[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.

[GitBox]

dweiss commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1257214001

   > oh, one question @dweiss, since javacc is upgraded, should we force a 
gradlew regenerate?
   
   Hmmm.. isn't javacc part of the checksum? It should regenerate itself when 
javacc is upgraded. If it's not then it's something that should be corrected 
there. I did run regenerate after updating stuff and it returns cleanly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.

[GitBox]

dweiss commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1257215252

   I re-ran javacc and the generated files just seem to be identical.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] dweiss merged pull request #11812: Upgrade several build dependencies.

[GitBox]

dweiss merged PR #11812:
URL: https://github.com/apache/lucene/pull/11812


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #11806: GITHUB#11728: Add a InterruptedCollector to received thread interrupt request and exit search task early

[GitBox]

uschindler commented on PR #11806:
URL: https://github.com/apache/lucene/pull/11806#issuecomment-1257216396

   This won't work when the thread is blocked on I/O (e.g. when it reads from 
IndexInput). Java has the behaviour to close file handles for safety when a 
thread doing IO was interrupted. When you use this collector the file handle 
might get closed.
   This won't negatively affect MMapDirectory (unless you interrupt at the time 
of opening the file), but all other implementations will fail.
   So we won't merge this. See also @rmuir 's comment in #11728.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] uschindler closed pull request #11806: GITHUB#11805: Add a InterruptedCollector to received thread interrupt request and exit search task early

[GitBox]

uschindler closed pull request #11806: GITHUB#11805: Add a InterruptedCollector 
to received thread interrupt request and exit search task early
URL: https://github.com/apache/lucene/pull/11806


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] uschindler commented on issue #11805: Add a InterruptedCollector to received thread interrupt request and exit search task early

[GitBox]

uschindler commented on issue #11805:
URL: https://github.com/apache/lucene/issues/11805#issuecomment-1257217007

   This won't work when the thread is blocked on I/O (e.g. when it reads from 
IndexInput). Java has the behaviour to close file handles for safety when a 
thread doing IO was interrupted. When you use this collector the file handle 
might get closed.
   This won't negatively affect MMapDirectory (unless you interrupt at the time 
of opening the file), but all other implementations will fail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] uschindler closed issue #11805: Add a InterruptedCollector to received thread interrupt request and exit search task early

[GitBox]

uschindler closed issue #11805: Add a InterruptedCollector to received thread 
interrupt request and exit search task early
URL: https://github.com/apache/lucene/issues/11805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] dweiss commented on pull request #11812: Upgrade several build dependencies.

[GitBox]

dweiss commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1257217466

   Sorry, I was wrong about javacc and possibly other tasks - I'll do a 
follow-up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] dweiss commented on pull request #11816: Dependency upgrades and regenerate (9x backport)

[GitBox]

dweiss commented on PR #11816:
URL: https://github.com/apache/lucene/pull/11816#issuecomment-1257223431

   I allow myself to merge this in without a review since it's an automatic 
update. Thanks to @rmuir for reminding me about the need for it. I'll have to 
think how to make this need more evident (make tool versions part of the 
checksum).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] dweiss merged pull request #11816: Dependency upgrades and regenerate (9x backport)

[GitBox]

dweiss merged PR #11816:
URL: https://github.com/apache/lucene/pull/11816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] dweiss commented on pull request #11817: Regenerate sources after dependency updates.

[GitBox]

dweiss commented on PR #11817:
URL: https://github.com/apache/lucene/pull/11817#issuecomment-1257224319

   I allow myself to merge this in without a review since it's an automatic 
update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] dweiss merged pull request #11817: Regenerate sources after dependency updates.

[GitBox]

dweiss merged PR #11817:
URL: https://github.com/apache/lucene/pull/11817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] risdenk commented on pull request #2671: Add sts support

[GitBox]

risdenk commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1257263160

   Thanks @joshsouza - I updated the branch you pushed to be based off of 
branch_8_11, add license and notice files, and add changes.txt. This just 
kicked off precommit as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] joshsouza commented on pull request #2671: Add sts support

[GitBox]

joshsouza commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1257263376

   Thank you so much!
   
   On Sun, Sep 25, 2022, 1:32 PM Kevin Risden ***@***.***> wrote:
   
   > Thanks @joshsouza  - I updated the branch
   > you pushed to be based off of branch_8_11, add license and notice files,
   > and add changes.txt. This just kicked off precommit as well.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] elliotzlin commented on pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix

[GitBox]

elliotzlin commented on PR #11724:
URL: https://github.com/apache/lucene/pull/11724#issuecomment-1257315679

   @dweiss can you help run the workflows again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] caohassl commented on issue #11805: Add a InterruptedCollector to received thread interrupt request and exit search task early

[GitBox]

caohassl commented on issue #11805:
URL: https://github.com/apache/lucene/issues/11805#issuecomment-1257428712

   hi, @uschindler  @rmuir 
   Thank you for reply
   
   Yes, we use the MMapDirectory implementation mainly, and Interrupted collect 
seems to work fine so far.  
   I‘m sorry for not considering other implementations 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] zhaih commented on a diff in pull request #11815: Support deletions in rearrange (#11814)

[GitBox]

zhaih commented on code in PR #11815:
URL: https://github.com/apache/lucene/pull/11815#discussion_r979581760


##
lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java:
##
@@ -175,5 +202,7 @@ public CacheHelper getReaderCacheHelper() {
   /** Select document within a CodecReader */
   public interface DocumentSelector {
 BitSet getFilteredLiveDocs(CodecReader reader) throws IOException;
+
+boolean isDeleted(LeafReader reader, int idx) throws IOException;

Review Comment:
   I think it is confusing to put this here:
   1. The first method `getFilteredLiveDocs` is basically from "original" 
index, generating a set of documents that will be pulled into the "new" index. 
But the new method is basically from "new" index, query whether a document is 
deleted. You see that they basically are supposed to be applied to different 
index and it is quite confusing.
   2. Given that this method are supposed to be applied to the "new" index, I 
would assume the creator will have some information on which documents are 
supposed to be deleted beforehand, like a set of ids that are deleted in the 
"origin" index. Then why don't we put this deletion logic after the rearrange 
has done? I don't see any advantage of putting the logic here. Also now the 
`writer.addIndexes` are subject to a lock which means we're slowing things down 
quite a lot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] zhaih commented on pull request #11780: GH#11601: Add ability to compute reader states after refresh

[GitBox]

zhaih commented on PR #11780:
URL: https://github.com/apache/lucene/pull/11780#issuecomment-1257538633

   How is it different from making a subclass/alternative of ReaderManager and 
just put the state calculation inside `refreshIfNeed`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org