[GitHub] [lucene] iverase commented on issue #11767: Does the method #cureLocalIntersections in the Tessellator make any sense?
iverase commented on issue #11767: URL: https://github.com/apache/lucene/issues/11767#issuecomment-1248999452 Then let's just skip that step if the tessellator is called with the flag `checkSelfIntersections` set to true. In that case it will fail before getting to this place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] janhoy commented on pull request #591: LUCENE-10365 Wizard changes contributed from Solr
janhoy commented on PR #591: URL: https://github.com/apache/lucene/pull/591#issuecomment-1249032346 I took the time to include also the remaining fixes from Solr wizard, please have a quick look at the last two commits: * [More Python fixes from the Solr 9 release](https://github.com/apache/lucene/pull/591/commits/677082577fe43c45ed74e569dac86b660d8b8798) * [Various yaml improvements from the Solr 9 release](https://github.com/apache/lucene/pull/591/commits/cdcd31656076d423ed2bd1dc1537323e1606df52) I did specifically *not* port over @HoustonPutman's script to stage maven artifacts (https://github.com/apache/solr/pull/807), as there seems to be an ongoing discussion on the route Lucene wants to take here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] janhoy commented on issue #11401: releaseWizard improvements from the Solr 9.0 release [LUCENE-10365]
janhoy commented on issue #11401: URL: https://github.com/apache/lucene/issues/11401#issuecomment-1249036921 @mocobeta This issue references https://github.com/apache/lucene/pull/591 but I cannot find any back-link over in the PR that points back to this issue. I'm sure that this comment will add a ref to the PR, but I'd expect something from the 23rd of August? We should probably adapt a workflow where we include "Fixes #xxx" in the commit-message of PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on a diff in pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix
dweiss commented on code in PR #11724:
URL: https://github.com/apache/lucene/pull/11724#discussion_r972866335
##
lucene/analysis/common/src/test/org/apache/lucene/analysis/charfilter/TestHTMLStripCharFilter.java:
##
@@ -632,6 +635,22 @@ public void testUTF16Surrogates() throws Exception {
analyzer.close();
}
+ /**
+ * Test that attributes with '>' or '<' characters are parsed correctly.
Review Comment:
```suggestion
* Test that attributes with {@code '>'} or {@code '<'} characters are
parsed correctly.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mocobeta commented on issue #11401: releaseWizard improvements from the Solr 9.0 release [LUCENE-10365]
mocobeta commented on issue #11401: URL: https://github.com/apache/lucene/issues/11401#issuecomment-1249216366 > I cannot find any back-link over in the PR that points back to this issue. Yes because the issue migration Jira to GitHub didn't touch any existing PRs. > We should probably adapt a workflow where we include "Fixes #xxx" in the commit-message of PRs. I noticed some people already use "Fixes #xxx" or "Closes #xxx" tips. I'm not so sure if we should/can make people obey any extra rules, but please feel free to propose/proceed with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] janhoy commented on issue #11401: releaseWizard improvements from the Solr 9.0 release [LUCENE-10365]
janhoy commented on issue #11401: URL: https://github.com/apache/lucene/issues/11401#issuecomment-1249254579 > Yes because the issue migration Jira to GitHub didn't touch any existing PRs. The MR was not changed, but in the 9 jan comment the asfimport bot reference the linked PR, without it being reflected on the PR. But when I mentioned the PR manually we got the backlink in the PR itself. > I'm not so sure if we should/can make people obey any extra rules These would not be rules. If folks want to close issues manually that's ok, just as we did with JIRA. But some devs may not be familiar with the commit-msg syntax to do it automatically. A hint in docs could point them in the right direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mocobeta commented on issue #11401: releaseWizard improvements from the Solr 9.0 release [LUCENE-10365]
mocobeta commented on issue #11401: URL: https://github.com/apache/lucene/issues/11401#issuecomment-1249301935 Sure, I understand "Fixes" comment is sometimes useful, and I often use it for convenience. If it is not a rule but a tip, I hope people learn it from their experiences or teach it to each other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mocobeta commented on issue #11401: releaseWizard improvements from the Solr 9.0 release [LUCENE-10365]
mocobeta commented on issue #11401: URL: https://github.com/apache/lucene/issues/11401#issuecomment-1249307982 I'll make backlinks from PRs to Issues when I have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #1068: LUCENE-10674: Ensure BitSetConjDISI returns NO_MORE_DOCS when sub-iterator exhausts
jpountz commented on PR #1068: URL: https://github.com/apache/lucene/pull/1068#issuecomment-1249477900 @jmazanec15 FYI I backported this change to 9.4, so it should be in the next release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #1068: LUCENE-10674: Ensure BitSetConjDISI returns NO_MORE_DOCS when sub-iterator exhausts
jpountz commented on PR #1068: URL: https://github.com/apache/lucene/pull/1068#issuecomment-1249481566 @jmazanec15 Maybe one thing I'd like to double check: what is the query that created a DocIdSetBuilder with a length that is less than `maxDoc`? Is it a Lucene Query or a custom query of your own? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] danmuzi merged pull request #11779: GITHUB#11778: Add detailed part-of-speech tag for particle and ending on Nori
danmuzi merged PR #11779: URL: https://github.com/apache/lucene/pull/11779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] danmuzi closed issue #11778: add detailed part-of-speech tag for particle and ending on Nori
danmuzi closed issue #11778: add detailed part-of-speech tag for particle and ending on Nori URL: https://github.com/apache/lucene/issues/11778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] danmuzi commented on pull request #11779: GITHUB#11778: Add detailed part-of-speech tag for particle and ending on Nori
danmuzi commented on PR #11779: URL: https://github.com/apache/lucene/pull/11779#issuecomment-1249520640 > looks like a good change to me. it is better to just use the POS that we hae and not "collapse" into very generic tags. Thank you for your review! @rmuir -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
