[GitHub] [lucene] romseygeek merged pull request #11762: Removed duplicate check in SpanGradientFormatter
romseygeek merged PR #11762: URL: https://github.com/apache/lucene/pull/11762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] kotman12 opened a new issue, #11771: KeywordRepeatFilter + OpenNLPLLemmatizer Early Exit
kotman12 opened a new issue, #11771: URL: https://github.com/apache/lucene/issues/11771 ### Description KeywordRepeatFilter + OpenNLPLLemmatizer leads to arbitrarily early exit of token stream. Steps to reproduce: run this [test](https://github.com/kotman12/lucene/blob/illustrate-bug/lucene/analysis/opennlp/src/test/org/apache/lucene/analysis/opennlp/TestOpenNLPLemmatizerFilterFactory.java#L324) and notice how no text below [this line from the test file](https://github.com/kotman12/lucene/blob/illustrate-bug/lucene/analysis/opennlp/src/test-files/org/apache/lucene/analysis/opennlp/data/early-exit-bug-input.txt#L20) gets analyzed. The root cause appears to be [an extraneous exit condition](https://github.com/kotman12/lucene/blob/illustrate-bug/lucene/analysis/opennlp/src/java/org/apache/lucene/analysis/opennlp/OpenNLPLemmatizerFilter.java#L75) that doesn't play nicely with KeywordRepeatFilter. This is related to the bug #11735 and is addressed by #11734 ### Version and environment details latest version of lucene running jdk-17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11766: Retry gradle wrapper download on http 500 and 503.
rmuir commented on PR #11766: URL: https://github.com/apache/lucene/pull/11766#issuecomment-1246912736 @dweiss we haven't seen any issues from this commit in jenkins, should be backport to 9.x branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir opened a new issue, #11772: remove WindowsDirectory
rmuir opened a new issue, #11772: URL: https://github.com/apache/lucene/issues/11772 ### Description Having native code complicates the gradle build and causes bugs. The Direct-IO directory no longer needs native code, it uses JDK APIs. So the only thing left is WindowsDirectory. I'm not sure this thing is really faster than the JDK. If i remember, the synchronization that causes the issues was in windows. Honestly, users should use MmapDirectory on windows IMO. So maybe net/net it is better for our windows support to remove this thing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11766: Retry gradle wrapper download on http 500 and 503.
dweiss commented on PR #11766: URL: https://github.com/apache/lucene/pull/11766#issuecomment-1246965355 Darn, I've cherry picked it on branch_9x but didn't push the changes. I've rebased it now and pushed. Sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on issue #11772: remove WindowsDirectory
dweiss commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246968550 I've no idea who uses this thing but I'm open to removing this - it does complicate things a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11772: remove WindowsDirectory
uschindler commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246968656 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #11772: remove WindowsDirectory
rmuir commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246969693 I kinda feel that going forwards, we would not do things this way with C code, but instead look to use the new FFI interfaces being added to openjdk if we really need to call native stuff... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on issue #11772: remove WindowsDirectory
dweiss commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246971638 If there are no objections, I'll handle the removal - there are some gradle scripts involved there that will also benefit from the cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11772: remove WindowsDirectory
uschindler commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246972037 Project Panama is the way to go, no need for FFI or anything like that. You can create a MethodHandle that downcalls into libc/kernel.dll. I have an example in some talk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11772: remove WindowsDirectory
uschindler commented on issue #11772:
URL: https://github.com/apache/lucene/issues/11772#issuecomment-1246993380
This is how to call `getpid()` with Java 19 (you need to enable preview APIS
and also enable access to native code (disabled for secuirty by default):
```java
var cLinker = Linker.nativeLinker();
// Using a MethodHandle
MethodHandle getpidMH =
cLinker.downcallHandle(cLinker.defaultLookup().lookup("getpid").get(),
FunctionDescriptor.of(JAVA_INT));
int pid= (int) getpidMH.invokeExact();
System.out.printf("MethodHandle calling getpid() (%d)\n", pid);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #11772: remove WindowsDirectory
rmuir commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1247019862 yeah, sorry when i said FFI i meant panama (its an FFI to me). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on issue #11772: remove WindowsDirectory
dweiss commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1247202311 That's pretty neat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mdmarshmallow commented on pull request #11729: LUCENE-11728: Improve code clarity for OrdinalMap
mdmarshmallow commented on PR #11729: URL: https://github.com/apache/lucene/pull/11729#issuecomment-1247251315 Removed some of the comments that were maybe just paraphrasing the code too much. I also renamed some variables to what I think are more clear names. Hopefully the comments/variable names make more sense now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] LuXugang opened a new issue, #11773: Could `PointRangeQuery`'s boundary values used for `NumericComparator` to calculate `estimatedNumberOfMatches`
LuXugang opened a new issue, #11773: URL: https://github.com/apache/lucene/issues/11773 ### Description Now when we do TopK search, we could rebuild `DocIdSetIterator` to reduce candidate docs since [LUCENE-9280](https://issues.apache.org/jira/browse/LUCENE-9280) . One condition of rebuilding `DocIdSetIterator` is that it must reduce number of docs at least 8x. But when we do TopK search by `PointRangeQuery`, it's `estimatedNumberOfMatches` contains some docs which are out of boundaries.Could we take advantage of range query's boundary values to make this condition much more easier to achieve？ Since [LUCENE-10620](https://issues.apache.org/jira/browse/LUCENE-10620) we pass `Weight` to `Collecter`, it might be able to do this optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] tang-hi commented on issue #11770: Optimization for time series data
tang-hi commented on issue #11770: URL: https://github.com/apache/lucene/issues/11770#issuecomment-1247622672 Hi,LuXugang. I have roughly read that paper. And I think it has a lot of interesting optimizations for lucene. I' m really interested about **the reverse binary search algorithm for tail queries** which was mentioned in paper,although I am not quite familiar with lucene's query implmentation😭. Could you tell me which lucene's files should I read, so I could implement that algorithm? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11774: GH-1172: remove WindowsDirectory and native subproject.
dweiss commented on PR #11774: URL: https://github.com/apache/lucene/pull/11774#issuecomment-1247630649 Fixes #11772. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on issue #11772: remove WindowsDirectory
dweiss commented on issue #11772: URL: https://github.com/apache/lucene/issues/11772#issuecomment-1247631506 We should apply this to main, but I think there's no harm to backport to 9.x, right? It's not a stable API and there is a safe replacement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
