[GitHub] [lucene] asfimport opened a new issue, #1070: Test issue by bot
asfimport opened a new issue, #1070: URL: https://github.com/apache/lucene/issues/1070 Hello world -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mocobeta closed issue #1070: Test issue by bot
mocobeta closed issue #1070: Test issue by bot URL: https://github.com/apache/lucene/issues/1070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] LuXugang commented on a diff in pull request #1062: Optimize TermInSetQuery for terms that match all docs in a segment
LuXugang commented on code in PR #1062:
URL: https://github.com/apache/lucene/pull/1062#discussion_r946845549
##
lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java:
##
@@ -363,6 +370,29 @@ public boolean isCacheable(LeafReaderContext ctx) {
// sets.
return ramBytesUsed() <=
RamUsageEstimator.QUERY_DEFAULT_RAM_BYTES_USED;
}
+
+ static final class MatchAllDocIdSet extends DocIdSet {
+private final int size;
Review Comment:
Hi @gsmiller , I saw there was already an `EMPTY` implementation in class
`DocIdSet `, and this implementation is commonly useful, should we move this
implementation to class `DocIdSet ` and name it like `all` or the other name ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] Yuti-G commented on pull request #1013: LUCENE-10644: Facets#getAllChildren testing should ignore child order
Yuti-G commented on PR #1013: URL: https://github.com/apache/lucene/pull/1013#issuecomment-1216920178 Hi @gsmiller, thanks for your previous review, and I have applied the changes to all the `getAllChildren` tests. Would you please help me take another look whenever you have time? Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
