[GitHub] [lucene-jira-archive] mocobeta closed issue #127: Consider using GitHub Pages for attachments rather than raw.githubusercontent.com

2022-08-12 Thread GitBox


mocobeta closed issue #127: Consider using GitHub Pages for attachments rather 
than raw.githubusercontent.com
URL: https://github.com/apache/lucene-jira-archive/issues/127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #144: Links to Jira issue comments are not converted to GitHub issue comments

2022-08-12 Thread GitBox


mocobeta opened a new issue, #144:
URL: https://github.com/apache/lucene-jira-archive/issues/144

   We convert Jira cross-issue links (LUCENE-) to GitHub issue links (#NN).
   However, links to Jira comments are not converted into GitHub comments since 
we don't have a mapping from Jira comment id to GitHub comment id.
   
   Original Jira:
   
https://issues.apache.org/jira/browse/LUCENE-9414?focusedCommentId=17142414&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17142414
   ![Screenshot from 2022-08-12 
18-20-57](https://user-images.githubusercontent.com/1825333/184325023-eaba1a07-dfee-4e5e-a6c8-54551f806bd8.png)
   
   Migrated issue:
   
https://github.com/mocobeta/forks-migration-test-3/issues/9378#issuecomment-1211440645
   ![Screenshot from 2022-08-12 
18-23-00](https://user-images.githubusercontent.com/1825333/184325424-1e0aa7a7-6198-4450-b7d3-f97431f65044.png)
   
   Creating a mapping for comments is not a trivial task (GitHub import API 
does not return the comment ids).
   Links to comments are relatively rare, I think we can leave this unresolved. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] rmuir commented on pull request #1057: LUCENE-10670: Add a codec class to track merge time of each index part

2022-08-12 Thread GitBox


rmuir commented on PR #1057:
URL: https://github.com/apache/lucene/pull/1057#issuecomment-1212962044

   dude, that's nothing compared to the cost of disabling bulk merge, which 
will also force all stored fields to be recompressed every merge as well.
   
   sorry, i'm completely against this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mikemccand opened a new pull request, #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145

   I made a few possible polish edits for the INFRA instructions, plus one 
question.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mikemccand commented on code in PR #145:
URL: 
https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944368903


##
migration/instructions-for-infra-team.md:
##
@@ -77,17 +77,19 @@ JiraKey,GitHubUrl,GitHubNumber
 LUCENE-1,https://github.com/apache/lucene/issues/1080,1080
 ```
 
+Peek at the issue through GitHub and confirm it was imported and looks 
reasonable.
+
 ### Clean up the test data
 
-Once the test is done, please delete `mapping-data/issue-map.csv` file and the 
imported issue (only admin accounts can delete an issue) before the actual 
migration.
+Once the test is done, please delete `mapping-data/issue-map.csv` local file 
and the imported issue through GitHub (only admin accounts can delete an issue) 
before the actual migration.
 
 ## Run the import script
 
-Please specify the `min` option to 1 and `max` option to the maximum number of 
the Lucene Jira issue, that will be known by then.
+Please specify the `min` option to 1 and `max` option to the maximum number of 
the Lucene Jira issue, that will be known by then (how?  based on the un-tgz'd 
GitHub import data?  or maybe you/we will communicate this number to them?  if 
so, let's say that above?)

Review Comment:
   Here I thought we should explicitly state that we will tell them the max id?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mocobeta commented on code in PR #145:
URL: 
https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944385229


##
migration/instructions-for-infra-team.md:
##
@@ -77,17 +77,19 @@ JiraKey,GitHubUrl,GitHubNumber
 LUCENE-1,https://github.com/apache/lucene/issues/1080,1080
 ```
 
+Peek at the issue through GitHub and confirm it was imported and looks 
reasonable.
+
 ### Clean up the test data
 
-Once the test is done, please delete `mapping-data/issue-map.csv` file and the 
imported issue (only admin accounts can delete an issue) before the actual 
migration.
+Once the test is done, please delete `mapping-data/issue-map.csv` local file 
and the imported issue through GitHub (only admin accounts can delete an issue) 
before the actual migration.
 
 ## Run the import script
 
-Please specify the `min` option to 1 and `max` option to the maximum number of 
the Lucene Jira issue, that will be known by then.
+Please specify the `min` option to 1 and `max` option to the maximum number of 
the Lucene Jira issue, that will be known by then (how?  based on the un-tgz'd 
GitHub import data?  or maybe you/we will communicate this number to them?  if 
so, let's say that above?)

Review Comment:
   Thanks for reviewing it.
   This is the only part we cannot determine yet, I will replace the `` with the concrete number after taking the Jira snapshot to avoid 
miscommunication.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on a diff in pull request #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mikemccand commented on code in PR #145:
URL: 
https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944386278


##
migration/instructions-for-infra-team.md:
##
@@ -77,17 +77,19 @@ JiraKey,GitHubUrl,GitHubNumber
 LUCENE-1,https://github.com/apache/lucene/issues/1080,1080
 ```
 
+Peek at the issue through GitHub and confirm it was imported and looks 
reasonable.
+
 ### Clean up the test data
 
-Once the test is done, please delete `mapping-data/issue-map.csv` file and the 
imported issue (only admin accounts can delete an issue) before the actual 
migration.
+Once the test is done, please delete `mapping-data/issue-map.csv` local file 
and the imported issue through GitHub (only admin accounts can delete an issue) 
before the actual migration.
 
 ## Run the import script
 
-Please specify the `min` option to 1 and `max` option to the maximum number of 
the Lucene Jira issue, that will be known by then.
+Please specify the `min` option to 1 and `max` option to the maximum number of 
the Lucene Jira issue, that will be known by then (how?  based on the un-tgz'd 
GitHub import data?  or maybe you/we will communicate this number to them?  if 
so, let's say that above?)

Review Comment:
   Oh I see, `` means "we will fill this in before we hand off 
these instructions to INFRA on the actual day of migration", OK.  I'll try to 
word that in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mocobeta commented on code in PR #145:
URL: 
https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944395455


##
migration/instructions-for-infra-team.md:
##
@@ -35,7 +35,7 @@ GH-LUCENE-10677.json
 # set the GitHub PAT token to an env variable
 migration $ cp .env.example .env
 migration $ vi .env
-export GITHUB_PAT=
+export GITHUB_PAT=

Review Comment:
   Note: `asfbot` is my proposal/request to infra. I think we are still not 
fully sure what account will be used, but fine with this for now. I'll make 
sure of the correct account information.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mocobeta commented on code in PR #145:
URL: 
https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944395455


##
migration/instructions-for-infra-team.md:
##
@@ -35,7 +35,7 @@ GH-LUCENE-10677.json
 # set the GitHub PAT token to an env variable
 migration $ cp .env.example .env
 migration $ vi .env
-export GITHUB_PAT=
+export GITHUB_PAT=

Review Comment:
   Note: `asfbot` is my proposal/request. I think we are still not fully sure 
what account will be used, but fine with this for now. I'll make sure of the 
correct account information.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mocobeta commented on code in PR #145:
URL: 
https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944395455


##
migration/instructions-for-infra-team.md:
##
@@ -35,7 +35,7 @@ GH-LUCENE-10677.json
 # set the GitHub PAT token to an env variable
 migration $ cp .env.example .env
 migration $ vi .env
-export GITHUB_PAT=
+export GITHUB_PAT=

Review Comment:
   Note: `asfgit` is my proposal/request. I think we are still not fully sure 
what account will be used, but fine with this for now. I'll make sure of the 
correct account information.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mocobeta commented on code in PR #145:
URL: 
https://github.com/apache/lucene-jira-archive/pull/145#discussion_r944408114


##
migration/instructions-for-infra-team.md:
##
@@ -77,17 +77,19 @@ JiraKey,GitHubUrl,GitHubNumber
 LUCENE-1,https://github.com/apache/lucene/issues/1080,1080
 ```
 
+Peek at the issue through GitHub and confirm it was imported and looks 
reasonable.
+
 ### Clean up the test data
 
-Once the test is done, please delete `mapping-data/issue-map.csv` file and the 
imported issue (only admin accounts can delete an issue) before the actual 
migration.
+Once the test is done, please delete `mapping-data/issue-map.csv` local file 
and the imported issue through GitHub (only admin accounts can delete an issue) 
before the actual migration.
 
 ## Run the import script
 
-Please specify the `min` option to 1 and `max` option to the maximum number of 
the Lucene Jira issue, that will be known by then.
+Please specify the `min` option to 1 and `max` option to the maximum number of 
the Lucene Jira issue, that will be known by then (how?  based on the un-tgz'd 
GitHub import data?  or maybe you/we will communicate this number to them?  if 
so, let's say that above?)

Review Comment:
   Thank you very much!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand merged pull request #145: Polish INFRA instructions a bit

2022-08-12 Thread GitBox


mikemccand merged PR #145:
URL: https://github.com/apache/lucene-jira-archive/pull/145


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] msokolov commented on pull request #1057: LUCENE-10670: Add a codec class to track merge time of each index part

2022-08-12 Thread GitBox


msokolov commented on PR #1057:
URL: https://github.com/apache/lucene/pull/1057#issuecomment-1213141620

   Thanks for helping out here, @rmuir - can you explain how it is that bulk 
operations would be prevented by this change? I don't really understand, but 
maybe if you explained we could figure out what to do about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #104: Should we regenerate another full export?

2022-08-12 Thread GitBox


mocobeta commented on issue #104:
URL: 
https://github.com/apache/lucene-jira-archive/issues/104#issuecomment-1213212384

   I checked several issues from new to old. I see no degradations from the 
previous one.
   
   If you are okay with that, the actual migration will be the same as this 
except for the issue reporter and assignees (the issue reporter should be an 
ASF bot account and assignees should be correctly set).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand closed issue #104: Should we regenerate another full export?

2022-08-12 Thread GitBox


mikemccand closed issue #104: Should we regenerate another full export?
URL: https://github.com/apache/lucene-jira-archive/issues/104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mikemccand commented on issue #104: Should we regenerate another full export?

2022-08-12 Thread GitBox


mikemccand commented on issue #104:
URL: 
https://github.com/apache/lucene-jira-archive/issues/104#issuecomment-1213220222

   +1, let's close this, yay!!  Thank you @mocobeta!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #104: Should we regenerate another full export?

2022-08-12 Thread GitBox


mocobeta commented on issue #104:
URL: 
https://github.com/apache/lucene-jira-archive/issues/104#issuecomment-1213225632

   Thank you, please open reports if you notice anything. I think we still have 
some time for small improvements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #93: Too much text is quoted

2022-08-12 Thread GitBox


mocobeta commented on issue #93:
URL: 
https://github.com/apache/lucene-jira-archive/issues/93#issuecomment-1213246144

   Incorrect quotes are misleading. I'd like to manage to address this...
   
   I think it is difficult to correctly insert line feeds like this.
   
   > EG running merges (or any still-open files) should not be sync'd.
   
   Files that are still being written should not be synced, that's kinda 
obvious.
   
   --
   
   Meanwhile, escaping `>` with `>` would be easy and safe I think.
   
   > EG running merges (or any still-open files) should not be sync'd.
   Files that are still being written should not be synced, that's kinda 
obvious.
   
   I already did it for [XML/HTML tag-like 
strings](https://github.com/apache/lucene-jira-archive/pull/32/files), and the 
tweak works fine; will try to apply the same fix for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] nknize merged pull request #1066: LUCENE-10654: Fix Shape Bounding Box Inconsistencies

2022-08-12 Thread GitBox


nknize merged PR #1066:
URL: https://github.com/apache/lucene/pull/1066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-10654) New companion doc value format for LatLonShape and XYShape field types

2022-08-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579030#comment-17579030
 ] 

ASF subversion and git services commented on LUCENE-10654:
--

Commit 543910d9008e714016db8a799058860b8ece5565 in lucene's branch 
refs/heads/main from Nick Knize
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=543910d9008 ]

LUCENE-10654: Fix ShapeDocValue Bounding Box failure (#1066)

The base spatial test case may create invalid self crossing polygons. These
polygons are cleaned by the tessellator which may result in an inconsistent
bounding box between the tessellated shape and the original, invalid, geometry.
This commit fixes the shape doc value test case to compute the bounding box from
the cleaned geometry instead of relying on the, potentially invalid, original
geometry.

Signed-off-by: Nicholas Walter Knize 

> New companion doc value format for LatLonShape and XYShape field types
> --
>
> Key: LUCENE-10654
> URL: https://issues.apache.org/jira/browse/LUCENE-10654
> Project: Lucene - Core
>  Issue Type: New Feature
>Reporter: Nick Knize
>Priority: Major
> Fix For: 9.4
>
>  Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> {{XYDocValuesField}} provides doc value support for {{XYPoint}}. 
> {{LatLonDocValuesField}} provides docvalue support for {{LatLonPoint}}.
> However, neither {{LatLonShape}} nor {{XYShape}} currently have a docvalue 
> format. 
> This lack of doc value support for shapes means facets, aggregations, and 
> IndexOrDocValues queries are currently not possible for Shape field types. 
> This gap needs be closed in lucene.
> To support IndexOrDocValues queries along with various geometry aggregations 
> and facets, the ability to compute the spatial relation with the doc value is 
> needed. This is straightforward with {{XYPoint}} and {{LatLonPoint}} since 
> the doc value encoding is nothing more than a simple 2D integer encoding of 
> the x,y and lat,lon dimensional components. Accomplishing the same with a 
> naive integer encoded binary representation for N-vertex shapes would be 
> costly. 
> {{ComponentTree}} already provides an efficient in memory structure for 
> quickly computing spatial relations over Shape types based on a binary tree 
> of tessellated triangles provided by the {{Tessellator}}. Furthermore, this 
> tessellation is already computed at index time. If we create an on-disk 
> representation of {{ComponentTree}} 's binary tree of tessellated triangles 
> and use this as the doc value {{binaryValue}} format we will be able to 
> efficiently compute spatial relations with this binary representation and 
> achieve the same facet/aggregation result over shapes as we can with points 
> today (e.g., grid facets, centroid, area, etc).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] nknize opened a new pull request, #1067: LUCENE-10654: Fix ShapeDocValue Bounding Box failure (#1066)

2022-08-12 Thread GitBox


nknize opened a new pull request, #1067:
URL: https://github.com/apache/lucene/pull/1067

   Backport of #1066 to 9x
   
   The base spatial test case may create invalid self crossing polygons. These
   polygons are cleaned by the tessellator which may result in an inconsistent
   bounding box between the tessellated shape and the original, invalid, 
geometry.
   This commit fixes the shape doc value test case to compute the bounding box 
from
   the cleaned geometry instead of relying on the, potentially invalid, original
   geometry.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene] nknize merged pull request #1067: LUCENE-10654: Fix ShapeDocValue Bounding Box failure (#1066)

2022-08-12 Thread GitBox


nknize merged PR #1067:
URL: https://github.com/apache/lucene/pull/1067


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[jira] [Commented] (LUCENE-10654) New companion doc value format for LatLonShape and XYShape field types

2022-08-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/LUCENE-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579057#comment-17579057
 ] 

ASF subversion and git services commented on LUCENE-10654:
--

Commit 923a9f800aef4f376eb1978c02e94ca6bacc5a5a in lucene's branch 
refs/heads/branch_9x from Nick Knize
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=923a9f800ae ]

LUCENE-10654: Fix ShapeDocValue Bounding Box failure (#1066) (#1067)

The base spatial test case may create invalid self crossing polygons. These
polygons are cleaned by the tessellator which may result in an inconsistent
bounding box between the tessellated shape and the original, invalid, geometry.
This commit fixes the shape doc value test case to compute the bounding box from
the cleaned geometry instead of relying on the, potentially invalid, original
geometry.

Signed-off-by: Nicholas Walter Knize 

> New companion doc value format for LatLonShape and XYShape field types
> --
>
> Key: LUCENE-10654
> URL: https://issues.apache.org/jira/browse/LUCENE-10654
> Project: Lucene - Core
>  Issue Type: New Feature
>Reporter: Nick Knize
>Priority: Major
> Fix For: 9.4
>
>  Time Spent: 8h
>  Remaining Estimate: 0h
>
> {{XYDocValuesField}} provides doc value support for {{XYPoint}}. 
> {{LatLonDocValuesField}} provides docvalue support for {{LatLonPoint}}.
> However, neither {{LatLonShape}} nor {{XYShape}} currently have a docvalue 
> format. 
> This lack of doc value support for shapes means facets, aggregations, and 
> IndexOrDocValues queries are currently not possible for Shape field types. 
> This gap needs be closed in lucene.
> To support IndexOrDocValues queries along with various geometry aggregations 
> and facets, the ability to compute the spatial relation with the doc value is 
> needed. This is straightforward with {{XYPoint}} and {{LatLonPoint}} since 
> the doc value encoding is nothing more than a simple 2D integer encoding of 
> the x,y and lat,lon dimensional components. Accomplishing the same with a 
> naive integer encoded binary representation for N-vertex shapes would be 
> costly. 
> {{ComponentTree}} already provides an efficient in memory structure for 
> quickly computing spatial relations over Shape types based on a binary tree 
> of tessellated triangles provided by the {{Tessellator}}. Furthermore, this 
> tessellation is already computed at index time. If we create an on-disk 
> representation of {{ComponentTree}} 's binary tree of tessellated triangles 
> and use this as the doc value {{binaryValue}} format we will be able to 
> efficiently compute spatial relations with this binary representation and 
> achieve the same facet/aggregation result over shapes as we can with points 
> today (e.g., grid facets, centroid, area, etc).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #146: Escape '>' to avoid wrong quotes in markdown

2022-08-12 Thread GitBox


mocobeta opened a new pull request, #146:
URL: https://github.com/apache/lucene-jira-archive/pull/146

   #93 
   
   `>` should be escaped 1) if it appears at the end of the line, and also 2) 
is not a part of any expression grammar. It's possible to do such selective 
escape by tweaking the syntax parser a bit.
   
   e.g.,
   
https://github.com/mocobeta/forks-migration-test/issues/2321#issuecomment-1197365531
   ![Screenshot from 2022-08-13 
13-09-09](https://user-images.githubusercontent.com/1825333/184467914-78bc6989-ed4e-4154-b97b-851f425d7ce2.png)
   
   should be
   
https://github.com/mocobeta/migration-test-3/issues/598#issuecomment-1213646156
   ![Screenshot from 2022-08-13 
13-09-59](https://user-images.githubusercontent.com/1825333/184467936-119e2c32-a56f-43eb-9c4f-3046b01202df.png)
   
   Note that this is applied only to plain texts without markups so that it 
does not affect on code blocks like this: 
https://github.com/mocobeta/migration-test-3/issues/601.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org



[GitHub] [lucene-jira-archive] mocobeta commented on issue #93: Too much text is quoted

2022-08-12 Thread GitBox


mocobeta commented on issue #93:
URL: 
https://github.com/apache/lucene-jira-archive/issues/93#issuecomment-1213650299

   I opened workaround PR #146.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org