[GitHub] [lucene-jira-archive] ovalhub opened a new pull request, #71: Update account-map.csv.20220722.verified
ovalhub opened a new pull request, #71: URL: https://github.com/apache/lucene-jira-archive/pull/71 Added mapping for va...@apache.org -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #71: Update account-map.csv.20220722.verified
mocobeta merged PR #71: URL: https://github.com/apache/lucene-jira-archive/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on pull request #71: Update account-map.csv.20220722.verified
mocobeta commented on PR #71: URL: https://github.com/apache/lucene-jira-archive/pull/71#issuecomment-1193261692 Thank you @ovalhub -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?
mikemccand commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193281812 Thanks @mocobeta ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #70: {{ X }} did not convert to backticks correctly?
mikemccand commented on issue #70: URL: https://github.com/apache/lucene-jira-archive/issues/70#issuecomment-1193281961 OK weird but this is likely rare so let's do nothing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand closed issue #70: {{ X }} did not convert to backticks correctly?
mikemccand closed issue #70: {{ X }} did not convert to backticks correctly?
URL: https://github.com/apache/lucene-jira-archive/issues/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #70: {{ X }} did not convert to backticks correctly?
mikemccand commented on issue #70: URL: https://github.com/apache/lucene-jira-archive/issues/70#issuecomment-1193282048 Thanks for explaining it @mocobeta. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #61: Should we carry over Jira "labels"?
mocobeta commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193285953 > But I think that is Search problem. And what we consider noise might be signal to people. Maybe people want to search for bugs related to `jvm` and they want `jvm bugs` to also search labels. We also should not try to judge noise vs signal in the search experience I feel. I agree with you. I've been playing around with GitHub issue search recently; I feel the result ranking is not very intuitive and there is room to be improved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #61: Should we carry over Jira "labels"?
mocobeta commented on issue #61:
URL:
https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193286815
Well, GitHub search result is not ranked by relevancy ("newest" sort is the
default).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?
mikemccand commented on issue #61:
URL:
https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193287224
> Well, GitHub search result is not ranked by relevancy ("newest" sort is
the default).
Ugh LOL. Maybe it will improve with time? If only it were open-source! I
wonder if it uses Lucene ;)
We always have [jirasearch](https://jirasearch.mikemccandless.com)! Except
I still have to cut it over to GitHub. And maybe rename it heh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?
mikemccand commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193287560 > There are some Jira metadata that are not ported at all to GitHub labels such as `Priority`, `Resolution`, `Lucene Fields`. Thanks @mocobeta. I've been looking at `Resolution` -- I think it has less noisy and still helpful metadata. I'll open a separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #72: Should we migrate Legacy Jira Resolution?
mikemccand opened a new issue, #72:
URL: https://github.com/apache/lucene-jira-archive/issues/72
Spinoff of #61.
I think Resolution has value. I wrote a quick Python script to count/sort
them across all Jira issues:
```
import os
import glob
import json
with_resolution_count = 0
count = 0
resolution_count = {}
for file_name in glob.glob('jira-dump/*.json'):
d = json.load(open(file_name))
count += 1
resolution = d["fields"]["resolution"]
if resolution is not None and len(resolution) > 0:
with_resolution_count += 1
#print(f'{file_name}: labels {labels}')
name = resolution['name']
resolution_count[name] = 1+resolution_count.get(name, 0)
print(f'{with_resolution_count} resolution out of {count}')
for name, count in sorted(resolution_count.items(), key=lambda a: -a[1]):
print(f'{name} {count}')
```
Result:
```
Fixed 7180
Won't Fix 534
Duplicate 297
Invalid 218
Not A Problem 195
Incomplete 98
Cannot Reproduce 40
Implemented 29
Done 18
Later 17
Abandoned 17
Won't Do 14
Resolved 13
Not A Bug 10
Workaround 8
Information Provided 6
Pending Closed 2
Works for Me 1
Auto Closed 1
Staged 1
```
Maybe we could add `legacy-jira-resolution:X`? E.g. searching for
`IndexWriter locking` and then drilling down on issues that were marked as
`Fixed` or `Won't Fix`.
I can imagine Search use-cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #60: Invalid unicode character in conversion of comment
mikemccand commented on issue #60: URL: https://github.com/apache/lucene-jira-archive/issues/60#issuecomment-1193288954 Sorry, I erased and regenerated my repo, breaking the above comment link. It is now [here](https://github.com/mikemccand/stargazers-migration-test/issues/329#issuecomment-1193207785). This is the original content from Jira: ``` "body": "Patch is available but it involves a binary file change.\u0010\r\nSo no easy to review and not easy to check with different OS", ``` I'm not yet sure exactly how that `\u0010` is supposed to be interpreted -- is that hex or decimal in JSON strings? I'll try to dig and see whether other Jira-exported issues use unicode escapes like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #60: Invalid unicode character in conversion of comment
mikemccand commented on issue #60: URL: https://github.com/apache/lucene-jira-archive/issues/60#issuecomment-1193290388 > I'm not yet sure exactly how that `\u0010` is supposed to be interpreted - OK it looks like [it is hexadecimal](https://tools.ietf.org/id/draft-ietf-json-rfc4627bis-09.html#rfc.section.7), so `\u0010` is this [exotic control character](https://www.fileformat.info/info/unicode/char/0010/index.htm). I'm not sure why it was not recognized, exotic though it be, on import, and converted to `U+FFFD` (the [fallback Unicode Replacement Character](https://www.fileformat.info/info/unicode/char/fffd/index.htm) when something goes wrong in decoding Unicode). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #60: Invalid unicode character in conversion of comment
mikemccand commented on issue #60: URL: https://github.com/apache/lucene-jira-archive/issues/60#issuecomment-1193291103 Indeed, I can see that we converted it "correctly" (preserving the U+0010 character): ``` "body": "Patch is available but it involves a binary file change.\u0010\nSo no easy to review and not easy to check with different OS\n\n[Legacy Jira: Alessandro Benedetti (@alessandrobenedetti) on [May 23 2018](https://issues.apache.org/jira/browse/LUCENE-8329?focusedCommentId=16487052&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16487052)]\n", ``` Maybe GitHub's import API does not allow "exotic" (yet, correctly encoded) Unicode characters and remaps some of them to U+FFFD? I tried searching for � LOL in GitHub's search but it matches nothing. I guess they do not index that character as a separate token ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #60: Invalid unicode character in conversion of comment
mikemccand commented on issue #60: URL: https://github.com/apache/lucene-jira-archive/issues/60#issuecomment-1193291357 Let's see what happens if I try to add this character myself: Patch is available but it involves a binary file change. So no easy to review and not easy to check with different OS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #60: Invalid unicode character in conversion of comment
mikemccand commented on issue #60: URL: https://github.com/apache/lucene-jira-archive/issues/60#issuecomment-1193291405 Whoa, indeed, even if you try to enter this character, GitHub remaps it. I wonder what else they remap? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #73: Port 'Resolution' as a label
mocobeta opened a new pull request, #73: URL: https://github.com/apache/lucene-jira-archive/pull/73 Close #72 Resolved issue:  For unresolved issues, there is no "Resolution" for them, so no additional label is attached. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #72: Should we migrate Legacy Jira Resolution?
mocobeta commented on issue #72: URL: https://github.com/apache/lucene-jira-archive/issues/72#issuecomment-1193292176 > Maybe we could add `legacy-jira-resolution:X`? I opened #73, will merge this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #73: Port 'Resolution' as a label
mocobeta merged PR #73: URL: https://github.com/apache/lucene-jira-archive/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta closed issue #72: Should we migrate Legacy Jira Resolution?
mocobeta closed issue #72: Should we migrate Legacy Jira Resolution? URL: https://github.com/apache/lucene-jira-archive/issues/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #60: Invalid unicode character in conversion of comment
mocobeta commented on issue #60:
URL:
https://github.com/apache/lucene-jira-archive/issues/60#issuecomment-1193293896
Regarding to "\u0010", fortunately it's relatively rare.
```
migration $ find jira-dump -name "*.json" | xargs -I{} cat {} | grep
"\u0010" | wc -l
13
```
Not sure about other ctrl characters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #72: Should we migrate Legacy Jira Resolution?
mikemccand commented on issue #72: URL: https://github.com/apache/lucene-jira-archive/issues/72#issuecomment-1193299188 Wow, thanks @mocobeta!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #60: Invalid unicode character in conversion of comment
mikemccand commented on issue #60: URL: https://github.com/apache/lucene-jira-archive/issues/60#issuecomment-1193300994 > Regarding to "\u0010", fortunately it's relatively rare. Phew, thanks for checking. Kinda crazy this exotic character occurs that many time in our Jira issues! Let's ignore it. I was going to try to figure out how many such remapped characters are happening, so I am trying to run `remap_cross_issue_links.py`. But first I discovered that in fact the character IS stored correctly in GitHub for this suspect issue comment! (I.e. on export it is still U+000A). So it must be in GH's front-end rendering of an issue where this U+FFFD substitution takes place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py
mikemccand opened a new pull request, #74: URL: https://github.com/apache/lucene-jira-archive/pull/74 Just changed words presented to humans ;) No actual code change for the machines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?
mikemccand commented on issue #61:
URL:
https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193307444
I was curious about the `Lucene Fields`, so I wrote up a quick aggregator of
all populated fields on our Jira issues:
```
import os
import glob
import json
field_count = {}
votes_count = {}
for file_name in glob.glob('jira-dump/*.json'):
d = json.load(open(file_name))
votes = d['fields']['votes']['votes']
votes_count[votes] = 1+votes_count.get(votes, 0)
for field, value in d['fields'].items():
if value:
field_count[field] = 1 + field_count.get(field, 0)
for name, count in sorted(field_count.items(), key=lambda a: -a[1]):
print(f'{name}: {count}')
print('Votes:')
for name, count in sorted(votes_count.items(), key=lambda a: -a[1]):
print(f'{name}: {count}')
```
Output:
```
-*- mode: compilation; default-directory:
"/l/orig-lucene-jira-archive/migration/" -*-
Compilation started at Sun Jul 24 08:17:22
python print_custom_fields.py
customfield_12310420: 10645
priority: 10645
customfield_12313422: 10645
status: 10645
customfield_12310920: 10645
creator: 10645
reporter: 10645
aggregateprogress: 10645
progress: 10645
votes: 10645
worklog: 10645
issuetype: 10645
customfield_12314020: 10645
project: 10645
watches: 10645
created: 10645
updated: 10645
summary: 10645
comment: 10645
customfield_12311820: 10645
workratio: 10437
description: 10339
customfield_12310120: 9741
resolution: 8699
resolutiondate: 8699
fixVersions: 6945
attachment: 6703
components: 5779
assignee: 5769
versions: 3618
issuelinks: 2164
timetracking: 1515
aggregatetimespent: 1315
timespent: 1307
environment: 1022
labels: 611
customfield_10010: 437
parent: 333
aggregatetimeoriginalestimate: 208
aggregatetimeestimate: 208
timeestimate: 205
timeoriginalestimate: 205
subtasks: 79
customfield_12310250: 63
customfield_12313520: 32
customfield_12311020: 15
duedate: 8
customfield_12311024: 4
Votes:
0: 9802
1: 545
2: 142
3: 63
4: 25
5: 22
6: 10
8: 7
7: 6
12: 5
11: 4
9: 3
14: 2
10: 2
13: 1
22: 1
19: 1
28: 1
16: 1
36: 1
15: 1
```
I guess the Lucene fields are all of these `customer_N` fields ... but they
are heavily denormalized on export LOL. I'll try to sift through them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #61: Should we carry over Jira "labels"?
mocobeta commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193312929 I think "Lucene Fields" has only two values - "New" and "Patch Available".  This is not shown as default though you can enable it when creating an issue (by clicking "Configure Fields" button in the upper right). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py
mocobeta commented on code in PR #74:
URL: https://github.com/apache/lucene-jira-archive/pull/74#discussion_r928254467
##
migration/src/remap_cross_issue_links.py:
##
@@ -68,11 +68,11 @@ def remap_issue_link_in_comments(issue_number: int,
issue_id_map: dict[str, str]
check_authentication(github_token)
parser = argparse.ArgumentParser()
-parser.add_argument('--issues', type=int, required=False, nargs='*',
help='GitHub issue number list to be downloaded')
-args = parser.parse_args()
-
mapping_data_dir =
Path(__file__).resolve().parent.parent.joinpath(MAPPINGS_DATA_DIRNAME)
issue_mapping_file = mapping_data_dir.joinpath(ISSUE_MAPPING_FILENAME)
+parser.add_argument('--issues', type=int, required=False, nargs='*',
help=f'GitHub issue number list to be downloaded, else all GitHub issues in
{issue_mapping_file.relative_to(Path.cwd())}')
Review Comment:
I copied this help string from another file. Let me adjust it.
```suggestion
parser.add_argument('--issues', type=int, required=False, nargs='*',
help=f'GitHub issue number list to be exported, else all GitHub issues in
{issue_mapping_file.relative_to(Path.cwd())}')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on pull request #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py
mocobeta commented on PR #74: URL: https://github.com/apache/lucene-jira-archive/pull/74#issuecomment-1193314053 I'd merge this, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py
mocobeta merged PR #74: URL: https://github.com/apache/lucene-jira-archive/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] luyuncheng opened a new pull request, #1046: Reduce mem copy byte store2
luyuncheng opened a new pull request, #1046: URL: https://github.com/apache/lucene/pull/1046 ### Description (or a Jira issue link if you have one) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] luyuncheng closed pull request #1046: Reduce mem copy byte store2
luyuncheng closed pull request #1046: Reduce mem copy byte store2 URL: https://github.com/apache/lucene/pull/1046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] luyuncheng opened a new pull request, #1047: LUCENE-10661: Reduce memory copy in BytesStore
luyuncheng opened a new pull request, #1047: URL: https://github.com/apache/lucene/pull/1047 This is derived from [LUCENE-10627](https://github.com/apache/lucene/pull/987) AND [LUCENE-10657](https://github.com/apache/lucene/pull/1034) The abstract method copyBytes in DataOutput have to copy from input to a copyBuffer and then write into BytesStore.blocks, which is called in FST initialization read from metaIn. Although, this copy bytes only a few bytes (in the testscase only 3-10 bytes), i think we can save this memory copy, just save the DataOutput.copyBytes to create new copyBuffer with 16384 bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10661) Reduce memory copy in BytesStore
LuYunCheng created LUCENE-10661: --- Summary: Reduce memory copy in BytesStore Key: LUCENE-10661 URL: https://issues.apache.org/jira/browse/LUCENE-10661 Project: Lucene - Core Issue Type: Improvement Reporter: LuYunCheng This is derived from [LUCENE-10627](https://github.com/apache/lucene/pull/987) AND [LUCENE-10657](https://github.com/apache/lucene/pull/1034) The abstract method copyBytes in DataOutput have to copy from input to a copyBuffer and then write into BytesStore.blocks, which is called in FST initialization read from metaIn. Although, this copy bytes only a few bytes (in the testscase only 3-10 bytes), i think we can save this memory copy, just save the DataOutput.copyBytes to create new copyBuffer with 16384 bytes -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
