[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #65: Handle tilde mentions
mocobeta opened a new pull request, #65: URL: https://github.com/apache/lucene-jira-archive/pull/65 Close #63. - Capture `[~username]` mentions as well as `@username` mentions. - Show full name if a github account is not available for the Jira username. e.g.,  is converted to  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta opened a new issue, #66: Handle new comments on existing Jira issues during migration
mocobeta opened a new issue, #66: URL: https://github.com/apache/lucene-jira-archive/issues/66 During migration, some issues could receive additional comments. These comments would be able to detect by their timestamp and migrated to the corresponding GitHub issue afterward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on pull request #65: Handle tilde mentions
mocobeta commented on PR #65: URL: https://github.com/apache/lucene-jira-archive/pull/65#issuecomment-1193086487 I'd merge this now - I need this for #66. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #65: Handle tilde mentions
mocobeta merged PR #65: URL: https://github.com/apache/lucene-jira-archive/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta closed issue #63: Jira username mentions are not converted?
mocobeta closed issue #63: Jira username mentions are not converted? URL: https://github.com/apache/lucene-jira-archive/issues/63 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #67: Add script to migrate the latest coments created in Jira during migration
mocobeta opened a new pull request, #67: URL: https://github.com/apache/lucene-jira-archive/pull/67 Close #66 This will be performed after the main migration is completed. - extracts Jira comments created after a specific timestamp (i.e. the point at the latest Jira snapshot is taken) - convert Jira comments to GitHub comments in the same way to `jira2github_import.py` - create GitHub comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on pull request #67: Add script to migrate the latest coments created in Jira during migration
mocobeta commented on PR #67: URL: https://github.com/apache/lucene-jira-archive/pull/67#issuecomment-1193094082 Tested with the latest comments on LUCENE-10557. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #67: Add script to migrate the latest coments created in Jira during migration
mocobeta merged PR #67: URL: https://github.com/apache/lucene-jira-archive/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta closed issue #66: Handle new comments on existing Jira issues during migration
mocobeta closed issue #66: Handle new comments on existing Jira issues during migration URL: https://github.com/apache/lucene-jira-archive/issues/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on pull request #65: Handle tilde mentions
mikemccand commented on PR #65: URL: https://github.com/apache/lucene-jira-archive/pull/65#issuecomment-1193096003 Yay, thank you @mocobeta! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #62: Missing closing paren in conversion
mikemccand commented on issue #62: URL: https://github.com/apache/lucene-jira-archive/issues/62#issuecomment-1193097287 Oh! I see what happened here: the closing `)` was accidentally included as part of the URL. I have often wondered how auto-hyperlinking handles this -- how does it know when a period or comma or closing `)` is NOT part of the URL? And, curiously, GitHub on migration detected that this was in fact a URL to a PR, despite have the closing `)` at the end. Though, if I try to [load that URL from GitHub](https://github.com/apache/lucene-solr/pull/916)) it does NOT discard that `)` and returns HTTP 404. Not sure where in the conversion process we "fixed" this but I like it ;) And given that this is hopefully rare, I think we can safely close this and ignore the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand closed issue #62: Missing closing paren in conversion
mikemccand closed issue #62: Missing closing paren in conversion URL: https://github.com/apache/lucene-jira-archive/issues/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?
mikemccand commented on issue #61:
URL:
https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193100921
OK I wrote a simple tool to aggregate all labels from my (nearly complete)
jira dump:
```
import os
import glob
import json
with_label_count = 0
label_count = {}
for file_name in glob.glob('jira-dump/*.json'):
d = json.load(open(file_name))
labels = d["fields"]["labels"]
if len(labels) > 0:
with_label_count += 1
#print(f'{file_name}: labels {labels}')
for label in labels:
label_count[label] = 1+label_count.get(label, 0)
for label, count in sorted(label_count.items(), key=lambda a: -a[1]):
print(f'{label} {count}')
```
Results:
```
patch 66
newdev 44
performance 39
newbie 30
vector-based-search 26
easyfix 25
gsoc2014 25
Java9 22
features 21
dead 19
build 17
gsoc2011 16
Java7 14
mentor 13
pull-request-available 13
documentation 13
Java8 12
maybe32blocker 11
random-chains 11
lucene-gsoc-11 11
lucene 11
github-pullrequest 11
analysis 10
IBM-J9 9
gsoc 8
search 8
facet 8
gsoc2012 7
lucene-gsoc-12 7
FastVectorHighlighter 7
patch-available 6
highlighter 6
query 6
suggester 6
docValues 6
test 6
Java11 6
similarity 5
stemmer 4
beginner 4
IndexWriter 4
incomplete_fix 4
missing_fixes 4
classification 4
index 4
sort 4
language 3
snowball 3
chinese 3
tokenization 3
compression 3
diffblue 3
queryparser 3
optimization 3
maven 3
solr 3
highlighting 3
Highlighter 3
stemming 3
fastvectorhighlighter 3
memory 3
perfomance 3
api-change 3
codec 3
bug 2
java8 2
pagination 2
sorting 2
parallelmultisearcher 2
jvm 2
rank 2
contrib 2
Documentation 2
Turkish 2
download 2
javadoc 2
hadoop 2
feature 2
blocker 2
locking 2
faceting 2
parser 2
Java10 2
booleanquery 2
regression 2
improvement 2
ICUFoldingFilterFactory 2
ready-to-commit 2
multi-word 2
synonyms 2
lock 2
release 2
filter 2
Arabic 2
highlight 2
faceted-search 2
EdgeNGramTokenFilter 2
analyzers 2
Java15 2
gsoc2013 2
searcher 2
tokenizer 2
morelikethis 2
jenkins 1
HTMLStripCharFilter 1
index, 1
iterators 1
Encoding 1
Front 1
normalize 1
null 1
codestyle 1
crush 1
multisearcher 1
span 1
synonym 1
score 1
Document 1
geo 1
join 1
DIH 1
Clarification 1
New_Users 1
Sort 1
docs 1
collator 1
ant 1
ivy 1
jar 1
javax 1
Analyzer 1
Ansj 1
plugin 1
Windows 1
antlr 1
hdfs 1
elasticsearch 1
refresh 1
static-analysis 1
scorer 1
clover 1
cache 1
explain 1
IndexReader 1
Highlighting 1
NPE 1
optimize 1
CountFacetRequest 1
LuceneFaq 1
Website 1
invalid 1
links 1
arguments/parameters 1
javadocs 1
indexing 1
soft-delete 1
ClassLoader 1
Thread 1
french 1
german 1
concurrency 1
starter 1
QueryParser 1
deprecated 1
missing 1
LZ4 1
BOM 1
Dependencies 1
IOE 1
update 1
policy 1
split 1
github-import 1
usability 1
EarlyTerminatingSortingCollector 1
paging 1
searchafter 1
sortingmergepolicy 1
spatial 1
spatialsearch 1
distance 1
geometric 1
length 1
short 1
suggest 1
lucene, 1
prefix 1
gradle-master 1
complexPhrase 1
cleanup 1
Impact 1
MultiLevelSkipList 1
SimpleTextCodec 1
discussion 1
gsoc2017 1
exception 1
interrupt 1
nio 1
classifier 1
batch 1
refactoring 1
time 1
error 1
checksum 1
double 1
float 1
int 1
long 1
numeric 1
Stemmer 1
SpanNearQuery 1
setMinimumNumberShouldMatch 1
CoreContainer 1
CoreReload 1
JMX 1
complexqueryparser 1
hang 1
NativeFSLockFactory 1
Java17 1
IDE 1
netbeans 1
applet 1
unsigned 1
grouping 1
neardup 1
CloseableThreadLocal 1
knn 1
android8.0 1
Suggestion 1
flex 1
merge 1
spatialrecursiveprefixtreefieldtype 1
fedora_12 1
tomcat 1
zstandard 1
Java13 1
Java14 1
java11 1
jdk11 1
jdk13 1
jdk14 1
jdk15 1
RegEx 1
bucket 1
security 1
sha1sum 1
curiosity 1
jdk16 1
opennlp 1
parallel 1
ShingleFilter 1
StopFilter 1
StopWords 1
writer 1
fieldcache 1
range 1
attribute 1
whitespace 1
Java16 1
SnapPull 1
failed 1
masterSlave 1
sorl 1
f5 1
test-failure 1
lookup 1
archive 1
dist 1
tests 1
query-parser 1
[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?
mikemccand commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193100969 Maybe we could import them under a `legacy-jira-label:XXX` to make it clear? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #61: Should we carry over Jira "labels"?
mocobeta commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193104522 > Maybe we could import them under a `legacy-jira-label:XXX` to make it clear? I'm fine with this but it seems there are many labels that do not really make much sense to me like `int`. Could we only preserve labels attached to at least N issues (perhaps N=3)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?
mikemccand commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193106221 Sorry, I still feel we should not be the judges/arbiters of history here. Our goal is to faithfully migrate and not pass personal judgement on what should make the cut. We should not to do any cleaning. Maybe one of those singleton labels was created by someone so they could remember their issue easily. They come back some day to find it by label, see we are in Jira, see that we migrated jira labels, try to search for it, fail to find it --> erodes trust. Have we done such judgement on other Jira metadata? I.e. are there cases where we could have migrated XYZ from labels (Jira export gave it to us, GitHub import would accept it) but we chose not to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #68: Preserve Jira 'Labels'
mocobeta opened a new pull request, #68: URL: https://github.com/apache/lucene-jira-archive/pull/68 #61 Port `Labels` as `legacy-jira-labels:xxx`. e.g. `newdev` is preserved as `legacy-jira-labels:newdev`  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #61: Should we carry over Jira "labels"?
mocobeta commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193108108 > Have we done such judgement on other Jira metadata? I.e. are there cases where we could have migrated XYZ from labels (Jira export gave it to us, GitHub import would accept it) but we chose not to? There are some Jira metadata that are not ported at all to GitHub labels such as `Priority`, `Resolution`, `Lucene Fields`. As for already ported metadata, there is no personal judgment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #61: Should we carry over Jira "labels"?
mocobeta commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193110759 Just to note, GitHub's search feature also search labels as well as issue title and body with "partial match". I think we need to be a bit careful about what labels we add to each issue not to increase search noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta opened a new pull request, #69: Port 'Environment' custom field
mocobeta opened a new pull request, #69: URL: https://github.com/apache/lucene-jira-archive/pull/69 Noticed there is an optional or custom metadata field "Environment" in Jira. This is not shown in the default view, but reporters can add arbitrary texts (which can be very long) in the field if they have detailed environment information. For example https://issues.apache.org/jira/browse/LUCENE-8532 For readability/visibility, I'd use a code block.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on pull request #69: Port 'Environment' custom field
mocobeta commented on PR #69: URL: https://github.com/apache/lucene-jira-archive/pull/69#issuecomment-1193124873 I think this is important and should be ported to GitHub. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #69: Port 'Environment' custom field
mocobeta merged PR #69: URL: https://github.com/apache/lucene-jira-archive/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on issue #61: Should we carry over Jira "labels"?
mikemccand commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193133017 > Just to note, GitHub's search feature also search labels as well as issue title and body in "partial match" (I do not know what they do though, I imagine GitHub tokenizes labels with some tokenizer and index the tokens). I think we need to be a bit careful about what labels we add to each issue not to increase search noise. But I think that is Search problem. And what we consider noise might be signal to people. Maybe people want to search for bugs related to `jvm` and they want `jvm bugs` to also search labels. We also should not try to judge noise vs signal in the search experience I feel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand commented on pull request #69: Port 'Environment' custom field
mikemccand commented on PR #69: URL: https://github.com/apache/lucene-jira-archive/pull/69#issuecomment-1193133256 +1 thanks @mocobeta! What other custom fields does Lucene have? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] gsmiller merged pull request #1044: Fix another TestDisiPriorityQueue bug
gsmiller merged PR #1044: URL: https://github.com/apache/lucene/pull/1044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-10659) Fix random TestDisiPriorityQueue bug
[
https://issues.apache.org/jira/browse/LUCENE-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller resolved LUCENE-10659.
--
Resolution: Fixed
> Fix random TestDisiPriorityQueue bug
>
>
> Key: LUCENE-10659
> URL: https://issues.apache.org/jira/browse/LUCENE-10659
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 9.3
>Reporter: Greg Miller
>Assignee: Greg Miller
>Priority: Blocker
> Fix For: 9.3
>
>
> A recently added test ({{TestDisiPriorityQueue}}) has a bug that can randomly
> trip (my fault). I fixed this on {{main}} and {{branch_9x}}, but I think we
> should roll it into the 9.3 release. I'll prepare a PR, but raising it here
> for visibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10659) Fix random TestDisiPriorityQueue bug
[
https://issues.apache.org/jira/browse/LUCENE-10659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570315#comment-17570315
]
Greg Miller commented on LUCENE-10659:
--
Patched this additional fix in as well. Hopefully this test is good to go now.
I'll keep an eye on it.
> Fix random TestDisiPriorityQueue bug
>
>
> Key: LUCENE-10659
> URL: https://issues.apache.org/jira/browse/LUCENE-10659
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 9.3
>Reporter: Greg Miller
>Assignee: Greg Miller
>Priority: Blocker
> Fix For: 9.3
>
>
> A recently added test ({{TestDisiPriorityQueue}}) has a bug that can randomly
> trip (my fault). I fixed this on {{main}} and {{branch_9x}}, but I think we
> should roll it into the 9.3 release. I'll prepare a PR, but raising it here
> for visibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mikemccand opened a new issue, #70: {{ X }} did not convert to backticks correctly?
mikemccand opened a new issue, #70: URL: https://github.com/apache/lucene-jira-archive/issues/70 I'm not sure what happened here but if you look a [this converted issue](https://github.com/mikemccand/stargazers-migration-test/issues/959), the \`MergePolicy.findFullFlushMerges\` somehow did not properly backtick? It renders correctly in the corresponding Jira as code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta merged pull request #68: Preserve Jira 'Labels'
mocobeta merged PR #68: URL: https://github.com/apache/lucene-jira-archive/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #61: Should we carry over Jira "labels"?
mocobeta commented on issue #61: URL: https://github.com/apache/lucene-jira-archive/issues/61#issuecomment-1193231561 I merged #68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-jira-archive] mocobeta commented on issue #70: {{ X }} did not convert to backticks correctly?
mocobeta commented on issue #70:
URL:
https://github.com/apache/lucene-jira-archive/issues/70#issuecomment-1193234407
`{{X}}` is correctly converted to backticks here. The problem is that the
original text in Jira data includes escaping character `\\` before `{{X}}` for
some reason, and then it seems GitHub "properly" escapes backticks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10660) precompute the max level in LogMergePolicy
tang donghai created LUCENE-10660:
-
Summary: precompute the max level in LogMergePolicy
Key: LUCENE-10660
URL: https://issues.apache.org/jira/browse/LUCENE-10660
Project: Lucene - Core
Issue Type: Improvement
Components: core/index
Affects Versions: 9.2
Reporter: tang donghai
I notice LogMergePolicy#findMerges will always calculate max level on the
right side when find the next segments to merge.
I think we could calculate the max levels only once, and when we need the max
level, we could simply
{code:java}
float maxLevel = maxLevels[start];
{code}
and the precomputed code looks like below, compare each level in levels from
right to left
{code:java}
float[] maxLevels = new float[numMergeableSegments + 1];
maxLevels[numMergeableSegments] = -1.0f;
for (int i = numMergeableSegments - 1; i >= 0; i--) {
maxLevels[i] = Math.max(levels.get(i).level, maxLevels[i + 1]);
}
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] tang-hi opened a new pull request, #1045: LUCENE-10660: precompute maxlevel in LogMergePolicy
tang-hi opened a new pull request, #1045: URL: https://github.com/apache/lucene/pull/1045 ### Description (or a Jira issue link if you have one) [jira](https://issues.apache.org/jira/browse/LUCENE-10660) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10480) Specialize 2-clauses disjunctions
[ https://issues.apache.org/jira/browse/LUCENE-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570417#comment-17570417 ] Zach Chen commented on LUCENE-10480: >From the latest nightly benchmark result, the negative impact to nested >boolean queries have been resolved, and the performance boost to top-level >disjunction queries have been maintained. Thanks for all the guidance >[~jpountz] ! > Specialize 2-clauses disjunctions > - > > Key: LUCENE-10480 > URL: https://issues.apache.org/jira/browse/LUCENE-10480 > Project: Lucene - Core > Issue Type: Task >Reporter: Adrien Grand >Assignee: Zach Chen >Priority: Minor > Time Spent: 11h 40m > Remaining Estimate: 0h > > WANDScorer is nice, but it also has lots of overhead to maintain its > invariants: one linked list for the current candidates, one priority queue of > scorers that are behind, another one for scorers that are ahead. All this > could be simplified in the 2-clauses case, which feels worth specializing for > as it's very common that end users enter queries that only have two terms? -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
