[jira] [Commented] (LUCENE-10603) Improve iteration of ords for SortedSetDocValues

2022-06-12 Thread Lu Xugang (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553390#comment-17553390
 ] 

Lu Xugang commented on LUCENE-10603:


Thanks [~gsmiller], if there was no one else has any further suggestion,  I 
will later do the work .

> Improve iteration of ords for SortedSetDocValues
> 
>
> Key: LUCENE-10603
> URL: https://issues.apache.org/jira/browse/LUCENE-10603
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Lu Xugang
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After SortedSetDocValues#docValueCount added since Lucene 9.2, should we 
> refactor the implementation of ords iterations using docValueCount instead of 
> NO_MORE_ORDS?
> Similar how SortedNumericDocValues did
> From 
> {code:java}
> for (long ord = values.nextOrd();ord != SortedSetDocValues.NO_MORE_ORDS; ord 
> = values.nextOrd()) {
> }{code}
> to
> {code:java}
> for (int i = 0; i < values.docValueCount(); i++) {
>   long ord = values.nextOrd();
> }{code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Comment Edited] (LUCENE-10606) Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed queries

2022-06-12 Thread Kaival Parikh (Jira) 


[ 
https://issues.apache.org/jira/browse/LUCENE-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552542#comment-17552542
 ] 

Kaival Parikh edited comment on LUCENE-10606 at 6/13/22 6:10 AM:
-

Sure, Thank you! I have created a 
[PR|https://github.com/apache/lucene/pull/951] now


was (Author: JIRAUSER289654):
Sure, Thank you! I have created a PR now

> Optimize hit collection of prefilter in KnnVectorQuery for BitSet backed 
> queries
> 
>
> Key: LUCENE-10606
> URL: https://issues.apache.org/jira/browse/LUCENE-10606
> Project: Lucene - Core
>  Issue Type: Improvement
>  Components: core/search
>Reporter: Kaival Parikh
>Priority: Minor
>  Labels: performance
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> While working on this [PR|https://github.com/apache/lucene/pull/932] to add 
> prefilter testing support, we saw that hit collection took a long time for 
> BitSetIterator backed scorers (due to iteration over the entire underlying 
> BitSet, and copying it into an internal one)
> These BitSetIterators can be frequent (as they are used in LRUQueryCache), 
> and bulk collection can be optimized with more knowledge of the underlying 
> iterator



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org