[jira] [Commented] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run
[ https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505409#comment-17505409 ] Dawid Weiss commented on LUCENE-10461: -- The problem with "java" used from within a cmd script is that it leaves an ugly console window hanging in the background - many people (including me) don't like that, especially when you double click on luke's icon and it opens two windows - the console and the application itself. I'm not sure how big of a problem it is in practice. > Luke: Windows launch script passes integration tests but fails to run > - > > Key: LUCENE-10461 > URL: https://issues.apache.org/jira/browse/LUCENE-10461 > Project: Lucene - Core > Issue Type: Bug >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: 9.1, 10.0 (main) > > Time Spent: 1h 20m > Remaining Estimate: 0h > > PR at https://github.com/apache/lucene/pull/743 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run
[ https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505418#comment-17505418 ] Tomoko Uchida commented on LUCENE-10461: I didn't know the cmd file can be started by double-click. :-/ As for opening two windows, I myself am not annoyed by it (I wonder how many people launch multiple Luke apps at the same time...) and the background console shows application logs, I think having it can be useful also for Windows users as well as Linux/Mac users. We now have an integration (or launch) test for Luke, I'm inclined to use the same testable command both on test and actual run as much as possible if there are no big practical problems. > Luke: Windows launch script passes integration tests but fails to run > - > > Key: LUCENE-10461 > URL: https://issues.apache.org/jira/browse/LUCENE-10461 > Project: Lucene - Core > Issue Type: Bug >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: 9.1, 10.0 (main) > > Time Spent: 1h 20m > Remaining Estimate: 0h > > PR at https://github.com/apache/lucene/pull/743 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run
[ https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10461: - Attachment: image-2022-03-13-11-15-50-927.png > Luke: Windows launch script passes integration tests but fails to run > - > > Key: LUCENE-10461 > URL: https://issues.apache.org/jira/browse/LUCENE-10461 > Project: Lucene - Core > Issue Type: Bug >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: 9.1, 10.0 (main) > > Attachments: image-2022-03-13-11-15-50-927.png > > Time Spent: 1h 20m > Remaining Estimate: 0h > > PR at https://github.com/apache/lucene/pull/743 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run
[ https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505421#comment-17505421 ] Dawid Weiss commented on LUCENE-10461: -- > I didn't know the cmd file can be started by double-click. :-/ It surely can be started like that! That background window is annoying though :( !image-2022-03-13-11-15-50-927.png|width=530,height=387! > Luke: Windows launch script passes integration tests but fails to run > - > > Key: LUCENE-10461 > URL: https://issues.apache.org/jira/browse/LUCENE-10461 > Project: Lucene - Core > Issue Type: Bug >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: 9.1, 10.0 (main) > > Attachments: image-2022-03-13-11-15-50-927.png > > Time Spent: 1h 20m > Remaining Estimate: 0h > > PR at https://github.com/apache/lucene/pull/743 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run
[ https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505421#comment-17505421 ] Dawid Weiss edited comment on LUCENE-10461 at 3/13/22, 10:17 AM: - > I didn't know the cmd file can be started by double-click. :-/ It surely can be started like that! That background window is annoying though :( was (Author: dweiss): > I didn't know the cmd file can be started by double-click. :-/ It surely can be started like that! That background window is annoying though :( !image-2022-03-13-11-15-50-927.png|width=530,height=387! > Luke: Windows launch script passes integration tests but fails to run > - > > Key: LUCENE-10461 > URL: https://issues.apache.org/jira/browse/LUCENE-10461 > Project: Lucene - Core > Issue Type: Bug >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: 9.1, 10.0 (main) > > Time Spent: 1h 20m > Remaining Estimate: 0h > > PR at https://github.com/apache/lucene/pull/743 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run
[ https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10461: - Attachment: (was: image-2022-03-13-11-15-50-927.png) > Luke: Windows launch script passes integration tests but fails to run > - > > Key: LUCENE-10461 > URL: https://issues.apache.org/jira/browse/LUCENE-10461 > Project: Lucene - Core > Issue Type: Bug >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: 9.1, 10.0 (main) > > Time Spent: 1h 20m > Remaining Estimate: 0h > > PR at https://github.com/apache/lucene/pull/743 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run
[ https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505421#comment-17505421 ] Dawid Weiss edited comment on LUCENE-10461 at 3/13/22, 10:18 AM: - > I didn't know the cmd file can be started by double-click. :-/ It surely can be started like that! That background window is annoying though :( !image-2022-03-13-11-18-34-704.png|width=496,height=325! was (Author: dweiss): > I didn't know the cmd file can be started by double-click. :-/ It surely can be started like that! That background window is annoying though :( > Luke: Windows launch script passes integration tests but fails to run > - > > Key: LUCENE-10461 > URL: https://issues.apache.org/jira/browse/LUCENE-10461 > Project: Lucene - Core > Issue Type: Bug >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: 9.1, 10.0 (main) > > Attachments: image-2022-03-13-11-18-34-704.png > > Time Spent: 1h 20m > Remaining Estimate: 0h > > PR at https://github.com/apache/lucene/pull/743 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run
[ https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505422#comment-17505422 ] Uwe Schindler commented on LUCENE-10461: Please stay with the javaw support. We have the log viewer inside the app. Maybe add a command line parameter to switch on the console when experiencing classpath issues, but on Windows this should not be the default. The startup script is so simple at moment, I don't see any problem in both code paths. Like Dawid I am heavy windows user and black console windows are not nice to my eyes. 🫣 > Luke: Windows launch script passes integration tests but fails to run > - > > Key: LUCENE-10461 > URL: https://issues.apache.org/jira/browse/LUCENE-10461 > Project: Lucene - Core > Issue Type: Bug >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Fix For: 9.1, 10.0 (main) > > Attachments: image-2022-03-13-11-18-34-704.png > > Time Spent: 1h 20m > Remaining Estimate: 0h > > PR at https://github.com/apache/lucene/pull/743 -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10462) Reenable smoke tester in Jenkins
[ https://issues.apache.org/jira/browse/LUCENE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505878#comment-17505878 ] Uwe Schindler commented on LUCENE-10462: Sorry I was not able to take care on this on weekend. I will investiage maybe tomorrow! > Reenable smoke tester in Jenkins > > > Key: LUCENE-10462 > URL: https://issues.apache.org/jira/browse/LUCENE-10462 > Project: Lucene - Core > Issue Type: Task >Reporter: Julie Tibshirani >Assignee: Uwe Schindler >Priority: Major > > While preparing the 9.1 release, we found that the smoke tester failed > because of some build changes (LUCENE-10459). It would be great to catch > these failures earlier, when the changes are actually made. > Apparently we used to have a smoke test check in Jenkins, but it was disabled > when we moved to gradle. It would be great to update the script and reenable > it. > As part of this we'd need to update the smoke tester for 'main', where there > are still some failures. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
