date:20220311



 [ 
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dawid Weiss updated LUCENE-10461:
-
Description: PR at https://github.com/apache/lucene/pull/743

> Luke: Windows launch script passes integration tests but fails to run
> -
>
> Key: LUCENE-10461
> URL: https://issues.apache.org/jira/browse/LUCENE-10461
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Dawid Weiss
>Priority: Major
>
> PR at https://github.com/apache/lucene/pull/743



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Assigned] (LUCENE-10461) Luke: Windows launch script passes integration tests but fails to run



 [ 
https://issues.apache.org/jira/browse/LUCENE-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dawid Weiss reassigned LUCENE-10461:


Assignee: Dawid Weiss

> Luke: Windows launch script passes integration tests but fails to run
> -
>
> Key: LUCENE-10461
> URL: https://issues.apache.org/jira/browse/LUCENE-10461
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> PR at https://github.com/apache/lucene/pull/743



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] mocobeta commented on pull request #740: LUCENE-10393: Unify binary dictionary and dictionary writer in kuromoji and nori



mocobeta commented on pull request #740:
URL: https://github.com/apache/lucene/pull/740#issuecomment-1064902141


   > I ran ./gradlew regenerate --rerun-tasks on your branch as an additional 
test and all binary data files were unchanged. So I feel good about correctness!
   
   Thanks, @rmuir for confirming that! This is code refactoring and shouldn't 
change the outputs of the BinaryDictionaryWriter.
   
   About the interface,  `MorphData` sounds fine to me if `Attributes` is 
confusing. I'll rename the classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1



[ 
https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504804#comment-17504804
 ] 

Dawid Weiss commented on LUCENE-10459:
--

Hi Julie. I filed a PR here: [https://github.com/apache/lucene/pull/744]

I wanted to test it against main but the smoke tester script fails there (it 
tries to use jdk11 - this should be changed as well). You can cherry pick the 
patch on top of 9x and 9_1 - it should work fine (LUCENE-10461 is also a 
blocker and should be backported to those branches prior to the release). I 
have to go back to work now. Let me know if this helped and feel free to commit 
those patches on behalf of me.

> Update smoke tester for 9.1
> ---
>
> Key: LUCENE-10459
> URL: https://issues.apache.org/jira/browse/LUCENE-10459
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 9.1
>Reporter: Julie Tibshirani
>Priority: Major
>
> While working on the 9.1 release, I ran into several failures in the smoke 
> tester that seem related to our move to the module system. At a high level, 
> they include:
> * Including test directories in the binary distribution
> * Missing dependencies for the demo
> I opened this PR to show the details of the issues: 
> https://github.com/apache/lucene/pull/739.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] kkewwei commented on a change in pull request #741: LUCENE-10448: avoid the instant writing rate bigger than the limited rate in merge process



kkewwei commented on a change in pull request #741:
URL: https://github.com/apache/lucene/pull/741#discussion_r824510831



##
File path: lucene/core/src/java/org/apache/lucene/index/MergeRateLimiter.java
##
@@ -124,16 +125,21 @@ private long maybePause(long bytes, long curNS) throws 
MergePolicy.MergeAbortedE
 // Time we should sleep until; this is purely instantaneous
 // rate (just adds seconds onto the last time we had paused to);
 // maybe we should also offer decayed recent history one?
-long targetNS = lastNS + (long) (10 * secondsToPause);
-
+long targetNS = lastedTime + (long) (10 * secondsToPause);
 long curPauseNS = targetNS - curNS;

Review comment:
   yes, I fix it by you reminder, thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1



[ 
https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504817#comment-17504817
 ] 

Tomoko Uchida commented on LUCENE-10459:


{quote}It was an intentional decision _not_ to include all of the binary 
dependencies for each and every module - we only ship the ones for Luke in the 
binary distribution so that it works. I also believe we did verify the smoke 
tester when the change was made and everything worked - have there been any 
dependencies add that broke this?
{quote}
The demo is also an application, I think it would make sense to include all 
necessary dependencies for the demo module in the binary distribution?  While 
it is a quick fix to make the smoketester work, having launch scripts for the 
demo in `bin/` folder also makes sense to me (in the future).

> Update smoke tester for 9.1
> ---
>
> Key: LUCENE-10459
> URL: https://issues.apache.org/jira/browse/LUCENE-10459
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 9.1
>Reporter: Julie Tibshirani
>Priority: Major
>
> While working on the 9.1 release, I ran into several failures in the smoke 
> tester that seem related to our move to the module system. At a high level, 
> they include:
> * Including test directories in the binary distribution
> * Missing dependencies for the demo
> I opened this PR to show the details of the issues: 
> https://github.com/apache/lucene/pull/739.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Comment Edited] (LUCENE-10459) Update smoke tester for 9.1



[ 
https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504817#comment-17504817
 ] 

Tomoko Uchida edited comment on LUCENE-10459 at 3/11/22, 9:25 AM:
--

{quote}It was an intentional decision _not_ to include all of the binary 
dependencies for each and every module - we only ship the ones for Luke in the 
binary distribution so that it works. I also believe we did verify the smoke 
tester when the change was made and everything worked - have there been any 
dependencies add that broke this?
{quote}
The demo is also an application, I think it would make sense to include all 
necessary dependencies for the demo module in the binary distribution?  While 
it is a quick fix to make the smoketester work, having launch scripts for the 
demo in `bin/` folder also makes sense to me (in the future).

=> I found this was handled in the PR #744 (I noticed the last comment from 
[~dweiss] after reloading), thanks.


was (Author: tomoko uchida):
{quote}It was an intentional decision _not_ to include all of the binary 
dependencies for each and every module - we only ship the ones for Luke in the 
binary distribution so that it works. I also believe we did verify the smoke 
tester when the change was made and everything worked - have there been any 
dependencies add that broke this?
{quote}
The demo is also an application, I think it would make sense to include all 
necessary dependencies for the demo module in the binary distribution?  While 
it is a quick fix to make the smoketester work, having launch scripts for the 
demo in `bin/` folder also makes sense to me (in the future).

> Update smoke tester for 9.1
> ---
>
> Key: LUCENE-10459
> URL: https://issues.apache.org/jira/browse/LUCENE-10459
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 9.1
>Reporter: Julie Tibshirani
>Priority: Major
>
> While working on the 9.1 release, I ran into several failures in the smoke 
> tester that seem related to our move to the module system. At a high level, 
> they include:
> * Including test directories in the binary distribution
> * Missing dependencies for the demo
> I opened this PR to show the details of the issues: 
> https://github.com/apache/lucene/pull/739.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] mocobeta commented on a change in pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…



mocobeta commented on a change in pull request #744:
URL: https://github.com/apache/lucene/pull/744#discussion_r824587863



##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -657,8 +657,8 @@ def testDemo(run_java, isSrc, version, jdk):
 indexFilesCmd = 'java -cp "%s" -Dsmoketester=true 
org.apache.lucene.demo.IndexFiles -index index -docs %s' % (cp, docsDir)
 searchFilesCmd = 'java -cp "%s" org.apache.lucene.demo.SearchFiles -index 
index -query lucene' % cp
   else:
-# For binary release, set up classpath as modules.
-cp = "--module-path modules"
+# For binary release, set up module path.
+cp = "--module-path %s" % (sep.join("modules", "modules-thirdparty"))

Review comment:
   `join()` takes a list;  `[` and `]` is needed.
   ```suggestion
   cp = "--module-path %s" % (sep.join(["modules", "modules-thirdparty"]))
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] mocobeta commented on a change in pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…



mocobeta commented on a change in pull request #744:
URL: https://github.com/apache/lucene/pull/744#discussion_r824590424



##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -657,8 +657,8 @@ def testDemo(run_java, isSrc, version, jdk):
 indexFilesCmd = 'java -cp "%s" -Dsmoketester=true 
org.apache.lucene.demo.IndexFiles -index index -docs %s' % (cp, docsDir)
 searchFilesCmd = 'java -cp "%s" org.apache.lucene.demo.SearchFiles -index 
index -query lucene' % cp
   else:
-# For binary release, set up classpath as modules.
-cp = "--module-path modules"
+# For binary release, set up module path.
+cp = "--module-path %s" % (sep.join("modules", "modules-thirdparty"))

Review comment:
   It is a trivial syntax correction (I confirmed it works). Let me commit 
this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] mocobeta commented on a change in pull request #739: Adapt release smoke tester for 9.1



mocobeta commented on a change in pull request #739:
URL: https://github.com/apache/lucene/pull/739#discussion_r824603725



##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -574,10 +574,11 @@ def verifyUnpacked(java, artifact, unpackPath, 
gitRevision, version, testArgs):
   #   raise RuntimeError('lucene: file "%s" is missing from artifact %s' % 
(fileName, artifact))
   # in_root_folder.remove(fileName)
 
-  expected_folders = ['analysis', 'backward-codecs', 'benchmark', 
'classification', 'codecs', 'core',
-  'demo', 'expressions', 'facet', 'grouping', 
'highlighter', 'join',
-  'luke', 'memory', 'misc', 'monitor', 'queries', 
'queryparser', 'replicator',
-  'sandbox', 'spatial-extras', 'spatial3d', 'suggest', 
'test-framework', 'licenses']
+  expected_folders = ['analysis', 'analysis.tests', 'backward-codecs', 
'benchmark', 'classification', 'codecs',

Review comment:
   The variable `expected_folders` is used to validate src distribution, 
not the binary distribution - I think "*.tests" folders should appear here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] mocobeta commented on pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…



mocobeta commented on pull request #744:
URL: https://github.com/apache/lucene/pull/744#issuecomment-1065010222


   I just corrected syntax and cherry-picked some changes in #739 to make the 
smoke tester work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] mocobeta commented on a change in pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…



mocobeta commented on a change in pull request #744:
URL: https://github.com/apache/lucene/pull/744#discussion_r824590424



##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -657,8 +657,8 @@ def testDemo(run_java, isSrc, version, jdk):
 indexFilesCmd = 'java -cp "%s" -Dsmoketester=true 
org.apache.lucene.demo.IndexFiles -index index -docs %s' % (cp, docsDir)
 searchFilesCmd = 'java -cp "%s" org.apache.lucene.demo.SearchFiles -index 
index -query lucene' % cp
   else:
-# For binary release, set up classpath as modules.
-cp = "--module-path modules"
+# For binary release, set up module path.
+cp = "--module-path %s" % (sep.join("modules", "modules-thirdparty"))

Review comment:
   It is a trivial syntax correction (I confirmed it works). Let me commit 
this in here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] mocobeta commented on pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…

mocobeta commented on pull request #744:
URL: https://github.com/apache/lucene/pull/744#issuecomment-1065070276

I cherry-picked these commits on my branch_9_1 and ran the smoke tester.
```
lucene $ /usr/bin/python3 -u dev-tools/scripts/smokeTestRelease.py
--not-signed --tmp-dir /mnt/hdd/tmp/smoketester
file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793

Java 11 JAVA_HOME=/home/moco/.sdkman/candidates/java/11.0.12-open
NOTE: output encoding is utf-8

Load release URL
"file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793"...

Get KEYS...
Downloading online KEYS file https://archive.apache.org/dist/lucene/KEYS
Downloading https://archive.apache.org/dist/lucene/KEYS
0.3 MB in 1.75 sec (0.2 MB/sec)

Test Lucene...
test basics...
check changes HTML...
download lucene-9.1.0-src.tgz...
Downloading
file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793/lucene/lucene-9.1.0-src.tgz
47.3 MB in 0.03 sec (1601.8 MB/sec)
verify sha512 digest
download lucene-9.1.0.tgz...
Downloading
file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793/lucene/lucene-9.1.0.tgz
64.8 MB in 0.04 sec (1535.7 MB/sec)
verify sha512 digest
unpack lucene-9.1.0.tgz...
lucene-9.1.0.tgz
Checking LICENSE
Checking NOTICE
Checking README
Checking JRE_VERSION_MIGRATION
Checking CHANGES
Checking MIGRATE
Checking SYSTEM_REQUIREMENTS
Checking bin
Checking docs
Checking licenses
Checking modules
Checking modules-thirdparty
Checking modules-test-framework
verify JAR metadata/identity/no javax.* or java.* classes...
test demo with 11...
got 4167 hits for query "lucene"
checkindex with 11...
unpack lucene-9.1.0-src.tgz...
lucene-9.1.0-src.tgz
Checking LICENSE
Checking NOTICE
Checking README
Checking JRE_VERSION_MIGRATION
Checking CHANGES
Checking MIGRATE
Checking SYSTEM_REQUIREMENTS
Checking build.gradle
Checking buildSrc
Checking dev-docs
Checking dev-tools
Checking gradle
Checking gradlew
Checking gradlew.bat
Checking help
Checking lucene
Checking settings.gradle
Checking versions.lock
Checking versions.props
Checking analysis
Checking analysis.tests
Checking backward-codecs
Checking benchmark
Checking classification
Checking codecs
Checking core
Checking core.tests
Checking distribution.tests
Checking demo
Checking expressions
Checking facet
Checking grouping
Checking highlighter
Checking join
Checking luke
Checking memory
Checking misc
Checking monitor
Checking queries
Checking queryparser
Checking replicator
Checking sandbox
Checking spatial-extras
Checking spatial-test-fixtures
Checking spatial3d
Checking suggest
Checking test-framework
Checking licenses
Checking build.gradle
Checking documentation
Checking distribution
Checking dev-docs
make sure no JARs/WARs in src dist...
run "./gradlew --no-daemon check -p lucene/documentation"
run tests w/ Java 11 and testArgs='-Dtests.nightly=true
-Dtests.badapples=false '...
compile jars w/ Java 11
test demo with 11...
got 230 hits for query "lucene"
checkindex with 11...
confirm all releases have coverage in TestBackwardsCompatibility
find all past Lucene releases...
run TestBackwardsCompatibility..
success!

Test Maven artifacts...
download artifacts

verify that each binary artifact has a deployed POM...
verify Maven artifacts' md5/sha1 digests...
check for javadoc and sources artifacts...
verify deployed POMs' coordinates...
unpack lucene-9.1.0.tgz...
verify

[GitHub] [lucene] mocobeta edited a comment on pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…

mocobeta edited a comment on pull request #744:
URL: https://github.com/apache/lucene/pull/744#issuecomment-1065070276

I cherry-picked these commits on my branch_9_1 and ran the smoke tester. (I
agree with it would be good to make the script work on main so that we can
easily do a test run... I will open an issue for that later.)
```
lucene $ /usr/bin/python3 -u dev-tools/scripts/smokeTestRelease.py
--not-signed --tmp-dir /mnt/hdd/tmp/smoketester
file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793

Java 11 JAVA_HOME=/home/moco/.sdkman/candidates/java/11.0.12-open
NOTE: output encoding is utf-8

Load release URL
"file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793"...

Get KEYS...
Downloading online KEYS file https://archive.apache.org/dist/lucene/KEYS
Downloading https://archive.apache.org/dist/lucene/KEYS
0.3 MB in 1.75 sec (0.2 MB/sec)

Test Maven artifacts...
download artifacts

verify that each binary artifact has a deployed POM...
verify Maven artifacts' md5/sha1 dige

[GitHub] [lucene] mocobeta edited a comment on pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…

mocobeta edited a comment on pull request #744:
URL: https://github.com/apache/lucene/pull/744#issuecomment-1065070276

click here to show outputs

```
lucene $ /usr/bin/python3 -u dev-tools/scripts/smokeTestRelease.py
--not-signed --tmp-dir /mnt/hdd/tmp/smoketester
file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793

Java 11 JAVA_HOME=/home/moco/.sdkman/candidates/java/11.0.12-open
NOTE: output encoding is utf-8

Load release URL
"file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793"...

Get KEYS...
Downloading online KEYS file https://archive.apache.org/dist/lucene/KEYS
Downloading https://archive.apache.org/dist/lucene/KEYS
0.3 MB in 1.75 sec (0.2 MB/sec)

Test Maven artifacts...
download artifacts

verify that each binary artifact has a deployed POM...

[GitHub] [lucene] mocobeta edited a comment on pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…

mocobeta edited a comment on pull request #744:
URL: https://github.com/apache/lucene/pull/744#issuecomment-1065070276

click here to show the script's outputs

Java 11 JAVA_HOME=/home/moco/.sdkman/candidates/java/11.0.12-open
NOTE: output encoding is utf-8

Load release URL
"file:///tmp/lucene-9.1/lucene-9.1.0-RC1-rev-b93d62ba57532a4d523e3a4a9579b0e9e47bf793"...

Get KEYS...
Downloading online KEYS file https://archive.apache.org/dist/lucene/KEYS
Downloading https://archive.apache.org/dist/lucene/KEYS
0.3 MB in 1.75 sec (0.2 MB/sec)

Test Maven artifacts...
download artifacts

verify that each binary artifact has a deplo

[GitHub] [lucene] dweiss commented on pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…



dweiss commented on pull request #744:
URL: https://github.com/apache/lucene/pull/744#issuecomment-1065151309


   Thanks @mocobeta !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] thelabdude opened a new pull request #2646: SOLR-16022: Enforce special character requirements on passwords with length less than 15



thelabdude opened a new pull request #2646:
URL: https://github.com/apache/lucene-solr/pull/2646


   backport from https://github.com/apache/solr/pull/741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] thelabdude merged pull request #2646: SOLR-16022: Enforce special character requirements on passwords with length less than 15



thelabdude merged pull request #2646:
URL: https://github.com/apache/lucene-solr/pull/2646


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] jtibshirani commented on a change in pull request #739: Adapt release smoke tester for 9.1



jtibshirani commented on a change in pull request #739:
URL: https://github.com/apache/lucene/pull/739#discussion_r824045245



##
File path: dev-tools/scripts/smokeTestRelease.py
##
@@ -658,7 +659,7 @@ def testDemo(run_java, isSrc, version, jdk):
 searchFilesCmd = 'java -cp "%s" org.apache.lucene.demo.SearchFiles -index 
index -query lucene' % cp
   else:
 # For binary release, set up classpath as modules.
-cp = "--module-path modules"
+cp = "--module-path modules:modules-thirdparty"

Review comment:
   This is obviously not what we'd do, just a hack so I could move onto the 
next issue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] jtibshirani merged pull request #744: LUCENE-10459: add demo dependencies to third party modules. Add an IT…

2022-03-11 Thread ASF subversion and git services (Jira)



jtibshirani merged pull request #744:
URL: https://github.com/apache/lucene/pull/744


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1



[ 
https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505054#comment-17505054
 ] 

ASF subversion and git services commented on LUCENE-10459:
--

Commit 9e9c457f8034d88052f1ed2a3746ab2b3b2940f1 in lucene's branch 
refs/heads/main from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=9e9c457 ]

LUCENE-10459: Update smoke tester for 9.1 (#744)

Add demo dependencies to third party modules. Add an IT that checks whether
demo classes are loadable.

Co-authored-by: Tomoko Uchida 
Co-authored-by: Julie Tibshirani 

> Update smoke tester for 9.1
> ---
>
> Key: LUCENE-10459
> URL: https://issues.apache.org/jira/browse/LUCENE-10459
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 9.1
>Reporter: Julie Tibshirani
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> While working on the 9.1 release, I ran into several failures in the smoke 
> tester that seem related to our move to the module system. At a high level, 
> they include:
> * Including test directories in the binary distribution
> * Missing dependencies for the demo
> I opened this PR to show the details of the issues: 
> https://github.com/apache/lucene/pull/739.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Created] (LUCENE-10462) Reenable smoke tester in Jenkins

2022-03-11 Thread Julie Tibshirani (Jira)

Julie Tibshirani created LUCENE-10462:
-

 Summary: Reenable smoke tester in Jenkins
 Key: LUCENE-10462
 URL: https://issues.apache.org/jira/browse/LUCENE-10462
 Project: Lucene - Core
  Issue Type: Task
Reporter: Julie Tibshirani


While preparing the 9.1 release, we found that the smoke tester failed because 
of some build changes (LUCENE-10459). It would be great to catch these failures 
earlier, when the changes are actually made.

Apparently we used to have a smoke test check in Jenkins, but it was disabled 
when we moved to gradle. It would be great to update the script and reenable it.

As part of this we'd need to update the smoke tester for 'main', where there 
are still some failures.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1

2022-03-11 Thread Julie Tibshirani (Jira)



[ 
https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505059#comment-17505059
 ] 

Julie Tibshirani commented on LUCENE-10459:
---

Thank you [~dweiss] [~tomoko] ! This already unblocks my testing for a bit 
since I'm not on Windows. I filed LUCENE-10462 to track running the smoke 
tester in Jenkins and adapting it for the 'main' branch.

> Update smoke tester for 9.1
> ---
>
> Key: LUCENE-10459
> URL: https://issues.apache.org/jira/browse/LUCENE-10459
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 9.1
>Reporter: Julie Tibshirani
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> While working on the 9.1 release, I ran into several failures in the smoke 
> tester that seem related to our move to the module system. At a high level, 
> they include:
> * Including test directories in the binary distribution
> * Missing dependencies for the demo
> I opened this PR to show the details of the issues: 
> https://github.com/apache/lucene/pull/739.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1

2022-03-11 Thread ASF subversion and git services (Jira)



[ 
https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505067#comment-17505067
 ] 

ASF subversion and git services commented on LUCENE-10459:
--

Commit 4b828f27f365b48647cf5aa9d5825263caf8dc03 in lucene's branch 
refs/heads/branch_9x from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=4b828f2 ]

LUCENE-10459: Update smoke tester for 9.1 (#744)

Add demo dependencies to third party modules. Add an IT that checks whether
demo classes are loadable.

Co-authored-by: Tomoko Uchida 
Co-authored-by: Julie Tibshirani 

> Update smoke tester for 9.1
> ---
>
> Key: LUCENE-10459
> URL: https://issues.apache.org/jira/browse/LUCENE-10459
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 9.1
>Reporter: Julie Tibshirani
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> While working on the 9.1 release, I ran into several failures in the smoke 
> tester that seem related to our move to the module system. At a high level, 
> they include:
> * Including test directories in the binary distribution
> * Missing dependencies for the demo
> I opened this PR to show the details of the issues: 
> https://github.com/apache/lucene/pull/739.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10459) Update smoke tester for 9.1

2022-03-11 Thread ASF subversion and git services (Jira)



[ 
https://issues.apache.org/jira/browse/LUCENE-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505069#comment-17505069
 ] 

ASF subversion and git services commented on LUCENE-10459:
--

Commit a3a058de6d7e8208cd988d3394b6562ee22928c6 in lucene's branch 
refs/heads/branch_9_1 from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=a3a058d ]

LUCENE-10459: Update smoke tester for 9.1 (#744)

Add demo dependencies to third party modules. Add an IT that checks whether
demo classes are loadable.

Co-authored-by: Tomoko Uchida 
Co-authored-by: Julie Tibshirani 

> Update smoke tester for 9.1
> ---
>
> Key: LUCENE-10459
> URL: https://issues.apache.org/jira/browse/LUCENE-10459
> Project: Lucene - Core
>  Issue Type: Bug
>Affects Versions: 9.1
>Reporter: Julie Tibshirani
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> While working on the 9.1 release, I ran into several failures in the smoke 
> tester that seem related to our move to the module system. At a high level, 
> they include:
> * Including test directories in the binary distribution
> * Missing dependencies for the demo
> I opened this PR to show the details of the issues: 
> https://github.com/apache/lucene/pull/739.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Assigned] (LUCENE-10462) Reenable smoke tester in Jenkins

2022-03-11 Thread Uwe Schindler (Jira)



 [ 
https://issues.apache.org/jira/browse/LUCENE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler reassigned LUCENE-10462:
--

Assignee: Uwe Schindler

> Reenable smoke tester in Jenkins
> 
>
> Key: LUCENE-10462
> URL: https://issues.apache.org/jira/browse/LUCENE-10462
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Julie Tibshirani
>Assignee: Uwe Schindler
>Priority: Major
>
> While preparing the 9.1 release, we found that the smoke tester failed 
> because of some build changes (LUCENE-10459). It would be great to catch 
> these failures earlier, when the changes are actually made.
> Apparently we used to have a smoke test check in Jenkins, but it was disabled 
> when we moved to gradle. It would be great to update the script and reenable 
> it.
> As part of this we'd need to update the smoke tester for 'main', where there 
> are still some failures.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10462) Reenable smoke tester in Jenkins

2022-03-11 Thread Uwe Schindler (Jira)



[ 
https://issues.apache.org/jira/browse/LUCENE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505093#comment-17505093
 ] 

Uwe Schindler commented on LUCENE-10462:


I can take care of this.

As I am not up to date with the release process in Gradle: what Gradle command 
should be executed before smoke tester is started?

If you give me few lines I will adapt them to Jenkins and it's env variables to 
invoke python and setting up workspace.

Uwe

> Reenable smoke tester in Jenkins
> 
>
> Key: LUCENE-10462
> URL: https://issues.apache.org/jira/browse/LUCENE-10462
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Julie Tibshirani
>Assignee: Uwe Schindler
>Priority: Major
>
> While preparing the 9.1 release, we found that the smoke tester failed 
> because of some build changes (LUCENE-10459). It would be great to catch 
> these failures earlier, when the changes are actually made.
> Apparently we used to have a smoke test check in Jenkins, but it was disabled 
> when we moved to gradle. It would be great to update the script and reenable 
> it.
> As part of this we'd need to update the smoke tester for 'main', where there 
> are still some failures.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10462) Reenable smoke tester in Jenkins

2022-03-11 Thread Uwe Schindler (Jira)



[ 
https://issues.apache.org/jira/browse/LUCENE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505094#comment-17505094
 ] 

Uwe Schindler commented on LUCENE-10462:


It would also be good to know if smoke tester can execute both 11 and 17 jdk 
versions, like the 8.x one with 8 and 11.

> Reenable smoke tester in Jenkins
> 
>
> Key: LUCENE-10462
> URL: https://issues.apache.org/jira/browse/LUCENE-10462
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Julie Tibshirani
>Assignee: Uwe Schindler
>Priority: Major
>
> While preparing the 9.1 release, we found that the smoke tester failed 
> because of some build changes (LUCENE-10459). It would be great to catch 
> these failures earlier, when the changes are actually made.
> Apparently we used to have a smoke test check in Jenkins, but it was disabled 
> when we moved to gradle. It would be great to update the script and reenable 
> it.
> As part of this we'd need to update the smoke tester for 'main', where there 
> are still some failures.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10462) Reenable smoke tester in Jenkins



[ 
https://issues.apache.org/jira/browse/LUCENE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505150#comment-17505150
 ] 

Tomoko Uchida commented on LUCENE-10462:


Hi [~uschindler], I believe the smoke tester script has not been so much 
changed from 8.x in terms of its interface (command-line arguments), although 
it now uses Gradle internally. There are lots of arguments; what preparation 
was done and what command was passed to them when we ran on 8.x? I think we can 
reenable it again on Jenkins by making small adjustments to the old commands.

As for java version, it takes `--test-java17` option to run on the specified 
java 17. It runs on java 11 by default (we should change this on the main 
branch).

 

> Reenable smoke tester in Jenkins
> 
>
> Key: LUCENE-10462
> URL: https://issues.apache.org/jira/browse/LUCENE-10462
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Julie Tibshirani
>Assignee: Uwe Schindler
>Priority: Major
>
> While preparing the 9.1 release, we found that the smoke tester failed 
> because of some build changes (LUCENE-10459). It would be great to catch 
> these failures earlier, when the changes are actually made.
> Apparently we used to have a smoke test check in Jenkins, but it was disabled 
> when we moved to gradle. It would be great to update the script and reenable 
> it.
> As part of this we'd need to update the smoke tester for 'main', where there 
> are still some failures.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Comment Edited] (LUCENE-10462) Reenable smoke tester in Jenkins



[ 
https://issues.apache.org/jira/browse/LUCENE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505150#comment-17505150
 ] 

Tomoko Uchida edited comment on LUCENE-10462 at 3/12/22, 12:43 AM:
---

Hi [~uschindler], I believe the smoke tester script has not been so much 
changed from 8.x in terms of its interface (command-line arguments), although 
it now uses Gradle internally. There are lots of arguments; what preparation 
was done and what command was passed to them when we ran on 8.x? I think we can 
reenable it again on Jenkins by making small adjustments to the old commands.

As for java version, it takes `--test-java17` option to run on the specified 
java 17 home. It runs on java 11 by default (we should change this on the main 
branch).

 


was (Author: tomoko uchida):
Hi [~uschindler], I believe the smoke tester script has not been so much 
changed from 8.x in terms of its interface (command-line arguments), although 
it now uses Gradle internally. There are lots of arguments; what preparation 
was done and what command was passed to them when we ran on 8.x? I think we can 
reenable it again on Jenkins by making small adjustments to the old commands.

As for java version, it takes `--test-java17` option to run on the specified 
java 17. It runs on java 11 by default (we should change this on the main 
branch).

 

> Reenable smoke tester in Jenkins
> 
>
> Key: LUCENE-10462
> URL: https://issues.apache.org/jira/browse/LUCENE-10462
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Julie Tibshirani
>Assignee: Uwe Schindler
>Priority: Major
>
> While preparing the 9.1 release, we found that the smoke tester failed 
> because of some build changes (LUCENE-10459). It would be great to catch 
> these failures earlier, when the changes are actually made.
> Apparently we used to have a smoke test check in Jenkins, but it was disabled 
> when we moved to gradle. It would be great to update the script and reenable 
> it.
> As part of this we'd need to update the smoke tester for 'main', where there 
> are still some failures.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Created] (LUCENE-10463) Make smoke tester script work on main branch (java 17)

Tomoko Uchida created LUCENE-10463:
--

 Summary: Make smoke tester script work on main branch (java 17)
 Key: LUCENE-10463
 URL: https://issues.apache.org/jira/browse/LUCENE-10463
 Project: Lucene - Core
  Issue Type: Task
Reporter: Tomoko Uchida


The smoke tester script has been obsoleted on main after upgrading to Java 17. 
To enable nightly smoke tests on Jenkins for main, its target java version 
should be bumped to 17.

In addition to bump the java version, it looks it should be refactored not to 
hard-code target java version. I feel it'd be better to make it coordinate with 
the Gradle distribution task.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Comment Edited] (LUCENE-10462) Reenable smoke tester in Jenkins



[ 
https://issues.apache.org/jira/browse/LUCENE-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505150#comment-17505150
 ] 

Tomoko Uchida edited comment on LUCENE-10462 at 3/12/22, 3:35 AM:
--

Hi [~uschindler], I believe the smoke tester script has not been so much 
changed from 8.x in terms of its interface (command-line arguments), although 
it now uses Gradle internally. There are lots of arguments; what preparation 
was done and what command was passed to them when we ran on 8.x? I think we can 
reenable it again on Jenkins by making small adjustments to the old commands.

As for java version, it takes `--test-java17` option to run on the specified 
java 17 home. It runs on java 11 by default (we should change this on the main 
branch: [LUCENE-10463]).

 


was (Author: tomoko uchida):
Hi [~uschindler], I believe the smoke tester script has not been so much 
changed from 8.x in terms of its interface (command-line arguments), although 
it now uses Gradle internally. There are lots of arguments; what preparation 
was done and what command was passed to them when we ran on 8.x? I think we can 
reenable it again on Jenkins by making small adjustments to the old commands.

As for java version, it takes `--test-java17` option to run on the specified 
java 17 home. It runs on java 11 by default (we should change this on the main 
branch).

 

> Reenable smoke tester in Jenkins
> 
>
> Key: LUCENE-10462
> URL: https://issues.apache.org/jira/browse/LUCENE-10462
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Julie Tibshirani
>Assignee: Uwe Schindler
>Priority: Major
>
> While preparing the 9.1 release, we found that the smoke tester failed 
> because of some build changes (LUCENE-10459). It would be great to catch 
> these failures earlier, when the changes are actually made.
> Apparently we used to have a smoke test check in Jenkins, but it was disabled 
> when we moved to gradle. It would be great to update the script and reenable 
> it.
> As part of this we'd need to update the smoke tester for 'main', where there 
> are still some failures.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10463) Make smoke tester script work on main branch (java 17)



[ 
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505171#comment-17505171
 ] 

Tomoko Uchida commented on LUCENE-10463:


Just to clarify, there are two "java version" - the target java version of the 
artifacts (this is fixed when build) and the runtime java version the script 
runs on (this can be changed by command-line arguments).

> Make smoke tester script work on main branch (java 17)
> --
>
> Key: LUCENE-10463
> URL: https://issues.apache.org/jira/browse/LUCENE-10463
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Tomoko Uchida
>Priority: Major
>
> The smoke tester script has been obsoleted on main after upgrading to Java 
> 17. To enable nightly smoke tests on Jenkins for main, its target java 
> version should be bumped to 17.
> In addition to bump the java version, it looks it should be refactored not to 
> hard-code target java version. I feel it'd be better to make it coordinate 
> with the Gradle distribution task.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10463) Make smoke tester script work on main branch (java 17)



[ 
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505174#comment-17505174
 ] 

Tomoko Uchida commented on LUCENE-10463:


Would you share your thoughts on that, [~dweiss]  - does it make sense to add a 
Gradle task to just outputs (to stdout or a temporary file) the target java 
version (`sourceCompatibility` and `targetCompatibility`) to verify the jar 
Manifests in the smoke tester? Or, in a more straightforward way, we could port 
the whole `checkJARMetaData()` method to a Gradle task.

[https://github.com/apache/lucene/blob/main/dev-tools/scripts/smokeTestRelease.py#L127]

> Make smoke tester script work on main branch (java 17)
> --
>
> Key: LUCENE-10463
> URL: https://issues.apache.org/jira/browse/LUCENE-10463
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Tomoko Uchida
>Priority: Major
>
> The smoke tester script has been obsoleted on main after upgrading to Java 
> 17. To enable nightly smoke tests on Jenkins for main, its target java 
> version should be bumped to 17.
> In addition to bump the java version, it looks it should be refactored not to 
> hard-code target java version. I feel it'd be better to make it coordinate 
> with the Gradle distribution task.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Comment Edited] (LUCENE-10463) Make smoke tester script work on main branch (java 17)



[ 
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505174#comment-17505174
 ] 

Tomoko Uchida edited comment on LUCENE-10463 at 3/12/22, 4:29 AM:
--

Would you share your thoughts on that, [~dweiss]  - does it make sense to add a 
Gradle task that just outputs (to stdout or a temporary file) the target java 
version (`sourceCompatibility` and `targetCompatibility`) to verify the jar 
Manifests in the smoke tester? Or, in a more straightforward way, we could port 
the whole `checkJARMetaData()` method to a Gradle task.

[https://github.com/apache/lucene/blob/main/dev-tools/scripts/smokeTestRelease.py#L127]


was (Author: tomoko uchida):
Would you share your thoughts on that, [~dweiss]  - does it make sense to add a 
Gradle task to just outputs (to stdout or a temporary file) the target java 
version (`sourceCompatibility` and `targetCompatibility`) to verify the jar 
Manifests in the smoke tester? Or, in a more straightforward way, we could port 
the whole `checkJARMetaData()` method to a Gradle task.

[https://github.com/apache/lucene/blob/main/dev-tools/scripts/smokeTestRelease.py#L127]

> Make smoke tester script work on main branch (java 17)
> --
>
> Key: LUCENE-10463
> URL: https://issues.apache.org/jira/browse/LUCENE-10463
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Tomoko Uchida
>Priority: Major
>
> The smoke tester script has been obsoleted on main after upgrading to Java 
> 17. To enable nightly smoke tests on Jenkins for main, its target java 
> version should be bumped to 17.
> In addition to bump the java version, it looks it should be refactored not to 
> hard-code target java version. I feel it'd be better to make it coordinate 
> with the Gradle distribution task.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10463) Make smoke tester script work on main branch (java 17)



[ 
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505195#comment-17505195
 ] 

Dawid Weiss commented on LUCENE-10463:
--

There are a number of things that rely on the java version,Tomoko - when Adrien 
made a bump to Java 17 we kept discovering that "minimum bar" in various places 
of the code. Maybe it'd be good to try to cover all of those (or most of those) 
under one issue? 

As far as I understand - the smoke tester's reason to exist is to have an 
external, final validation of things. If w tie it to the build then that 
validation will no longer be independent. Speaking for myself, I think it's 
fine if we move this check to an integration test within distribution.tests but 
I recall some discussions asking for the script to be a separate validation 
check.

> Make smoke tester script work on main branch (java 17)
> --
>
> Key: LUCENE-10463
> URL: https://issues.apache.org/jira/browse/LUCENE-10463
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Tomoko Uchida
>Priority: Major
>
> The smoke tester script has been obsoleted on main after upgrading to Java 
> 17. To enable nightly smoke tests on Jenkins for main, its target java 
> version should be bumped to 17.
> In addition to bump the java version, it looks it should be refactored not to 
> hard-code target java version. I feel it'd be better to make it coordinate 
> with the Gradle distribution task.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] dweiss commented on pull request #743: LUCENE-10461: fix windows launch script for luke so that it works with ITs



dweiss commented on pull request #743:
URL: https://github.com/apache/lucene/pull/743#issuecomment-1065826909


   Thanks @mocobeta ! I'll merge and backport this later today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene] mocobeta commented on pull request #743: LUCENE-10461: fix windows launch script for luke so that it works with ITs



mocobeta commented on pull request #743:
URL: https://github.com/apache/lucene/pull/743#issuecomment-1065827536


   @dweiss if you don't mind, I can merge and backport it to branch_9x and 
branch_9_1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-10463) Make smoke tester script work on main branch (java 17)