[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r805154103
##
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##
@@ -510,8 +510,10 @@ public static void fsync(Path fileToSync, boolean isDir)
throws IOException {
* An IO operation with a single input.
*
* @see java.util.function.Consumer
+ * @deprecated was replaced by {@link org.apache.lucene.util.IOConsumer}.
*/
@FunctionalInterface
+ @Deprecated(forRemoval = true, since = "9.1")
public interface IOConsumer {
Review comment:
I committed the remaining changes. The IOUtils.applyToAll method now
takes the old interface as parameter for backwards compatibility. Now code
compiled against Lucene 9.0 still works in 9.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r805154260
##
File path: lucene/core/src/java/org/apache/lucene/util/IOConsumer.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.util;
+
+import java.io.IOException;
+
+/**
+ * An IO operation with a single input that may throw an IOException.
+ *
+ * @see java.util.function.Consumer
+ * @param the consumer's input type.
+ */
+@FunctionalInterface
+@SuppressWarnings("removal")
+public interface IOConsumer extends IOUtils.IOConsumer {
+ /**
+ * Performs this operation on the given argument.
+ *
+ * @param input the input argument
+ * @throws IOException if producing the result throws an {@link IOException}
+ */
+ @Override
Review comment:
this annotation need to be removed in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on a change in pull request #673: LUCENE-10420: Move functional interfaces in IOUtils to top-level interfaces
uschindler commented on a change in pull request #673:
URL: https://github.com/apache/lucene/pull/673#discussion_r805154292
##
File path: lucene/core/src/java/org/apache/lucene/util/IOConsumer.java
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.util;
+
+import java.io.IOException;
+
+/**
+ * An IO operation with a single input that may throw an IOException.
+ *
+ * @see java.util.function.Consumer
+ * @param the consumer's input type.
+ */
+@FunctionalInterface
+@SuppressWarnings("removal")
+public interface IOConsumer extends IOUtils.IOConsumer {
Review comment:
the extends clause needs to be removed in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] thelabdude opened a new pull request #2640: SOLR-15974: Remove Calcite's ENUMERABLE_AGGREGATE_RULE as Solr only s…
thelabdude opened a new pull request #2640: URL: https://github.com/apache/lucene-solr/pull/2640 …upports push-down for LogicalAggregate (#626) (#627) (#628) backport of https://github.com/apache/solr/pull/628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] itygh commented on pull request #2640: SOLR-15974: Remove Calcite's ENUMERABLE_AGGREGATE_RULE as Solr only s…
itygh commented on pull request #2640: URL: https://github.com/apache/lucene-solr/pull/2640#issuecomment-1037330151 这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] itygh removed a comment on pull request #2640: SOLR-15974: Remove Calcite's ENUMERABLE_AGGREGATE_RULE as Solr only s…
itygh removed a comment on pull request #2640: URL: https://github.com/apache/lucene-solr/pull/2640#issuecomment-1037330151 这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] thelabdude merged pull request #2640: SOLR-15974: Remove Calcite's ENUMERABLE_AGGREGATE_RULE as Solr only s…
thelabdude merged pull request #2640: URL: https://github.com/apache/lucene-solr/pull/2640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers
[
https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491435#comment-17491435
]
ASF subversion and git services commented on LUCENE-10419:
--
Commit 50b7e2970f5e882072fae9d28096c9f7e6e9dc7c in lucene's branch
refs/heads/main from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=50b7e29 ]
LUCENE-10419: more debugging code. The message from AbstractStringBuilder
suggests a concurrency issue somewhere, but I just can't see it!
> Identify occasional validateSourcePatterns error on CI servers
> --
>
> Key: LUCENE-10419
> URL: https://issues.apache.org/jira/browse/LUCENE-10419
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Trivial
>
> {code}
> What went wrong: Execution failed for task
> ':lucene:analysis:icu:validateSourcePatterns'. > start 1, end 0, length 0
> {code}
>
> This annoys me. It's a message from stringbuilder.substring somewhere - let's
> get the stack of that first and see where the bug is.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers
[
https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491437#comment-17491437
]
Uwe Schindler commented on LUCENE-10419:
Could it be that RAT has some global static state? Maybe that's caused by
multiple parallel check tasks running.
A workaround would be a synchronized around the rat part.
> Identify occasional validateSourcePatterns error on CI servers
> --
>
> Key: LUCENE-10419
> URL: https://issues.apache.org/jira/browse/LUCENE-10419
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Trivial
>
> {code}
> What went wrong: Execution failed for task
> ':lucene:analysis:icu:validateSourcePatterns'. > start 1, end 0, length 0
> {code}
>
> This annoys me. It's a message from stringbuilder.substring somewhere - let's
> get the stack of that first and see where the bug is.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers
[
https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491438#comment-17491438
]
Uwe Schindler commented on LUCENE-10419:
On which Jenkins nodes does it happen? Linux, Windows, Mac?
> Identify occasional validateSourcePatterns error on CI servers
> --
>
> Key: LUCENE-10419
> URL: https://issues.apache.org/jira/browse/LUCENE-10419
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Trivial
>
> {code}
> What went wrong: Execution failed for task
> ':lucene:analysis:icu:validateSourcePatterns'. > start 1, end 0, length 0
> {code}
>
> This annoys me. It's a message from stringbuilder.substring somewhere - let's
> get the stack of that first and see where the bug is.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10419) Identify occasional validateSourcePatterns error on CI servers
[
https://issues.apache.org/jira/browse/LUCENE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491519#comment-17491519
]
Dawid Weiss commented on LUCENE-10419:
--
[https://jenkins.thetaphi.de/job/Lucene-main-Linux/32788/consoleText]
I admit this is the most bizarre thing I've seen in a while. When you look at
the above log, this message should be logged at least 5 times:
{code:java}
Exception thrown=java.lang.StringIndexOutOfBoundsException: start 1, end 0,
length 0, retries: 0, matcher.group(1)= {code}
but it gets logged once (and only on the final retry). Here is the code that
logs these messages:
[https://github.com/apache/lucene/blob/main/gradle/validation/validate-source-patterns.gradle#L176-L191]
Uwe, can you log to that VM and try to run just
{code:java}
gradlew cleanValidateSourcePatterns validateSourcePatterns {code}
a few times to see if it fails on individual runs? Or you can give me temporary
access to that machine so that I can try it there - this problem only shows up
on runs from your CI, nowhere else. But it's so consistent that it's
unbelievable that it's a hardware problem or a VM problem (it happens with many
VMs).
> Identify occasional validateSourcePatterns error on CI servers
> --
>
> Key: LUCENE-10419
> URL: https://issues.apache.org/jira/browse/LUCENE-10419
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Trivial
>
> {code}
> What went wrong: Execution failed for task
> ':lucene:analysis:icu:validateSourcePatterns'. > start 1, end 0, length 0
> {code}
>
> This annoys me. It's a message from stringbuilder.substring somewhere - let's
> get the stack of that first and see where the bug is.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
