[jira] [Created] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit
Tomoko Uchida created LUCENE-10028:
--
Summary: Optionally allow to enable git pre-commit hook for
precommit
Key: LUCENE-10028
URL: https://issues.apache.org/jira/browse/LUCENE-10028
Project: Lucene - Core
Issue Type: Task
Components: general/build
Reporter: Tomoko Uchida
With [githooks|https://git-scm.com/docs/githooks], one can automatically
perform {{arbitrary }}checks (e.g. "precommit") when before performing "git
commit".
I found the precommit check is now pretty fast on main branch, it might make
sense for developers who want to run it in an automated manner (to prevent
premature commits ore push).
*Implementation*
Hooks are just plain shell scripts that are placed in .git/hooks, so we can
provide a simple executable "pre-commit" script that runs "gradlew precommit"
and a gradle Copy task to copy it under local .git/hooks dir.
*Usage*
Install pre-commit hook (opt-in)
{code:java}
./gradlew precommitHook
{code}
After installing, precommit will be automatically performed before every commit.
{code:java}
git commit -m "commit attempt that doesn't pass spotless check"
..
> Task :lucene:luke:spotlessJavaCheck FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> The following files had format violations:
..
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit
[
https://issues.apache.org/jira/browse/LUCENE-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10028:
---
Description:
With [githooks|https://git-scm.com/docs/githooks], one can automatically
perform arbitrary checks (e.g. "precommit") when before performing "git commit".
I found the "precommit" check is now pretty fast on main branch, it might make
sense for developers who want to run it in an automated manner (to prevent
premature commits ore push).
*Implementation*
Hooks are just plain shell scripts that are placed in .git/hooks, so we can
provide a simple executable "pre-commit" script that runs "gradlew precommit"
and a gradle Copy task to copy it under local .git/hooks dir.
*Usage*
Install pre-commit hook (opt-in)
{code:java}
./gradlew precommitHook
{code}
After installing, precommit will be automatically performed before every commit.
{code:java}
git commit -m "commit attempt that doesn't pass spotless check"
..
> Task :lucene:luke:spotlessJavaCheck FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> The following files had format violations:
..
{code}
was:
With [githooks|https://git-scm.com/docs/githooks], one can automatically
perform {{arbitrary }}checks (e.g. "precommit") when before performing "git
commit".
I found the precommit check is now pretty fast on main branch, it might make
sense for developers who want to run it in an automated manner (to prevent
premature commits ore push).
*Implementation*
Hooks are just plain shell scripts that are placed in .git/hooks, so we can
provide a simple executable "pre-commit" script that runs "gradlew precommit"
and a gradle Copy task to copy it under local .git/hooks dir.
*Usage*
Install pre-commit hook (opt-in)
{code:java}
./gradlew precommitHook
{code}
After installing, precommit will be automatically performed before every commit.
{code:java}
git commit -m "commit attempt that doesn't pass spotless check"
..
> Task :lucene:luke:spotlessJavaCheck FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> The following files had format violations:
..
{code}
> Optionally allow to enable git pre-commit hook for precommit
>
>
> Key: LUCENE-10028
> URL: https://issues.apache.org/jira/browse/LUCENE-10028
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
>Reporter: Tomoko Uchida
>Priority: Minor
>
> With [githooks|https://git-scm.com/docs/githooks], one can automatically
> perform arbitrary checks (e.g. "precommit") when before performing "git
> commit".
> I found the "precommit" check is now pretty fast on main branch, it might
> make sense for developers who want to run it in an automated manner (to
> prevent premature commits ore push).
> *Implementation*
> Hooks are just plain shell scripts that are placed in .git/hooks, so we can
> provide a simple executable "pre-commit" script that runs "gradlew precommit"
> and a gradle Copy task to copy it under local .git/hooks dir.
> *Usage*
> Install pre-commit hook (opt-in)
> {code:java}
> ./gradlew precommitHook
> {code}
> After installing, precommit will be automatically performed before every
> commit.
> {code:java}
> git commit -m "commit attempt that doesn't pass spotless check"
> ..
> > Task :lucene:luke:spotlessJavaCheck FAILED
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> > The following files had format violations:
> ..
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mocobeta opened a new pull request #215: LUCENE-10028: Add git pre-commit hook that runs precommit task.
mocobeta opened a new pull request #215: URL: https://github.com/apache/lucene/pull/215 This adds git pre-commit hook for Lucene precommit check. (Usage) Install pre-commit hook (opt-in) ``` ./gradlew precommitHook ``` After installing, precommit will be automatically performed before every commit. ``` git commit -m "commit attempt that doesn't pass spotless check" .. > Task :lucene:luke:spotlessJavaCheck FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':lucene:luke:spotlessJavaCheck'. > The following files had format violations: .. // commit fails. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit
[
https://issues.apache.org/jira/browse/LUCENE-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10028:
---
Description:
With [githooks|https://git-scm.com/docs/githooks], one can automatically
perform arbitrary checks (e.g. "precommit") when before performing "git commit".
I found the "precommit" check is now pretty fast on main branch, it might make
sense for developers who want to run it in an automated manner (to prevent
premature commits ore push).
*Implementation*
Hooks are just plain shell scripts that are placed in .git/hooks, so we can
provide a simple executable "pre-commit" script that runs "gradlew precommit"
and a gradle Copy task to copy it under local .git/hooks dir.
*Usage*
Install pre-commit hook (opt-in)
{code:java}
./gradlew precommitHook
{code}
After installing, precommit will be automatically performed before every commit.
{code:java}
git commit -m "commit attempt that doesn't pass spotless check"
..
> Task :lucene:luke:spotlessJavaCheck FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> The following files had format violations:
..
// commit fails.
{code}
was:
With [githooks|https://git-scm.com/docs/githooks], one can automatically
perform arbitrary checks (e.g. "precommit") when before performing "git commit".
I found the "precommit" check is now pretty fast on main branch, it might make
sense for developers who want to run it in an automated manner (to prevent
premature commits ore push).
*Implementation*
Hooks are just plain shell scripts that are placed in .git/hooks, so we can
provide a simple executable "pre-commit" script that runs "gradlew precommit"
and a gradle Copy task to copy it under local .git/hooks dir.
*Usage*
Install pre-commit hook (opt-in)
{code:java}
./gradlew precommitHook
{code}
After installing, precommit will be automatically performed before every commit.
{code:java}
git commit -m "commit attempt that doesn't pass spotless check"
..
> Task :lucene:luke:spotlessJavaCheck FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> The following files had format violations:
..
{code}
> Optionally allow to enable git pre-commit hook for precommit
>
>
> Key: LUCENE-10028
> URL: https://issues.apache.org/jira/browse/LUCENE-10028
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
>Reporter: Tomoko Uchida
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With [githooks|https://git-scm.com/docs/githooks], one can automatically
> perform arbitrary checks (e.g. "precommit") when before performing "git
> commit".
> I found the "precommit" check is now pretty fast on main branch, it might
> make sense for developers who want to run it in an automated manner (to
> prevent premature commits ore push).
> *Implementation*
> Hooks are just plain shell scripts that are placed in .git/hooks, so we can
> provide a simple executable "pre-commit" script that runs "gradlew precommit"
> and a gradle Copy task to copy it under local .git/hooks dir.
> *Usage*
> Install pre-commit hook (opt-in)
> {code:java}
> ./gradlew precommitHook
> {code}
> After installing, precommit will be automatically performed before every
> commit.
> {code:java}
> git commit -m "commit attempt that doesn't pass spotless check"
> ..
> > Task :lucene:luke:spotlessJavaCheck FAILED
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> > The following files had format violations:
> ..
> // commit fails.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit
[
https://issues.apache.org/jira/browse/LUCENE-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-10028:
---
Description:
With [githooks|https://git-scm.com/docs/githooks], one can automatically
perform arbitrary checks (e.g. "precommit") when before performing "git commit".
I found the "precommit" check is now pretty fast on main branch, it might make
sense for developers who want to run it in an automated manner (to prevent
premature commits ore push).
*Implementation*
Hooks are just plain shell scripts that are placed in .git/hooks, so we can
provide a simple executable "pre-commit" script that runs "gradlew precommit"
and a gradle Copy task to copy it under local .git/hooks dir.
*Usage*
Install pre-commit hook (opt-in)
{code:java}
./gradlew precommitHook
{code}
After installing, precommit will be automatically performed before every commit.
{code:java}
git commit -m "commit attempt that doesn't pass spotless check"
..
> Task :lucene:luke:spotlessJavaCheck FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> The following files had format violations:
..
// commit fails.
{code}
As another option, one could use pre-push hook.
was:
With [githooks|https://git-scm.com/docs/githooks], one can automatically
perform arbitrary checks (e.g. "precommit") when before performing "git commit".
I found the "precommit" check is now pretty fast on main branch, it might make
sense for developers who want to run it in an automated manner (to prevent
premature commits ore push).
*Implementation*
Hooks are just plain shell scripts that are placed in .git/hooks, so we can
provide a simple executable "pre-commit" script that runs "gradlew precommit"
and a gradle Copy task to copy it under local .git/hooks dir.
*Usage*
Install pre-commit hook (opt-in)
{code:java}
./gradlew precommitHook
{code}
After installing, precommit will be automatically performed before every commit.
{code:java}
git commit -m "commit attempt that doesn't pass spotless check"
..
> Task :lucene:luke:spotlessJavaCheck FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> The following files had format violations:
..
// commit fails.
{code}
> Optionally allow to enable git pre-commit hook for precommit
>
>
> Key: LUCENE-10028
> URL: https://issues.apache.org/jira/browse/LUCENE-10028
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
>Reporter: Tomoko Uchida
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With [githooks|https://git-scm.com/docs/githooks], one can automatically
> perform arbitrary checks (e.g. "precommit") when before performing "git
> commit".
> I found the "precommit" check is now pretty fast on main branch, it might
> make sense for developers who want to run it in an automated manner (to
> prevent premature commits ore push).
> *Implementation*
> Hooks are just plain shell scripts that are placed in .git/hooks, so we can
> provide a simple executable "pre-commit" script that runs "gradlew precommit"
> and a gradle Copy task to copy it under local .git/hooks dir.
> *Usage*
> Install pre-commit hook (opt-in)
> {code:java}
> ./gradlew precommitHook
> {code}
> After installing, precommit will be automatically performed before every
> commit.
> {code:java}
> git commit -m "commit attempt that doesn't pass spotless check"
> ..
> > Task :lucene:luke:spotlessJavaCheck FAILED
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> > The following files had format violations:
> ..
> // commit fails.
> {code}
> As another option, one could use pre-push hook.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10028) Optionally allow to enable git pre-commit hook for precommit
[
https://issues.apache.org/jira/browse/LUCENE-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382564#comment-17382564
]
Tomoko Uchida commented on LUCENE-10028:
I opened a draft PR to provide a working example; this works for me (on linux
setup) but isn't perfect. If there is anyone who is interested in it, I think
we can refine or finish the implementation.
> Optionally allow to enable git pre-commit hook for precommit
>
>
> Key: LUCENE-10028
> URL: https://issues.apache.org/jira/browse/LUCENE-10028
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
>Reporter: Tomoko Uchida
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> With [githooks|https://git-scm.com/docs/githooks], one can automatically
> perform arbitrary checks (e.g. "precommit") when before performing "git
> commit".
> I found the "precommit" check is now pretty fast on main branch, it might
> make sense for developers who want to run it in an automated manner (to
> prevent premature commits ore push).
> *Implementation*
> Hooks are just plain shell scripts that are placed in .git/hooks, so we can
> provide a simple executable "pre-commit" script that runs "gradlew precommit"
> and a gradle Copy task to copy it under local .git/hooks dir.
> *Usage*
> Install pre-commit hook (opt-in)
> {code:java}
> ./gradlew precommitHook
> {code}
> After installing, precommit will be automatically performed before every
> commit.
> {code:java}
> git commit -m "commit attempt that doesn't pass spotless check"
> ..
> > Task :lucene:luke:spotlessJavaCheck FAILED
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':lucene:luke:spotlessJavaCheck'.
> > The following files had format violations:
> ..
> // commit fails.
> {code}
> As another option, one could use pre-push hook.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] msokolov commented on pull request #210: LUCENE-10016: remove fanout parameter from nearest neighbor vector search
msokolov commented on pull request #210: URL: https://github.com/apache/lucene/pull/210#issuecomment-881912928 OK! Thanks for the discussion. We can always revisit when we have an actual need for a parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] msokolov merged pull request #210: LUCENE-10016: remove fanout parameter from nearest neighbor vector search
msokolov merged pull request #210: URL: https://github.com/apache/lucene/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?
[
https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382588#comment-17382588
]
ASF subversion and git services commented on LUCENE-10016:
--
Commit 9b5e23396092ea1d4cfb19c8a996b8fc118c33e8 in lucene's branch
refs/heads/main from Michael Sokolov
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=9b5e233 ]
LUCENE-10016: remove fanout parameter from nearest neighbor vector search (#210)
> VectorReader.search needs rethought, o.a.l.search integration?
> --
>
> Key: LUCENE-10016
> URL: https://issues.apache.org/jira/browse/LUCENE-10016
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Robert Muir
>Priority: Blocker
> Fix For: 9.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There's no search integration (e.g. queries) for the current vector values,
> no documentation/examples that I can find.
> Instead the codec has this method:
> {code}
> TopDocs search(String field, float[] target, int k, int fanout)
> {code}
> First, the "fanout" parameter needs to go, this is specific to HNSW impl, get
> it out of here.
> Second, How am I supposed to skip over deleted documents? How can I use
> filters? How should i search across multiple segments?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on a change in pull request #215: LUCENE-10028: Add git pre-commit hook that runs precommit task.
dweiss commented on a change in pull request #215: URL: https://github.com/apache/lucene/pull/215#discussion_r671789348 ## File path: dev-tools/git/hooks/pre-commit ## @@ -0,0 +1,7 @@ +#!/usr/bin/sh +# +# Run precommit check +# + +## TODO: Windows support Review comment: I think the precommitHook task could detect the OS it's running on and copy an appropriate implementation (or fail if there is none available). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
