[jira] [Updated] (LUCENE-9328) SortingGroupHead to reuse DocValues
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Attachment: LUCENE-9328.patch Status: Patch Available (was: Patch Available) > SortingGroupHead to reuse DocValues > --- > > Key: LUCENE-9328 > URL: https://issues.apache.org/jira/browse/LUCENE-9328 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/grouping >Reporter: Mikhail Khludnev >Priority: Minor > Attachments: LUCENE-9328.patch, LUCENE-9328.patch, LUCENE-9328.patch > > > That's why > https://issues.apache.org/jira/browse/LUCENE-7701?focusedCommentId=17084365&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17084365 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] mrsoong opened a new pull request #1457: SOLR-13184: Added a null check in FunctionQParser.parseArg()
mrsoong opened a new pull request #1457: URL: https://github.com/apache/lucene-solr/pull/1457 # Description FunctionQParser.parseArg() did not throw an error when it failed to properly deference a parameter. This would cause a NPE later in JoinDocFreqValueSource.hashCode() where qfield is expected to be non-null. # Solution Added a check in FunctionQParser.parseArg() for null parameters # Tests Added an extra test in QueryParsingTest.testGetQParser() to check for NPEs resulting from invalid inputs # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. **(Existing issue)** - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14419) Query DLS paramter $reference
[ https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-14419: Description: What we can do with plain params: {{q=\{!parent which=$prnts}...&prnts=type:parent}} obviously I want to have something like this in Query DSL: {code} { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}} "params": { "prnts":"type:parent" } } {code} was: What we can do with plain params: {{q=\{!parent which=$prnts}...&prnts=type:parent}} obviously I want to have something like this in Query DSL: {code} { "query": { "parents":{ "which":"$prnts", "query":"..."}} "params": { "prnts":"type:parent" } } {code} > Query DLS paramter $reference > - > > Key: SOLR-14419 > URL: https://issues.apache.org/jira/browse/SOLR-14419 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: JSON Request API >Reporter: Mikhail Khludnev >Priority: Major > > What we can do with plain params: > {{q=\{!parent which=$prnts}...&prnts=type:parent}} > obviously I want to have something like this in Query DSL: > {code} > { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}} > "params": { > "prnts":"type:parent" >} > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14419) Query DLS paramter $reference
[ https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092394#comment-17092394 ] Mikhail Khludnev commented on SOLR-14419: - attaching -w patch for easier review. > Query DLS paramter $reference > - > > Key: SOLR-14419 > URL: https://issues.apache.org/jira/browse/SOLR-14419 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: JSON Request API >Reporter: Mikhail Khludnev >Priority: Major > Attachments: SOLR-14419.patch > > > What we can do with plain params: > {{q=\{!parent which=$prnts}...&prnts=type:parent}} > obviously I want to have something like this in Query DSL: > {code} > { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}} > "params": { > "prnts":"type:parent" >} > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14419) Query DLS paramter $reference
[ https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-14419: Attachment: SOLR-14419.patch > Query DLS paramter $reference > - > > Key: SOLR-14419 > URL: https://issues.apache.org/jira/browse/SOLR-14419 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: JSON Request API >Reporter: Mikhail Khludnev >Priority: Major > Attachments: SOLR-14419.patch > > > What we can do with plain params: > {{q=\{!parent which=$prnts}...&prnts=type:parent}} > obviously I want to have something like this in Query DSL: > {code} > { "query": { "parents":{ "which":{"param":"prnts"}, "query":"..."}} > "params": { > "prnts":"type:parent" >} > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14421) New examples in solr.in.cmd in Solr 8.5 don't work as provided
[ https://issues.apache.org/jira/browse/SOLR-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092413#comment-17092413 ] Marcus Eagan commented on SOLR-14421: - I think we need to consider reopening this ticket because I am still seeing issues in master. > New examples in solr.in.cmd in Solr 8.5 don't work as provided > -- > > Key: SOLR-14421 > URL: https://issues.apache.org/jira/browse/SOLR-14421 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.5, 8.5.1 >Reporter: Colvin Cowie >Assignee: Jan Høydahl >Priority: Trivial > Fix For: 8.6 > > Attachments: SOLR-14421.patch > > > > These SOLR_OPTS examples need to be prefixed with _set_ and don't work when > surrounded with quotes > [https://github.com/apache/lucene-solr/blob/master/solr/bin/solr.in.cmd#L194-L199] > {noformat} > REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.environment=prod" > REM Specifies the path to a common library directory that will be shared > across all cores. > REM Any JAR files in this directory will be added to the search path for Solr > plugins. > REM If the specified path is not absolute, it will be relative to > `%SOLR_HOME%`. > REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.sharedLib=/path/to/lib" > {noformat} > Without set you will get "_'SOLR_OPTS' is not recognized as an internal or > external command, operable program or batch file_." > After adding _set,_ with the quotes you get _"-Dsolr.environment=prod was > unexpected at this time."_ > I'll attach a patch > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-14421) New examples in solr.in.cmd in Solr 8.5 don't work as provided
[ https://issues.apache.org/jira/browse/SOLR-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092413#comment-17092413 ] Marcus Eagan edited comment on SOLR-14421 at 4/25/20, 11:21 PM: I think we need to consider reopening this ticket because I am still seeing issues in master on UNIX systems. was (Author: marcussorealheis): I think we need to consider reopening this ticket because I am still seeing issues in master. > New examples in solr.in.cmd in Solr 8.5 don't work as provided > -- > > Key: SOLR-14421 > URL: https://issues.apache.org/jira/browse/SOLR-14421 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.5, 8.5.1 >Reporter: Colvin Cowie >Assignee: Jan Høydahl >Priority: Trivial > Fix For: 8.6 > > Attachments: SOLR-14421.patch > > > > These SOLR_OPTS examples need to be prefixed with _set_ and don't work when > surrounded with quotes > [https://github.com/apache/lucene-solr/blob/master/solr/bin/solr.in.cmd#L194-L199] > {noformat} > REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.environment=prod" > REM Specifies the path to a common library directory that will be shared > across all cores. > REM Any JAR files in this directory will be added to the search path for Solr > plugins. > REM If the specified path is not absolute, it will be relative to > `%SOLR_HOME%`. > REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.sharedLib=/path/to/lib" > {noformat} > Without set you will get "_'SOLR_OPTS' is not recognized as an internal or > external command, operable program or batch file_." > After adding _set,_ with the quotes you get _"-Dsolr.environment=prod was > unexpected at this time."_ > I'll attach a patch > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-14421) New examples in solr.in.cmd in Solr 8.5 don't work as provided
[ https://issues.apache.org/jira/browse/SOLR-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcus Eagan updated SOLR-14421: Comment: was deleted (was: I think we need to consider reopening this ticket because I am still seeing issues in master on UNIX systems.) > New examples in solr.in.cmd in Solr 8.5 don't work as provided > -- > > Key: SOLR-14421 > URL: https://issues.apache.org/jira/browse/SOLR-14421 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 8.5, 8.5.1 >Reporter: Colvin Cowie >Assignee: Jan Høydahl >Priority: Trivial > Fix For: 8.6 > > Attachments: SOLR-14421.patch > > > > These SOLR_OPTS examples need to be prefixed with _set_ and don't work when > surrounded with quotes > [https://github.com/apache/lucene-solr/blob/master/solr/bin/solr.in.cmd#L194-L199] > {noformat} > REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.environment=prod" > REM Specifies the path to a common library directory that will be shared > across all cores. > REM Any JAR files in this directory will be added to the search path for Solr > plugins. > REM If the specified path is not absolute, it will be relative to > `%SOLR_HOME%`. > REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.sharedLib=/path/to/lib" > {noformat} > Without set you will get "_'SOLR_OPTS' is not recognized as an internal or > external command, operable program or batch file_." > After adding _set,_ with the quotes you get _"-Dsolr.environment=prod was > unexpected at this time."_ > I'll attach a patch > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092428#comment-17092428 ] Lucene/Solr QA commented on LUCENE-9328: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Release audit (RAT) {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Check forbidden APIs {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} Validate source patterns {color} | {color:green} 0m 18s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 10s{color} | {color:green} grouping in the patch passed. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 2m 26s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | LUCENE-9328 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13001169/LUCENE-9328.patch | | Optional Tests | compile javac unit ratsources checkforbiddenapis validatesourcepatterns | | uname | Linux lucene2-us-west.apache.org 4.4.0-170-generic #199-Ubuntu SMP Thu Nov 14 01:45:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | ant | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh | | git revision | master / ecc98e8 | | ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 | | Default Java | LTS | | Test Results | https://builds.apache.org/job/PreCommit-LUCENE-Build/265/testReport/ | | modules | C: lucene/grouping U: lucene/grouping | | Console output | https://builds.apache.org/job/PreCommit-LUCENE-Build/265/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > SortingGroupHead to reuse DocValues > --- > > Key: LUCENE-9328 > URL: https://issues.apache.org/jira/browse/LUCENE-9328 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/grouping >Reporter: Mikhail Khludnev >Priority: Minor > Attachments: LUCENE-9328.patch, LUCENE-9328.patch, LUCENE-9328.patch > > > That's why > https://issues.apache.org/jira/browse/LUCENE-7701?focusedCommentId=17084365&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17084365 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-1302) Fun with Distances - Add Distance functions for a variety of things
[ https://issues.apache.org/jira/browse/SOLR-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092490#comment-17092490 ] David Smiley commented on SOLR-1302: Notice: This (old) issue introduced {{ghhsin()}} and {{geohash()}} function queries (ValueSources). I'm inclined to delete these for 9.x because it's not clear to me they have much value now (or if they ever did?). They could be distracting to users ("oh do I need this; maybe not") and I'd rather us not continue to maintain what isn't useful. Likewise, I deprecated GeohashField (and un-documented it) a few years ago and am removing it for 9.x. > Fun with Distances - Add Distance functions for a variety of things > --- > > Key: SOLR-1302 > URL: https://issues.apache.org/jira/browse/SOLR-1302 > Project: Solr > Issue Type: New Feature >Reporter: Grant Ingersoll >Assignee: Grant Ingersoll >Priority: Minor > Fix For: 1.5, 3.1, 4.0-ALPHA > > Attachments: SOLR-1302.patch, SOLR-1302.patch, SOLR-1302.patch > > > There are many distance functions that are useful to have: > 1. Great Circle (lat/lon) and other geo distances > 2. Euclidean (Vector) > 3. Manhattan (Vector) > 4. Cosine (Vector) > For the vector ones, the idea is that the fields on a document can be used to > determine the vector. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9255) ValueSource Has Generic Typing Issues
[ https://issues.apache.org/jira/browse/LUCENE-9255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092492#comment-17092492 ] David Smiley commented on LUCENE-9255: -- Agreed [~romseygeek]. But Solr's use of something shouldn't prevent Lucene from getting rid of it; just move it. > ValueSource Has Generic Typing Issues > - > > Key: LUCENE-9255 > URL: https://issues.apache.org/jira/browse/LUCENE-9255 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Atri Sharma >Priority: Major > > ValueSource uses a bunch of weakly typed members which raises compiler > issues. We need to fix this in ValueSource and all of its subclasses. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8638) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092514#comment-17092514 ] David Smiley commented on LUCENE-8638: -- I fixed up the branch a lot; mostly Solr but I'll leave that discussion for SOLR-13138 The removal of the deprecated method SloppyMath.haversinKilometers (in lieu of haversineMeters) has the unfortunate side effect of changing the definition of the {{haversine()}} function in the expressions module which is mapped to that method. In the patch I fixed the reference and the tests so it compiles and tests pass. _However_, that's a super sneaky back-compat break. Instead we should probably retain the current semantics either by just keeping the method or by moving this method into the expressions module as an internal detail. > Remove deprecated code in master > > > Key: LUCENE-8638 > URL: https://issues.apache.org/jira/browse/LUCENE-8638 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward >Priority: Major > Fix For: master (9.0) > > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-13138) Remove deprecated code in master
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092515#comment-17092515 ] David Smiley commented on SOLR-13138: - I did merge it and fixed things up so that tests pass. Come to think of it I didn't run *all* tests so maybe there's more to do. > Remove deprecated code in master > > > Key: SOLR-13138 > URL: https://issues.apache.org/jira/browse/SOLR-13138 > Project: Solr > Issue Type: Improvement >Affects Versions: master (9.0) >Reporter: Alan Woodward >Priority: Major > > There are a number of deprecations in master that should be removed. This > issue is to keep track of deprecations as a whole, some individual > deprecations may require their own issues. > > Work on this issue should be pushed to the `master-deprecations` branch on > gitbox. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Assigned] (SOLR-14237) Add authenticated user principal in Solr admin UI
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reassigned SOLR-14237: --- Assignee: Ishan Chattopadhyaya > Add authenticated user principal in Solr admin UI > - > > Key: SOLR-14237 > URL: https://issues.apache.org/jira/browse/SOLR-14237 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: mosh >Assignee: Ishan Chattopadhyaya >Priority: Major > Labels: AdminUI, kerberos, security > > When user is logged in to Solr's admin UI using Kerberos, no authentication > info is displayed. > It would be very useful to see the logged in user principal. This could be > specially crucial when SSO is being used and user not always aware that Solr > is even configured with authentication mechanism. > +Info should include:+ > 1. user principal > 2. mapped role (in case authorization plugin is also configured) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14237) Add authenticated user principal in Solr admin UI
[ https://issues.apache.org/jira/browse/SOLR-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-14237: Attachment: SOLR-14237.patch Status: Open (was: Open) Here's an initial patch. Some more work remains. This shows the user principal, but doesn't yet show the mapped roles. > Add authenticated user principal in Solr admin UI > - > > Key: SOLR-14237 > URL: https://issues.apache.org/jira/browse/SOLR-14237 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI >Reporter: mosh >Assignee: Ishan Chattopadhyaya >Priority: Major > Labels: AdminUI, kerberos, security > Attachments: SOLR-14237.patch > > > When user is logged in to Solr's admin UI using Kerberos, no authentication > info is displayed. > It would be very useful to see the logged in user principal. This could be > specially crucial when SSO is being used and user not always aware that Solr > is even configured with authentication mechanism. > +Info should include:+ > 1. user principal > 2. mapped role (in case authorization plugin is also configured) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org