[jira] [Commented] (SOLR-14038) Admin UI display for "state.json" should be in a scollable region

[Lucene/Solr QA (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023494#comment-17023494
 ] 

Lucene/Solr QA commented on SOLR-14038:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  0m  3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:black}{color} | {color:black} {color} | {color:black}  0m 37s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-14038 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12991811/SOLR-14038.patch |
| Optional Tests |  validatesourcepatterns  |
| uname | Linux lucene2-us-west.apache.org 4.4.0-170-generic #199-Ubuntu SMP 
Thu Nov 14 01:45:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 127ce3e |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018 |
| modules | C: solr/webapp U: solr/webapp |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/664/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> Admin UI display for "state.json" should be in a scollable region
> -
>
> Key: SOLR-14038
> URL: https://issues.apache.org/jira/browse/SOLR-14038
> Project: Solr
>  Issue Type: Bug
>  Components: Admin UI
>Reporter: Erick Erickson
>Assignee: Kevin Risden
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-14038.patch, Screen Shot 2019-12-09 at 3.19.53 
> PM.png
>
>
> Probably a result of some of the recent changes to the admin UI. See attached 
> screenshot



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] dweiss commented on issue #1207: LUCENE-9169: Add Github Workflow for Gradle Wrapper Validation

[GitBox]

dweiss commented on issue #1207: LUCENE-9169: Add Github Workflow for Gradle 
Wrapper Validation
URL: https://github.com/apache/lucene-solr/pull/1207#issuecomment-578398492
 
 
   Ouch. I thought it is a free service? If it is a paid option then I will
   revert.
   
   D.
   
   On Sat, Jan 25, 2020, 01:04 Jan Høydahl  wrote:
   
   > This workflow was triggered on a push to my fork (
   > 
https://github.com/cominvent/lucene-solr/commit/9bae9c71ef632e141adedadc7ccfccabe2ca353d/checks?check_suite_id=419459737)
   > and I got an error email. Can you disable for forks?
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] eskatos commented on issue #1207: LUCENE-9169: Add Github Workflow for Gradle Wrapper Validation

[GitBox]

eskatos commented on issue #1207: LUCENE-9169: Add Github Workflow for Gradle 
Wrapper Validation
URL: https://github.com/apache/lucene-solr/pull/1207#issuecomment-578399059
 
 
   It's a free service. But Github organizations with legacy Github paid plans 
can't run Github Actions yet. I suppose `cominvent` has a legacy paid plan.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] eskatos commented on issue #1207: LUCENE-9169: Add Github Workflow for Gradle Wrapper Validation

[GitBox]

eskatos commented on issue #1207: LUCENE-9169: Add Github Workflow for Gradle 
Wrapper Validation
URL: https://github.com/apache/lucene-solr/pull/1207#issuecomment-578399978
 
 
   @janhoy, you can disable Github Actions on your fork, go to `Settings > 
Actions` and select `Disable Actions for this repository`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] eskatos edited a comment on issue #1207: LUCENE-9169: Add Github Workflow for Gradle Wrapper Validation

[GitBox]

eskatos edited a comment on issue #1207: LUCENE-9169: Add Github Workflow for 
Gradle Wrapper Validation
URL: https://github.com/apache/lucene-solr/pull/1207#issuecomment-578399059
 
 
   It's a free service. But Github organizations with legacy Github paid plans 
can't run Github Actions yet (they don't get free OSS minutes). I suppose 
`cominvent` has a legacy paid plan.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] eskatos commented on issue #1207: LUCENE-9169: Add Github Workflow for Gradle Wrapper Validation

[GitBox]

eskatos commented on issue #1207: LUCENE-9169: Add Github Workflow for Gradle 
Wrapper Validation
URL: https://github.com/apache/lucene-solr/pull/1207#issuecomment-578400830
 
 
   Also note that this isn't limited to this workflow. The existing 
`.github/workflows/ant.yml` caused the same issue on your fork 4 days ago. See 
https://github.com/cominvent/lucene-solr/actions


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost by payload

[GitBox]

alessandrobenedetti commented on issue #357: [SOLR-12238] Synonym Queries boost 
by payload 
URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-578403615
 
 
   I have been doing merge conflicts, a huge cleaning up and re-design.
   Most of the logic is now in Lucene Query Parser, this avoids passing back 
and forth token streams.
   It seems to me a much cleaner approach, happy to discuss
   
   TO DO:
   This is what I'll do next week
   - Add additional tests on Lucene Query Builder (that is green at the moment)
   - discuss about Paylod decoding and possible use of 
org.apache.lucene.analysis.payloads.PayloadHelper
   - discuss why "/*confirm autoGeneratePhraseQueries always builds OR 
queries*/ from org.apache.solr.search.TestSolrQueryParser#testSynonymQueryStyle


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Created] (LUCENE-9171) Synonyms Boost by Payload

[Alessandro Benedetti (Jira)]

Alessandro Benedetti created LUCENE-9171:


 Summary: Synonyms Boost by Payload
 Key: LUCENE-9171
 URL: https://issues.apache.org/jira/browse/LUCENE-9171
 Project: Lucene - Core
  Issue Type: New Feature
  Components: core/queryparser
Reporter: Alessandro Benedetti


I have been working in the additional capability of boosting queries by terms 
payload through a parameter to enable it in Lucene Query Builder.
This has been done targeting the Synonyms Query.
It is parametric, so it meant to see no difference unless the feature is 
enabled.
Solr has its bits to comply thorugh its SynonymsQueryStyles



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12238) Synonym Query Style Boost By Payload

[Alessandro Benedetti (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023539#comment-17023539
 ] 

Alessandro Benedetti commented on SOLR-12238:
-

The Lucene functionality is described here

> Synonym Query Style Boost By Payload
> 
>
> Key: SOLR-12238
> URL: https://issues.apache.org/jira/browse/SOLR-12238
> Project: Solr
>  Issue Type: Improvement
>  Components: query parsers
>Affects Versions: 7.2
>Reporter: Alessandro Benedetti
>Priority: Major
> Attachments: SOLR-12238.patch, SOLR-12238.patch, SOLR-12238.patch, 
> SOLR-12238.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This improvement is built on top of the Synonym Query Style feature and 
> brings the possibility of boosting synonym queries using the payload 
> associated.
> It introduces two new modalities for the Synonym Query Style :
> PICK_BEST_BOOST_BY_PAYLOAD -> build a Disjunction query with the clauses 
> boosted by payload
> AS_DISTINCT_TERMS_BOOST_BY_PAYLOAD -> build a Boolean query with the clauses 
> boosted by payload
> This new synonym query styles will assume payloads are available so they must 
> be used in conjunction with a token filter able to produce payloads.
> An synonym.txt example could be :
> # Synonyms used by Payload Boost
> tiger => tiger|1.0, Big_Cat|0.8, Shere_Khan|0.9
> leopard => leopard, Big_Cat|0.8, Bagheera|0.9
> lion => lion|1.0, panthera leo|0.99, Simba|0.8
> snow_leopard => panthera uncia|0.99, snow leopard|1.0
> A simple token filter to populate the payloads from such synonym.txt is :
>  delimiter="|"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (LUCENE-9171) Synonyms Boost by Payload

[Alessandro Benedetti (Jira)]

 [ 
https://issues.apache.org/jira/browse/LUCENE-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alessandro Benedetti updated LUCENE-9171:
-
Status: Patch Available  (was: Open)

> Synonyms Boost by Payload
> -
>
> Key: LUCENE-9171
> URL: https://issues.apache.org/jira/browse/LUCENE-9171
> Project: Lucene - Core
>  Issue Type: New Feature
>  Components: core/queryparser
>Reporter: Alessandro Benedetti
>Priority: Major
>
> I have been working in the additional capability of boosting queries by terms 
> payload through a parameter to enable it in Lucene Query Builder.
> This has been done targeting the Synonyms Query.
> It is parametric, so it meant to see no difference unless the feature is 
> enabled.
> Solr has its bits to comply thorugh its SynonymsQueryStyles



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9171) Synonyms Boost by Payload

[Alessandro Benedetti (Jira)]

[ 
https://issues.apache.org/jira/browse/LUCENE-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023541#comment-17023541
 ] 

Alessandro Benedetti commented on LUCENE-9171:
--

You can take a look to the Github Pull Request (that includes also the Solr 
changes).
I will add a set of tests also to the Lucene side.
Current questions:

- is this a clean approach keeping all the payload extraction from token 
streams Lucene side?

- discuss about Paylod decoding and possible use of 
org.apache.lucene.analysis.payloads.PayloadHelper (no visibility from core)

- need to evaluate better the part in: 
org/apache/lucene/util/QueryBuilder.java:629 
(org.apache.lucene.util.QueryBuilder#analyzeGraphBoolean)




> Synonyms Boost by Payload
> -
>
> Key: LUCENE-9171
> URL: https://issues.apache.org/jira/browse/LUCENE-9171
> Project: Lucene - Core
>  Issue Type: New Feature
>  Components: core/queryparser
>Reporter: Alessandro Benedetti
>Priority: Major
>
> I have been working in the additional capability of boosting queries by terms 
> payload through a parameter to enable it in Lucene Query Builder.
> This has been done targeting the Synonyms Query.
> It is parametric, so it meant to see no difference unless the feature is 
> enabled.
> Solr has its bits to comply thorugh its SynonymsQueryStyles



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9171) Synonyms Boost by Payload

[Alessandro Benedetti (Jira)]

[ 
https://issues.apache.org/jira/browse/LUCENE-9171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023543#comment-17023543
 ] 

Alessandro Benedetti commented on LUCENE-9171:
--

[~romseygeek] , [~jim.ferenczi] , [~jimczi] , [~dsmiley] , [~mikemccand] , 
[~shalin] : I noticed the last activity on the class was from you over the past 
few years, any review and consideration would be welcome :)

> Synonyms Boost by Payload
> -
>
> Key: LUCENE-9171
> URL: https://issues.apache.org/jira/browse/LUCENE-9171
> Project: Lucene - Core
>  Issue Type: New Feature
>  Components: core/queryparser
>Reporter: Alessandro Benedetti
>Priority: Major
>
> I have been working in the additional capability of boosting queries by terms 
> payload through a parameter to enable it in Lucene Query Builder.
> This has been done targeting the Synonyms Query.
> It is parametric, so it meant to see no difference unless the feature is 
> enabled.
> Solr has its bits to comply thorugh its SynonymsQueryStyles



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] uschindler commented on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank()

[GitBox]

uschindler commented on issue #1172: SOLR-14189 switch from String.trim() to 
StringUtils.isBlank()
URL: https://github.com/apache/lucene-solr/pull/1172#issuecomment-578404626
 
 
   IsBlank() is behaving fine. If you look at its source code all is checked:
   - null means blank
   - empty means blank
   - all remaining characters are tested on isWhitespace()
   
   So this is the best replacement. We should also look for similar patterns at 
other places in Solr.
   
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Comment Edited] (SOLR-12238) Synonym Query Style Boost By Payload

[Alessandro Benedetti (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023539#comment-17023539
 ] 

Alessandro Benedetti edited comment on SOLR-12238 at 1/25/20 1:05 PM:
--

I linked the related Lucene Jira, resolved all conflicts and re-engineered the 
approach hopefully in a cleaner way.
I tagged in the Lucene issue all the relevant people that worked on this in the 
last few years.

Solr tests have been hugely refined and next steps will be oriented to the 
Lucene Query Builder tests.


was (Author: alessandro.benedetti):
The Lucene functionality is described here

> Synonym Query Style Boost By Payload
> 
>
> Key: SOLR-12238
> URL: https://issues.apache.org/jira/browse/SOLR-12238
> Project: Solr
>  Issue Type: Improvement
>  Components: query parsers
>Affects Versions: 7.2
>Reporter: Alessandro Benedetti
>Priority: Major
> Attachments: SOLR-12238.patch, SOLR-12238.patch, SOLR-12238.patch, 
> SOLR-12238.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This improvement is built on top of the Synonym Query Style feature and 
> brings the possibility of boosting synonym queries using the payload 
> associated.
> It introduces two new modalities for the Synonym Query Style :
> PICK_BEST_BOOST_BY_PAYLOAD -> build a Disjunction query with the clauses 
> boosted by payload
> AS_DISTINCT_TERMS_BOOST_BY_PAYLOAD -> build a Boolean query with the clauses 
> boosted by payload
> This new synonym query styles will assume payloads are available so they must 
> be used in conjunction with a token filter able to produce payloads.
> An synonym.txt example could be :
> # Synonyms used by Payload Boost
> tiger => tiger|1.0, Big_Cat|0.8, Shere_Khan|0.9
> leopard => leopard, Big_Cat|0.8, Bagheera|0.9
> lion => lion|1.0, panthera leo|0.99, Simba|0.8
> snow_leopard => panthera uncia|0.99, snow leopard|1.0
> A simple token filter to populate the payloads from such synonym.txt is :
>  delimiter="|"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Comment Edited] (SOLR-12238) Synonym Query Style Boost By Payload

[Alessandro Benedetti (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023539#comment-17023539
 ] 

Alessandro Benedetti edited comment on SOLR-12238 at 1/25/20 1:05 PM:
--

PR have been hugely updated
I linked the related Lucene Jira, resolved all conflicts and re-engineered the 
approach hopefully in a cleaner way.
I tagged in the Lucene issue all the relevant people that worked on this in the 
last few years.

Solr tests have been hugely refined and next steps will be oriented to the 
Lucene Query Builder tests.


was (Author: alessandro.benedetti):
I linked the related Lucene Jira, resolved all conflicts and re-engineered the 
approach hopefully in a cleaner way.
I tagged in the Lucene issue all the relevant people that worked on this in the 
last few years.

Solr tests have been hugely refined and next steps will be oriented to the 
Lucene Query Builder tests.

> Synonym Query Style Boost By Payload
> 
>
> Key: SOLR-12238
> URL: https://issues.apache.org/jira/browse/SOLR-12238
> Project: Solr
>  Issue Type: Improvement
>  Components: query parsers
>Affects Versions: 7.2
>Reporter: Alessandro Benedetti
>Priority: Major
> Attachments: SOLR-12238.patch, SOLR-12238.patch, SOLR-12238.patch, 
> SOLR-12238.patch
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This improvement is built on top of the Synonym Query Style feature and 
> brings the possibility of boosting synonym queries using the payload 
> associated.
> It introduces two new modalities for the Synonym Query Style :
> PICK_BEST_BOOST_BY_PAYLOAD -> build a Disjunction query with the clauses 
> boosted by payload
> AS_DISTINCT_TERMS_BOOST_BY_PAYLOAD -> build a Boolean query with the clauses 
> boosted by payload
> This new synonym query styles will assume payloads are available so they must 
> be used in conjunction with a token filter able to produce payloads.
> An synonym.txt example could be :
> # Synonyms used by Payload Boost
> tiger => tiger|1.0, Big_Cat|0.8, Shere_Khan|0.9
> leopard => leopard, Big_Cat|0.8, Bagheera|0.9
> lion => lion|1.0, panthera leo|0.99, Simba|0.8
> snow_leopard => panthera uncia|0.99, snow leopard|1.0
> A simple token filter to populate the payloads from such synonym.txt is :
>  delimiter="|"/>



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] uschindler edited a comment on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank()

[GitBox]

uschindler edited a comment on issue #1172: SOLR-14189 switch from 
String.trim() to StringUtils.isBlank()
URL: https://github.com/apache/lucene-solr/pull/1172#issuecomment-578404626
 
 
   IsBlank() is behaving fine. If you look at its source code all is checked:
   - null means blank
   - empty means blank
   - all remaining characters are tested on isWhitespace(), if one non-ws found 
it bails out with false.
   
   So common case is fast.
   
   So this is the best replacement. We should also look for similar patterns at 
other places in Solr.
   
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Assigned] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Mikhail Khludnev (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev reassigned SOLR-12325:
---

Assignee: Mikhail Khludnev

> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Attachments: SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Mikhail Khludnev (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated SOLR-12325:

   Attachment: SOLR-12325.patch
Fix Version/s: 8.5
   Status: Patch Available  (was: Patch Available)

Slightly reworked the patch. Drop some redundancy. Switched to little bit more 
verbose {{fp.parseNestedQuery()}} to avoid syntax problem. Although, now the 
syntax is a little bit \{!v=scary} 

> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] andywebb1975 commented on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank()

[GitBox]

andywebb1975 commented on issue #1172: SOLR-14189 switch from String.trim() to 
StringUtils.isBlank()
URL: https://github.com/apache/lucene-solr/pull/1172#issuecomment-578408900
 
 
   hi Christine - thanks for looking at this, and for the tip! I've made the 
change to use `StringUtils.isBlank()`, which efficiency-wise looks just the 
same as `isWhitespace()` to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] andywebb1975 edited a comment on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank()

[GitBox]

andywebb1975 edited a comment on issue #1172: SOLR-14189 switch from 
String.trim() to StringUtils.isBlank()
URL: https://github.com/apache/lucene-solr/pull/1172#issuecomment-578408900
 
 
   hi Christine - thanks for looking at this, and for the tip! I've made the 
change to use `StringUtils.isBlank()`, which efficiency-wise looks just the 
same as `isWhitespace()` to me.
   
   (And thanks Uwe too - I'd had this page open for a few hours and didn't see 
your comment above til I posted mine.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] andywebb1975 commented on issue #1172: SOLR-14189 switch from String.trim() to StringUtils.isBlank()

[GitBox]

andywebb1975 commented on issue #1172: SOLR-14189 switch from String.trim() to 
StringUtils.isBlank()
URL: https://github.com/apache/lucene-solr/pull/1172#issuecomment-578409637
 
 
   I previously did a quick grep looking for `.trim(` and found these three 
instances that were obvious ones to change. The edismax instance is biting us 
as we get occasional exceptions in production due to junk queries, so that was 
my priority. There are lots more that could change, though I suspect they're 
much less likely to receive other unusual whitespace chars than the query 
parsers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9170) wagon-ssh Maven HTTPS issue

[Uwe Schindler (Jira)]

[ 
https://issues.apache.org/jira/browse/LUCENE-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023580#comment-17023580
 ] 

Uwe Schindler commented on LUCENE-9170:
---

Does anybody has an explanation why this happens. The fix just enforced the 
repo to use, but is this a big in the Maven ant tasks?

> wagon-ssh Maven HTTPS issue
> ---
>
> Key: LUCENE-9170
> URL: https://issues.apache.org/jira/browse/LUCENE-9170
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Ishan Chattopadhyaya
>Assignee: Ishan Chattopadhyaya
>Priority: Blocker
> Fix For: 8.5
>
> Attachments: LUCENE-9170.patch, LUCENE-9170.patch
>
>
> When I do, from lucene/ in branch_8_4:
> ant -Dversion=8.4.2 generate-maven-artifacts 
> I see that wagon-ssh is being resolved from http://repo1.maven.org/maven2 
> instead of https equivalent. This is surprising to me, since I can't find the 
> http URL anywhere.
> Here's my log:
> https://paste.centos.org/view/be2d3f3f
> This is a critical issue since releases won't work without this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Comment Edited] (LUCENE-9170) wagon-ssh Maven HTTPS issue

[Uwe Schindler (Jira)]

[ 
https://issues.apache.org/jira/browse/LUCENE-9170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023580#comment-17023580
 ] 

Uwe Schindler edited comment on LUCENE-9170 at 1/25/20 2:15 PM:


Does anybody has an explanation why this happens? The fix just enforces the 
repo to use, but is this a bug in the Maven ant tasks?


was (Author: thetaphi):
Does anybody has an explanation why this happens. The fix just enforced the 
repo to use, but is this a big in the Maven ant tasks?

> wagon-ssh Maven HTTPS issue
> ---
>
> Key: LUCENE-9170
> URL: https://issues.apache.org/jira/browse/LUCENE-9170
> Project: Lucene - Core
>  Issue Type: Bug
>Reporter: Ishan Chattopadhyaya
>Assignee: Ishan Chattopadhyaya
>Priority: Blocker
> Fix For: 8.5
>
> Attachments: LUCENE-9170.patch, LUCENE-9170.patch
>
>
> When I do, from lucene/ in branch_8_4:
> ant -Dversion=8.4.2 generate-maven-artifacts 
> I see that wagon-ssh is being resolved from http://repo1.maven.org/maven2 
> instead of https equivalent. This is surprising to me, since I can't find the 
> http URL anywhere.
> Here's my log:
> https://paste.centos.org/view/be2d3f3f
> This is a critical issue since releases won't work without this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Created] (SOLR-14217) tests respect tests.workDir correctly (prevent SSD destruction)

[Robert Muir (Jira)]

Robert Muir created SOLR-14217:
--

 Summary: tests respect tests.workDir correctly (prevent SSD 
destruction)
 Key: SOLR-14217
 URL: https://issues.apache.org/jira/browse/SOLR-14217
 Project: Solr
  Issue Type: Bug
  Security Level: Public (Default Security Level. Issues are Public)
  Components: Tests
Reporter: Robert Muir


To prevent SSD destruction you should be able to set in your 
{{gradle.properties}}:

{code}
tests.workDir=/tmp/lucene_gradle
{code}

This causes all tests to write their temporary stuff (e.g. indexes) to that 
location, instead of build/ directories inside the checkout.

Unfortunately if you do this, some solr tests fail, because their configs will 
then try to reach out to invalid places. It happens because they load up 
configuration files with logic that looks like this:

{code}

{code}

Because {{solr.install.dir}} is not set, it falls back to an inappropriate 
relative path, and tries to access bogus locations on the filesystem, causing 
tests to fail:

{noformat}
  2> Caused by: org.apache.solr.common.SolrException: Error loading solr config 
from 
/tmp/lucene_gradle/solr.client.solrj.embedded.SolrExampleJettyTest_FF93943C1C04FCAC-001/tempDir-001/collection1/conf/solrconfig.xml
  2>at 
org.apache.solr.core.SolrConfig.readFromResourceLoader(SolrConfig.java:157)
  2>at 
org.apache.solr.core.ConfigSetService.createSolrConfig(ConfigSetService.java:111)
  2>at 
org.apache.solr.core.ConfigSetService.loadConfigSet(ConfigSetService.java:82)
  2>... 8 more
  2> Caused by: java.security.AccessControlException: access denied 
("java.io.FilePermission" 
"/tmp/lucene_gradle/solr.client.solrj.embedded.SolrExampleJettyTest_FF93943C1C04FCAC-001/tempDir-001/collection1/../../../../contrib/extraction/lib"
 "read")
  2>at 
java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:472)
  2>at 
java.base/java.security.AccessController.checkPermission(AccessController.java:1036)
  2>at 
java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:408)
  2>at 
java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:747)
  2>at java.base/sun.nio.fs.UnixPath.checkRead(UnixPath.java:818)
  2>at 
java.base/sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:399)
  2>at java.base/java.nio.file.Files.newDirectoryStream(Files.java:607)
  2>at 
org.apache.solr.core.SolrResourceLoader.getURLs(SolrResourceLoader.java:286)
  2>at 
org.apache.solr.core.SolrResourceLoader.getFilteredURLs(SolrResourceLoader.java:319)
  2>at org.apache.solr.core.SolrConfig.initLibs(SolrConfig.java:782)
  2>at org.apache.solr.core.SolrConfig.(SolrConfig.java:176)
  2>at 
org.apache.solr.core.SolrConfig.readFromResourceLoader(SolrConfig.java:149)
  2>... 10 more
{noformat}

The system property must be set so that these tests will work with the 
configured tests.workDir

It has no impact on tests speed, because solr tests are all sitting in 
Thread.sleep, not bottlenecked on anything related to this.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-14217) tests respect tests.workDir correctly (prevent SSD destruction)

[Robert Muir (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-14217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated SOLR-14217:
---
Attachment: SOLR-14217.patch

> tests respect tests.workDir correctly (prevent SSD destruction)
> ---
>
> Key: SOLR-14217
> URL: https://issues.apache.org/jira/browse/SOLR-14217
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Tests
>Reporter: Robert Muir
>Priority: Major
> Attachments: SOLR-14217.patch
>
>
> To prevent SSD destruction you should be able to set in your 
> {{gradle.properties}}:
> {code}
> tests.workDir=/tmp/lucene_gradle
> {code}
> This causes all tests to write their temporary stuff (e.g. indexes) to that 
> location, instead of build/ directories inside the checkout.
> Unfortunately if you do this, some solr tests fail, because their configs 
> will then try to reach out to invalid places. It happens because they load up 
> configuration files with logic that looks like this:
> {code}
>  regex=".*\.jar" />
> {code}
> Because {{solr.install.dir}} is not set, it falls back to an inappropriate 
> relative path, and tries to access bogus locations on the filesystem, causing 
> tests to fail:
> {noformat}
>   2> Caused by: org.apache.solr.common.SolrException: Error loading solr 
> config from 
> /tmp/lucene_gradle/solr.client.solrj.embedded.SolrExampleJettyTest_FF93943C1C04FCAC-001/tempDir-001/collection1/conf/solrconfig.xml
>   2>at 
> org.apache.solr.core.SolrConfig.readFromResourceLoader(SolrConfig.java:157)
>   2>at 
> org.apache.solr.core.ConfigSetService.createSolrConfig(ConfigSetService.java:111)
>   2>at 
> org.apache.solr.core.ConfigSetService.loadConfigSet(ConfigSetService.java:82)
>   2>... 8 more
>   2> Caused by: java.security.AccessControlException: access denied 
> ("java.io.FilePermission" 
> "/tmp/lucene_gradle/solr.client.solrj.embedded.SolrExampleJettyTest_FF93943C1C04FCAC-001/tempDir-001/collection1/../../../../contrib/extraction/lib"
>  "read")
>   2>at 
> java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:472)
>   2>at 
> java.base/java.security.AccessController.checkPermission(AccessController.java:1036)
>   2>at 
> java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:408)
>   2>at 
> java.base/java.lang.SecurityManager.checkRead(SecurityManager.java:747)
>   2>at java.base/sun.nio.fs.UnixPath.checkRead(UnixPath.java:818)
>   2>at 
> java.base/sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:399)
>   2>at java.base/java.nio.file.Files.newDirectoryStream(Files.java:607)
>   2>at 
> org.apache.solr.core.SolrResourceLoader.getURLs(SolrResourceLoader.java:286)
>   2>at 
> org.apache.solr.core.SolrResourceLoader.getFilteredURLs(SolrResourceLoader.java:319)
>   2>at org.apache.solr.core.SolrConfig.initLibs(SolrConfig.java:782)
>   2>at org.apache.solr.core.SolrConfig.(SolrConfig.java:176)
>   2>at 
> org.apache.solr.core.SolrConfig.readFromResourceLoader(SolrConfig.java:149)
>   2>... 10 more
> {noformat}
> The system property must be set so that these tests will work with the 
> configured tests.workDir
> It has no impact on tests speed, because solr tests are all sitting in 
> Thread.sleep, not bottlenecked on anything related to this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-5146) Figure out what it would take for lazily-loaded cores to play nice with SolrCloud

[Erick Erickson (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023591#comment-17023591
 ] 

Erick Erickson commented on SOLR-5146:
--

[~dsmiley] AFAIC, if you're going to be diving into this feel totally free to 
make any changes to the JIRA you want ;).  I created it mostly to have a marker 
so people would know that transient cores weren't supported in SolrCloud. In a 
similar vein, you can change the "TestLazyCores.java" to "TestTransientCores" ;)

As far as the design for the pluggable interface I totally agree that it's 
awkward. When I was originally working on it the sponsor of the effort had 
forked Solr and heavily customized the prior implementation (CoreContainer 
etc). They wanted a less-painful upgrade path next time. So I pulled the 
intertwined bits out of CoreContainer and made them accessible.

Making it pluggable really amounted to identifying all the bits in places like 
CoreContainer that were needed and getting them into the interface. I always 
thought of it as an intermediate step and could help inform a thoughtful 
redesign. There's a use-case for each of the touch points, what would be good 
is to identify whether all of those use-cases are necessary and/or could be 
combined into something simpler, perhaps modifying Solr's core operations along 
the way.

At root, there's a two-way set of communications that need to happen between 
CoreContainer and the transient core code. As cores move through various phases 
(loading, pendingOps, queued up for the closer thread etc.) it may or may not 
be available for the plugin to do what it wants, say move it to another 
location. So there have to be ways for the transient code to know what state 
the core is in as it moves through it's lifecycle.

Conversely, when Solr is trying to do whatever it needs to, say close the core, 
it needs the transient plugin not to do something conflicting.

The plugin can do anything it wants to the core. Move it physically, 
temporarily suspend it, even move it to another machine if the infrastructure 
is such that the external app knows how to resolve where the core is.

Some of the complexity is due to trying to operate on cores in parallel, and 
the core operations have accumulated cruft over time. Whether we could reduce 
the complexity of core manipulation and thus reduce the complexity of the 
transient interface, as well as the complexity of CoreContainer is a fair 
question.

If you are puzzled by how trivial some of the touch points are in the default 
implementation, we can talk about why they're there, some of them were required 
for the alternate implementation. If I can remember why 2 years later...

Anyway, if you want to totally redesign it, please feel free ;)

> Figure out what it would take for lazily-loaded cores to play nice with 
> SolrCloud
> -
>
> Key: SOLR-5146
> URL: https://issues.apache.org/jira/browse/SOLR-5146
> Project: Solr
>  Issue Type: Improvement
>  Components: SolrCloud
>Affects Versions: 4.5, 6.0
>Reporter: Erick Erickson
>Assignee: David Smiley
>Priority: Major
>
> The whole lazy-load core thing was implemented with non-SolrCloud use-cases 
> in mind. There are several user-list threads that ask about using lazy cores 
> with SolrCloud, especially in multi-tenant use-cases.
> This is a marker JIRA to investigate what it would take to make lazy-load 
> cores play nice with SolrCloud. It's especially interesting how this all 
> works with shards, replicas, leader election, recovery, etc.
> NOTE: This is pretty much totally unexplored territory. It may be that a few 
> trivial modifications are all that's needed. OTOH, It may be that we'd have 
> to rip apart SolrCloud to handle this case. Until someone dives into the 
> code, we don't know.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Created] (LUCENE-9172) nuke some compiler warnings

[Robert Muir (Jira)]

Robert Muir created LUCENE-9172:
---

 Summary: nuke some compiler warnings
 Key: LUCENE-9172
 URL: https://issues.apache.org/jira/browse/LUCENE-9172
 Project: Lucene - Core
  Issue Type: Task
Reporter: Robert Muir
 Attachments: LUCENE-9172.patch

Got annoyed by some of these spamming my console



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (LUCENE-9172) nuke some compiler warnings

[Robert Muir (Jira)]

 [ 
https://issues.apache.org/jira/browse/LUCENE-9172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-9172:

Attachment: LUCENE-9172.patch

> nuke some compiler warnings
> ---
>
> Key: LUCENE-9172
> URL: https://issues.apache.org/jira/browse/LUCENE-9172
> Project: Lucene - Core
>  Issue Type: Task
>Reporter: Robert Muir
>Priority: Major
> Attachments: LUCENE-9172.patch
>
>
> Got annoyed by some of these spamming my console



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

[GitBox]

diegoceccarelli commented on a change in pull request #357: [SOLR-12238] 
Synonym Queries boost by payload 
URL: https://github.com/apache/lucene-solr/pull/357#discussion_r370941515
 
 

 ##
 File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java
 ##
 @@ -349,25 +361,78 @@ protected Query createFieldQuery(TokenStream source, 
BooleanClause.Occur operato
* returned.  When multiple tokens, an ordered SpanNearQuery 
with slop 0 is returned.
*/
   protected SpanQuery createSpanQuery(TokenStream in, String field) throws 
IOException {
+PayloadAttribute payloadAttribute = null;
+if(synonymsBoostByPayload){
+  payloadAttribute = in.getAttribute(PayloadAttribute.class);
+}
 TermToBytesRefAttribute termAtt = 
in.getAttribute(TermToBytesRefAttribute.class);
 if (termAtt == null) {
   return null;
 }
 
 List terms = new ArrayList<>();
+List payloads = new ArrayList<>();
 while (in.incrementToken()) {
   terms.add(new SpanTermQuery(new Term(field, termAtt.getBytesRef(;
+  if(payloadAttribute!=null){
+payloads.add(payloadAttribute.getPayload());
+  }
+}
+in.end();
+in.close();
+
+BytesRef[] queryPayloadsArray = payloads.toArray(new 
BytesRef[payloads.size()]);
+float queryPayloadBoost = 0;
+if (!payloads.isEmpty()) {
+  queryPayloadBoost = extractQueryPayload(queryPayloadsArray);
 }
 
 if (terms.isEmpty()) {
   return null;
 } else if (terms.size() == 1) {
-  return terms.get(0);
+  SpanTermQuery singleTermQuery = terms.get(0);
+  if (queryPayloadBoost != 0) {
+return new SpanBoostQuery(singleTermQuery, queryPayloadBoost);
+  } else {
+return singleTermQuery;
+  }
 } else {
-  return new SpanNearQuery(terms.toArray(new SpanTermQuery[0]), 0, true);
+  SpanNearQuery multiTermQuery = new SpanNearQuery(terms.toArray(new 
SpanTermQuery[0]), 0, true);
+  if (queryPayloadBoost != 0) {
+return new SpanBoostQuery(multiTermQuery, queryPayloadBoost);
+  } else {
+return multiTermQuery;
 
 Review comment:
   nit: maybe you can have a function:
   ```
   private SpanNearQuery getBoostedSpanQuery(spanQuery, queryPayloadBoost){
   if (queryPayloadBoost != 0) {
   return new SpanBoostQuery(spanQuery, queryPayloadBoost);
 } else {
   return spanQuery;
 }
   }
   ```
   and reuse it in both the branches? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

[GitBox]

diegoceccarelli commented on a change in pull request #357: [SOLR-12238] 
Synonym Queries boost by payload 
URL: https://github.com/apache/lucene-solr/pull/357#discussion_r370941548
 
 

 ##
 File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java
 ##
 @@ -349,25 +361,78 @@ protected Query createFieldQuery(TokenStream source, 
BooleanClause.Occur operato
* returned.  When multiple tokens, an ordered SpanNearQuery 
with slop 0 is returned.
*/
   protected SpanQuery createSpanQuery(TokenStream in, String field) throws 
IOException {
+PayloadAttribute payloadAttribute = null;
+if(synonymsBoostByPayload){
+  payloadAttribute = in.getAttribute(PayloadAttribute.class);
+}
 TermToBytesRefAttribute termAtt = 
in.getAttribute(TermToBytesRefAttribute.class);
 if (termAtt == null) {
   return null;
 }
 
 List terms = new ArrayList<>();
+List payloads = new ArrayList<>();
 while (in.incrementToken()) {
   terms.add(new SpanTermQuery(new Term(field, termAtt.getBytesRef(;
+  if(payloadAttribute!=null){
+payloads.add(payloadAttribute.getPayload());
+  }
+}
+in.end();
+in.close();
+
+BytesRef[] queryPayloadsArray = payloads.toArray(new 
BytesRef[payloads.size()]);
+float queryPayloadBoost = 0;
+if (!payloads.isEmpty()) {
+  queryPayloadBoost = extractQueryPayload(queryPayloadsArray);
 }
 
 if (terms.isEmpty()) {
   return null;
 } else if (terms.size() == 1) {
-  return terms.get(0);
+  SpanTermQuery singleTermQuery = terms.get(0);
+  if (queryPayloadBoost != 0) {
+return new SpanBoostQuery(singleTermQuery, queryPayloadBoost);
+  } else {
+return singleTermQuery;
+  }
 } else {
-  return new SpanNearQuery(terms.toArray(new SpanTermQuery[0]), 0, true);
+  SpanNearQuery multiTermQuery = new SpanNearQuery(terms.toArray(new 
SpanTermQuery[0]), 0, true);
+  if (queryPayloadBoost != 0) {
+return new SpanBoostQuery(multiTermQuery, queryPayloadBoost);
+  } else {
+return multiTermQuery;
+  }
+}
+  }
+
+  /*Current assumption is that the user will associate a single payload to the 
multi terms synonym
+   * that generated the phrase query, so a valid value for the payload 
associated to the query is just the first not null payload
+   * e.g.
+   * lion => panthera leo|0.99
+   * "panthera leo" query will have associated Payloads [null,0.99]
+   *  So the payload associated to the query will be 0.99 which is the first 
not null
+   * */
+  protected float extractQueryPayload(BytesRef[] payloadsForQueryTerms) {
+for (BytesRef singlePayload : payloadsForQueryTerms) {
+  if (singlePayload != null) {
+float decodedPayload = decodeFloat(singlePayload.bytes, 
singlePayload.offset);
+return decodedPayload;
+  }
 }
+return 0;
   }
 
+  public static final float decodeFloat(byte [] bytes, int offset){
 
 Review comment:
   public intended? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

[GitBox]

diegoceccarelli commented on a change in pull request #357: [SOLR-12238] 
Synonym Queries boost by payload 
URL: https://github.com/apache/lucene-solr/pull/357#discussion_r370941551
 
 

 ##
 File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java
 ##
 @@ -349,25 +361,78 @@ protected Query createFieldQuery(TokenStream source, 
BooleanClause.Occur operato
* returned.  When multiple tokens, an ordered SpanNearQuery 
with slop 0 is returned.
*/
   protected SpanQuery createSpanQuery(TokenStream in, String field) throws 
IOException {
+PayloadAttribute payloadAttribute = null;
+if(synonymsBoostByPayload){
+  payloadAttribute = in.getAttribute(PayloadAttribute.class);
+}
 TermToBytesRefAttribute termAtt = 
in.getAttribute(TermToBytesRefAttribute.class);
 if (termAtt == null) {
   return null;
 }
 
 List terms = new ArrayList<>();
+List payloads = new ArrayList<>();
 while (in.incrementToken()) {
   terms.add(new SpanTermQuery(new Term(field, termAtt.getBytesRef(;
+  if(payloadAttribute!=null){
+payloads.add(payloadAttribute.getPayload());
+  }
+}
+in.end();
+in.close();
+
+BytesRef[] queryPayloadsArray = payloads.toArray(new 
BytesRef[payloads.size()]);
+float queryPayloadBoost = 0;
+if (!payloads.isEmpty()) {
+  queryPayloadBoost = extractQueryPayload(queryPayloadsArray);
 }
 
 if (terms.isEmpty()) {
   return null;
 } else if (terms.size() == 1) {
-  return terms.get(0);
+  SpanTermQuery singleTermQuery = terms.get(0);
+  if (queryPayloadBoost != 0) {
+return new SpanBoostQuery(singleTermQuery, queryPayloadBoost);
+  } else {
+return singleTermQuery;
+  }
 } else {
-  return new SpanNearQuery(terms.toArray(new SpanTermQuery[0]), 0, true);
+  SpanNearQuery multiTermQuery = new SpanNearQuery(terms.toArray(new 
SpanTermQuery[0]), 0, true);
+  if (queryPayloadBoost != 0) {
+return new SpanBoostQuery(multiTermQuery, queryPayloadBoost);
+  } else {
+return multiTermQuery;
+  }
+}
+  }
+
+  /*Current assumption is that the user will associate a single payload to the 
multi terms synonym
+   * that generated the phrase query, so a valid value for the payload 
associated to the query is just the first not null payload
+   * e.g.
+   * lion => panthera leo|0.99
+   * "panthera leo" query will have associated Payloads [null,0.99]
+   *  So the payload associated to the query will be 0.99 which is the first 
not null
+   * */
+  protected float extractQueryPayload(BytesRef[] payloadsForQueryTerms) {
+for (BytesRef singlePayload : payloadsForQueryTerms) {
+  if (singlePayload != null) {
+float decodedPayload = decodeFloat(singlePayload.bytes, 
singlePayload.offset);
+return decodedPayload;
+  }
 }
+return 0;
   }
 
+  public static final float decodeFloat(byte [] bytes, int offset){
+
+return Float.intBitsToFloat(decodeInt(bytes, offset));
+  }
+
+  public static final int decodeInt(byte [] bytes, int offset){
 
 Review comment:
   public intended? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] diegoceccarelli commented on a change in pull request #357: [SOLR-12238] Synonym Queries boost by payload

[GitBox]

diegoceccarelli commented on a change in pull request #357: [SOLR-12238] 
Synonym Queries boost by payload 
URL: https://github.com/apache/lucene-solr/pull/357#discussion_r370941581
 
 

 ##
 File path: lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java
 ##
 @@ -509,38 +591,75 @@ protected Query analyzeGraphBoolean(String field, 
TokenStream source, BooleanCla
 end = articulationPoints[i];
   }
   lastState = end;
-  final Query queryPos;
+  final Query queryClause;
+  final Iterator sidePathsForPayloads = 
graph.getFiniteStrings(start, end);
+  Iterator sidePathsPayloads = new Iterator() {
+@Override
+public boolean hasNext() {
+  return sidePathsForPayloads.hasNext();
+}
+
+@Override
+public BytesRef[] next() {
+  TokenStream sidePath = sidePathsForPayloads.next();
+  return getPayloadsFromStream(sidePath);
+}
+  };
   if (graph.hasSidePath(start)) {
-final Iterator it = graph.getFiniteStrings(start, end);
-Iterator queries = new Iterator() {
+final Iterator sidePaths = graph.getFiniteStrings(start, 
end);
 
 Review comment:
   nit: maybe keep iterator in the name? `sidePathsIterator`? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Mikhail Khludnev (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated SOLR-12325:

Attachment: (was: SOLR-12325.patch)

> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Mikhail Khludnev (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated SOLR-12325:

Attachment: SOLR-12325.patch

> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Lucene/Solr QA (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023610#comment-17023610
 ] 

Lucene/Solr QA commented on SOLR-12325:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  1m  4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  1m  4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  1m  4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 53m 53s{color} 
| {color:red} core in the patch failed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 57m 57s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | solr.search.QueryEqualityTest |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12325 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12991831/SOLR-12325.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 127ce3e360a |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| unit | 
https://builds.apache.org/job/PreCommit-SOLR-Build/666/artifact/out/patch-unit-solr_core.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/666/testReport/ |
| modules | C: solr solr/core U: solr |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/666/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] yonik merged pull request #1195: SOLR-13101: Log accurate file counts for Push and Pull in CorePushPull

[GitBox]

yonik merged pull request #1195: SOLR-13101: Log accurate file counts for Push 
and Pull in CorePushPull
URL: https://github.com/apache/lucene-solr/pull/1195
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] yonik commented on issue #1195: SOLR-13101: Log accurate file counts for Push and Pull in CorePushPull

[GitBox]

yonik commented on issue #1195: SOLR-13101: Log accurate file counts for Push 
and Pull in CorePushPull
URL: https://github.com/apache/lucene-solr/pull/1195#issuecomment-578433525
 
 
   Thanks Emily!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-13101) Shared storage support in SolrCloud

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023628#comment-17023628
 ] 

ASF subversion and git services commented on SOLR-13101:


Commit 5c797bfa31063a6532e223a18db16c0a2dc8effe in lucene-solr's branch 
refs/heads/jira/SOLR-13101 from ebehrendt
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5c797bf ]

SOLR-13101: Log accurate file counts for Push and Pull in CorePushPull (#1195)

* CorePushPull blob interaction log line inaccurate in case of failures. Fix 
logged file and bytes count to be accurate in both success and failure

* Move file transfer count data into inner class to preserve incremented values 
when exception is thrown


> Shared storage support in SolrCloud
> ---
>
> Key: SOLR-13101
> URL: https://issues.apache.org/jira/browse/SOLR-13101
> Project: Solr
>  Issue Type: New Feature
>  Components: SolrCloud
>Reporter: Yonik Seeley
>Priority: Major
>  Time Spent: 11h 10m
>  Remaining Estimate: 0h
>
> Solr should have first-class support for shared storage (blob/object stores 
> like S3, google cloud storage, etc. and shared filesystems like HDFS, NFS, 
> etc).
> The key component will likely be a new replica type for shared storage.  It 
> would have many of the benefits of the current "pull" replicas (not indexing 
> on all replicas, all shards identical with no shards getting out-of-sync, 
> etc), but would have additional benefits:
>  - Any shard could become leader (the blob store always has the index)
>  - Better elasticity scaling down
>- durability not linked to number of replcias.. a single replica could be 
> common for write workloads
>- could drop to 0 replicas for a shard when not needed (blob store always 
> has index)
>  - Allow for higher performance write workloads by skipping the transaction 
> log
>- don't pay for what you don't need
>- a commit will be necessary to flush to stable storage (blob store)
>  - A lot of the complexity and failure modes go away
> An additional component a Directory implementation that will work well with 
> blob stores.  We probably want one that treats local disk as a cache since 
> the latency to remote storage is so large.  I think there are still some 
> "locking" issues to be solved here (ensuring that more than one writer to the 
> same index won't corrupt it).  This should probably be pulled out into a 
> different JIRA issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Mikhail Khludnev (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated SOLR-12325:

Attachment: SOLR-12325.patch

> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Mikhail Khludnev (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated SOLR-12325:

Attachment: (was: SOLR-12325.patch)

> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] dweiss commented on issue #1121: SOLR-11207: Add OWASP dependency checker to gradle build

[GitBox]

dweiss commented on issue #1121: SOLR-11207: Add OWASP dependency checker to 
gradle build
URL: https://github.com/apache/lucene-solr/pull/1121#issuecomment-578443878
 
 
   Thanks Jan. I'll merge it in tomorrow, have a day off.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12930) Add developer documentation to source repo

[Dawid Weiss (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023649#comment-17023649
 ] 

Dawid Weiss commented on SOLR-12930:


bq.  I'm not sure how being in a different directory than the one they were in 
is "burying" them - there's literally one other file there right now [...]

Well, this one is really subjective. I have a feeling these dev-docs will 
accumulate instructions on more complex processes (like release manager tasks, 
etc.). I really wanted to keep the help/* scripts as simple as possible, 
focused on a particular thing or task so that you can quickly look at them when 
you need something. Contrary to dev-docs (which will probably be in a rich text 
format) I wanted these files to be simple ascii too (so that they can be 
displayed via gradle task or even cat/ vi/ you name it). 

I know this may be perceived as an inconsistency with dev-docs and I have 
nothing other than the above to defend it. Maybe with time (when people learn 
those new tools) the need for help/* will decrease and we can move them under 
dev-docs (?).

> Add developer documentation to source repo
> --
>
> Key: SOLR-12930
> URL: https://issues.apache.org/jira/browse/SOLR-12930
> Project: Solr
>  Issue Type: Improvement
>  Components: Tests
>Reporter: Mark Miller
>Priority: Major
> Attachments: solr-dev-docs.zip
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] janhoy commented on issue #1121: SOLR-11207: Add OWASP dependency checker to gradle build

[GitBox]

janhoy commented on issue #1121: SOLR-11207: Add OWASP dependency checker to 
gradle build
URL: https://github.com/apache/lucene-solr/pull/1121#issuecomment-578446398
 
 
   Thanks Dawid. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Created] (SOLR-14218) buy oxycodone online

[simmons josh (Jira)]

simmons josh created SOLR-14218:
---

 Summary: buy oxycodone online
 Key: SOLR-14218
 URL: https://issues.apache.org/jira/browse/SOLR-14218
 Project: Solr
  Issue Type: Bug
  Security Level: Public (Default Security Level. Issues are Public)
  Components: Authentication
Affects Versions: 8.4
Reporter: simmons josh
 Fix For: 6.1.1
 Attachments: 3cb0729.jpg

a patient suffering from illnesses like anxiety, chronic and severe pain, panic 
disorder, dizzyness, sleepless night .onlinephamadrugs is here to fight against 
those illnesses we offer good services reliable to their Job, good medical 
assistance, free shipping, visit our website for more information.
https://onlinephamadrugs.org/product/buy-genotropin-online/";>buy 
Genotropin online usa
https://onlinephamadrugs.org/product/buy-biotropin-online/";>order 
cheap biotrophic online with prescription
https://onlinephamadrugs.org/product/buy-vyvanse-cii-online/";>buy 
Vyvanse online with prescription
https://onlinephamadrugs.org/buy-ritalin-10mg-online/";>buy Ritalin 
online in uk
https://onlinephamadrugs.org/product/buy-adderall-online/";>where to 
buy Adderals online uk
https://onlinephamadrugs.org/product/buy-adderall-online/";>where can i 
buy Adderals online
https://onlinephamadrugs.org/product/buy-dextroamphetamine-dexedrine-online/";>buy
 prescribe dexedrine online 
https://onlinephamadrugs.org/product/buy-diazepam-10mg-online/";>order 
diazepam 10mg online with prescription
https://onlinephamadrugs.org/product/buy-pregabalin-online/";>buy 
pregabalin online



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Resolved] (SOLR-14218) buy oxycodone online

[Robert Muir (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir resolved SOLR-14218.

Resolution: Later

> buy oxycodone online
> 
>
> Key: SOLR-14218
> URL: https://issues.apache.org/jira/browse/SOLR-14218
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: Authentication
>Affects Versions: 8.4
>Reporter: simmons josh
>Priority: Major
>  Labels: windows
> Fix For: 6.1.1
>
> Attachments: 3cb0729.jpg
>
>
> a patient suffering from illnesses like anxiety, chronic and severe pain, 
> panic disorder, dizzyness, sleepless night .onlinephamadrugs is here to fight 
> against those illnesses we offer good services reliable to their Job, good 
> medical assistance, free shipping, visit our website for more information.
> https://onlinephamadrugs.org/product/buy-genotropin-online/";>buy 
> Genotropin online usa
> https://onlinephamadrugs.org/product/buy-biotropin-online/";>order 
> cheap biotrophic online with prescription
> https://onlinephamadrugs.org/product/buy-vyvanse-cii-online/";>buy 
> Vyvanse online with prescription
> https://onlinephamadrugs.org/buy-ritalin-10mg-online/";>buy Ritalin 
> online in uk
> https://onlinephamadrugs.org/product/buy-adderall-online/";>where to 
> buy Adderals online uk
> https://onlinephamadrugs.org/product/buy-adderall-online/";>where can 
> i buy Adderals online
>  href="https://onlinephamadrugs.org/product/buy-dextroamphetamine-dexedrine-online/";>buy
>  prescribe dexedrine online 
>  href="https://onlinephamadrugs.org/product/buy-diazepam-10mg-online/";>order 
> diazepam 10mg online with prescription
> https://onlinephamadrugs.org/product/buy-pregabalin-online/";>buy 
> pregabalin online



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370967657
 
 

 ##
 File path: lucene/core/build.gradle
 ##
 @@ -1,7 +1,117 @@
-
 apply plugin: 'java-library'
+apply plugin: "de.undercouch.download"
 
 dependencies {
   testImplementation project(':lucene:codecs')
   testImplementation project(':lucene:test-framework')
 }
+
+def momanCommitHash = "5c5c2a1e4dea"
+def momanUrl = 
"https://bitbucket.org/jpbarrette/moman/get/${momanCommitHash}.zip";
+def python_exe = "python"
+
+def jflexUrl = "https://jflex.de/release/jflex-1.7.0.zip";
+
+// Download and extract Moman
+task installJFlex(type: Download) {
+  src jflexUrl
+  dest file("${buildDir}/jflex.zip")
 
 Review comment:
   Right, done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370967681
 
 

 ##
 File path: lucene/core/build.gradle
 ##
 @@ -1,7 +1,117 @@
-
 apply plugin: 'java-library'
+apply plugin: "de.undercouch.download"
 
 dependencies {
   testImplementation project(':lucene:codecs')
   testImplementation project(':lucene:test-framework')
 }
+
+def momanCommitHash = "5c5c2a1e4dea"
+def momanUrl = 
"https://bitbucket.org/jpbarrette/moman/get/${momanCommitHash}.zip";
+def python_exe = "python"
+
+def jflexUrl = "https://jflex.de/release/jflex-1.7.0.zip";
+
+// Download and extract Moman
 
 Review comment:
   See previous.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370967671
 
 

 ##
 File path: lucene/core/build.gradle
 ##
 @@ -1,7 +1,117 @@
-
 apply plugin: 'java-library'
+apply plugin: "de.undercouch.download"
 
 dependencies {
   testImplementation project(':lucene:codecs')
   testImplementation project(':lucene:test-framework')
 }
+
+def momanCommitHash = "5c5c2a1e4dea"
+def momanUrl = 
"https://bitbucket.org/jpbarrette/moman/get/${momanCommitHash}.zip";
+def python_exe = "python"
+
+def jflexUrl = "https://jflex.de/release/jflex-1.7.0.zip";
+
+// Download and extract Moman
+task installJFlex(type: Download) {
+  src jflexUrl
+  dest file("${buildDir}/jflex.zip")
+  onlyIfModified true
+  doLast {
 
 Review comment:
   Actually, I found a way to combine them all, thanks for suggesting this, 
made me look closer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370968095
 
 

 ##
 File path: lucene/core/build.gradle
 ##
 @@ -1,7 +1,117 @@
-
 apply plugin: 'java-library'
+apply plugin: "de.undercouch.download"
 
 dependencies {
   testImplementation project(':lucene:codecs')
   testImplementation project(':lucene:test-framework')
 }
+
+def momanCommitHash = "5c5c2a1e4dea"
+def momanUrl = 
"https://bitbucket.org/jpbarrette/moman/get/${momanCommitHash}.zip";
+def python_exe = "python"
+
+def jflexUrl = "https://jflex.de/release/jflex-1.7.0.zip";
+
+// Download and extract Moman
+task installJFlex(type: Download) {
+  src jflexUrl
+  dest file("${buildDir}/jflex.zip")
+  onlyIfModified true
+  doLast {
+ant.unzip(src: file("${buildDir}/jflex.zip"), dest: 
file("${buildDir}/jflex"), overwrite: "true") {
+  ant.cutdirsmapper(dirs: "1")
+}
+  }
+}
+
+task installMoman(type: Download) {
+  src momanUrl
+  dest file("${buildDir}/moman.zip")
+  onlyIfModified true
+
+  doLast {
+ant.unzip(src: file("${buildDir}/moman.zip"), dest: 
file("${buildDir}/moman"), overwrite: "true") {
+  ant.cutdirsmapper(dirs: "1")
+}
+  }
+}
+
+task createPackedIntSources {
+  doLast {
+exec {
+  workingDir 'src/java/org/apache/lucene/util/packed'
+  executable "${python_exe}"
+  args = ['-B', 'gen_BulkOperation.py']
+}
+exec {
+  workingDir 'src/java/org/apache/lucene/util/packed'
+  executable "${python_exe}"
+  args = ['-B', 'gen_Packed64SingleBlock.py']
+}
+ant.fixcrlf(srcdir: 'src/java/org/apache/lucene/util/packed', includes: 
'Packed64SingleBlock.java', encoding: 'UTF-8')
+ant.fixcrlf(srcdir: 'src/java/org/apache/lucene/util/packed', includes: 
'BulkOperation*.java', encoding: 'UTF-8')
+  }
+}
+
+task createLevAutomaton(dependsOn: installMoman) {
+  doLast {
+exec {
 
 Review comment:
   Slick. I can do something similar in createPackedIntSources too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370968598
 
 

 ##
 File path: 
lucene/queryparser/src/java/org/apache/lucene/queryparser/classic/QueryParser.java
 ##
 @@ -879,7 +878,7 @@ private void jj_add_error_token(int kind, int pos) {
   for (int i = 0; i < jj_endpos; i++) {
 jj_expentry[i] = jj_lasttokens[i];
   }
-  jj_entries_loop: for (java.util.Iterator it = jj_expentries.iterator(); 
it.hasNext();) {
 
 Review comment:
   The line you attached this comment to _does_ have a wildcard generic (line 
881) in the changed code. Or did you mean line 866?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Lucene/Solr QA (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023707#comment-17023707
 ] 

Lucene/Solr QA commented on SOLR-12325:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
14s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} | 
{color:green}  1m  1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} | 
{color:green}  1m  1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} | 
{color:green}  1m  1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 52m 
10s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 21s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-12325 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12991835/SOLR-12325.patch |
| Optional Tests |  compile  javac  unit  ratsources  checkforbiddenapis  
validatesourcepatterns  |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
 |
| git revision | master / 127ce3e360a |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
|  Test Results | 
https://builds.apache.org/job/PreCommit-SOLR-Build/667/testReport/ |
| modules | C: solr solr/core U: solr |
| Console output | 
https://builds.apache.org/job/PreCommit-SOLR-Build/667/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370969039
 
 

 ##
 File path: lucene/core/build.gradle
 ##
 @@ -1,7 +1,117 @@
-
 apply plugin: 'java-library'
+apply plugin: "de.undercouch.download"
 
 dependencies {
   testImplementation project(':lucene:codecs')
   testImplementation project(':lucene:test-framework')
 }
+
+def momanCommitHash = "5c5c2a1e4dea"
+def momanUrl = 
"https://bitbucket.org/jpbarrette/moman/get/${momanCommitHash}.zip";
+def python_exe = "python"
+
+def jflexUrl = "https://jflex.de/release/jflex-1.7.0.zip";
+
+// Download and extract Moman
+task installJFlex(type: Download) {
+  src jflexUrl
+  dest file("${buildDir}/jflex.zip")
+  onlyIfModified true
+  doLast {
+ant.unzip(src: file("${buildDir}/jflex.zip"), dest: 
file("${buildDir}/jflex"), overwrite: "true") {
+  ant.cutdirsmapper(dirs: "1")
+}
+  }
+}
+
+task installMoman(type: Download) {
 
 Review comment:
   Done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370969055
 
 

 ##
 File path: lucene/queryparser/build.gradle
 ##
 @@ -7,3 +7,305 @@ dependencies {
 
   testImplementation project(':lucene:test-framework')
 }
+
+configure(":lucene:queryparser") {
+  configurations {
+javaCCDeps
+
+dependencies {
+  javaCCDeps "net.java.dev.javacc:javacc:5.0"
+}
+  }
+}
+def conf = [
+"queryParser": ["inputFile": 
file('src/java/org/apache/lucene/queryparser/classic/QueryParser.jj'), 
"outputDir": file('src/java/org/apache/lucene/queryparser/classic')],
+"surround"   : ["inputFile": 
file('src/java/org/apache/lucene/queryparser/surround/parser/QueryParser.jj'), 
"outputDir": file('src/java/org/apache/lucene/queryparser/surround/parser/')],
+"flexible"   : ["inputFile": 
file('src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.jj'),
 "outputDir": 
file('src/java/org/apache/lucene/queryparser/flexible/standard/parser')]
+]
+
+String javaCCClasspath
+String javaCCHome
+
+task installJavacc {
+  doLast {
+javaCCClasspath = 
project.project(":lucene:queryparser").configurations.javaCCDeps.asPath
+javaCCHome = javaCCClasspath.substring(0, javaCCClasspath.lastIndexOf("/"))
+
+String hacky = javaCCHome + "/" + "javacc.jar"
 
 Review comment:
   From what I can tell, the ant JavaCC task _requires_ the file be named 
javacc.jar and what's downloaded is javacc-5.0.jar (ancient, I know). I can't 
find a place to download it from so I'm relying on the Gradle dependency magic 
to get it in the first place. But then it needs to be renamed. I'll make this a 
little neater and add a comment.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370969094
 
 

 ##
 File path: lucene/queryparser/build.gradle
 ##
 @@ -7,3 +7,305 @@ dependencies {
 
   testImplementation project(':lucene:test-framework')
 }
+
+configure(":lucene:queryparser") {
+  configurations {
+javaCCDeps
+
+dependencies {
+  javaCCDeps "net.java.dev.javacc:javacc:5.0"
+}
+  }
+}
+def conf = [
+"queryParser": ["inputFile": 
file('src/java/org/apache/lucene/queryparser/classic/QueryParser.jj'), 
"outputDir": file('src/java/org/apache/lucene/queryparser/classic')],
+"surround"   : ["inputFile": 
file('src/java/org/apache/lucene/queryparser/surround/parser/QueryParser.jj'), 
"outputDir": file('src/java/org/apache/lucene/queryparser/surround/parser/')],
+"flexible"   : ["inputFile": 
file('src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.jj'),
 "outputDir": 
file('src/java/org/apache/lucene/queryparser/flexible/standard/parser')]
+]
+
+String javaCCClasspath
+String javaCCHome
+
+task installJavacc {
+  doLast {
+javaCCClasspath = 
project.project(":lucene:queryparser").configurations.javaCCDeps.asPath
+javaCCHome = javaCCClasspath.substring(0, javaCCClasspath.lastIndexOf("/"))
+
+String hacky = javaCCHome + "/" + "javacc.jar"
+File hackyFile = new File(hacky)
+println hackyFile
+println hackyFile.exists()
+if (hackyFile.exists() == false) {
+  hackyFile.bytes = new File(javaCCClasspath).bytes
+  hackyFile.setExecutable(true)
+}
+  }
+}
+String lineSeparator = System.lineSeparator()
+
+task cleanOldGeneratedFiles {
+  doLast {
+println "Removing old generated files"
+conf.each { key, val ->
+  val["outputDir"].eachFileMatch ~/.*\.java/, { f ->
+if (f.text =~ /Generated.*By.*JavaCC/) {
+  f.delete()
+}
+  }
+}
+  }
+}
+
+task runJavaccQueryParser(dependsOn: installJavacc) {
+  doLast {
+println "Generating QueryParser parser"
+
+def inputFile = conf["queryParser"]["inputFile"].getAbsolutePath()
+def outputDir = conf["queryParser"]["outputDir"].getAbsolutePath()
+ant.javacc(target: inputFile, outputDirectory: outputDir, javacchome: 
javaCCHome)
+
+
+ant.replaceregexp(file: new File(outputDir, "QueryParser.java"),
+byline: "true",
+match: "public QueryParser\\(CharStream ",
+replace: "protected QueryParser(CharStream ")
+ant.replaceregexp(file: new File(outputDir, "QueryParser.java"),
+byline: "true",
+match: "public QueryParser\\(QueryParserTokenManager ",
+replace: "protected QueryParser(QueryParserTokenManager ")
+  }
+}
+
+task runJavaccSurround(dependsOn: installJavacc) {
+  doLast {
+println "Generating Surroundf parser"
+def inputFile = conf["surround"]["inputFile"].getAbsolutePath()
+def outputDir = conf["surround"]["outputDir"].getAbsolutePath()
+
+ant.javacc(target: inputFile, outputDirectory: outputDir, javacchome: 
javaCCHome)
+
+// This is very clumsy, but these are unused imports that are necessary 
other generated files
+[
+"import java.util.Vector;",
+"import org.apache.lucene.queryparser.flexible.messages.Message;",
+"import org.apache.lucene.queryparser.flexible.messages.MessageImpl;",
+"import 
org.apache.lucene.queryparser.flexible.core.QueryNodeParseException;",
+"import 
org.apache.lucene.queryparser.flexible.core.messages.QueryParserMessages;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.AndQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.BooleanQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.BoostQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.FieldQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.FuzzyQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.ModifierQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.GroupQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.OrQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.standard.nodes.RegexpQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.SlopQueryNode;",
+"import org.apache.lucene.queryparser.flexible.core.nodes.QueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.nodes.QuotedFieldQueryNode;",
+"import 
org.apache.lucene.queryparser.flexible.core.parser.SyntaxParser;",
+"import 
org.apache.lucene.queryparser.flexible.standard.nodes.TermRangeQueryNode;",
+"import java.io.StringReader;",
+"import java.util.ArrayList;",
+"import java.util.Arrays;",
+"import java.util.HashSet;",
+   

[GitHub] [lucene-solr] ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port ant-regenerate tasks to Gradle build

[GitBox]

ErickErickson commented on a change in pull request #1199: LUCENE-9134: Port 
ant-regenerate tasks to Gradle build
URL: https://github.com/apache/lucene-solr/pull/1199#discussion_r370970749
 
 

 ##
 File path: lucene/queryparser/build.gradle
 ##
 @@ -7,3 +7,305 @@ dependencies {
 
   testImplementation project(':lucene:test-framework')
 }
+
+configure(":lucene:queryparser") {
+  configurations {
+javaCCDeps
+
+dependencies {
+  javaCCDeps "net.java.dev.javacc:javacc:5.0"
+}
+  }
+}
+def conf = [
+"queryParser": ["inputFile": 
file('src/java/org/apache/lucene/queryparser/classic/QueryParser.jj'), 
"outputDir": file('src/java/org/apache/lucene/queryparser/classic')],
+"surround"   : ["inputFile": 
file('src/java/org/apache/lucene/queryparser/surround/parser/QueryParser.jj'), 
"outputDir": file('src/java/org/apache/lucene/queryparser/surround/parser/')],
+"flexible"   : ["inputFile": 
file('src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.jj'),
 "outputDir": 
file('src/java/org/apache/lucene/queryparser/flexible/standard/parser')]
+]
+
+String javaCCClasspath
+String javaCCHome
+
+task installJavacc {
+  doLast {
+javaCCClasspath = 
project.project(":lucene:queryparser").configurations.javaCCDeps.asPath
+javaCCHome = javaCCClasspath.substring(0, javaCCClasspath.lastIndexOf("/"))
+
+String hacky = javaCCHome + "/" + "javacc.jar"
+File hackyFile = new File(hacky)
+println hackyFile
+println hackyFile.exists()
+if (hackyFile.exists() == false) {
+  hackyFile.bytes = new File(javaCCClasspath).bytes
+  hackyFile.setExecutable(true)
+}
+  }
+}
+String lineSeparator = System.lineSeparator()
+
+task cleanOldGeneratedFiles {
+  doLast {
+println "Removing old generated files"
+conf.each { key, val ->
+  val["outputDir"].eachFileMatch ~/.*\.java/, { f ->
+if (f.text =~ /Generated.*By.*JavaCC/) {
+  f.delete()
+}
+  }
+}
+  }
+}
+
+task runJavaccQueryParser(dependsOn: installJavacc) {
 
 Review comment:
   Gah, it's worse than that. The common bits _are_ in one place, see 
cleanUpAfter. I missed taking it out of a place or two. Fixing it up.
   
   So there's only one small bit that's repeated now, I don't think it's worth 
a new class now.
   
   And many thanks for your review! I'll get the hang of this yet.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (LUCENE-9134) Port ant-regenerate tasks to Gradle build

[Erick Erickson (Jira)]

[ 
https://issues.apache.org/jira/browse/LUCENE-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023716#comment-17023716
 ] 

Erick Erickson commented on LUCENE-9134:


I'll have a another PR up tomorrow (Sunday) incorporating Mike's comments 
(there's one question still open). I've pushed the other changes based on 
Mike's comments to my branch if you'd like to look, the "regen_eoe" branch.

> Port ant-regenerate tasks to Gradle build
> -
>
> Key: LUCENE-9134
> URL: https://issues.apache.org/jira/browse/LUCENE-9134
> Project: Lucene - Core
>  Issue Type: Sub-task
>Reporter: Erick Erickson
>Assignee: Erick Erickson
>Priority: Major
> Attachments: LUCENE-9134.patch, core_regen.patch
>
>  Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> Here are the "regenerate" targets I found in the ant version. There are a 
> couple that I don't have evidence for or against being rebuilt
>  // Very top level
> {code:java}
> ./build.xml: 
> ./build.xml:  failonerror="true">
> ./build.xml:  depends="regenerate,-check-after-regeneration"/>
>  {code}
> // top level Lucene. This includes the core/build.xml and 
> test-framework/build.xml files
> {code:java}
> ./lucene/build.xml: 
> ./lucene/build.xml:  inheritall="false">
> ./lucene/build.xml: 
>  {code}
> // This one has quite a number of customizations to
> {code:java}
> ./lucene/core/build.xml:  depends="createLevAutomata,createPackedIntSources,jflex"/>
>  {code}
> // This one has a bunch of code modifications _after_ javacc is run on 
> certain of the
>  // output files. Save this one for last?
> {code:java}
> ./lucene/queryparser/build.xml: 
>  {code}
> // the files under ../lucene/analysis... are pretty self contained. I expect 
> these could be done as a unit
> {code:java}
> ./lucene/analysis/build.xml: 
> ./lucene/analysis/build.xml: 
> ./lucene/analysis/common/build.xml:  depends="jflex,unicode-data"/>
> ./lucene/analysis/icu/build.xml:  depends="gen-utr30-data-files,gennorm2,genrbbi"/>
> ./lucene/analysis/kuromoji/build.xml:  depends="build-dict"/>
> ./lucene/analysis/nori/build.xml:  depends="build-dict"/>
> ./lucene/analysis/opennlp/build.xml:  depends="train-test-models"/>
>  {code}
>  
> // These _are_ regenerated from the top-level regenerate target, but for --
> LUCENE-9080//the changes were only in imports so there are no
> //corresponding files checked in in that JIRA
> {code:java}
> ./lucene/expressions/build.xml:  depends="run-antlr"/>
>  {code}
> // Apparently unrelated to ./lucene/analysis/opennlp/build.xml 
> "train-test-models" target
> // Apparently not rebuilt from the top level, but _are_ regenerated when 
> executed from
> // ./solr/contrib/langid
> {code:java}
> ./solr/contrib/langid/build.xml:  depends="train-test-models"/>
>  {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-14218) deleted spam

[Erick Erickson (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-14218:
--
Attachment: (was: 3cb0729.jpg)

> deleted spam
> 
>
> Key: SOLR-14218
> URL: https://issues.apache.org/jira/browse/SOLR-14218
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: simmons josh
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Updated] (SOLR-14218) deleted spam

[Erick Erickson (Jira)]

 [ 
https://issues.apache.org/jira/browse/SOLR-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erick Erickson updated SOLR-14218:
--
  Component/s: (was: Authentication)
Fix Version/s: (was: 6.1.1)
Affects Version/s: (was: 8.4)
  Description: (was: a patient suffering from illnesses like 
anxiety, chronic and severe pain, panic disorder, dizzyness, sleepless night 
.onlinephamadrugs is here to fight against those illnesses we offer good 
services reliable to their Job, good medical assistance, free shipping, visit 
our website for more information.
https://onlinephamadrugs.org/product/buy-genotropin-online/";>buy 
Genotropin online usa
https://onlinephamadrugs.org/product/buy-biotropin-online/";>order 
cheap biotrophic online with prescription
https://onlinephamadrugs.org/product/buy-vyvanse-cii-online/";>buy 
Vyvanse online with prescription
https://onlinephamadrugs.org/buy-ritalin-10mg-online/";>buy Ritalin 
online in uk
https://onlinephamadrugs.org/product/buy-adderall-online/";>where to 
buy Adderals online uk
https://onlinephamadrugs.org/product/buy-adderall-online/";>where can i 
buy Adderals online
https://onlinephamadrugs.org/product/buy-dextroamphetamine-dexedrine-online/";>buy
 prescribe dexedrine online 
https://onlinephamadrugs.org/product/buy-diazepam-10mg-online/";>order 
diazepam 10mg online with prescription
https://onlinephamadrugs.org/product/buy-pregabalin-online/";>buy 
pregabalin online)
   Labels:   (was: windows)
  Summary: deleted spam  (was: buy oxycodone online)

> deleted spam
> 
>
> Key: SOLR-14218
> URL: https://issues.apache.org/jira/browse/SOLR-14218
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: simmons josh
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

[jira] [Commented] (SOLR-12325) introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet

[Munendra S N (Jira)]

[ 
https://issues.apache.org/jira/browse/SOLR-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023724#comment-17023724
 ] 

Munendra S N commented on SOLR-12325:
-

* When {{parentBitSet}} is null, we get NPE. {{parentBitSet}} could be null 
when uniqueBlock is used without blockjoin or on some invalid parent condition 
like {{type_s:book1}}. I think we could return 0 as count
* Other case is when there are {{NO_MORE_DOCS}}. This could happen if the given 
condition doesn't match all parent products For example, In tests, 
{{cat_s:fantasy}} should return count 1 instead of 2.

I would consider both cases as less likely scenarios but it would be great if 
we can handle them.

The patch introduces new aggregation for queries {{uniqueBlockQuery}}, I was 
thinking if it is possible to handle in the existing aggregation 
{{uniqueBlock}}. 

One thought was to introduce {{type}} argument. So, it would look like 
{{uniqueBlock(field, _root_)}} for field based aggregation and 
{{uniqueBlock(query, \{!v=type_s:book})}}. In future,this could be extended for 
function queries when supported is added, something like {{uniqueBlock(func, 
avg(something))}}.
For backward compatibility, when only one argument is passed, it would be 
treated as field aggregation.
This won't change the internal implementation but there won't be need for 
different aggregations for the users.

Above suggestion is a thought & have shared it as it is just to check if it 
makes sense or not. I think SOLR-14188 addresses this problem in general. 

Except those minor cases, other changes LGTM

> introduce uniqueBlockQuery(parent:true) aggregation for JSON Facet
> --
>
> Key: SOLR-12325
> URL: https://issues.apache.org/jira/browse/SOLR-12325
> Project: Solr
>  Issue Type: New Feature
>  Components: Facet Module
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 8.5
>
> Attachments: SOLR-12325.patch, SOLR-12325.patch, SOLR-12325.patch
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> It might be faster twin for {{uniqueBlock(\_root_)}}. Please utilise buildin 
> query parsing method, don't invent your own. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org