[jira] [Updated] (GEODE-9880) Cluster with multiple locators in an environment with no host name resolution, leads to null pointer exception

2022-03-03 Thread Owen Nichols (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Owen Nichols updated GEODE-9880:

Labels: blocks-1.12.10 membership  (was: blocks-1.12.9 membership)

> Cluster with multiple locators in an environment with no host name 
> resolution, leads to null pointer exception
> --
>
> Key: GEODE-9880
> URL: https://issues.apache.org/jira/browse/GEODE-9880
> Project: Geode
>  Issue Type: Bug
>  Components: locator, membership
>Affects Versions: 1.12.5
>Reporter: Tigran Ghahramanyan
>Priority: Major
>  Labels: blocks-1.12.10, membership
>
> In our use case we have two locators that are initially configured with IP 
> addresses, but _AutoConnectionSourceImpl.UpdateLocatorList()_ flow keeps on 
> adding their corresponding host names to the locators list, while these host 
> names are not resolvable.
> Later in {_}AutoConnectionSourceImpl.queryLocators(){_}, whenever a client 
> tries to use such non resolvable host name to connect to a locator it tries 
> to establish a connection to {_}socketaddr=0.0.0.0{_}, as written in 
> {_}SocketCreator.connect(){_}. Which seems strange.
> Then, if there is no locator running on the same host, the next locator in 
> the list is contacted, until reaching a locator contact configured with IP 
> address - which succeeds eventually.
> But, when there happens to be a locator listening on the same host, then we 
> have a null pointer exception in the second line below, because _inetadd=null_
> _socket.connect(sockaddr, Math.max(timeout, 0)); // sockaddr=0.0.0.0, 
> connects to a locator listening on the same host_
> _configureClientSSLSocket(socket, inetadd.getHostName(), timeout); // inetadd 
> = null_
>  
> As a result, the cluster comes to a failed state, unable to recover.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (GEODE-9868) geode-native docker build images should not have Geode installed

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender updated GEODE-9868:

Summary: geode-native docker build images should not have Geode installed  
(was: geode-native docker build images are not compiling correctly )

> geode-native docker build images should not have Geode installed
> 
>
> Key: GEODE-9868
> URL: https://issues.apache.org/jira/browse/GEODE-9868
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Mario Salazar de Torres
>Priority: Major
>
> Given that currently Geode version specified in the docker build images for 
> geode-native is 1.13.2, and latest tests introduces an Authentication feature 
> only available in 1.15.0 (develop), current docker build images are failing 
> to compile the source.
> The solution would require to have the latest version of geode included 
> within the generated images.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-9868) geode-native docker build images should not have Geode installed

2022-03-03 Thread Blake Bender (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500843#comment-17500843
 ] 

Blake Bender commented on GEODE-9868:
-

We've actually added installation of latest "blessed" Geode build(s) to the CI 
pipeline, but haven't gotten around to removing it from the Docker images.  
Additionally, [PR 917|https://github.com/apache/geode-native/pull/917] fixed 
the native client build problem with older Geode versions.  I'm editing the 
title to indicate we need to remove Geode from the Docker files.

> geode-native docker build images should not have Geode installed
> 
>
> Key: GEODE-9868
> URL: https://issues.apache.org/jira/browse/GEODE-9868
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Mario Salazar de Torres
>Priority: Major
>
> Given that currently Geode version specified in the docker build images for 
> geode-native is 1.13.2, and latest tests introduces an Authentication feature 
> only available in 1.15.0 (develop), current docker build images are failing 
> to compile the source.
> The solution would require to have the latest version of geode included 
> within the generated images.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10096) Handshake "acceptance codes" should be an enum class

2022-03-03 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500880#comment-17500880
 ] 

ASF GitHub Bot commented on GEODE-10096:


pivotal-jbarrett commented on a change in pull request #938:
URL: https://github.com/apache/geode-native/pull/938#discussion_r818852254



##
File path: cppcache/src/TcrConnection.cpp
##
@@ -380,33 +386,33 @@ bool TcrConnection::initTcrConnection(
 }
 
 switch (acceptanceCode[0]) {
-  case REPLY_OK:
-  case SUCCESSFUL_SERVER_TO_CLIENT:
+  case static_cast(acceptance_codes::REPLY_OK):

Review comment:
   Usage of `enum class` should be preferred to scope the constants and 
avoid collision with others not to mention avoid the strangely behaving type 
decaying old school `enum` does.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Handshake "acceptance codes" should be an enum class
> 
>
> Key: GEODE-10096
> URL: https://issues.apache.org/jira/browse/GEODE-10096
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> In the method TcrConnection::initTcrConnection, the following block of code 
> appears:
> {code:java}
> switch (acceptanceCode[0]) {
>   case REPLY_OK:
>   case SUCCESSFUL_SERVER_TO_CLIENT:
> LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
>  serverQueueStatus[0], recvMsgLen2);
> if (isClientNotification) 
> readHandshakeInstantiatorMsg(connectTimeout);
> break;
>   case REPLY_AUTHENTICATION_FAILED: {
> AuthenticationFailedException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_AUTHENTICATION_REQUIRED: {
> AuthenticationRequiredException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_DUPLICATE_DURABLE_CLIENT: {
> DuplicateDurableClientException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_REFUSED:
>   case REPLY_INVALID:
>   case UNSUCCESSFUL_SERVER_TO_CLIENT: {
> LOGERROR("Handshake rejected by server[%s]: %s",
>  m_endpointObj->name().c_str(),
>  reinterpret_cast(recvMessage.data()));
> auto message = std::string("TcrConnection::TcrConnection: ") +
>"Handshake rejected by server: " +
>reinterpret_cast(recvMessage.data());
> CacheServerException ex(message);
> m_conn.reset();
> throw ex;
>   }
> {code}
> These response codes are unique to the server handshake, and not used 
> anywhere else in the code. We need to remove the #defines for them and put 
> them in a proper enum class.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10096) Handshake "acceptance codes" should be an enum class

2022-03-03 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500886#comment-17500886
 ] 

ASF GitHub Bot commented on GEODE-10096:


pdxcodemonkey commented on a change in pull request #938:
URL: https://github.com/apache/geode-native/pull/938#discussion_r818854739



##
File path: cppcache/src/TcrConnection.cpp
##
@@ -380,33 +386,33 @@ bool TcrConnection::initTcrConnection(
 }
 
 switch (acceptanceCode[0]) {
-  case REPLY_OK:
-  case SUCCESSFUL_SERVER_TO_CLIENT:
+  case static_cast(acceptance_codes::REPLY_OK):

Review comment:
   Exactly, it's good already, just cast in one place instead of 5 (6?).
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Handshake "acceptance codes" should be an enum class
> 
>
> Key: GEODE-10096
> URL: https://issues.apache.org/jira/browse/GEODE-10096
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> In the method TcrConnection::initTcrConnection, the following block of code 
> appears:
> {code:java}
> switch (acceptanceCode[0]) {
>   case REPLY_OK:
>   case SUCCESSFUL_SERVER_TO_CLIENT:
> LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
>  serverQueueStatus[0], recvMsgLen2);
> if (isClientNotification) 
> readHandshakeInstantiatorMsg(connectTimeout);
> break;
>   case REPLY_AUTHENTICATION_FAILED: {
> AuthenticationFailedException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_AUTHENTICATION_REQUIRED: {
> AuthenticationRequiredException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_DUPLICATE_DURABLE_CLIENT: {
> DuplicateDurableClientException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_REFUSED:
>   case REPLY_INVALID:
>   case UNSUCCESSFUL_SERVER_TO_CLIENT: {
> LOGERROR("Handshake rejected by server[%s]: %s",
>  m_endpointObj->name().c_str(),
>  reinterpret_cast(recvMessage.data()));
> auto message = std::string("TcrConnection::TcrConnection: ") +
>"Handshake rejected by server: " +
>reinterpret_cast(recvMessage.data());
> CacheServerException ex(message);
> m_conn.reset();
> throw ex;
>   }
> {code}
> These response codes are unique to the server handshake, and not used 
> anywhere else in the code. We need to remove the #defines for them and put 
> them in a proper enum class.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Closed] (GEODE-10082) Duplicate values found in DSCode enums

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-10082.


> Duplicate values found in DSCode enums
> --
>
> Key: GEODE-10082
> URL: https://issues.apache.org/jira/browse/GEODE-10082
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Assignee: Jacob Barrett
>Priority: Major
>  Labels: needsTriage, pull-request-available
> Fix For: 1.15.0
>
>
> The following snippet appears in DSCode.hpp:
> ``` 
>   CacheableEnum = 94,
>   ClientProxyMembershipId = 38,
>   CacheableUserData = 39,
>   CacheableUserData2 = 38,
>   CacheableUserData4 = 37,
>   PDX = 93,
>   PDX_ENUM = 94,
>   InterestResultPolicy = 37,
> };
> ```
> `CacheableEnum` is the name of the class that geode-native uses for 
> `PDX_ENUM`, it should not exist as an enum value.  `ClientProxyMembershipId`, 
> `InternalDistributedMember`, and `InterestResultPolicy` are 
> `DataSerializableFixedId` values, and belong in that enum rather than DSCode.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (GEODE-10085) Multiple Locators Not Working in New .NET Test Framework

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-10085.
--
Fix Version/s: 1.15.0
   Resolution: Fixed

> Multiple Locators Not Working in New .NET Test Framework
> 
>
> Key: GEODE-10085
> URL: https://issues.apache.org/jira/browse/GEODE-10085
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>Priority: Major
>  Labels: needsTriage, pull-request-available
> Fix For: 1.15.0
>
>
> If a cluster with more than one locator is used in the new .NET test 
> framework, the test will fail. The failure results from trying to start 
> JmxManager when it is already running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Closed] (GEODE-10085) Multiple Locators Not Working in New .NET Test Framework

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-10085.


> Multiple Locators Not Working in New .NET Test Framework
> 
>
> Key: GEODE-10085
> URL: https://issues.apache.org/jira/browse/GEODE-10085
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Michael Martell
>Priority: Major
>  Labels: needsTriage, pull-request-available
> Fix For: 1.15.0
>
>
> If a cluster with more than one locator is used in the new .NET test 
> framework, the test will fail. The failure results from trying to start 
> JmxManager when it is already running.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10014) Add support for building nativeclient against older geode releases

2022-03-03 Thread Blake Bender (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500889#comment-17500889
 ] 

Blake Bender commented on GEODE-10014:
--

https://github.com/apache/geode-native/pull/917

> Add support for building nativeclient against older geode releases
> --
>
> Key: GEODE-10014
> URL: https://issues.apache.org/jira/browse/GEODE-10014
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>Assignee: Michael Martell
>Priority: Major
>
> Currently, the nativeclient's java test module (javaobject.jar) depends on a 
> very recent version of geode (1.15.0-build.546 or higher). This ticket is to 
> add support for building this jar file against older versions of geode which 
> do not contain the new AuthenticationExpiredException.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Closed] (GEODE-10014) Add support for building nativeclient against older geode releases

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-10014.


> Add support for building nativeclient against older geode releases
> --
>
> Key: GEODE-10014
> URL: https://issues.apache.org/jira/browse/GEODE-10014
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>Assignee: Michael Martell
>Priority: Major
> Fix For: 1.15.0
>
>
> Currently, the nativeclient's java test module (javaobject.jar) depends on a 
> very recent version of geode (1.15.0-build.546 or higher). This ticket is to 
> add support for building this jar file against older versions of geode which 
> do not contain the new AuthenticationExpiredException.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (GEODE-10014) Add support for building nativeclient against older geode releases

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-10014.
--
Fix Version/s: 1.15.0
   Resolution: Fixed

> Add support for building nativeclient against older geode releases
> --
>
> Key: GEODE-10014
> URL: https://issues.apache.org/jira/browse/GEODE-10014
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Michael Martell
>Assignee: Michael Martell
>Priority: Major
> Fix For: 1.15.0
>
>
> Currently, the nativeclient's java test module (javaobject.jar) depends on a 
> very recent version of geode (1.15.0-build.546 or higher). This ticket is to 
> add support for building this jar file against older versions of geode which 
> do not contain the new AuthenticationExpiredException.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Closed] (GEODE-9440) Revert changes for GEODE-9431

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender closed GEODE-9440.
---

> Revert changes for GEODE-9431
> -
>
> Key: GEODE-9440
> URL: https://issues.apache.org/jira/browse/GEODE-9440
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>
> We encountered a problem with `std::regex` crashing on RHEL-8 in release 
> builds, and the first fix we found that worked was to switch to 
> `boost::regex`.  We're filing bugs with RedHat and GNU, so if/when the issue 
> is resolved we will need to verify the fix and revert the workaround.  We 
> should be using `std::` objects whenever possible, certainly for something as 
> mainstream as `regex`.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (GEODE-9440) Revert changes for GEODE-9431

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-9440.
-
Resolution: Done

> Revert changes for GEODE-9431
> -
>
> Key: GEODE-9440
> URL: https://issues.apache.org/jira/browse/GEODE-9440
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>
> We encountered a problem with `std::regex` crashing on RHEL-8 in release 
> builds, and the first fix we found that worked was to switch to 
> `boost::regex`.  We're filing bugs with RedHat and GNU, so if/when the issue 
> is resolved we will need to verify the fix and revert the workaround.  We 
> should be using `std::` objects whenever possible, certainly for something as 
> mainstream as `regex`.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (GEODE-10082) Duplicate values found in DSCode enums

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-10082.
--
Fix Version/s: 1.15.0
   Resolution: Fixed

> Duplicate values found in DSCode enums
> --
>
> Key: GEODE-10082
> URL: https://issues.apache.org/jira/browse/GEODE-10082
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Assignee: Jacob Barrett
>Priority: Major
>  Labels: needsTriage, pull-request-available
> Fix For: 1.15.0
>
>
> The following snippet appears in DSCode.hpp:
> ``` 
>   CacheableEnum = 94,
>   ClientProxyMembershipId = 38,
>   CacheableUserData = 39,
>   CacheableUserData2 = 38,
>   CacheableUserData4 = 37,
>   PDX = 93,
>   PDX_ENUM = 94,
>   InterestResultPolicy = 37,
> };
> ```
> `CacheableEnum` is the name of the class that geode-native uses for 
> `PDX_ENUM`, it should not exist as an enum value.  `ClientProxyMembershipId`, 
> `InternalDistributedMember`, and `InterestResultPolicy` are 
> `DataSerializableFixedId` values, and belong in that enum rather than DSCode.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Resolved] (GEODE-3852) Fix race condition causing intermittent test failure

2022-03-03 Thread Blake Bender (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Blake Bender resolved GEODE-3852.
-
Fix Version/s: 1.15.0
   Resolution: Cannot Reproduce

Closing primordial native client bugs - after 5 years (!), this is either fixed 
elsewhere or no longer relevant.

> Fix race condition causing intermittent test failure
> 
>
> Key: GEODE-3852
> URL: https://issues.apache.org/jira/browse/GEODE-3852
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: David Kimura
>Priority: Major
> Fix For: 1.15.0
>
> Attachments: SampleFailureTest.cs
>
>
> ThinClientQueryTestsN fails intermittently.  Hypothesis is garbage collection 
> race-condition leading to access violations of deleted data.
> Here's an example stacktrace:
> {noformat}
>   [Managed to Native Transition]  
>   Apache.Geode.dll!std::shared_ptr::`scalar 
> deleting destructor' + 0x6b bytes   
> > 
> > Apache.Geode.dll!Apache::Geode::Client::native_shared_ptr::!native_shared_ptr()
> >  Line 27 + 0x13 bytesC++
>   
> Apache.Geode.dll!Apache::Geode::Client::native_shared_ptr::Dispose(bool
>  A_0) + 0x1e bytes C++
>   [Native to Managed Transition]  
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (GEODE-4198) DiskStoreMonitor should not invoke GemFireCacheImpl.getInstance

2022-03-03 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4198:
--
Labels: pull-request-available  (was: )

> DiskStoreMonitor should not invoke GemFireCacheImpl.getInstance
> ---
>
> Key: GEODE-4198
> URL: https://issues.apache.org/jira/browse/GEODE-4198
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Kirk Lund
>Assignee: Anilkumar Gingade
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>
> DiskStoreMonitor should not invoke GemFireCacheImpl.getInstance



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-4198) DiskStoreMonitor should not invoke GemFireCacheImpl.getInstance

2022-03-03 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500988#comment-17500988
 ] 

ASF GitHub Bot commented on GEODE-4198:
---

pdxcodemonkey opened a new pull request #942:
URL: https://github.com/apache/geode-native/pull/942


   rather than utf-8 --> utf-16 --> jmutf-8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> DiskStoreMonitor should not invoke GemFireCacheImpl.getInstance
> ---
>
> Key: GEODE-4198
> URL: https://issues.apache.org/jira/browse/GEODE-4198
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Kirk Lund
>Assignee: Anilkumar Gingade
>Priority: Major
> Fix For: 1.5.0
>
>
> DiskStoreMonitor should not invoke GemFireCacheImpl.getInstance



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10091) Benchmark instability in RedisZaddAndZremBenchmark

2022-03-03 Thread Eric Zoerner (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501034#comment-17501034
 ] 

Eric Zoerner commented on GEODE-10091:
--

Commit b7297023c309210e70f3792980e75d10c54e7421 can't be the culprit because 
the only changes in that commit are to test code in geode which isn't run in 
the geode-benchmarks. I am working on trying to find the commit(s) that are the 
culprit (if any)

> Benchmark instability in RedisZaddAndZremBenchmark
> --
>
> Key: GEODE-10091
> URL: https://issues.apache.org/jira/browse/GEODE-10091
> Project: Geode
>  Issue Type: Bug
>  Components: benchmarks, redis
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Assignee: Eric Zoerner
>Priority: Major
>  Labels: needsTriage
>
> {noformat}
> This is ITERATION 1 of benchmarking against baseline.
>    RedisGetBenchmark avg ops/sec  
> Baseline:428358.55  Test:446241.49  Difference:   +4.2%
>  avg latency  
> Baseline:   1678809.55  Test:   1611045.34  Difference:   -4.0%
>   RedisHgetBenchmark avg ops/sec  
> Baseline:438535.25  Test:441078.97  Difference:   +0.6%
>  avg latency  
> Baseline:   1638968.92  Test:   1630999.16  Difference:   -0.5%
>    RedisHsetAndHgetBenchmark avg ops/sec  
> Baseline:191331.54  Test:186806.37  Difference:   -2.4%
>  avg latency  
> Baseline:   3759694.09  Test:   3850396.04  Difference:   +2.4%
>   RedisHsetBenchmark avg ops/sec  
> Baseline:308079.41  Test:303715.78  Difference:   -1.4%
>  avg latency  
> Baseline:   2332102.91  Test:   2367639.93  Difference:   +1.5%
>    RedisSetBenchmark avg ops/sec  
> Baseline:318147.74  Test:326996.22  Difference:   +2.8%
>  avg latency  
> Baseline:   2263687.57  Test:   2198181.68  Difference:   -2.9%
>    RedisWeightedHsetAndHgetBenchmark avg ops/sec  
> Baseline:390383.79  Test:385565.48  Difference:   -1.2%
>  avg latency  
> Baseline:   1842561.96  Test:   1864716.09  Difference:   +1.2%
>  RedisWeightedZaddAndZrangeBenchmark avg ops/sec  
> Baseline:375078.82  Test:350886.03  Difference:   -6.5%
>  avg latency  
> Baseline:   1917476.15  Test:   2049452.87  Difference:   +6.9%
>    RedisZaddAndZremBenchmark avg ops/sec  
> Baseline:124763.60  Test:118600.72  Difference:   -4.9%
>  avg latency  
> Baseline:   5766048.34  Test:   6065491.13  Difference:   +5.2%
>   RedisZaddBenchmark avg ops/sec  
> Baseline:432494.29  Test:438594.53  Difference:   +1.4%
>  avg latency  
> Baseline:   1662639.09  Test:   1639906.18  Difference:   -1.4%
> RedisZrangeBenchmark avg ops/sec  
> Baseline:295523.77  Test:340381.87  Difference:  +15.2%
>  avg latency  
> Baseline:   2433250.54  Test:   2112961.66  Difference:  -13.2%
>  RedisZrangeByScoreBenchmark avg ops/sec  
> Baseline:285836.33  Test:356142.91  Difference:  +24.6%
>  avg latency  
> Baseline:   2515708.23  Test:   2019249.68  Difference:  -19.7%
> This is ITERATION 2 of benchmarking against baseline.
>  RedisWeightedZaddAndZrangeBenchmark avg ops/sec  
> Baseline:358570.33  Test:348012.02  Difference:   -2.9%
>  avg latency  
> Baseline:   2005804.05  Test:   2066535.24  Difference:   +3.0%
>    RedisZaddAndZremBenchmark avg ops/sec  
> Baseline:122900.38  Test:115226.22  Difference:   -6.2%
>  avg latency  
> Baseline:   5858357.13  Test:   6243018.38  Difference:   +6.6%
> This is ITERATION 3 of benchmarking against baseline.
>    RedisZaddAndZremBenchmark avg ops/sec  
> Baseline:125677.36  Test: 

[jira] [Updated] (GEODE-10082) Duplicate values found in DSCode enums

2022-03-03 Thread Jacob Barrett (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob Barrett updated GEODE-10082:
--
Fix Version/s: 1.16.0
   (was: 1.15.0)

> Duplicate values found in DSCode enums
> --
>
> Key: GEODE-10082
> URL: https://issues.apache.org/jira/browse/GEODE-10082
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Blake Bender
>Assignee: Jacob Barrett
>Priority: Major
>  Labels: needsTriage, pull-request-available
> Fix For: 1.16.0
>
>
> The following snippet appears in DSCode.hpp:
> ``` 
>   CacheableEnum = 94,
>   ClientProxyMembershipId = 38,
>   CacheableUserData = 39,
>   CacheableUserData2 = 38,
>   CacheableUserData4 = 37,
>   PDX = 93,
>   PDX_ENUM = 94,
>   InterestResultPolicy = 37,
> };
> ```
> `CacheableEnum` is the name of the class that geode-native uses for 
> `PDX_ENUM`, it should not exist as an enum value.  `ClientProxyMembershipId`, 
> `InternalDistributedMember`, and `InterestResultPolicy` are 
> `DataSerializableFixedId` values, and belong in that enum rather than DSCode.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10096) Handshake "acceptance codes" should be an enum class

2022-03-03 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501062#comment-17501062
 ] 

ASF GitHub Bot commented on GEODE-10096:


pivotal-jbarrett commented on a change in pull request #938:
URL: https://github.com/apache/geode-native/pull/938#discussion_r819110617



##
File path: cppcache/src/TcrConnection.cpp
##
@@ -380,33 +386,33 @@ bool TcrConnection::initTcrConnection(
 }
 
 switch (acceptanceCode[0]) {
-  case REPLY_OK:
-  case SUCCESSFUL_SERVER_TO_CLIENT:
+  case static_cast(acceptance_codes::REPLY_OK):

Review comment:
   Yup, the cast should be in the `switch` statement.
   ```c++
   switch (static_cast(acceptanceCode[0]) {
 case acceptance_codes::REPLY_OK:
   ...
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Handshake "acceptance codes" should be an enum class
> 
>
> Key: GEODE-10096
> URL: https://issues.apache.org/jira/browse/GEODE-10096
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> In the method TcrConnection::initTcrConnection, the following block of code 
> appears:
> {code:java}
> switch (acceptanceCode[0]) {
>   case REPLY_OK:
>   case SUCCESSFUL_SERVER_TO_CLIENT:
> LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
>  serverQueueStatus[0], recvMsgLen2);
> if (isClientNotification) 
> readHandshakeInstantiatorMsg(connectTimeout);
> break;
>   case REPLY_AUTHENTICATION_FAILED: {
> AuthenticationFailedException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_AUTHENTICATION_REQUIRED: {
> AuthenticationRequiredException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_DUPLICATE_DURABLE_CLIENT: {
> DuplicateDurableClientException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_REFUSED:
>   case REPLY_INVALID:
>   case UNSUCCESSFUL_SERVER_TO_CLIENT: {
> LOGERROR("Handshake rejected by server[%s]: %s",
>  m_endpointObj->name().c_str(),
>  reinterpret_cast(recvMessage.data()));
> auto message = std::string("TcrConnection::TcrConnection: ") +
>"Handshake rejected by server: " +
>reinterpret_cast(recvMessage.data());
> CacheServerException ex(message);
> m_conn.reset();
> throw ex;
>   }
> {code}
> These response codes are unique to the server handshake, and not used 
> anywhere else in the code. We need to remove the #defines for them and put 
> them in a proper enum class.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10096) Handshake "acceptance codes" should be an enum class

2022-03-03 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501063#comment-17501063
 ] 

ASF GitHub Bot commented on GEODE-10096:


pivotal-jbarrett commented on a change in pull request #938:
URL: https://github.com/apache/geode-native/pull/938#discussion_r819111687



##
File path: cppcache/src/TcrConnection.hpp
##
@@ -33,22 +33,28 @@
 #include "util/synchronized_set.hpp"
 
 #define DEFAULT_TIMEOUT_RETRIES 12
-#define PRIMARY_SERVER_TO_CLIENT 101
-#define SECONDARY_SERVER_TO_CLIENT 102
-#define SUCCESSFUL_SERVER_TO_CLIENT 105
-#define UNSUCCESSFUL_SERVER_TO_CLIENT 106
-#define CLIENT_TO_SERVER 100
-#define REPLY_OK 59
-#define REPLY_REFUSED 60
-#define REPLY_INVALID 61
-#define REPLY_SSL_ENABLED 21
-#define REPLY_AUTHENTICATION_REQUIRED 62
-#define REPLY_AUTHENTICATION_FAILED 63
-#define REPLY_DUPLICATE_DURABLE_CLIENT 64
-
-#define SECURITY_CREDENTIALS_NONE 0
-#define SECURITY_CREDENTIALS_NORMAL 1
-#define SECURITY_MULTIUSER_NOTIFICATIONCHANNEL 3
+
+enum class acceptor : ::std::int8_t {

Review comment:
   While personally like the std C++ style these names don't conform to our 
[style guide](https://google.github.io/styleguide/cppguide.html#Type_Names). 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Handshake "acceptance codes" should be an enum class
> 
>
> Key: GEODE-10096
> URL: https://issues.apache.org/jira/browse/GEODE-10096
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> In the method TcrConnection::initTcrConnection, the following block of code 
> appears:
> {code:java}
> switch (acceptanceCode[0]) {
>   case REPLY_OK:
>   case SUCCESSFUL_SERVER_TO_CLIENT:
> LOGFINER("Handshake reply: %u,%u,%u", acceptanceCode[0],
>  serverQueueStatus[0], recvMsgLen2);
> if (isClientNotification) 
> readHandshakeInstantiatorMsg(connectTimeout);
> break;
>   case REPLY_AUTHENTICATION_FAILED: {
> AuthenticationFailedException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_AUTHENTICATION_REQUIRED: {
> AuthenticationRequiredException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_DUPLICATE_DURABLE_CLIENT: {
> DuplicateDurableClientException ex(
> reinterpret_cast(recvMessage.data()));
> m_conn.reset();
> throwException(ex);
>   }
>   case REPLY_REFUSED:
>   case REPLY_INVALID:
>   case UNSUCCESSFUL_SERVER_TO_CLIENT: {
> LOGERROR("Handshake rejected by server[%s]: %s",
>  m_endpointObj->name().c_str(),
>  reinterpret_cast(recvMessage.data()));
> auto message = std::string("TcrConnection::TcrConnection: ") +
>"Handshake rejected by server: " +
>reinterpret_cast(recvMessage.data());
> CacheServerException ex(message);
> m_conn.reset();
> throw ex;
>   }
> {code}
> These response codes are unique to the server handshake, and not used 
> anywhere else in the code. We need to remove the #defines for them and put 
> them in a proper enum class.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10100) release 1.13.8

2022-03-03 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501132#comment-17501132
 ] 

ASF subversion and git services commented on GEODE-10100:
-

Commit ab2510bc1d5c9db1846a389b2dbf0d3c8697b537 in geode-examples's branch 
refs/heads/support/1.13 from Dick Cavender
[ https://gitbox.apache.org/repos/asf?p=geode-examples.git;h=ab2510b ]

GEODE-10100: Bump version to 1.13.8

As part of the Geode Release Process, the geode-examples build number
must be rolled forward as work begins on the next release


> release 1.13.8
> --
>
> Key: GEODE-10100
> URL: https://issues.apache.org/jira/browse/GEODE-10100
> Project: Geode
>  Issue Type: Task
>  Components: release
>Reporter: Dick Cavender
>Priority: Major
>
> Release to incorporate  GEODE-10093



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10100) release 1.13.8

2022-03-03 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501133#comment-17501133
 ] 

ASF subversion and git services commented on GEODE-10100:
-

Commit b4314d94e8f38e191e6d440dcc3a78f17966b278 in geode-examples's branch 
refs/heads/support/1.13 from Dick Cavender
[ https://gitbox.apache.org/repos/asf?p=geode-examples.git;h=b4314d9 ]

GEODE-10100: Set temporary staging repo

This serves two purposes: it gives the RC pipeline a way to get the
nexus staging repo id needed for various tests, and it gives the
Jenkins server a valid configuration during the voting period.


> release 1.13.8
> --
>
> Key: GEODE-10100
> URL: https://issues.apache.org/jira/browse/GEODE-10100
> Project: Geode
>  Issue Type: Task
>  Components: release
>Reporter: Dick Cavender
>Priority: Major
>
> Release to incorporate  GEODE-10093



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10100) release 1.13.8

2022-03-03 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501134#comment-17501134
 ] 

ASF subversion and git services commented on GEODE-10100:
-

Commit d2c710cf8033bf50205c829bca565119a773a3a7 in geode-examples's branch 
refs/heads/support/1.13 from Dick Cavender
[ https://gitbox.apache.org/repos/asf?p=geode-examples.git;h=d2c710c ]

GEODE-10100: Bump version to 1.13.8

As part of the Geode Release Process, the geode-examples build number
must be rolled forward as work begins on the next release


> release 1.13.8
> --
>
> Key: GEODE-10100
> URL: https://issues.apache.org/jira/browse/GEODE-10100
> Project: Geode
>  Issue Type: Task
>  Components: release
>Reporter: Dick Cavender
>Priority: Major
>
> Release to incorporate  GEODE-10093



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (GEODE-10102) [CI Failure] Tomcat6CachingClientServerTest > invalidationShouldRemoveValueAccessForAllContainers FAILED

2022-03-03 Thread Geode Integration (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501205#comment-17501205
 ] 

Geode Integration commented on GEODE-10102:
---

Seen on support/1.13 in [distributed-test-openjdk8 
#32|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-13-main/jobs/distributed-test-openjdk8/builds/32]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.8-build.0656/test-results/distributedTest/1646270295/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.8-build.0656/test-artifacts/1646270295/distributedtestfiles-openjdk8-1.13.8-build.0656.tgz].

> [CI Failure] Tomcat6CachingClientServerTest > 
> invalidationShouldRemoveValueAccessForAllContainers FAILED
> 
>
> Key: GEODE-10102
> URL: https://issues.apache.org/jira/browse/GEODE-10102
> Project: Geode
>  Issue Type: Task
>  Components: http session
>Affects Versions: 1.13.8
>Reporter: Owen Nichols
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Created] (GEODE-10102) [CI Failure] Tomcat6CachingClientServerTest > invalidationShouldRemoveValueAccessForAllContainers FAILED

2022-03-03 Thread Owen Nichols (Jira) 
Owen Nichols created GEODE-10102:


 Summary: [CI Failure] Tomcat6CachingClientServerTest > 
invalidationShouldRemoveValueAccessForAllContainers FAILED
 Key: GEODE-10102
 URL: https://issues.apache.org/jira/browse/GEODE-10102
 Project: Geode
  Issue Type: Task
  Components: http session
Affects Versions: 1.13.8
Reporter: Owen Nichols






--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Updated] (GEODE-10102) [CI Failure] Tomcat6CachingClientServerTest > invalidationShouldRemoveValueAccessForAllContainers FAILED

2022-03-03 Thread Owen Nichols (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Owen Nichols updated GEODE-10102:
-
Description: 
{noformat}
org.apache.geode.session.tests.Tomcat6CachingClientServerTest > 
invalidationShouldRemoveValueAccessForAllContainers FAILED
org.junit.ComparisonFailure: expected:<"[]"> but was:<"[Foo]">
 {noformat}

> [CI Failure] Tomcat6CachingClientServerTest > 
> invalidationShouldRemoveValueAccessForAllContainers FAILED
> 
>
> Key: GEODE-10102
> URL: https://issues.apache.org/jira/browse/GEODE-10102
> Project: Geode
>  Issue Type: Task
>  Components: http session
>Affects Versions: 1.13.8
>Reporter: Owen Nichols
>Priority: Major
>
> {noformat}
> org.apache.geode.session.tests.Tomcat6CachingClientServerTest > 
> invalidationShouldRemoveValueAccessForAllContainers FAILED
> org.junit.ComparisonFailure: expected:<"[]"> but was:<"[Foo]">
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)