[jira] [Resolved] (GEODE-9786) remove IndexibleTreeSet and associated tests
[ https://issues.apache.org/jira/browse/GEODE-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans resolved GEODE-9786. Fix Version/s: 1.15.0 Resolution: Fixed > remove IndexibleTreeSet and associated tests > > > Key: GEODE-9786 > URL: https://issues.apache.org/jira/browse/GEODE-9786 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Darrel Schneider >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > IndexibleTreeSet is unused by geode-for-redis. It was added to compare its > performance to OrderStatisticsTree and a decision was made to use > OrderStatisticsTree. > So to simplify the code and testing it should be removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9786) remove IndexibleTreeSet and associated tests
[ https://issues.apache.org/jira/browse/GEODE-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438801#comment-17438801 ] ASF subversion and git services commented on GEODE-9786: Commit 60c62d8c81a53d75f03e347574d6f1f63aacea7b in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=60c62d8 ] GEODE-9786: Make IndexibleTreeSet inner class of quick check test (#7078) Authored-by: Donal Evans > remove IndexibleTreeSet and associated tests > > > Key: GEODE-9786 > URL: https://issues.apache.org/jira/browse/GEODE-9786 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Darrel Schneider >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > IndexibleTreeSet is unused by geode-for-redis. It was added to compare its > performance to OrderStatisticsTree and a decision was made to use > OrderStatisticsTree. > So to simplify the code and testing it should be removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9796) CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
[
https://issues.apache.org/jira/browse/GEODE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Murmann updated GEODE-9796:
-
Labels: needsTriage (was: )
> CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
> -
>
> Key: GEODE-9796
> URL: https://issues.apache.org/jira/browse/GEODE-9796
> Project: Geode
> Issue Type: Bug
> Components: ci
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Priority: Major
> Labels: needsTriage
>
> The job fails with the following error:
> {noformat}
> ERROR: JAVA_HOME is set to an invalid directory:
> /usr/lib/jvm/jdk-8u312-bellsoft-x86_64
> Please set the JAVA_HOME variable in your environment to match the
> location of your Java installation.
> {noformat}
> Link to the first failed concourse run:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1090
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-9796) CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
Donal Evans created GEODE-9796:
--
Summary: CI Failure: reap-benchmark-instances fails with invalid
JAVA_HOME
Key: GEODE-9796
URL: https://issues.apache.org/jira/browse/GEODE-9796
Project: Geode
Issue Type: Bug
Components: ci
Affects Versions: 1.15.0
Reporter: Donal Evans
The job fails with the following error:
{noformat}
ERROR: JAVA_HOME is set to an invalid directory:
/usr/lib/jvm/jdk-8u312-bellsoft-x86_64
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.
{noformat}
Link to the first failed concourse run:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1090
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9796) CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
[
https://issues.apache.org/jira/browse/GEODE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438807#comment-17438807
]
Geode Integration commented on GEODE-9796:
--
Seen in [reap-benchmark-instances
#1092|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1092].
> CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
> -
>
> Key: GEODE-9796
> URL: https://issues.apache.org/jira/browse/GEODE-9796
> Project: Geode
> Issue Type: Bug
> Components: ci
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Priority: Major
> Labels: needsTriage
>
> The job fails with the following error:
> {noformat}
> ERROR: JAVA_HOME is set to an invalid directory:
> /usr/lib/jvm/jdk-8u312-bellsoft-x86_64
> Please set the JAVA_HOME variable in your environment to match the
> location of your Java installation.
> {noformat}
> Link to the first failed concourse run:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1090
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9796) CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
[
https://issues.apache.org/jira/browse/GEODE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438805#comment-17438805
]
Geode Integration commented on GEODE-9796:
--
Seen in [reap-benchmark-instances
#1090|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1090].
> CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
> -
>
> Key: GEODE-9796
> URL: https://issues.apache.org/jira/browse/GEODE-9796
> Project: Geode
> Issue Type: Bug
> Components: ci
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Priority: Major
> Labels: needsTriage
>
> The job fails with the following error:
> {noformat}
> ERROR: JAVA_HOME is set to an invalid directory:
> /usr/lib/jvm/jdk-8u312-bellsoft-x86_64
> Please set the JAVA_HOME variable in your environment to match the
> location of your Java installation.
> {noformat}
> Link to the first failed concourse run:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1090
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9796) CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
[
https://issues.apache.org/jira/browse/GEODE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438806#comment-17438806
]
Geode Integration commented on GEODE-9796:
--
Seen in [reap-benchmark-instances
#1091|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1091].
> CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
> -
>
> Key: GEODE-9796
> URL: https://issues.apache.org/jira/browse/GEODE-9796
> Project: Geode
> Issue Type: Bug
> Components: ci
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Priority: Major
> Labels: needsTriage
>
> The job fails with the following error:
> {noformat}
> ERROR: JAVA_HOME is set to an invalid directory:
> /usr/lib/jvm/jdk-8u312-bellsoft-x86_64
> Please set the JAVA_HOME variable in your environment to match the
> location of your Java installation.
> {noformat}
> Link to the first failed concourse run:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1090
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-9796) CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
[
https://issues.apache.org/jira/browse/GEODE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen Nichols reassigned GEODE-9796:
---
Assignee: Owen Nichols
> CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
> -
>
> Key: GEODE-9796
> URL: https://issues.apache.org/jira/browse/GEODE-9796
> Project: Geode
> Issue Type: Bug
> Components: ci
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Assignee: Owen Nichols
>Priority: Major
> Labels: needsTriage
>
> The job fails with the following error:
> {noformat}
> ERROR: JAVA_HOME is set to an invalid directory:
> /usr/lib/jvm/jdk-8u312-bellsoft-x86_64
> Please set the JAVA_HOME variable in your environment to match the
> location of your Java installation.
> {noformat}
> Link to the first failed concourse run:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1090
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9796) CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
[
https://issues.apache.org/jira/browse/GEODE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438808#comment-17438808
]
ASF subversion and git services commented on GEODE-9796:
Commit 4dc33b167e85080ebc8d4bc75d94348f6ed2c662 in geode-benchmarks's branch
refs/heads/develop from Owen Nichols
[ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=4dc33b1 ]
GEODE-9796: workaround for cgroups issue
> CI Failure: reap-benchmark-instances fails with invalid JAVA_HOME
> -
>
> Key: GEODE-9796
> URL: https://issues.apache.org/jira/browse/GEODE-9796
> Project: Geode
> Issue Type: Bug
> Components: ci
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Assignee: Owen Nichols
>Priority: Major
> Labels: needsTriage
>
> The job fails with the following error:
> {noformat}
> ERROR: JAVA_HOME is set to an invalid directory:
> /usr/lib/jvm/jdk-8u312-bellsoft-x86_64
> Please set the JAVA_HOME variable in your environment to match the
> location of your Java installation.
> {noformat}
> Link to the first failed concourse run:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-reaper/jobs/reap-benchmark-instances/builds/1090
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-5934) fix examples pipeline
[ https://issues.apache.org/jira/browse/GEODE-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans resolved GEODE-5934. Resolution: Fixed > fix examples pipeline > - > > Key: GEODE-5934 > URL: https://issues.apache.org/jira/browse/GEODE-5934 > Project: Geode > Issue Type: Bug >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > looks like this pipeline got missed in the refactoring -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-5934) fix examples pipeline
[ https://issues.apache.org/jira/browse/GEODE-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438811#comment-17438811 ] Donal Evans commented on GEODE-5934: Closing this ticket as it was fixed in Geode 1.8.0 > fix examples pipeline > - > > Key: GEODE-5934 > URL: https://issues.apache.org/jira/browse/GEODE-5934 > Project: Geode > Issue Type: Bug >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > looks like this pipeline got missed in the refactoring -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9794) Radish PassiveExpirationManager can throw NPE
[
https://issues.apache.org/jira/browse/GEODE-9794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe resolved GEODE-9794.
---
Fix Version/s: 1.15.0
Resolution: Fixed
> Radish PassiveExpirationManager can throw NPE
> -
>
> Key: GEODE-9794
> URL: https://issues.apache.org/jira/browse/GEODE-9794
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: needsTriage, pull-request-available
> Fix For: 1.15.0
>
>
> I noticed this log entry in a recent test:
>
> {noformat}
> [warn 2021/11/02 15:12:08.402 PDT redisServergemfire1_host1_9725
> tid=0x47] Passive expiration failed. Will
> try again in 1 second.
> java.lang.NullPointerException
> at
> org.apache.geode.redis.internal.PassiveExpirationManager.doDataExpiration(PassiveExpirationManager.java:66)
> at
> org.apache.geode.redis.internal.PassiveExpirationManager.lambda$new$0(PassiveExpirationManager.java:49)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9291) Develop Benchmarking Tests for Leaderboard API
[
https://issues.apache.org/jira/browse/GEODE-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438970#comment-17438970
]
ASF GitHub Bot commented on GEODE-9291:
---
nonbinaryprogrammer commented on a change in pull request #160:
URL: https://github.com/apache/geode-benchmarks/pull/160#discussion_r743246628
##
File path:
geode-benchmarks/src/main/java/org/apache/geode/benchmark/redis/tasks/ZaddAndZremRedisTask.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.geode.benchmark.redis.tasks;
+
+
+import static org.apache.geode.benchmark.redis.tasks.RedisSplitKey.toKey;
+import static org.apache.geode.benchmark.redis.tasks.RedisSplitKey.toPart;
+
+import java.io.Serializable;
+import java.util.Map;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.yardstickframework.BenchmarkConfiguration;
+import org.yardstickframework.BenchmarkDriverAdapter;
+
+import org.apache.geode.benchmark.LongRange;
+
+public class ZaddAndZremRedisTask extends BenchmarkDriverAdapter implements
Serializable {
+ private static final Logger logger =
LoggerFactory.getLogger(ZaddAndZremRedisTask.class);
+
+ private final RedisClientManager redisClientManager;
+ private final LongRange keyRange;
+
+ private transient LongStringCache keyCache;
+ private transient RedisClient redisClient;
+
+ public ZaddAndZremRedisTask(final RedisClientManager redisClientManager,
+ final LongRange keyRange) {
+logger.info("Initialized: keyRange={}", keyRange);
+this.redisClientManager = redisClientManager;
+this.keyRange = keyRange;
+ }
+
+ @Override
+ public void setUp(final BenchmarkConfiguration cfg) throws Exception {
+super.setUp(cfg);
+
+keyCache = new LongStringCache(keyRange);
+redisClient = redisClientManager.get();
+ }
+
+ private static String NEXT_KEY = "N";
+
+ @Override
+ public boolean test(final Map ctx) throws Exception {
+final long k = keyRange.random();
+
+final String key = keyCache.valueOf(toKey(k));
+final long score = toPart(k);
+final String value = keyCache.valueOf(score);
+redisClient.zadd(key, score, value);
+redisClient.zrem(key, value);
Review comment:
I'm not a huge fan of creating a sorted set then turning around and
deleting that same sorted set. Have you considered adding a random key and then
removing a random key? There are definitely some potential issues there (ie
always getting unlucky and removing a key that doesn't exist, resulting in more
creates than deletes, or conversely getting unlucky when adding a sorted set
and colliding with one that exists already, causing more removes than adds), I
just want to make sure that this is the best test that we can do given these
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Develop Benchmarking Tests for Leaderboard API
> --
>
> Key: GEODE-9291
> URL: https://issues.apache.org/jira/browse/GEODE-9291
> Project: Geode
> Issue Type: Test
> Components: redis
>Affects Versions: 1.15.0
>Reporter: Wayne
>Assignee: Eric Zoerner
>Priority: Major
> Labels: pull-request-available, redis
>
> Develop a suite of benchmarking tests for the Leaderboard API that benchmark
> the comparison between native Redis and the compatibility with Redis layer.
> +Acceptance Criteria+
> A benchmark should be developed that provides acceptable coverage (TBD) of
> the Leaderboard API that allows us to monitor the performance over time and
> compared to native Redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9291) Develop Benchmarking Tests for Leaderboard API
[
https://issues.apache.org/jira/browse/GEODE-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438973#comment-17438973
]
ASF GitHub Bot commented on GEODE-9291:
---
ezoerner commented on a change in pull request #160:
URL: https://github.com/apache/geode-benchmarks/pull/160#discussion_r743258356
##
File path:
geode-benchmarks/src/main/java/org/apache/geode/benchmark/redis/tasks/ZaddAndZremRedisTask.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.geode.benchmark.redis.tasks;
+
+
+import static org.apache.geode.benchmark.redis.tasks.RedisSplitKey.toKey;
+import static org.apache.geode.benchmark.redis.tasks.RedisSplitKey.toPart;
+
+import java.io.Serializable;
+import java.util.Map;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.yardstickframework.BenchmarkConfiguration;
+import org.yardstickframework.BenchmarkDriverAdapter;
+
+import org.apache.geode.benchmark.LongRange;
+
+public class ZaddAndZremRedisTask extends BenchmarkDriverAdapter implements
Serializable {
+ private static final Logger logger =
LoggerFactory.getLogger(ZaddAndZremRedisTask.class);
+
+ private final RedisClientManager redisClientManager;
+ private final LongRange keyRange;
+
+ private transient LongStringCache keyCache;
+ private transient RedisClient redisClient;
+
+ public ZaddAndZremRedisTask(final RedisClientManager redisClientManager,
+ final LongRange keyRange) {
+logger.info("Initialized: keyRange={}", keyRange);
+this.redisClientManager = redisClientManager;
+this.keyRange = keyRange;
+ }
+
+ @Override
+ public void setUp(final BenchmarkConfiguration cfg) throws Exception {
+super.setUp(cfg);
+
+keyCache = new LongStringCache(keyRange);
+redisClient = redisClientManager.get();
+ }
+
+ private static String NEXT_KEY = "N";
+
+ @Override
+ public boolean test(final Map ctx) throws Exception {
+final long k = keyRange.random();
+
+final String key = keyCache.valueOf(toKey(k));
+final long score = toPart(k);
+final String value = keyCache.valueOf(score);
+redisClient.zadd(key, score, value);
+redisClient.zrem(key, value);
Review comment:
> Have you considered adding a random key and then removing a random
key?
This is what is actually happening. A random long is being fetched from the
entire key range, but that long is then broken apart using `toKey` and `toPart`
to get a top-level key and a value which is the value that goes into the sorted
set itself. The `RedisSplitKey` class used to be named `RedisHash` because it
was used for hashes to split the long value into a top-level key and a
hash-key. I re-used this code for sorted sets. I renamed it to "split key" so
that it wasn't specific to hashes but can be used for any kind of container
data type that contains values. It essentially splits a random long value into
a key and a sub-part. I struggled a little bit to find a good name for this
that would be self-evident without requiring a bunch of extra comments in the
code, but maybe more explanation about is going on here in code comments would
help(?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Develop Benchmarking Tests for Leaderboard API
> --
>
> Key: GEODE-9291
> URL: https://issues.apache.org/jira/browse/GEODE-9291
> Project: Geode
> Issue Type: Test
> Components: redis
>Affects Versions: 1.15.0
>Reporter: Wayne
>Assignee: Eric Zoerner
>Priority: Major
> Labels: pull-request-available, redis
>
> Develop a suite of benchmarking tests for the Leaderboard API that benchmark
> the comparison between native Redis and the compatibility with Redis layer.
> +Acceptance C
[jira] [Commented] (GEODE-9774) Function execution on partition region does not clear networkHop on exit
[ https://issues.apache.org/jira/browse/GEODE-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17439056#comment-17439056 ] ASF subversion and git services commented on GEODE-9774: Commit 4c43c53b6a9dda8e8af0eaf586ccc3b63fd408d0 in geode's branch refs/heads/develop from Alberto Gomez [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4c43c53 ] GEODE-9774: Clear networkHop variable at function execution exit (#7051) * GEODE-9774: Clear networkHop variable at function execution exit * GEODE-9774: Added unit test after review > Function execution on partition region does not clear networkHop on exit > > > Key: GEODE-9774 > URL: https://issues.apache.org/jira/browse/GEODE-9774 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: needsTriage, pull-request-available > > When executing a server function on a partitioned region, if a network hop is > done during the execution of the function to access data from another server, > the networkHop thread local variable on the PartitionedRegion instance will > be set to either 1 or 2. Nevertheless, when the function returns, the > variable will not be reset leaving a wrong value in it for subsequent > requests. > As a result, subsequent requests handled by the same thread that executed the > previous function will see the networkHop thread local variable with the > value set previously by the function no matter if a network hop was required > or not. In case of get/put/destroy/invalidate, the server will return this > information to the client indicating that it should update the metadata when > it should not. > This will cause unnecessary requests from the client to update the metadata > which could impact very negatively the performance of the system. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9774) Function execution on partition region does not clear networkHop on exit
[ https://issues.apache.org/jira/browse/GEODE-9774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alberto Gomez resolved GEODE-9774. -- Fix Version/s: 1.15.0 Resolution: Fixed > Function execution on partition region does not clear networkHop on exit > > > Key: GEODE-9774 > URL: https://issues.apache.org/jira/browse/GEODE-9774 > Project: Geode > Issue Type: Bug > Components: functions >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: needsTriage, pull-request-available > Fix For: 1.15.0 > > > When executing a server function on a partitioned region, if a network hop is > done during the execution of the function to access data from another server, > the networkHop thread local variable on the PartitionedRegion instance will > be set to either 1 or 2. Nevertheless, when the function returns, the > variable will not be reset leaving a wrong value in it for subsequent > requests. > As a result, subsequent requests handled by the same thread that executed the > previous function will see the networkHop thread local variable with the > value set previously by the function no matter if a network hop was required > or not. In case of get/put/destroy/invalidate, the server will return this > information to the client indicating that it should update the metadata when > it should not. > This will cause unnecessary requests from the client to update the metadata > which could impact very negatively the performance of the system. -- This message was sent by Atlassian Jira (v8.3.4#803005)
