[jira] [Commented] (GEODE-9576) InternalFunctionInvocationTargetException when executing single hop function all buckets

2021-09-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413013#comment-17413013
 ] 

ASF GitHub Bot commented on GEODE-9576:
---

jvarenina commented on a change in pull request #864:
URL: https://github.com/apache/geode-native/pull/864#discussion_r705952887



##
File path: cppcache/integration/test/FunctionExecutionTest.cpp
##
@@ -175,6 +181,58 @@ TEST(FunctionExecutionTest,
   cache.close();
 }
 
+void populateRegion(const std::shared_ptr ®ion) {
+  for (int i = 0; i < 113; i++) {
+region->put("KEY--" + std::to_string(i), "VALUE--" + std::to_string(i));
+  }
+}
+
+TEST(FunctionExecutionTest, FunctionExecutionSingleHopNonHA) {
+  Cluster cluster{
+  LocatorCount{1}, ServerCount{3},
+  CacheXMLFiles(
+  {std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver1_pool_nonHA.xml",
+   std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver2_pool_nonHA.xml",
+   std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver3_pool_nonHA.xml"})};
+
+  cluster.start([&]() {
+cluster.getGfsh()
+.deploy()
+.jar(getFrameworkString(FrameworkVariable::JavaObjectJarPath))
+.execute();
+  });
+
+  auto cache = CacheFactory().create();
+  auto poolFactory = cache.getPoolManager().createFactory();
+
+  cluster.applyLocators(poolFactory);
+
+  auto pool =
+  poolFactory.setPRSingleHopEnabled(true).setRetryAttempts(0).create(
+  "pool");
+
+  auto region = cache.createRegionFactory(RegionShortcut::PROXY)
+.setPoolName("pool")
+.create("partition_region");
+
+  populateRegion(region);
+
+  for (int i = 0; i < 30; i++) {
+auto functionService = FunctionService::onRegion(region);
+auto rc =
+functionService.withCollector(std::make_shared())

Review comment:
   Thanks for the review! Really appreciate it!
   
   Actually I already did the same thing in my integration test 
`FunctionExecutionWithIncompleteBucketLocations`. If you inspect it closely you 
will see following similarities:
   
   1. I do same here as you when execute 50 puts. Additionally, I use hook to 
check that metadata is updated on client. For this case it is important to have 
incomplete metadata (number of locations is not important in retrieved 
metadata), because in case metadata is never refreshed on client the faulty 
case would not be triggered. I think that you use sleep instead the hook for 
this reason.
   ```
 // Populate region in a way that not all buckets are created.
 // Servers in this case will create 88 of possible 113 buckets.
 populateRegion(region);
   
 // Check that PR metadata is updated. This is done to be sure
 // that client will execute function in a non single hop manner
 // because metadata doesn't contain all bucket locations.
 // After metadata is refreshed, it will contain at least one
 // bucket location.
 CacheImpl *cacheImpl = CacheRegionHelper::getCacheImpl(&cache);
 waitUntilPRMetadataIsRefreshed(cacheImpl);
   ```
   2. Then I execute function, which then trigger faulty case. You can remove 
fix and execute this case, and you will get 
"InternalFunctionInvocationTargetException" every time.
   ```
 auto functionService = FunctionService::onRegion(region);
 auto rc =
 functionService.withCollector(std::make_shared())
 .execute("MultiGetAllFunctionNonHA");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InternalFunctionInvocationTargetException when executing single hop function 
> all buckets
> 
>
> Key: GEODE-9576
> URL: https://issues.apache.org/jira/browse/GEODE-9576
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
>  Labels: pull-request-available
>
>  *InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation* occurs on native client when executing function in a 
> single hop manner for all buckets during the period when client bucket 
> metadata doesn't contain all buckets locations.
> Java client in this case executes functions in non single hop manner until it 
> receives locations of all buckets on servers. The solution in native cl

[jira] [Commented] (GEODE-9576) InternalFunctionInvocationTargetException when executing single hop function all buckets

2021-09-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413015#comment-17413015
 ] 

ASF GitHub Bot commented on GEODE-9576:
---

jvarenina commented on a change in pull request #864:
URL: https://github.com/apache/geode-native/pull/864#discussion_r705954380



##
File path: cppcache/src/ClientMetadataService.cpp
##
@@ -578,12 +579,10 @@ ClientMetadataService::pruneNodes(
 const auto locations = metadata->adviseServerLocations(bucketId);
 if (locations.size() == 0) {
   LOGDEBUG(
-  "ClientMetadataService::pruneNodes Since no server location "
-  "available for bucketId = %d  putting it into "
-  "bucketSetWithoutServer ",
+  "ClientMetadataService::pruneNodes Use non single-hop path "
+  "since no server location is available for bucketId = %d",
   bucketId);
-  bucketSetWithoutServer.insert(bucketId);
-  continue;
+  return nullptr;

Review comment:
   Thank you for the review!
   
   There is already integration 
"FunctionExecutionTest.FunctionExecutionWithIncompleteBucketLocations" test in 
this PR that exposes the issue. Please check comment 
https://github.com/apache/geode-native/pull/864#discussion_r705952887 .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InternalFunctionInvocationTargetException when executing single hop function 
> all buckets
> 
>
> Key: GEODE-9576
> URL: https://issues.apache.org/jira/browse/GEODE-9576
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
>  Labels: pull-request-available
>
>  *InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation* occurs on native client when executing function in a 
> single hop manner for all buckets during the period when client bucket 
> metadata doesn't contain all buckets locations.
> Java client in this case executes functions in non single hop manner until it 
> receives locations of all buckets on servers. The solution in native client 
> would be to implement the same handling as in java client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9576) InternalFunctionInvocationTargetException when executing single hop function all buckets

2021-09-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413229#comment-17413229
 ] 

ASF GitHub Bot commented on GEODE-9576:
---

pdxcodemonkey commented on a change in pull request #864:
URL: https://github.com/apache/geode-native/pull/864#discussion_r706251752



##
File path: cppcache/integration/test/FunctionExecutionTest.cpp
##
@@ -175,6 +181,58 @@ TEST(FunctionExecutionTest,
   cache.close();
 }
 
+void populateRegion(const std::shared_ptr ®ion) {
+  for (int i = 0; i < 113; i++) {
+region->put("KEY--" + std::to_string(i), "VALUE--" + std::to_string(i));
+  }
+}
+
+TEST(FunctionExecutionTest, FunctionExecutionSingleHopNonHA) {
+  Cluster cluster{
+  LocatorCount{1}, ServerCount{3},
+  CacheXMLFiles(
+  {std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver1_pool_nonHA.xml",
+   std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver2_pool_nonHA.xml",
+   std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver3_pool_nonHA.xml"})};
+
+  cluster.start([&]() {
+cluster.getGfsh()
+.deploy()
+.jar(getFrameworkString(FrameworkVariable::JavaObjectJarPath))
+.execute();
+  });
+
+  auto cache = CacheFactory().create();
+  auto poolFactory = cache.getPoolManager().createFactory();
+
+  cluster.applyLocators(poolFactory);
+
+  auto pool =
+  poolFactory.setPRSingleHopEnabled(true).setRetryAttempts(0).create(
+  "pool");
+
+  auto region = cache.createRegionFactory(RegionShortcut::PROXY)
+.setPoolName("pool")
+.create("partition_region");
+
+  populateRegion(region);
+
+  for (int i = 0; i < 30; i++) {
+auto functionService = FunctionService::onRegion(region);
+auto rc =
+functionService.withCollector(std::make_shared())

Review comment:
   Sorry, totally missed this test - dunno how that happened.  To confirm 
your conjecture above, yes my test sleeps because it has to have a metadata 
update, with partial info, to repro the failure, just as yours does.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InternalFunctionInvocationTargetException when executing single hop function 
> all buckets
> 
>
> Key: GEODE-9576
> URL: https://issues.apache.org/jira/browse/GEODE-9576
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
>  Labels: pull-request-available
>
>  *InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation* occurs on native client when executing function in a 
> single hop manner for all buckets during the period when client bucket 
> metadata doesn't contain all buckets locations.
> Java client in this case executes functions in non single hop manner until it 
> receives locations of all buckets on servers. The solution in native client 
> would be to implement the same handling as in java client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9576) InternalFunctionInvocationTargetException when executing single hop function all buckets

2021-09-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413230#comment-17413230
 ] 

ASF GitHub Bot commented on GEODE-9576:
---

pdxcodemonkey commented on a change in pull request #864:
URL: https://github.com/apache/geode-native/pull/864#discussion_r706251752



##
File path: cppcache/integration/test/FunctionExecutionTest.cpp
##
@@ -175,6 +181,58 @@ TEST(FunctionExecutionTest,
   cache.close();
 }
 
+void populateRegion(const std::shared_ptr ®ion) {
+  for (int i = 0; i < 113; i++) {
+region->put("KEY--" + std::to_string(i), "VALUE--" + std::to_string(i));
+  }
+}
+
+TEST(FunctionExecutionTest, FunctionExecutionSingleHopNonHA) {
+  Cluster cluster{
+  LocatorCount{1}, ServerCount{3},
+  CacheXMLFiles(
+  {std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver1_pool_nonHA.xml",
+   std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver2_pool_nonHA.xml",
+   std::string(getFrameworkString(FrameworkVariable::TestCacheXmlDir)) 
+
+   "/func_cacheserver3_pool_nonHA.xml"})};
+
+  cluster.start([&]() {
+cluster.getGfsh()
+.deploy()
+.jar(getFrameworkString(FrameworkVariable::JavaObjectJarPath))
+.execute();
+  });
+
+  auto cache = CacheFactory().create();
+  auto poolFactory = cache.getPoolManager().createFactory();
+
+  cluster.applyLocators(poolFactory);
+
+  auto pool =
+  poolFactory.setPRSingleHopEnabled(true).setRetryAttempts(0).create(
+  "pool");
+
+  auto region = cache.createRegionFactory(RegionShortcut::PROXY)
+.setPoolName("pool")
+.create("partition_region");
+
+  populateRegion(region);
+
+  for (int i = 0; i < 30; i++) {
+auto functionService = FunctionService::onRegion(region);
+auto rc =
+functionService.withCollector(std::make_shared())

Review comment:
   Sorry, totally missed this was an integration test - dunno how that 
happened.  To confirm your conjecture above, yes my test sleeps because it has 
to have a metadata update, with partial info, to repro the failure, just as 
yours does.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InternalFunctionInvocationTargetException when executing single hop function 
> all buckets
> 
>
> Key: GEODE-9576
> URL: https://issues.apache.org/jira/browse/GEODE-9576
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
>  Labels: pull-request-available
>
>  *InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation* occurs on native client when executing function in a 
> single hop manner for all buckets during the period when client bucket 
> metadata doesn't contain all buckets locations.
> Java client in this case executes functions in non single hop manner until it 
> receives locations of all buckets on servers. The solution in native client 
> would be to implement the same handling as in java client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9576) InternalFunctionInvocationTargetException when executing single hop function all buckets

2021-09-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413291#comment-17413291
 ] 

ASF GitHub Bot commented on GEODE-9576:
---

mreddington commented on a change in pull request #864:
URL: https://github.com/apache/geode-native/pull/864#discussion_r706337802



##
File path: cppcache/test/mock/ClientMetadataMock.hpp
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#ifndef GEODE_CLIENTMETADATAMOCK_H_
+#define GEODE_CLIENTMETADATAMOCK_H_
+
+#include 
+
+#include "ClientMetadata.hpp"
+
+namespace apache {
+namespace geode {
+namespace client {
+class ClientMetadataMock : public ClientMetadata {

Review comment:
   I would rather you overload the ClientMetadata constructor to accept a 
bucket set than burden the system with yet more polymorphism so you can inject 
a bucket set.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InternalFunctionInvocationTargetException when executing single hop function 
> all buckets
> 
>
> Key: GEODE-9576
> URL: https://issues.apache.org/jira/browse/GEODE-9576
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
>  Labels: pull-request-available
>
>  *InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation* occurs on native client when executing function in a 
> single hop manner for all buckets during the period when client bucket 
> metadata doesn't contain all buckets locations.
> Java client in this case executes functions in non single hop manner until it 
> receives locations of all buckets on servers. The solution in native client 
> would be to implement the same handling as in java client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7710) CI Failure: JMXMBeanReconnectDUnitTest aka JmxServerReconnectDistributedTest fails intermittently because one locator is missing the LockServiceMXBean

2021-09-10 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413314#comment-17413314
 ] 

Geode Integration commented on GEODE-7710:
--

Seen on support/1.13 in [distributed-test-openjdk11 
#49|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-13-main/jobs/distributed-test-openjdk11/builds/49]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.5-build.0593/test-results/distributedTest/1631257914/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.5-build.0593/test-artifacts/1631257914/distributedtestfiles-openjdk11-1.13.5-build.0593.tgz].

> CI Failure: JMXMBeanReconnectDUnitTest aka JmxServerReconnectDistributedTest 
> fails intermittently because one locator is missing the LockServiceMXBean
> --
>
> Key: GEODE-7710
> URL: https://issues.apache.org/jira/browse/GEODE-7710
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 1.13.0
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: GeodeOperationAPI, flaky, pull-request-available
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> Multiple tests in JMXMBeanReconnectDUnitTest may fail an await due to one of 
> the locators missing the LockServiceMXBean for the cluster config service.
> {noformat}
> but could not find:
>  
> <[GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
> {noformat}
> These test failures are caused by *GEODE-7739*.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-6751) CI failure: AcceptanceTestOpenJDK8 ConnectCommandAcceptanceTest.useCurrentGfshToConnectToOlderLocator failure

2021-09-10 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413328#comment-17413328
 ] 

Geode Integration commented on GEODE-6751:
--

Seen in [upgrade-test-openjdk8 
#182|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/upgrade-test-openjdk8/builds/182]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0475/test-results/upgradeTest/1631242228/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0475/test-artifacts/1631242228/upgradetestfiles-openjdk8-1.15.0-build.0475.tgz].

> CI failure: AcceptanceTestOpenJDK8 
> ConnectCommandAcceptanceTest.useCurrentGfshToConnectToOlderLocator failure
> -
>
> Key: GEODE-6751
> URL: https://issues.apache.org/jira/browse/GEODE-6751
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Affects Versions: 1.15.0
>Reporter: Scott Jewell
>Priority: Major
>
> Assertion failure in 
> ConnectCommandAcceptanceTest.useCurrentGfshToConnectToOlderLocator
> Appears to be a new bug
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest
>  > useCurrentGfshToConnectToOlderLocator FAILED
> java.lang.AssertionError: 
> Expecting:
>  <"
> (1) Executing - connect
> Connecting to Locator at [host=localhost, port=10334] ..
> Exception caused JMX Manager startup to fail because: 'HTTP service 
> failed to start'
> ">
> to contain:
>  <"Cannot use a"> 
> at 
> org.apache.geode.management.internal.cli.commands.ConnectCommandAcceptanceTest.useCurrentGfshToConnectToOlderLocator(ConnectCommandAcceptanceTest.java:50)
> 60 tests completed, 1 failed
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.10.0-SNAPSHOT.0258/test-results/acceptanceTest/1557290414/*]
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.10.0-SNAPSHOT.0258/test-artifacts/1557290414/acceptancetestfiles-OpenJDK8-1.10.0-SNAPSHOT.0258.tgz*]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8644) SerialGatewaySenderQueueDUnitTest.unprocessedTokensMapShouldDrainCompletely() intermittently fails when queues drain too slowly

2021-09-10 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1741#comment-1741
 ] 

Geode Integration commented on GEODE-8644:
--

Seen in [distributed-test-openjdk11 
#180|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/distributed-test-openjdk11/builds/180]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0474/test-results/distributedTest/1631230821/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0474/test-artifacts/1631230821/distributedtestfiles-openjdk11-1.15.0-build.0474.tgz].

> SerialGatewaySenderQueueDUnitTest.unprocessedTokensMapShouldDrainCompletely() 
> intermittently fails when queues drain too slowly
> ---
>
> Key: GEODE-8644
> URL: https://issues.apache.org/jira/browse/GEODE-8644
> Project: Geode
>  Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Benjamin P Ross
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: pull-request-available
>
> Currently the test 
> SerialGatewaySenderQueueDUnitTest.unprocessedTokensMapShouldDrainCompletely() 
> relies on a 2 second delay to allow for queues to finish draining after 
> finishing the put operation. If queues take longer than 2 seconds to drain 
> the test will fail. We should change the test to wait for the queues to be 
> empty with a long timeout in case the queues never fully drain.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9554) Rebalancing a region with multiple redundancy zones can fail

2021-09-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413353#comment-17413353
 ] 

ASF subversion and git services commented on GEODE-9554:


Commit 0dfcb06f2864aa7c93a6ac3c4cacff52de0864b7 in geode's branch 
refs/heads/support/1.12 from mhansonp
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0dfcb06 ]

GEODE-9554 backport to 1.12 (#6857)

* GEODE-9554 backport (#6856)

* GEODE-9554: Change up the rebalance calls to use new canDelete call (#6845) 
(#6853)

GEODE-9554: Change up the rebalance calls to use new canDelete call

If there is no redundancy zone, exit and allow delete
Adding xml files to git
Adding xml files to git
Added new tests

(cherry picked from commit d1d605b24787698c5d8f47b8538808d6b990c0a4)
(cherry picked from commit 142e06fe001aae428c32ec602992e45bcefa2259)

* GEODE-5994: Cleanup from some additional review comments (#6852)

(cherry picked from commit 7b924b5ccef4646f28615bab290447824f9f9f45)
(cherry picked from commit 69ca9cdf75904f70d6272286f4322ba90ee8bfa3)
(cherry picked from commit d94aa6431c4f19167feea417be4739c6746ab4e3)

* GEODE-9554: modifications for 1.12 support

> Rebalancing a region with multiple redundancy zones can fail
> 
>
> Key: GEODE-9554
> URL: https://issues.apache.org/jira/browse/GEODE-9554
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.4, 1.13.4, 1.14.0, 1.15.0
>Reporter: Mark Hanson
>Assignee: Mark Hanson
>Priority: Major
>  Labels: pull-request-available
>
> When attempting to rebalance a region with multiple redundancy zones, the 
> code does not distinguish between zones when deleting redundant bucket 
> copies. This can mean that a bucket from a different zone gets deleted 
> leaving the servers in a state of reduced redundancy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-5994) Add a service to contend for CPUs for testing purposes

2021-09-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413354#comment-17413354
 ] 

ASF subversion and git services commented on GEODE-5994:


Commit 0dfcb06f2864aa7c93a6ac3c4cacff52de0864b7 in geode's branch 
refs/heads/support/1.12 from mhansonp
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0dfcb06 ]

GEODE-9554 backport to 1.12 (#6857)

* GEODE-9554 backport (#6856)

* GEODE-9554: Change up the rebalance calls to use new canDelete call (#6845) 
(#6853)

GEODE-9554: Change up the rebalance calls to use new canDelete call

If there is no redundancy zone, exit and allow delete
Adding xml files to git
Adding xml files to git
Added new tests

(cherry picked from commit d1d605b24787698c5d8f47b8538808d6b990c0a4)
(cherry picked from commit 142e06fe001aae428c32ec602992e45bcefa2259)

* GEODE-5994: Cleanup from some additional review comments (#6852)

(cherry picked from commit 7b924b5ccef4646f28615bab290447824f9f9f45)
(cherry picked from commit 69ca9cdf75904f70d6272286f4322ba90ee8bfa3)
(cherry picked from commit d94aa6431c4f19167feea417be4739c6746ab4e3)

* GEODE-9554: modifications for 1.12 support

> Add a service to contend for CPUs for testing purposes
> --
>
> Key: GEODE-5994
> URL: https://issues.apache.org/jira/browse/GEODE-5994
> Project: Geode
>  Issue Type: Improvement
>Reporter: Dale Emery
>Assignee: Dale Emery
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Some test failures are easier to reproduce and diagnose when there is heavy 
> contention for CPUs.
> Add a simple utility to contend for CPUs. This can be added to a test while 
> debugging, and removed after the problem has been diagnosed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-9554) Rebalancing a region with multiple redundancy zones can fail

2021-09-10 Thread Mark Hanson (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Hanson resolved GEODE-9554.

Fix Version/s: 1.15.0
   1.14.1
   1.13.5
   1.12.5
   Resolution: Fixed

This fix to this issue was to ensure that we were not deleting the last copy of 
a bucket in a redundancy zone. 

> Rebalancing a region with multiple redundancy zones can fail
> 
>
> Key: GEODE-9554
> URL: https://issues.apache.org/jira/browse/GEODE-9554
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.12.4, 1.13.4, 1.14.0, 1.15.0
>Reporter: Mark Hanson
>Assignee: Mark Hanson
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.5, 1.13.5, 1.14.1, 1.15.0
>
>
> When attempting to rebalance a region with multiple redundancy zones, the 
> code does not distinguish between zones when deleting redundant bucket 
> copies. This can mean that a bucket from a different zone gets deleted 
> leaving the servers in a state of reduced redundancy.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-9594) Implement integer types for put/get in .net core

2021-09-10 Thread Blake Bender (Jira)
Blake Bender created GEODE-9594:
---

 Summary: Implement integer types for put/get in .net core
 Key: GEODE-9594
 URL: https://issues.apache.org/jira/browse/GEODE-9594
 Project: Geode
  Issue Type: New Feature
  Components: native client
Reporter: Blake Bender


There are several numeric types under the "cacheable built-ins" umbrella in the 
CLI code - Int16, Int32, Int64, double, and float, perhaps others.  We can add 
put/get support for these types to the Region object, giving us a lot more 
flexibility and a blueprint for adding the remaining Geode-supported types.

Feel free to implement these one at a time, if it makes for more reasonable 
PRs.  Like add a CacheableInt32 class, implement 
toData/fromData/Equals/HashCode/whatever else is required to match features in 
the current .net API, then implement put/get for this type.  Be sure to include 
appropriate unit & integration tests.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9340) Benchmark instability in PartitionedPutLongBenchmark

2021-09-10 Thread Geode Integration (Jira)

[ 
https://issues.apache.org/jira/browse/GEODE-9340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413384#comment-17413384
 ] 

Geode Integration commented on GEODE-9340:
--

Seen on support/1.14 in [benchmark-with-security-manager 
#41|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-support-1-14-main/jobs/benchmark-with-security-manager/builds/41].

> Benchmark instability in PartitionedPutLongBenchmark
> 
>
> Key: GEODE-9340
> URL: https://issues.apache.org/jira/browse/GEODE-9340
> Project: Geode
>  Issue Type: Bug
>  Components: benchmarks
>Affects Versions: 1.15.0
>Reporter: Sarah Abbey
>Assignee: Hale Bales
>Priority: Major
>  Labels: pull-request-available
>
> PartitionedPutLongBenchmark failed in CI 
> (https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/benchmark-base/builds/6):
> {code:java}
> This is ITERATION 1 of benchmarking against baseline.
>   P2pPartitionedGetBenchmark avg ops/sec  
> Baseline:825011.38  Test:835847.67  Difference:   +1.3%
>  avg latency  
> Baseline:871392.31  Test:859444.66  Difference:   -1.4%
>   P2pPartitionedPutBenchmark avg ops/sec  
> Baseline:123838.43  Test:122686.30  Difference:   -0.9%
>  avg latency  
> Baseline:   6015719.73  Test:   6119472.19  Difference:   +1.7%
>  P2pPartitionedPutBytesBenchmark avg ops/sec  
> Baseline:174887.77  Test:171040.93  Difference:   -2.2%
>  avg latency  
> Baseline:   4145337.60  Test:   4236159.60  Difference:   +2.2%
>    PartitionedFunctionExecutionBenchmark avg ops/sec  
> Baseline:248635.36  Test:261498.94  Difference:   +5.2%
>  avg latency  
> Baseline:867122.63  Test:824550.34  Difference:   -4.9%
>   PartitionedFunctionExecutionWithArgumentsBenchmark avg ops/sec  
> Baseline:280071.19  Test:275305.31  Difference:   -1.7%
>  avg latency  
> Baseline:   1026643.12  Test:   1044307.43  Difference:   +1.7%
> PartitionedFunctionExecutionWithFiltersBenchmark avg ops/sec  
> Baseline:301416.23  Test:304317.30  Difference:   +1.0%
>  avg latency  
> Baseline:   1908390.88  Test:   1890040.46  Difference:   -1.0%
>  PartitionedGetBenchmark avg ops/sec  
> Baseline:790800.52  Test:784514.74  Difference:   -0.8%
>  avg latency  
> Baseline:908357.58  Test:915790.96  Difference:   +0.8%
>  PartitionedGetLongBenchmark avg ops/sec  
> Baseline:   1020821.32  Test:996529.93  Difference:   -2.4%
>  avg latency  
> Baseline:703761.09  Test:720744.36  Difference:   +2.4%
>    PartitionedGetStringBenchmark avg ops/sec  
> Baseline:   1028992.93  Test:   1010447.47  Difference:   -1.8%
>  avg latency  
> Baseline:698009.55  Test:710765.29  Difference:   +1.8%
> PartitionedIndexedQueryBenchmark avg ops/sec  
> Baseline: 30868.78  Test: 31478.90  Difference:   +2.0%
>  avg latency  
> Baseline:  18670093.21  Test:  18278083.16  Difference:   -2.1%
>  PartitionedNonIndexedQueryBenchmark avg ops/sec  
> Baseline:99.45  Test:   101.97  Difference:   +2.5%
>  avg latency  
> Baseline: 723415530.75  Test: 705653061.86  Difference:   -2.5%
>   PartitionedPutAllBenchmark avg ops/sec  
> Baseline:  7921.61  Test:  7816.66  Difference:   -1.3%
>  avg latency  
> Baseline:  18172638.37  Test:  18416169.28  Difference:   +1.3%
>   PartitionedPutAllLongBenchmark avg ops/sec  
> Baseline:  1379.53  Test:  1169.16  Difference:  -15.2%
>  avg latency  
> Baseline: 105140260.44  Test: 123722914.94  Difference:  +17.7%
>  PartitionedPutBenchmark avg ops/sec  
> Baseline:474986.11  Test:

[jira] [Commented] (GEODE-9302) Benchmark instability in PartitionedPutStringBenchmark

2021-09-10 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413386#comment-17413386
 ] 

Geode Integration commented on GEODE-9302:
--

Seen in [benchmark-base 
#175|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/benchmark-base/builds/175].

> Benchmark instability in PartitionedPutStringBenchmark
> --
>
> Key: GEODE-9302
> URL: https://issues.apache.org/jira/browse/GEODE-9302
> Project: Geode
>  Issue Type: Bug
>  Components: benchmarks
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Priority: Major
>
> A benchmark failure due to the recently-introduced 
> PartitionedPutStringBenchmark was observed:
> {noformat}
> This is ITERATION 1 of benchmarking against baseline.
>   P2pPartitionedGetBenchmark avg ops/sec  
> Baseline:853001.60  Test:867151.67  Difference:   +1.7%
>  avg latency  
> Baseline:842007.55  Test:828545.06  Difference:   -1.6%
>   P2pPartitionedPutBenchmark avg ops/sec  
> Baseline:128283.47  Test:126510.92  Difference:   -1.4%
>  avg latency  
> Baseline:   5785619.62  Test:   5915913.49  Difference:   +2.3%
>  P2pPartitionedPutBytesBenchmark avg ops/sec  
> Baseline:175658.08  Test:174865.97  Difference:   -0.5%
>  avg latency  
> Baseline:   4130071.43  Test:   4130753.09  Difference:   +0.0%
>PartitionedFunctionExecutionBenchmark avg ops/sec  
> Baseline:254788.26  Test:268132.99  Difference:   +5.2%
>  avg latency  
> Baseline:846158.41  Test:804199.42  Difference:   -5.0%
>   PartitionedFunctionExecutionWithArgumentsBenchmark avg ops/sec  
> Baseline:278669.87  Test:281504.58  Difference:   +1.0%
>  avg latency  
> Baseline:   1031826.82  Test:   1021314.54  Difference:   -1.0%
> PartitionedFunctionExecutionWithFiltersBenchmark avg ops/sec  
> Baseline:372204.82  Test:348815.81  Difference:   -6.3%
>  avg latency  
> Baseline:   1545217.38  Test:   1649706.37  Difference:   +6.8%
>  PartitionedGetBenchmark avg ops/sec  
> Baseline:823740.09  Test:819044.99  Difference:   -0.6%
>  avg latency  
> Baseline:872172.75  Test:877580.02  Difference:   +0.6%
>  PartitionedGetLongBenchmark avg ops/sec  
> Baseline:   1047221.43  Test:   1045565.89  Difference:   -0.2%
>  avg latency  
> Baseline:685757.55  Test:687005.43  Difference:   +0.2%
>PartitionedGetStringBenchmark avg ops/sec  
> Baseline:   1055904.14  Test:   1045420.73  Difference:   -1.0%
>  avg latency  
> Baseline:680031.44  Test:687045.15  Difference:   +1.0%
> PartitionedIndexedQueryBenchmark avg ops/sec  
> Baseline: 31596.35  Test: 31653.48  Difference:   +0.2%
>  avg latency  
> Baseline:  18221302.10  Test:  18216097.86  Difference:   -0.0%
>  PartitionedNonIndexedQueryBenchmark avg ops/sec  
> Baseline:95.78  Test:   100.35  Difference:   +4.8%
>  avg latency  
> Baseline: 750871203.78  Test: 716853923.95  Difference:   -4.5%
>   PartitionedPutAllBenchmark avg ops/sec  
> Baseline:  8675.75  Test:  8628.10  Difference:   -0.5%
>  avg latency  
> Baseline:  16595044.73  Test:  16685258.91  Difference:   +0.5%
>   PartitionedPutAllLongBenchmark avg ops/sec  
> Baseline:  1382.38  Test:  1380.50  Difference:   -0.1%
>  avg latency  
> Baseline: 104866853.92  Test: 104775538.34  Difference:   -0.1%
>  PartitionedPutBenchmark avg ops/sec  
> Baseline:491790.40  Test:479926.75  Difference:   -2.4%
>  avg latency  
> Baseline:   1461947.23  Test:   1497519.77  Difference:   +2.4%
>   

[jira] [Commented] (GEODE-9302) Benchmark instability in PartitionedPutStringBenchmark

2021-09-10 Thread Geode Integration (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413385#comment-17413385
 ] 

Geode Integration commented on GEODE-9302:
--

Seen in [benchmark-base 
#177|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/benchmark-base/builds/177].

> Benchmark instability in PartitionedPutStringBenchmark
> --
>
> Key: GEODE-9302
> URL: https://issues.apache.org/jira/browse/GEODE-9302
> Project: Geode
>  Issue Type: Bug
>  Components: benchmarks
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Priority: Major
>
> A benchmark failure due to the recently-introduced 
> PartitionedPutStringBenchmark was observed:
> {noformat}
> This is ITERATION 1 of benchmarking against baseline.
>   P2pPartitionedGetBenchmark avg ops/sec  
> Baseline:853001.60  Test:867151.67  Difference:   +1.7%
>  avg latency  
> Baseline:842007.55  Test:828545.06  Difference:   -1.6%
>   P2pPartitionedPutBenchmark avg ops/sec  
> Baseline:128283.47  Test:126510.92  Difference:   -1.4%
>  avg latency  
> Baseline:   5785619.62  Test:   5915913.49  Difference:   +2.3%
>  P2pPartitionedPutBytesBenchmark avg ops/sec  
> Baseline:175658.08  Test:174865.97  Difference:   -0.5%
>  avg latency  
> Baseline:   4130071.43  Test:   4130753.09  Difference:   +0.0%
>PartitionedFunctionExecutionBenchmark avg ops/sec  
> Baseline:254788.26  Test:268132.99  Difference:   +5.2%
>  avg latency  
> Baseline:846158.41  Test:804199.42  Difference:   -5.0%
>   PartitionedFunctionExecutionWithArgumentsBenchmark avg ops/sec  
> Baseline:278669.87  Test:281504.58  Difference:   +1.0%
>  avg latency  
> Baseline:   1031826.82  Test:   1021314.54  Difference:   -1.0%
> PartitionedFunctionExecutionWithFiltersBenchmark avg ops/sec  
> Baseline:372204.82  Test:348815.81  Difference:   -6.3%
>  avg latency  
> Baseline:   1545217.38  Test:   1649706.37  Difference:   +6.8%
>  PartitionedGetBenchmark avg ops/sec  
> Baseline:823740.09  Test:819044.99  Difference:   -0.6%
>  avg latency  
> Baseline:872172.75  Test:877580.02  Difference:   +0.6%
>  PartitionedGetLongBenchmark avg ops/sec  
> Baseline:   1047221.43  Test:   1045565.89  Difference:   -0.2%
>  avg latency  
> Baseline:685757.55  Test:687005.43  Difference:   +0.2%
>PartitionedGetStringBenchmark avg ops/sec  
> Baseline:   1055904.14  Test:   1045420.73  Difference:   -1.0%
>  avg latency  
> Baseline:680031.44  Test:687045.15  Difference:   +1.0%
> PartitionedIndexedQueryBenchmark avg ops/sec  
> Baseline: 31596.35  Test: 31653.48  Difference:   +0.2%
>  avg latency  
> Baseline:  18221302.10  Test:  18216097.86  Difference:   -0.0%
>  PartitionedNonIndexedQueryBenchmark avg ops/sec  
> Baseline:95.78  Test:   100.35  Difference:   +4.8%
>  avg latency  
> Baseline: 750871203.78  Test: 716853923.95  Difference:   -4.5%
>   PartitionedPutAllBenchmark avg ops/sec  
> Baseline:  8675.75  Test:  8628.10  Difference:   -0.5%
>  avg latency  
> Baseline:  16595044.73  Test:  16685258.91  Difference:   +0.5%
>   PartitionedPutAllLongBenchmark avg ops/sec  
> Baseline:  1382.38  Test:  1380.50  Difference:   -0.1%
>  avg latency  
> Baseline: 104866853.92  Test: 104775538.34  Difference:   -0.1%
>  PartitionedPutBenchmark avg ops/sec  
> Baseline:491790.40  Test:479926.75  Difference:   -2.4%
>  avg latency  
> Baseline:   1461947.23  Test:   1497519.77  Difference:   +2.4%
>   

[jira] [Assigned] (GEODE-9521) Add test to cover multi-servers scenario for re-authentication

2021-09-10 Thread Jinmei Liao (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao reassigned GEODE-9521:
--

Assignee: Jinmei Liao

> Add test to cover multi-servers scenario for re-authentication
> --
>
> Key: GEODE-9521
> URL: https://issues.apache.org/jira/browse/GEODE-9521
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available, security
> Fix For: 1.15.0
>
>
> The test should should spin up multiple servers and test:
>  # client connect to one server directly
>  # client connect to the locator and have locator allocate server connection 
> of the client
> the test should check:
>  # expiring users on all the servers would prevent client connect to the all 
> the server.
>  # on the same client, after it's connected and the user is expired, make 
> sure no further operation will be allowed by this user (expired) even if the 
> client's connection is re-directed to the other server.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-9556) GETSET command supported

2021-09-10 Thread Eric Zoerner (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Zoerner resolved GEODE-9556.
-
Fix Version/s: 1.15.0
   Resolution: Fixed

> GETSET command supported
> 
>
> Key: GEODE-9556
> URL: https://issues.apache.org/jira/browse/GEODE-9556
> Project: Geode
>  Issue Type: New Feature
>  Components: redis
>Affects Versions: 1.15.0
>Reporter: Eric Zoerner
>Assignee: Eric Zoerner
>Priority: Major
>  Labels: redis
> Fix For: 1.15.0
>
>
> Write unit/integration tests that run against both Geode Redis and native 
> Redis, and dunit tests which test multiple concurrent clients accessing 
> different servers for the following command:
>  * GETSET
> *A.C.*
>  * Unit/integration tests for both Geode and native Redis passing
>  * DUNIT tests passing
>  * README/redis_api_for_geode.html.md.erb updated to make command "supported"
> _or_
>  * Stories in the backlog to fix the identified issues (with JIRA tickets) 
> and problem tests ignored



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-9577) **PSETEX** and **SETEX** Commands Supported

2021-09-10 Thread Eric Zoerner (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Zoerner resolved GEODE-9577.
-
Fix Version/s: 1.15.0
   Resolution: Fixed

> **PSETEX** and **SETEX** Commands Supported
> ---
>
> Key: GEODE-9577
> URL: https://issues.apache.org/jira/browse/GEODE-9577
> Project: Geode
>  Issue Type: New Feature
>  Components: redis
>Affects Versions: 1.15.0
>Reporter: Eric Zoerner
>Assignee: Eric Zoerner
>Priority: Major
>  Labels: pull-request-available, redis
> Fix For: 1.15.0
>
>
> Write unit/integration tests that run against both Geode Redis and native 
> Redis, and dunit tests which test multiple concurrent clients accessing 
> different servers for the following commands:
> PSETEX and SETEX
> A.C.
> Unit/integration tests for both Geode and native Redis passing
> DUNIT tests passing
> README/redis_api_for_geode.html.md.erb updated to make command "supported"
> or
> Stories in the backlog to fix the identified issues (with JIRA tickets) and 
> problem tests that are ignored should be fixed and enabled



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-9585) Add support for the KEYSLOT command

2021-09-10 Thread Eric Zoerner (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Zoerner reassigned GEODE-9585:
---

Assignee: Eric Zoerner

> Add support for the KEYSLOT command
> ---
>
> Key: GEODE-9585
> URL: https://issues.apache.org/jira/browse/GEODE-9585
> Project: Geode
>  Issue Type: Improvement
>  Components: redis
>Reporter: Dan Smith
>Assignee: Eric Zoerner
>Priority: Major
>  Labels: pull-request-available
>
> Spring data redis's JedisClusterKeyCommands class unfortunately is calling 
> the CLUSTER KEYSLOT command on the server to find the slot for a key when 
> performing rename or restore operations. Rename is used by spring session 
> data redis.
> I'll file a PR against jedis, but in the meantime we should add support for 
> the KEYSLOT command to handle this and other weird client behaviors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9576) InternalFunctionInvocationTargetException when executing single hop function all buckets

2021-09-10 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413429#comment-17413429
 ] 

ASF GitHub Bot commented on GEODE-9576:
---

pivotal-jbarrett commented on a change in pull request #864:
URL: https://github.com/apache/geode-native/pull/864#discussion_r706508046



##
File path: cppcache/test/mock/ClientMetadataMock.hpp
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#ifndef GEODE_CLIENTMETADATAMOCK_H_
+#define GEODE_CLIENTMETADATAMOCK_H_
+
+#include 
+
+#include "ClientMetadata.hpp"
+
+namespace apache {
+namespace geode {
+namespace client {
+class ClientMetadataMock : public ClientMetadata {

Review comment:
   I am not sure I understand @mreddington, this is mock and this is how 
you mock classes using gmock.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InternalFunctionInvocationTargetException when executing single hop function 
> all buckets
> 
>
> Key: GEODE-9576
> URL: https://issues.apache.org/jira/browse/GEODE-9576
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
>  Labels: pull-request-available
>
>  *InternalFunctionInvocationTargetException: Multiple target nodes found for 
> single hop operation* occurs on native client when executing function in a 
> single hop manner for all buckets during the period when client bucket 
> metadata doesn't contain all buckets locations.
> Java client in this case executes functions in non single hop manner until it 
> receives locations of all buckets on servers. The solution in native client 
> would be to implement the same handling as in java client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8626) Omitting field-mapping tag of cache.xml when using Simple JDBC Connector

2021-09-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413443#comment-17413443
 ] 

ASF subversion and git services commented on GEODE-8626:


Commit 723429f291f48f309acc3407f1405339ddbcfc20 in geode's branch 
refs/heads/develop from Masaki Yamakawa
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=723429f ]

GEODE-8626: Omitting field-mapping tag of cache.xml when using Simple JDBC 
Connector (#5637)

* Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
* Use the default mapping when using the Simple JDBC Connector in cache.xml and 
without the field-mapping tag
* Move some methods of CreateMappingPreconditionCheckFunction class to 
JdbcConnectorServiceImpl class

> Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
> 
>
> Key: GEODE-8626
> URL: https://issues.apache.org/jira/browse/GEODE-8626
> Project: Geode
>  Issue Type: Improvement
>  Components: jdbc
>Reporter: Masaki Yamakawa
>Priority: Minor
>  Labels: pull-request-available
>
> When configuring Simple JDBC Connector with gfsh, I don't need to create 
> field-mapping, the default field-mapping will be created from pdx and table 
> meta data.
> On the other hand, when using cache.xml(cluster.xml), pdx and table meta data 
> cannot be used, and field-mapping must be described in cache.xml.
> I would like to create field-mapping defaults based on pdx and table meta 
> data when using cache.xml.
> If field-mapping is specified in cache.xml, the xml setting has priority, and 
> only if there are no field-mapping tags.
> cache.xml will be as follows:
> {code:java}
> 
>  data-source="TestDataSource"
> table="employees"
> pdx-name="org.apache.geode.connectors.jdbc.Employee"
> ids="id">
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)