[jira] [Assigned] (GEODE-8092) redis dbSize on empty redis server returns 2
[ https://issues.apache.org/jira/browse/GEODE-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nabarun Nag reassigned GEODE-8092: -- Assignee: Nabarun Nag > redis dbSize on empty redis server returns 2 > > > Key: GEODE-8092 > URL: https://issues.apache.org/jira/browse/GEODE-8092 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Assignee: Nabarun Nag >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > On an empty redis server dbSize should return 0. > But currently it is always 2 more than it should be. > The bug is caused by us loading 5 region names into the keyRegistrar but > NUM_DEFAULT_KEYS in RedisConstants is 3 (should be 5) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8092) redis dbSize on empty redis server returns 2
[ https://issues.apache.org/jira/browse/GEODE-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nabarun Nag reassigned GEODE-8092: -- Assignee: (was: Nabarun Nag) > redis dbSize on empty redis server returns 2 > > > Key: GEODE-8092 > URL: https://issues.apache.org/jira/browse/GEODE-8092 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > On an empty redis server dbSize should return 0. > But currently it is always 2 more than it should be. > The bug is caused by us loading 5 region names into the keyRegistrar but > NUM_DEFAULT_KEYS in RedisConstants is 3 (should be 5) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8334) Primary and secondary bucket data mismatch with concurrent putAll/removeAll and PR.clear
[ https://issues.apache.org/jira/browse/GEODE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nabarun Nag updated GEODE-8334: --- Fix Version/s: 1.14.0 > Primary and secondary bucket data mismatch with concurrent putAll/removeAll > and PR.clear > - > > Key: GEODE-8334 > URL: https://issues.apache.org/jira/browse/GEODE-8334 > Project: Geode > Issue Type: Sub-task > Components: regions >Affects Versions: 1.14.0 >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > Fix For: 1.14.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-7489) DistributionArchUnitTest is running out of memory for some users
[
https://issues.apache.org/jira/browse/GEODE-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nabarun Nag reassigned GEODE-7489:
--
Assignee: (was: Nabarun Nag)
> DistributionArchUnitTest is running out of memory for some users
>
>
> Key: GEODE-7489
> URL: https://issues.apache.org/jira/browse/GEODE-7489
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Dan Smith
>Priority: Major
> Labels: no-release-note, pull-request-available
> Fix For: 1.14.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This test ran out of memory when running ./gradlew build for some users. From
> the mailing list:
> {noformat}
> Any ideas why DistributionArchUnitTest would run OutOfMemoryError when
> doing a "./gradlew build"?
> I think we should move any unit tests that run OutOfMemoryError out of unit
> tests (to integration tests maybe?).
> > Task :geode:geode-core:test
> Heap dump file created [957877145 bytes in 17.227 secs]
> org.apache.geode.distributed.internal.DistributionArchUnitTest >
> classMethod FAILED
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> 6991 tests completed, 1 failed, 12 skipped
> {noformat}
> This is a relatively new test that is scanning a lot of classes for
> dependencies, so it may have memory issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-7489) DistributionArchUnitTest is running out of memory for some users
[
https://issues.apache.org/jira/browse/GEODE-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nabarun Nag reassigned GEODE-7489:
--
Assignee: Nabarun Nag
> DistributionArchUnitTest is running out of memory for some users
>
>
> Key: GEODE-7489
> URL: https://issues.apache.org/jira/browse/GEODE-7489
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Dan Smith
>Assignee: Nabarun Nag
>Priority: Major
> Labels: no-release-note, pull-request-available
> Fix For: 1.14.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This test ran out of memory when running ./gradlew build for some users. From
> the mailing list:
> {noformat}
> Any ideas why DistributionArchUnitTest would run OutOfMemoryError when
> doing a "./gradlew build"?
> I think we should move any unit tests that run OutOfMemoryError out of unit
> tests (to integration tests maybe?).
> > Task :geode:geode-core:test
> Heap dump file created [957877145 bytes in 17.227 secs]
> org.apache.geode.distributed.internal.DistributionArchUnitTest >
> classMethod FAILED
> java.lang.OutOfMemoryError: GC overhead limit exceeded
> 6991 tests completed, 1 failed, 12 skipped
> {noformat}
> This is a relatively new test that is scanning a lot of classes for
> dependencies, so it may have memory issues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-7016) CI failure: ServerStartupRedundancyRecoveryNotificationTest > startupReportsOnlineOnlyAfterRedundancyRestored FAILED
[
https://issues.apache.org/jira/browse/GEODE-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nabarun Nag updated GEODE-7016:
---
Fix Version/s: (was: 1.14.0)
> CI failure: ServerStartupRedundancyRecoveryNotificationTest >
> startupReportsOnlineOnlyAfterRedundancyRestored FAILED
>
>
> Key: GEODE-7016
> URL: https://issues.apache.org/jira/browse/GEODE-7016
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Affects Versions: 1.10.0
>Reporter: Anilkumar Gingade
>Assignee: Kirk Lund
>Priority: Major
> Labels: pull-request-available
> Attachments: acceptancetestfiles-OpenJDK11-1.14.0-build.0628 (1).tgz,
> acceptancetestfiles-OpenJDK11-1.14.0-build.0628 (2).tgz
>
>
> {noformat}
> org.apache.geode.launchers.ServerStartupRedundancyRecoveryNotificationTest >
> startupReportsOnlineOnlyAfterRedundancyRestored FAILED
> org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshExecution.awaitTermination(GfshExecution.java:125)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:125)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:112)
> at
> org.apache.geode.launchers.ServerStartupRedundancyRecoveryNotificationTest.startupReportsOnlineOnlyAfterRedundancyRestored(ServerStartupRedundancyRecoveryNotificationTest.java:142)
> org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshExecution.awaitTermination(GfshExecution.java:125)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:125)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:112)
> at
> org.apache.geode.launchers.ServerStartupRedundancyRecoveryNotificationTest.stopAllMembers(ServerStartupRedundancyRecoveryNotificationTest.java:128)
> {noformat}
> https://concourse.gemfire-ci.info/teams/main/pipelines/gemfire-develop-main/jobs/AcceptanceTestOpenJDK8/builds/797
> Test report artifacts from this job are available at:
> gs://gemfire-test-artifacts/builds/gemfire-develop-main/9.9.0-build.0258/test-artifacts/1564078711/acceptancetestfiles-OpenJDK8-9.9.0-build.0258.tgz
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9252) CI failure: NativeRedisClusterTestRule incorrect primary node count (expected 3 but was 2)
[
https://issues.apache.org/jira/browse/GEODE-9252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407324#comment-17407324
]
ASF subversion and git services commented on GEODE-9252:
Commit 38b22dc36a24774187faef90a3ee7dce27e6e51d in geode's branch
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=38b22dc ]
GEODE-9252: Wait longer for Redis cluster to be formed (#6817)
> CI failure: NativeRedisClusterTestRule incorrect primary node count (expected
> 3 but was 2)
> --
>
> Key: GEODE-9252
> URL: https://issues.apache.org/jira/browse/GEODE-9252
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Owen Nichols
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> {noformat}
> org.apache.geode.redis.internal.executor.hash.HashesNativeRedisAcceptanceTest
> > classMethod FAILED
> org.junit.ComparisonFailure: [Incorrect primary node count]
> expected:<[3]> but was:<[2]>
> at
> org.apache.geode.redis.NativeRedisClusterTestRule$1.evaluate(NativeRedisClusterTestRule.java:93)
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9541) CI Failure: SubCommandsIntegrationTest has multiple tests failing intermittently
[
https://issues.apache.org/jira/browse/GEODE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-9541:
--
Labels: pull-request-available (was: )
> CI Failure: SubCommandsIntegrationTest has multiple tests failing
> intermittently
>
>
> Key: GEODE-9541
> URL: https://issues.apache.org/jira/browse/GEODE-9541
> Project: Geode
> Issue Type: Test
> Components: redis, tests
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> This class has become flaky since changes to the netty/radish thread model.
> Failures look like:
> {noformat}
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldNotIncludeChannelSubscriptions_forSameClient FAILED
> org.junit.ComparisonFailure: expected:<[1]L> but was:<[2]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numpat_shouldNotIncludeChannelSubscriptions_forSameClient(AbstractSubCommandsIntegrationTest.java:334)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldNotIncludeChannelSubscriptions_forDifferentClient FAILED
> org.junit.ComparisonFailure: expected:<[1]L> but was:<[2]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numpat_shouldNotIncludeChannelSubscriptions_forDifferentClient(AbstractSubCommandsIntegrationTest.java:320)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> channels_shouldReturnListOfAllChannels_withActiveChannelSubscribers_whenCalledWithoutPattern
> FAILED
> java.lang.AssertionError:
> Expecting actual:
> [[102, 42], [102, 111, 111], [98, 97, 114]]
> to contain exactly in any order:
> [[102, 111, 111], [98, 97, 114]]
> but the following elements were unexpected:
> [[102, 42]]
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.channels_shouldReturnListOfAllChannels_withActiveChannelSubscribers_whenCalledWithoutPattern(AbstractSubCommandsIntegrationTest.java:126)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numsub_shouldReturnZero_whenCalledWithPatternWithNoChannelSubscribers FAILED
> org.junit.ComparisonFailure: expected:<"[0]"> but was:<"[1]">
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numsub_shouldReturnZero_whenCalledWithPatternWithNoChannelSubscribers(AbstractSubCommandsIntegrationTest.java:259)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldReturnCountOfAllPatternSubscriptions_includingDuplicates FAILED
> org.junit.ComparisonFailure: expected:<[2]L> but was:<[3]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numpat_shouldReturnCountOfAllPatternSubscriptions_includingDuplicates(AbstractSubCommandsIntegrationTest.java:302)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> channels_shouldOnlyReturnChannelsWithActiveSubscribers FAILED
> jav
[jira] [Commented] (GEODE-9559) Demacroize clicache
[ https://issues.apache.org/jira/browse/GEODE-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407404#comment-17407404 ] ASF GitHub Bot commented on GEODE-9559: --- mmartell commented on pull request #862: URL: https://github.com/apache/geode-native/pull/862#issuecomment-908649949 The procedure for this PR consisted of cutting/pasting the original macro invocations with the corresponding preprocessor output. Although there are quite a few files involved, the changes are basically all the same. For this reason it seemed prudent to submit this as a single PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Demacroize clicache > > > Key: GEODE-9559 > URL: https://issues.apache.org/jira/browse/GEODE-9559 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > Macros in C++ complicate debug efforts and code maintenance and are generally > considered old school ([https://stroustrup.com/icsm-2012-demacro.pdf).] This > PR is to remove all the complicated macros in the .NET Framework client, e.g. > the clicache module. > In addition to improving the maintainability of the clicache module, removing > the macros will greatly assist the creation of the .NET Core client. [dotPeek > |http://jetbrains.com/decompiler/] is proving to be a valuable tool in the > .NET Core project, but is currently limited by the extensive use of macros in > the clicache code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-9560) ECHO Command Supported
[ https://issues.apache.org/jira/browse/GEODE-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans resolved GEODE-9560. Fix Version/s: 1.15.0 Resolution: Fixed > ECHO Command Supported > -- > > Key: GEODE-9560 > URL: https://issues.apache.org/jira/browse/GEODE-9560 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Write unit/integration tests that run against both Geode Redis and native > Redis, and dunit tests which test multiple concurrent clients accessing > different servers for the following command: > ECHO > +Acceptance Criteria+ > Unit/integration tests for both Geode and native Redis passing > DUNIT tests passing > README/redis_api_for_geode.html.md.erb updated to make command "supported" > or > Stories in the backlog to fix the identified issues (with JIRA tickets) and > problem tests that are ignored should be fixed and enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9560) ECHO Command Supported
[ https://issues.apache.org/jira/browse/GEODE-9560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407493#comment-17407493 ] ASF subversion and git services commented on GEODE-9560: Commit 4cbb02aed22822b8292e0c2bdd6d124ff4f0faa1 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4cbb02a ] GEODE-9560: Implement Radish ECHO command (#6815) - Move ECHO command to supported commands - Refactor tests to use cluster mode - Minor refactor for cleaner code Authored-by: Donal Evans > ECHO Command Supported > -- > > Key: GEODE-9560 > URL: https://issues.apache.org/jira/browse/GEODE-9560 > Project: Geode > Issue Type: New Feature > Components: redis >Reporter: Wayne >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Write unit/integration tests that run against both Geode Redis and native > Redis, and dunit tests which test multiple concurrent clients accessing > different servers for the following command: > ECHO > +Acceptance Criteria+ > Unit/integration tests for both Geode and native Redis passing > DUNIT tests passing > README/redis_api_for_geode.html.md.erb updated to make command "supported" > or > Stories in the backlog to fix the identified issues (with JIRA tickets) and > problem tests that are ignored should be fixed and enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9486) Serialized classes in geode-serializable fail to deserialize when validate-serializable-objects is enabled
[
https://issues.apache.org/jira/browse/GEODE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407494#comment-17407494
]
Geode Integration commented on GEODE-9486:
--
Seen in [windows-integration-test-openjdk8
#158|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/windows-integration-test-openjdk8/builds/158]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0453/test-results/integrationTest/1630423058/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0453/test-artifacts/1630423058/windows-integrationtestfiles-openjdk8-1.15.0-build.0453.tgz].
> Serialized classes in geode-serializable fail to deserialize when
> validate-serializable-objects is enabled
> --
>
> Key: GEODE-9486
> URL: https://issues.apache.org/jira/browse/GEODE-9486
> Project: Geode
> Issue Type: Bug
> Components: serialization
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> Serialized classes in geode-serializable fail to deserialize when
> {{validate-serializable-objects}} is enabled. This bug was caught by
> {{SessionsAndCrashesDUnitTest}} in geode-apis-compatible-with-redis
> (GEODE-9485):
> {noformat}
> [fatal 2021/08/04 13:50:57.548 UTC tid=114]
> Serialization filter is rejecting class
> org.apache.geode.internal.serialization.DSFIDNotFoundException
> java.lang.Exception:
> at
> org.apache.geode.internal.ObjectInputStreamFilterWrapper.lambda$createSerializationFilter$0(ObjectInputStreamFilterWrapper.java:234)
> at com.sun.proxy.$Proxy26.checkInput(Unknown Source)
> at
> java.base/java.io.ObjectInputStream.filterCheck(ObjectInputStream.java:1336)
> at
> java.base/java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:2005)
> at
> java.base/java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1862)
> at
> java.base/java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2169)
> at
> java.base/java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1679)
> {noformat}
> Any module with a class that may be serialized must implement
> {{DistributedSystemService}} to provide the list of sanctioned serializables
> as defined in {{sanctionedDataSerializables.txt}} and a concrete test
> subclassing {{AnalyzeSerializablesJUnitTestBase}}.
> {{org.apache.geode.internal.serialization.DSFIDNotFoundException}} is in
> geode-serialization which cannot depend on geode-core which owns
> {{DistributedSystemService}}. Even if we remove the unused {{void
> init(InternalDistributedSystem internalDistributedSystem)}} and move it to
> geode-serialization, {{SerializationDistributedSystemService}} would need to
> implement {{getSerializationAcceptlist()}} as:
> {noformat}
> @Override
> public Collection getSerializationAcceptlist() throws IOException {
> URL sanctionedSerializables =
> ClassPathLoader.getLatest().getResource(getClass(),
> "sanctioned-geode-gfsh-serializables.txt");
> return InternalDataSerializer.loadClassNames(sanctionedSerializables);
> }
> {noformat}
> ... which uses {{ClassPathLoader}} and {{InternalDataSerializer}} which live
> in geode-core.
> This requires moving the classes {{ClassPathLoader}} and
> {{InternalDataSerializer}} that need to be used within
> {{getSerializationAcceptlist()}}.
> {{ClassPathLoader}} depends on geode deployment:
> {noformat}
> import org.apache.geode.internal.deployment.DeploymentServiceFactory;
> import org.apache.geode.internal.deployment.JarDeploymentService;
> {noformat}
> {{InternalDataSerializer}} gets even more complicated with many dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9486) Serialized classes in geode-serializable fail to deserialize when validate-serializable-objects is enabled
[
https://issues.apache.org/jira/browse/GEODE-9486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407495#comment-17407495
]
Geode Integration commented on GEODE-9486:
--
Seen in [windows-integration-test-openjdk11
#154|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/windows-integration-test-openjdk11/builds/154]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0453/test-results/integrationTest/1630424331/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0453/test-artifacts/1630424331/windows-integrationtestfiles-openjdk11-1.15.0-build.0453.tgz].
> Serialized classes in geode-serializable fail to deserialize when
> validate-serializable-objects is enabled
> --
>
> Key: GEODE-9486
> URL: https://issues.apache.org/jira/browse/GEODE-9486
> Project: Geode
> Issue Type: Bug
> Components: serialization
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> Serialized classes in geode-serializable fail to deserialize when
> {{validate-serializable-objects}} is enabled. This bug was caught by
> {{SessionsAndCrashesDUnitTest}} in geode-apis-compatible-with-redis
> (GEODE-9485):
> {noformat}
> [fatal 2021/08/04 13:50:57.548 UTC tid=114]
> Serialization filter is rejecting class
> org.apache.geode.internal.serialization.DSFIDNotFoundException
> java.lang.Exception:
> at
> org.apache.geode.internal.ObjectInputStreamFilterWrapper.lambda$createSerializationFilter$0(ObjectInputStreamFilterWrapper.java:234)
> at com.sun.proxy.$Proxy26.checkInput(Unknown Source)
> at
> java.base/java.io.ObjectInputStream.filterCheck(ObjectInputStream.java:1336)
> at
> java.base/java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:2005)
> at
> java.base/java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1862)
> at
> java.base/java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2169)
> at
> java.base/java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1679)
> {noformat}
> Any module with a class that may be serialized must implement
> {{DistributedSystemService}} to provide the list of sanctioned serializables
> as defined in {{sanctionedDataSerializables.txt}} and a concrete test
> subclassing {{AnalyzeSerializablesJUnitTestBase}}.
> {{org.apache.geode.internal.serialization.DSFIDNotFoundException}} is in
> geode-serialization which cannot depend on geode-core which owns
> {{DistributedSystemService}}. Even if we remove the unused {{void
> init(InternalDistributedSystem internalDistributedSystem)}} and move it to
> geode-serialization, {{SerializationDistributedSystemService}} would need to
> implement {{getSerializationAcceptlist()}} as:
> {noformat}
> @Override
> public Collection getSerializationAcceptlist() throws IOException {
> URL sanctionedSerializables =
> ClassPathLoader.getLatest().getResource(getClass(),
> "sanctioned-geode-gfsh-serializables.txt");
> return InternalDataSerializer.loadClassNames(sanctionedSerializables);
> }
> {noformat}
> ... which uses {{ClassPathLoader}} and {{InternalDataSerializer}} which live
> in geode-core.
> This requires moving the classes {{ClassPathLoader}} and
> {{InternalDataSerializer}} that need to be used within
> {{getSerializationAcceptlist()}}.
> {{ClassPathLoader}} depends on geode deployment:
> {noformat}
> import org.apache.geode.internal.deployment.DeploymentServiceFactory;
> import org.apache.geode.internal.deployment.JarDeploymentService;
> {noformat}
> {{InternalDataSerializer}} gets even more complicated with many dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9541) CI Failure: SubCommandsIntegrationTest has multiple tests failing intermittently
[
https://issues.apache.org/jira/browse/GEODE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407537#comment-17407537
]
ASF subversion and git services commented on GEODE-9541:
Commit 214fc2c084c50e7a1cfa5adac5e955227de65e9b in geode's branch
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=214fc2c ]
GEODE-9541: Explicitly unsubscribe after each test in
SubCommandsIntegrationTest (#6821)
- Jedis does not track psubscribe and subscribe requests separately.
Thus a psubscribe followed by unsubscribe, (when no subscribes exist),
will cause the client to think everything is unsubscribed and
disconnect the MockSubscriber. This makes cleanup in a generic way
difficult, if not impossible. Now, instead of trying to clean up in
@After, each test does its own cleanup.
> CI Failure: SubCommandsIntegrationTest has multiple tests failing
> intermittently
>
>
> Key: GEODE-9541
> URL: https://issues.apache.org/jira/browse/GEODE-9541
> Project: Geode
> Issue Type: Test
> Components: redis, tests
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> This class has become flaky since changes to the netty/radish thread model.
> Failures look like:
> {noformat}
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldNotIncludeChannelSubscriptions_forSameClient FAILED
> org.junit.ComparisonFailure: expected:<[1]L> but was:<[2]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numpat_shouldNotIncludeChannelSubscriptions_forSameClient(AbstractSubCommandsIntegrationTest.java:334)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldNotIncludeChannelSubscriptions_forDifferentClient FAILED
> org.junit.ComparisonFailure: expected:<[1]L> but was:<[2]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numpat_shouldNotIncludeChannelSubscriptions_forDifferentClient(AbstractSubCommandsIntegrationTest.java:320)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> channels_shouldReturnListOfAllChannels_withActiveChannelSubscribers_whenCalledWithoutPattern
> FAILED
> java.lang.AssertionError:
> Expecting actual:
> [[102, 42], [102, 111, 111], [98, 97, 114]]
> to contain exactly in any order:
> [[102, 111, 111], [98, 97, 114]]
> but the following elements were unexpected:
> [[102, 42]]
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.channels_shouldReturnListOfAllChannels_withActiveChannelSubscribers_whenCalledWithoutPattern(AbstractSubCommandsIntegrationTest.java:126)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numsub_shouldReturnZero_whenCalledWithPatternWithNoChannelSubscribers FAILED
> org.junit.ComparisonFailure: expected:<"[0]"> but was:<"[1]">
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numsub_shouldReturnZero_whenCalledWithPatternWithNoChannelSubscribers(AbstractSubCommandsIntegrationTest.java:259)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldReturnCountOfAllPatternSubscriptions_includingDuplicates FAILED
> org.junit.ComparisonFailure
[jira] [Resolved] (GEODE-9541) CI Failure: SubCommandsIntegrationTest has multiple tests failing intermittently
[
https://issues.apache.org/jira/browse/GEODE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe resolved GEODE-9541.
---
Fix Version/s: 1.15.0
Resolution: Fixed
> CI Failure: SubCommandsIntegrationTest has multiple tests failing
> intermittently
>
>
> Key: GEODE-9541
> URL: https://issues.apache.org/jira/browse/GEODE-9541
> Project: Geode
> Issue Type: Test
> Components: redis, tests
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> This class has become flaky since changes to the netty/radish thread model.
> Failures look like:
> {noformat}
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldNotIncludeChannelSubscriptions_forSameClient FAILED
> org.junit.ComparisonFailure: expected:<[1]L> but was:<[2]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numpat_shouldNotIncludeChannelSubscriptions_forSameClient(AbstractSubCommandsIntegrationTest.java:334)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldNotIncludeChannelSubscriptions_forDifferentClient FAILED
> org.junit.ComparisonFailure: expected:<[1]L> but was:<[2]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numpat_shouldNotIncludeChannelSubscriptions_forDifferentClient(AbstractSubCommandsIntegrationTest.java:320)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> channels_shouldReturnListOfAllChannels_withActiveChannelSubscribers_whenCalledWithoutPattern
> FAILED
> java.lang.AssertionError:
> Expecting actual:
> [[102, 42], [102, 111, 111], [98, 97, 114]]
> to contain exactly in any order:
> [[102, 111, 111], [98, 97, 114]]
> but the following elements were unexpected:
> [[102, 42]]
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.channels_shouldReturnListOfAllChannels_withActiveChannelSubscribers_whenCalledWithoutPattern(AbstractSubCommandsIntegrationTest.java:126)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numsub_shouldReturnZero_whenCalledWithPatternWithNoChannelSubscribers FAILED
> org.junit.ComparisonFailure: expected:<"[0]"> but was:<"[1]">
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numsub_shouldReturnZero_whenCalledWithPatternWithNoChannelSubscribers(AbstractSubCommandsIntegrationTest.java:259)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> numpat_shouldReturnCountOfAllPatternSubscriptions_includingDuplicates FAILED
> org.junit.ComparisonFailure: expected:<[2]L> but was:<[3]L>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.redis.internal.executor.pubsub.AbstractSubCommandsIntegrationTest.numpat_shouldReturnCountOfAllPatternSubscriptions_includingDuplicates(AbstractSubCommandsIntegrationTest.java:302)
>
> org.apache.geode.redis.internal.executor.pubsub.SubCommandsIntegrationTest >
> channels_shouldOnlyReturnChannelsWithA
[jira] [Updated] (GEODE-8326) CI Failure: FixedPartitioningWithTransactionDistributedTest.clientCanRollbackFunctionOnRegionWithoutFilterAndWithSingleHopEnabled times out waiting for client metadata
[
https://issues.apache.org/jira/browse/GEODE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nabarun Nag updated GEODE-8326:
---
Fix Version/s: (was: 1.13.0)
> CI Failure:
> FixedPartitioningWithTransactionDistributedTest.clientCanRollbackFunctionOnRegionWithoutFilterAndWithSingleHopEnabled
> times out waiting for client metadata
> ---
>
> Key: GEODE-8326
> URL: https://issues.apache.org/jira/browse/GEODE-8326
> Project: Geode
> Issue Type: Bug
> Components: client/server, tests
>Affects Versions: 1.13.0
>Reporter: Kirk Lund
>Assignee: Eric Shu
>Priority: Major
> Labels: caching-applications
>
> CI Failure:
> http://files.apachegeode-ci.info/builds/apache-support-1-13-main/1.13.0-build.0296/test-results/distributedTest/1592846714/
> {noformat}
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest
> >
> clientCanRollbackFunctionOnRegionWithoutFilterAndWithSingleHopEnabled[ExecuteFunctionByObject]
> FAILED
> org.awaitility.core.ConditionTimeoutException: Condition with lambda
> expression in
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest
> that uses org.apache.geode.cache.client.internal.ClientMetadataService was
> not fulfilled within 5 minutes.
> at
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at
> org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
> at
> org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
> at
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest.forceClientMetadataUpdate(FixedPartitioningWithTransactionDistributedTest.java:241)
> at
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest.doFunctionTransactionAndSuspend(FixedPartitioningWithTransactionDistributedTest.java:458)
> at
> org.apache.geode.internal.cache.partitioned.fixed.FixedPartitioningWithTransactionDistributedTest.clientCanRollbackFunctionOnRegionWithoutFilterAndWithSingleHopEnabled(FixedPartitioningWithTransactionDistributedTest.java:254)
> {noformat}
> The failure occurs after waiting 5 minutes for the ClientMetadataService to
> stabilize. See ClientMetadataService#isMetadataStable.
> The timeout occurs within a block of test code that was introduced by Jake in
> PR #3840:
> {noformat}
> GEODE-7006: Fixes function execution by id with transactions. (#3840)
> * Fixes test to force and wait for PR metadata to update.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9537) CqDataUsingPoolDUnitTest (and CqDataUsingPoolOptimizedExecuteDUnitTest) should not use ephemeral ports
[
https://issues.apache.org/jira/browse/GEODE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407600#comment-17407600
]
ASF subversion and git services commented on GEODE-9537:
Commit 00aa276b5a38f32434002b53e615d62319f7b819 in geode's branch
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=00aa276 ]
GEODE-9537: Ensure that servers do not start on ephemeral ports (#6796)
> CqDataUsingPoolDUnitTest (and CqDataUsingPoolOptimizedExecuteDUnitTest)
> should not use ephemeral ports
> --
>
> Key: GEODE-9537
> URL: https://issues.apache.org/jira/browse/GEODE-9537
> Project: Geode
> Issue Type: Test
> Components: tests
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> These tests currently use ephemeral ports for components that are stopped and
> restarted during the test. It can happen that other, concurrently running
> tests, will start using these same ports causing test failures (but not in
> the tests mentioned here).
> Test failures appear as dunit suspect strings:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-locator.log' at line 347
> [fatal 2021/08/21 19:46:08.527 UTC tid=47]
> Exception in processing request from 10.0.0.107
> java.lang.Exception: Improperly configured client detected - use
> addPoolLocator to configure its locators instead of addPoolServer.
> at
> org.apache.geode.distributed.internal.ProtocolCheckerImpl.checkProtocol(ProtocolCheckerImpl.java:31)
> at
> org.apache.geode.distributed.internal.tcpserver.TcpServer.lambda$processRequest$0(TcpServer.java:342)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-9564) Radish ParameterRequirements package name does not follow naming conventions
[ https://issues.apache.org/jira/browse/GEODE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans resolved GEODE-9564. Fix Version/s: 1.15.0 Resolution: Fixed > Radish ParameterRequirements package name does not follow naming conventions > > > Key: GEODE-9564 > URL: https://issues.apache.org/jira/browse/GEODE-9564 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.15.0 >Reporter: Donal Evans >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Per [the style > guide|https://google.github.io/styleguide/javaguide.html#s5.2.1-package-names] > adopted by Geode, package names should be all lower-case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7864) Code improvement refactoring
[ https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407602#comment-17407602 ] ASF subversion and git services commented on GEODE-7864: Commit 14cfdf025f3d1b2091474c453e852b78e3299823 in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=14cfdf0 ] GEODE-7864: Add missing curly braces to if statements (#6812) - StripedExecutorService contained two instances of if statements withoug curly braces Authored-by: Donal Evans > Code improvement refactoring > > > Key: GEODE-7864 > URL: https://issues.apache.org/jira/browse/GEODE-7864 > Project: Geode > Issue Type: Improvement >Reporter: Nabarun Nag >Priority: Major > Labels: pull-request-available > Time Spent: 13h 10m > Remaining Estimate: 0h > > This is a placeholder ticket. > * this is used to do refactoring. > * this ticket number is used to number the commit message. > * this ticket will never be closed. > * it will be used to mark improvements like correcting spelling mistakes, > efficient java code, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9564) Radish ParameterRequirements package name does not follow naming conventions
[ https://issues.apache.org/jira/browse/GEODE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407604#comment-17407604 ] ASF subversion and git services commented on GEODE-9564: Commit 89dba0132ccd2f2d3ac4dca4e4f1162fafe56acf in geode's branch refs/heads/develop from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=89dba01 ] GEODE-9564: Rename package from ParameterRequirements to parameters (#6819) Authored-by: Donal Evans > Radish ParameterRequirements package name does not follow naming conventions > > > Key: GEODE-9564 > URL: https://issues.apache.org/jira/browse/GEODE-9564 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.15.0 >Reporter: Donal Evans >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > Fix For: 1.15.0 > > > Per [the style > guide|https://google.github.io/styleguide/javaguide.html#s5.2.1-package-names] > adopted by Geode, package names should be all lower-case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9566) Geode for Redis No Longer Experimental
Wayne created GEODE-9566: Summary: Geode for Redis No Longer Experimental Key: GEODE-9566 URL: https://issues.apache.org/jira/browse/GEODE-9566 Project: Geode Issue Type: New Feature Components: redis Reporter: Wayne Geode for Redis is no longer experimental. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-9567) Geode for Redis Rename
Wayne created GEODE-9567: Summary: Geode for Redis Rename Key: GEODE-9567 URL: https://issues.apache.org/jira/browse/GEODE-9567 Project: Geode Issue Type: New Feature Components: redis Reporter: Wayne The current naming convention we have for compatibility with Redis that uses the naming scheme compatible-with-redis* requires change to geode-for-redis. This includes product and test source code, documentation, region name, statistics, log files, build artifacts, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8411) CI Failure: Jetty9CachingClientServerTest. containersShouldShareDataRemovals() fails with comparison failure
[
https://issues.apache.org/jira/browse/GEODE-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407722#comment-17407722
]
Geode Integration commented on GEODE-8411:
--
Seen in [distributed-test-openjdk11
#164|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/distributed-test-openjdk11/builds/164]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0457/test-results/distributedTest/1630446270/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.15.0-build.0457/test-artifacts/1630446270/distributedtestfiles-openjdk11-1.15.0-build.0457.tgz].
> CI Failure: Jetty9CachingClientServerTest.
> containersShouldShareDataRemovals() fails with comparison failure
>
>
> Key: GEODE-8411
> URL: https://issues.apache.org/jira/browse/GEODE-8411
> Project: Geode
> Issue Type: Bug
>Reporter: Benjamin P Ross
>Priority: Major
>
> We saw Jetty9CachingClientServerTest fail with a Comparison failure in a CI
> run.
> {code:java}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> containersShouldShareDataRemovals FAILED
> org.junit.ComparisonFailure: expected:<"[]"> but was:<"[Foo]">
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8411) CI Failure: Jetty9CachingClientServerTest. containersShouldShareDataRemovals() fails with comparison failure
[
https://issues.apache.org/jira/browse/GEODE-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hale Bales reassigned GEODE-8411:
-
Assignee: Benjamin P Ross
> CI Failure: Jetty9CachingClientServerTest.
> containersShouldShareDataRemovals() fails with comparison failure
>
>
> Key: GEODE-8411
> URL: https://issues.apache.org/jira/browse/GEODE-8411
> Project: Geode
> Issue Type: Bug
>Reporter: Benjamin P Ross
>Assignee: Benjamin P Ross
>Priority: Major
>
> We saw Jetty9CachingClientServerTest fail with a Comparison failure in a CI
> run.
> {code:java}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> containersShouldShareDataRemovals FAILED
> org.junit.ComparisonFailure: expected:<"[]"> but was:<"[Foo]">
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-7282) Geode Native Client .NET guide: Fix capitalization issues
[ https://issues.apache.org/jira/browse/GEODE-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-7282: -- Labels: pull-request-available (was: ) > Geode Native Client .NET guide: Fix capitalization issues > - > > Key: GEODE-7282 > URL: https://issues.apache.org/jira/browse/GEODE-7282 > Project: Geode > Issue Type: Bug > Components: docs, native client >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > Reviewer [~karensmolermiller] approved the Native Client manual > reorganization (GEODE-7262), but noted the following issues with the .NET > version. These need cleaning up. > geode-native/dotnet/111/regions/registering-interest-for-entries.html > - C++ capitalization in 3rd paragraph and in Client API for Registering > Interest > subsection > - I believe that all the examples use C++ capitalization > > geode-native/dotnet/111/serialization/data-serialization.html > - The .NET Example subsection has capitalization wrong for the field name > description. I think that the example was wrong before these docs were > separated, so this is not a mistake in separation. > > geode-native/dotnet/111/remote-queries.html > - Step 3 under Executing a Query from the Client should have a capital 'E' > in Query.Execute(). I think that the example was wrong before these docs were > separated, so this is not a mistake in separation. > > geode-native/dotnet/111/continuous-queries.html > - Prose within step 2 of Typical Continuous Query Lifecycle should change > to CqQuery Execute* methods (in 2 spots). Original prose only used the > C++ capitalization. Step 4 changes to CqQuery.Close. > - Prose within step 3 of Executing a Continuous Query from the Client > should change to CqQuery Execute* methods. > > geode-native/dotnet/111/function-execution.html > - This whole section was originally written with C++ capitalization. I suggest > that we introduce a separate task/PR to correct the capitalization for the > .NET docs. > > geode-native/dotnet/111/transactions.html > - first paragraph of Native Client Transaction APIs should capitalize Begin, > Commit, and Rollback, as they are function names. > - second paragraph of Running Native Client Transaction should capitalize > Begin, > Commit, and Rollback, as they are function names. > - There's a boo-boo in capitalization of the .NET Example. Within a foreach > code block, it should be > var value = GetValueFromExternalSystem(); > because function name start with a capital letter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7282) Geode Native Client .NET guide: Fix capitalization issues
[ https://issues.apache.org/jira/browse/GEODE-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407727#comment-17407727 ] ASF GitHub Bot commented on GEODE-7282: --- davebarnes97 opened a new pull request #863: URL: https://github.com/apache/geode-native/pull/863 Update method names to follow C# capitalization conventions. Addresses occurrences enumerated in the JIRA ticket - not a comprehensive survey of the entire user guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Geode Native Client .NET guide: Fix capitalization issues > - > > Key: GEODE-7282 > URL: https://issues.apache.org/jira/browse/GEODE-7282 > Project: Geode > Issue Type: Bug > Components: docs, native client >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > > Reviewer [~karensmolermiller] approved the Native Client manual > reorganization (GEODE-7262), but noted the following issues with the .NET > version. These need cleaning up. > geode-native/dotnet/111/regions/registering-interest-for-entries.html > - C++ capitalization in 3rd paragraph and in Client API for Registering > Interest > subsection > - I believe that all the examples use C++ capitalization > > geode-native/dotnet/111/serialization/data-serialization.html > - The .NET Example subsection has capitalization wrong for the field name > description. I think that the example was wrong before these docs were > separated, so this is not a mistake in separation. > > geode-native/dotnet/111/remote-queries.html > - Step 3 under Executing a Query from the Client should have a capital 'E' > in Query.Execute(). I think that the example was wrong before these docs were > separated, so this is not a mistake in separation. > > geode-native/dotnet/111/continuous-queries.html > - Prose within step 2 of Typical Continuous Query Lifecycle should change > to CqQuery Execute* methods (in 2 spots). Original prose only used the > C++ capitalization. Step 4 changes to CqQuery.Close. > - Prose within step 3 of Executing a Continuous Query from the Client > should change to CqQuery Execute* methods. > > geode-native/dotnet/111/function-execution.html > - This whole section was originally written with C++ capitalization. I suggest > that we introduce a separate task/PR to correct the capitalization for the > .NET docs. > > geode-native/dotnet/111/transactions.html > - first paragraph of Native Client Transaction APIs should capitalize Begin, > Commit, and Rollback, as they are function names. > - second paragraph of Running Native Client Transaction should capitalize > Begin, > Commit, and Rollback, as they are function names. > - There's a boo-boo in capitalization of the .NET Example. Within a foreach > code block, it should be > var value = GetValueFromExternalSystem(); > because function name start with a capital letter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
