[jira] [Commented] (GEODE-9368) Upgrade to lettuce library that fixes reconnection issues

2021-07-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384891#comment-17384891
 ] 

ASF subversion and git services commented on GEODE-9368:


Commit 198f66489d842994abbcbabd621c3ed6f4d8c730 in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=198f664 ]

GEODE-9368: Changes to support better resiliency for HA scenarios (#6686)

- Wrap all StripedExecutor.execute calls with
  PartitionedRegion.computeWithPrimaryLocked.
- Handle RegionDestroyedException as a result of trying to lock a bucket
  while the bucket is moving.
- Improve race condition handling in *ScanExecutor calls
- Rename responds with MOVED when the bucket is moving during the call.
- Convert tests to use Lettuce's RedisClusterClient
- Add a retry mechanism to various lettuce calls since the client does
  not handle all failure cases.
- Fix TCL test script to ensure that buckets are created before running
  the tests.
- Ignore RedisSessionDUnitTest for now - fix in GEODE-9437

> Upgrade to lettuce library that fixes reconnection issues
> -
>
> Key: GEODE-9368
> URL: https://issues.apache.org/jira/browse/GEODE-9368
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> We found an issue with the lettuce library when doing failover testing:
> https://github.com/lettuce-io/lettuce-core/discussions/1757
> Wait until this change is merged into a released version of lettuce and 
> update all tests disabled due to this problem.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9437) Redis session dunit tests are flaky

2021-07-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384892#comment-17384892
 ] 

ASF subversion and git services commented on GEODE-9437:


Commit 198f66489d842994abbcbabd621c3ed6f4d8c730 in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=198f664 ]

GEODE-9368: Changes to support better resiliency for HA scenarios (#6686)

- Wrap all StripedExecutor.execute calls with
  PartitionedRegion.computeWithPrimaryLocked.
- Handle RegionDestroyedException as a result of trying to lock a bucket
  while the bucket is moving.
- Improve race condition handling in *ScanExecutor calls
- Rename responds with MOVED when the bucket is moving during the call.
- Convert tests to use Lettuce's RedisClusterClient
- Add a retry mechanism to various lettuce calls since the client does
  not handle all failure cases.
- Fix TCL test script to ensure that buckets are created before running
  the tests.
- Ignore RedisSessionDUnitTest for now - fix in GEODE-9437

> Redis session dunit tests are flaky
> ---
>
> Key: GEODE-9437
> URL: https://issues.apache.org/jira/browse/GEODE-9437
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>
> The Redis session-related DUnit tests will sometimes fail with errors such as:
> {noformat}
> org.apache.geode.redis.session.RedisSessionDUnitTest > should_storeSession 
> FAILED
> 
> org.springframework.web.client.HttpServerErrorException$InternalServerError: 
> 500 Server Error: [no body]
> at 
> org.springframework.web.client.HttpServerErrorException.create(HttpServerErrorException.java:100)
> at 
> org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:188)
> at 
> org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:125)
> at 
> org.springframework.web.client.ResponseErrorHandler.handleError(ResponseErrorHandler.java:63)
> at 
> org.springframework.web.client.RestTemplate.handleResponse(RestTemplate.java:819)
> at 
> org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:777)
> at 
> org.springframework.web.client.RestTemplate.execute(RestTemplate.java:711)
> at 
> org.springframework.web.client.RestTemplate.postForEntity(RestTemplate.java:468)
> at 
> org.apache.geode.redis.session.SessionDUnitTest.createNewSessionWithNote0(SessionDUnitTest.java:207)
> at 
> org.apache.geode.redis.session.SessionDUnitTest.lambda$createNewSessionWithNote$1(SessionDUnitTest.java:201)
> at 
> io.github.resilience4j.retry.Retry.lambda$decorateCallable$5(Retry.java:306)
> at 
> org.apache.geode.redis.session.SessionDUnitTest.createNewSessionWithNote(SessionDUnitTest.java:201)
> at 
> org.apache.geode.redis.session.RedisSessionDUnitTest.should_storeSession(RedisSessionDUnitTest.java:88)
> org.apache.geode.redis.session.RedisSessionDUnitTest > 
> should_propagateSession_toOtherServers FAILED
> 
> org.springframework.web.client.HttpServerErrorException$InternalServerError: 
> 500 Server Error: 
> [{"timestamp":"2021-07-19T15:38:49.855+00:00","status":500,"error":"Internal 
> Server Error","path":"/addSessionNote"}]
> at 
> org.springframework.web.client.HttpServerErrorException.create(HttpServerErrorException.java:100)
> at 
> org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:188)
> at 
> org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:125)
> at 
> org.springframework.web.client.ResponseErrorHandler.handleError(ResponseErrorHandler.java:63)
> at 
> org.springframework.web.client.RestTemplate.handleResponse(RestTemplate.java:819)
> at 
> org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:777)
> at 
> org.springframework.web.client.RestTemplate.execute(RestTemplate.java:711)
> at 
> org.springframework.web.client.RestTemplate.postForEntity(RestTemplate.java:468)
> at 
> org.apache.geode.redis.session.SessionDUnitTest.createNewSessionWithNote0(SessionDUnitTest.java:207)
> at 
> org.apache.geode.redis.session.SessionDUnitTest.lambda$createNewSessionWithNote$1(SessionDUnitTest.java:201)
> at 
> io.github.resilience4j.retry.Retry.lambda$decorateCallable$5(Retry.java:306)
> at 
> org.apache.geode.redis.session.SessionDUnitTest.createNewSessionWithNote(SessionDUnitTest.java:201)
> at 
> org.apache.geode.redis.session.RedisSessionDUnitTest.should_propagateSession_toOtherServers(RedisSessionDUnitTest.java:97)
> {nofo

[jira] [Commented] (GEODE-9360) Initial revision of .net core support

2021-07-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384937#comment-17384937
 ] 

ASF GitHub Bot commented on GEODE-9360:
---

pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r674049746



##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using Apache.Geode.Client;
+using Xunit;
+
+namespace GeodeDotNetTest {
+  [Collection("Geode .net Core Collection")]
+  public class CacheFactoryUnitTests {
+[Fact]
+public void TestCreateFactory() {

Review comment:
   Removed `Test` prefix, and `Unit` from test class and test filename.  
Added some more asserts, and made test case names a bit more descriptive where 
warranted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native 
> API.  To facilitate this, we need to implement a minimal set of C# classes 
> that use p/invoke to access geode-native via C bindings (GEODE-9358).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9360) Initial revision of .net core support

2021-07-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384938#comment-17384938
 ] 

ASF GitHub Bot commented on GEODE-9360:
---

pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r674049907



##
File path: netcore/NetCore.Test/xunit.runner.json
##
@@ -0,0 +1,5 @@
+{
+  "methodDisplay": "classAndMethod",
+  "parallelizeAssembly": true,
+  "parallelizeTestCollections": true
+}

Review comment:
   Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native 
> API.  To facilitate this, we need to implement a minimal set of C# classes 
> that use p/invoke to access geode-native via C bindings (GEODE-9358).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-9444) Improve gfsh error message when creating persistent region with no persistent gw sender

2021-07-21 Thread Alberto Bustamante Reyes (Jira)
Alberto Bustamante Reyes created GEODE-9444:
---

 Summary: Improve gfsh error message when creating persistent 
region with no persistent gw sender
 Key: GEODE-9444
 URL: https://issues.apache.org/jira/browse/GEODE-9444
 Project: Geode
  Issue Type: Improvement
  Components: gfsh
Reporter: Alberto Bustamante Reyes


The error shown in gfsh if you try to create a persistent region with a 
non-persistent gateway sender is not describing the problem.

{code}
Cluster-1 gfsh>create region --name=testregion --type=PARTITION_PERSISTENT 
--disk-store=regionstore --gateway-sender-id=sender
Member  | Status | Message
--- | -- | 
---
server1 | ERROR  | An exception was caught while registering PartitionedRegion 
/testregion. dumpPRId: prIdToPR Map@657410168:

server2 | ERROR  | An exception was caught while registering PartitionedRegion 
/testregion. dumpPRId: prIdToPR Map@985461106:

{code}

You have to check the server logs to check what happened:

{code}
[warn 2021/07/21 16:30:43.348 CEST  tid=0x3a] 
Initialization failed for Region /testregion
org.apache.geode.internal.cache.PartitionedRegionException: An exception was 
caught while registering PartitionedRegion /testregion. dumpPRId: prIdToPR 
Map@657410168:
, caused by 
org.apache.geode.internal.cache.wan.GatewaySenderConfigurationException: Non 
persistent gateway sender sender can not be attached to persistent region 
/testregion
{code}





--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9360) Initial revision of .net core support

2021-07-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384940#comment-17384940
 ] 

ASF GitHub Bot commented on GEODE-9360:
---

pdxcodemonkey commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r674056114



##
File path: netcore/NetCore/IRegionService.cs
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+
+namespace Apache {
+  namespace Geode {
+namespace Client {
+  public interface IRegionService {
+//IPdxInstanceFactory CreatePdxInstanceFactory(String 
className);

Review comment:
   Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Initial revision of .net core support
> -
>
> Key: GEODE-9360
> URL: https://issues.apache.org/jira/browse/GEODE-9360
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Blake Bender
>Priority: Major
>  Labels: pull-request-available
>
> As a .net core developer, I would like to be able to access the geode-native 
> API.  To facilitate this, we need to implement a minimal set of C# classes 
> that use p/invoke to access geode-native via C bindings (GEODE-9358).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-9443) Increase kernel.pid_max in CI images

2021-07-21 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384981#comment-17384981
 ] 

ASF subversion and git services commented on GEODE-9443:


Commit 4338015abc1605217204681f5043c3bb6f1c714a in geode's branch 
refs/heads/develop from Dale Emery
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4338015 ]

GEODE-9443: Increase pid_max in CI images (#6710)

Certain Geode tests create a lot of threads. When these tests run in
parallel with many other tests (as they do in CI), the whole set of
concurrently running tests can overwhelm the Linux kernel's ability to
assign PIDs to new threads. When this happens, test processes, Gradle
processes, and other processes can become unable to create new threads.

The relevant system parameter is `kernel.pid_max`. In our CI images,
`pid_max` is 98,304.

This commit raises CI images' `pid_max` to 983040 (10x the default
value). A build can run 24 concurrent instances of even our most
thread-heavy tests without exceeding this threshold.

Co-authored-by: Dale Emery 

> Increase kernel.pid_max in CI images
> 
>
> Key: GEODE-9443
> URL: https://issues.apache.org/jira/browse/GEODE-9443
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Dale Emery
>Assignee: Dale Emery
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>
> Certain Geode tests create a lot of threads. When these tests run in parallel 
> with many other tests (as they do in CI), the whole set of concurrently 
> running tests can overwhelm the Linux kernel's ability to assign PIDs to new 
> threads. When this happens, test processes, Gradle processes, and other 
> processes can become unable to create new threads.
> The relevant system parameter is {{kernel.pid_max}}. On our CI systems, 
> {{pid_max}} is 98,304.
> Raising {{pid_max}} to 983040 (10x the default value). A build can run 24 
> concurrent instances of even our most thread-heavy tests without exceeding 
> this threshold.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-9443) Increase kernel.pid_max in CI images

2021-07-21 Thread Dale Emery (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dale Emery resolved GEODE-9443.
---
Fix Version/s: 1.15.0
   Resolution: Fixed

> Increase kernel.pid_max in CI images
> 
>
> Key: GEODE-9443
> URL: https://issues.apache.org/jira/browse/GEODE-9443
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Dale Emery
>Assignee: Dale Emery
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.15.0
>
>
> Certain Geode tests create a lot of threads. When these tests run in parallel 
> with many other tests (as they do in CI), the whole set of concurrently 
> running tests can overwhelm the Linux kernel's ability to assign PIDs to new 
> threads. When this happens, test processes, Gradle processes, and other 
> processes can become unable to create new threads.
> The relevant system parameter is {{kernel.pid_max}}. On our CI systems, 
> {{pid_max}} is 98,304.
> Raising {{pid_max}} to 983040 (10x the default value). A build can run 24 
> concurrent instances of even our most thread-heavy tests without exceeding 
> this threshold.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-9445) Disk Store IDs are logged in two different formats

2021-07-21 Thread Lynn Gallinat (Jira)
Lynn Gallinat created GEODE-9445:


 Summary: Disk Store IDs are logged in two different formats
 Key: GEODE-9445
 URL: https://issues.apache.org/jira/browse/GEODE-9445
 Project: Geode
  Issue Type: Bug
  Components: persistence
Affects Versions: 1.15.0
Reporter: Lynn Gallinat


Logging disk store IDs in two different formats might confuse users. They 
should be logged consistently.

Here the disk store ID is logged with four "-" characters. This is from the 
toString method in util.UUID
{noformat}
[info 2021/06/23 14:59:31.002 GMT gemfirecluster-sample-locator-0  
tid=0x1] Region /_ConfigurationRegion has potentially stale data. It is waiting 
for another member to recover the latest data.
My persistent id:

  DiskStore ID: 0bfd6f3f-8244-4eae-8c1f-108feff87273
  Name: gemfirecluster-sample-locator-0
  Location: /10.208.0.26:/data/ConfigDiskDir_gemfirecluster-sample-locator-0

Members with potentially new data:
[
  DiskStore ID: 4b08042e-61b7-42a8-8549-2ef0a7152284
  Name: gemfirecluster-sample-locator-1
  Location: /10.208.2.25:/data/ConfigDiskDir_gemfirecluster-sample-locator-1
]
{noformat}
Here the disk store Id is logged with one "-" character. This comes from the 
toString method in org.apache.geode.internal.cache.DiskStoreImpl
{noformat}
[info 2021/06/23 15:00:07.251 GMT gemfirecluster-sample-locator-1  
tid=0x1] Recovered disk store cluster_config with unique id 
4b08042e61b742a8-85492ef0a7152284{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-9446) Remove unnecessary uses of byte[] in RedisSortedSet

2021-07-21 Thread Donal Evans (Jira)
Donal Evans created GEODE-9446:
--

 Summary: Remove unnecessary uses of byte[] in RedisSortedSet
 Key: GEODE-9446
 URL: https://issues.apache.org/jira/browse/GEODE-9446
 Project: Geode
  Issue Type: Improvement
  Components: redis
Affects Versions: 1.15.0
Reporter: Donal Evans


The current implementation of {{RedisSortedSet}} uses an 
{{AbstractOrderedStatisticsEntry}} class containing both {{double}} score and 
{{byte[]}} scoreBytes fields. The {{double}} field is required to allow the 
sorting behaviour required of the data structure, but the {{byte[]}} field is 
not necessary except when returning results to the client.

The class should be refactored to eliminate the {{byte[]}} scoreBytes field 
from {{AbstractOrderedStatisticsEntry}} and reduce the memory overhead of 
operations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-9446) Remove unnecessary uses of byte[] in RedisSortedSet

2021-07-21 Thread Donal Evans (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Donal Evans updated GEODE-9446:
---
Description: 
The current implementation of {{RedisSortedSet}} uses an 
{{AbstractOrderedStatisticsEntry}} class containing both {{double}} score and 
{{byte[]}} scoreBytes fields. The {{double}} field is required to allow the 
sorting behaviour required of the data structure, but the {{byte[]}} field is 
not necessary except when returning results to the client.

The class should be refactored to eliminate the {{byte[]}} scoreBytes field 
from {{AbstractOrderedStatisticsEntry}} and reduce the memory overhead of 
operations.

As part of this refactoring, the below call to {{members.put()}} should be 
removed from {{memberAdd()}} as it will no longer be necessary.
{code:java}
protected synchronized byte[] memberAdd(byte[] memberToAdd, byte[] scoreToAdd) {
...
} else {
  scoreSet.remove(existingEntry);
  byte[] oldScore = existingEntry.scoreBytes;
  existingEntry.updateScore(stripTrailingZeroFromDouble(scoreToAdd));
  members.put(memberToAdd, existingEntry); <<< remove this
  scoreSet.add(existingEntry);
  return oldScore;
}
{code}

Also, uses of the {{stripTrailingZeroFromDouble()}} method should be moved to 
just prior to the response being returned to the client, to ensure that the 
format of the returned String representations of double values match native 
Redis.

  was:
The current implementation of {{RedisSortedSet}} uses an 
{{AbstractOrderedStatisticsEntry}} class containing both {{double}} score and 
{{byte[]}} scoreBytes fields. The {{double}} field is required to allow the 
sorting behaviour required of the data structure, but the {{byte[]}} field is 
not necessary except when returning results to the client.

The class should be refactored to eliminate the {{byte[]}} scoreBytes field 
from {{AbstractOrderedStatisticsEntry}} and reduce the memory overhead of 
operations.


> Remove unnecessary uses of byte[] in RedisSortedSet
> ---
>
> Key: GEODE-9446
> URL: https://issues.apache.org/jira/browse/GEODE-9446
> Project: Geode
>  Issue Type: Improvement
>  Components: redis
>Affects Versions: 1.15.0
>Reporter: Donal Evans
>Priority: Major
>
> The current implementation of {{RedisSortedSet}} uses an 
> {{AbstractOrderedStatisticsEntry}} class containing both {{double}} score and 
> {{byte[]}} scoreBytes fields. The {{double}} field is required to allow the 
> sorting behaviour required of the data structure, but the {{byte[]}} field is 
> not necessary except when returning results to the client.
> The class should be refactored to eliminate the {{byte[]}} scoreBytes field 
> from {{AbstractOrderedStatisticsEntry}} and reduce the memory overhead of 
> operations.
> As part of this refactoring, the below call to {{members.put()}} should be 
> removed from {{memberAdd()}} as it will no longer be necessary.
> {code:java}
> protected synchronized byte[] memberAdd(byte[] memberToAdd, byte[] 
> scoreToAdd) {
> ...
> } else {
>   scoreSet.remove(existingEntry);
>   byte[] oldScore = existingEntry.scoreBytes;
>   existingEntry.updateScore(stripTrailingZeroFromDouble(scoreToAdd));
>   members.put(memberToAdd, existingEntry); <<< remove this
>   scoreSet.add(existingEntry);
>   return oldScore;
> }
> {code}
> Also, uses of the {{stripTrailingZeroFromDouble()}} method should be moved to 
> just prior to the response being returned to the client, to ensure that the 
> format of the returned String representations of double values match native 
> Redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-9447) fix release scripts

2021-07-21 Thread Owen Nichols (Jira)
Owen Nichols created GEODE-9447:
---

 Summary: fix release scripts
 Key: GEODE-9447
 URL: https://issues.apache.org/jira/browse/GEODE-9447
 Project: Geode
  Issue Type: Improvement
  Components: release
Reporter: Owen Nichols


* JAVA_HOME not respected in all cases
 * rc pipeline did not get upthewaterspout tests from the correct repo
 * one job in rc pipeline could run on old native or geode tag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-9447) fix release scripts

2021-07-21 Thread Owen Nichols (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Owen Nichols reassigned GEODE-9447:
---

Assignee: Owen Nichols

> fix release scripts
> ---
>
> Key: GEODE-9447
> URL: https://issues.apache.org/jira/browse/GEODE-9447
> Project: Geode
>  Issue Type: Improvement
>  Components: release
>Reporter: Owen Nichols
>Assignee: Owen Nichols
>Priority: Major
>
> * JAVA_HOME not respected in all cases
>  * rc pipeline did not get upthewaterspout tests from the correct repo
>  * one job in rc pipeline could run on old native or geode tag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-9447) fix release scripts

2021-07-21 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-9447:
--
Labels: pull-request-available  (was: )

> fix release scripts
> ---
>
> Key: GEODE-9447
> URL: https://issues.apache.org/jira/browse/GEODE-9447
> Project: Geode
>  Issue Type: Improvement
>  Components: release
>Reporter: Owen Nichols
>Assignee: Owen Nichols
>Priority: Major
>  Labels: pull-request-available
>
> * JAVA_HOME not respected in all cases
>  * rc pipeline did not get upthewaterspout tests from the correct repo
>  * one job in rc pipeline could run on old native or geode tag



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-9396) Upgrades using SSL fail with mismatch of hostname in certificates

2021-07-21 Thread Kamilla Aslami (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamilla Aslami reassigned GEODE-9396:
-

Assignee: Kamilla Aslami  (was: Bill Burcham)

> Upgrades using SSL fail with mismatch of hostname in certificates
> -
>
> Key: GEODE-9396
> URL: https://issues.apache.org/jira/browse/GEODE-9396
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Ernest Burghardt
>Assignee: Kamilla Aslami
>Priority: Major
>  Labels: pull-request-available
>
> When upgrading from a previous version (prior to 1.14) the ssl handshake will 
> fail to complete in cases where the Certificate contains a symbolic name that 
> doesn't match the hostname used by the sslengine.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-9396) Upgrades using SSL fail with mismatch of hostname in certificates

2021-07-21 Thread Kamilla Aslami (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kamilla Aslami updated GEODE-9396:
--
Affects Version/s: (was: 1.14.0)

> Upgrades using SSL fail with mismatch of hostname in certificates
> -
>
> Key: GEODE-9396
> URL: https://issues.apache.org/jira/browse/GEODE-9396
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Affects Versions: 1.15.0
>Reporter: Ernest Burghardt
>Assignee: Kamilla Aslami
>Priority: Major
>  Labels: pull-request-available
>
> When upgrading from a previous version (prior to 1.14) the ssl handshake will 
> fail to complete in cases where the Certificate contains a symbolic name that 
> doesn't match the hostname used by the sslengine.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)