[jira] [Commented] (GEODE-8751) Create new geode example about compression

2020-12-20 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252455#comment-17252455
 ] 

ASF GitHub Bot commented on GEODE-8751:
---

yrashish commented on pull request #106:
URL: https://github.com/apache/geode-examples/pull/106#issuecomment-748623220


   Thanks for approving the changes. Could you please merge this PR 
@upthewaterspout @mhansonp?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create new geode example about compression
> --
>
> Key: GEODE-8751
> URL: https://issues.apache.org/jira/browse/GEODE-8751
> Project: Geode
>  Issue Type: New Feature
>  Components: examples
>Reporter: Ashish Choudhary
>Assignee: Ashish Choudhary
>Priority: Major
>  Labels: pull-request-available
>
> Create new geode example about compression



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8735) Enable factory lookup logic to look for symbols in the application

2020-12-20 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252637#comment-17252637
 ] 

ASF GitHub Bot commented on GEODE-8735:
---

pivotal-jbarrett commented on a change in pull request #700:
URL: https://github.com/apache/geode-native/pull/700#discussion_r546533140



##
File path: cppcache/integration/test/resources/pr_app_client_cache.xml
##
@@ -0,0 +1,29 @@
+
+
+
+http://geode.apache.org/schema/cache";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ 
xsi:schemaLocation="http://geode.apache.org/schema/cache 
http://geode.apache.org/schema/cache/cache-1.0.xsd";

Review comment:
   No, it's lost of pairs of namespace uri to url mapping. 
   
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable factory lookup logic to look for symbols in the application
> --
>
> Key: GEODE-8735
> URL: https://issues.apache.org/jira/browse/GEODE-8735
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Affects Versions: 1.13.1
>Reporter: Mario Salazar de Torres
>Priority: Major
>  Labels: pull-request-available
>
> *AS A* native client contributor
> *I WANT* to be able to specify factory names within the application space
> *SO THAT* the user does not need to create a separate shared library to load 
> several items like partition resolvers, cache loaders, cache writers, 
> partition resolvers...
> 
> *Additional information*
> The rationale for this change is that if the user wants to declaratively 
> specify a partition resolver, right now the only way is by creating the 
> shared library.
> So the idea would be to change the current factory implementation, so library 
> name is an optional field, and whenever "library-name" is not specified, the 
> client will look for symbols within the application instead.
> *For example:*
> Using this region definition:
> {code:xml}
> 
>pool-name="partitioned-pool">
> 
> 
> 
> {code}
> And within the application defining this function:
> {code:cpp}
> APPLICATION_EXPORT PartitionResolver* createPartitionResolver()
> {
>   return new StringPrefixPartitionResolver{};
> }
> {code}
> You could declaratively create a region which uses the 
> StringPrefixPartitionResolver.
> *IMPORTANT.* Take into account that documentation should be updated in order 
> to indicate that library-name will become an optional field and what it means 
> whenever it's not present.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8737) Create new geode example about rest api

2020-12-20 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252643#comment-17252643
 ] 

ASF GitHub Bot commented on GEODE-8737:
---

yrashish commented on pull request #104:
URL: https://github.com/apache/geode-examples/pull/104#issuecomment-748794244


   @upthewaterspout I have one doubt before we merge this PR. I have used one 
single key and value for HTTP POST request and data gets inserted however If 
the user will try to re-run it will fail with 409 status code as the key is 
already present. Let me know if need to handle it differently or fine from an 
example perspective.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create new geode example about rest api
> ---
>
> Key: GEODE-8737
> URL: https://issues.apache.org/jira/browse/GEODE-8737
> Project: Geode
>  Issue Type: New Feature
>  Components: examples
>Reporter: Ashish Choudhary
>Assignee: Ashish Choudhary
>Priority: Major
>  Labels: pull-request-available
>
> Create new example that demonstrate use of geode rest api.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)