[jira] [Created] (GEODE-8388) Geode Native Client user guide: delete unused sources

2020-07-28 Thread Dave Barnes (Jira)
Dave Barnes created GEODE-8388:
--

 Summary: Geode Native Client user guide: delete unused sources
 Key: GEODE-8388
 URL: https://issues.apache.org/jira/browse/GEODE-8388
 Project: Geode
  Issue Type: Bug
  Components: docs, native client
Reporter: Dave Barnes


The geode-native docs directory contains unused sources from the 
pre-open-source days. The problem is that while they're not linked to the user 
guide's T of C, these out-of-date docs are still included in the manual build 
(a quirk of the toolset), where they can be accidentally discovered via web 
searches.

These unused files need to be identified and deleted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8388) Geode Native Client user guide: delete unused sources

2020-07-28 Thread Dave Barnes (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-8388:
--

Assignee: Dave Barnes

> Geode Native Client user guide: delete unused sources
> -
>
> Key: GEODE-8388
> URL: https://issues.apache.org/jira/browse/GEODE-8388
> Project: Geode
>  Issue Type: Bug
>  Components: docs, native client
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
>
> The geode-native docs directory contains unused sources from the 
> pre-open-source days. The problem is that while they're not linked to the 
> user guide's T of C, these out-of-date docs are still included in the manual 
> build (a quirk of the toolset), where they can be accidentally discovered via 
> web searches.
> These unused files need to be identified and deleted.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8267) serverRestartsAfterOneLocatorDies hangs

2020-07-28 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt updated GEODE-8267:
--
Summary: serverRestartsAfterOneLocatorDies hangs  (was: 
serverRestartHangsWaitingForStartupMessageResponse hangs)

> serverRestartsAfterOneLocatorDies hangs
> ---
>
> Key: GEODE-8267
> URL: https://issues.apache.org/jira/browse/GEODE-8267
> Project: Geode
>  Issue Type: Bug
>  Components: configuration, locator, membership
>Reporter: Bill Burcham
>Priority: Major
>
> hang: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/275#A
> {code}
> org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest
>  > serverRestartHangsWaitingForStartupMessageResponse FAILED
> org.junit.runners.model.TestTimedOutException: test timed out after 
> 30 milliseconds
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.socketRead(SocketInputStream.java:115)
> at java.net.SocketInputStream.read(SocketInputStream.java:168)
> at java.net.SocketInputStream.read(SocketInputStream.java:140)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:252)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:271)
> at java.io.DataInputStream.readByte(DataInputStream.java:270)
> at 
> sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:240)
> at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:164)
> at 
> java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:217)
> at 
> java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:162)
> at com.sun.proxy.$Proxy53.executeMethodOnObject(Unknown Source)
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:607)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:437)
> at 
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:94)
> at 
> org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest.serverRestartHangsWaitingForStartupMessageResponse(ClusterConfigLocatorRestartDUnitTest.java:176)
> {code}
> Seems like 300s should be long enough so I fear there may be a real problem 
> here.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8267) serverRestartsAfterOneLocatorDies hangs

2020-07-28 Thread Bruce J Schuchardt (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt updated GEODE-8267:
--
Description: 
hang: 
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/275#A]

 

The test hung in serverRestartsAfterOneLocatorDies after another failure in the 
same test class.

Here's the hung thread:
{noformat}
"Test worker" #27 prio=5 os_prio=0 cpu=5016.73ms elapsed=5638.52s 
tid=0x7f01c8ad4800 nid=0x18 runnable  [0x7f019872c000]"Test worker" #27 
prio=5 os_prio=0 cpu=5016.73ms elapsed=5638.52s tid=0x7f01c8ad4800 nid=0x18 
runnable  [0x7f019872c000]   java.lang.Thread.State: RUNNABLE at 
java.net.SocketInputStream.socketRead0(java.base@11.0.7/Native Method) at 
java.net.SocketInputStream.socketRead(java.base@11.0.7/SocketInputStream.java:115)
 at 
java.net.SocketInputStream.read(java.base@11.0.7/SocketInputStream.java:168) at 
java.net.SocketInputStream.read(java.base@11.0.7/SocketInputStream.java:140) at 
java.io.BufferedInputStream.fill(java.base@11.0.7/BufferedInputStream.java:252) 
at 
java.io.BufferedInputStream.read(java.base@11.0.7/BufferedInputStream.java:271) 
- locked <0xd08fe7a0> (a java.io.BufferedInputStream) at 
java.io.DataInputStream.readByte(java.base@11.0.7/DataInputStream.java:270) at 
sun.rmi.transport.StreamRemoteCall.executeCall(java.rmi@11.0.7/StreamRemoteCall.java:240)
 at sun.rmi.server.UnicastRef.invoke(java.rmi@11.0.7/UnicastRef.java:164) at 
java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(java.rmi@11.0.7/RemoteObjectInvocationHandler.java:217)
 at 
java.rmi.server.RemoteObjectInvocationHandler.invoke(java.rmi@11.0.7/RemoteObjectInvocationHandler.java:162)
 at com.sun.proxy.$Proxy53.executeMethodOnObject(Unknown Source) at 
org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:607) at 
org.apache.geode.test.dunit.VM.invoke(VM.java:450) at 
org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:268)
 at 
org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:261)
 at 
org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:256)
 at 
org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest.serverRestartsAfterOneLocatorDies(ClusterConfigLocatorRestartDUnitTest.java:114)
 at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.7/Native 
Method) {noformat}
Here's the previous test failure, which may have affected the test that hung:
{code:java}
org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest
 > serverRestartHangsWaitingForStartupMessageResponse FAILED

org.junit.runners.model.TestTimedOutException: test timed out after 30 
milliseconds

at java.net.SocketInputStream.socketRead0(Native Method)

at java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

at java.net.SocketInputStream.read(SocketInputStream.java:168)

at java.net.SocketInputStream.read(SocketInputStream.java:140)

at java.io.BufferedInputStream.fill(BufferedInputStream.java:252)

at java.io.BufferedInputStream.read(BufferedInputStream.java:271)

at java.io.DataInputStream.readByte(DataInputStream.java:270)

at 
sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:240)

at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:164)

at 
java.rmi.server.RemoteObjectInvocationHandler.invokeRemoteMethod(RemoteObjectInvocationHandler.java:217)

at 
java.rmi.server.RemoteObjectInvocationHandler.invoke(RemoteObjectInvocationHandler.java:162)

at com.sun.proxy.$Proxy53.executeMethodOnObject(Unknown Source)

at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:607)

at org.apache.geode.test.dunit.VM.invoke(VM.java:437)

at 
org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:94)

at 
org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest.serverRestartHangsWaitingForStartupMessageResponse(ClusterConfigLocatorRestartDUnitTest.java:176)
{code}
Seems like 300s should be long enough so I fear there may be a real problem 
here.

  was:
hang: 
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/275#A

{code}
org.apache.geode.management.internal.configuration.ClusterConfigLocatorRestartDUnitTest
 > serverRestartHangsWaitingForStartupMessageResponse FAILED

org.junit.runners.model.TestTimedOutException: test timed out after 30 
milliseconds

at java.net.SocketInputStream.socketRead0(Native Method)

at java.net.SocketInputStream.socketRead(SocketInputStream.java:115)

at java.net.SocketInputStream.read(SocketInputStr

[jira] [Created] (GEODE-8389) reconnect attempt fails due to distribution configuration validation checks

2020-07-28 Thread Bruce J Schuchardt (Jira)
Bruce J Schuchardt created GEODE-8389:
-

 Summary: reconnect attempt fails due to distribution configuration 
validation checks
 Key: GEODE-8389
 URL: https://issues.apache.org/jira/browse/GEODE-8389
 Project: Geode
  Issue Type: Bug
  Components: membership
Reporter: Bruce J Schuchardt


While tracking down a hang I found this stack trace in distributed unit test 
output.  I couldn't tell which test it came from, but it should be easy to 
write a unit test for it.

Configuration validation should ignore the ds-quorum-checker attribute when 
doing sameAs comparisons with another configuration.

 
{noformat}
[vm1] [warn 2020/06/16 19:02:34.580 GMT  tid=0x72] Exception 
occurred while trying to connect the system during reconnect[vm1] [warn 
2020/06/16 19:02:34.580 GMT  tid=0x72] Exception occurred 
while trying to connect the system during reconnect[vm1] 
java.lang.IllegalArgumentException: Unknown configuration attribute name 
ds-quorum-checker. Valid attribute names are: ack-severe-alert-threshold 
ack-wait-threshold archive-disk-space-limit archive-file-size-limit 
async-distribution-timeout async-max-queue-size async-queue-timeout 
bind-address cache-xml-file cluster-configuration-dir cluster-ssl-ciphers 
cluster-ssl-enabled cluster-ssl-keystore cluster-ssl-keystore-password 
cluster-ssl-keystore-type cluster-ssl-protocols 
cluster-ssl-require-authentication cluster-ssl-truststore 
cluster-ssl-truststore-password conflate-events conserve-sockets 
delta-propagation deploy-working-dir disable-auto-reconnect disable-jmx 
disable-tcp distributed-system-id distributed-transactions durable-client-id 
durable-client-timeout enable-cluster-configuration 
enable-management-rest-service enable-network-partition-detection 
enable-time-statistics enforce-unique-host gateway-ssl-ciphers 
gateway-ssl-enabled gateway-ssl-keystore gateway-ssl-keystore-password 
gateway-ssl-keystore-type gateway-ssl-protocols 
gateway-ssl-require-authentication gateway-ssl-truststore 
gateway-ssl-truststore-password groups http-service-bind-address 
http-service-port http-service-ssl-ciphers http-service-ssl-enabled 
http-service-ssl-keystore http-service-ssl-keystore-password 
http-service-ssl-keystore-type http-service-ssl-protocols 
http-service-ssl-require-authentication http-service-ssl-truststore 
http-service-ssl-truststore-password jmx-manager jmx-manager-access-file 
jmx-manager-bind-address jmx-manager-hostname-for-clients jmx-manager-http-port 
jmx-manager-password-file jmx-manager-port jmx-manager-ssl-ciphers 
jmx-manager-ssl-enabled jmx-manager-ssl-keystore 
jmx-manager-ssl-keystore-password jmx-manager-ssl-keystore-type 
jmx-manager-ssl-protocols jmx-manager-ssl-require-authentication 
jmx-manager-ssl-truststore jmx-manager-ssl-truststore-password 
jmx-manager-start jmx-manager-update-rate load-cluster-configuration-from-dir 
locator-wait-time locators lock-memory log-disk-space-limit log-file 
log-file-size-limit log-level max-num-reconnect-tries max-wait-time-reconnect 
mcast-address mcast-flow-control mcast-port mcast-recv-buffer-size 
mcast-send-buffer-size mcast-ttl member-timeout membership-port-range 
memcached-bind-address memcached-port memcached-protocol name 
off-heap-memory-size redis-bind-address redis-enabled redis-password redis-port 
redundancy-zone remote-locators remove-unresponsive-client roles 
security-auth-token-enabled-components security-client-accessor 
security-client-accessor-pp security-client-auth-init 
security-client-authenticator security-client-dhalgo security-log-file 
security-log-level security-manager security-peer-auth-init 
security-peer-authenticator security-peer-verifymember-timeout 
security-post-processor security-shiro-init security-udp-dhalgo 
serializable-object-filter server-bind-address server-ssl-ciphers 
server-ssl-enabled server-ssl-keystore server-ssl-keystore-password 
server-ssl-keystore-type server-ssl-protocols server-ssl-require-authentication 
server-ssl-truststore server-ssl-truststore-password socket-buffer-size 
socket-lease-time ssl-ciphers ssl-cluster-alias ssl-default-alias 
ssl-enabled-components ssl-endpoint-identification-enabled ssl-gateway-alias 
ssl-jmx-alias ssl-keystore ssl-keystore-password ssl-keystore-type 
ssl-locator-alias ssl-parameter-extension ssl-protocols 
ssl-require-authentication ssl-server-alias ssl-truststore 
ssl-truststore-password ssl-truststore-type ssl-use-default-context 
ssl-web-alias ssl-web-require-authentication start-dev-rest-api start-locator 
statistic-archive-file statistic-sample-rate statistic-sampling-enabled 
tcp-port thread-monitor-enabled thread-monitor-interval-ms 
thread-monitor-time-limit-ms udp-fragment-size udp-recv-buffer-size 
udp-send-buffer-size use-cluster-configuration user-command-packages 
validate-serializable-objects .[vm1]  at 
org.apache.geode.internal.AbstractConfig.checkAttri

[jira] [Commented] (GEODE-8267) serverRestartsAfterOneLocatorDies hangs

2020-07-28 Thread Bruce J Schuchardt (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166582#comment-17166582
 ] 

Bruce J Schuchardt commented on GEODE-8267:
---

See also GEODE-8389, which has a suspicious auto-reconnect error from the same 
run.

Stack traces from the artifacts also show these dangling auto-reconnect 
threads, which would be from a previous test and may be blocking the test that 
hung.
{noformat}
"ReconnectThread" #97 prio=5 os_prio=0 cpu=6655.62ms elapsed=5595.75s 
tid=0x7f6f2c4e5800 nid=0x2ea in Object.wait()  
[0x7f6e6fbfc000]"ReconnectThread" #97 prio=5 os_prio=0 cpu=6655.62ms 
elapsed=5595.75s tid=0x7f6f2c4e5800 nid=0x2ea in Object.wait()  
[0x7f6e6fbfc000]   java.lang.Thread.State: TIMED_WAITING (on object 
monitor) at java.lang.Object.wait(java.base@11.0.7/Native Method) - waiting on 
 at 
org.apache.geode.distributed.internal.InternalDistributedSystem.reconnect(InternalDistributedSystem.java:2569)
 at 
org.apache.geode.distributed.internal.InternalDistributedSystem.tryReconnect(InternalDistributedSystem.java:2424)
 - waiting to re-lock in wait() <0xe063ad70> (a java.lang.Object) - 
locked <0xe10b6060> (a java.lang.Class for 
org.apache.geode.internal.cache.GemFireCacheImpl) - locked <0xe0cd2348> 
(a java.lang.Class for org.apache.geode.internal.cache.InternalCacheBuilder) at 
org.apache.geode.distributed.internal.InternalDistributedSystem.disconnect(InternalDistributedSystem.java:1275)
 at 
org.apache.geode.distributed.internal.ClusterDistributionManager$DMListener.membershipFailure(ClusterDistributionManager.java:2315)
 at 
org.apache.geode.distributed.internal.membership.gms.GMSMembership.uncleanShutdown(GMSMembership.java:1287)
 at 
org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.lambda$forceDisconnect$0(GMSMembership.java:2030)
 at 
org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl$$Lambda$453/0x000840bbe440.run(Unknown
 Source) at java.lang.Thread.run(java.base@11.0.7/Thread.java:834)
   Locked ownable synchronizers: - None
"RMI TCP Connection(5)-172.17.0.11" #310 daemon prio=5 os_prio=0 cpu=269.79ms 
elapsed=5330.58s tid=0x7f6f30001800 nid=0x5b8 waiting for monitor entry  
[0x7f6f359da000]   java.lang.Thread.State: BLOCKED (on object monitor) at 
org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:156)
 - waiting to lock <0xe0cd2348> (a java.lang.Class for 
org.apache.geode.internal.cache.InternalCacheBuilder) at 
org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142) at 
org.apache.geode.test.junit.rules.ServerStarterRule.startServer(ServerStarterRule.java:199)
 at 
org.apache.geode.test.junit.rules.ServerStarterRule.before(ServerStarterRule.java:91)
 at 
org.apache.geode.test.dunit.rules.ClusterStartupRule.lambda$startServerVM$729766c4$1(ClusterStartupRule.java:277)
 at 
org.apache.geode.test.dunit.rules.ClusterStartupRule$$Lambda$139/0x000840a2b440.call(Unknown
 Source) at 
org.apache.geode.test.dunit.internal.IdentifiableCallable.call(IdentifiableCallable.java:41)
 at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.7/Native 
Method) at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@11.0.7/NativeMethodAccessorImpl.java:62)
 at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@11.0.7/DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(java.base@11.0.7/Method.java:566) at 
org.apache.geode.test.dunit.internal.MethodInvoker.executeObject(MethodInvoker.java:123)
 at 
org.apache.geode.test.dunit.internal.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:78)
 at jdk.internal.reflect.GeneratedMethodAccessor250.invoke(Unknown Source) at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@11.0.7/DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(java.base@11.0.7/Method.java:566) at 
sun.rmi.server.UnicastServerRef.dispatch(java.rmi@11.0.7/UnicastServerRef.java:359)
 at sun.rmi.transport.Transport$1.run(java.rmi@11.0.7/Transport.java:200) at 
sun.rmi.transport.Transport$1.run(java.rmi@11.0.7/Transport.java:197) at 
java.security.AccessController.doPrivileged(java.base@11.0.7/Native Method) at 
sun.rmi.transport.Transport.serviceCall(java.rmi@11.0.7/Transport.java:196) at 
sun.rmi.transport.tcp.TCPTransport.handleMessages(java.rmi@11.0.7/TCPTransport.java:562)
 at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(java.rmi@11.0.7/TCPTransport.java:796)
 at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(java.rmi@11.0.7/TCPTransport.java:677)
 at 
sun.rmi.transport.tcp.TCPTransport$ConnectionHandler$$Lambda$134/0x000840a25840.run(java.rmi@11.0.7/Unknown
 Source) at java.security.AccessController.doPrivileged(java.base@11.0.7/Native 
Method) at 
sun.rmi.transport.tcp

[jira] [Created] (GEODE-8390) Geode Native Client user guide: Expand "Continuous Queries" navigation

2020-07-28 Thread Dave Barnes (Jira)
Dave Barnes created GEODE-8390:
--

 Summary: Geode Native Client user guide: Expand "Continuous 
Queries" navigation
 Key: GEODE-8390
 URL: https://issues.apache.org/jira/browse/GEODE-8390
 Project: Geode
  Issue Type: Improvement
  Components: docs, native client
Reporter: Dave Barnes


In the native client user guides (both C++ and .NET), the left-hand navigation 
pick "Continuous Queries" has no subtopics. The page itself contains a plethora 
of links, some of which should be promoted to visibility in the left-hand nav. 
For example, Connection Pools and High-Availability.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8390) Geode Native Client user guide: Expose "Continuous Queries" links as nav topics

2020-07-28 Thread Dave Barnes (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes updated GEODE-8390:
---
Summary: Geode Native Client user guide: Expose "Continuous Queries" links 
as nav topics  (was: Geode Native Client user guide: Expand "Continuous 
Queries" navigation)

> Geode Native Client user guide: Expose "Continuous Queries" links as nav 
> topics
> ---
>
> Key: GEODE-8390
> URL: https://issues.apache.org/jira/browse/GEODE-8390
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, native client
>Reporter: Dave Barnes
>Priority: Major
>
> In the native client user guides (both C++ and .NET), the left-hand 
> navigation pick "Continuous Queries" has no subtopics. The page itself 
> contains a plethora of links, some of which should be promoted to visibility 
> in the left-hand nav. For example, Connection Pools and High-Availability.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7864) Code improvement refactoring

2020-07-28 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166716#comment-17166716
 ] 

ASF subversion and git services commented on GEODE-7864:


Commit e7051289e7a30e942be46e7364dfcdbc3a4e3051 in geode's branch 
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e705128 ]

GEODE-7864: Fix several LGTM warnings (#5400)

- This commit addresses warnings with the language-features, logic,
useless-code, readability and security tags on LGTM
- The change to CompactRangeIndex may be fixing a bug/incorrectness in
the code

Authored-by: Donal Evans 

> Code improvement refactoring
> 
>
> Key: GEODE-7864
> URL: https://issues.apache.org/jira/browse/GEODE-7864
> Project: Geode
>  Issue Type: Improvement
>Reporter: Nabarun Nag
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 13h 10m
>  Remaining Estimate: 0h
>
> This is a placeholder ticket.
>  * this is used to do refactoring.
>  * this ticket number is used to number the commit message.
>  * this ticket will never be closed.
>  * it will be used to mark improvements like correcting spelling mistakes, 
> efficient java code, etc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-5782) LauncherMemberMXBeanIntegrationTest can fail intermittently

2020-07-28 Thread Ernest Burghardt (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166895#comment-17166895
 ] 

Ernest Burghardt commented on GEODE-5782:
-

windows again...  

https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsCoreIntegrationTestOpenJDK11/builds/365
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0244/test-results/integrationTest/1595989147/
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
 
Test report artifacts from this job are available at:
 
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0244/test-artifacts/1595989147/windows-coreintegrationtestfiles-OpenJDK11-1.14.0-build.0244.tgz

> LauncherMemberMXBeanIntegrationTest can fail intermittently
> ---
>
> Key: GEODE-5782
> URL: https://issues.apache.org/jira/browse/GEODE-5782
> Project: Geode
>  Issue Type: Test
>  Components: jmx
>Affects Versions: 1.9.0
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Noticed this failure:
> {noformat}
> org.apache.geode.distributed.LauncherMemberMXBeanIntegrationTest > 
> showOSMetrics_reconstructsOSMetricsFromCompositeDataType FAILED
> org.junit.ComparisonFailure: expected:<204.[68]> but was:<204.[55]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.distributed.LauncherMemberMXBeanIntegrationTest.showOSMetrics_reconstructsOSMetricsFromCompositeDataType(LauncherMemberMXBeanIntegrationTest.java:143)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8109) CI failure: JMXMBeanReconnectDUnitTest > serverMXBeansOnServerAreUnaffectedByLocatorCrash failed with ConditionTimeoutException

2020-07-28 Thread Ernest Burghardt (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166897#comment-17166897
 ] 

Ernest Burghardt commented on GEODE-8109:
-

failed again: 
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/386]

 
 
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0244/test-results/distributedTest/1595982862/
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
 
Test report artifacts from this job are available at:
 
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0244/test-artifacts/1595982862/distributedtestfiles-OpenJDK8-1.14.0-build.0244.tgz

> CI failure: JMXMBeanReconnectDUnitTest > 
> serverMXBeansOnServerAreUnaffectedByLocatorCrash failed with 
> ConditionTimeoutException
> ---
>
> Key: GEODE-8109
> URL: https://issues.apache.org/jira/browse/GEODE-8109
> Project: Geode
>  Issue Type: Bug
>  Components: jmx
>Reporter: Barrett Oglesby
>Priority: Major
>
> DistributedTestOpenJDK8 build 157:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/157
> Failed with:
> {noformat}
> org.apache.geode.management.JMXMBeanReconnectDUnitTest > 
> serverMXBeansOnServerAreUnaffectedByLocatorCrash FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest$$Lambda$343/845984545.call
>  in VM -1 running on Host e4f9524803d1 with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:610)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:462)
> at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.setUp(JMXMBeanReconnectDUnitTest.java:189)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition 
> defined as a lambda expression in 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest [GemFire mbeans on 
> locator2] 
> Expecting:
>  <[GemFire:type=Member,member=locator1,
> 
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator2,
> GemFire:type=Member,member=server1,
> GemFire:service=Manager,type=Member,member=locator1,
> GemFire:service=Locator,type=Member,member=locator2,
> GemFire:type=Member,member=locator2,
> GemFire:service=Region,name=/region1,type=Member,member=server1,
> GemFire:service=FileUploader,type=Distributed,
> 
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator2,
> GemFire:service=Manager,type=Member,member=locator2,
> GemFire:service=Locator,type=Member,member=locator1,
> GemFire:service=System,type=Distributed,
> GemFire:service=AccessControl,type=Distributed,
> 
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Distributed,
> GemFire:service=Region,name=/region1,type=Distributed]>
> to contain:
>  <[GemFire:type=Member,member=locator1,
> GemFire:service=Locator,type=Member,member=locator1,
> GemFire:service=Manager,type=Member,member=locator1,
> 
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator1,
> 
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
> but could not find:
>  
> <[GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator1,
> 
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
>  within 5 minutes.
> at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at 
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
> at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.lambda$setUp$515fd116$3(JMXMBeanReconnectDUnitTest.java:190)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

[jira] [Commented] (GEODE-6222) CI Failure: GemFireDeadlockDetectorDUnitTest

2020-07-28 Thread Ernest Burghardt (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166898#comment-17166898
 ] 

Ernest Burghardt commented on GEODE-6222:
-

failed again:

[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/377]

 
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0244/test-results/distributedTest/1595982057/
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
 
Test report artifacts from this job are available at:
 
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0244/test-artifacts/1595982057/distributedtestfiles-OpenJDK11-1.14.0-build.0244.tgz

> CI Failure: GemFireDeadlockDetectorDUnitTest
> 
>
> Key: GEODE-6222
> URL: https://issues.apache.org/jira/browse/GEODE-6222
> Project: Geode
>  Issue Type: Bug
>  Components: distributed lock service
>Affects Versions: 1.9.0
>Reporter: Ken Howe
>Priority: Major
>  Labels: flaky
>
> Flaky test failure in 
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/247]
> {code:java}
> org.apache.geode.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest
>  > testDistributedDeadlockWithDLock FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at 
> org.apache.geode.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithDLock(GemFireDeadlockDetectorDUnitTest.java:199)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)