[jira] [Commented] (GEODE-8293) activeCQCount has negative value
[
https://issues.apache.org/jira/browse/GEODE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163272#comment-17163272
]
ASF GitHub Bot commented on GEODE-8293:
---
mkevo opened a new pull request #5397:
URL: https://github.com/apache/geode/pull/5397
This counter increments correct, but when doing decrement it should
decrement just one which is incremented.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> activeCQCount has negative value
>
>
> Key: GEODE-8293
> URL: https://issues.apache.org/jira/browse/GEODE-8293
> Project: Geode
> Issue Type: Bug
> Components: statistics
>Reporter: Mario Kevo
>Priority: Major
>
> In case you have more than one server in the system and you close CQ there
> will be negative value of active cqs.
> The problem is when you started more than one server and execute cq on it. In
> that case we got incCqsActive on one server, but when it is closed we have
> decCqsActive on both servers.
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide MetricsCategory | Metric | Value
> | | -
> query| activeCQCount| 1
> | queryRequestRate | 0.0
> {code}
> After cq is closed or stopped:
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide Metrics
> Category | Metric | Value
> | | -
> query| activeCQCount| -1
> | queryRequestRate | 0.0
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8293) activeCQCount has negative value
[
https://issues.apache.org/jira/browse/GEODE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8293:
--
Labels: pull-request-available (was: )
> activeCQCount has negative value
>
>
> Key: GEODE-8293
> URL: https://issues.apache.org/jira/browse/GEODE-8293
> Project: Geode
> Issue Type: Bug
> Components: statistics
>Reporter: Mario Kevo
>Priority: Major
> Labels: pull-request-available
>
> In case you have more than one server in the system and you close CQ there
> will be negative value of active cqs.
> The problem is when you started more than one server and execute cq on it. In
> that case we got incCqsActive on one server, but when it is closed we have
> decCqsActive on both servers.
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide MetricsCategory | Metric | Value
> | | -
> query| activeCQCount| 1
> | queryRequestRate | 0.0
> {code}
> After cq is closed or stopped:
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide Metrics
> Category | Metric | Value
> | | -
> query| activeCQCount| -1
> | queryRequestRate | 0.0
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-923) CI failure: ConnectionManagerJUnitTest.testIdleExpiration
[
https://issues.apache.org/jira/browse/GEODE-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163337#comment-17163337
]
Mario Kevo commented on GEODE-923:
--
Another failure:
http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-5397/test-results/integrationTest/1595489934/
> CI failure: ConnectionManagerJUnitTest.testIdleExpiration
> -
>
> Key: GEODE-923
> URL: https://issues.apache.org/jira/browse/GEODE-923
> Project: Geode
> Issue Type: Bug
> Components: client/server
>Reporter: Sai Boorlagadda
>Priority: Major
> Labels: CI, Flaky
>
> {noformat}
> Error Message
> java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
> Stacktrace
> java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> com.gemstone.gemfire.cache.client.internal.pooling.ConnectionManagerJUnitTest.testIdleExpiration(ConnectionManagerJUnitTest.java:282)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecu
[jira] [Assigned] (GEODE-8293) activeCQCount has negative value
[
https://issues.apache.org/jira/browse/GEODE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Kevo reassigned GEODE-8293:
-
Assignee: Mario Kevo
> activeCQCount has negative value
>
>
> Key: GEODE-8293
> URL: https://issues.apache.org/jira/browse/GEODE-8293
> Project: Geode
> Issue Type: Bug
> Components: statistics
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
> Labels: pull-request-available
>
> In case you have more than one server in the system and you close CQ there
> will be negative value of active cqs.
> The problem is when you started more than one server and execute cq on it. In
> that case we got incCqsActive on one server, but when it is closed we have
> decCqsActive on both servers.
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide MetricsCategory | Metric | Value
> | | -
> query| activeCQCount| 1
> | queryRequestRate | 0.0
> {code}
> After cq is closed or stopped:
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide Metrics
> Category | Metric | Value
> | | -
> query| activeCQCount| -1
> | queryRequestRate | 0.0
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8172) CI failure: ParallelWANPersistenceEnabledGatewaySenderOffHeapDUnitTest.testpersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
[
https://issues.apache.org/jira/browse/GEODE-8172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163649#comment-17163649
]
Bruce J Schuchardt commented on GEODE-8172:
---
This test failed again in build 377
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/377]
> CI failure:
> ParallelWANPersistenceEnabledGatewaySenderOffHeapDUnitTest.testpersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
> ---
>
> Key: GEODE-8172
> URL: https://issues.apache.org/jira/browse/GEODE-8172
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: Bruce J Schuchardt
>Assignee: Mario Ivanac
>Priority: Major
>
> Failed in a CI run
> (https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/191#A).
> No previous failures for this issue are found in JIRA and no recent WAN
> changes could be detected. Flaky?
> {noformat}
> > Task :geode-wan:distributedTest
> org.apache.geode.internal.cache.wan.offheap.ParallelWANPersistenceEnabledGatewaySenderOffHeapDUnitTest
> >
> testpersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
> FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.wan.parallel.ParallelWANPersistenceEnabledGatewaySenderDUnitTest$$Lambda$487/908301056.run
> in VM 2 running on Host 8e35f765a792 with 8 VMs
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.internal.cache.wan.WANTestBase that uses int,
> intorg.apache.geode.cache.Region Expected region entries: 0 but actual
> entries: 20 present region keyset [3, 5, 8, 13, 16, 21, 27, 30, 35, 38, 43,
> 45, 50, 54, 58, 62, 65, 68, 73, 78] expected:<0> but was:<20> within 5
> minutes.
> Caused by:
> java.lang.AssertionError: Expected region entries: 0 but actual
> entries: 20 present region keyset [3, 5, 8, 13, 16, 21, 27, 30, 35, 38, 43,
> 45, 50, 54, 58, 62, 65, 68, 73, 78] expected:<0> but was:<20>
> 824 tests completed, 1 failed, 59 skipped
> > Task :geode-wan:distributedTest FAILED
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-6331) WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover. testSecondaryEventsNotReprocessedAfterOldSiteMemberFailover fails to connect to VM
[
https://issues.apache.org/jira/browse/GEODE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163652#comment-17163652
]
Bruce J Schuchardt commented on GEODE-6331:
---
failed again in CI:
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK11/builds/366]
> WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover.
> testSecondaryEventsNotReprocessedAfterOldSiteMemberFailover fails to connect
> to VM
>
>
> Key: GEODE-6331
> URL: https://issues.apache.org/jira/browse/GEODE-6331
> Project: Geode
> Issue Type: Bug
>Reporter: Dale Emery
>Priority: Major
> Labels: flaky
>
> Three tests failed in a pre-checkin:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-pr/jobs/UpgradeTestOpenJDK8/builds/891]
> [http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-3128/test-results/upgradeTest/1548465524/]
> The first test failed in `GfshCommandRule.after()`:
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.test.dunit.IgnoredException$1.run in VM 2 running on Host
> 316152fb4a09 with 7 VMs with version 150
> at org.apache.geode.test.dunit.VM.checkAvailability(VM.java:512)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:364)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:59)
> at org.apache.geode.test.dunit.Invoke.invokeInEveryVM(Invoke.java:48)
> at
> org.apache.geode.test.dunit.IgnoredException.remove(IgnoredException.java:114)
> at
> org.apache.geode.test.junit.rules.GfshCommandRule.after(GfshCommandRule.java:128)
> at
> org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:42)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
> at
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapte
[jira] [Commented] (GEODE-5782) LauncherMemberMXBeanIntegrationTest can fail intermittently
[
https://issues.apache.org/jira/browse/GEODE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163655#comment-17163655
]
Bruce J Schuchardt commented on GEODE-5782:
---
failed again on Windows:
{noformat}
LauncherMemberMXBeanIntegrationTest >
showOSMetrics_reconstructsOSMetricsFromCompositeDataType FAILED
16:29:20java.lang.AssertionError:
16:29:20Expecting:
16:29:20 <(1081712640,1081970688)>
16:29:20to match 'committed virtual memory size]' predicate.
16:29:20at org.apache.geode.distributed.LauncherMemberMXB
{noformat}
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsCoreIntegrationTestOpenJDK11/builds/356]
> LauncherMemberMXBeanIntegrationTest can fail intermittently
> ---
>
> Key: GEODE-5782
> URL: https://issues.apache.org/jira/browse/GEODE-5782
> Project: Geode
> Issue Type: Test
> Components: jmx
>Affects Versions: 1.9.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Noticed this failure:
> {noformat}
> org.apache.geode.distributed.LauncherMemberMXBeanIntegrationTest >
> showOSMetrics_reconstructsOSMetricsFromCompositeDataType FAILED
> org.junit.ComparisonFailure: expected:<204.[68]> but was:<204.[55]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.distributed.LauncherMemberMXBeanIntegrationTest.showOSMetrics_reconstructsOSMetricsFromCompositeDataType(LauncherMemberMXBeanIntegrationTest.java:143)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8379) CI failure: TimeIntegrationTest.timeCommandRespondsWIthTwoValue
Bruce J Schuchardt created GEODE-8379:
-
Summary: CI failure:
TimeIntegrationTest.timeCommandRespondsWIthTwoValue
Key: GEODE-8379
URL: https://issues.apache.org/jira/browse/GEODE-8379
Project: Geode
Issue Type: Bug
Components: redis
Reporter: Bruce J Schuchardt
This relatively new test failed in a Windows CI run:
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsIntegrationTestOpenJDK11/builds/339]
{noformat}
org.apache.geode.redis.internal.executor.server.TimeIntegrationTest >
timeCommandRespondsWIthTwoValues FAILED
16:38:28java.lang.AssertionError:
16:38:28Expecting:
16:38:28 <0L>
16:38:28to be greater than:
16:38:28 <0L>
16:38:28at
org.apache.geode.redis.internal.executor.server.TimeIntegrationTest.timeCommandRespondsWIthTwoValues(TimeIntegrationTest.java:57)
16:48:28 {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8380) CI failure: AlterRuntimeCommandDistributedTest.alterDisableStatisticSampling
Bruce J Schuchardt created GEODE-8380:
-
Summary: CI failure:
AlterRuntimeCommandDistributedTest.alterDisableStatisticSampling
Key: GEODE-8380
URL: https://issues.apache.org/jira/browse/GEODE-8380
Project: Geode
Issue Type: Bug
Reporter: Bruce J Schuchardt
This test failed with a suspect string in a Windows CI run:
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsGfshDistributedTestOpenJDK8/builds/353]
{noformat}
org.apache.geode.management.internal.cli.commands.AlterRuntimeCommandDistributedTest
> alterDisableStatisticSampling(true) [0] FAILED
15:43:47java.lang.AssertionError: Suspicious strings were written to the
log during this run.
15:43:47Fix the strings or use IgnoredException.addIgnoredException to
ignore.
15:43:47
---
15:43:47Found suspect string in log4j at line 755
15:43:47
15:43:47[fatal 2020/07/22 22:43:44.593 GMT tid=1121] Unknown handshake reply code: 0 messageLength: 89
15:43:47 {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-7680: -- Labels: GeodeCommons caching-applications pull-request-available (was: GeodeCommons caching-applications) > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163680#comment-17163680 ] ASF subversion and git services commented on GEODE-7680: Commit b941d7fe7fb0df69636fbb7847899d10cf281dea in geode's branch refs/heads/feature/GEODE-7665 from Donal Evans [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b941d7f ] GEODE-7680: PR.clear must be successful when interacting with rebalance (#5095) - Added DUnit tests to confirm that clear does not interfere with rebalance or vice versa - Test when member departs during clear/rebalance - Test when member joins during clear/rebalance - Fixed typo in PartitionedRegionClearWithExpirationDUnitTest - Fixed typo in PartitionedRegion - Call assignBucketsToPartitions() on leader colocated region during clear instead of target region Authored-by: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163679#comment-17163679 ] ASF GitHub Bot commented on GEODE-7680: --- DonalEvans merged pull request #5095: URL: https://github.com/apache/geode/pull/5095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans reassigned GEODE-7680: -- Assignee: Donal Evans > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans resolved GEODE-7680. Fix Version/s: 1.14.0 Resolution: Fixed > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Donal Evans >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > Fix For: 1.14.0 > > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-7680) Partitioned region clear operations must be successful while interacting with rebalance
[ https://issues.apache.org/jira/browse/GEODE-7680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans reassigned GEODE-7680: -- Assignee: (was: Donal Evans) > Partitioned region clear operations must be successful while interacting with > rebalance > > > Key: GEODE-7680 > URL: https://issues.apache.org/jira/browse/GEODE-7680 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons, caching-applications, > pull-request-available > > Clear operations are successful and while rebalance operations are ongoing. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8366) A non-persistent partitioned region attached to a non-persistent gateway sender throws an exception if its leader co-located region is persistent
[
https://issues.apache.org/jira/browse/GEODE-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163724#comment-17163724
]
ASF GitHub Bot commented on GEODE-8366:
---
boglesby merged pull request #5378:
URL: https://github.com/apache/geode/pull/5378
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> A non-persistent partitioned region attached to a non-persistent gateway
> sender throws an exception if its leader co-located region is persistent
> -
>
> Key: GEODE-8366
> URL: https://issues.apache.org/jira/browse/GEODE-8366
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: Barrett Oglesby
>Assignee: Barrett Oglesby
>Priority: Major
> Labels: pull-request-available
>
> With this configuration:
> {noformat}
> enable-persistence="false" remote-distributed-system-id="1"/>
>
>
>
> redundant-copies="1"/>
>
>
> {noformat}
> An exception is thrown, and the Cache fails to start.
> The error and exception are:
> {noformat}
> [error 2020/07/16 14:06:59.908 PDT tid=0x1]
> org.apache.geode.internal.cache.wan.GatewaySenderException: Non persistent
> gateway sender non_persistent_sender can not be attached to persistent region
> /persistent_parent
> {noformat}
> {noformat}
> Exception in thread "main"
> org.apache.geode.internal.cache.wan.GatewaySenderException: Non persistent
> gateway sender non_persistent_sender can not be attached to persistent region
> /persistent_parent
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderQueue.java:470)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderQueue.java:459)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderEventProcessor.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderEventProcessor.java:195)
> at
> org.apache.geode.internal.cache.wan.parallel.ConcurrentParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ConcurrentParallelGatewaySenderQueue.java:183)
> at
> org.apache.geode.internal.cache.PartitionedRegion.postCreateRegion(PartitionedRegion.java:1201)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3115)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:2975)
> {noformat}
> The ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR method
> currently compares the data policy of the input region's leader region with
> the sender's persistence policy. It assumes the input region and the leader
> region have the same data policy. In this scenario, that is not the case. The
> input region is 'non_persistent_child' which is not persistent, and the
> leader region is 'persistent_parent' which is persistent. The sender is
> 'non_persistent_sender' which is not persistent. So, instead of comparing the
> data policy of 'non_persistent_child' to the sender which would succeed since
> they are both not persistent, it compares the data policy of
> 'persistent_parent' to the sender which fails since one is persistent, and
> the other is not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8366) A non-persistent partitioned region attached to a non-persistent gateway sender throws an exception if its leader co-located region is persistent
[
https://issues.apache.org/jira/browse/GEODE-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163725#comment-17163725
]
ASF subversion and git services commented on GEODE-8366:
Commit f9626323d284f828d0e6b7b7277066107721dba9 in geode's branch
refs/heads/develop from Barry Oglesby
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f962632 ]
GEODE-8366: Compared the input region's data policy to the sender instead of
the leader region's
> A non-persistent partitioned region attached to a non-persistent gateway
> sender throws an exception if its leader co-located region is persistent
> -
>
> Key: GEODE-8366
> URL: https://issues.apache.org/jira/browse/GEODE-8366
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: Barrett Oglesby
>Assignee: Barrett Oglesby
>Priority: Major
> Labels: pull-request-available
>
> With this configuration:
> {noformat}
> enable-persistence="false" remote-distributed-system-id="1"/>
>
>
>
> redundant-copies="1"/>
>
>
> {noformat}
> An exception is thrown, and the Cache fails to start.
> The error and exception are:
> {noformat}
> [error 2020/07/16 14:06:59.908 PDT tid=0x1]
> org.apache.geode.internal.cache.wan.GatewaySenderException: Non persistent
> gateway sender non_persistent_sender can not be attached to persistent region
> /persistent_parent
> {noformat}
> {noformat}
> Exception in thread "main"
> org.apache.geode.internal.cache.wan.GatewaySenderException: Non persistent
> gateway sender non_persistent_sender can not be attached to persistent region
> /persistent_parent
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderQueue.java:470)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderQueue.java:459)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderEventProcessor.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderEventProcessor.java:195)
> at
> org.apache.geode.internal.cache.wan.parallel.ConcurrentParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ConcurrentParallelGatewaySenderQueue.java:183)
> at
> org.apache.geode.internal.cache.PartitionedRegion.postCreateRegion(PartitionedRegion.java:1201)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3115)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:2975)
> {noformat}
> The ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR method
> currently compares the data policy of the input region's leader region with
> the sender's persistence policy. It assumes the input region and the leader
> region have the same data policy. In this scenario, that is not the case. The
> input region is 'non_persistent_child' which is not persistent, and the
> leader region is 'persistent_parent' which is persistent. The sender is
> 'non_persistent_sender' which is not persistent. So, instead of comparing the
> data policy of 'non_persistent_child' to the sender which would succeed since
> they are both not persistent, it compares the data policy of
> 'persistent_parent' to the sender which fails since one is persistent, and
> the other is not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8377) User Guide: GFSH GC command should be documented to use only in non-production environments
[ https://issues.apache.org/jira/browse/GEODE-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163727#comment-17163727 ] ASF subversion and git services commented on GEODE-8377: Commit dcbe8dedb004c64e0b8812293e2220763447b061 in geode's branch refs/heads/support/1.13 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=dcbe8de ] GEODE-8377: User Guide: GFSH GC command should be documented ... (#5396) * GEODE-8377: User Guide: GFSH GC command should be documented to use only in non-production environments > User Guide: GFSH GC command should be documented to use only in > non-production environments > --- > > Key: GEODE-8377 > URL: https://issues.apache.org/jira/browse/GEODE-8377 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > [DWisler] The GSFH GC command is very likely to cause members of GemFire to > be kicked out due to being unresponsive, as this is a forced GC event and not > always handled well by GC outside of normal GC processing. We need to > document that this should only be used in non-production environments, and to > not use it if it causes such issues. We are especially susceptible if > multiple members run on the same vm/host and/or if the number of cpus is > insufficient to handle the “load” needed by GC. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7628) Block jmx mbean creation when no security manager is configured
[ https://issues.apache.org/jira/browse/GEODE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163729#comment-17163729 ] ASF subversion and git services commented on GEODE-7628: Commit 9efd67b1e9a7b0e9f0c8f089a32a89d98487a95b in geode's branch refs/heads/support/1.13 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9efd67b ] GEODE-7628: Block jmx mbean creation when no security manager is configured (docs) (#5387) > Block jmx mbean creation when no security manager is configured > --- > > Key: GEODE-7628 > URL: https://issues.apache.org/jira/browse/GEODE-7628 > Project: Geode > Issue Type: Improvement > Components: jmx >Affects Versions: 1.10.0 >Reporter: Jinmei Liao >Assignee: Ernest Burghardt >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0 > > Time Spent: 10m > Remaining Estimate: 0h > > When no security manager is configured, we should not allow any client to be > able to create mbeans. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8377) User Guide: GFSH GC command should be documented to use only in non-production environments
[ https://issues.apache.org/jira/browse/GEODE-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163726#comment-17163726 ] ASF subversion and git services commented on GEODE-8377: Commit dcbe8dedb004c64e0b8812293e2220763447b061 in geode's branch refs/heads/support/1.13 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=dcbe8de ] GEODE-8377: User Guide: GFSH GC command should be documented ... (#5396) * GEODE-8377: User Guide: GFSH GC command should be documented to use only in non-production environments > User Guide: GFSH GC command should be documented to use only in > non-production environments > --- > > Key: GEODE-8377 > URL: https://issues.apache.org/jira/browse/GEODE-8377 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > [DWisler] The GSFH GC command is very likely to cause members of GemFire to > be kicked out due to being unresponsive, as this is a forced GC event and not > always handled well by GC outside of normal GC processing. We need to > document that this should only be used in non-production environments, and to > not use it if it causes such issues. We are especially susceptible if > multiple members run on the same vm/host and/or if the number of cpus is > insufficient to handle the “load” needed by GC. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-2113) Implement SSL over NIO
[ https://issues.apache.org/jira/browse/GEODE-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163730#comment-17163730 ] ASF subversion and git services commented on GEODE-2113: Commit a9e79b0e6ce0bf1f3fab3f7034c7049017846379 in geode's branch refs/heads/support/1.13 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a9e79b0 ] GEODE-2113: User Guide - p2p.HANDSHAKE_POOL_SIZE is obsolete, remove from docs (#5383) > Implement SSL over NIO > -- > > Key: GEODE-2113 > URL: https://issues.apache.org/jira/browse/GEODE-2113 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Addison >Assignee: Dave Barnes >Priority: Major > Labels: SmallFeature, pull-request-available > Fix For: 1.9.0 > > Time Spent: 5.5h > Remaining Estimate: 0h > > Java now has a nifty javax.net.ssl.SSLSocketFactory that can produce an > SSLSocket from an existing Socket. This will let us create an SSLSocket that > has an NIO SocketChannel and get rid of all of the "Old IO" code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8363) Make docs clear that Micrometer API is experimental
[ https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163728#comment-17163728 ] ASF subversion and git services commented on GEODE-8363: Commit 656b0f1a0b8c28d4aab2ae046027bc2d6e854bc6 in geode's branch refs/heads/support/1.13 from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=656b0f1 ] GEODE-8363: Label Micrometer docs as experimental (#5386) Co-authored-by: Karen Miller > Make docs clear that Micrometer API is experimental > --- > > Key: GEODE-8363 > URL: https://issues.apache.org/jira/browse/GEODE-8363 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > The MetricsSession and MetricsPublishingService interfaces are marked as > experimental. The docs do not make this clear. There is a note at the end of > a subsection to that effect, but it is definitely not prominent. > Make the docs clear that the Micrometer API is experimental by putting a note > in a more prominent place, such as at the beginning of the section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8377) User Guide: GFSH GC command should be documented to use only in non-production environments
[ https://issues.apache.org/jira/browse/GEODE-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163735#comment-17163735 ] ASF subversion and git services commented on GEODE-8377: Commit 5b018349c2b82f28854266e68e5f37e5101d9bc2 in geode's branch refs/heads/support/1.12 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5b01834 ] GEODE-8377: User Guide: GFSH GC command should be documented ... (#5396) * GEODE-8377: User Guide: GFSH GC command should be documented to use only in non-production environments > User Guide: GFSH GC command should be documented to use only in > non-production environments > --- > > Key: GEODE-8377 > URL: https://issues.apache.org/jira/browse/GEODE-8377 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > [DWisler] The GSFH GC command is very likely to cause members of GemFire to > be kicked out due to being unresponsive, as this is a forced GC event and not > always handled well by GC outside of normal GC processing. We need to > document that this should only be used in non-production environments, and to > not use it if it causes such issues. We are especially susceptible if > multiple members run on the same vm/host and/or if the number of cpus is > insufficient to handle the “load” needed by GC. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-2113) Implement SSL over NIO
[ https://issues.apache.org/jira/browse/GEODE-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163739#comment-17163739 ] ASF subversion and git services commented on GEODE-2113: Commit 3fbd2f1f88ef20d59b99c0dc14df98fac489c023 in geode's branch refs/heads/support/1.12 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3fbd2f1 ] GEODE-2113: User Guide - p2p.HANDSHAKE_POOL_SIZE is obsolete, remove from docs (#5383) > Implement SSL over NIO > -- > > Key: GEODE-2113 > URL: https://issues.apache.org/jira/browse/GEODE-2113 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Addison >Assignee: Dave Barnes >Priority: Major > Labels: SmallFeature, pull-request-available > Fix For: 1.9.0 > > Time Spent: 5.5h > Remaining Estimate: 0h > > Java now has a nifty javax.net.ssl.SSLSocketFactory that can produce an > SSLSocket from an existing Socket. This will let us create an SSLSocket that > has an NIO SocketChannel and get rid of all of the "Old IO" code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7628) Block jmx mbean creation when no security manager is configured
[ https://issues.apache.org/jira/browse/GEODE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163738#comment-17163738 ] ASF subversion and git services commented on GEODE-7628: Commit 4e5c4cecb218b25d9330949430b1a3e4873e7496 in geode's branch refs/heads/support/1.12 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4e5c4ce ] GEODE-7628: Block jmx mbean creation when no security manager is configured (docs) (#5387) > Block jmx mbean creation when no security manager is configured > --- > > Key: GEODE-7628 > URL: https://issues.apache.org/jira/browse/GEODE-7628 > Project: Geode > Issue Type: Improvement > Components: jmx >Affects Versions: 1.10.0 >Reporter: Jinmei Liao >Assignee: Ernest Burghardt >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0 > > Time Spent: 10m > Remaining Estimate: 0h > > When no security manager is configured, we should not allow any client to be > able to create mbeans. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8363) Make docs clear that Micrometer API is experimental
[ https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163737#comment-17163737 ] ASF subversion and git services commented on GEODE-8363: Commit 18bda236a76548a72cb2d959d4ebbdb48cd6f1ff in geode's branch refs/heads/support/1.12 from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=18bda23 ] GEODE-8363: Label Micrometer docs as experimental (#5386) Co-authored-by: Karen Miller > Make docs clear that Micrometer API is experimental > --- > > Key: GEODE-8363 > URL: https://issues.apache.org/jira/browse/GEODE-8363 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > The MetricsSession and MetricsPublishingService interfaces are marked as > experimental. The docs do not make this clear. There is a note at the end of > a subsection to that effect, but it is definitely not prominent. > Make the docs clear that the Micrometer API is experimental by putting a note > in a more prominent place, such as at the beginning of the section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8377) User Guide: GFSH GC command should be documented to use only in non-production environments
[ https://issues.apache.org/jira/browse/GEODE-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163736#comment-17163736 ] ASF subversion and git services commented on GEODE-8377: Commit 5b018349c2b82f28854266e68e5f37e5101d9bc2 in geode's branch refs/heads/support/1.12 from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=5b01834 ] GEODE-8377: User Guide: GFSH GC command should be documented ... (#5396) * GEODE-8377: User Guide: GFSH GC command should be documented to use only in non-production environments > User Guide: GFSH GC command should be documented to use only in > non-production environments > --- > > Key: GEODE-8377 > URL: https://issues.apache.org/jira/browse/GEODE-8377 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > [DWisler] The GSFH GC command is very likely to cause members of GemFire to > be kicked out due to being unresponsive, as this is a forced GC event and not > always handled well by GC outside of normal GC processing. We need to > document that this should only be used in non-production environments, and to > not use it if it causes such issues. We are especially susceptible if > multiple members run on the same vm/host and/or if the number of cpus is > insufficient to handle the “load” needed by GC. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8381) User Guide: Reformat table in REST command description
Dave Barnes created GEODE-8381: -- Summary: User Guide: Reformat table in REST command description Key: GEODE-8381 URL: https://issues.apache.org/jira/browse/GEODE-8381 Project: Geode Issue Type: Improvement Components: docs Reporter: Dave Barnes The first table needs format help in this REST command description: [https://geode.apache.org/docs/guide/112/rest_apps/put_update_cas_data.html]. Two of the three columns contain wide content, causing readability issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8381) User Guide: Reformat table in REST command description
[ https://issues.apache.org/jira/browse/GEODE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes reassigned GEODE-8381: -- Assignee: Dave Barnes > User Guide: Reformat table in REST command description > -- > > Key: GEODE-8381 > URL: https://issues.apache.org/jira/browse/GEODE-8381 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > > The first table needs format help in this REST command description: > [https://geode.apache.org/docs/guide/112/rest_apps/put_update_cas_data.html]. > Two of the three columns contain wide content, causing readability issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8366) A non-persistent partitioned region attached to a non-persistent gateway sender throws an exception if its leader co-located region is persistent
[
https://issues.apache.org/jira/browse/GEODE-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Barrett Oglesby resolved GEODE-8366.
Fix Version/s: 1.14.0
Resolution: Fixed
> A non-persistent partitioned region attached to a non-persistent gateway
> sender throws an exception if its leader co-located region is persistent
> -
>
> Key: GEODE-8366
> URL: https://issues.apache.org/jira/browse/GEODE-8366
> Project: Geode
> Issue Type: Bug
> Components: wan
>Reporter: Barrett Oglesby
>Assignee: Barrett Oglesby
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> With this configuration:
> {noformat}
> enable-persistence="false" remote-distributed-system-id="1"/>
>
>
>
> redundant-copies="1"/>
>
>
> {noformat}
> An exception is thrown, and the Cache fails to start.
> The error and exception are:
> {noformat}
> [error 2020/07/16 14:06:59.908 PDT tid=0x1]
> org.apache.geode.internal.cache.wan.GatewaySenderException: Non persistent
> gateway sender non_persistent_sender can not be attached to persistent region
> /persistent_parent
> {noformat}
> {noformat}
> Exception in thread "main"
> org.apache.geode.internal.cache.wan.GatewaySenderException: Non persistent
> gateway sender non_persistent_sender can not be attached to persistent region
> /persistent_parent
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderQueue.java:470)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderQueue.java:459)
> at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderEventProcessor.addShadowPartitionedRegionForUserPR(ParallelGatewaySenderEventProcessor.java:195)
> at
> org.apache.geode.internal.cache.wan.parallel.ConcurrentParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR(ConcurrentParallelGatewaySenderQueue.java:183)
> at
> org.apache.geode.internal.cache.PartitionedRegion.postCreateRegion(PartitionedRegion.java:1201)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.createVMRegion(GemFireCacheImpl.java:3115)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.basicCreateRegion(GemFireCacheImpl.java:2975)
> {noformat}
> The ParallelGatewaySenderQueue.addShadowPartitionedRegionForUserPR method
> currently compares the data policy of the input region's leader region with
> the sender's persistence policy. It assumes the input region and the leader
> region have the same data policy. In this scenario, that is not the case. The
> input region is 'non_persistent_child' which is not persistent, and the
> leader region is 'persistent_parent' which is persistent. The sender is
> 'non_persistent_sender' which is not persistent. So, instead of comparing the
> data policy of 'non_persistent_child' to the sender which would succeed since
> they are both not persistent, it compares the data policy of
> 'persistent_parent' to the sender which fails since one is persistent, and
> the other is not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8377) User Guide: GFSH GC command should be documented to use only in non-production environments
[ https://issues.apache.org/jira/browse/GEODE-8377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes updated GEODE-8377: --- Fix Version/s: 1.12.0 1.13.0 > User Guide: GFSH GC command should be documented to use only in > non-production environments > --- > > Key: GEODE-8377 > URL: https://issues.apache.org/jira/browse/GEODE-8377 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0, 1.13.0, 1.14.0 > > > [DWisler] The GSFH GC command is very likely to cause members of GemFire to > be kicked out due to being unresponsive, as this is a forced GC event and not > always handled well by GC outside of normal GC processing. We need to > document that this should only be used in non-production environments, and to > not use it if it causes such issues. We are especially susceptible if > multiple members run on the same vm/host and/or if the number of cpus is > insufficient to handle the “load” needed by GC. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-923) CI failure: ConnectionManagerJUnitTest.testIdleExpiration
[
https://issues.apache.org/jira/browse/GEODE-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-923:
Description:
Error Message
{noformat}
java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
{noformat}
Stacktrace
{noformat}
java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
com.gemstone.gemfire.cache.client.internal.pooling.ConnectionManagerJUnitTest.testIdleExpiration(ConnectionManagerJUnitTest.java:282)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
at
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at
org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at
org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at
org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
at
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
(noformat}
was:
{noformat}
Error Message
java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
Stacktrace
java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assert
[jira] [Updated] (GEODE-8308) Some formatting text visible in the docs
[ https://issues.apache.org/jira/browse/GEODE-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes updated GEODE-8308: --- Fix Version/s: 1.12.0 1.13.0 > Some formatting text visible in the docs > > > Key: GEODE-8308 > URL: https://issues.apache.org/jira/browse/GEODE-8308 > Project: Geode > Issue Type: Bug > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Fix For: 1.12.0, 1.13.0, 1.14.0 > > > See > [https://geode.apache.org/docs/guide/112/reference/statistics_list.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-923) CI failure: ConnectionManagerJUnitTest.testIdleExpiration
[
https://issues.apache.org/jira/browse/GEODE-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund reassigned GEODE-923:
---
Assignee: Kirk Lund
> CI failure: ConnectionManagerJUnitTest.testIdleExpiration
> -
>
> Key: GEODE-923
> URL: https://issues.apache.org/jira/browse/GEODE-923
> Project: Geode
> Issue Type: Bug
> Components: client/server
>Reporter: Sai Boorlagadda
>Assignee: Kirk Lund
>Priority: Major
> Labels: CI, Flaky
>
> {noformat}
> Error Message
> java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
> Stacktrace
> java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> com.gemstone.gemfire.cache.client.internal.pooling.ConnectionManagerJUnitTest.testIdleExpiration(ConnectionManagerJUnitTest.java:282)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
> at
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:
[jira] [Commented] (GEODE-8316) RollingUpgradeWithGfshDUnitTest > testRollingUpgradeWithDeployment[] FAILED
[
https://issues.apache.org/jira/browse/GEODE-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163755#comment-17163755
]
ASF GitHub Bot commented on GEODE-8316:
---
jinmeiliao merged pull request #5394:
URL: https://github.com/apache/geode/pull/5394
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RollingUpgradeWithGfshDUnitTest > testRollingUpgradeWithDeployment[] FAILED
> ---
>
> Key: GEODE-8316
> URL: https://issues.apache.org/jira/browse/GEODE-8316
> Project: Geode
> Issue Type: Bug
> Components: core
>Reporter: Mark Hanson
>Priority: Major
> Labels: CI, GeodeOperationAPI, pull-request-available
>
> {noformat}
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
> > testRollingUpgradeWithDeployment[1.10.0] FAILED
> 07:26:08java.lang.AssertionError:
> 07:26:08Expecting file:
> 07:26:08
>
> 07:26:08to exist.
> 07:26:08
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
> > testRollingUpgradeWithDeployment[1.11.0] FAILED
> 07:26:08java.lang.AssertionError:
> 07:26:08Expecting file:
> 07:26:08
>
> 07:26:08to exist.
> 07:26:08
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
> > testRollingUpgradeWithDeployment[1.12.0] FAILED
> 07:26:08java.lang.AssertionError:
> 07:26:08Expecting file:
> 07:26:08
>
> 07:26:08to exist.
> 07:26:19 {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8363) Make docs clear that Micrometer API is experimental
[ https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes updated GEODE-8363: --- Fix Version/s: 1.12.0 1.13.0 > Make docs clear that Micrometer API is experimental > --- > > Key: GEODE-8363 > URL: https://issues.apache.org/jira/browse/GEODE-8363 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0, 1.13.0, 1.14.0 > > > The MetricsSession and MetricsPublishingService interfaces are marked as > experimental. The docs do not make this clear. There is a note at the end of > a subsection to that effect, but it is definitely not prominent. > Make the docs clear that the Micrometer API is experimental by putting a note > in a more prominent place, such as at the beginning of the section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-923) CI failure: ConnectionManagerJUnitTest.testIdleExpiration
[
https://issues.apache.org/jira/browse/GEODE-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-923:
Description:
Error Message
{noformat}
java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
{noformat}
Stacktrace
{noformat}
java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at
com.gemstone.gemfire.cache.client.internal.pooling.ConnectionManagerJUnitTest.testIdleExpiration(ConnectionManagerJUnitTest.java:282)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
at
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at
org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at
org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at
org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at
org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
at
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
{noformat}
was:
Error Message
{noformat}
java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
{noformat}
Stacktrace
{noformat}
java.lang.AssertionError: Elapsed 238 is less than idle timeout 300
at org.junit.Assert.fail(Assert.java:88)
at org
[jira] [Updated] (GEODE-8193) Broken link in statistics list
[ https://issues.apache.org/jira/browse/GEODE-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes updated GEODE-8193: --- Fix Version/s: 1.12.0 > Broken link in statistics list > -- > > Key: GEODE-8193 > URL: https://issues.apache.org/jira/browse/GEODE-8193 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Alberto Bustamante Reyes >Assignee: Alberto Bustamante Reyes >Priority: Major > Labels: pull-request-available > Fix For: 1.12.0, 1.13.0, 1.14.0 > > > The link of region entry heap-based eviction is wrong and shows the html > anchor id in the statistics lists: > * Region Entry Eviction - Heap-based eviction > (HeapLRUStatistics)#section_3B74F6FA08A374FBD92AA23047929B4F) > [https://geode.apache.org/docs/guide/112/reference/statistics_list.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8316) RollingUpgradeWithGfshDUnitTest > testRollingUpgradeWithDeployment[] FAILED
[
https://issues.apache.org/jira/browse/GEODE-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163756#comment-17163756
]
ASF subversion and git services commented on GEODE-8316:
Commit a4306dc0d2716ef4a5ca2314bc8e990288a04244 in geode's branch
refs/heads/develop from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a4306dc ]
GEODE-8316: move RollingUpgradeWithGfshDUnitTest to geode-assembly since it
needs to do installDist first. (#5394)
> RollingUpgradeWithGfshDUnitTest > testRollingUpgradeWithDeployment[] FAILED
> ---
>
> Key: GEODE-8316
> URL: https://issues.apache.org/jira/browse/GEODE-8316
> Project: Geode
> Issue Type: Bug
> Components: core
>Reporter: Mark Hanson
>Priority: Major
> Labels: CI, GeodeOperationAPI, pull-request-available
>
> {noformat}
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
> > testRollingUpgradeWithDeployment[1.10.0] FAILED
> 07:26:08java.lang.AssertionError:
> 07:26:08Expecting file:
> 07:26:08
>
> 07:26:08to exist.
> 07:26:08
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
> > testRollingUpgradeWithDeployment[1.11.0] FAILED
> 07:26:08java.lang.AssertionError:
> 07:26:08Expecting file:
> 07:26:08
>
> 07:26:08to exist.
> 07:26:08
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
> > testRollingUpgradeWithDeployment[1.12.0] FAILED
> 07:26:08java.lang.AssertionError:
> 07:26:08Expecting file:
> 07:26:08
>
> 07:26:08to exist.
> 07:26:19 {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8375) No-op test to run Redis API for Geode for local development
[ https://issues.apache.org/jira/browse/GEODE-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darrel Schneider resolved GEODE-8375. - Fix Version/s: 1.14.0 Resolution: Fixed > No-op test to run Redis API for Geode for local development > --- > > Key: GEODE-8375 > URL: https://issues.apache.org/jira/browse/GEODE-8375 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Sarah Abbey >Priority: Trivial > Labels: pull-request-available > Fix For: 1.14.0 > > > No-op test to run Redis API for Geode for local development -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8375) No-op test to run Redis API for Geode for local development
[ https://issues.apache.org/jira/browse/GEODE-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163805#comment-17163805 ] ASF GitHub Bot commented on GEODE-8375: --- dschneider-pivotal merged pull request #5392: URL: https://github.com/apache/geode/pull/5392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No-op test to run Redis API for Geode for local development > --- > > Key: GEODE-8375 > URL: https://issues.apache.org/jira/browse/GEODE-8375 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Sarah Abbey >Priority: Trivial > Labels: pull-request-available > > No-op test to run Redis API for Geode for local development -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8375) No-op test to run Redis API for Geode for local development
[ https://issues.apache.org/jira/browse/GEODE-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163806#comment-17163806 ] ASF subversion and git services commented on GEODE-8375: Commit a322434d854624d9f47a2e044319ca001b499946 in geode's branch refs/heads/develop from Sarah Abbey [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a322434 ] GEODE-8375: No-op test to run Redis server for Geode for local development (#5392) > No-op test to run Redis API for Geode for local development > --- > > Key: GEODE-8375 > URL: https://issues.apache.org/jira/browse/GEODE-8375 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Sarah Abbey >Priority: Trivial > Labels: pull-request-available > Fix For: 1.14.0 > > > No-op test to run Redis API for Geode for local development -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7846) Clear in Partitioned Region should have its own stats
[
https://issues.apache.org/jira/browse/GEODE-7846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163822#comment-17163822
]
ASF GitHub Bot commented on GEODE-7846:
---
DonalEvans commented on a change in pull request #5391:
URL: https://github.com/apache/geode/pull/5391#discussion_r459601065
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java
##
@@ -162,6 +162,7 @@ protected void
waitForPrimary(PartitionedRegion.RetryTimeKeeper retryTimer) {
doAfterClear(regionEvent);
}
}
+incClearCount();
Review comment:
I feel like the calls to `incClearCount()` and `incClearDuration()`
should be made at the same time, since there should be a consistent approach to
when a clear is "done."
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java
##
@@ -367,12 +370,38 @@ void doClear(RegionEventImpl regionEvent, boolean
cacheWrite) {
releaseLockForClear(regionEvent);
}
}
-
} finally {
releaseDistributedClearLock(lockName);
+ incClearDuration(System.nanoTime() - clearStartTime);
+}
+ }
+
+ void incClearCount() {
+if (partitionedRegion != null && partitionedRegion.getDataStore() != null
+&& partitionedRegion.getDataStore().getAllLocalBucketRegions() != null
+&& partitionedRegion.getDataStore().getAllLocalBucketRegions().size()
!= 0) {
+ CachePerfStats stats = partitionedRegion.getCachePerfStats();
+ if (stats != null) {
+logger.info("BR inc PR Region count:" + stats.getClass().getName() +
":"
++ partitionedRegion.getFullPath(), new Exception());
+stats.incClearCount();
+ }
}
}
+ void incClearDuration(long durationNanos) {
+if (partitionedRegion != null &&
partitionedRegion.getTotalNumberOfBuckets() != 0) {
Review comment:
See my other comment about the possibility of hitting the scenario being
checked for. Is it actually possible that we get to where this method is called
and `getTotalNumberOfBuckets()` is zero? If it is, do we want to throw an
exception instead of just quietly not incrementing the stats?
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java
##
@@ -367,12 +370,38 @@ void doClear(RegionEventImpl regionEvent, boolean
cacheWrite) {
releaseLockForClear(regionEvent);
}
}
-
} finally {
releaseDistributedClearLock(lockName);
+ incClearDuration(System.nanoTime() - clearStartTime);
+}
+ }
+
+ void incClearCount() {
+if (partitionedRegion != null && partitionedRegion.getDataStore() != null
+&& partitionedRegion.getDataStore().getAllLocalBucketRegions() != null
+&& partitionedRegion.getDataStore().getAllLocalBucketRegions().size()
!= 0) {
+ CachePerfStats stats = partitionedRegion.getCachePerfStats();
+ if (stats != null) {
+logger.info("BR inc PR Region count:" + stats.getClass().getName() +
":"
++ partitionedRegion.getFullPath(), new Exception());
+stats.incClearCount();
+ }
}
}
+ void incClearDuration(long durationNanos) {
+if (partitionedRegion != null &&
partitionedRegion.getTotalNumberOfBuckets() != 0) {
+ CachePerfStats stats = partitionedRegion.getCachePerfStats();
+ if (stats != null) {
+logger.info("BR inc PR Duration by + " + durationNanos + " ns:" +
stats.getClass().getName()
Review comment:
Remove this logging.
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java
##
@@ -367,12 +370,38 @@ void doClear(RegionEventImpl regionEvent, boolean
cacheWrite) {
releaseLockForClear(regionEvent);
}
}
-
} finally {
releaseDistributedClearLock(lockName);
+ incClearDuration(System.nanoTime() - clearStartTime);
+}
+ }
+
+ void incClearCount() {
+if (partitionedRegion != null && partitionedRegion.getDataStore() != null
+&& partitionedRegion.getDataStore().getAllLocalBucketRegions() != null
+&& partitionedRegion.getDataStore().getAllLocalBucketRegions().size()
!= 0) {
Review comment:
I'm not sure that all these null checks are required. I would think that
if the region is null at this point, then we would expect that something has
gone wrong and that we should throw an exception rather than just silently not
incrementing the stats. Also, I'm not sure I understand why we only increment
the stats if `getAllLocalBucketRegions()` returns a non-empty set. Are there
scenarios where we could call clear, it could complete without an exception,
bringing us to this method, and then `getAllLocalBucketRegions()` returns empty?
##
File path:
geode-core/src/distributedTest/jav
[jira] [Commented] (GEODE-8381) User Guide: Reformat table in REST command description
[ https://issues.apache.org/jira/browse/GEODE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163840#comment-17163840 ] ASF GitHub Bot commented on GEODE-8381: --- davebarnes97 opened a new pull request #5398: URL: https://github.com/apache/geode/pull/5398 Reduced indent size in code samples that were located inside table cells. Allows more space for other columns' contents. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User Guide: Reformat table in REST command description > -- > > Key: GEODE-8381 > URL: https://issues.apache.org/jira/browse/GEODE-8381 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > > The first table needs format help in this REST command description: > [https://geode.apache.org/docs/guide/112/rest_apps/put_update_cas_data.html]. > Two of the three columns contain wide content, causing readability issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8381) User Guide: Reformat table in REST command description
[ https://issues.apache.org/jira/browse/GEODE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8381: -- Labels: pull-request-available (was: ) > User Guide: Reformat table in REST command description > -- > > Key: GEODE-8381 > URL: https://issues.apache.org/jira/browse/GEODE-8381 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > The first table needs format help in this REST command description: > [https://geode.apache.org/docs/guide/112/rest_apps/put_update_cas_data.html]. > Two of the three columns contain wide content, causing readability issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8381) User Guide: Reformat table in REST command description
[ https://issues.apache.org/jira/browse/GEODE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163855#comment-17163855 ] ASF GitHub Bot commented on GEODE-8381: --- davebarnes97 merged pull request #5398: URL: https://github.com/apache/geode/pull/5398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > User Guide: Reformat table in REST command description > -- > > Key: GEODE-8381 > URL: https://issues.apache.org/jira/browse/GEODE-8381 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > The first table needs format help in this REST command description: > [https://geode.apache.org/docs/guide/112/rest_apps/put_update_cas_data.html]. > Two of the three columns contain wide content, causing readability issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8381) User Guide: Reformat table in REST command description
[ https://issues.apache.org/jira/browse/GEODE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163856#comment-17163856 ] ASF subversion and git services commented on GEODE-8381: Commit c3cefe1c7e948f59051ae4941ec09fbb95c4d8ac in geode's branch refs/heads/develop from Dave Barnes [ https://gitbox.apache.org/repos/asf?p=geode.git;h=c3cefe1 ] GEODE-8381: User Guide - Reformat table in REST command description (#5398) > User Guide: Reformat table in REST command description > -- > > Key: GEODE-8381 > URL: https://issues.apache.org/jira/browse/GEODE-8381 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Labels: pull-request-available > > The first table needs format help in this REST command description: > [https://geode.apache.org/docs/guide/112/rest_apps/put_update_cas_data.html]. > Two of the three columns contain wide content, causing readability issues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8293) activeCQCount has negative value
[
https://issues.apache.org/jira/browse/GEODE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163892#comment-17163892
]
ASF GitHub Bot commented on GEODE-8293:
---
agingade commented on a change in pull request #5397:
URL: https://github.com/apache/geode/pull/5397#discussion_r459664869
##
File path:
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.cache.query.cq;
+
+
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.Serializable;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.query.CqAttributes;
+import org.apache.geode.cache.query.CqAttributesFactory;
+import org.apache.geode.cache.query.CqEvent;
+import org.apache.geode.cache.query.CqListener;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.data.Portfolio;
+import org.apache.geode.management.DistributedSystemMXBean;
+import org.apache.geode.management.ManagementService;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+
+public class CQMetricsDUnitTest {
Review comment:
The functionality here is related to accessing stat using mbean; these
tests are under "management" package. There is one test
"CacheServerManagementTest", can this be added here. Or move this test to
management package.
##
File path:
geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/ServerCQImpl.java
##
@@ -367,10 +367,12 @@ public void close(boolean sendRequestToServer) throws
CqClosedException, CqExcep
this.removeFromCqMap();
// Stat update.
- if (stateBeforeClosing == CqStateImpl.RUNNING) {
-cqService.stats().decCqsActive();
- } else if (stateBeforeClosing == CqStateImpl.STOPPED) {
-cqService.stats().decCqsStopped();
+ if (!cqName.equals(serverCqName)) {
Review comment:
How is this change addressing the issue. The CqName and serverCqName is
not same on the server side CQ representation. As this class represent server
side, when the CQ execution (close) comes here the cqName should not be the
same, isn't the case, here...Please help us to understand the context/stack
where you are seeing this check is needed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> activeCQCount has negative value
>
>
> Key: GEODE-8293
> URL: https://issues.apache.org/jira/browse/GEODE-8293
> Project: Geode
> Issue Type: Bug
> Components: statistics
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
> Labels: pull-request-available
>
> In case you have more than one server in the system and you close CQ there
> will be negative value of active cqs.
> The problem is when you started more than one server and execute cq on it. In
> that case we got incCqsActive on one server, but when it is closed we have
> decCqsActive on both servers.
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide MetricsCategory | Metric | Value
> | | -
> query| activeCQCount| 1
> | queryRequestRate | 0.0
> {code}
> After cq is closed or stopped:
> {code:java}
> gfsh>show metrics --catego
[jira] [Commented] (GEODE-8331) allow GFSH to connect to newer and older locator/server.
[ https://issues.apache.org/jira/browse/GEODE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164030#comment-17164030 ] ASF GitHub Bot commented on GEODE-8331: --- jinmeiliao opened a new pull request #5399: URL: https://github.com/apache/geode/pull/5399 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > allow GFSH to connect to newer and older locator/server. > > > Key: GEODE-8331 > URL: https://issues.apache.org/jira/browse/GEODE-8331 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jinmei Liao >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > When using an older or newer gfsh to connect to an older or newer distributed > system gfsh will throw a warning error and not connect. > Example warning message Cannot use a 9.8.5 gfsh client to connect to a 9.9.0 > cluster.. > The desired behavior is to allow gfsh connect and only if there is an issue > with an updated /unknown command parsing should the system throw an error and > provide the extra guidance of what version the servers are at and the version > of the current gfsh cli. > Initially add these capability into the newer product version > Later based on the feasibility of adding this to older version, this will be > ported into the older version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8331) allow GFSH to connect to newer and older locator/server.
[ https://issues.apache.org/jira/browse/GEODE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164031#comment-17164031 ] ASF GitHub Bot commented on GEODE-8331: --- jinmeiliao closed pull request #5399: URL: https://github.com/apache/geode/pull/5399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > allow GFSH to connect to newer and older locator/server. > > > Key: GEODE-8331 > URL: https://issues.apache.org/jira/browse/GEODE-8331 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jinmei Liao >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > When using an older or newer gfsh to connect to an older or newer distributed > system gfsh will throw a warning error and not connect. > Example warning message Cannot use a 9.8.5 gfsh client to connect to a 9.9.0 > cluster.. > The desired behavior is to allow gfsh connect and only if there is an issue > with an updated /unknown command parsing should the system throw an error and > provide the extra guidance of what version the servers are at and the version > of the current gfsh cli. > Initially add these capability into the newer product version > Later based on the feasibility of adding this to older version, this will be > ported into the older version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8331) allow GFSH to connect to newer and older locator/server.
[ https://issues.apache.org/jira/browse/GEODE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164032#comment-17164032 ] ASF subversion and git services commented on GEODE-8331: Commit 903eff973128a9995e66decdd1b5be89172f55f9 in geode's branch refs/heads/support/1.13 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=903eff9 ] GEODE-8331: allow GFSH to connect to other versions of cluster (#5375) > allow GFSH to connect to newer and older locator/server. > > > Key: GEODE-8331 > URL: https://issues.apache.org/jira/browse/GEODE-8331 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jinmei Liao >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > When using an older or newer gfsh to connect to an older or newer distributed > system gfsh will throw a warning error and not connect. > Example warning message Cannot use a 9.8.5 gfsh client to connect to a 9.9.0 > cluster.. > The desired behavior is to allow gfsh connect and only if there is an issue > with an updated /unknown command parsing should the system throw an error and > provide the extra guidance of what version the servers are at and the version > of the current gfsh cli. > Initially add these capability into the newer product version > Later based on the feasibility of adding this to older version, this will be > ported into the older version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8331) allow GFSH to connect to newer and older locator/server.
[ https://issues.apache.org/jira/browse/GEODE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164034#comment-17164034 ] ASF subversion and git services commented on GEODE-8331: Commit 8ed3da354299253c30efd03fca3d7b55dcfc7a9c in geode's branch refs/heads/support/1.13 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=8ed3da3 ] Revert "GEODE-8331: allow GFSH to connect to other versions of cluster (#5375)" This reverts commit 903eff97 > allow GFSH to connect to newer and older locator/server. > > > Key: GEODE-8331 > URL: https://issues.apache.org/jira/browse/GEODE-8331 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jinmei Liao >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > When using an older or newer gfsh to connect to an older or newer distributed > system gfsh will throw a warning error and not connect. > Example warning message Cannot use a 9.8.5 gfsh client to connect to a 9.9.0 > cluster.. > The desired behavior is to allow gfsh connect and only if there is an issue > with an updated /unknown command parsing should the system throw an error and > provide the extra guidance of what version the servers are at and the version > of the current gfsh cli. > Initially add these capability into the newer product version > Later based on the feasibility of adding this to older version, this will be > ported into the older version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7888) CI Failure: AlterRuntimeCommandDistributedTest.alterStatArchiveFileWithMember_updatesSelectedServerConfigs(false) failed
[
https://issues.apache.org/jira/browse/GEODE-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164053#comment-17164053
]
Bill Burcham commented on GEODE-7888:
-
different method, same class
{code:java}
> Task :geode-web:distributedTest
org.apache.geode.management.internal.cli.commands.AlterRuntimeCommandDistributedTest
> alterArchiveDiskSpaceLimitRangeIsEnforced(false) [1] FAILED
java.lang.AssertionError: Suspicious strings were written to the log during
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 878
[fatal 2020/07/23 21:15:31.437 GMT
tid=2401] Unknown handshake reply code: 0 messageLength: 90
122 tests completed, 1 failed
{code}
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsGfshDistributedTestOpenJDK8/builds/358
> CI Failure:
> AlterRuntimeCommandDistributedTest.alterStatArchiveFileWithMember_updatesSelectedServerConfigs(false)
> failed
>
>
> Key: GEODE-7888
> URL: https://issues.apache.org/jira/browse/GEODE-7888
> Project: Geode
> Issue Type: Bug
> Components: ci
>Reporter: Eric Shu
>Priority: Major
>
> Failed in WindowsGfshDistributedTestOpenJDK11 pipeline:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsGfshDistributedTestOpenJDK11/builds/1386
> org.apache.geode.management.internal.cli.commands.AlterRuntimeCommandDistributedTest
> > alterStatArchiveFileWithMember_updatesSelectedServerConfigs(false) [1]
> FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 810
> [fatal 2020/03/17 19:53:11.437 GMT
> tid=3647] Unknown handshake reply code: 0 messageLength: 90
> Artifacts are in:
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.13.0-SNAPSHOT.0100/test-results/distributedTest/1584476616/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.13.0-SNAPSHOT.0100/test-artifacts/1584476616/windows-gfshdistributedtest-OpenJDK11-1.13.0-SNAPSHOT.0100.tgz
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
