[jira] [Created] (GEODE-8369) Do not build docker images on Windows

2020-07-20 Thread Jens Deppe (Jira) 
Jens Deppe created GEODE-8369:
-

 Summary: Do not build docker images on Windows
 Key: GEODE-8369
 URL: https://issues.apache.org/jira/browse/GEODE-8369
 Project: Geode
  Issue Type: Test
  Components: tests
Reporter: Jens Deppe


The {{geode-assembly:acceptanceTest}} task builds a docker image, before the 
tests start, for use by tests. This step recently broke since the upstream 
openjdk bas container didn't seem to support the version of Windows we run. 
Since we don't run dockerized tests on Windows in any case this step is not 
necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8369) Do not build docker images on Windows

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161302#comment-17161302
 ] 

ASF GitHub Bot commented on GEODE-8369:
---

jdeppe-pivotal opened a new pull request #5384:
URL: https://github.com/apache/geode/pull/5384


   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Do not build docker images on Windows
> -
>
> Key: GEODE-8369
> URL: https://issues.apache.org/jira/browse/GEODE-8369
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Jens Deppe
>Priority: Major
>
> The {{geode-assembly:acceptanceTest}} task builds a docker image, before the 
> tests start, for use by tests. This step recently broke since the upstream 
> openjdk bas container didn't seem to support the version of Windows we run. 
> Since we don't run dockerized tests on Windows in any case this step is not 
> necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8369) Do not build docker images on Windows

2020-07-20 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8369:
--
Labels: pull-request-available  (was: )

> Do not build docker images on Windows
> -
>
> Key: GEODE-8369
> URL: https://issues.apache.org/jira/browse/GEODE-8369
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> The {{geode-assembly:acceptanceTest}} task builds a docker image, before the 
> tests start, for use by tests. This step recently broke since the upstream 
> openjdk bas container didn't seem to support the version of Windows we run. 
> Since we don't run dockerized tests on Windows in any case this step is not 
> necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8298) member version comparison sense inconsistent when deciding on multicast

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161327#comment-17161327
 ] 

ASF GitHub Bot commented on GEODE-8298:
---

Bill merged pull request #5370:
URL: https://github.com/apache/geode/pull/5370


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> member version comparison sense inconsistent when deciding on multicast
> ---
>
> Key: GEODE-8298
> URL: https://issues.apache.org/jira/browse/GEODE-8298
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bill Burcham
>Assignee: Kamilla Aslami
>Priority: Major
>  Labels: pull-request-available, starter
>
> Since about 2014 when we introduced the {{Version}} class to replace use of 
> {{short}} s all over the place for serialization versions, these two loops in 
> {{GMSMembership.processView()}} have used comparisons that disagree in sense:
> {code}
> // We perform the update under a global lock so that other
> // incoming events will not be lost in terms of our global view.
> latestViewWriteLock.lock();
> try {
>   // first determine the version for multicast message serialization
>   VersionOrdinal version = Version.CURRENT;
>   for (final Entry internalIDLongEntry : surpriseMembers
>   .entrySet()) {
> ID mbr = internalIDLongEntry.getKey();
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && version.compareTo(itsVersion) < 0) {
>   version = itsVersion;
> }
>   }
>   for (ID mbr : newView.getMembers()) {
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && itsVersion.compareTo(version) < 0) {
>   version = mbr.getVersionObject();
> }
>   }
>   disableMulticastForRollingUpgrade = !version.equals(Version.CURRENT);
> {code}
> The goal here is to find the oldest version and if that version is older than 
> our local version we disable multicast. So we want to put the minimum into 
> {{version}}. So the first loop's comparison is wrong and the second one is 
> right.
> While we are in here let's combine the two loops using 
> {{Stream.concat(surpriseMembers.entrySet().stream().map(entry->entry.getKey()),
>   newView.getMembers().stream()).forEach(member -> ...)}}.
> Alternatives are described here: 
> https://www.baeldung.com/java-combine-multiple-collections
> Once we have the combined {{Iterable}} we can use something like 
> {{Collections.min()}} to find the minimum in one swell foop and this whole 
> thing collapses to one or two declarative expressions.
> When this story is complete, the functionality will be in a separate method 
> and we'll have a unit test for it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8298) member version comparison sense inconsistent when deciding on multicast

2020-07-20 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161328#comment-17161328
 ] 

ASF subversion and git services commented on GEODE-8298:


Commit fd76cc0b7dbf97dfb84d11e67b37e33c0a9e7fb2 in geode's branch 
refs/heads/develop from Kamilla Aslami
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fd76cc0 ]

GEODE-8298: Fix multicast version detection (#5370)

Membership decides whether or not use multicast based on the versions
of view members and surprise members. Surprise member version comparison
was backward. Correct version comparison by unifying view and surprise
member processing.

Co-authored-by: Kamilla Aslami 
Co-authored-by: Bill Burcham 

> member version comparison sense inconsistent when deciding on multicast
> ---
>
> Key: GEODE-8298
> URL: https://issues.apache.org/jira/browse/GEODE-8298
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bill Burcham
>Assignee: Kamilla Aslami
>Priority: Major
>  Labels: pull-request-available, starter
>
> Since about 2014 when we introduced the {{Version}} class to replace use of 
> {{short}} s all over the place for serialization versions, these two loops in 
> {{GMSMembership.processView()}} have used comparisons that disagree in sense:
> {code}
> // We perform the update under a global lock so that other
> // incoming events will not be lost in terms of our global view.
> latestViewWriteLock.lock();
> try {
>   // first determine the version for multicast message serialization
>   VersionOrdinal version = Version.CURRENT;
>   for (final Entry internalIDLongEntry : surpriseMembers
>   .entrySet()) {
> ID mbr = internalIDLongEntry.getKey();
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && version.compareTo(itsVersion) < 0) {
>   version = itsVersion;
> }
>   }
>   for (ID mbr : newView.getMembers()) {
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && itsVersion.compareTo(version) < 0) {
>   version = mbr.getVersionObject();
> }
>   }
>   disableMulticastForRollingUpgrade = !version.equals(Version.CURRENT);
> {code}
> The goal here is to find the oldest version and if that version is older than 
> our local version we disable multicast. So we want to put the minimum into 
> {{version}}. So the first loop's comparison is wrong and the second one is 
> right.
> While we are in here let's combine the two loops using 
> {{Stream.concat(surpriseMembers.entrySet().stream().map(entry->entry.getKey()),
>   newView.getMembers().stream()).forEach(member -> ...)}}.
> Alternatives are described here: 
> https://www.baeldung.com/java-combine-multiple-collections
> Once we have the combined {{Iterable}} we can use something like 
> {{Collections.min()}} to find the minimum in one swell foop and this whole 
> thing collapses to one or two declarative expressions.
> When this story is complete, the functionality will be in a separate method 
> and we'll have a unit test for it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161335#comment-17161335
 ] 

ASF GitHub Bot commented on GEODE-7670:
---

DonalEvans commented on a change in pull request #4848:
URL: https://github.com/apache/geode/pull/4848#discussion_r457469700



##
File path: 
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithConcurrentOperationsDUnitTest.java
##
@@ -0,0 +1,733 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.apache.geode.internal.util.ArrayUtils.asList;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.dunit.VM.getVM;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import java.io.Serializable;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.IntStream;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import junitparams.naming.TestCaseName;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.ForcedDisconnectException;
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.PartitionAttributes;
+import org.apache.geode.cache.PartitionAttributesFactory;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.partition.PartitionRegionHelper;
+import org.apache.geode.distributed.DistributedSystemDisconnectedException;
+import org.apache.geode.distributed.internal.ClusterDistributionManager;
+import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.distributed.internal.DistributionMessage;
+import org.apache.geode.distributed.internal.DistributionMessageObserver;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import 
org.apache.geode.distributed.internal.membership.api.MembershipManagerHelper;
+import org.apache.geode.internal.cache.versions.RegionVersionHolder;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionSource;
+import org.apache.geode.test.dunit.AsyncInvocation;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.rules.CacheRule;
+import org.apache.geode.test.dunit.rules.DistributedRule;
+
+/**
+ * Tests to verify that {@link PartitionedRegion#clear()} operation can be 
executed multiple times
+ * on the same region while other cache operations are being executed 
concurrently and members are
+ * added or removed.
+ */
+@RunWith(JUnitParamsRunner.class)
+public class PartitionedRegionClearWithConcurrentOperationsDUnitTest 
implements Serializable {
+  private static final Integer BUCKETS = 13;
+  private static final String REGION_NAME = "PartitionedRegion";
+  private static final String TEST_CASE_NAME =
+  "[{index}] {method}(Coordinator:{0}, RegionType:{1})";
+
+  @Rule
+  public DistributedRule distributedRule = new DistributedRule(3);
+
+  @Rule
+  public CacheRule cacheRule = CacheRule.builder().createCacheInAll().build();
+
+  private VM accessor, server1, server2;

Review comment:
   It's recommended not to declare multiple variables inline, so this 
should ideally be split into three separate lines.

##
File path: 
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithConcurrentOperationsDUnitTest.java
##
@@ -0,0 +1,733 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you

[jira] [Commented] (GEODE-8369) Do not build docker images on Windows

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161347#comment-17161347
 ] 

ASF GitHub Bot commented on GEODE-8369:
---

rhoughton-pivot merged pull request #5384:
URL: https://github.com/apache/geode/pull/5384


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Do not build docker images on Windows
> -
>
> Key: GEODE-8369
> URL: https://issues.apache.org/jira/browse/GEODE-8369
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> The {{geode-assembly:acceptanceTest}} task builds a docker image, before the 
> tests start, for use by tests. This step recently broke since the upstream 
> openjdk bas container didn't seem to support the version of Windows we run. 
> Since we don't run dockerized tests on Windows in any case this step is not 
> necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8369) Do not build docker images on Windows

2020-07-20 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161348#comment-17161348
 ] 

ASF subversion and git services commented on GEODE-8369:


Commit 25c15e94983c14a6947e0268989388ff4e4967de in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=25c15e9 ]

GEODE-8369: Do not build docker images on Windows for 
geode-assembly:acceptanceTest (#5384)



> Do not build docker images on Windows
> -
>
> Key: GEODE-8369
> URL: https://issues.apache.org/jira/browse/GEODE-8369
> Project: Geode
>  Issue Type: Test
>  Components: tests
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> The {{geode-assembly:acceptanceTest}} task builds a docker image, before the 
> tests start, for use by tests. This step recently broke since the upstream 
> openjdk bas container didn't seem to support the version of Windows we run. 
> Since we don't run dockerized tests on Windows in any case this step is not 
> necessary.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GEODE-8359) Server logs NPE as a warning while processing RegisterInterestList requests from clients during (server) shutdown

2020-07-20 Thread Mark Hanson (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Hanson resolved GEODE-8359.

  Assignee: Mark Hanson
Resolution: Fixed

This has been merged to develop.

> Server logs NPE as a warning while processing RegisterInterestList requests 
> from clients during (server) shutdown
> -
>
> Key: GEODE-8359
> URL: https://issues.apache.org/jira/browse/GEODE-8359
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Mark Hanson
>Assignee: Mark Hanson
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Getting a null pointer exception  when RegisterinterestList is called during 
> shutdown.
> {noformat}
> at 
> org.apache.geode.internal.cache.tier.sockets.command.RegisterInterestList66.cmdExecute(RegisterInterestList66.java:188)
>   at 
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:183)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMessage(ServerConnection.java:848)
>   at 
> org.apache.geode.internal.cache.tier.sockets.OriginalServerConnection.doOneMessage(OriginalServerConnection.java:72)
>   at 
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1181)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at 
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.lambda$initializeServerConnectionThreadPool$3(AcceptorImpl.java:676)
>   at 
> org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:119)
>   at java.lang.Thread.run(Thread.java:748) {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GEODE-8337) Rename Version enum to KnownVersion; VersionOrdinal to Version

2020-07-20 Thread Bill Burcham (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bill Burcham resolved GEODE-8337.
-
Fix Version/s: 1.14.0
   Resolution: Fixed

> Rename Version enum to KnownVersion; VersionOrdinal to Version
> --
>
> Key: GEODE-8337
> URL: https://issues.apache.org/jira/browse/GEODE-8337
> Project: Geode
>  Issue Type: Improvement
>  Components: serialization
>Reporter: Bill Burcham
>Assignee: Bill Burcham
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> As a follow-on to GEODE-8240 and GEODE-8330, this is the final ticket, to 
> rename:
> {{Version}} -> {{KnownVersion}}
> {{VersionOrdinal}} -> {{Version}}
> With this ticket, the work started in GEODE-8240 is complete.
> After this change, the versioning hierarchy will be:
>  !screenshot-1.png! 
> Before this change, the hierarchy was:
>  !screenshot-2.png! 
> As part of this story we'll also harmonize version access methods on 
> MemberIdentifier, InternalDistributedMember, and GMSMemberData:
> getVersionOrdinalObject() becomes getVersion()
> On GMSMemberData:
> setVersionObjectForTest() becomes setVersionForTest()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GEODE-8298) member version comparison sense inconsistent when deciding on multicast

2020-07-20 Thread Bill Burcham (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bill Burcham resolved GEODE-8298.
-
Fix Version/s: 1.14.0
   Resolution: Fixed

> member version comparison sense inconsistent when deciding on multicast
> ---
>
> Key: GEODE-8298
> URL: https://issues.apache.org/jira/browse/GEODE-8298
> Project: Geode
>  Issue Type: Bug
>  Components: membership
>Reporter: Bill Burcham
>Assignee: Kamilla Aslami
>Priority: Major
>  Labels: pull-request-available, starter
> Fix For: 1.14.0
>
>
> Since about 2014 when we introduced the {{Version}} class to replace use of 
> {{short}} s all over the place for serialization versions, these two loops in 
> {{GMSMembership.processView()}} have used comparisons that disagree in sense:
> {code}
> // We perform the update under a global lock so that other
> // incoming events will not be lost in terms of our global view.
> latestViewWriteLock.lock();
> try {
>   // first determine the version for multicast message serialization
>   VersionOrdinal version = Version.CURRENT;
>   for (final Entry internalIDLongEntry : surpriseMembers
>   .entrySet()) {
> ID mbr = internalIDLongEntry.getKey();
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && version.compareTo(itsVersion) < 0) {
>   version = itsVersion;
> }
>   }
>   for (ID mbr : newView.getMembers()) {
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && itsVersion.compareTo(version) < 0) {
>   version = mbr.getVersionObject();
> }
>   }
>   disableMulticastForRollingUpgrade = !version.equals(Version.CURRENT);
> {code}
> The goal here is to find the oldest version and if that version is older than 
> our local version we disable multicast. So we want to put the minimum into 
> {{version}}. So the first loop's comparison is wrong and the second one is 
> right.
> While we are in here let's combine the two loops using 
> {{Stream.concat(surpriseMembers.entrySet().stream().map(entry->entry.getKey()),
>   newView.getMembers().stream()).forEach(member -> ...)}}.
> Alternatives are described here: 
> https://www.baeldung.com/java-combine-multiple-collections
> Once we have the combined {{Iterable}} we can use something like 
> {{Collections.min()}} to find the minimum in one swell foop and this whole 
> thing collapses to one or two declarative expressions.
> When this story is complete, the functionality will be in a separate method 
> and we'll have a unit test for it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-6950) Locator can't start if a lot of clients already started

2020-07-20 Thread Bill Burcham (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bill Burcham updated GEODE-6950:

Component/s: membership

> Locator can't start if a lot of clients already started
> ---
>
> Key: GEODE-6950
> URL: https://issues.apache.org/jira/browse/GEODE-6950
> Project: Geode
>  Issue Type: Bug
>  Components: core, membership
>Affects Versions: 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.11.0, 1.12.0
>Reporter: Eugene Nedzvetsky
>Priority: Major
> Attachments: 1.log
>
>
> Locator can't start if a few hundred clients already started.
> Steps to reproduce:
> 1. Start Locator
> 2. Start 300 Geode clients
> 3. Stop Locator
> 4. Start Locator again
> Observe 100% CPU load and after some time Locator app crashes with timeout 
> exceptions in the log.
> The problem is in the method 
> org.apache.geode.distributed.internal.InternalLocator.PrimaryHandler#processRequest
> handlerMapping doesn't have handlers for LocatorListRequest and 
> ClientConnectionRequest requests on Locator startup and in this case work 
> code part with condition 'if(giveup == 0)'(InternalLocator:1185)
> Pause Thread.sleep(1000) works only on the first iteration and after that 
> giveup>0 and CPU just spends resources on cycle execution without any pauses.
> Call Thread.sleep(1000)  should be after if(giveup>0) condition block. It 
> will be called on each iteration in this case.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GEODE-8360) Revert GEODE-7384 to resolve HANG

2020-07-20 Thread Xiaojian Zhou (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiaojian Zhou resolved GEODE-8360.
--
Resolution: Not A Problem

We confirmed GEODE-7384 is not the root cause of the HANG. So close the ticket. 

> Revert GEODE-7384 to resolve HANG
> -
>
> Key: GEODE-8360
> URL: https://issues.apache.org/jira/browse/GEODE-8360
> Project: Geode
>  Issue Type: Improvement
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7384) OldId from the same distributed member should be removed when processing the dm's PrepareNewPersistentMemberMessage

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161419#comment-17161419
 ] 

ASF GitHub Bot commented on GEODE-7384:
---

gesterzhou closed pull request #5372:
URL: https://github.com/apache/geode/pull/5372


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> OldId from the same distributed member should be removed when processing the 
> dm's PrepareNewPersistentMemberMessage
> ---
>
> Key: GEODE-7384
> URL: https://issues.apache.org/jira/browse/GEODE-7384
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.1.0
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
>  Labels: GeodeCommons
> Fix For: 1.11.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The old id is being removed only if the PersistenceAdvisorImpl is initialized 
> when processing the message. However, this could lead to two 
> PersistentMemberIDs from the same member being persisted and there is no way 
> that the old id can be removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-7384) OldId from the same distributed member should be removed when processing the dm's PrepareNewPersistentMemberMessage

2020-07-20 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-7384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-7384:
--
Labels: GeodeCommons pull-request-available  (was: GeodeCommons)

> OldId from the same distributed member should be removed when processing the 
> dm's PrepareNewPersistentMemberMessage
> ---
>
> Key: GEODE-7384
> URL: https://issues.apache.org/jira/browse/GEODE-7384
> Project: Geode
>  Issue Type: Bug
>  Components: persistence
>Affects Versions: 1.1.0
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
> Fix For: 1.11.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The old id is being removed only if the PersistenceAdvisorImpl is initialized 
> when processing the message. However, this could lead to two 
> PersistentMemberIDs from the same member being persisted and there is no way 
> that the old id can be removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (GEODE-8370) Add test for maxInactiveInterval

2020-07-20 Thread Sarah Abbey (Jira) 
Sarah Abbey created GEODE-8370:
--

 Summary: Add test for maxInactiveInterval
 Key: GEODE-8370
 URL: https://issues.apache.org/jira/browse/GEODE-8370
 Project: Geode
  Issue Type: Test
  Components: redis, tests
Reporter: Sarah Abbey


Write test verifying that maxInactiveInterval propagates correctly to all 
buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8370) Add test for maxInactiveInterval

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161428#comment-17161428
 ] 

ASF GitHub Bot commented on GEODE-8370:
---

sabbeyPivotal opened a new pull request #5385:
URL: https://github.com/apache/geode/pull/5385


   Write test verifying that maxInactiveInterval propagates correctly to all 
buckets



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add test for maxInactiveInterval
> 
>
> Key: GEODE-8370
> URL: https://issues.apache.org/jira/browse/GEODE-8370
> Project: Geode
>  Issue Type: Test
>  Components: redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>
> Write test verifying that maxInactiveInterval propagates correctly to all 
> buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8370) Add test for maxInactiveInterval

2020-07-20 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8370:
--
Labels: pull-request-available  (was: )

> Add test for maxInactiveInterval
> 
>
> Key: GEODE-8370
> URL: https://issues.apache.org/jira/browse/GEODE-8370
> Project: Geode
>  Issue Type: Test
>  Components: redis, tests
>Reporter: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> Write test verifying that maxInactiveInterval propagates correctly to all 
> buckets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8363) Make docs clear that Micrometer API is experimental

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161498#comment-17161498
 ] 

ASF GitHub Bot commented on GEODE-8363:
---

karensmolermiller opened a new pull request #5386:
URL: https://github.com/apache/geode/pull/5386


   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make docs clear that Micrometer API is experimental
> ---
>
> Key: GEODE-8363
> URL: https://issues.apache.org/jira/browse/GEODE-8363
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>
> The MetricsSession and MetricsPublishingService interfaces are marked as 
> experimental. The docs do not make this clear.  There is a note at the end of 
> a subsection to that effect, but it is definitely not prominent.
> Make the docs clear that the Micrometer API is experimental by putting a note 
> in a more prominent place, such as at the beginning of the section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8363) Make docs clear that Micrometer API is experimental

2020-07-20 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8363:
--
Labels: pull-request-available  (was: )

> Make docs clear that Micrometer API is experimental
> ---
>
> Key: GEODE-8363
> URL: https://issues.apache.org/jira/browse/GEODE-8363
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>  Labels: pull-request-available
>
> The MetricsSession and MetricsPublishingService interfaces are marked as 
> experimental. The docs do not make this clear.  There is a note at the end of 
> a subsection to that effect, but it is definitely not prominent.
> Make the docs clear that the Micrometer API is experimental by putting a note 
> in a more prominent place, such as at the beginning of the section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8363) Make docs clear that Micrometer API is experimental

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161508#comment-17161508
 ] 

ASF GitHub Bot commented on GEODE-8363:
---

karensmolermiller merged pull request #5386:
URL: https://github.com/apache/geode/pull/5386


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make docs clear that Micrometer API is experimental
> ---
>
> Key: GEODE-8363
> URL: https://issues.apache.org/jira/browse/GEODE-8363
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>  Labels: pull-request-available
>
> The MetricsSession and MetricsPublishingService interfaces are marked as 
> experimental. The docs do not make this clear.  There is a note at the end of 
> a subsection to that effect, but it is definitely not prominent.
> Make the docs clear that the Micrometer API is experimental by putting a note 
> in a more prominent place, such as at the beginning of the section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GEODE-8363) Make docs clear that Micrometer API is experimental

2020-07-20 Thread Karen Smoler Miller (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karen Smoler Miller resolved GEODE-8363.

Fix Version/s: 1.14.0
   Resolution: Fixed

> Make docs clear that Micrometer API is experimental
> ---
>
> Key: GEODE-8363
> URL: https://issues.apache.org/jira/browse/GEODE-8363
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> The MetricsSession and MetricsPublishingService interfaces are marked as 
> experimental. The docs do not make this clear.  There is a note at the end of 
> a subsection to that effect, but it is definitely not prominent.
> Make the docs clear that the Micrometer API is experimental by putting a note 
> in a more prominent place, such as at the beginning of the section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8363) Make docs clear that Micrometer API is experimental

2020-07-20 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161509#comment-17161509
 ] 

ASF subversion and git services commented on GEODE-8363:


Commit 1067f4545c344d16314fc803264cee793e082416 in geode's branch 
refs/heads/develop from Karen Miller
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1067f45 ]

GEODE-8363: Label Micrometer docs as experimental (#5386)

Co-authored-by: Karen Miller 

> Make docs clear that Micrometer API is experimental
> ---
>
> Key: GEODE-8363
> URL: https://issues.apache.org/jira/browse/GEODE-8363
> Project: Geode
>  Issue Type: Improvement
>  Components: docs
>Reporter: Karen Smoler Miller
>Assignee: Karen Smoler Miller
>Priority: Major
>  Labels: pull-request-available
>
> The MetricsSession and MetricsPublishingService interfaces are marked as 
> experimental. The docs do not make this clear.  There is a note at the end of 
> a subsection to that effect, but it is definitely not prominent.
> Make the docs clear that the Micrometer API is experimental by putting a note 
> in a more prominent place, such as at the beginning of the section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7628) Block jmx mbean creation when no security manager is configured

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161513#comment-17161513
 ] 

ASF GitHub Bot commented on GEODE-7628:
---

davebarnes97 opened a new pull request #5387:
URL: https://github.com/apache/geode/pull/5387


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Block jmx mbean creation when no security manager is configured
> ---
>
> Key: GEODE-7628
> URL: https://issues.apache.org/jira/browse/GEODE-7628
> Project: Geode
>  Issue Type: Improvement
>  Components: jmx
>Affects Versions: 1.10.0
>Reporter: Jinmei Liao
>Assignee: Ernest Burghardt
>Priority: Major
> Fix For: 1.12.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When no security manager is configured, we should not allow any client to be 
> able to create mbeans.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-7628) Block jmx mbean creation when no security manager is configured

2020-07-20 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-7628:
--
Labels: pull-request-available  (was: )

> Block jmx mbean creation when no security manager is configured
> ---
>
> Key: GEODE-7628
> URL: https://issues.apache.org/jira/browse/GEODE-7628
> Project: Geode
>  Issue Type: Improvement
>  Components: jmx
>Affects Versions: 1.10.0
>Reporter: Jinmei Liao
>Assignee: Ernest Burghardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When no security manager is configured, we should not allow any client to be 
> able to create mbeans.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (GEODE-7603) RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers

2020-07-20 Thread Kirk Lund (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-7603:


Assignee: Benjamin P Ross

> RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers
> 
>
> Key: GEODE-7603
> URL: https://issues.apache.org/jira/browse/GEODE-7603
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: flaky
>
> RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers
>  failed twice as a part of the mass test run.
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/2160]
>  
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/2130]
>  
> {noformat}
> 10:56:44org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest
>  > testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers FAILED
> 10:56:44java.lang.AssertionError: [List check last element] 
> 10:56:44Expecting:
> 10:56:44 <"0">
> 10:56:44not to be equal to:
> 10:56:44 <"0">
> 10:56:44at 
> org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest.assertPrimariesTransfered(RepeatedRebalanceDUnitTest.java:204)
> 10:56:44at 
> org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers(RepeatedRebalanceDUnitTest.java:124)
> 11:06:20
> 11:06:20352 tests completed, 1 failed, 5 skipped
> 11:06:22
> 11:06:22> Task :geode-gfsh:distributedTest FAILED
> 11:54:40
> 11:54:40> Task :geode-core:distributedTest
> 11:54:40{noformat}
>  
> {noformat}
> 22:06:33org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest
>  > testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers FAILED
> 22:06:33java.lang.AssertionError: [List check last element] 
> 22:06:33Expecting:
> 22:06:33 <"0">
> 22:06:33not to be equal to:
> 22:06:33 <"0">
> 22:06:33at 
> org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest.assertPrimariesTransfered(RepeatedRebalanceDUnitTest.java:204)
> 22:06:33at 
> org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers(RepeatedRebalanceDUnitTest.java:124)
> 22:16:05 {noformat}
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7603) RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers

2020-07-20 Thread Kirk Lund (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-7603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161515#comment-17161515
 ] 

Kirk Lund commented on GEODE-7603:
--

This test continues to fail:

http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-5382/test-results/distributedTest/1595010977/

> RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers
> 
>
> Key: GEODE-7603
> URL: https://issues.apache.org/jira/browse/GEODE-7603
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Mark Hanson
>Assignee: Benjamin P Ross
>Priority: Major
>  Labels: flaky
>
> RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers
>  failed twice as a part of the mass test run.
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/2160]
>  
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/mhansonp-mhanson-mass-test-ru-main/jobs/DistributedTestOpenJDK8/builds/2130]
>  
> {noformat}
> 10:56:44org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest
>  > testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers FAILED
> 10:56:44java.lang.AssertionError: [List check last element] 
> 10:56:44Expecting:
> 10:56:44 <"0">
> 10:56:44not to be equal to:
> 10:56:44 <"0">
> 10:56:44at 
> org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest.assertPrimariesTransfered(RepeatedRebalanceDUnitTest.java:204)
> 10:56:44at 
> org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers(RepeatedRebalanceDUnitTest.java:124)
> 11:06:20
> 11:06:20352 tests completed, 1 failed, 5 skipped
> 11:06:22
> 11:06:22> Task :geode-gfsh:distributedTest FAILED
> 11:54:40
> 11:54:40> Task :geode-core:distributedTest
> 11:54:40{noformat}
>  
> {noformat}
> 22:06:33org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest
>  > testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers FAILED
> 22:06:33java.lang.AssertionError: [List check last element] 
> 22:06:33Expecting:
> 22:06:33 <"0">
> 22:06:33not to be equal to:
> 22:06:33 <"0">
> 22:06:33at 
> org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest.assertPrimariesTransfered(RepeatedRebalanceDUnitTest.java:204)
> 22:06:33at 
> org.apache.geode.management.internal.cli.commands.RepeatedRebalanceDUnitTest.testSecondRebalanceIsNotNecessaryWithAddedAndRestartedMembers(RepeatedRebalanceDUnitTest.java:124)
> 22:16:05 {noformat}
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8216) SerialWANPersistenceEnabledGatewaySenderOffHeapDUnitTest.testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived FAILED

2020-07-20 Thread Kirk Lund (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161518#comment-17161518
 ] 

Kirk Lund commented on GEODE-8216:
--

This failure continues to reproduce in CI: 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0228/test-results/distributedTest/1595040557/

> SerialWANPersistenceEnabledGatewaySenderOffHeapDUnitTest.testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
>  FAILED
> 
>
> Key: GEODE-8216
> URL: https://issues.apache.org/jira/browse/GEODE-8216
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Mark Hanson
>Assignee: Mario Ivanac
>Priority: Major
>  Labels: ci
> Attachments: geode-8216-logs.tgz
>
>
> Test failure 
> {noformat}
> org.apache.geode.internal.cache.wan.offheap.SerialWANPersistenceEnabledGatewaySenderOffHeapDUnitTest
>  > 
> testReplicatedRegionPersistentWanGateway_restartSenderWithCleanQueues_expectNoEventsReceived
>  FAILED
> 11:25:56org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.serial.SerialWANPersistenceEnabledGatewaySenderDUnitTest$$Lambda$182/1489068907.run
>  in VM 2 running on Host 40c25330a7e0 with 8 VMs
> 11:25:56
> 11:25:56Caused by:
> 11:25:56org.awaitility.core.ConditionTimeoutException: Assertion 
> condition defined as a lambda expression in 
> org.apache.geode.internal.cache.wan.WANTestBase that uses int, 
> intorg.apache.geode.cache.Region Expected region entries: 0 but actual 
> entries: 10 present region keyset [6, 5, 7, 0, 8, 9, 2, 1, 3, 4] expected:<0> 
> but was:<10> within 5 minutes.
> 11:25:56
> 11:25:56Caused by:
> 11:25:56java.lang.AssertionError: Expected region entries: 0 but 
> actual entries: 10 present region keyset [6, 5, 7, 0, 8, 9, 2, 1, 3, 4] 
> expected:<0> but was:<10>
> 11:33:48 {noformat}
>  
>  
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/229]
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0098/test-results/distributedTest/1591126795/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0098/test-artifacts/1591126795/distributedtestfiles-OpenJDK8-1.14.0-build.0098.tgz
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7628) Block jmx mbean creation when no security manager is configured

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161567#comment-17161567
 ] 

ASF GitHub Bot commented on GEODE-7628:
---

davebarnes97 merged pull request #5387:
URL: https://github.com/apache/geode/pull/5387


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Block jmx mbean creation when no security manager is configured
> ---
>
> Key: GEODE-7628
> URL: https://issues.apache.org/jira/browse/GEODE-7628
> Project: Geode
>  Issue Type: Improvement
>  Components: jmx
>Affects Versions: 1.10.0
>Reporter: Jinmei Liao
>Assignee: Ernest Burghardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When no security manager is configured, we should not allow any client to be 
> able to create mbeans.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7628) Block jmx mbean creation when no security manager is configured

2020-07-20 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161568#comment-17161568
 ] 

ASF subversion and git services commented on GEODE-7628:


Commit 6fa5dcb8af380611e40a9a033b0b44c1e5c3ba07 in geode's branch 
refs/heads/develop from Dave Barnes
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6fa5dcb ]

GEODE-7628: Block jmx mbean creation when no security manager is configured 
(docs) (#5387)



> Block jmx mbean creation when no security manager is configured
> ---
>
> Key: GEODE-7628
> URL: https://issues.apache.org/jira/browse/GEODE-7628
> Project: Geode
>  Issue Type: Improvement
>  Components: jmx
>Affects Versions: 1.10.0
>Reporter: Jinmei Liao
>Assignee: Ernest Burghardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When no security manager is configured, we should not allow any client to be 
> able to create mbeans.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8266) StatForNotQueuedConflated not incremented in time

2020-07-20 Thread Kirk Lund (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161580#comment-17161580
 ] 

Kirk Lund commented on GEODE-8266:
--

Failed on Windows again: 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0232/test-results/test/1595283848/

> StatForNotQueuedConflated not incremented in time
> -
>
> Key: GEODE-8266
> URL: https://issues.apache.org/jira/browse/GEODE-8266
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Bill Burcham
>Priority: Major
>
> Failed here: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK11/builds/259#A
> {code}
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest
>  > 
> whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented
>  FAILED
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest.whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented(ParallelGatewaySenderQueueJUnitTest.java:146)
> {code}
> It appears we are waiting 100ms for the statistic to be incremented. Perhaps 
> we need to wait longer. Or maybe there is product bug here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8266) StatForNotQueuedConflated not incremented in time

2020-07-20 Thread Kirk Lund (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161581#comment-17161581
 ] 

Kirk Lund commented on GEODE-8266:
--

100ms is way too short. I should also mention that we have in the past 
determined that making a test depend on statistic value from the stat sampler 
is a bad way to write a test. So the 100ms and the use of a stat value are 
making this a flaky test.

> StatForNotQueuedConflated not incremented in time
> -
>
> Key: GEODE-8266
> URL: https://issues.apache.org/jira/browse/GEODE-8266
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Bill Burcham
>Priority: Major
>
> Failed here: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK11/builds/259#A
> {code}
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest
>  > 
> whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented
>  FAILED
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest.whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented(ParallelGatewaySenderQueueJUnitTest.java:146)
> {code}
> It appears we are waiting 100ms for the statistic to be incremented. Perhaps 
> we need to wait longer. Or maybe there is product bug here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (GEODE-8371) ClassGraph license should be attributed to MIT in LICENSE

2020-07-20 Thread Kirk Lund (Jira) 
Kirk Lund created GEODE-8371:


 Summary: ClassGraph license should be attributed to MIT in LICENSE
 Key: GEODE-8371
 URL: https://issues.apache.org/jira/browse/GEODE-8371
 Project: Geode
  Issue Type: Bug
  Components: build
Reporter: Kirk Lund


ClassGraph license should be attributed to MIT instead of BSD in LICENSE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (GEODE-8371) ClassGraph license should be attributed to MIT in LICENSE

2020-07-20 Thread Kirk Lund (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-8371:


Assignee: Kirk Lund

> ClassGraph license should be attributed to MIT in LICENSE
> -
>
> Key: GEODE-8371
> URL: https://issues.apache.org/jira/browse/GEODE-8371
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>
> ClassGraph license should be attributed to MIT instead of BSD in LICENSE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8371) ClassGraph license should be attributed to MIT in LICENSE

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161590#comment-17161590
 ] 

ASF GitHub Bot commented on GEODE-8371:
---

kirklund opened a new pull request #5388:
URL: https://github.com/apache/geode/pull/5388


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ClassGraph license should be attributed to MIT in LICENSE
> -
>
> Key: GEODE-8371
> URL: https://issues.apache.org/jira/browse/GEODE-8371
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>
> ClassGraph license should be attributed to MIT instead of BSD in LICENSE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8371) ClassGraph license should be attributed to MIT in LICENSE

2020-07-20 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8371:
--
Labels: pull-request-available  (was: )

> ClassGraph license should be attributed to MIT in LICENSE
> -
>
> Key: GEODE-8371
> URL: https://issues.apache.org/jira/browse/GEODE-8371
> Project: Geode
>  Issue Type: Bug
>  Components: build
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>
> ClassGraph license should be attributed to MIT instead of BSD in LICENSE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8316) RollingUpgradeWithGfshDUnitTest > testRollingUpgradeWithDeployment[] FAILED

2020-07-20 Thread Jinmei Liao (Jira) 


 [ 
https://issues.apache.org/jira/browse/GEODE-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao updated GEODE-8316:
---
Labels: CI GeodeOperationAPI  (was: CI)

> RollingUpgradeWithGfshDUnitTest > testRollingUpgradeWithDeployment[] FAILED
> ---
>
> Key: GEODE-8316
> URL: https://issues.apache.org/jira/browse/GEODE-8316
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Mark Hanson
>Priority: Major
>  Labels: CI, GeodeOperationAPI
>
> {noformat}
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
>  > testRollingUpgradeWithDeployment[1.10.0] FAILED
> 07:26:08java.lang.AssertionError: 
> 07:26:08Expecting file:
> 07:26:08  
> 
> 07:26:08to exist.
> 07:26:08
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
>  > testRollingUpgradeWithDeployment[1.11.0] FAILED
> 07:26:08java.lang.AssertionError: 
> 07:26:08Expecting file:
> 07:26:08  
> 
> 07:26:08to exist.
> 07:26:08
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
>  > testRollingUpgradeWithDeployment[1.12.0] FAILED
> 07:26:08java.lang.AssertionError: 
> 07:26:08Expecting file:
> 07:26:08  
> 
> 07:26:08to exist.
> 07:26:19 {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8316) RollingUpgradeWithGfshDUnitTest > testRollingUpgradeWithDeployment[] FAILED

2020-07-20 Thread Jinmei Liao (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161605#comment-17161605
 ] 

Jinmei Liao commented on GEODE-8316:


I think this has something to do with the environment is not ready yet when the 
test started to execute. This failure only appears when these tests are the 
first to execute. In the successful runs, these tests are executed about 4 or 5 
minutes later.

> RollingUpgradeWithGfshDUnitTest > testRollingUpgradeWithDeployment[] FAILED
> ---
>
> Key: GEODE-8316
> URL: https://issues.apache.org/jira/browse/GEODE-8316
> Project: Geode
>  Issue Type: Bug
>  Components: core
>Reporter: Mark Hanson
>Priority: Major
>  Labels: CI, GeodeOperationAPI
>
> {noformat}
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
>  > testRollingUpgradeWithDeployment[1.10.0] FAILED
> 07:26:08java.lang.AssertionError: 
> 07:26:08Expecting file:
> 07:26:08  
> 
> 07:26:08to exist.
> 07:26:08
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
>  > testRollingUpgradeWithDeployment[1.11.0] FAILED
> 07:26:08java.lang.AssertionError: 
> 07:26:08Expecting file:
> 07:26:08  
> 
> 07:26:08to exist.
> 07:26:08
> 07:26:08org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeWithGfshDUnitTest
>  > testRollingUpgradeWithDeployment[1.12.0] FAILED
> 07:26:08java.lang.AssertionError: 
> 07:26:08Expecting file:
> 07:26:08  
> 
> 07:26:08to exist.
> 07:26:19 {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8368) Upgrade ClassGraph dependency from 4.8.52 to 4.8.87

2020-07-20 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/GEODE-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161631#comment-17161631
 ] 

ASF GitHub Bot commented on GEODE-8368:
---

onichols-pivotal commented on pull request #5382:
URL: https://github.com/apache/geode/pull/5382#issuecomment-661500736


   Out of curiosity what are we changing this?  Was there a specific issue with 
4.8.52 you are trying to solve?  I would much rather go back to 4.0.6 and fix 
the log4j issue with an exclusion, than mess around with any of these 
newfangled versions.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade ClassGraph dependency from 4.8.52 to 4.8.87
> ---
>
> Key: GEODE-8368
> URL: https://issues.apache.org/jira/browse/GEODE-8368
> Project: Geode
>  Issue Type: Wish
>  Components: build, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>
> Upgrade ClassGraph dependency from 4.8.52 to 4.8.87.
> See GEODE-8150. There were performance issues with 4.8.78 that caused us to 
> rollback to 4.8.52. We'll need to do extra testing as well as review of 
> ClassGraph release notes and bugs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)