[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[ https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104155#comment-17104155 ] ASF GitHub Bot commented on GEODE-7971: --- albertogpz commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-626524327 > Methods named `isGroupTransactionEvents` might be better named `shouldGroupTransactionEvents`. Similarly, fields/variables named `isGroupTransactionEvents` might be better named simply `groupTransactionEvents`. I agree. Instead of using shouldGroupTransactionEvents I will use mustGroupTransactionEvents which is a bit shorter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Gateway sender to deliver transaction events atomically to gateway receivers > > > Key: GEODE-7971 > URL: https://issues.apache.org/jira/browse/GEODE-7971 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > The goal of this ticket is to implement the necessary changes in the gateway > sender to prevent that events belonging to the same transaction are spread > across different batches. In other words, to ensure that events from the same > transaction are sent inside the same batch. > This will be an optional feature on gateway senders to be enabled via a new > parameter (--group-transaction-events) and will be restricted to serial > gateway senders with just one dispatcher thread or to parallel gateway > senders. > Apart from the above restriction, grouping of events for a transaction inside > the same batch may only be attained if the regions to which the events belong > are replicated by the same set of gateway senders with the > --group-transaction-events flag enabled. If this condition is not met, the > events will be correctly delivered by the gateway senders but it will not be > guaranteed that all events will always be sent inside the same batch. > For more details see: > [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[ https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104174#comment-17104174 ] ASF GitHub Bot commented on GEODE-7971: --- albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r422851648 ## File path: geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java ## @@ -153,6 +155,13 @@ .getInteger(GeodeGlossary.GEMFIRE_PREFIX + "gateway-connection-retry-interval", 1000) .intValue(); + /** + * Number of times to retry to get events for a transaction from the gateway sender queue + */ + int GET_TRANSACTION_EVENTS_FROM_QUEUE_RETRIES = + Integer.getInteger(GeodeGlossary.GEMFIRE_PREFIX + "get-transaction-events-from-queue-retries", Review comment: I did not document this property as I thought it was too internal to be used by clients just as other properties that are not documented. For example: gateway-connection-retry-interval This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Gateway sender to deliver transaction events atomically to gateway receivers > > > Key: GEODE-7971 > URL: https://issues.apache.org/jira/browse/GEODE-7971 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > The goal of this ticket is to implement the necessary changes in the gateway > sender to prevent that events belonging to the same transaction are spread > across different batches. In other words, to ensure that events from the same > transaction are sent inside the same batch. > This will be an optional feature on gateway senders to be enabled via a new > parameter (--group-transaction-events) and will be restricted to serial > gateway senders with just one dispatcher thread or to parallel gateway > senders. > Apart from the above restriction, grouping of events for a transaction inside > the same batch may only be attained if the regions to which the events belong > are replicated by the same set of gateway senders with the > --group-transaction-events flag enabled. If this condition is not met, the > events will be correctly delivered by the gateway senders but it will not be > guaranteed that all events will always be sent inside the same batch. > For more details see: > [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[ https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104197#comment-17104197 ] ASF GitHub Bot commented on GEODE-7971: --- albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r422866672 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/InternalRegion.java ## @@ -307,6 +307,11 @@ void cacheWriteBeforePut(EntryEventImpl event, Set netWriteRecipients, CacheWrit void invokeTXCallbacks(EnumListenerEvent afterDestroy, EntryEventImpl ee, boolean b); + default void invokeTXCallbacks(EnumListenerEvent afterDestroy, EntryEventImpl ee, boolean b, Review comment: It is not. I will remove the default implementation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Gateway sender to deliver transaction events atomically to gateway receivers > > > Key: GEODE-7971 > URL: https://issues.apache.org/jira/browse/GEODE-7971 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > The goal of this ticket is to implement the necessary changes in the gateway > sender to prevent that events belonging to the same transaction are spread > across different batches. In other words, to ensure that events from the same > transaction are sent inside the same batch. > This will be an optional feature on gateway senders to be enabled via a new > parameter (--group-transaction-events) and will be restricted to serial > gateway senders with just one dispatcher thread or to parallel gateway > senders. > Apart from the above restriction, grouping of events for a transaction inside > the same batch may only be attained if the regions to which the events belong > are replicated by the same set of gateway senders with the > --group-transaction-events flag enabled. If this condition is not met, the > events will be correctly delivered by the gateway senders but it will not be > guaranteed that all events will always be sent inside the same batch. > For more details see: > [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104200#comment-17104200
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r422867687
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/TXLastEventInTransactionUtils.java
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.ServiceConfigurationError;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import org.apache.logging.log4j.Logger;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.wan.GatewaySender;
+import org.apache.geode.logging.internal.log4j.api.LogService;
+
+public class TXLastEventInTransactionUtils {
+ private static final Logger logger = LogService.getLogger();
+
+ /**
+ * @param callbacks list of events belonging to a transaction
+ *
+ * @return the last event of the transaction.
+ * If the regions to which the events belong do not have senders
+ * that group transactions it returns null.
+ * If the regions to which the
+ * events belong have different sets of senders that group
transactions
+ * then it throws a ServiceConfigurationError exception.
+ */
+ public static EntryEventImpl getLastTransactionEvent(List
callbacks,
+ Cache cache)
+ throws ServiceConfigurationError {
+if (checkNoSendersGroupTransactionEvents(callbacks, cache)) {
+ return null;
+}
+
+List senderIdsPerEvent = getGroupingSendersPerEvent(callbacks, cache);
+if (senderIdsPerEvent.stream().distinct().count() > 1) {
+ String info = eventsAndSendersPerEventToString(callbacks,
senderIdsPerEvent);
+ throw new ServiceConfigurationError(
+ "Not all events go to the same senders that group transactions. " +
info);
+} ;
Review comment:
Good eye!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
>
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104222#comment-17104222
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r422882651
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
##
@@ -862,14 +868,14 @@ private void logEvents(String message,
List events) {
event.getRawCallbackArgument(), this.sender.getMyDSId(),
allRemoteDSIds);
event.setCallbackArgument(geCallbackArg);
GatewaySenderEventImpl pdxSenderEvent =
- new GatewaySenderEventImpl(EnumListenerEvent.AFTER_UPDATE,
event, null); // OFFHEAP:
-
// event for
-
// pdx type
-
// meta data
-
// so it
-
// should
-
// never be
-
// off-heap
+ new GatewaySenderEventImpl(EnumListenerEvent.AFTER_UPDATE,
event, null, false); // OFFHEAP:
+ // event for
+ // pdx type
+ // meta data
+ // so it
+ // should
+ // never be
+ // off-heap
Review comment:
I have put it in a single line above the instance creation sentence. I
cannot tell if the comment is significant so I do not know if it can be removed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
>
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104232#comment-17104232
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r422886472
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -373,7 +373,8 @@ public static Integer createSecondRemoteLocator(int dsId,
int localPort, int rem
}
public static Integer createSecondRemoteLocatorWithAPI(int dsId, int
localPort, int remoteLocPort,
- String hostnameForClients) throws IOException {
+ String hostnameForClients)
Review comment:
No reason. I did it by mistake. I have reverted the changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
>
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104387#comment-17104387
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r422994223
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java
##
@@ -299,19 +312,316 @@ public void
testPartitionedRegionParallelPropagation_AfterDispatch_NoRedundancy(
(ArrayList) vm7.invoke(() -> WANTestBase.getSenderStats("ln",
0));
assertEquals(0, v4List.get(0) + v5List.get(0) + v6List.get(0) +
v7List.get(0)); // queue size
-assertEquals(NUM_PUTS, v4List.get(1) + v5List.get(1) + v6List.get(1) +
v7List.get(1)); // eventsReceived
+assertEquals(NUM_PUTS,
+v4List.get(1) + v5List.get(1) + v6List.get(1) + v7List.get(1)); //
eventsReceived
assertEquals(NUM_PUTS, v4List.get(2) + v5List.get(2) + v6List.get(2) +
v7List.get(2)); // events
-
// queued
+// queued
assertEquals(NUM_PUTS, v4List.get(3) + v5List.get(3) + v6List.get(3) +
v7List.get(3)); // events
-
// distributed
+// distributed
assertTrue(v4List.get(4) + v5List.get(4) + v6List.get(4) + v7List.get(4)
>= 10); // batches
-
// distributed
+// distributed
assertEquals(0, v4List.get(5) + v5List.get(5) + v6List.get(5) +
v7List.get(5)); // batches
-
// redistributed
+// redistributed
vm2.invoke(() -> WANTestBase.checkGatewayReceiverStats(10, NUM_PUTS,
NUM_PUTS));
}
+ @Test
+ public void
testPartitionedRegionParallelPropagation_NoGroupTransactionEvents()
+ throws Exception {
+Integer lnPort = (Integer) vm0.invoke(() ->
WANTestBase.createFirstLocatorWithDSId(1));
+Integer nyPort = (Integer) vm1.invoke(() ->
WANTestBase.createFirstRemoteLocator(2, lnPort));
+
+createCacheInVMs(nyPort, vm2);
+createReceiverInVMs(vm2);
+
+int batchTimeInterval = 1;
+createSenders(lnPort, false, batchTimeInterval);
+
+createReceiverCustomerOrderShipmentPR(vm2, 0);
+
+createSenderCustomerOrderShipmentPRs(0);
+
+startSenderInVMs("ln", vm4, vm5, vm6, vm7);
+
+final Map custKeyValue = new HashMap();
+int intCustId = 1;
+CustId custId = new CustId(intCustId);
+custKeyValue.put(custId, new Customer());
+vm4.invoke(() -> WANTestBase.putGivenKeyValue(customerRegionName,
custKeyValue));
+
+int transactions = 3;
+final Map keyValues = new HashMap();
+for (int i = 0; i < transactions; i++) {
+ OrderId orderId = new OrderId(i, custId);
+ ShipmentId shipmentId1 = new ShipmentId(i, orderId);
+ ShipmentId shipmentId2 = new ShipmentId(i + 1, orderId);
+ ShipmentId shipmentId3 = new ShipmentId(i + 2, orderId);
+ keyValues.put(orderId, new Order());
+ keyValues.put(shipmentId1, new Shipment());
+ keyValues.put(shipmentId2, new Shipment());
+ keyValues.put(shipmentId3, new Shipment());
+}
+int eventsPerTransaction = 4;
+vm4.invoke(() ->
WANTestBase.doOrderAndShipmentPutsInsideTransactions(keyValues,
+eventsPerTransaction));
+
+int entries = (transactions * eventsPerTransaction) + 1;
+
+vm4.invoke(() -> WANTestBase.validateRegionSize(customerRegionName, 1));
+vm4.invoke(() -> WANTestBase.validateRegionSize(orderRegionName,
transactions));
+vm4.invoke(() -> WANTestBase.validateRegionSize(shipmentRegionName,
transactions * 3));
+
+ArrayList v4List =
+(ArrayList) vm4.invoke(() -> WANTestBase.getSenderStats("ln",
0));
+ArrayList v5List =
+(ArrayList) vm5.invoke(() -> WANTestBase.getSenderStats("ln",
0));
+ArrayList v6List =
+(ArrayList) vm6.invoke(() -> WANTestBase.getSenderStats("ln",
0));
+ArrayList v7List =
+(ArrayList) vm7.invoke(() -> WANTestBase.getSenderStats("ln",
0));
+
+assertEquals(0, v4List.get(0) + v5List.get(0) + v6List.get(0) +
v7List.get(0)); // queue size
+assertEquals(entries,
+v4List.get(1) + v5List.get(1) + v6List.get(1) + v7List.get(1)); //
eventsReceived
+assertEquals(entries, v4List.get(2) + v5List.get(2) + v6List.get(2) +
v7List.get(2)); // events
+// queued
+assertEquals(entries, v4List.get(3) + v5List.get(3) + v6List.get(3) +
v7List.get(3)); // events
+// distributed
+assertEquals(2, v4List.get(4) + v5List.get(4) + v6List.get(4) +
v7List.get(4)); // batches
+// distributed
+assertEquals(0, v4List.get(5) + v5List.get(5) + v6List.get(5)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104415#comment-17104415
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423010939
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java
##
@@ -503,17 +815,16 @@ public void
testParallelPropagationWithRemoteRegionDestroy() throws Exception {
ArrayList v7List =
(ArrayList) vm7.invoke(() -> WANTestBase.getSenderStats("ln",
-1));
-
assertTrue(v4List.get(4) + v5List.get(4) + v6List.get(4) + v7List.get(4)
>= 1); // batches
-
// distributed :
-
// its quite
-
// possible that
-
// vm4 has
-
// distributed
-
// some of the
-
// batches.
+// distributed :
+// its quite
+// possible that
+// vm4 has
+// distributed
+// some of the
+// batches.
assertTrue(v4List.get(5) + v5List.get(5) + v6List.get(5) + v7List.get(5)
>= 1); // batches
-
// redistributed
+// redistributed
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java
##
@@ -559,17 +868,18 @@ public void testParallelPropagationWithFilter() throws
Exception {
(ArrayList) vm7.invoke(() -> WANTestBase.getSenderStats("ln",
0));
assertEquals(0, v4List.get(0) + v5List.get(0) + v6List.get(0) +
v7List.get(0)); // queue size
-assertEquals(1000, v4List.get(1) + v5List.get(1) + v6List.get(1) +
v7List.get(1)); // eventsReceived
+assertEquals(1000,
+v4List.get(1) + v5List.get(1) + v6List.get(1) + v7List.get(1)); //
eventsReceived
assertEquals(900, v4List.get(2) + v5List.get(2) + v6List.get(2) +
v7List.get(2)); // events
-
// queued
+// queued
assertEquals(800, v4List.get(3) + v5List.get(3) + v6List.get(3) +
v7List.get(3)); // events
-
// distributed
+// distributed
assertTrue(v4List.get(4) + v5List.get(4) + v6List.get(4) + v7List.get(4)
>= 80); // batches
-
// distributed
+// distributed
assertEquals(0, v4List.get(5) + v5List.get(5) + v6List.get(5) +
v7List.get(5)); // batches
-
// redistributed
+// redistributed
assertEquals(200, v4List.get(6) + v5List.get(6) + v6List.get(6) +
v7List.get(6)); // events
-
// filtered
+// filtered
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
>
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thr
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104414#comment-17104414
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423010749
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java
##
@@ -299,19 +312,316 @@ public void
testPartitionedRegionParallelPropagation_AfterDispatch_NoRedundancy(
(ArrayList) vm7.invoke(() -> WANTestBase.getSenderStats("ln",
0));
assertEquals(0, v4List.get(0) + v5List.get(0) + v6List.get(0) +
v7List.get(0)); // queue size
-assertEquals(NUM_PUTS, v4List.get(1) + v5List.get(1) + v6List.get(1) +
v7List.get(1)); // eventsReceived
+assertEquals(NUM_PUTS,
+v4List.get(1) + v5List.get(1) + v6List.get(1) + v7List.get(1)); //
eventsReceived
assertEquals(NUM_PUTS, v4List.get(2) + v5List.get(2) + v6List.get(2) +
v7List.get(2)); // events
-
// queued
+// queued
assertEquals(NUM_PUTS, v4List.get(3) + v5List.get(3) + v6List.get(3) +
v7List.get(3)); // events
-
// distributed
+// distributed
assertTrue(v4List.get(4) + v5List.get(4) + v6List.get(4) + v7List.get(4)
>= 10); // batches
-
// distributed
+// distributed
assertEquals(0, v4List.get(5) + v5List.get(5) + v6List.get(5) +
v7List.get(5)); // batches
-
// redistributed
+// redistributed
vm2.invoke(() -> WANTestBase.checkGatewayReceiverStats(10, NUM_PUTS,
NUM_PUTS));
}
+ @Test
+ public void
testPartitionedRegionParallelPropagation_NoGroupTransactionEvents()
+ throws Exception {
+Integer lnPort = (Integer) vm0.invoke(() ->
WANTestBase.createFirstLocatorWithDSId(1));
+Integer nyPort = (Integer) vm1.invoke(() ->
WANTestBase.createFirstRemoteLocator(2, lnPort));
+
+createCacheInVMs(nyPort, vm2);
+createReceiverInVMs(vm2);
+
+int batchTimeInterval = 1;
+createSenders(lnPort, false, batchTimeInterval);
+
+createReceiverCustomerOrderShipmentPR(vm2, 0);
+
+createSenderCustomerOrderShipmentPRs(0);
+
+startSenderInVMs("ln", vm4, vm5, vm6, vm7);
+
+final Map custKeyValue = new HashMap();
+int intCustId = 1;
+CustId custId = new CustId(intCustId);
+custKeyValue.put(custId, new Customer());
+vm4.invoke(() -> WANTestBase.putGivenKeyValue(customerRegionName,
custKeyValue));
+
+int transactions = 3;
+final Map keyValues = new HashMap();
+for (int i = 0; i < transactions; i++) {
+ OrderId orderId = new OrderId(i, custId);
+ ShipmentId shipmentId1 = new ShipmentId(i, orderId);
+ ShipmentId shipmentId2 = new ShipmentId(i + 1, orderId);
+ ShipmentId shipmentId3 = new ShipmentId(i + 2, orderId);
+ keyValues.put(orderId, new Order());
+ keyValues.put(shipmentId1, new Shipment());
+ keyValues.put(shipmentId2, new Shipment());
+ keyValues.put(shipmentId3, new Shipment());
+}
+int eventsPerTransaction = 4;
+vm4.invoke(() ->
WANTestBase.doOrderAndShipmentPutsInsideTransactions(keyValues,
+eventsPerTransaction));
+
+int entries = (transactions * eventsPerTransaction) + 1;
+
+vm4.invoke(() -> WANTestBase.validateRegionSize(customerRegionName, 1));
+vm4.invoke(() -> WANTestBase.validateRegionSize(orderRegionName,
transactions));
+vm4.invoke(() -> WANTestBase.validateRegionSize(shipmentRegionName,
transactions * 3));
+
+ArrayList v4List =
+(ArrayList) vm4.invoke(() -> WANTestBase.getSenderStats("ln",
0));
+ArrayList v5List =
+(ArrayList) vm5.invoke(() -> WANTestBase.getSenderStats("ln",
0));
+ArrayList v6List =
+(ArrayList) vm6.invoke(() -> WANTestBase.getSenderStats("ln",
0));
+ArrayList v7List =
+(ArrayList) vm7.invoke(() -> WANTestBase.getSenderStats("ln",
0));
+
+assertEquals(0, v4List.get(0) + v5List.get(0) + v6List.get(0) +
v7List.get(0)); // queue size
+assertEquals(entries,
+v4List.get(1) + v5List.get(1) + v6List.get(1) + v7List.get(1)); //
eventsReceived
+assertEquals(entries, v4List.get(2) + v5List.get(2) + v6List.get(2) +
v7List.get(2)); // events
+// queued
+assertEquals(entries, v4List.get(3) + v5List.get(3) + v6List.get(3) +
v7List.get(3)); // events
+// distributed
+assertEquals(2, v4List.get(4) + v5List.get(4) + v6List.get(4) +
v7List.get(4)); // batches
+// distributed
+assertEquals(0, v4List.get(5) + v5List.get(5) + v6List.get(5)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104417#comment-17104417
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423011450
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -497,7 +498,8 @@ public static void createPersistentReplicatedRegion(String
regionName, String se
}
public static void createReplicatedRegionWithAsyncEventQueue(String
regionName,
- String asyncQueueIds, Boolean offHeap) {
+ String asyncQueueIds,
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
>
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104418#comment-17104418
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423011534
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -519,7 +521,9 @@ public static void
createReplicatedRegionWithAsyncEventQueue(String regionName,
}
public static void createReplicatedRegionWithSenderAndAsyncEventQueue(String
regionName,
- String senderIds, String asyncChannelId, Boolean offHeap) {
+ String senderIds,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -560,7 +564,8 @@ public static void createReplicatedRegion(String
regionName, String senderIds, S
}
public static void createAsyncEventQueue(String asyncChannelId, boolean
isParallel,
- Integer maxMemory, Integer batchSize, boolean isConflation, boolean
isPersistent,
+ Integer maxMemory, Integer batchSize,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -589,7 +594,8 @@ public static void createAsyncEventQueue(String
asyncChannelId, boolean isParall
}
public static void createPartitionedRegion(String regionName, String
senderIds,
- Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+ Integer redundantCopies, Integer totalNumBuckets,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -619,7 +625,8 @@ public static void createPartitionedRegion(String
regionName, String senderIds,
// TODO:OFFHEAP: add offheap flavor
public static void createPartitionedRegionWithPersistence(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets) {
+ Integer redundantCopies,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -647,7 +654,9 @@ public static void
createPartitionedRegionWithPersistence(String regionName, Str
}
public static void createColocatedPartitionedRegion(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets, String colocatedWith) {
+ Integer redundantCopies,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -691,7 +700,8 @@ public static void
addAsyncEventQueueThroughAttributesMutator(String regionName,
}
public static void createPartitionedRegionAsAccessor(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets) {
+ Integer redundantCopies,
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
>
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For m
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104419#comment-17104419
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423011955
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -709,7 +719,10 @@ public static void
createPartitionedRegionAsAccessor(String regionName, String s
}
public static void createPartitionedRegionWithSerialParallelSenderIds(String
regionName,
- String serialSenderIds, String parallelSenderIds, String colocatedWith,
Boolean offHeap) {
+ String serialSenderIds,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -734,7 +747,8 @@ public static void
createPartitionedRegionWithSerialParallelSenderIds(String reg
}
public static void createPersistentPartitionedRegion(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+ Integer redundantCopies,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -764,7 +778,9 @@ public static void createPersistentPartitionedRegion(String
regionName, String s
}
public static void createCustomerOrderShipmentPartitionedRegion(String
senderIds,
- Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+ Integer redundantCopies,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -830,7 +846,8 @@ public static void
createCustomerOrderShipmentPartitionedRegion(String senderIds
}
public static void createColocatedPartitionedRegions(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+ Integer redundantCopies,
Review comment:
ok
##
File path:
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java
##
@@ -858,7 +875,8 @@ public static void createColocatedPartitionedRegions(String
regionName, String s
}
public static void createColocatedPartitionedRegions2(String regionName,
String senderIds,
- Integer redundantCopies, Integer totalNumBuckets, Boolean offHeap) {
+ Integer redundantCopies,
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
>
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7971) Gateway sender to deliver transaction events atomically to gateway receivers
[
https://issues.apache.org/jira/browse/GEODE-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104422#comment-17104422
]
ASF GitHub Bot commented on GEODE-7971:
---
albertogpz commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r423014670
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##
@@ -1282,22 +1278,89 @@ public List peek(int batchSize, int timeToWait) throws
InterruptedException, Cac
Thread.currentThread().interrupt();
break;
}
-continue;
}
}
+
+if (batch.size() > 0) {
+ peekEventsFromIncompleteTransactions(batch,
incompleteTransactionsInBatch, prQ);
+}
+
if (isDebugEnabled) {
logger.debug("{}: Peeked a batch of {} entries. The size of the queue is
{}. localSize is {}",
this, batch.size(), size(), localSize());
}
+
if (batch.size() == 0) {
blockProcessorThreadIfRequired();
}
return batch;
}
+ private boolean stopPeekingDueToTime(long currentTime, int timeToWait, long
end) {
Review comment:
Good point
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Gateway sender to deliver transaction events atomically to gateway receivers
>
>
> Key: GEODE-7971
> URL: https://issues.apache.org/jira/browse/GEODE-7971
> Project: Geode
> Issue Type: Improvement
> Components: wan
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The goal of this ticket is to implement the necessary changes in the gateway
> sender to prevent that events belonging to the same transaction are spread
> across different batches. In other words, to ensure that events from the same
> transaction are sent inside the same batch.
> This will be an optional feature on gateway senders to be enabled via a new
> parameter (--group-transaction-events) and will be restricted to serial
> gateway senders with just one dispatcher thread or to parallel gateway
> senders.
> Apart from the above restriction, grouping of events for a transaction inside
> the same batch may only be attained if the regions to which the events belong
> are replicated by the same set of gateway senders with the
> --group-transaction-events flag enabled. If this condition is not met, the
> events will be correctly delivered by the gateway senders but it will not be
> guaranteed that all events will always be sent inside the same batch.
> For more details see:
> [https://cwiki.apache.org/confluence/display/GEODE/Gw+sender+to+deliver+transaction+events+atomically+to+receivers]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8093) redis HSETNX should not allows for multiple field/value pairs
[ https://issues.apache.org/jira/browse/GEODE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104446#comment-17104446 ] ASF subversion and git services commented on GEODE-8093: Commit a0226d6e168477c4dc3f5db0d567a15b06fa0996 in geode's branch refs/heads/develop from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0226d6 ] GEODE-8093: Declare parameter requirements for HSET and HSETNX (#5083) > redis HSETNX should not allows for multiple field/value pairs > - > > Key: GEODE-8093 > URL: https://issues.apache.org/jira/browse/GEODE-8093 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > HSETNX should only support a single field/value pair. But it inherits its > implementation from HSET which supports multiple field/value pairs. > So in order to be compatible with native redis HSETNX should only support a > single field/value pair. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8093) redis HSETNX should not allows for multiple field/value pairs
[ https://issues.apache.org/jira/browse/GEODE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-8093. --- Fix Version/s: 1.14.0 Resolution: Fixed > redis HSETNX should not allows for multiple field/value pairs > - > > Key: GEODE-8093 > URL: https://issues.apache.org/jira/browse/GEODE-8093 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > HSETNX should only support a single field/value pair. But it inherits its > implementation from HSET which supports multiple field/value pairs. > So in order to be compatible with native redis HSETNX should only support a > single field/value pair. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8082) Refactor GeodeRedisServer
[ https://issues.apache.org/jira/browse/GEODE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104450#comment-17104450 ] ASF subversion and git services commented on GEODE-8082: Commit 29b0b22ebca1bd371ed4a04ca2b46751e11979e3 in geode's branch refs/heads/develop from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=29b0b22 ] GEODE-8082: Refactor GeodeRedisServer (#5080) Co-authored-by: Ray Ingles Co-authored-by: john Hutchison Co-authored-by: Darrel Schneider Co-authored-by: Sarah > Refactor GeodeRedisServer > - > > Key: GEODE-8082 > URL: https://issues.apache.org/jira/browse/GEODE-8082 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8062) Disable broken tests to avoid accidental runs
[
https://issues.apache.org/jira/browse/GEODE-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104602#comment-17104602
]
ASF subversion and git services commented on GEODE-8062:
Commit 330e8da18899b057028fc982f581464a3a1209c9 in geode-native's branch
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=330e8da ]
GEODE-8062: Disables flaky and omitted tests. (#598)
Use test DISABLED property to avoid accidental execution.
> Disable broken tests to avoid accidental runs
> -
>
> Key: GEODE-8062
> URL: https://issues.apache.org/jira/browse/GEODE-8062
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> In the initial migration to CMake there wasn't a way to mark tests as
> disabled in CTest. Our solution was to use {{LABELS}}. The use of labels can
> result in unexpected execution of a test during {{--rerun-failed}} or {{-R}}
> options. As of CMake 3.9 you can disabled at test with the {{DISABLED}}
> property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8063) Access violation during Cache destrucition caused by ClientMetadataService
[
https://issues.apache.org/jira/browse/GEODE-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104604#comment-17104604
]
ASF subversion and git services commented on GEODE-8063:
Commit 4929011adfeecb2cfac6559df171cba9e33ae9b9 in geode-native's branch
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=4929011 ]
GEODE-8063: Fixes access violation. (#597)
The external Cache pointer is not valid when destruction has started.
Refactored to not be static and use this CacheImpl.
Removed unused private static method from API files.
> Access violation during Cache destrucition caused by ClientMetadataService
> --
>
> Key: GEODE-8063
> URL: https://issues.apache.org/jira/browse/GEODE-8063
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> During the destruction of {{Cache}} the pointer to {{CacheImpl}} is invalid.
> Calls from {{ClientMetadataService}} attempt to access {{Pool}} instances
> through the {{Cache}} instance rather than {{CacheImpl}} resulting in access
> violation. This issue is timing dependent and isn't always reproducible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8016) Replace Maven SNAPSHOT with enumerated build-id artifacts
[ https://issues.apache.org/jira/browse/GEODE-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104670#comment-17104670 ] ASF subversion and git services commented on GEODE-8016: Commit 3e8453f58aabea0fb1da7c436a64a254c66d5a40 in geode's branch refs/heads/support/1.13 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3e8453f ] GEODE-8016: publish with non-zero-padded build ids instead of SNAPSHOT. (#5089) * Artifacts take the form `1.13.0-build.123` instead of `1.13.0-SNAPSHOT`. * checkPom task has been modified to use a slug instead of an always changing version. * Gradle clients will use the greedy "1.13.0-build+" notation * Maven clients will use semver v1.0 "[1.13.0-build,1.14.0)" notation. Signed-off-by: Sean Goller (cherry picked from commit a4c8b9ed8bbea584f798164fa5308d236e9b6048) (cherry picked from commit 39c522e340196cb30d55d81d93c63028938cd782) > Replace Maven SNAPSHOT with enumerated build-id artifacts > - > > Key: GEODE-8016 > URL: https://issues.apache.org/jira/browse/GEODE-8016 > Project: Geode > Issue Type: Task > Components: build, ci >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > > To better support repeatable builds in CI, publish artifacts in the form > `1.2.3-build.123` instead of `1.2.3-SNAPSHOT` with the SNAPSHOT dynamically > changing. As an example, the `geode-examples` pipeline would be able to grab > a distinct artifact for build-and-test, instead of an unrepeatable, invisibly > rolling `SNAPSHOT`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8016) Replace Maven SNAPSHOT with enumerated build-id artifacts
[ https://issues.apache.org/jira/browse/GEODE-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104671#comment-17104671 ] ASF subversion and git services commented on GEODE-8016: Commit 96e6250652d1f387314965d80e42f4fc2b20ede5 in geode's branch refs/heads/support/1.12 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=96e6250 ] GEODE-8016: publish with non-zero-padded build ids instead of SNAPSHOT. (#5090) * Artifacts take the form `1.12.1-build.123` instead of `1.12.1-SNAPSHOT`. * checkPom task has been modified to use a slug instead of an always changing version. * Gradle clients will use the greedy "1.12.1-build+" notation * Maven clients will use semver v1.0 "[1.12.1-build,1.13.0)" notation. Signed-off-by: Sean Goller (cherry picked from commit a4c8b9ed8bbea584f798164fa5308d236e9b6048) (cherry picked from commit 39c522e340196cb30d55d81d93c63028938cd782) > Replace Maven SNAPSHOT with enumerated build-id artifacts > - > > Key: GEODE-8016 > URL: https://issues.apache.org/jira/browse/GEODE-8016 > Project: Geode > Issue Type: Task > Components: build, ci >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > > To better support repeatable builds in CI, publish artifacts in the form > `1.2.3-build.123` instead of `1.2.3-SNAPSHOT` with the SNAPSHOT dynamically > changing. As an example, the `geode-examples` pipeline would be able to grab > a distinct artifact for build-and-test, instead of an unrepeatable, invisibly > rolling `SNAPSHOT`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8035) Parallel Disk Store Recovery when Cluster Restarts
[ https://issues.apache.org/jira/browse/GEODE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104673#comment-17104673 ] Geode Integration commented on GEODE-8035: -- Jianxia Chen added a comment in Pivotal Tracker: Need to document the new system property `parallel-disk-store-recovery` View this Pivotal Tracker story: https://www.pivotaltracker.com/story/show/172708308 > Parallel Disk Store Recovery when Cluster Restarts > -- > > Key: GEODE-8035 > URL: https://issues.apache.org/jira/browse/GEODE-8035 > Project: Geode > Issue Type: Improvement >Reporter: Jianxia Chen >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, GeodeOperationAPI > > Currently, when Geode cluster restarts, the disk store recovery is > serialized. When all regions share the same disk store, the restart process > is time consuming. To improve the performance, different regions can use > different disk stores with different disk controllers. And adding parallel > disk store recovery. This is expected to significantly reduce the time to > restart Geode cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-6222) CI Failure: GemFireDeadlockDetectorDUnitTest
[
https://issues.apache.org/jira/browse/GEODE-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104679#comment-17104679
]
Barrett Oglesby commented on GEODE-6222:
Failed again in DistributedTestOpenJDK11 build 151:
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/151]
> CI Failure: GemFireDeadlockDetectorDUnitTest
>
>
> Key: GEODE-6222
> URL: https://issues.apache.org/jira/browse/GEODE-6222
> Project: Geode
> Issue Type: Bug
> Components: distributed lock service
>Affects Versions: 1.9.0
>Reporter: Ken Howe
>Priority: Major
> Labels: flaky
>
> Flaky test failure in
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/247]
> {code:java}
> org.apache.geode.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest
> > testDistributedDeadlockWithDLock FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.geode.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest.testDistributedDeadlockWithDLock(GemFireDeadlockDetectorDUnitTest.java:199)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8096) redeployingParentClassDoesNotCauseSubclassIncompatibilities encounters ClassNotFoundException exception
[
https://issues.apache.org/jira/browse/GEODE-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104689#comment-17104689
]
Barrett Oglesby commented on GEODE-8096:
Failed again in IntegrationTestOpenJDK8 build 145:
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/145]
> redeployingParentClassDoesNotCauseSubclassIncompatibilities encounters
> ClassNotFoundException exception
> ---
>
> Key: GEODE-8096
> URL: https://issues.apache.org/jira/browse/GEODE-8096
> Project: Geode
> Issue Type: Bug
> Components: serialization
>Reporter: Bill Burcham
>Assignee: Nabarun Nag
>Priority: Major
> Labels: caching-applications
>
> JUnit test failed in this CI run:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK8/builds/134#A
> {code}
> org.apache.geode.internal.ClassPathLoaderJUnitTest >
> redeployingParentClassDoesNotCauseSubclassIncompatibilities FAILED
> java.lang.ClassNotFoundException: jddunit.function.classB
> at
> org.apache.geode.internal.ClassPathLoader.forName(ClassPathLoader.java:186)
> at
> org.apache.geode.internal.ClassPathLoader$1.loadClass(ClassPathLoader.java:366)
> at
> org.apache.geode.internal.ClassPathLoaderJUnitTest.redeployingParentClassDoesNotCauseSubclassIncompatibilities(ClassPathLoaderJUnitTest.java:242)
> {code}
> I ran it 100 times in IntelliJ with no failures. On the theory that maybe we
> ran out of disk I visually traced through the paths dealing w/ (jar) files
> and didn't see anywhere where the product might have been swallowing
> exceptions. So I don't know what went wrong.
> Marked component as serialization because this is testing loading a Jar file
> that redefines a class which was the base class (of a derived class) loaded
> previously from a different jar file. Seems like the point of all that is
> mainly to support users updating their jar files without restarting their
> JVMs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7948) LocatorUDPSecurityDUnitTest > testStartTwoLocatorsWithMultiKeystoreSSL FAILED
[
https://issues.apache.org/jira/browse/GEODE-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104694#comment-17104694
]
Barrett Oglesby commented on GEODE-7948:
Occurred again in DistributedTestOpenJDK8 build 147:
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/147]
> LocatorUDPSecurityDUnitTest > testStartTwoLocatorsWithMultiKeystoreSSL FAILED
> -
>
> Key: GEODE-7948
> URL: https://issues.apache.org/jira/browse/GEODE-7948
> Project: Geode
> Issue Type: Bug
> Components: ci
>Reporter: Ernest Burghardt
>Priority: Major
> Labels: flaky
>
>
> {code:java}
> java.io.EOFException: Locator at HostAndPort
> [socketInetAddress=2c3140cf3e20:29021] did not respond. This is normal if the
> locator was shutdown. If it wasn't check its log for exceptions.
> at
> org.apache.geode.distributed.internal.tcpserver.TcpClient.requestToServer(TcpClient.java:201)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.findCoordinator(GMSJoinLeave.java:1145)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.join(GMSJoinLeave.java:331)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership.join(GMSMembership.java:573)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership.access$1300(GMSMembership.java:71)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.joinDistributedSystem(GMSMembership.java:1972)
> at
> org.apache.geode.distributed.internal.membership.gms.Services.start(Services.java:242)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership.start(GMSMembership.java:1851)
> at
> org.apache.geode.distributed.internal.DistributionImpl.start(DistributionImpl.java:171)
> at
> org.apache.geode.distributed.internal.DistributionImpl.createDistribution(DistributionImpl.java:222)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.(ClusterDistributionManager.java:464)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.(ClusterDistributionManager.java:497)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.create(ClusterDistributionManager.java:326)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:779)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.access$200(InternalDistributedSystem.java:135)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem$Builder.build(InternalDistributedSystem.java:3033)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.connectInternal(InternalDistributedSystem.java:290)
> at
> org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:743)
> at
> org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:388)
> at
> org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:338)
> at org.apache.geode.distributed.Locator.startLocator(Locator.java:252)
> at
> org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:139)
> at
> org.apache.geode.distributed.LocatorDUnitTest.startLocatorWithPortAndProperties(LocatorDUnitTest.java:1507)
> at
> org.apache.geode.distributed.LocatorDUnitTest.lambda$startVerifyAndStopLocator$e21733f2$1(LocatorDUnitTest.java:1539)
> at
> org.apache.geode.test.dunit.internal.IdentifiableRunnable.run(IdentifiableRunnable.java:41)
> {code}
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/9
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (GEODE-8080) Update to ACE 6.5.9, Boost 1.73.0
[ https://issues.apache.org/jira/browse/GEODE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8080. --- > Update to ACE 6.5.9, Boost 1.73.0 > - > > Key: GEODE-8080 > URL: https://issues.apache.org/jira/browse/GEODE-8080 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > > Update to: > * ACE 6.5.9 > * Boost 1.73.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8080) Update to ACE 6.5.9, Boost 1.73.0
[ https://issues.apache.org/jira/browse/GEODE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8080. - Resolution: Fixed > Update to ACE 6.5.9, Boost 1.73.0 > - > > Key: GEODE-8080 > URL: https://issues.apache.org/jira/browse/GEODE-8080 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > > Update to: > * ACE 6.5.9 > * Boost 1.73.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8016) Replace Maven SNAPSHOT with enumerated build-id artifacts
[ https://issues.apache.org/jira/browse/GEODE-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104719#comment-17104719 ] ASF subversion and git services commented on GEODE-8016: Commit 5add60bc6378524e827c53a1b29faae288294576 in geode-examples's branch refs/heads/support/1.13 from Robert Houghton [ https://gitbox.apache.org/repos/asf?p=geode-examples.git;h=5add60b ] Simplify fetch of Geode artifacts. Reset geode version re: GEODE-8016 Authored-by: Robert Houghton (cherry picked from commit a7895d505fc4f309934eeb7e35b112e0a0852c50) > Replace Maven SNAPSHOT with enumerated build-id artifacts > - > > Key: GEODE-8016 > URL: https://issues.apache.org/jira/browse/GEODE-8016 > Project: Geode > Issue Type: Task > Components: build, ci >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > > To better support repeatable builds in CI, publish artifacts in the form > `1.2.3-build.123` instead of `1.2.3-SNAPSHOT` with the SNAPSHOT dynamically > changing. As an example, the `geode-examples` pipeline would be able to grab > a distinct artifact for build-and-test, instead of an unrepeatable, invisibly > rolling `SNAPSHOT`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8016) Replace Maven SNAPSHOT with enumerated build-id artifacts
[ https://issues.apache.org/jira/browse/GEODE-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104720#comment-17104720 ] ASF subversion and git services commented on GEODE-8016: Commit 12ef58357bd5d46564f9cb9a59670735ea1c6e52 in geode-examples's branch refs/heads/support/1.12 from Robert Houghton [ https://gitbox.apache.org/repos/asf?p=geode-examples.git;h=12ef583 ] Simplify fetch of Geode artifacts. Reset geode version re: GEODE-8016 Authored-by: Robert Houghton (cherry picked from commit a7895d505fc4f309934eeb7e35b112e0a0852c50) > Replace Maven SNAPSHOT with enumerated build-id artifacts > - > > Key: GEODE-8016 > URL: https://issues.apache.org/jira/browse/GEODE-8016 > Project: Geode > Issue Type: Task > Components: build, ci >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > > To better support repeatable builds in CI, publish artifacts in the form > `1.2.3-build.123` instead of `1.2.3-SNAPSHOT` with the SNAPSHOT dynamically > changing. As an example, the `geode-examples` pipeline would be able to grab > a distinct artifact for build-and-test, instead of an unrepeatable, invisibly > rolling `SNAPSHOT`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8016) Replace Maven SNAPSHOT with enumerated build-id artifacts
[ https://issues.apache.org/jira/browse/GEODE-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104721#comment-17104721 ] ASF subversion and git services commented on GEODE-8016: Commit 744083fc17636451bb08416e90d9dc41e8e9b3c9 in geode-examples's branch refs/heads/develop from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode-examples.git;h=744083f ] Simplify fetch of Geode artifacts. Reset geode version re: GEODE-8016 > Replace Maven SNAPSHOT with enumerated build-id artifacts > - > > Key: GEODE-8016 > URL: https://issues.apache.org/jira/browse/GEODE-8016 > Project: Geode > Issue Type: Task > Components: build, ci >Reporter: Robert Houghton >Assignee: Robert Houghton >Priority: Major > > To better support repeatable builds in CI, publish artifacts in the form > `1.2.3-build.123` instead of `1.2.3-SNAPSHOT` with the SNAPSHOT dynamically > changing. As an example, the `geode-examples` pipeline would be able to grab > a distinct artifact for build-and-test, instead of an unrepeatable, invisibly > rolling `SNAPSHOT`. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8103) Rename SniSocketFactory to SniProxySocketFactory for consistency.
Jacob Barrett created GEODE-8103: Summary: Rename SniSocketFactory to SniProxySocketFactory for consistency. Key: GEODE-8103 URL: https://issues.apache.org/jira/browse/GEODE-8103 Project: Geode Issue Type: Improvement Reporter: Jacob Barrett The class SniSocketFactory should be renamed SniProxySocketFactory. The class in question produces objects of type SniProxySocket. An "SNI socket" isn’t a thing but an SNI proxy is a thing. The factory class that produces proxy socket factories (yes a meta factory) ProxySocketFactories uses the “ProxySocket” name as well. It fells very inconsistent with all the other classes that make up with API for SniSocketFactory to not have a proxy in it and be called SniProxySocketFactory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8088) Refactor: Move packages in dunit test folder
[ https://issues.apache.org/jira/browse/GEODE-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Ingles resolved GEODE-8088. --- Resolution: Duplicate > Refactor: Move packages in dunit test folder > > > Key: GEODE-8088 > URL: https://issues.apache.org/jira/browse/GEODE-8088 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Murtuza Boxwala >Priority: Major > > Did some refactoring as a group. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8088) Refactor: Move packages in dunit test folder
[ https://issues.apache.org/jira/browse/GEODE-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Ingles closed GEODE-8088. - Assignee: Raymond Ingles > Refactor: Move packages in dunit test folder > > > Key: GEODE-8088 > URL: https://issues.apache.org/jira/browse/GEODE-8088 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Murtuza Boxwala >Assignee: Raymond Ingles >Priority: Major > > Did some refactoring as a group. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8085) Refactor Dunit test locations
[ https://issues.apache.org/jira/browse/GEODE-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Ingles resolved GEODE-8085. --- Assignee: Raymond Ingles Resolution: Fixed > Refactor Dunit test locations > - > > Key: GEODE-8085 > URL: https://issues.apache.org/jira/browse/GEODE-8085 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Raymond Ingles >Assignee: Raymond Ingles >Priority: Major > Fix For: 1.13.0 > > > Place Dunit command tests into folders arranged by data type (e.g. Sets, > Hashes). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8104) CI failure: RollingUpgradeQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion > luceneQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion failed w
Barrett Oglesby created GEODE-8104:
--
Summary: CI failure:
RollingUpgradeQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion >
luceneQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion failed
with ForcedDisconnectException
Key: GEODE-8104
URL: https://issues.apache.org/jira/browse/GEODE-8104
Project: Geode
Issue Type: Bug
Components: lucene
Reporter: Barrett Oglesby
UpgradeTestOpenJDK8 build 151:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK8/builds/151
Failed with:
{noformat}
org.apache.geode.cache.lucene.RollingUpgradeQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion
>
luceneQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion[from_v1.3.0,
with reindex=false, singleHopEnabled=true] FAILED
org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeTestBase$$Lambda$45/1830810133.run
in VM 0 running on Host ed6cdf133f8a with 4 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:610)
at org.apache.geode.test.dunit.VM.invoke(VM.java:437)
at
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeTestBase.verifyLuceneQueryResultInEachVM(LuceneSearchWithRollingUpgradeTestBase.java:317)
at
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeDUnit.executeLuceneQueryWithServerRollOvers(LuceneSearchWithRollingUpgradeDUnit.java:145)
at
org.apache.geode.cache.lucene.RollingUpgradeQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion.luceneQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion(RollingUpgradeQueryReturnsCorrectResultsAfterServersRollOverOnPartitionRegion.java:24)
Caused by:
java.lang.reflect.InvocationTargetException
Caused by:
org.apache.geode.distributed.DistributedSystemDisconnectedException: membership
shutdown, caused by org.apache.geode.ForcedDisconnectException: Member isn't
responding to heartbeat requests
Caused by:
org.apache.geode.ForcedDisconnectException: Member isn't
responding to heartbeat requests
java.lang.AssertionError: Suspicious strings were written to the log during
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 4014
[fatal 2020/05/09 06:23:14.624 GMT
tid=48] Membership service failure: Member isn't responding to heartbeat
requests
org.apache.geode.distributed.internal.membership.api.MemberDisconnectedException:
Member isn't responding to heartbeat requests
at
org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.forceDisconnect(GMSMembership.java:2007)
at
org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:1085)
at
org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:688)
at
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1331)
at
org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1267)
at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
at org.jgroups.JChannel.up(JChannel.java:741)
at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1077)
at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:792)
at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:433)
at
org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:72)
at
org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:70)
at org.jgroups.protocols.TP.passMessageUp(TP.java:1658)
at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1876)
at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1789)
at org.jgroups.protocols.TP.receive(TP.java:1714)
at
org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:159)
at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
at java.lang.Thread.run(Thread.java:748)
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8105) WANRollingUpgradeNewSenderProcessOldEvent > bothOldAndNewEventsShouldBeProcessedByOldSender failed with ConditionTimeoutException
Barrett Oglesby created GEODE-8105:
--
Summary: WANRollingUpgradeNewSenderProcessOldEvent >
bothOldAndNewEventsShouldBeProcessedByOldSender failed with
ConditionTimeoutException
Key: GEODE-8105
URL: https://issues.apache.org/jira/browse/GEODE-8105
Project: Geode
Issue Type: Bug
Components: wan
Reporter: Barrett Oglesby
UpgradeTestOpenJDK8 build 151:
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UpgradeTestOpenJDK8/builds/151
Failed with:
{noformat}
org.apache.geode.cache.wan.WANRollingUpgradeNewSenderProcessOldEvent >
bothOldAndNewEventsShouldBeProcessedByOldSender[from_v1.4.0] FAILED
org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.cache.wan.WANRollingUpgradeNewSenderProcessOldEvent$$Lambda$80/2095718601.run
in VM 1 running on Host b80bdc5d4182 with 7 VMs with version 1.4.0
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:610)
at org.apache.geode.test.dunit.VM.invoke(VM.java:437)
at
org.apache.geode.cache.wan.WANRollingUpgradeNewSenderProcessOldEvent.prepare(WANRollingUpgradeNewSenderProcessOldEvent.java:124)
Caused by:
org.awaitility.core.ConditionTimeoutException: Condition with lambda
expression in org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest was not
fulfilled within 5 minutes.
at
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
at
org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
at
org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
at
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:864)
at
org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest.waitForQueueRegionToCertainSize(WANRollingUpgradeDUnitTest.java:364)
at
org.apache.geode.cache.wan.WANRollingUpgradeNewSenderProcessOldEvent.lambda$prepare$bb17a952$10(WANRollingUpgradeNewSenderProcessOldEvent.java:124)
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8103) Rename SniSocketFactory to SniProxySocketFactory for consistency.
[ https://issues.apache.org/jira/browse/GEODE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob Barrett updated GEODE-8103: - Affects Version/s: 1.14.0 1.13.0 > Rename SniSocketFactory to SniProxySocketFactory for consistency. > - > > Key: GEODE-8103 > URL: https://issues.apache.org/jira/browse/GEODE-8103 > Project: Geode > Issue Type: Improvement >Affects Versions: 1.13.0, 1.14.0 >Reporter: Jacob Barrett >Priority: Major > Fix For: 1.13.0, 1.14.0 > > > The class SniSocketFactory should be renamed SniProxySocketFactory. The class > in question produces objects of type SniProxySocket. An "SNI socket" isn’t a > thing but an SNI proxy is a thing. The factory class that produces proxy > socket factories (yes a meta factory) ProxySocketFactories uses the > “ProxySocket” name as well. It fells very inconsistent with all the other > classes that make up with API for SniSocketFactory to not have a proxy in it > and be called SniProxySocketFactory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8103) Rename SniSocketFactory to SniProxySocketFactory for consistency.
[ https://issues.apache.org/jira/browse/GEODE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob Barrett updated GEODE-8103: - Fix Version/s: 1.14.0 1.13.0 > Rename SniSocketFactory to SniProxySocketFactory for consistency. > - > > Key: GEODE-8103 > URL: https://issues.apache.org/jira/browse/GEODE-8103 > Project: Geode > Issue Type: Improvement >Reporter: Jacob Barrett >Priority: Major > Fix For: 1.13.0, 1.14.0 > > > The class SniSocketFactory should be renamed SniProxySocketFactory. The class > in question produces objects of type SniProxySocket. An "SNI socket" isn’t a > thing but an SNI proxy is a thing. The factory class that produces proxy > socket factories (yes a meta factory) ProxySocketFactories uses the > “ProxySocket” name as well. It fells very inconsistent with all the other > classes that make up with API for SniSocketFactory to not have a proxy in it > and be called SniProxySocketFactory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8103) Rename SniSocketFactory to SniProxySocketFactory for consistency.
[ https://issues.apache.org/jira/browse/GEODE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob Barrett updated GEODE-8103: - Component/s: client/server > Rename SniSocketFactory to SniProxySocketFactory for consistency. > - > > Key: GEODE-8103 > URL: https://issues.apache.org/jira/browse/GEODE-8103 > Project: Geode > Issue Type: Improvement > Components: client/server >Affects Versions: 1.13.0, 1.14.0 >Reporter: Jacob Barrett >Priority: Major > Fix For: 1.13.0, 1.14.0 > > > The class SniSocketFactory should be renamed SniProxySocketFactory. The class > in question produces objects of type SniProxySocket. An "SNI socket" isn’t a > thing but an SNI proxy is a thing. The factory class that produces proxy > socket factories (yes a meta factory) ProxySocketFactories uses the > “ProxySocket” name as well. It fells very inconsistent with all the other > classes that make up with API for SniSocketFactory to not have a proxy in it > and be called SniProxySocketFactory. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8080) Update to ACE 6.5.9, Boost 1.73.0
[ https://issues.apache.org/jira/browse/GEODE-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacob Barrett updated GEODE-8080: - Fix Version/s: 1.14.0 > Update to ACE 6.5.9, Boost 1.73.0 > - > > Key: GEODE-8080 > URL: https://issues.apache.org/jira/browse/GEODE-8080 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Fix For: 1.14.0 > > > Update to: > * ACE 6.5.9 > * Boost 1.73.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8063) Access violation during Cache destrucition caused by ClientMetadataService
[
https://issues.apache.org/jira/browse/GEODE-8063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob Barrett resolved GEODE-8063.
--
Fix Version/s: 1.14.0
Resolution: Fixed
> Access violation during Cache destrucition caused by ClientMetadataService
> --
>
> Key: GEODE-8063
> URL: https://issues.apache.org/jira/browse/GEODE-8063
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
> Fix For: 1.14.0
>
>
> During the destruction of {{Cache}} the pointer to {{CacheImpl}} is invalid.
> Calls from {{ClientMetadataService}} attempt to access {{Pool}} instances
> through the {{Cache}} instance rather than {{CacheImpl}} resulting in access
> violation. This issue is timing dependent and isn't always reproducible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8062) Disable broken tests to avoid accidental runs
[
https://issues.apache.org/jira/browse/GEODE-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob Barrett resolved GEODE-8062.
--
Fix Version/s: 1.14.0
Resolution: Fixed
> Disable broken tests to avoid accidental runs
> -
>
> Key: GEODE-8062
> URL: https://issues.apache.org/jira/browse/GEODE-8062
> Project: Geode
> Issue Type: Improvement
> Components: native client
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
> Fix For: 1.14.0
>
>
> In the initial migration to CMake there wasn't a way to mark tests as
> disabled in CTest. Our solution was to use {{LABELS}}. The use of labels can
> result in unexpected execution of a test during {{--rerun-failed}} or {{-R}}
> options. As of CMake 3.9 you can disabled at test with the {{DISABLED}}
> property.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7682) Create the java API to clear a PartitionedRegion
[ https://issues.apache.org/jira/browse/GEODE-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104786#comment-17104786 ] ASF subversion and git services commented on GEODE-7682: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Create the java API to clear a PartitionedRegion > > > Key: GEODE-7682 > URL: https://issues.apache.org/jira/browse/GEODE-7682 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 7h 50m > Remaining Estimate: 0h > > This task will just include creating the API which calls the internal > commands to clear the region and send messages to the members hosting the > Partitioned region. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8093) redis HSETNX should not allows for multiple field/value pairs
[ https://issues.apache.org/jira/browse/GEODE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104782#comment-17104782 ] ASF subversion and git services commented on GEODE-8093: Commit a0226d6e168477c4dc3f5db0d567a15b06fa0996 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0226d6 ] GEODE-8093: Declare parameter requirements for HSET and HSETNX (#5083) > redis HSETNX should not allows for multiple field/value pairs > - > > Key: GEODE-8093 > URL: https://issues.apache.org/jira/browse/GEODE-8093 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > HSETNX should only support a single field/value pair. But it inherits its > implementation from HSET which supports multiple field/value pairs. > So in order to be compatible with native redis HSETNX should only support a > single field/value pair. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104784#comment-17104784 ] ASF subversion and git services commented on GEODE-7683: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8082) Refactor GeodeRedisServer
[ https://issues.apache.org/jira/browse/GEODE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104783#comment-17104783 ] ASF subversion and git services commented on GEODE-8082: Commit 29b0b22ebca1bd371ed4a04ca2b46751e11979e3 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=29b0b22 ] GEODE-8082: Refactor GeodeRedisServer (#5080) Co-authored-by: Ray Ingles Co-authored-by: john Hutchison Co-authored-by: Darrel Schneider Co-authored-by: Sarah > Refactor GeodeRedisServer > - > > Key: GEODE-8082 > URL: https://issues.apache.org/jira/browse/GEODE-8082 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7684) Implement the Bucket region clear messages and handling
[ https://issues.apache.org/jira/browse/GEODE-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104785#comment-17104785 ] ASF subversion and git services commented on GEODE-7684: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket region clear messages and handling > --- > > Key: GEODE-7684 > URL: https://issues.apache.org/jira/browse/GEODE-7684 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 4h 10m > Remaining Estimate: 0h > > Implement the bucket region clear message, and the handling of the message. > Upon receiving this message the bucket region must be cleared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104792#comment-17104792 ] ASF subversion and git services commented on GEODE-7667: Commit 10831981722b2c74e8db2899306b8a02c8435e1e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1083198 ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104796#comment-17104796 ] ASF subversion and git services commented on GEODE-7683: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8093) redis HSETNX should not allows for multiple field/value pairs
[ https://issues.apache.org/jira/browse/GEODE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104794#comment-17104794 ] ASF subversion and git services commented on GEODE-8093: Commit a0226d6e168477c4dc3f5db0d567a15b06fa0996 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0226d6 ] GEODE-8093: Declare parameter requirements for HSET and HSETNX (#5083) > redis HSETNX should not allows for multiple field/value pairs > - > > Key: GEODE-8093 > URL: https://issues.apache.org/jira/browse/GEODE-8093 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > HSETNX should only support a single field/value pair. But it inherits its > implementation from HSET which supports multiple field/value pairs. > So in order to be compatible with native redis HSETNX should only support a > single field/value pair. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7857) PR.clear's eventID should not be NULL
[ https://issues.apache.org/jira/browse/GEODE-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104788#comment-17104788 ] ASF subversion and git services commented on GEODE-7857: Commit bc38e50724fbb751a6294cae5c4ca3439dfdbee3 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=bc38e50 ] PR.clear's event id should be created and used in BR (#4805) * GEODE-7857: PR.clear's event id should be created and used in BR > PR.clear's eventID should not be NULL > - > > Key: GEODE-7857 > URL: https://issues.apache.org/jira/browse/GEODE-7857 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > > In earlier implementation for PR.clear, I set eventid to be null for the time > being. The event id should be the same at both PR and BR level. but not null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104789#comment-17104789 ] ASF subversion and git services commented on GEODE-7912: Commit 3eae78e7d7ef62875f200d5edb776cc3373eba9f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3eae78e ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104793#comment-17104793 ] ASF subversion and git services commented on GEODE-7676: Commit 56679c621182ee974b336f2bb0cede3de3a790da in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=56679c6 ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104787#comment-17104787 ] ASF subversion and git services commented on GEODE-7683: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104790#comment-17104790 ] ASF subversion and git services commented on GEODE-7983: Commit f61c16adaac19b0ab664b4ca27a1d0b71cf4537e in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f61c16a ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8082) Refactor GeodeRedisServer
[ https://issues.apache.org/jira/browse/GEODE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104795#comment-17104795 ] ASF subversion and git services commented on GEODE-8082: Commit 29b0b22ebca1bd371ed4a04ca2b46751e11979e3 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=29b0b22 ] GEODE-8082: Refactor GeodeRedisServer (#5080) Co-authored-by: Ray Ingles Co-authored-by: john Hutchison Co-authored-by: Darrel Schneider Co-authored-by: Sarah > Refactor GeodeRedisServer > - > > Key: GEODE-8082 > URL: https://issues.apache.org/jira/browse/GEODE-8082 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104791#comment-17104791 ] ASF subversion and git services commented on GEODE-7676: Commit 0ea87378250cb420b389a1ae8a4b83cd40c0 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ea8737 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104799#comment-17104799 ] ASF subversion and git services commented on GEODE-7683: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104805#comment-17104805 ] ASF subversion and git services commented on GEODE-7676: Commit 56679c621182ee974b336f2bb0cede3de3a790da in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=56679c6 ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104803#comment-17104803 ] ASF subversion and git services commented on GEODE-7676: Commit 0ea87378250cb420b389a1ae8a4b83cd40c0 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ea8737 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7857) PR.clear's eventID should not be NULL
[ https://issues.apache.org/jira/browse/GEODE-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104800#comment-17104800 ] ASF subversion and git services commented on GEODE-7857: Commit bc38e50724fbb751a6294cae5c4ca3439dfdbee3 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=bc38e50 ] PR.clear's event id should be created and used in BR (#4805) * GEODE-7857: PR.clear's event id should be created and used in BR > PR.clear's eventID should not be NULL > - > > Key: GEODE-7857 > URL: https://issues.apache.org/jira/browse/GEODE-7857 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > > In earlier implementation for PR.clear, I set eventid to be null for the time > being. The event id should be the same at both PR and BR level. but not null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104801#comment-17104801 ] ASF subversion and git services commented on GEODE-7912: Commit 3eae78e7d7ef62875f200d5edb776cc3373eba9f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3eae78e ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7684) Implement the Bucket region clear messages and handling
[ https://issues.apache.org/jira/browse/GEODE-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104797#comment-17104797 ] ASF subversion and git services commented on GEODE-7684: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket region clear messages and handling > --- > > Key: GEODE-7684 > URL: https://issues.apache.org/jira/browse/GEODE-7684 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 4h 10m > Remaining Estimate: 0h > > Implement the bucket region clear message, and the handling of the message. > Upon receiving this message the bucket region must be cleared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104804#comment-17104804 ] ASF subversion and git services commented on GEODE-7667: Commit 10831981722b2c74e8db2899306b8a02c8435e1e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1083198 ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8093) redis HSETNX should not allows for multiple field/value pairs
[ https://issues.apache.org/jira/browse/GEODE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104807#comment-17104807 ] ASF subversion and git services commented on GEODE-8093: Commit a0226d6e168477c4dc3f5db0d567a15b06fa0996 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0226d6 ] GEODE-8093: Declare parameter requirements for HSET and HSETNX (#5083) > redis HSETNX should not allows for multiple field/value pairs > - > > Key: GEODE-8093 > URL: https://issues.apache.org/jira/browse/GEODE-8093 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > HSETNX should only support a single field/value pair. But it inherits its > implementation from HSET which supports multiple field/value pairs. > So in order to be compatible with native redis HSETNX should only support a > single field/value pair. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104802#comment-17104802 ] ASF subversion and git services commented on GEODE-7983: Commit f61c16adaac19b0ab664b4ca27a1d0b71cf4537e in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f61c16a ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7682) Create the java API to clear a PartitionedRegion
[ https://issues.apache.org/jira/browse/GEODE-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104798#comment-17104798 ] ASF subversion and git services commented on GEODE-7682: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Create the java API to clear a PartitionedRegion > > > Key: GEODE-7682 > URL: https://issues.apache.org/jira/browse/GEODE-7682 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 7h 50m > Remaining Estimate: 0h > > This task will just include creating the API which calls the internal > commands to clear the region and send messages to the members hosting the > Partitioned region. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104819#comment-17104819 ] ASF subversion and git services commented on GEODE-7676: Commit 56679c621182ee974b336f2bb0cede3de3a790da in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=56679c6 ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7857) PR.clear's eventID should not be NULL
[ https://issues.apache.org/jira/browse/GEODE-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104813#comment-17104813 ] ASF subversion and git services commented on GEODE-7857: Commit bc38e50724fbb751a6294cae5c4ca3439dfdbee3 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=bc38e50 ] PR.clear's event id should be created and used in BR (#4805) * GEODE-7857: PR.clear's event id should be created and used in BR > PR.clear's eventID should not be NULL > - > > Key: GEODE-7857 > URL: https://issues.apache.org/jira/browse/GEODE-7857 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > > In earlier implementation for PR.clear, I set eventid to be null for the time > being. The event id should be the same at both PR and BR level. but not null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104815#comment-17104815 ] ASF subversion and git services commented on GEODE-7983: Commit f61c16adaac19b0ab664b4ca27a1d0b71cf4537e in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f61c16a ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7684) Implement the Bucket region clear messages and handling
[ https://issues.apache.org/jira/browse/GEODE-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104810#comment-17104810 ] ASF subversion and git services commented on GEODE-7684: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket region clear messages and handling > --- > > Key: GEODE-7684 > URL: https://issues.apache.org/jira/browse/GEODE-7684 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 4h 10m > Remaining Estimate: 0h > > Implement the bucket region clear message, and the handling of the message. > Upon receiving this message the bucket region must be cleared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104809#comment-17104809 ] ASF subversion and git services commented on GEODE-7683: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104814#comment-17104814 ] ASF subversion and git services commented on GEODE-7912: Commit 3eae78e7d7ef62875f200d5edb776cc3373eba9f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3eae78e ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8082) Refactor GeodeRedisServer
[ https://issues.apache.org/jira/browse/GEODE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104808#comment-17104808 ] ASF subversion and git services commented on GEODE-8082: Commit 29b0b22ebca1bd371ed4a04ca2b46751e11979e3 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=29b0b22 ] GEODE-8082: Refactor GeodeRedisServer (#5080) Co-authored-by: Ray Ingles Co-authored-by: john Hutchison Co-authored-by: Darrel Schneider Co-authored-by: Sarah > Refactor GeodeRedisServer > - > > Key: GEODE-8082 > URL: https://issues.apache.org/jira/browse/GEODE-8082 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104817#comment-17104817 ] ASF subversion and git services commented on GEODE-7676: Commit 0ea87378250cb420b389a1ae8a4b83cd40c0 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ea8737 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104818#comment-17104818 ] ASF subversion and git services commented on GEODE-7667: Commit 10831981722b2c74e8db2899306b8a02c8435e1e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1083198 ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7682) Create the java API to clear a PartitionedRegion
[ https://issues.apache.org/jira/browse/GEODE-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104811#comment-17104811 ] ASF subversion and git services commented on GEODE-7682: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Create the java API to clear a PartitionedRegion > > > Key: GEODE-7682 > URL: https://issues.apache.org/jira/browse/GEODE-7682 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 7h 50m > Remaining Estimate: 0h > > This task will just include creating the API which calls the internal > commands to clear the region and send messages to the members hosting the > Partitioned region. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104812#comment-17104812 ] ASF subversion and git services commented on GEODE-7683: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104830#comment-17104830 ] ASF subversion and git services commented on GEODE-7667: Commit 10831981722b2c74e8db2899306b8a02c8435e1e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1083198 ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7682) Create the java API to clear a PartitionedRegion
[ https://issues.apache.org/jira/browse/GEODE-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104824#comment-17104824 ] ASF subversion and git services commented on GEODE-7682: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Create the java API to clear a PartitionedRegion > > > Key: GEODE-7682 > URL: https://issues.apache.org/jira/browse/GEODE-7682 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 7h 50m > Remaining Estimate: 0h > > This task will just include creating the API which calls the internal > commands to clear the region and send messages to the members hosting the > Partitioned region. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8082) Refactor GeodeRedisServer
[ https://issues.apache.org/jira/browse/GEODE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104821#comment-17104821 ] ASF subversion and git services commented on GEODE-8082: Commit 29b0b22ebca1bd371ed4a04ca2b46751e11979e3 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=29b0b22 ] GEODE-8082: Refactor GeodeRedisServer (#5080) Co-authored-by: Ray Ingles Co-authored-by: john Hutchison Co-authored-by: Darrel Schneider Co-authored-by: Sarah > Refactor GeodeRedisServer > - > > Key: GEODE-8082 > URL: https://issues.apache.org/jira/browse/GEODE-8082 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7912) cacheWriter should be triggered when PR.clear
[ https://issues.apache.org/jira/browse/GEODE-7912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104827#comment-17104827 ] ASF subversion and git services commented on GEODE-7912: Commit 3eae78e7d7ef62875f200d5edb776cc3373eba9f in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=3eae78e ] GEODE-7912: cacheWriter should be triggered when PR.clear (#4882) Co-authored-by: Anil Co-authored-by: Xiaojian Zhou > cacheWriter should be triggered when PR.clear > - > > Key: GEODE-7912 > URL: https://issues.apache.org/jira/browse/GEODE-7912 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > If server configured cacheWriter, PR.clear should trigger it the same way as > PR.destroyRegion does. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7857) PR.clear's eventID should not be NULL
[ https://issues.apache.org/jira/browse/GEODE-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104826#comment-17104826 ] ASF subversion and git services commented on GEODE-7857: Commit bc38e50724fbb751a6294cae5c4ca3439dfdbee3 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=bc38e50 ] PR.clear's event id should be created and used in BR (#4805) * GEODE-7857: PR.clear's event id should be created and used in BR > PR.clear's eventID should not be NULL > - > > Key: GEODE-7857 > URL: https://issues.apache.org/jira/browse/GEODE-7857 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > > In earlier implementation for PR.clear, I set eventid to be null for the time > being. The event id should be the same at both PR and BR level. but not null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104828#comment-17104828 ] ASF subversion and git services commented on GEODE-7983: Commit f61c16adaac19b0ab664b4ca27a1d0b71cf4537e in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f61c16a ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104822#comment-17104822 ] ASF subversion and git services commented on GEODE-7683: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104825#comment-17104825 ] ASF subversion and git services commented on GEODE-7683: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7684) Implement the Bucket region clear messages and handling
[ https://issues.apache.org/jira/browse/GEODE-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104823#comment-17104823 ] ASF subversion and git services commented on GEODE-7684: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket region clear messages and handling > --- > > Key: GEODE-7684 > URL: https://issues.apache.org/jira/browse/GEODE-7684 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 4h 10m > Remaining Estimate: 0h > > Implement the bucket region clear message, and the handling of the message. > Upon receiving this message the bucket region must be cleared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104831#comment-17104831 ] ASF subversion and git services commented on GEODE-7676: Commit 56679c621182ee974b336f2bb0cede3de3a790da in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=56679c6 ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104829#comment-17104829 ] ASF subversion and git services commented on GEODE-7676: Commit 0ea87378250cb420b389a1ae8a4b83cd40c0 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ea8737 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8093) redis HSETNX should not allows for multiple field/value pairs
[ https://issues.apache.org/jira/browse/GEODE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104820#comment-17104820 ] ASF subversion and git services commented on GEODE-8093: Commit a0226d6e168477c4dc3f5db0d567a15b06fa0996 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0226d6 ] GEODE-8093: Declare parameter requirements for HSET and HSETNX (#5083) > redis HSETNX should not allows for multiple field/value pairs > - > > Key: GEODE-8093 > URL: https://issues.apache.org/jira/browse/GEODE-8093 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > HSETNX should only support a single field/value pair. But it inherits its > implementation from HSET which supports multiple field/value pairs. > So in order to be compatible with native redis HSETNX should only support a > single field/value pair. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104835#comment-17104835 ] ASF subversion and git services commented on GEODE-7683: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104844#comment-17104844 ] ASF subversion and git services commented on GEODE-7676: Commit 56679c621182ee974b336f2bb0cede3de3a790da in geode's branch refs/heads/feature/GEODE-7665 from Nabarun Nag [ https://gitbox.apache.org/repos/asf?p=geode.git;h=56679c6 ] GEODE-7676: Conversion of duration to seconds. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8082) Refactor GeodeRedisServer
[ https://issues.apache.org/jira/browse/GEODE-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104834#comment-17104834 ] ASF subversion and git services commented on GEODE-8082: Commit 29b0b22ebca1bd371ed4a04ca2b46751e11979e3 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=29b0b22 ] GEODE-8082: Refactor GeodeRedisServer (#5080) Co-authored-by: Ray Ingles Co-authored-by: john Hutchison Co-authored-by: Darrel Schneider Co-authored-by: Sarah > Refactor GeodeRedisServer > - > > Key: GEODE-8082 > URL: https://issues.apache.org/jira/browse/GEODE-8082 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7676) All expiration tasks are cleared after a Partitioned Region is cleared
[ https://issues.apache.org/jira/browse/GEODE-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104842#comment-17104842 ] ASF subversion and git services commented on GEODE-7676: Commit 0ea87378250cb420b389a1ae8a4b83cd40c0 in geode's branch refs/heads/feature/GEODE-7665 from Juan José Ramos [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0ea8737 ] GEODE-7676: Add PR clear with expiration tests (#4970) Added distributed tests to verify the clear operation on Partitioned Regions works as expected when expiration is configured. - Added unit and distributed tests. - Fixed LocalRegion class to clear the entryExpiryTasks Map whenever the cancelAllEntryExpiryTasks method is invoked. > All expiration tasks are cleared after a Partitioned Region is cleared > -- > > Key: GEODE-7676 > URL: https://issues.apache.org/jira/browse/GEODE-7676 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Juan Ramos >Priority: Major > Labels: GeodeCommons, feature/GEODE-7665 > Time Spent: 1h 50m > Remaining Estimate: 0h > > Clear operations are successful and all the expiration tasks are cleared in > the bucket level > Acceptance : > * DUnit tests ensuring that clear operations are successful > * Expiration tasks are cleared. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7857) PR.clear's eventID should not be NULL
[ https://issues.apache.org/jira/browse/GEODE-7857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104839#comment-17104839 ] ASF subversion and git services commented on GEODE-7857: Commit bc38e50724fbb751a6294cae5c4ca3439dfdbee3 in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=bc38e50 ] PR.clear's event id should be created and used in BR (#4805) * GEODE-7857: PR.clear's event id should be created and used in BR > PR.clear's eventID should not be NULL > - > > Key: GEODE-7857 > URL: https://issues.apache.org/jira/browse/GEODE-7857 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > > In earlier implementation for PR.clear, I set eventid to be null for the time > being. The event id should be the same at both PR and BR level. but not null. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7667) GFSH commands - uniform gfsh command to clear regions
[ https://issues.apache.org/jira/browse/GEODE-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104843#comment-17104843 ] ASF subversion and git services commented on GEODE-7667: Commit 10831981722b2c74e8db2899306b8a02c8435e1e in geode's branch refs/heads/feature/GEODE-7665 from BenjaminPerryRoss [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1083198 ] GEODE-7667: Add a 'clear' gfsh command for PR and RR clear (#4818) * Added clear command and modified remove functionality to clear PR Authored-by: Benjamin Ross > GFSH commands - uniform gfsh command to clear regions > - > > Key: GEODE-7667 > URL: https://issues.apache.org/jira/browse/GEODE-7667 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, docs > Time Spent: 5h > Remaining Estimate: 0h > > * Currently, the gfsh command to clear replicated region is called ‘remove > —region=/regionName’. > * Replace this command with ‘clear region —region=regionName’ > * While executing this gfsh command on partitioned regions, this should call > the clear() Java API using the gfsh function execution machinery. > * Point to note is that this command should take into consideration of the > coordinator selection and how this command is distributed to the members > Acceptance : > * There should be ‘clear region —region=/regionName’ gfsh command > * The gfsh command must be documented in the Geode User Guide > * DUnit tests to verify that command can be executed successfully on > PartitionedRegion > * Deprecate the remove command, as remove does not mean clear > * Unit tests with complete code coverage for the newly written code. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7683) Implement the Bucket Region cmnClearRegion
[ https://issues.apache.org/jira/browse/GEODE-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104838#comment-17104838 ] ASF subversion and git services commented on GEODE-7683: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Implement the Bucket Region cmnClearRegion > --- > > Key: GEODE-7683 > URL: https://issues.apache.org/jira/browse/GEODE-7683 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 4h > Remaining Estimate: 0h > > Implement the method to clear up a bucket region -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7684) Implement the Bucket region clear messages and handling
[ https://issues.apache.org/jira/browse/GEODE-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104836#comment-17104836 ] ASF subversion and git services commented on GEODE-7684: Commit 7ad1190d8ca514c12af7076c656efdf928d2cefd in geode's branch refs/heads/feature/GEODE-7665 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ad1190 ] GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou GEODE-7684: Create messaging class for PR Clear (#4689) * Added new message class and test Co-authored-by: Benjamin Ross Co-authored-by: Donal Evans > Implement the Bucket region clear messages and handling > --- > > Key: GEODE-7684 > URL: https://issues.apache.org/jira/browse/GEODE-7684 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 4h 10m > Remaining Estimate: 0h > > Implement the bucket region clear message, and the handling of the message. > Upon receiving this message the bucket region must be cleared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8093) redis HSETNX should not allows for multiple field/value pairs
[ https://issues.apache.org/jira/browse/GEODE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104833#comment-17104833 ] ASF subversion and git services commented on GEODE-8093: Commit a0226d6e168477c4dc3f5db0d567a15b06fa0996 in geode's branch refs/heads/feature/GEODE-7665 from Murtuza Boxwala [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a0226d6 ] GEODE-8093: Declare parameter requirements for HSET and HSETNX (#5083) > redis HSETNX should not allows for multiple field/value pairs > - > > Key: GEODE-8093 > URL: https://issues.apache.org/jira/browse/GEODE-8093 > Project: Geode > Issue Type: Bug > Components: redis >Reporter: Darrel Schneider >Priority: Major > Labels: easy-fix > Fix For: 1.14.0 > > > HSETNX should only support a single field/value pair. But it inherits its > implementation from HSET which supports multiple field/value pairs. > So in order to be compatible with native redis HSETNX should only support a > single field/value pair. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7682) Create the java API to clear a PartitionedRegion
[ https://issues.apache.org/jira/browse/GEODE-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104837#comment-17104837 ] ASF subversion and git services commented on GEODE-7682: Commit 362bad56e45f3e984425d76be0fe8c38c14f80aa in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=362bad5 ] GEODE-7682: add PR.clear API (#4755) * GEODE-7683: introduce BR.cmnClearRegion Co-authored-by: Xiaojian Zhou > Create the java API to clear a PartitionedRegion > > > Key: GEODE-7682 > URL: https://issues.apache.org/jira/browse/GEODE-7682 > Project: Geode > Issue Type: New Feature > Components: regions >Reporter: Nabarun Nag >Priority: Major > Labels: GeodeCommons > Time Spent: 7h 50m > Remaining Estimate: 0h > > This task will just include creating the API which calls the internal > commands to clear the region and send messages to the members hosting the > Partitioned region. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7983) Clear region writer callbacks should not be invoked for bucket regions
[ https://issues.apache.org/jira/browse/GEODE-7983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104841#comment-17104841 ] ASF subversion and git services commented on GEODE-7983: Commit f61c16adaac19b0ab664b4ca27a1d0b71cf4537e in geode's branch refs/heads/feature/GEODE-7665 from Xiaojian Zhou [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f61c16a ] GEODE-7983: Clear region writer callbacks should not be invoked for bucket regions (#4954) > Clear region writer callbacks should not be invoked for bucket regions > -- > > Key: GEODE-7983 > URL: https://issues.apache.org/jira/browse/GEODE-7983 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeCommons > Fix For: 1.13.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Region destroy will not trigger cacheWriter for bucket region. we should keep > the same behavior for clear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
