[jira] [Created] (GEODE-5995) Include docker gradle plugin in buildSrc

2018-11-06 Thread Jens Deppe (JIRA)
Jens Deppe created GEODE-5995:
-

 Summary: Include docker gradle plugin in buildSrc
 Key: GEODE-5995
 URL: https://issues.apache.org/jira/browse/GEODE-5995
 Project: Geode
  Issue Type: Task
  Components: build
Reporter: Jens Deppe


As I see it, we have a few issues with this plugin:

- We've cloned the plugin to our own repo
- Made changes which are not upstream (and probably will never be)
- Do not have a formal build process for it
- Have already missed some changes which cause build failures



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-5995) Include docker gradle plugin in buildSrc

2018-11-06 Thread Jens Deppe (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe reassigned GEODE-5995:
-

Assignee: Jens Deppe

> Include docker gradle plugin in buildSrc
> 
>
> Key: GEODE-5995
> URL: https://issues.apache.org/jira/browse/GEODE-5995
> Project: Geode
>  Issue Type: Task
>  Components: build
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
>
> As I see it, we have a few issues with this plugin:
> - We've cloned the plugin to our own repo
> - Made changes which are not upstream (and probably will never be)
> - Do not have a formal build process for it
> - Have already missed some changes which cause build failures



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-5995) Include docker gradle plugin in buildSrc

2018-11-06 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5995:
--
Labels: pull-request-available  (was: )

> Include docker gradle plugin in buildSrc
> 
>
> Key: GEODE-5995
> URL: https://issues.apache.org/jira/browse/GEODE-5995
> Project: Geode
>  Issue Type: Task
>  Components: build
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> As I see it, we have a few issues with this plugin:
> - We've cloned the plugin to our own repo
> - Made changes which are not upstream (and probably will never be)
> - Do not have a formal build process for it
> - Have already missed some changes which cause build failures



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5942) prefix variables in PersistenceManager

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676911#comment-16676911
 ] 

ASF subversion and git services commented on GEODE-5942:


Commit 5dcf04589ffb1b58fbe4fc36f0bc469591a16024 in geode-native's branch 
refs/heads/develop from [~bbender]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=5dcf045 ]

GEODE-5942: Remove named constants from PersistenceManager (#393)

- These should just be agreed-upon values between client code and plugin

Co-authored-by: Sai Boorlagaddda 

> prefix variables in PersistenceManager
> --
>
> Key: GEODE-5942
> URL: https://issues.apache.org/jira/browse/GEODE-5942
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Sai Boorlagadda
>Assignee: Sai Boorlagadda
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> PersistenceManager has a variable PAGE_SIZE which is bad can cause conflicts, 
> so change it to PM_PAGE_SIZE.
> Also, do this for other variables to be consistent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5985) Possible integer overflow before assigning result to a long variable

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677005#comment-16677005
 ] 

ASF subversion and git services commented on GEODE-5985:


Commit 37d6025381b04b6f6407e506e1af30be0413d4ce in geode's branch 
refs/heads/feature/GEODE-5985 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=37d6025 ]

GEODE-5985 Possible integer overflow before assigning result to a long variable

Fixing problems in IndexElemArray.  It was throwing an
ArrayIndexOutOfBoundsException if its capacity was exceeded and this
totally damaged the array as its size would then be a negative number.

With the fix the array's capacity now has a limit of 255 instead of 128.


> Possible integer overflow before assigning result to a long variable
> 
>
> Key: GEODE-5985
> URL: https://issues.apache.org/jira/browse/GEODE-5985
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are many places where we are performing a calculation on an int 
> variable and then storing the result in a long variable.  For instance,
> long milliseconds = intVariable * 1000;
> For correctness we should cast the int variable to a long or add an L to the 
> numeric multiplier.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-5996) Review and update dependencies for v1.8.0

2018-11-06 Thread Anthony Baker (JIRA)
Anthony Baker created GEODE-5996:


 Summary: Review and update dependencies for v1.8.0
 Key: GEODE-5996
 URL: https://issues.apache.org/jira/browse/GEODE-5996
 Project: Geode
  Issue Type: Improvement
  Components: build
Reporter: Anthony Baker






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5984) Address LGTM recommendations

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677033#comment-16677033
 ] 

ASF subversion and git services commented on GEODE-5984:


Commit a3b648613536d55376c5bc87509f0efc4f9f8f02 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a3b6486 ]

GEODE-5984 Address LGTM recommendations

Addressing minor issues in javadocs and code reported by LooksGoodToMe.

One change that I made wasn't reported by that tool: I removed
two static variables from AcceptorImpl that duplicated variables in
Handshake.

This closes #2780


> Address LGTM recommendations
> 
>
> Key: GEODE-5984
> URL: https://issues.apache.org/jira/browse/GEODE-5984
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> There is a list of 87 minor "recommendations" from the LooksGoodToMe CI 
> integration report for 2b4313a:
> Implicit conversion from Array to String.
> Avoid automated semicolon insertion (97% of all statements in the enclosing 
> function have an explicit semicolon).
> @param for phantom parameters
> Missing spaces in concatenated string literals
> Others are in javascript files used by geode-book and Pulse.
> https://lgtm.com/projects/g/apache/incubator-geode/alerts/?mode=list&severity=recommendation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-5984) Address LGTM recommendations

2018-11-06 Thread Bruce Schuchardt (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-5984.
-
   Resolution: Fixed
Fix Version/s: 1.8.0

> Address LGTM recommendations
> 
>
> Key: GEODE-5984
> URL: https://issues.apache.org/jira/browse/GEODE-5984
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> There is a list of 87 minor "recommendations" from the LooksGoodToMe CI 
> integration report for 2b4313a:
> Implicit conversion from Array to String.
> Avoid automated semicolon insertion (97% of all statements in the enclosing 
> function have an explicit semicolon).
> @param for phantom parameters
> Missing spaces in concatenated string literals
> Others are in javascript files used by geode-book and Pulse.
> https://lgtm.com/projects/g/apache/incubator-geode/alerts/?mode=list&severity=recommendation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5986) Inconsistent equals/hashCode

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677046#comment-16677046
 ] 

ASF subversion and git services commented on GEODE-5986:


Commit 355527c638c6f5ca7fd76332cb726b675abf22ce in geode's branch 
refs/heads/feature/GEODE-5986 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=355527c ]

GEODE-5986 Inconsistent equals/hashCode

Added hashCode and equals methods to classes that were missing one or
the other.


> Inconsistent equals/hashCode
> 
>
> Key: GEODE-5986
> URL: https://issues.apache.org/jira/browse/GEODE-5986
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>
> LGTM reports 47 classes with inconsistent equals & hashCode methods
> https://lgtm.com/projects/g/apache/incubator-geode/alerts/?mode=tree&lang=java&severity=error&ruleFocus=6770060



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-5986) Inconsistent equals/hashCode

2018-11-06 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5986:
--
Labels: pull-request-available  (was: )

> Inconsistent equals/hashCode
> 
>
> Key: GEODE-5986
> URL: https://issues.apache.org/jira/browse/GEODE-5986
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> LGTM reports 47 classes with inconsistent equals & hashCode methods
> https://lgtm.com/projects/g/apache/incubator-geode/alerts/?mode=tree&lang=java&severity=error&ruleFocus=6770060



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5984) Address LGTM recommendations

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677058#comment-16677058
 ] 

ASF subversion and git services commented on GEODE-5984:


Commit a3b648613536d55376c5bc87509f0efc4f9f8f02 in geode's branch 
refs/heads/feature/GEODE-5986 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a3b6486 ]

GEODE-5984 Address LGTM recommendations

Addressing minor issues in javadocs and code reported by LooksGoodToMe.

One change that I made wasn't reported by that tool: I removed
two static variables from AcceptorImpl that duplicated variables in
Handshake.

This closes #2780


> Address LGTM recommendations
> 
>
> Key: GEODE-5984
> URL: https://issues.apache.org/jira/browse/GEODE-5984
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> There is a list of 87 minor "recommendations" from the LooksGoodToMe CI 
> integration report for 2b4313a:
> Implicit conversion from Array to String.
> Avoid automated semicolon insertion (97% of all statements in the enclosing 
> function have an explicit semicolon).
> @param for phantom parameters
> Missing spaces in concatenated string literals
> Others are in javascript files used by geode-book and Pulse.
> https://lgtm.com/projects/g/apache/incubator-geode/alerts/?mode=list&severity=recommendation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5938) Make dependencies explicit in cq and rebalancer modules

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677050#comment-16677050
 ] 

ASF subversion and git services commented on GEODE-5938:


Commit 7f657f9646b7d58d44aed2e35e556dd7cf0c6824 in geode's branch 
refs/heads/feature/GEODE-5986 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7f657f9 ]

GEODE-5938: Make dependencies explicit in cq and rebalancer modules. (#2729)



> Make dependencies explicit in cq and rebalancer modules
> ---
>
> Key: GEODE-5938
> URL: https://issues.apache.org/jira/browse/GEODE-5938
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5986) Inconsistent equals/hashCode

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677059#comment-16677059
 ] 

ASF subversion and git services commented on GEODE-5986:


Commit fd255883a8dd3c0d192e3b394dc27b239296ed72 in geode's branch 
refs/heads/feature/GEODE-5986 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fd25588 ]

Merge branch 'develop' into feature/GEODE-5986

> Inconsistent equals/hashCode
> 
>
> Key: GEODE-5986
> URL: https://issues.apache.org/jira/browse/GEODE-5986
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> LGTM reports 47 classes with inconsistent equals & hashCode methods
> https://lgtm.com/projects/g/apache/incubator-geode/alerts/?mode=tree&lang=java&severity=error&ruleFocus=6770060



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5992) Code improvements found by static analysis

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677055#comment-16677055
 ] 

ASF subversion and git services commented on GEODE-5992:


Commit b65b36477b931453276c72138bde676f6c5362db in geode's branch 
refs/heads/feature/GEODE-5986 from [~amb]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b65b364 ]

GEODE-5992 Fix bugs identified by static analysis


> Code improvements found by static analysis
> --
>
> Key: GEODE-5992
> URL: https://issues.apache.org/jira/browse/GEODE-5992
> Project: Geode
>  Issue Type: Bug
>Reporter: Anthony Baker
>Priority: Major
> Fix For: 1.8.0
>
>
> Update code to address high priority warnings from findbugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5884) Executing a function with non HA should return any available partial results

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677056#comment-16677056
 ] 

ASF subversion and git services commented on GEODE-5884:


Commit 0f517d3cd5d21d0d061ddce2bbcd67d9bb599dc7 in geode's branch 
refs/heads/feature/GEODE-5986 from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0f517d3 ]

GEODE-5884: Restores behavior of exceptions/wrapping of exceptions (#2786)


* Previous refactor in a5daa924 was causing behavioral changes
   with function exceptions when combining with GEODE-5884

> Executing a function with non HA should return any available partial results
> 
>
> Key: GEODE-5884
> URL: https://issues.apache.org/jira/browse/GEODE-5884
> Project: Geode
>  Issue Type: Bug
>  Components: functions
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> When a function is executed without single hop, it is sent to a 
> "coordinating" node.  This node then creates tasks that are executed on other 
> remote nodes and itself.  If any of the remote nodes or the local node gets 
> an exception, it will accumulate the exception and any results it has 
> currently received.  It then completes and sends those results back to the 
> client.
> There is a flag to waitOnException.  We should set this to true if the 
> function is non HA.  This will have the coordinating node wait for all 
> results before sending back to the client.  The work is going to get executed 
> on the remote nodes anyways, so why not wait for the results?
> This will mirror a single-hop execution where a single node may fail.  If it 
> does, the client still receives results from the other nodes.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5976) Prevent conversion of string to bytes multiple times

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677052#comment-16677052
 ] 

ASF subversion and git services commented on GEODE-5976:


Commit 915dcd8f725f868da171db611bd44a72dcb602c4 in geode's branch 
refs/heads/feature/GEODE-5986 from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=915dcd8 ]

GEODE-5976:Prevent conversion of string to bytes (#2772)

* prevents the conversion of string to bytes everytime equals is called on the 
immutable strings

> Prevent conversion of string to bytes multiple times
> 
>
> Key: GEODE-5976
> URL: https://issues.apache.org/jira/browse/GEODE-5976
> Project: Geode
>  Issue Type: Bug
>Reporter: nabarun
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Prevent the conversion of string to bytes multiple times when equals is 
> called on 
> ByteArrayWrapper and a string value.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5980) Remove collections from the code that are not used.

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677053#comment-16677053
 ] 

ASF subversion and git services commented on GEODE-5980:


Commit 6f303b30bcd1b97e08415917b7720a0fc1c4ce90 in geode's branch 
refs/heads/feature/GEODE-5986 from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6f303b3 ]

GEODE-5980: Removed unused collections. (#2774)

* Removed collections that are populated but are never used.

> Remove collections from the code that are not used.
> ---
>
> Key: GEODE-5980
> URL: https://issues.apache.org/jira/browse/GEODE-5980
> Project: Geode
>  Issue Type: Bug
>Reporter: nabarun
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> There are a couple of collections that are initialized and populated but are 
> never accessed. Those need to be removed.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5983) Compare boxed primitives using equals() rather than ==

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677054#comment-16677054
 ] 

ASF subversion and git services commented on GEODE-5983:


Commit 54cf7d1e6ec966167f7e5e855f054f9e4ae4bafa in geode's branch 
refs/heads/feature/GEODE-5986 from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=54cf7d1 ]

GEODE-5983: use equals() instead of == (#2777)

* For boxed primitive types equals() is used instead of ==

> Compare boxed primitives using equals() rather than ==
> --
>
> Key: GEODE-5983
> URL: https://issues.apache.org/jira/browse/GEODE-5983
> Project: Geode
>  Issue Type: Bug
>Reporter: nabarun
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Files affected:
> [DistributedCacheOperation.java|https://lgtm.com/projects/g/apache/incubator-geode/snapshot/8c3d7f0677a5c6d167d1927ebb2e8056b67086fe/files/geode-core/src/main/java/org/apache/geode/internal/cache/DistributedCacheOperation.java]
> [SqlHandler.java|https://lgtm.com/projects/g/apache/incubator-geode/snapshot/8c3d7f0677a5c6d167d1927ebb2e8056b67086fe/files/geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/SqlHandler.java]
> [RegionFunctionArgs.java|https://lgtm.com/projects/g/apache/incubator-geode/snapshot/8c3d7f0677a5c6d167d1927ebb2e8056b67086fe/files/geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/RegionFunctionArgs.java]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5884) Executing a function with non HA should return any available partial results

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677057#comment-16677057
 ] 

ASF subversion and git services commented on GEODE-5884:


Commit 0f517d3cd5d21d0d061ddce2bbcd67d9bb599dc7 in geode's branch 
refs/heads/feature/GEODE-5986 from [~huynhja]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0f517d3 ]

GEODE-5884: Restores behavior of exceptions/wrapping of exceptions (#2786)


* Previous refactor in a5daa924 was causing behavioral changes
   with function exceptions when combining with GEODE-5884

> Executing a function with non HA should return any available partial results
> 
>
> Key: GEODE-5884
> URL: https://issues.apache.org/jira/browse/GEODE-5884
> Project: Geode
>  Issue Type: Bug
>  Components: functions
>Affects Versions: 1.0.0-incubating
>Reporter: Jason Huynh
>Assignee: Jason Huynh
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> When a function is executed without single hop, it is sent to a 
> "coordinating" node.  This node then creates tasks that are executed on other 
> remote nodes and itself.  If any of the remote nodes or the local node gets 
> an exception, it will accumulate the exception and any results it has 
> currently received.  It then completes and sends those results back to the 
> client.
> There is a flag to waitOnException.  We should set this to true if the 
> function is non HA.  This will have the coordinating node wait for all 
> results before sending back to the client.  The work is going to get executed 
> on the remote nodes anyways, so why not wait for the results?
> This will mirror a single-hop execution where a single node may fail.  If it 
> does, the client still receives results from the other nodes.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5937) Make dependencies explicit in geode-protobuf

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677051#comment-16677051
 ] 

ASF subversion and git services commented on GEODE-5937:


Commit 7babb27f3639d9ab170509fe6c51a1a193c31a7e in geode's branch 
refs/heads/feature/GEODE-5986 from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7babb27 ]

GEODE-5937: Made dependencies explicit in geode-protobuf modules. (#2722)



> Make dependencies explicit in geode-protobuf
> 
>
> Key: GEODE-5937
> URL: https://issues.apache.org/jira/browse/GEODE-5937
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (GEODE-5742) ComparisonFailure in GfshExecution.awaitTermination (from GfshDisconnectWithinScript)

2018-11-06 Thread Jason Huynh (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reopened GEODE-5742:

  Assignee: (was: Brian Rowe)

Reopening due to seeing similar failure on:

 
[http://files.apachegeode-ci.info/builds/apache-develop-main/1.8.0-build.98/test-results/acceptanceTest/1541445429/classes/org.apache.geode.management.internal.cli.shell.StatusServerExitCodeAcceptanceTest.html#statusCommandWithIncorrectPidShouldFail]
{noformat}
org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e>
at 
jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at 
jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
org.apache.geode.test.junit.rules.gfsh.GfshExecution.awaitTermination(GfshExecution.java:123)
at 
org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:125)
at 
org.apache.geode.test.junit.rules.gfsh.GfshScript.execute(GfshScript.java:133)
at 
org.apache.geode.management.internal.cli.shell.StatusServerExitCodeAcceptanceTest.statusCommandWithIncorrectPidShouldFail(StatusServerExitCodeAcceptanceTest.java:99)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:106)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at 
org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:117)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)

[jira] [Commented] (GEODE-5595) CI: DeltaPropagationDUnit.testBug40165ClientReconnects - NoSubscriptionServersAvailableException

2018-11-06 Thread Jason Huynh (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677089#comment-16677089
 ] 

Jason Huynh commented on GEODE-5595:


 

We ran into a similar but not exact failure, below is the stack trace from run: 

http://files.apachegeode-ci.info/builds/apache-develop-main/1.8.0-build.99/test-results/distributedTest/1541452365/classes/org.apache.geode.cache.client.internal.ClientServerHostNameVerificationDistributedTest.html#expectConnectionFailureWhenNoHostNameInServerKey
{noformat}
java.lang.AssertionError: Suspicious strings were written to the log during 
this run. Fix the strings or use IgnoredException.addIgnoredException to 
ignore. --- 
Found suspect string in log4j at line 1553 javax.net.ssl.SSLProtocolException: 
Connection reset at org.junit.Assert.fail(Assert.java:88) at 
org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:412)
 at 
org.apache.geode.test.dunit.rules.ClusterStartupRule.after(ClusterStartupRule.java:172)
 at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50) at 
org.junit.rules.RunRules.evaluate(RunRules.java:20) at 
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at 
org.junit.runners.ParentRunner.run(ParentRunner.java:363) at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:106)
 at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
 at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
 at 
org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:66)
 at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:566) at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
 at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
 at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
 at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
 at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:117)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:566) at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
 at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
 at 
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155)
 at 
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137)
 at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
 at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
 at 
org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) 
at 
org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
 at java.lang.Thread.run(Thread.java:834)
{noformat}
 

> CI: DeltaPropagationDUnit.testBug40165ClientReconnects - 
> NoSubscriptionServersAvailableException
> ---

[jira] [Comment Edited] (GEODE-5595) CI: DeltaPropagationDUnit.testBug40165ClientReconnects - NoSubscriptionServersAvailableException

2018-11-06 Thread Jason Huynh (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677089#comment-16677089
 ] 

Jason Huynh edited comment on GEODE-5595 at 11/6/18 6:00 PM:
-

 

We ran into a similar but not exact failure, below is the stack trace from run: 

http://files.apachegeode-ci.info/builds/apache-develop-main/1.8.0-build.99/test-results/distributedTest/1541452365/classes/org.apache.geode.cache.client.internal.ClientServerHostNameVerificationDistributedTest.html#expectConnectionFailureWhenNoHostNameInServerKey

{noformat}
java.lang.AssertionError: Suspicious strings were written to the log during 
this run. Fix the strings or use IgnoredException.addIgnoredException to 
ignore. --- 
Found suspect string in log4j at line 1553 javax.net.ssl.SSLProtocolException: 
Connection reset at org.junit.Assert.fail(Assert.java:88) at 
org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:412)
 at 
org.apache.geode.test.dunit.rules.ClusterStartupRule.after(ClusterStartupRule.java:172)
 at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50) at 
org.junit.rules.RunRules.evaluate(RunRules.java:20) at 
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
 at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at 
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at 
org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at 
org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at 
org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at 
org.junit.runners.ParentRunner.run(ParentRunner.java:363) at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:106)
 at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
 at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
 at 
org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:66)
 at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:566) at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
 at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
 at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
 at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
 at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:117)
 at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
 at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:566) at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
 at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
 at 
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155)
 at 
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137)
 at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
 at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
 at 
org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
 at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) 
at 
org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
 at java.lang.Thread.run(Thread.java:834)
{noformat}
 


was (Author: huynhja):
 

We ran into a similar but not exact failure, below is the stack trace from run: 

http

[jira] [Comment Edited] (GEODE-5595) CI: DeltaPropagationDUnit.testBug40165ClientReconnects - NoSubscriptionServersAvailableException

2018-11-06 Thread Jason Huynh (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677089#comment-16677089
 ] 

Jason Huynh edited comment on GEODE-5595 at 11/6/18 6:01 PM:
-

 

We ran into a similar but not exact failure, below is the stack trace from run: 

http://files.apachegeode-ci.info/builds/apache-develop-main/1.8.0-build.99/test-results/distributedTest/1541452365/classes/org.apache.geode.cache.client.internal.ClientServerHostNameVerificationDistributedTest.html#expectConnectionFailureWhenNoHostNameInServerKey

{noformat}
java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 1553

javax.net.ssl.SSLProtocolException: Connection reset


at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:412)
at 
org.apache.geode.test.dunit.rules.ClusterStartupRule.after(ClusterStartupRule.java:172)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:106)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at 
org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:117)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155)
at 
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
at 
org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(Th

[jira] [Comment Edited] (GEODE-5595) CI: DeltaPropagationDUnit.testBug40165ClientReconnects - NoSubscriptionServersAvailableException

2018-11-06 Thread Jason Huynh (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677089#comment-16677089
 ] 

Jason Huynh edited comment on GEODE-5595 at 11/6/18 6:03 PM:
-

 

We ran into a similar but not exact failure on jdk11, below is the stack trace 
from run: 

http://files.apachegeode-ci.info/builds/apache-develop-main/1.8.0-build.99/test-results/distributedTest/1541452365/classes/org.apache.geode.cache.client.internal.ClientServerHostNameVerificationDistributedTest.html#expectConnectionFailureWhenNoHostNameInServerKey

{noformat}
java.lang.AssertionError: Suspicious strings were written to the log during 
this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
---
Found suspect string in log4j at line 1553

javax.net.ssl.SSLProtocolException: Connection reset


at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.geode.test.dunit.standalone.DUnitLauncher.closeAndCheckForSuspects(DUnitLauncher.java:412)
at 
org.apache.geode.test.dunit.rules.ClusterStartupRule.after(ClusterStartupRule.java:172)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:50)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:106)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at 
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at 
org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:66)
at 
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at 
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at 
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:117)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at 
org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at 
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155)
at 
org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137)
at 
org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
at 
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
at 
org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.util.concurrent.ThreadPoolExecutor$Wor

[jira] [Commented] (GEODE-5595) CI: DeltaPropagationDUnit.testBug40165ClientReconnects - NoSubscriptionServersAvailableException

2018-11-06 Thread Jason Huynh (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677102#comment-16677102
 ] 

Jason Huynh commented on GEODE-5595:


Saw this again in : 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.8.0-build.103/test-results/distributedTest/1541465597/classes/org.apache.geode.internal.cache.DeltaPropagationDUnitTest.html#testBug40165ClientReconnects



> CI: DeltaPropagationDUnit.testBug40165ClientReconnects - 
> NoSubscriptionServersAvailableException
> 
>
> Key: GEODE-5595
> URL: https://issues.apache.org/jira/browse/GEODE-5595
> Project: Geode
>  Issue Type: Bug
>Reporter: Kenneth Howe
>Assignee: Mark Hanson
>Priority: Major
>  Labels: pull-request-available, swat
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> This test failed. See _Issue Links_ section below for a bunch of other tests 
> that seem to fail due to the same underlying product fault. See [~klund]'s 
> analysis cited in the comment section for that underlying fault. Don't mark 
> this ticket resolved until that product problem is really fixed please.
> {code:java}
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest > 
> testBug40165ClientReconnects FAILED
>   
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could not 
> initialize a primary queue on startup. No queue servers available.
>   
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:187)
>   
> at 
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:548)
>   
> at 
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:855)
>   
> at 
> org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
>   
> at 
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:355)
>   
> at 
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3797)
>   
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3888)
>   
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3686)
>   
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3681)
>   
> at 
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3676)
>   
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1305)
>   
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.testBug40165ClientReconnects(DeltaPropagationDUnitTest.java:647)
>   
>   
> Caused by:
>   
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Could 
> not initialize a primary queue on startup. No queue servers available.
>   
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.initializeConnections(QueueManagerImpl.java:585)
>   
> at 
> org.apache.geode.cache.client.internal.QueueManagerImpl.start(QueueManagerImpl.java:296)
>   
> at 
> org.apache.geode.cache.client.internal.PoolImpl.start(PoolImpl.java:352)
>   
> at 
> org.apache.geode.cache.client.internal.PoolImpl.finishCreate(PoolImpl.java:176)
>   
> at 
> org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:162)
>   
> at 
> org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:349)
>   
> at 
> org.apache.geode.internal.cache.DeltaPropagationDUnitTest.createDurableCacheClient(DeltaPropagationDUnitTest.java:1295)
>   
> ... 1 more
>   
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5228) ServerLauncherRemoteFileIntegrationTest fails intermittently with IllegalStateException vf.gf.server.status is blank

2018-11-06 Thread Jason Huynh (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677106#comment-16677106
 ] 

Jason Huynh commented on GEODE-5228:


Ran into this again : 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.8.0-build.95/test-results/integrationTest/1541439491/classes/org.apache.geode.distributed.ServerLauncherRemoteFileIntegrationTest.html#startDeletesStaleControlFiles

{noformat}
java.lang.IllegalStateException: Status file 
'/tmp/junit8287552360679473422/vf.gf.server.status' is blank
at 
org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:151)
at 
org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:88)
at 
org.apache.geode.distributed.ServerLauncher.statusWithWorkingDirectory(ServerLauncher.java:1116)
at 
org.apache.geode.distributed.ServerLauncher.status(ServerLauncher.java:1064)
at 
org.apache.geode.distributed.ServerLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(ServerLauncherRemoteIntegrationTestCase.java:200)
at 
org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
at 
org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:192)
at 
org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:179)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{noformat}

> ServerLauncherRemoteFileIntegrationTest fails intermittently with 
> IllegalStateException vf.gf.server.status is blank
> 
>
> Key: GEODE-5228
> URL: https://issues.apache.org/jira/browse/GEODE-5228
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Kirk Lund
>Priority: Minor
>  Labels: ServerLauncher, ci, flaky, swat
>
> {noformat}
> java.lang.IllegalStateException: Status file 
> '/tmp/build/ae3c03f4/built-geode/tmp/junit5775773082469887234/vf.gf.server.status'
>  is blank
>   at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:152)
>   at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
>   at 
> org.apache.geode.distributed.ServerLauncher.statusWithWorkingDirectory(ServerLauncher.java:1102)
>   at 
> org.apache.geode.distributed.ServerLauncher.status(ServerLauncher.java:1050)
>   at 
> org.apache.geode.distributed.ServerLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(ServerLauncherRemoteIntegrationTestCase.java:198)
>   at 
> org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
>   at 
> org.awaitility.core.ConditionAwaiter$ConditionPoller.run(ConditionAwaiter.java:215)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-5997) Make FastLogger optimization work without using isEnabled clause

2018-11-06 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-5997:


 Summary: Make FastLogger optimization work without using isEnabled 
clause
 Key: GEODE-5997
 URL: https://issues.apache.org/jira/browse/GEODE-5997
 Project: Geode
  Issue Type: Wish
  Components: logging
Reporter: Kirk Lund


Geode logger statements at debug or trace level currently have isDebugEnabled 
and isTraceEnabled clauses which are overridden by FastLogger to improve 
performance of disabled log statements.

If FastLogger is changed to override every method defined in the ExtendedLogger 
interface, then we can delete all isDebugEnabled and isTraceEnabled clauses.

It would be ideal to include new JMH benchmarks with any changes involving 
FastLogger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-5338) Geode client to support Trust and Keystore rotation

2018-11-06 Thread Sai Boorlagadda (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sai Boorlagadda resolved GEODE-5338.

Resolution: Fixed

> Geode client to support Trust and Keystore rotation
> ---
>
> Key: GEODE-5338
> URL: https://issues.apache.org/jira/browse/GEODE-5338
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, security
>Reporter: Pulkit Chandra
>Assignee: Sai Boorlagadda
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> WHY: Cloud Foundry provides ability to rotate certs pretty frequently. By 
> default the certs are rotated every day and change be changed to rotate every 
> hour. Which creates a issue with Java applications. This rotation is 
> essential to provide a strong security stance on client applications.
> WHAT: Today Geode client applications, when establishing a TLS connection to 
> the servers requires a path to the certificate, since these files would be 
> changing we need a mechanism in Geode which will watch for these changes and 
> use the new certs without causing service disruption.
>  
> Solution options:
> Some options to consider
>  # Cloud Foundry has a lib which watches for changes to these certs (which 
> are in pem format)and converts them and creates inmemory objects of 
> TrustStore and KeyStore. If we have a mechanism in Geode to pass these 
> objects instead of path to them, we might have a solution. Also, these 
> objects gets updates after rotation so the geode code needs to consider that 
> as well.
>  # Geode can develop its own capability to watch for change on the files and 
> convert them to right format using OpenSSL and create files and pass them in. 
> Update these file everytime someone updates the certs
>  # Geode starts accepting pem files and watches them directly for changes.
>  
> Key Outcomes to watch for:
>  1. Provide ability to rotate cert easily without downtime.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-5998) Redis adapter: add geospatial operations

2018-11-06 Thread Galen O'Sullivan (JIRA)
Galen O'Sullivan created GEODE-5998:
---

 Summary: Redis adapter: add geospatial operations
 Key: GEODE-5998
 URL: https://issues.apache.org/jira/browse/GEODE-5998
 Project: Geode
  Issue Type: Bug
  Components: redis
Reporter: Galen O'Sullivan






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5998) Redis adapter: add geospatial operations

2018-11-06 Thread Galen O'Sullivan (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677142#comment-16677142
 ] 

Galen O'Sullivan commented on GEODE-5998:
-

https://github.com/apache/geode/pull/2210

> Redis adapter: add geospatial operations
> 
>
> Key: GEODE-5998
> URL: https://issues.apache.org/jira/browse/GEODE-5998
> Project: Geode
>  Issue Type: New Feature
>  Components: redis
>Reporter: Galen O'Sullivan
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-5998) Redis adapter: add geospatial operations

2018-11-06 Thread Galen O'Sullivan (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan updated GEODE-5998:

Issue Type: New Feature  (was: Bug)

> Redis adapter: add geospatial operations
> 
>
> Key: GEODE-5998
> URL: https://issues.apache.org/jira/browse/GEODE-5998
> Project: Geode
>  Issue Type: New Feature
>  Components: redis
>Reporter: Galen O'Sullivan
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5985) Possible integer overflow before assigning result to a long variable

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677149#comment-16677149
 ] 

ASF subversion and git services commented on GEODE-5985:


Commit 86c86ac6bfd4fbb19d383260f1f7193532082f1a in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=86c86ac ]

GEODE-5985 Possible integer overflow

We had a number of calculations that were taking place with ints instead
of longs.  I've modified them to, in most places, just add an L to the
constant multiplier.  In other places I had to change a variable type
from int to long.

There were a few places that were also assigning a long to an int
variable or an int to a byte variable.  In these I added bit AND
operators to reduce the chances of overflow.

IndexElemArray needed a lot of work due to its "size" instvar being
a byte.

This closes #2783


> Possible integer overflow before assigning result to a long variable
> 
>
> Key: GEODE-5985
> URL: https://issues.apache.org/jira/browse/GEODE-5985
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are many places where we are performing a calculation on an int 
> variable and then storing the result in a long variable.  For instance,
> long milliseconds = intVariable * 1000;
> For correctness we should cast the int variable to a long or add an L to the 
> numeric multiplier.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-5985) Possible integer overflow before assigning result to a long variable

2018-11-06 Thread Bruce Schuchardt (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-5985.
-
   Resolution: Fixed
Fix Version/s: 1.8.0

> Possible integer overflow before assigning result to a long variable
> 
>
> Key: GEODE-5985
> URL: https://issues.apache.org/jira/browse/GEODE-5985
> Project: Geode
>  Issue Type: Bug
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> There are many places where we are performing a calculation on an int 
> variable and then storing the result in a long variable.  For instance,
> long milliseconds = intVariable * 1000;
> For correctness we should cast the int variable to a long or add an L to the 
> numeric multiplier.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5978) Expand GeodeAwaitility so that the default timeout can be used for Mockito.timeout

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677166#comment-16677166
 ] 

ASF subversion and git services commented on GEODE-5978:


Commit 28785d0608574bd8d9027bd780429a4c4d82a80d in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=28785d0 ]

GEODE-5978: Expand GeodeAwaitility and add test coverage

Add getTimeout to allow the default timeout to be used for more than
just Awaitility (for example, with Mockito.timeout).

Add toTimeDuration to facilitate conversions between java.time.Duration
and org.awaitility.Duration.

Make timeout non-static for testing and write some unit tests.


> Expand GeodeAwaitility so that the default timeout can be used for 
> Mockito.timeout
> --
>
> Key: GEODE-5978
> URL: https://issues.apache.org/jira/browse/GEODE-5978
> Project: Geode
>  Issue Type: Wish
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Many tests use Mockito.verify which supports Mockito.timeout. I'd like to 
> expose the timeout in GeodeAwaitility for use with Mockito.timeout. I'd also 
> like to add toTimeDuration to facilitate conversions between 
> java.time.Duration and org.awaitility.Duration.
> Since GeodeAwaitility does not have any unit tests, we should also make it 
> testable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-5999) separate Java 8 and 11 testing into separate pipeline boxes

2018-11-06 Thread Owen Nichols (JIRA)
Owen Nichols created GEODE-5999:
---

 Summary: separate Java 8 and 11 testing into separate pipeline 
boxes
 Key: GEODE-5999
 URL: https://issues.apache.org/jira/browse/GEODE-5999
 Project: Geode
  Issue Type: Sub-task
  Components: ci
Reporter: Owen Nichols


although this moves us the wrong direction relative to long-term goal of 
selecting only a subset of tests to run on multiple versions of Java, popular 
demand at the moment is to have an unreadable pipeline with 18 boxes stacked 
one atop the other.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-5999) separate Java 8 and 11 testing into separate pipeline boxes

2018-11-06 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5999:
--
Labels: pull-request-available  (was: )

> separate Java 8 and 11 testing into separate pipeline boxes
> ---
>
> Key: GEODE-5999
> URL: https://issues.apache.org/jira/browse/GEODE-5999
> Project: Geode
>  Issue Type: Sub-task
>  Components: ci
>Reporter: Owen Nichols
>Priority: Major
>  Labels: pull-request-available
>
> although this moves us the wrong direction relative to long-term goal of 
> selecting only a subset of tests to run on multiple versions of Java, popular 
> demand at the moment is to have an unreadable pipeline with 18 boxes stacked 
> one atop the other.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5918) Geode function security should be dynamically determined by function arguments

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677184#comment-16677184
 ] 

ASF subversion and git services commented on GEODE-5918:


Commit d02315d1fc989779da6d364c92beaed947fe728f in geode's branch 
refs/heads/develop from [~ivorzhou]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=d02315d ]

GEODE-5918 Geode function security should be dynamically determined by function 
arguments (#2727)




> Geode function security should be dynamically determined by function arguments
> --
>
> Key: GEODE-5918
> URL: https://issues.apache.org/jira/browse/GEODE-5918
> Project: Geode
>  Issue Type: Improvement
>  Components: functions, security
>Reporter: ivorzhou
>Priority: Critical
>  Labels: pull-request-available
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Now in Function interface there is a method
> default Collection getRequiredPermissions(String 
> regionName) {
>  return Collections.singletonList(ResourcePermissions.DATA_WRITE);
> }
>  
> Which only support statically security determination in design 
> time(regionName is not enough).
> In some situation,we require determining security on function arguments.
>  
> I think add a method in this interface like
> default Collection getRequiredPermissions(String 
> regionName,Object args) {
> return getRequiredPermissions(regionName);
> }
>  
> and in server side command,call the new method with regionName and arguments 
> together.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5947) Make dependencies explicit in connectors and experimental-driver modules

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677221#comment-16677221
 ] 

ASF subversion and git services commented on GEODE-5947:


Commit a103871dcdde89d68282844e9e25bf9a376de5b6 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a103871 ]

GEODE-5947: Make dependencies explicit in connectors and experimental-driver 
modules (#2738)



> Make dependencies explicit in connectors and experimental-driver modules
> 
>
> Key: GEODE-5947
> URL: https://issues.apache.org/jira/browse/GEODE-5947
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Patrick Rhomberg
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5977) jdbc-mapping --connection should be renamed to --data-source

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677249#comment-16677249
 ] 

ASF subversion and git services commented on GEODE-5977:


Commit 72a5b0bd70746f4bf43022d576617da76c11531f in geode's branch 
refs/heads/develop from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=72a5b0b ]

GEODE-5977: rename --connection to --data-source (#2773)



> jdbc-mapping --connection should be renamed to --data-source
> 
>
> Key: GEODE-5977
> URL: https://issues.apache.org/jira/browse/GEODE-5977
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, extensions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> For consistency with "gfsh create data-source" the --connection option on 
> gfsh create jdbc-mapping should be renamed to --data-source.
> This is also consistent with other extensions.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-5977) jdbc-mapping --connection should be renamed to --data-source

2018-11-06 Thread Darrel Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider resolved GEODE-5977.
-
   Resolution: Fixed
Fix Version/s: 1.8.0

> jdbc-mapping --connection should be renamed to --data-source
> 
>
> Key: GEODE-5977
> URL: https://issues.apache.org/jira/browse/GEODE-5977
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, extensions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> For consistency with "gfsh create data-source" the --connection option on 
> gfsh create jdbc-mapping should be renamed to --data-source.
> This is also consistent with other extensions.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-6000) jdbc-mapping --pdx-name should be required

2018-11-06 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-6000:
---

 Summary: jdbc-mapping --pdx-name should be required
 Key: GEODE-6000
 URL: https://issues.apache.org/jira/browse/GEODE-6000
 Project: Geode
  Issue Type: Improvement
  Components: extensions
Reporter: Darrel Schneider


The jdbc-mapping command has a --pdx-name option. It should be required.

Currently if no pdx- name is given then the data will be pdx instances that do 
not have a domain class. Support for these "typeless" pdx instances should be 
removed and an error thrown if the required pdx-name is not given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-6000) jdbc-mapping --pdx-name should be required

2018-11-06 Thread Darrel Schneider (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-6000:
---

Assignee: Darrel Schneider

> jdbc-mapping --pdx-name should be required
> --
>
> Key: GEODE-6000
> URL: https://issues.apache.org/jira/browse/GEODE-6000
> Project: Geode
>  Issue Type: Improvement
>  Components: extensions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>
> The jdbc-mapping command has a --pdx-name option. It should be required.
> Currently if no pdx- name is given then the data will be pdx instances that 
> do not have a domain class. Support for these "typeless" pdx instances should 
> be removed and an error thrown if the required pdx-name is not given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-6001) move dependency to OpenSSL v 1.1.1 (TLS)

2018-11-06 Thread Ernest Burghardt (JIRA)
Ernest Burghardt created GEODE-6001:
---

 Summary: move dependency to OpenSSL v 1.1.1 (TLS)
 Key: GEODE-6001
 URL: https://issues.apache.org/jira/browse/GEODE-6001
 Project: Geode
  Issue Type: Task
Reporter: Ernest Burghardt


OpenSSL 1.1.1 (LTS) was released 2018-09-11



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-6001) move dependency to OpenSSL v 1.1.1 (TLS)

2018-11-06 Thread Ernest Burghardt (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt updated GEODE-6001:

Component/s: native client

> move dependency to OpenSSL v 1.1.1 (TLS)
> 
>
> Key: GEODE-6001
> URL: https://issues.apache.org/jira/browse/GEODE-6001
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Ernest Burghardt
>Priority: Major
>
> OpenSSL 1.1.1 (LTS) was released 2018-09-11



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5987) Dependencies should not be injected into every subproject by test.gradle

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677308#comment-16677308
 ] 

ASF subversion and git services commented on GEODE-5987:


Commit 10df202df6425c0b90d7a7c8522925c6c4f7ac76 in geode's branch 
refs/heads/develop from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=10df202 ]

GEODE-5987: Do not inject dependencies into all subprojects in test.gradle 
(#2782)

* Removed several unnecessary testCompile dependencies: 
* Moved other dependencies to those modules that require them (and are not 
having them leaked by other project modules)
* Injection of testRuntime dependency on cglib to be addressed in a future 
commit.

> Dependencies should not be injected into every subproject by test.gradle
> 
>
> Key: GEODE-5987
> URL: https://issues.apache.org/jira/browse/GEODE-5987
> Project: Geode
>  Issue Type: Sub-task
>Reporter: Patrick Rhomberg
>Assignee: Patrick Rhomberg
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Dependencies should be explicit, particularly for those dependencies on 
> internal modules that would influence the larger gradle task graph.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-6002) Member specific configuration is not persisted in the cluster configuration

2018-11-06 Thread Kenneth Howe (JIRA)
Kenneth Howe created GEODE-6002:
---

 Summary: Member specific configuration is not persisted in the 
cluster configuration
 Key: GEODE-6002
 URL: https://issues.apache.org/jira/browse/GEODE-6002
 Project: Geode
  Issue Type: Bug
  Components: gfsh
Reporter: Kenneth Howe


Some commands, such as {{create gateway-receiver}} have an option 
({{--member}}) to restrict the command to a single server member in the 
cluster. This member specific action now creates the object on the server but 
does not store the configuration information in the cluster configuration. The 
same command, when used without the {{--member}} option will save the 
information as an entry in the cluster configuration.

If a member with specific configuration shuts down and is then restarted, the 
object (e.g. gateway-receiver) will not be recreated because there is no 
persisted record of it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-6002) Member specific configuration is not persisted in the cluster configuration

2018-11-06 Thread Kenneth Howe (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kenneth Howe reassigned GEODE-6002:
---

 Assignee: Kenneth Howe
Affects Version/s: 1.7.0

> Member specific configuration is not persisted in the cluster configuration
> ---
>
> Key: GEODE-6002
> URL: https://issues.apache.org/jira/browse/GEODE-6002
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.7.0
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>Priority: Major
>
> Some commands, such as {{create gateway-receiver}} have an option 
> ({{--member}}) to restrict the command to a single server member in the 
> cluster. This member specific action now creates the object on the server but 
> does not store the configuration information in the cluster configuration. 
> The same command, when used without the {{--member}} option will save the 
> information as an entry in the cluster configuration.
> If a member with specific configuration shuts down and is then restarted, the 
> object (e.g. gateway-receiver) will not be recreated because there is no 
> persisted record of it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-6002) Member specific configuration is not persisted in the cluster configuration

2018-11-06 Thread Kenneth Howe (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677356#comment-16677356
 ] 

Kenneth Howe commented on GEODE-6002:
-

The following commands have a {{--member}} option and may affect the 
configuration:
{code}
DestroyGatewayReceiverCommand.java
CreateGatewayReceiverCommand.java
StartGatewayReceiverCommand.java
DestroyIndexCommand.java
CreateDefinedIndexesCommand.java
DestroyFunctionCommand.java
CreateIndexCommand.java
AlterRuntimeConfigCommand.java
CreateGatewaySenderCommand.java
DestroyGatewaySenderCommand.java
StartGatewaySenderCommand.java
{code}

> Member specific configuration is not persisted in the cluster configuration
> ---
>
> Key: GEODE-6002
> URL: https://issues.apache.org/jira/browse/GEODE-6002
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.7.0
>Reporter: Kenneth Howe
>Assignee: Kenneth Howe
>Priority: Major
>
> Some commands, such as {{create gateway-receiver}} have an option 
> ({{--member}}) to restrict the command to a single server member in the 
> cluster. This member specific action now creates the object on the server but 
> does not store the configuration information in the cluster configuration. 
> The same command, when used without the {{--member}} option will save the 
> information as an entry in the cluster configuration.
> If a member with specific configuration shuts down and is then restarted, the 
> object (e.g. gateway-receiver) will not be recreated because there is no 
> persisted record of it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-5338) Geode client to support Trust and Keystore rotation

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677370#comment-16677370
 ] 

ASF subversion and git services commented on GEODE-5338:


Commit dbf3692ea1d413db53eb32eb91b51f9ec1de90c2 in geode's branch 
refs/heads/develop from [~sai.boorlaga...@gmail.com]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=dbf3692 ]

GEODE-5338: Rephrased warning when SSL hostname validation is disabled (#2793)



> Geode client to support Trust and Keystore rotation
> ---
>
> Key: GEODE-5338
> URL: https://issues.apache.org/jira/browse/GEODE-5338
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, security
>Reporter: Pulkit Chandra
>Assignee: Sai Boorlagadda
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> WHY: Cloud Foundry provides ability to rotate certs pretty frequently. By 
> default the certs are rotated every day and change be changed to rotate every 
> hour. Which creates a issue with Java applications. This rotation is 
> essential to provide a strong security stance on client applications.
> WHAT: Today Geode client applications, when establishing a TLS connection to 
> the servers requires a path to the certificate, since these files would be 
> changing we need a mechanism in Geode which will watch for these changes and 
> use the new certs without causing service disruption.
>  
> Solution options:
> Some options to consider
>  # Cloud Foundry has a lib which watches for changes to these certs (which 
> are in pem format)and converts them and creates inmemory objects of 
> TrustStore and KeyStore. If we have a mechanism in Geode to pass these 
> objects instead of path to them, we might have a solution. Also, these 
> objects gets updates after rotation so the geode code needs to consider that 
> as well.
>  # Geode can develop its own capability to watch for change on the files and 
> convert them to right format using OpenSSL and create files and pass them in. 
> Update these file everytime someone updates the certs
>  # Geode starts accepting pem files and watches them directly for changes.
>  
> Key Outcomes to watch for:
>  1. Provide ability to rotate cert easily without downtime.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-2484) Remove ACE from native client dependencies

2018-11-06 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-2484:
--
Labels: pull-request-available  (was: )

> Remove ACE from native client dependencies
> --
>
> Key: GEODE-2484
> URL: https://issues.apache.org/jira/browse/GEODE-2484
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: David Kimura
>Priority: Major
>  Labels: pull-request-available
>
> Remove ACE from native client dependencies.
> Replace ACE usage with C++11 and/or Boost 1.63+



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-6003) windows image java 11 install fails when successfully installed

2018-11-06 Thread Owen Nichols (JIRA)
Owen Nichols created GEODE-6003:
---

 Summary: windows image java 11 install fails when successfully 
installed
 Key: GEODE-6003
 URL: https://issues.apache.org/jira/browse/GEODE-6003
 Project: Geode
  Issue Type: Sub-task
  Components: ci
Reporter: Owen Nichols


the step at the end to kill java fails the entire build, if java has already 
exited normally.  lack of a java process to kill should be treated as success 
instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-5228) ServerLauncherRemoteFileIntegrationTest fails intermittently with IllegalStateException vf.gf.server.status is blank

2018-11-06 Thread Jason Huynh (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh reassigned GEODE-5228:
--

Assignee: Jason Huynh

> ServerLauncherRemoteFileIntegrationTest fails intermittently with 
> IllegalStateException vf.gf.server.status is blank
> 
>
> Key: GEODE-5228
> URL: https://issues.apache.org/jira/browse/GEODE-5228
> Project: Geode
>  Issue Type: Bug
>  Components: management, tests
>Reporter: Kirk Lund
>Assignee: Jason Huynh
>Priority: Minor
>  Labels: ServerLauncher, ci, flaky, swat
>
> {noformat}
> java.lang.IllegalStateException: Status file 
> '/tmp/build/ae3c03f4/built-geode/tmp/junit5775773082469887234/vf.gf.server.status'
>  is blank
>   at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:152)
>   at 
> org.apache.geode.internal.process.FileProcessController.status(FileProcessController.java:89)
>   at 
> org.apache.geode.distributed.ServerLauncher.statusWithWorkingDirectory(ServerLauncher.java:1102)
>   at 
> org.apache.geode.distributed.ServerLauncher.status(ServerLauncher.java:1050)
>   at 
> org.apache.geode.distributed.ServerLauncherRemoteIntegrationTestCase.lambda$awaitStart$1(ServerLauncherRemoteIntegrationTestCase.java:198)
>   at 
> org.awaitility.core.AssertionCondition$1.eval(AssertionCondition.java:55)
>   at 
> org.awaitility.core.ConditionAwaiter$ConditionPoller.run(ConditionAwaiter.java:215)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-6003) windows image java 11 install fails when successfully installed

2018-11-06 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-6003:
--
Labels: pull-request-available  (was: )

> windows image java 11 install fails when successfully installed
> ---
>
> Key: GEODE-6003
> URL: https://issues.apache.org/jira/browse/GEODE-6003
> Project: Geode
>  Issue Type: Sub-task
>  Components: ci
>Reporter: Owen Nichols
>Priority: Major
>  Labels: pull-request-available
>
> the step at the end to kill java fails the entire build, if java has already 
> exited normally.  lack of a java process to kill should be treated as success 
> instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-6003) windows image java 11 install fails when successfully installed

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677417#comment-16677417
 ] 

ASF subversion and git services commented on GEODE-6003:


Commit 6f950fda874835a2415709a5bf20f9813bb5ad06 in geode's branch 
refs/heads/develop from [~dcavender]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6f950fd ]

Merge pull request #2796 from onichols-pivotal/GEODE-6003-fix-windows-image

GEODE-6003 don't fail if we can't kill a process because it's already exited

> windows image java 11 install fails when successfully installed
> ---
>
> Key: GEODE-6003
> URL: https://issues.apache.org/jira/browse/GEODE-6003
> Project: Geode
>  Issue Type: Sub-task
>  Components: ci
>Reporter: Owen Nichols
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> the step at the end to kill java fails the entire build, if java has already 
> exited normally.  lack of a java process to kill should be treated as success 
> instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-6003) windows image java 11 install fails when successfully installed

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677415#comment-16677415
 ] 

ASF subversion and git services commented on GEODE-6003:


Commit a7aeca9df4a7b5fc327dd23ffc56a807c4056021 in geode's branch 
refs/heads/develop from [~onichols-pivotal]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a7aeca9 ]

GEODE-6003 don't fail if we can't kill a process because it's already exited

added -ErrorAction ignore to ensure we continue the script if the
process does not need to be killed because it has already exited.


> windows image java 11 install fails when successfully installed
> ---
>
> Key: GEODE-6003
> URL: https://issues.apache.org/jira/browse/GEODE-6003
> Project: Geode
>  Issue Type: Sub-task
>  Components: ci
>Reporter: Owen Nichols
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> the step at the end to kill java fails the entire build, if java has already 
> exited normally.  lack of a java process to kill should be treated as success 
> instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-6003) windows image java 11 install fails when successfully installed

2018-11-06 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/GEODE-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677416#comment-16677416
 ] 

ASF subversion and git services commented on GEODE-6003:


Commit 6f950fda874835a2415709a5bf20f9813bb5ad06 in geode's branch 
refs/heads/develop from [~dcavender]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6f950fd ]

Merge pull request #2796 from onichols-pivotal/GEODE-6003-fix-windows-image

GEODE-6003 don't fail if we can't kill a process because it's already exited

> windows image java 11 install fails when successfully installed
> ---
>
> Key: GEODE-6003
> URL: https://issues.apache.org/jira/browse/GEODE-6003
> Project: Geode
>  Issue Type: Sub-task
>  Components: ci
>Reporter: Owen Nichols
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> the step at the end to kill java fails the entire build, if java has already 
> exited normally.  lack of a java process to kill should be treated as success 
> instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-6003) windows image java 11 install fails when successfully installed

2018-11-06 Thread Owen Nichols (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Owen Nichols resolved GEODE-6003.
-
   Resolution: Fixed
Fix Version/s: 1.8.0

> windows image java 11 install fails when successfully installed
> ---
>
> Key: GEODE-6003
> URL: https://issues.apache.org/jira/browse/GEODE-6003
> Project: Geode
>  Issue Type: Sub-task
>  Components: ci
>Reporter: Owen Nichols
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> the step at the end to kill java fails the entire build, if java has already 
> exited normally.  lack of a java process to kill should be treated as success 
> instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-5997) Make FastLogger optimization work without using isEnabled clause

2018-11-06 Thread Kirk Lund (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-5997:


Assignee: Kirk Lund

> Make FastLogger optimization work without using isEnabled clause
> 
>
> Key: GEODE-5997
> URL: https://issues.apache.org/jira/browse/GEODE-5997
> Project: Geode
>  Issue Type: Wish
>  Components: logging
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>
> Geode logger statements at debug or trace level currently have isDebugEnabled 
> and isTraceEnabled clauses which are overridden by FastLogger to improve 
> performance of disabled log statements.
> If FastLogger is changed to override every method defined in the 
> ExtendedLogger interface, then we can delete all isDebugEnabled and 
> isTraceEnabled clauses.
> It would be ideal to include new JMH benchmarks with any changes involving 
> FastLogger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-6004) FunctionService::withArgs should accept vector of std::string

2018-11-06 Thread Blake Bender (JIRA)
Blake Bender created GEODE-6004:
---

 Summary: FunctionService::withArgs should accept vector of 
std::string
 Key: GEODE-6004
 URL: https://issues.apache.org/jira/browse/GEODE-6004
 Project: Geode
  Issue Type: Improvement
  Components: native client
Reporter: Blake Bender


This method expects a shared_ptr to CacheableVector, so shared_ptr to 
std::vector should be acceptable, or rather std::vector where T 
is the region value type.  Unfortunately the parameter is declared as 
shared_ptr, so passing std::vector doesn't compile.  It would be 
awfully convenient to be able to pass standard types around here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-5997) Make FastLogger optimization work without using isEnabled clause

2018-11-06 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5997:
--
Labels: pull-request-available  (was: )

> Make FastLogger optimization work without using isEnabled clause
> 
>
> Key: GEODE-5997
> URL: https://issues.apache.org/jira/browse/GEODE-5997
> Project: Geode
>  Issue Type: Wish
>  Components: logging
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: pull-request-available
>
> Geode logger statements at debug or trace level currently have isDebugEnabled 
> and isTraceEnabled clauses which are overridden by FastLogger to improve 
> performance of disabled log statements.
> If FastLogger is changed to override every method defined in the 
> ExtendedLogger interface, then we can delete all isDebugEnabled and 
> isTraceEnabled clauses.
> It would be ideal to include new JMH benchmarks with any changes involving 
> FastLogger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-6000) jdbc-mapping --pdx-name should be required

2018-11-06 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-6000:
--
Labels: pull-request-available  (was: )

> jdbc-mapping --pdx-name should be required
> --
>
> Key: GEODE-6000
> URL: https://issues.apache.org/jira/browse/GEODE-6000
> Project: Geode
>  Issue Type: Improvement
>  Components: extensions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
>
> The jdbc-mapping command has a --pdx-name option. It should be required.
> Currently if no pdx- name is given then the data will be pdx instances that 
> do not have a domain class. Support for these "typeless" pdx instances should 
> be removed and an error thrown if the required pdx-name is not given.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-5998) Redis adapter: add geospatial operations

2018-11-06 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-5998:
--
Labels: pull-request-available  (was: )

> Redis adapter: add geospatial operations
> 
>
> Key: GEODE-5998
> URL: https://issues.apache.org/jira/browse/GEODE-5998
> Project: Geode
>  Issue Type: New Feature
>  Components: redis
>Reporter: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-6005) Investigate DataOutput's "big buffer"

2018-11-06 Thread Jacob S. Barrett (JIRA)
Jacob S. Barrett created GEODE-6005:
---

 Summary: Investigate DataOutput's "big buffer"
 Key: GEODE-6005
 URL: https://issues.apache.org/jira/browse/GEODE-6005
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Jacob S. Barrett


There is a process global lock for protecting something called "big buffer" but 
there is no big buffer. It looks like it may just restrict other threads from 
creating big buffers while another thread has a big buffer. Let's investigate 
what is really going on here and understand why and if we need to do this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-6005) Investigate DataOutput's "big buffer"

2018-11-06 Thread Jacob S. Barrett (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-6005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett updated GEODE-6005:

Description: 
There is a process global lock for protecting something called "big buffer" but 
there is no big buffer. It looks like it may just restrict other threads from 
creating big buffers while another thread has a big buffer. Let's investigate 
what is really going on here and understand why and if we need to do this.

 

I think a better solution to resource management would be a bounded buffer pool 
where DataOutput/Input would checkout buffers to some user configurable limit 
before blocking.

  was:There is a process global lock for protecting something called "big 
buffer" but there is no big buffer. It looks like it may just restrict other 
threads from creating big buffers while another thread has a big buffer. Let's 
investigate what is really going on here and understand why and if we need to 
do this.


> Investigate DataOutput's "big buffer"
> -
>
> Key: GEODE-6005
> URL: https://issues.apache.org/jira/browse/GEODE-6005
> Project: Geode
>  Issue Type: Task
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>
> There is a process global lock for protecting something called "big buffer" 
> but there is no big buffer. It looks like it may just restrict other threads 
> from creating big buffers while another thread has a big buffer. Let's 
> investigate what is really going on here and understand why and if we need to 
> do this.
>  
> I think a better solution to resource management would be a bounded buffer 
> pool where DataOutput/Input would checkout buffers to some user configurable 
> limit before blocking.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-6006) Evaluate ThinClientPoolDM's mutex usage around m_endpoints

2018-11-06 Thread Jacob S. Barrett (JIRA)
Jacob S. Barrett created GEODE-6006:
---

 Summary: Evaluate ThinClientPoolDM's mutex usage around m_endpoints
 Key: GEODE-6006
 URL: https://issues.apache.org/jira/browse/GEODE-6006
 Project: Geode
  Issue Type: Task
  Components: native client
Reporter: Jacob S. Barrett


In some places {{m_endpoints}} is protected by the mutex in the ACE map, in 
other places by {{m_endpointsLock}} mutex.

 

ACE map does not lock iterators so any iterator calls should be locked 
externally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-5918) Geode function security should be dynamically determined by function arguments

2018-11-06 Thread ivorzhou (JIRA)


 [ 
https://issues.apache.org/jira/browse/GEODE-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ivorzhou updated GEODE-5918:

Fix Version/s: 1.8.0

> Geode function security should be dynamically determined by function arguments
> --
>
> Key: GEODE-5918
> URL: https://issues.apache.org/jira/browse/GEODE-5918
> Project: Geode
>  Issue Type: Improvement
>  Components: functions, security
>Reporter: ivorzhou
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 1.8.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Now in Function interface there is a method
> default Collection getRequiredPermissions(String 
> regionName) {
>  return Collections.singletonList(ResourcePermissions.DATA_WRITE);
> }
>  
> Which only support statically security determination in design 
> time(regionName is not enough).
> In some situation,we require determining security on function arguments.
>  
> I think add a method in this interface like
> default Collection getRequiredPermissions(String 
> regionName,Object args) {
> return getRequiredPermissions(regionName);
> }
>  
> and in server side command,call the new method with regionName and arguments 
> together.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)