[jira] [Assigned] (GEODE-5353) gfsh hint should be case independent
[
https://issues.apache.org/jira/browse/GEODE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan José Ramos Cassella reassigned GEODE-5353:
---
Assignee: Juan José Ramos Cassella
> gfsh hint should be case independent
>
>
> Key: GEODE-5353
> URL: https://issues.apache.org/jira/browse/GEODE-5353
> Project: Geode
> Issue Type: Improvement
> Components: docs, gfsh
>Reporter: Karen Smoler Miller
>Assignee: Juan José Ramos Cassella
>Priority: Major
> Labels: starter
>
> The gfsh hint command does not accept topic arguments that start with lower
> case letters. It should. Here is an example:
> {{gfsh>hint help}}
> {{Unknown topic: help. Use hint; to view the list of available topics.}}{{ }}
> {{gfsh>hint Help}}
> {{Provides usage information for gfsh & its commands.}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GEODE-5353) gfsh hint should be case independent
[
https://issues.apache.org/jira/browse/GEODE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-5353:
--
Labels: pull-request-available starter (was: starter)
> gfsh hint should be case independent
>
>
> Key: GEODE-5353
> URL: https://issues.apache.org/jira/browse/GEODE-5353
> Project: Geode
> Issue Type: Improvement
> Components: docs, gfsh
>Reporter: Karen Smoler Miller
>Assignee: Juan José Ramos Cassella
>Priority: Major
> Labels: pull-request-available, starter
>
> The gfsh hint command does not accept topic arguments that start with lower
> case letters. It should. Here is an example:
> {{gfsh>hint help}}
> {{Unknown topic: help. Use hint; to view the list of available topics.}}{{ }}
> {{gfsh>hint Help}}
> {{Provides usage information for gfsh & its commands.}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5617) Flaky Test AutoBalancerJUnitTest.testAuditorInvocation
[
https://issues.apache.org/jira/browse/GEODE-5617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591774#comment-16591774
]
ASF subversion and git services commented on GEODE-5617:
Commit 9be422c93f2dfcaf2ff719b760fe33881d39ba2b in geode's branch
refs/heads/windows-heavy-lifter from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9be422c ]
GEODE-5617: FIxing a race in AutoBalancerJUnitTest
This test asserted that execute was invoked exactly twice by a
background timer task. But that task could invoke execute more times
than that if the main test thread is slow.
> Flaky Test AutoBalancerJUnitTest.testAuditorInvocation
> --
>
> Key: GEODE-5617
> URL: https://issues.apache.org/jira/browse/GEODE-5617
> Project: Geode
> Issue Type: Bug
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
> Labels: pull-request-available, swat
> Fix For: 1.7.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This test failed in CI:
> {noformat}
> org.apache.geode.cache.util.AutoBalancerJUnitTest > testAuditorInvocation
> FAILED
> unexpected invocation: oobAuditor.execute()
> expectations:
> expected once, already invoked 1 time: oobAuditor.init(an instance of
> java.util.Properties)
> expected exactly 2 times, already invoked 2 times: oobAuditor.execute()
> allowed, already invoked 3 times: timeProvider.currentTimeMillis();
> returnTime
> what happened before this:
> oobAuditor.init(<{schedule=* 0/30 * * * ?}>)
> timeProvider.currentTimeMillis()
> oobAuditor.execute()
> timeProvider.currentTimeMillis()
> oobAuditor.execute()
> timeProvider.currentTimeMillis()
> {noformat}
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/Build/builds/356
> This test suspiciously has a 1 second timeout, which may be why it is failing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5630) Some tests using await should use until instead of untilAsserted
[
https://issues.apache.org/jira/browse/GEODE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591773#comment-16591773
]
ASF subversion and git services commented on GEODE-5630:
Commit abb2702eb252efc2e27ba78d6dde8fc2bac13545 in geode's branch
refs/heads/windows-heavy-lifter from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=abb2702 ]
GEODE-5630: fix use of Awaitility in BucketCreationCrashCompletesRegressionTest
> Some tests using await should use until instead of untilAsserted
>
>
> Key: GEODE-5630
> URL: https://issues.apache.org/jira/browse/GEODE-5630
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Awaitility was upgraded for GEODE-5593 and most or all of the
> await()...until() calls were changed to await()...untilAsserted(). One or
> more of these that are now incorrect.
> BucketCreationCrashCompletesRegressionTest line 173 is now:
> {noformat}
> await().atMost(2, MINUTES).untilAsserted(() -> {
> hasBucketOwners(partitionedRegion, bucketId);
> });
> {noformat}
> But hasBucketOwners returns a boolean and does not perform any assertions.
> I'll fix this test and then review every other test that was changed to use
> untilAsserted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5597) Upload geode maven snapshot artifacts from concourse
[ https://issues.apache.org/jira/browse/GEODE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591776#comment-16591776 ] ASF subversion and git services commented on GEODE-5597: Commit 39b22362db046ae245006ef2452af58789e75eab in geode's branch refs/heads/windows-heavy-lifter from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=39b2236 ] GEODE-5597 let AssemblyContentsIntegrationTest pass on windows Co-authored-by: Finn Southerland Co-authored-by: Jacob Barrett > Upload geode maven snapshot artifacts from concourse > > > Key: GEODE-5597 > URL: https://issues.apache.org/jira/browse/GEODE-5597 > Project: Geode > Issue Type: Task > Components: ci >Reporter: Finn Southerland >Priority: Major > Labels: pull-request-available > Time Spent: 7.5h > Remaining Estimate: 0h > > We would like to publish snapshots from concourse, rather than jenkins. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5627) ConcurrencyTestHelper fails with tests that don't use it
[
https://issues.apache.org/jira/browse/GEODE-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591775#comment-16591775
]
ASF subversion and git services commented on GEODE-5627:
Commit cfa7ca5da13a07ca99562b3bfdf32efe1c1414e7 in geode's branch
refs/heads/windows-heavy-lifter from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=cfa7ca5 ]
GEODE-5627: ConcurrencyRule passes when not used. (#2370)
Before this, if ConcurrencyRule was used for a test it failed because
`allthreadsExecuted` was `false`.
Also delegate to the non-default constructor with the default
constructor.
> ConcurrencyTestHelper fails with tests that don't use it
>
>
> Key: GEODE-5627
> URL: https://issues.apache.org/jira/browse/GEODE-5627
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The field {{allThreadsExecuted}} is set to {{false}} when the test runs, so
> if the helper doesn't see any use at all it will fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5601) AcceptanceTests are run in parallel without using containers, resulting in port conflicts
[
https://issues.apache.org/jira/browse/GEODE-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591781#comment-16591781
]
Kenneth Howe commented on GEODE-5601:
-
A bit more detail ...
Acceptance tests by design use default ports for running servers and locators,
so when tests run in parallel without the isolation of containers there are
inevitably port conflicts. Failures typically show error logs something like
{code:java}
[INFO 01:35:33.190 UTC] (cluster-setup): (2) Executing - start server
--name=server
--security-properties-file=/tmp/junit1230333947702514837/security.properties
[INFO 01:35:33.191 UTC] (cluster-setup):
[ERROR 01:35:35.320 UTC] (cluster-setup): The Cache Server process terminated
unexpectedly with exit status 1. Please refer to the log file in
/tmp/junit1230333947702514837/cluster-setup/server for full details.
[ERROR 01:35:35.321 UTC] (cluster-setup):
[ERROR 01:35:35.321 UTC] (cluster-setup): Exception in thread "main"
java.lang.RuntimeException: An IO error occurred while starting a Server in
/tmp/junit1230333947702514837/cluster-setup/server on
build-develop-acceptancetest-319.c.apachegeode-ci.internal[40404]: Network is
unreachable; port (40404) is not available on localhost.
{code}
Some of the {{AcceptanceTests}} require external services such as mysql or
postgres which are in docker containers. To avoid docker-in-docker problems CI
for these tests are not containerized.
> AcceptanceTests are run in parallel without using containers, resulting in
> port conflicts
> -
>
> Key: GEODE-5601
> URL: https://issues.apache.org/jira/browse/GEODE-5601
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Jacob S. Barrett
>Assignee: Kenneth Howe
>Priority: Major
> Labels: flaky, swat
>
> {noformat}
> org.apache.geode.management.internal.cli.commands.DeployWithLargeJarTest >
> deployLargeSetOfJars FAILED
> org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.awaitIfNecessary(GfshScript.java:117)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:135)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.execute(GfshScript.java:106)
> at
> org.apache.geode.management.internal.cli.commands.DeployWithLargeJarTest.deployLargeSetOfJars(DeployWithLargeJarTest.java:41)
> {noformat}
> Passes:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/pr-develop/jobs/AcceptanceTest/builds/721
> Fails:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/pr-develop/jobs/AcceptanceTest/builds/728
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5601) AcceptanceTests are run in parallel without using containers, resulting in port conflicts
[
https://issues.apache.org/jira/browse/GEODE-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591786#comment-16591786
]
Kenneth Howe commented on GEODE-5601:
-
Work on containerizing {{AcceptanceTests}} is in progress on PR#2368, against
GEODE-5590 which is now tagged as a duplicate of this JIRA
> AcceptanceTests are run in parallel without using containers, resulting in
> port conflicts
> -
>
> Key: GEODE-5601
> URL: https://issues.apache.org/jira/browse/GEODE-5601
> Project: Geode
> Issue Type: Bug
> Components: tests
>Reporter: Jacob S. Barrett
>Assignee: Kenneth Howe
>Priority: Major
> Labels: flaky, swat
>
> {noformat}
> org.apache.geode.management.internal.cli.commands.DeployWithLargeJarTest >
> deployLargeSetOfJars FAILED
> org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.awaitIfNecessary(GfshScript.java:117)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:135)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.execute(GfshScript.java:106)
> at
> org.apache.geode.management.internal.cli.commands.DeployWithLargeJarTest.deployLargeSetOfJars(DeployWithLargeJarTest.java:41)
> {noformat}
> Passes:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/pr-develop/jobs/AcceptanceTest/builds/721
> Fails:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/pr-develop/jobs/AcceptanceTest/builds/728
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GEODE-5634) Upgrade to latest xunit modules
Michael Martell created GEODE-5634: -- Summary: Upgrade to latest xunit modules Key: GEODE-5634 URL: https://issues.apache.org/jira/browse/GEODE-5634 Project: Geode Issue Type: Improvement Components: native client Reporter: Michael Martell Upgrade the core modules from version 2.3.1 => 2.4.0 and xunit.analyzers 0.8.0 => 0.10.0 "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5634) Upgrade to latest xunit modules
[ https://issues.apache.org/jira/browse/GEODE-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591816#comment-16591816 ] ASF subversion and git services commented on GEODE-5634: Commit 4661e6f86e7feecdf3fd271e2e734d28e8dae898 in geode-native's branch refs/heads/feature/GEODE-5634 from [~eburghardt] [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=4661e6f ] GEODE-5634: Xunit modules upgraded to latest > Upgrade to latest xunit modules > --- > > Key: GEODE-5634 > URL: https://issues.apache.org/jira/browse/GEODE-5634 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > > Upgrade the core modules from version 2.3.1 => 2.4.0 > and > xunit.analyzers 0.8.0 => 0.10.0 > "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5634) Upgrade to latest xunit modules
[ https://issues.apache.org/jira/browse/GEODE-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-5634: -- Labels: pull-request-available (was: ) > Upgrade to latest xunit modules > --- > > Key: GEODE-5634 > URL: https://issues.apache.org/jira/browse/GEODE-5634 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > > Upgrade the core modules from version 2.3.1 => 2.4.0 > and > xunit.analyzers 0.8.0 => 0.10.0 > "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5634) Upgrade to latest xunit modules
[ https://issues.apache.org/jira/browse/GEODE-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591825#comment-16591825 ] ASF subversion and git services commented on GEODE-5634: Commit dc0a041d7c01d5cbe5d265fda1f65f7b158217ad in geode-native's branch refs/heads/feature/GEODE-5634 from [~eburghardt] [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=dc0a041 ] GEODE-5634: Xunit modules upgraded to latest > Upgrade to latest xunit modules > --- > > Key: GEODE-5634 > URL: https://issues.apache.org/jira/browse/GEODE-5634 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Upgrade the core modules from version 2.3.1 => 2.4.0 > and > xunit.analyzers 0.8.0 => 0.10.0 > "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5634) Upgrade to latest xunit modules
[ https://issues.apache.org/jira/browse/GEODE-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591828#comment-16591828 ] ASF subversion and git services commented on GEODE-5634: Commit 24d235b92e85313f299a355aa9c6ba777453 in geode-native's branch refs/heads/develop from Ernie Burghardt [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=24d235b ] GEODE-5634: Xunit modules upgraded to latest > Upgrade to latest xunit modules > --- > > Key: GEODE-5634 > URL: https://issues.apache.org/jira/browse/GEODE-5634 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Upgrade the core modules from version 2.3.1 => 2.4.0 > and > xunit.analyzers 0.8.0 => 0.10.0 > "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5562) LowMemoryException message sometimes does not provide the member that is low on memory
[ https://issues.apache.org/jira/browse/GEODE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591846#comment-16591846 ] ASF subversion and git services commented on GEODE-5562: Commit 583d1416644a8392ed1bf257b87025a9071aaa55 in geode's branch refs/heads/develop from [~lgallinat] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=583d141 ] GEODE-5562 Reading the values of LocalRegion.memoryThresholdReached and DistributedRegion.memoryThresholdReachedMembers must be atomic (#2320) * GEODE-5562 Reading the values of LocalRegion.memoryThresholdReached and DistributedRegion.memoryThresholdReachedMembers must be atomic. > LowMemoryException message sometimes does not provide the member that is low > on memory > -- > > Key: GEODE-5562 > URL: https://issues.apache.org/jira/browse/GEODE-5562 > Project: Geode > Issue Type: Bug >Reporter: Lynn Gallinat >Assignee: Lynn Gallinat >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > org.apache.geode.cache.LowMemoryException: Region: /replicatedRegion cannot > process operation on key: Object_7998 because member [] is running low on > memory > at > org.apache.geode.internal.cache.LocalRegion.checkIfAboveThreshold(LocalRegion.java:5729) > at > org.apache.geode.internal.cache.LocalRegion.checkIfAboveThreshold(LocalRegion.java:5705) > at > org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5654) > at > org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:371) > at > org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:152) > at > org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5086) > at > org.apache.geode.internal.cache.LocalRegion.validatedPut(LocalRegion.java:1618) > at > org.apache.geode.internal.cache.LocalRegion.put(LocalRegion.java:1605) > at > org.apache.geode.internal.cache.AbstractRegion.put(AbstractRegion.java:413) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5562) LowMemoryException message sometimes does not provide the member that is low on memory
[ https://issues.apache.org/jira/browse/GEODE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591845#comment-16591845 ] ASF subversion and git services commented on GEODE-5562: Commit 583d1416644a8392ed1bf257b87025a9071aaa55 in geode's branch refs/heads/develop from [~lgallinat] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=583d141 ] GEODE-5562 Reading the values of LocalRegion.memoryThresholdReached and DistributedRegion.memoryThresholdReachedMembers must be atomic (#2320) * GEODE-5562 Reading the values of LocalRegion.memoryThresholdReached and DistributedRegion.memoryThresholdReachedMembers must be atomic. > LowMemoryException message sometimes does not provide the member that is low > on memory > -- > > Key: GEODE-5562 > URL: https://issues.apache.org/jira/browse/GEODE-5562 > Project: Geode > Issue Type: Bug >Reporter: Lynn Gallinat >Assignee: Lynn Gallinat >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > org.apache.geode.cache.LowMemoryException: Region: /replicatedRegion cannot > process operation on key: Object_7998 because member [] is running low on > memory > at > org.apache.geode.internal.cache.LocalRegion.checkIfAboveThreshold(LocalRegion.java:5729) > at > org.apache.geode.internal.cache.LocalRegion.checkIfAboveThreshold(LocalRegion.java:5705) > at > org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5654) > at > org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:371) > at > org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:152) > at > org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5086) > at > org.apache.geode.internal.cache.LocalRegion.validatedPut(LocalRegion.java:1618) > at > org.apache.geode.internal.cache.LocalRegion.put(LocalRegion.java:1605) > at > org.apache.geode.internal.cache.AbstractRegion.put(AbstractRegion.java:413) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5594) Enable endpoint validation during using SSL handshake
[ https://issues.apache.org/jira/browse/GEODE-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-5594: -- Labels: pull-request-available (was: ) > Enable endpoint validation during using SSL handshake > - > > Key: GEODE-5594 > URL: https://issues.apache.org/jira/browse/GEODE-5594 > Project: Geode > Issue Type: Improvement > Components: client/server >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > > Users can set `ssl-endpoint-identification-enabled` to true to enable > validation of hostname in server's identity when using SSL to harden against > certain man-in-the-middle attacks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5632) Tests should prefer imporing org.assertj.core.api.Assertions instead of AssertionsForClassTypes
[ https://issues.apache.org/jira/browse/GEODE-5632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591967#comment-16591967 ] ASF subversion and git services commented on GEODE-5632: Commit 9de289d0315f0866ead4a199f68d5afc05f5f69f in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9de289d ] GEODE-5632: import Assertions instead of AssertionsForClassTypes > Tests should prefer imporing org.assertj.core.api.Assertions instead of > AssertionsForClassTypes > --- > > Key: GEODE-5632 > URL: https://issues.apache.org/jira/browse/GEODE-5632 > Project: Geode > Issue Type: Bug > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > The following tests contain _import static > org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;_: > * JdbcWriterTest > * JdbcAsyncWriterTest > * QueueConnectionImplJUnitTest > * GemFireBasicDataSourceJUnitTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-5562) LowMemoryException message sometimes does not provide the member that is low on memory
[ https://issues.apache.org/jira/browse/GEODE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lynn Gallinat resolved GEODE-5562. -- Resolution: Fixed Fix Version/s: 1.7.0 commit 583d1416644a8392ed1bf257b87025a9071aaa55 Author: Lynn Gallinat Date: Fri Aug 24 08:58:27 2018 -0700 GEODE-5562 Reading the values of LocalRegion.memoryThresholdReached and DistributedRegion.memoryThresholdReachedMembers must be atomic (#2320) * GEODE-5562 Reading the values of LocalRegion.memoryThresholdReached and DistributedRegion.memoryThresholdReachedMembers must be atomic. > LowMemoryException message sometimes does not provide the member that is low > on memory > -- > > Key: GEODE-5562 > URL: https://issues.apache.org/jira/browse/GEODE-5562 > Project: Geode > Issue Type: Bug >Reporter: Lynn Gallinat >Assignee: Lynn Gallinat >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > org.apache.geode.cache.LowMemoryException: Region: /replicatedRegion cannot > process operation on key: Object_7998 because member [] is running low on > memory > at > org.apache.geode.internal.cache.LocalRegion.checkIfAboveThreshold(LocalRegion.java:5729) > at > org.apache.geode.internal.cache.LocalRegion.checkIfAboveThreshold(LocalRegion.java:5705) > at > org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5654) > at > org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:371) > at > org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:152) > at > org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5086) > at > org.apache.geode.internal.cache.LocalRegion.validatedPut(LocalRegion.java:1618) > at > org.apache.geode.internal.cache.LocalRegion.put(LocalRegion.java:1605) > at > org.apache.geode.internal.cache.AbstractRegion.put(AbstractRegion.java:413) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GEODE-5632) Tests should prefer imporing org.assertj.core.api.Assertions instead of AssertionsForClassTypes
[ https://issues.apache.org/jira/browse/GEODE-5632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-5632. -- Resolution: Fixed Fix Version/s: 1.7.0 > Tests should prefer imporing org.assertj.core.api.Assertions instead of > AssertionsForClassTypes > --- > > Key: GEODE-5632 > URL: https://issues.apache.org/jira/browse/GEODE-5632 > Project: Geode > Issue Type: Bug > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The following tests contain _import static > org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;_: > * JdbcWriterTest > * JdbcAsyncWriterTest > * QueueConnectionImplJUnitTest > * GemFireBasicDataSourceJUnitTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5629) GMSEncryptJUnitTest does not actually check the results of threads it starts
[
https://issues.apache.org/jira/browse/GEODE-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-5629:
--
Labels: pull-request-available swat (was: swat)
> GMSEncryptJUnitTest does not actually check the results of threads it starts
>
>
> Key: GEODE-5629
> URL: https://issues.apache.org/jira/browse/GEODE-5629
> Project: Geode
> Issue Type: Bug
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
> Labels: pull-request-available, swat
>
> The testForClusterSecretKeyFromOtherMemberMultipleThreads method starts a
> bunch of threads, but it does not actually check to see if they ran
> successfully without an exception. It just waits for them to finish around
> line 362. This test should be refactored to use the ConcurrencyRule.
> {code}
> countDownLatch.await();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (GEODE-5619) Change scanning for XSDRootElement to consider all packages on the classpath
[ https://issues.apache.org/jira/browse/GEODE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-5619. --- Resolution: Fixed Fix Version/s: 1.7.0 > Change scanning for XSDRootElement to consider all packages on the classpath > > > Key: GEODE-5619 > URL: https://issues.apache.org/jira/browse/GEODE-5619 > Project: Geode > Issue Type: Improvement > Components: configuration >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > Labels: pull-request-available > Fix For: 1.7.0 > > Time Spent: 20m > Remaining Estimate: 0h > > This used to be the case but switched to "org.apache.geode" with the > classpath scanner upgrade to 4.0.6 (possibly because of memory issues). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5634) Upgrade to latest xunit modules
[ https://issues.apache.org/jira/browse/GEODE-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592105#comment-16592105 ] ASF subversion and git services commented on GEODE-5634: Commit 8c308c87fd6dd57318165dc3a32a34f59c32 in geode-native's branch refs/heads/feature/GEODE-5634 from [~eburghardt] [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=8c308c8 ] Revert "GEODE-5634: Xunit modules upgraded to latest" This reverts commit dc0a041d7c01d5cbe5d265fda1f65f7b158217ad. > Upgrade to latest xunit modules > --- > > Key: GEODE-5634 > URL: https://issues.apache.org/jira/browse/GEODE-5634 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Upgrade the core modules from version 2.3.1 => 2.4.0 > and > xunit.analyzers 0.8.0 => 0.10.0 > "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-5551) Flaky unit test LoginHandlerInterceptorJUnitTest > testHandlerInterceptorThreadSafety
[
https://issues.apache.org/jira/browse/GEODE-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Smith updated GEODE-5551:
-
Summary: Flaky unit test LoginHandlerInterceptorJUnitTest >
testHandlerInterceptorThreadSafety (was: Flaky test
LoginHandlerInterceptorJUnitTest > testHandlerInterceptorThreadSafety)
> Flaky unit test LoginHandlerInterceptorJUnitTest >
> testHandlerInterceptorThreadSafety
> -
>
> Key: GEODE-5551
> URL: https://issues.apache.org/jira/browse/GEODE-5551
> Project: Geode
> Issue Type: Bug
> Components: tests
>Affects Versions: 1.8.0
>Reporter: Jacob S. Barrett
>Priority: Major
> Labels: flaky, swat
>
> {noformat}
> > Task :geode-web:test
> org.apache.geode.management.internal.web.controllers.support.LoginHandlerInterceptorJUnitTest
> > testHandlerInterceptorThreadSafety FAILED
> junit.framework.AssertionFailedError: expected:<0> but was:<3>
> not all expectations were satisfied
> expectations:
> ! expected once, never invoked:
> testHandlerInterceptorThreadSafety.HttpServletRequest.1.getParameterNames();
> returns
>
> ! expected once, never invoked:
> testHandlerInterceptorThreadSafety.HttpServletRequest.1.getHeader("security-username");
> returns "admin"
> ! expected once, never invoked:
> testHandlerInterceptorThreadSafety.HttpServletRequest.1.getHeader("security-password");
> returns "password"
> ! expected once, never invoked:
> testHandlerInterceptorThreadSafety.HttpServletRequest.1.getParameter("vf.gf.env.STAGE");
> returns "test"
> ! expected once, never invoked:
> testHandlerInterceptorThreadSafety.HttpServletRequest.1.getParameter("vf.gf.env.GEODE_HOME");
> returns "/path/to/gemfire/700"
> expected once, already invoked 1 time: securityService.login(not null);
> returns a default value
> expected once, already invoked 1 time: securityService.logout()
> expected once, already invoked 1 time:
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getParameterNames();
> returns
>
> expected once, already invoked 1 time:
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getHeader("security-username");
> returns "admin"
> expected once, already invoked 1 time:
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getHeader("security-password");
> returns "password"
> expected once, already invoked 1 time:
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getParameter("vf.gf.env.HOST");
> returns "localhost"
> expected once, already invoked 1 time:
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getParameter("vf.gf.env.GEODE_HOME");
> returns "/path/to/gemfire/75"
> ! expected once, never invoked: securityService.login(not null);
> returns a default value
> ! expected once, never invoked: securityService.logout()
> what happened before this:
>
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getParameterNames()
>
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getParameter("vf.gf.env.HOST")
>
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getParameter("vf.gf.env.GEODE_HOME")
>
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getHeader("security-username")
>
> testHandlerInterceptorThreadSafety.HttpServletRequest.2.getHeader("security-password")
> securityService.login(<{security-username=admin,
> security-password=password}>)
> securityService.logout()
> at
> org.jmock.api.ExpectationError.notAllSatisfied(ExpectationError.java:27)
> at org.jmock.Mockery.assertIsSatisfied(Mockery.java:213)
> at
> org.apache.geode.management.internal.web.controllers.support.LoginHandlerInterceptorJUnitTest.tearDown(LoginHandlerInterceptorJUnitTest.java:70)
> {noformat}
> Failing:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/pr-develop/jobs/Build/builds/558
> Passing:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/pr-develop/jobs/Build/builds/559
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5624) JTA transaction does not clean up TXState due to IllegalMonitorStateException
[
https://issues.apache.org/jira/browse/GEODE-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592145#comment-16592145
]
ASF subversion and git services commented on GEODE-5624:
Commit 413b34f3a63af62094925b16f280ae4a641d4dc6 in geode's branch
refs/heads/feature/GEODE-5624 from eshu
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=413b34f ]
GEODE-5624: Use a thread to do beforeCompletion and afterCompletion.
> JTA transaction does not clean up TXState due to IllegalMonitorStateException
> -
>
> Key: GEODE-5624
> URL: https://issues.apache.org/jira/browse/GEODE-5624
> Project: Geode
> Issue Type: Bug
> Components: transactions
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
>
> When server has different threads handling JTA beforeCompletion and
> afterCompletion, IllegalMonitorStateException can be thrown when release
> locks held. This causes the TXState not being cleaned up.
> {noformat}
> java.lang.IllegalMonitorStateException: attempt to unlock read lock, not
> locked by current thread
> at
> java.util.concurrent.locks.ReentrantReadWriteLock$Sync.unmatchedUnlockException(ReentrantReadWriteLock.java:444)
> at
> java.util.concurrent.locks.ReentrantReadWriteLock$Sync.tryReleaseShared(ReentrantReadWriteLock.java:428)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.releaseShared(AbstractQueuedSynchronizer.java:1341)
> at
> java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.unlock(ReentrantReadWriteLock.java:881)
> at
> org.apache.geode.internal.util.concurrent.StoppableReentrantReadWriteLock$StoppableReadLock.unlock(StoppableReentrantReadWriteLock.java:144)
> at
> org.apache.geode.internal.cache.locks.TXLockServiceImpl.releaseRecoveryReadLock(TXLockServiceImpl.java:275)
> at
> org.apache.geode.internal.cache.locks.TXLockServiceImpl.release(TXLockServiceImpl.java:240)
> at
> org.apache.geode.internal.cache.TXLockRequest.releaseDistributed(TXLockRequest.java:109)
> at
> org.apache.geode.internal.cache.TXLockRequest.cleanup(TXLockRequest.java:142)
> at org.apache.geode.internal.cache.TXState.cleanup(TXState.java:870)
> at org.apache.geode.internal.cache.TXState.commit(TXState.java:514)
> at
> org.apache.geode.internal.cache.TXState.doAfterCompletion(TXState.java:1103)
> at
> org.apache.geode.internal.cache.TXState.afterCompletion(TXState.java:1084)
> at
> org.apache.geode.internal.cache.TXStateProxyImpl.afterCompletion(TXStateProxyImpl.java:452)
> at
> org.apache.geode.internal.cache.tier.sockets.command.TXSynchronizationCommand.cmdExecute(TXSynchronizationCommand.java:140)
> at
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:158)
> at
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMsg(ServerConnection.java:869)
> at
> org.apache.geode.internal.cache.tier.sockets.OriginalServerConnection.doOneMessage(OriginalServerConnection.java:77)
> at
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1248)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$4$1.run(AcceptorImpl.java:645)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5634) Upgrade to latest xunit modules
[ https://issues.apache.org/jira/browse/GEODE-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592153#comment-16592153 ] ASF subversion and git services commented on GEODE-5634: Commit d0ff5d7e393f17955f54d3fe0bdf2694c78e9a7e in geode-native's branch refs/heads/develop from Ernie Burghardt [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=d0ff5d7 ] GEODE-5634: Reverting the Xunit upgrade - Revert "GEODE-5634: Xunit modules upgraded to latest" - This reverts commit dc0a041d7c01d5cbe5d265fda1f65f7b158217ad. > Upgrade to latest xunit modules > --- > > Key: GEODE-5634 > URL: https://issues.apache.org/jira/browse/GEODE-5634 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Upgrade the core modules from version 2.3.1 => 2.4.0 > and > xunit.analyzers 0.8.0 => 0.10.0 > "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5634) Upgrade to latest xunit modules
[ https://issues.apache.org/jira/browse/GEODE-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592154#comment-16592154 ] ASF subversion and git services commented on GEODE-5634: Commit d0ff5d7e393f17955f54d3fe0bdf2694c78e9a7e in geode-native's branch refs/heads/develop from Ernie Burghardt [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=d0ff5d7 ] GEODE-5634: Reverting the Xunit upgrade - Revert "GEODE-5634: Xunit modules upgraded to latest" - This reverts commit dc0a041d7c01d5cbe5d265fda1f65f7b158217ad. > Upgrade to latest xunit modules > --- > > Key: GEODE-5634 > URL: https://issues.apache.org/jira/browse/GEODE-5634 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Martell >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Upgrade the core modules from version 2.3.1 => 2.4.0 > and > xunit.analyzers 0.8.0 => 0.10.0 > "xunit.abstractions 2.0.1 => 2.0.2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5142) new Thread Monitoring Mechanism
[ https://issues.apache.org/jira/browse/GEODE-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592267#comment-16592267 ] ASF subversion and git services commented on GEODE-5142: Commit b9511465702bf746c1543a6a5eb2369f22f88fb3 in geode's branch refs/heads/develop from [~bschuchardt] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=b951146 ] GEODE-5142 new Thread Monitoring Mechanism Fixing some formatting problems in stack trace output and other log messages. One person noticed the monitor saying it was "expiring" a thread and thought it was doing something other than print stack traces. > new Thread Monitoring Mechanism > --- > > Key: GEODE-5142 > URL: https://issues.apache.org/jira/browse/GEODE-5142 > Project: Geode > Issue Type: New Feature > Components: docs, management >Reporter: yossi reginiano >Assignee: Joey McAllister >Priority: Major > Labels: pull-request-available > Time Spent: 6h 20m > Remaining Estimate: 0h > > One of the most severe issues hitting our real time application is thread > stuck for multiple reasons, such as long lasting locks, deadlocks, threads > which wait for reply forever in case of packet drop issue etc... > Such kind of stuck are under Radar of the existing system health check > methods. In mission critical applications, this will be resulted as an > immediate outage. > Here we introduce thread monitoring mechanism, to detect threads which are > stuck for any reason. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5614) Rename DistributedTestRule as DistributedRule
[ https://issues.apache.org/jira/browse/GEODE-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592288#comment-16592288 ] ASF subversion and git services commented on GEODE-5614: Commit f91c2dfa319073ddb1222c3f50c26735d19332fe in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=f91c2df ] GEODE-5614: update RegionManagementDUnitTest usage of DistributedRule > Rename DistributedTestRule as DistributedRule > - > > Key: GEODE-5614 > URL: https://issues.apache.org/jira/browse/GEODE-5614 > Project: Geode > Issue Type: Improvement > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Rename DistributedTestRule as DistributedRule. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5614) Rename DistributedTestRule as DistributedRule
[ https://issues.apache.org/jira/browse/GEODE-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592287#comment-16592287 ] ASF subversion and git services commented on GEODE-5614: Commit 16d0f6962a1c11d5f09e21ab67e23e1686d14934 in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=16d0f69 ] GEODE-5614: rename distributedTestRule field to distributedRule * Cleanup warnings in these tests > Rename DistributedTestRule as DistributedRule > - > > Key: GEODE-5614 > URL: https://issues.apache.org/jira/browse/GEODE-5614 > Project: Geode > Issue Type: Improvement > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Rename DistributedTestRule as DistributedRule. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GEODE-5614) Rename DistributedTestRule as DistributedRule
[ https://issues.apache.org/jira/browse/GEODE-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592286#comment-16592286 ] ASF subversion and git services commented on GEODE-5614: Commit 123b8c4b3a415598c9edd5a1c311b94a75ce9edf in geode's branch refs/heads/develop from [~apa...@the9muses.net] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=123b8c4 ] GEODE-5614: rename DistributedTestRule as DistributedRule * Cleanup javadocs on rules that referred to DistributedTestRule. * Add ClientCacheFactoryDistributedTest for ClientCacheRule. > Rename DistributedTestRule as DistributedRule > - > > Key: GEODE-5614 > URL: https://issues.apache.org/jira/browse/GEODE-5614 > Project: Geode > Issue Type: Improvement > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Rename DistributedTestRule as DistributedRule. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (GEODE-3780) suspected member is never watched again after passing final check
[
https://issues.apache.org/jira/browse/GEODE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruce Schuchardt reopened GEODE-3780:
-
Another variant of this bug was hit in network-down testing.
The problem is happening when the network partition isn't instantaneous, which
is the case with most test frameworks that use iptable manipulation.
The network from the losing side to the surviving side was shut down and
process 13989 initiates a final existence check on one of the surviving-side
processes:
{noformat}
system.log: [info 2018/08/21 21:56:43.082 PDT gemfire1_host1_13989 tid=0x84] Performing final check for suspect member
10.32.111.37(gemfire4_host2_12365:12365:locator):1025 reason=Unable to
send messages to this member via JGroups
{noformat}
But the network from the surviving-side -> the losing side was still open and
13989 received messages from it:
{noformat}
system.log: [info 2018/08/21 21:56:48.084 PDT gemfire1_host1_13989 tid=0x84] Final check failed but detected recent
message traffic for suspect member
10.32.111.37(gemfire4_host2_12365:12365:locator):1025
system.log: [info 2018/08/21 21:56:48.085 PDT gemfire1_host1_13989 tid=0x84] Final check passed for suspect member
10.32.111.37(gemfire4_host2_12365:12365:locator):1025
{noformat}
The health monitor eventually suspected the other surviving-side member and
kicked it out, but it never performed another final check on
gemfire4_host2_12365 and so did not shut down:
{noformat}
system.log: [info 2018/08/21 21:56:48.086 PDT gemfire1_host1_13989 tid=0x85] Final check failed - requesting removal
of suspect member 10.32.111.37(gemfire3_host2_12393:12393):1026
system.log: [info 2018/08/21 21:56:50.536 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.111.37(gemfire3_host2_12393:12393):1026
system.log: [info 2018/08/21 21:56:50.536 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.111.37(gemfire4_host2_12365:12365:locator):1025
system.log: [info 2018/08/21 21:56:53.036 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.111.37(gemfire3_host2_12393:12393):1026
system.log: [info 2018/08/21 21:56:53.036 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.111.37(gemfire4_host2_12365:12365:locator):1025
system.log: [info 2018/08/21 21:56:55.536 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.111.37(gemfire3_host2_12393:12393):1026
system.log: [info 2018/08/21 21:56:58.036 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.108.137(gemfire1_host1_13989:13989):1024
system.log: [info 2018/08/21 21:56:58.036 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.111.37(gemfire3_host2_12393:12393):1026
system.log: [info 2018/08/21 21:57:00.536 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.108.137(gemfire1_host1_13989:13989):1024
system.log: [info 2018/08/21 21:57:00.536 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.111.37(gemfire3_host2_12393:12393):1026
system.log: [info 2018/08/21 21:57:03.036 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.108.137(gemfire1_host1_13989:13989):1024
system.log: [info 2018/08/21 21:57:03.036 PDT gemfire1_host1_13989 tid=0x22] Failure detection is now watching
10.32.111.37(gemfire3_host2_12393:12393):1026
system.log: [info 2018/08/21 21:57:05.536 PDT gemfire1_host1_13989 tid=0x22] All other members are suspect at this
point
{noformat}
> suspected member is never watched again after passing final check
> -
>
> Key: GEODE-3780
> URL: https://issues.apache.org/jira/browse/GEODE-3780
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In a network-down test we saw a node on the losing side of the network
> partition perform final checks on members on the winning side. One of the
> final checks mysteriously succeeded
> [info 2017/09/17 12:24:45.552 PDT
> gemfire1_rs-FullRegression-2017-09-15-21-00-35-client-10_8941 Detection thread 4> tid=0x128] Final check failed but detected recent message
> traffic for suspect member
> 10.32.109.252(gemfire3_rs-FullRegression-2017-09-15-21-00-35-client-16_6135:6135):1026
> [info 2017/09/17 12:24:45.552 PDT
> gemfire1_rs-FullRegression-2017-09-15-21-00-35-client-10_8941 Detection thread 4> tid=0x128] Final check passed for suspect member
> 10.32.109.252(gemfire3_rs-FullRegression-2017-09-15-21-00-35-client-16_6135:6135):1026
> After this the sus
[jira] [Updated] (GEODE-5623) SUPERFLAKY: StopLocatorCommandDUnitTest
[
https://issues.apache.org/jira/browse/GEODE-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-5623:
--
Labels: pull-request-available swat (was: swat)
> SUPERFLAKY: StopLocatorCommandDUnitTest
> ---
>
> Key: GEODE-5623
> URL: https://issues.apache.org/jira/browse/GEODE-5623
> Project: Geode
> Issue Type: Bug
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
> Labels: pull-request-available, swat
>
> This test failed recently in CI, and it failed multiple times in the a 300
> run batch of DistributedTest
> Most recent failure:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/281
> {noformat}
> org.apache.geode.management.internal.cli.commands.StopLocatorCommandDUnitTest
> > testWithMemberName FAILED
>
> org.junit.ComparisonFailure: expected:<[OK]> but was:<[ERROR]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.management.internal.cli.commands.StopLocatorCommandDUnitTest.testWithMemberName(StopLocatorCommandDUnitTest.java:159)
> {noformat}
> In the 300 run batch, to two different methods in this class are failing:
> {noformat}
> org.apache.geode.management.internal.cli.commands.StopLocatorCommandDUnitTest:
> 9 failures (97.000% success rate)
> | .testWithMemberID: 2 failures (99.333% success rate)
> | | Failed build 286 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/286
> | | Failed build 146 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/146
> | .testWithMemberName: 7 failures (97.667% success rate)
> | | Failed build 260 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/260
> | | Failed build 231 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/231
> | | Failed build 178 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/178
> | | Failed build 127 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/127
> | | Failed build 87 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/87
> | | Failed build 53 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/53
> | | Failed build 27 at
> https://concourse.apachegeode-ci.info/teams/staging/pipelines/concourse-staging/jobs/DistributedTest/builds/27
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GEODE-5629) GMSEncryptJUnitTest does not actually check the results of threads it starts
[
https://issues.apache.org/jira/browse/GEODE-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592310#comment-16592310
]
ASF subversion and git services commented on GEODE-5629:
Commit e719331d03b3e3b1ae069b9db5b04cc928b96e3f in geode's branch
refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=e719331 ]
GEODE-5629: Changing GMSEncryptJUnitTest to use ConcurrencyRule
This test was not capturing exceptions from the background threads.
Using ConcurrenyRule to execute the background tests.
> GMSEncryptJUnitTest does not actually check the results of threads it starts
>
>
> Key: GEODE-5629
> URL: https://issues.apache.org/jira/browse/GEODE-5629
> Project: Geode
> Issue Type: Bug
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
> Labels: pull-request-available, swat
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The testForClusterSecretKeyFromOtherMemberMultipleThreads method starts a
> bunch of threads, but it does not actually check to see if they ran
> successfully without an exception. It just waits for them to finish around
> line 362. This test should be refactored to use the ConcurrencyRule.
> {code}
> countDownLatch.await();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (GEODE-5629) GMSEncryptJUnitTest does not actually check the results of threads it starts
[
https://issues.apache.org/jira/browse/GEODE-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Smith resolved GEODE-5629.
--
Resolution: Fixed
> GMSEncryptJUnitTest does not actually check the results of threads it starts
>
>
> Key: GEODE-5629
> URL: https://issues.apache.org/jira/browse/GEODE-5629
> Project: Geode
> Issue Type: Bug
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
> Labels: pull-request-available, swat
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The testForClusterSecretKeyFromOtherMemberMultipleThreads method starts a
> bunch of threads, but it does not actually check to see if they ran
> successfully without an exception. It just waits for them to finish around
> line 362. This test should be refactored to use the ConcurrencyRule.
> {code}
> countDownLatch.await();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
