Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
On Mon, Sep 24, 2007 at 11:40:40AM +0200, Lars Weiler wrote: > * Robin H. Johnson <[EMAIL PROTECTED]> [07/09/18 17:23 -0700]: > > Reply-To on gentoo-commits is already set to [EMAIL PROTECTED] > I guess this is set by the mailing-list-software? That > collides with https://bugs.gentoo.org/193376. That was filed after the original creations of the commit mail system. Anyway, it's moot now, I updated the code to set Reply-To to both the list and the committer per that bug. However that is still going to suck, because now folk that ARE subscribed to gentoo-dev that get commit-reviewed are going to get duplicates. Additionally, responses after the first review that are on the list won't be seen by a non-subscribed dev. -- Robin Hugh Johnson Gentoo Linux Developer & Infra Guy E-Mail : [EMAIL PROTECTED] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85 pgpHSI23oQKoa.pgp Description: PGP signature
Re: [gentoo-dev] commit reviewing ... new list or keep it on -dev ?
On Tuesday 25 September 2007, Robin H. Johnson wrote: > However that is still going to suck, because now folk that ARE > subscribed to gentoo-dev that get commit-reviewed are going to get > duplicates. i dont think so ... i'm pretty sure the default mailer settings are to not post duplicates at least, i dont recall ever seeing duplicates when someone e-mailed gentoo-dev and cc-ed me > Additionally, responses after the first review that are on > the list won't be seen by a non-subscribed dev. reply-all ! -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild
On Montag, 24. September 2007, Donnie Berkholz wrote:
> On 19:59 Mon 24 Sep , Matthias Schwarzott (zzam) wrote:
> > zzam07/09/24 19:59:38
> >
>
> This ebuild has really inconsistent use of tests, quotes in tests, and
> command substitutions. Being more consistent will increase readability
> and decrease bugs due to differences between styles. For tests, pick a
> style [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice
> because it generally doesn't require quotes, so the code looks a lot
> cleaner. For command substitions, prefer $() over ``.
>
> > newins ${FILESDIR}/blacklist-110 blacklist
> > doins ${FILESDIR}/pnp-aliases
>
> Quotes here.
>
> > emake \
> > EXTRAS="${extras}" \
> > libudevdir=${udev_helper_dir} \
> > CROSS_COMPILE=${mycross} \
> > OPTFLAGS="" \
> > ${myconf} || die
> >
> > emake \
> > DESTDIR="${D}" \
> > libudevdir=${udev_helper_dir} \
> > EXTRAS="${extras}" \
> > ${myconf} \
> > install || die
>
> Could use some die messages here.
>
> Thanks,
> Donnie
fixed, thanks
Matthias
--
Matthias Schwarzott (zzam)
--
[EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/linuxtv-dvb-apps: ChangeLog linuxtv-dvb-apps-1.1.1.20070924.ebuild
On Tuesday, 25. September 2007, Donnie Berkholz wrote: > On 20:04 Mon 24 Sep , Doug Goldstein (cardoe) wrote: > > if ! use usb; then > > sed -i util/Makefile \ > > -e '/ttusb_dec_reset/d' \ > > -e '/dib3000-watch/d' > > fi > > > > # do not compile test-progs > > sed -i Makefile -e '/-C test/d' > > You might want to die if these seds fail. I already wondered a while back: sed only fails if the file does not exist, but not if there was no replacement. Is there any way to force it to? Regards, Robert signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] meaning of sqlite/sqlite3 use flag
Alin Năstac kirjoitti:
> Mike Frysinger wrote:
>> how about 'sqlite' means you want sqlite irregardless of version ... then
>> sqlite-2 either gets punted from apr-util or it gets a local USE
>> flag 'sqlite-old' for older cruft
>>
> Wouldn't be better to determine what version of sqlite should be used
> based on the version of sqlite currently installed on the system?
> Something like:
>sqlite_atom=$(best_version dev-db/sqlite)
>sqlite_major_version=${sqlite_atom#*/*-} #reduce it to $PV-$PR
>sqlite_major_version=${sqlite_major_version%%.*} # major version
>
>... ebuild stuff...
>econf \
> $(use_enable sqlite sqlite${sqlite_major_version})
>
> Better yet, why not make an sqlite.eclass that would contain at least
> get_sqlite_major_version()?
>
No. The produced binaries can't depend on the build system like this.
Breaks binary packages etc.
Regards,
Petteri
signature.asc
Description: OpenPGP digital signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Donnie Berkholz wrote:
> On 12:35 Mon 24 Sep , Marijn Schouten (hkbst) wrote:
>> hkbst 07/09/24 12:35:11
>>
>> Modified: ChangeLog
>> Added:bigloo-3.0b_p2.ebuild
>> Log:
>> bump 3.0b-2, minor bugfix version
>> (Portage version: 2.1.3.9)
>
>> # "make test" does something weird so default src_test() in
>> /usr/lib/portage/bin/ebuild.sh fails the following test
>> # elif emake -j1 test -n &> /dev/null; then
>> # so copy straight from default src_test() all the stuff which depends on
>> that test passing
>> src_test() {
>> vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
>> if ! emake -j1 test; then
>> hasq test $FEATURES && die "Make test failed. See above for
>> details."
>> hasq test $FEATURES || eerror "Make test failed. See above for
>> details."
>> fi
>> }
>
> I'm a bit confused about what's going on here. Isn't src_test() only
> supposed to run when 'test' is in FEATURES?
I'm not sure, but as the comment says, I copied this straight from
/usr/lib/portage/bin/ebuild.sh and it goes:
src_test() {
if emake -j1 check -n &> /dev/null; then
vecho ">>> Test phase [check]: ${CATEGORY}/${PF}"
if ! emake -j1 check; then
hasq test $FEATURES && die "Make check failed. See
above for details."
hasq test $FEATURES || eerror "Make check failed. See
above for details."
fi
elif emake -j1 test -n &> /dev/null; then
vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
if ! emake -j1 test; then
hasq test $FEATURES && die "Make test failed. See
above for details."
hasq test $FEATURES || eerror "Make test failed. See
above for details."
fi
else
vecho ">>> Test phase [none]: ${CATEGORY}/${PF}"
fi
}
Marijn
PS Thank you for reviewing, Donnie.
- --
Marijn Schouten (hkBst), Gentoo Lisp project
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in www-servers/nginx: ChangeLog nginx-0.6.13.ebuild nginx-0.6.12.ebuild
"Konstantin Arkhipov (voxus)" <[EMAIL PROTECTED]>:
> Added:nginx-0.6.13.ebuild
> Removed: nginx-0.6.12.ebuild
> ./configure \
> --prefix=/usr \
econf is no option here?
> cp ${FILESDIR}/nginx-r1 ${T}/nginx
> doinitd ${T}/nginx
> cp ${FILESDIR}/nginx.conf-r4 conf/nginx.conf
Please add some quotes
> make DESTDIR=${D} install || die "failed to install
Quotes around $D and is emake not possible here?
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild
On Tuesday 25 September 2007 12:47:35 Marijn Schouten (hkBst) wrote:
> > > # "make test" does something weird so default src_test() in
> > > /usr/lib/portage/bin/ebuild.sh fails the following test
> > > # elif emake -j1 test -n &> /dev/null; then
> > > # so copy straight from default src_test() all the stuff which depends on
> > > that test passing
> > > src_test() {
> > > vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
> > > if ! emake -j1 test; then
> > > hasq test $FEATURES && die "Make test failed. See above for
> > > details."
> > > hasq test $FEATURES || eerror "Make test failed. See above for
> > > details."
> > > fi
> > > }
> >
> > I'm a bit confused about what's going on here. Isn't src_test() only
> > supposed to run when 'test' is in FEATURES?
>
> I'm not sure, but as the comment says, I copied this straight from
> /usr/lib/portage/bin/ebuild.sh and it goes:
[SNIP]
Some of that code is unreachable since src_test is never called when test is
not in FEATURES. Also there is some dispute as to whether testing the FEATURES
variable at all is permitted in ebuilds (bug #174335). In either case it's not
needed here. if `emake -j1 test -n` really fails for some reason even though
`emake -j1 test` generally works your src_test should just be:
src_test() {
emake -j1 test || die "Make test failed"
}
--
Bo Andresen
signature.asc
Description: This is a digitally signed message part.
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-proxy/squidguard: ChangeLog squidguard-1.2.1-r2.ebuild squidguard-1.2.1-r1.ebuild
"Alin Nastac (mrness)" <[EMAIL PROTECTED]>:
> Added:squidguard-1.2.1-r2.ebuild
> Removed: squidguard-1.2.1-r1.ebuild
> Log:
> Fix regular expresion matching (#193712).
[...]
> unpack ${A} || die "unpack problem"
unpack will die on its own.
> make prefix="/usr" INSTDIR="${D}" install || die "make
> install has failed"
emake not possible?
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-fs/udev: ChangeLog udev-115-r6.ebuild
Ryan Hill <[EMAIL PROTECTED]> posted [EMAIL PROTECTED], excerpted below, on Mon, 24 Sep 2007 20:19:34 -0600: > Duncan wrote: >> Can you point me (and anyone else that may be interested) to a nice >> explanation of the difference? I've always wondered why [[ ]] is >> considered "better" than [ ] for tests. > > check out http://tldp.org/LDP/abs/html/testconstructs.html#DBLBRACKETS Thanks (to Mike and Lars too). Seems I have some reading to do. =8^) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-proxy/squidguard: ChangeLog squidguard-1.2.1-r2.ebuild squidguard-1.2.1-r1.ebuild
Christian Faulhammer wrote:
> "Alin Nastac (mrness)" <[EMAIL PROTECTED]>:
>
>
>> Added:squidguard-1.2.1-r2.ebuild
>> Removed: squidguard-1.2.1-r1.ebuild
>> Log:
>> Fix regular expresion matching (#193712).
>>
> [...]
>
>> unpack ${A} || die "unpack problem"
>>
>
> unpack will die on its own.
>
>
>> make prefix="/usr" INSTDIR="${D}" install || die "make
>> install has failed"
>>
>
> emake not possible?
>
>
Both suggestions have been applied. Thanks!
signature.asc
Description: OpenPGP digital signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-ruby/IceRuby: IceRuby-3.2.1-r1.ebuild ChangeLog
"Caleb Tennis (caleb)" <[EMAIL PROTECTED]>:
> Modified: IceRuby-3.2.1-r1.ebuild ChangeLog
> Log:
> Fix up quoting a bit
> - unpack ${A}
> + unpack "${A}"
Don't do that, as $A may contain several elements which will not be
recognized when quoted.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-ada/xmlada: xmlada-1.0-r4.ebuild ChangeLog
"George Shapovalov (george)" <[EMAIL PROTECTED]>:
> Modified: xmlada-1.0-r4.ebuild ChangeLog
> adjusted ebuild to follow eclass reorg
[...]
> cd ${S}
Maybe you want to check for unquoted instances of $S, $T, $D,
$WORKDIR, $FILESDIR and so in that ebuild.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/fail2ban: fail2ban-0.8.1.ebuild ChangeLog
"Raphael Marichez (falco)" <[EMAIL PROTECTED]>:
> Add logrotate script file as from upstream documentation (bug
> 193745) (Portage version: 2.1.2.12)
> newinitd files/gentoo-initd fail2ban
I assume this is files directory available in the tarball.
> + # Use INSTALL_MASK if you do not want to
> touch /etc/logrotate.d.
> + # See http://thread.gmane.org/gmane.linux.gentoo.devel/35675
> + insinto /etc/logrotate.d
> + newins ${FILESDIR}/${PN}-logrotate ${PN} || die
Please quote occurences of $S, $D, $T, $WORKDIR, $FILESDIR and so on
and provide die with a message.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-mathematics/geomview: ChangeLog geomview-1.9.4.ebuild
"Markus Dittrich (markusle)" <[EMAIL PROTECTED]>:
> Added:geomview-1.9.4.ebuild
> Log:
> Version bump (see bug #193722).
> if use emacs; then
> insinto /usr/share/geomview
> doins "${FILESDIR}"/gvcl-mode.el || die
> fi
Please provide die messages. You will get a patch to update that
Emacs support soon.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/linuxtv-dvb-apps: ChangeLog linuxtv-dvb-apps-1.1.1.20070924.ebuild
Donnie Berkholz wrote: > On 20:04 Mon 24 Sep , Doug Goldstein (cardoe) wrote: > >> cardoe 07/09/24 20:04:55 >> >> Modified: ChangeLog >> Added:linuxtv-dvb-apps-1.1.1.20070924.ebuild >> Log: >> latest upstream snapshot. Includes many scan file updates. Drops duplicate >> installs of scan files in /usr/share/dvb. >> (Portage version: 2.1.3.9) >> > > >> 1.1 >> media-tv/linuxtv-dvb-apps/linuxtv-dvb-apps-1.1.1.20070924.ebuild >> >> file : >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/linuxtv-dvb-apps/linuxtv-dvb-apps-1.1.1.20070924.ebuild?rev=1.1&view=markup >> plain: >> http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-tv/linuxtv-dvb-apps/linuxtv-dvb-apps-1.1.1.20070924.ebuild?rev=1.1&content-type=text/plain >> > > Numerous instances of D, S, T without quotes. > > >> if ! use usb; then >> sed -i util/Makefile \ >> -e '/ttusb_dec_reset/d' \ >> -e '/dib3000-watch/d' >> fi >> >> # do not compile test-progs >> sed -i Makefile -e '/-C test/d' >> > > You might want to die if these seds fail. > > Thanks, > Donnie > I simply cp'd the previous revision to the new revision so it would pull now a newer upstream tarball then one from middle January. File a bug with the maintainers. -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild
On Tuesday 25 September 2007, Bo Ørsted Andresen wrote:
> On Tuesday 25 September 2007 12:47:35 Marijn Schouten (hkBst) wrote:
> > > > # "make test" does something weird so default src_test() in
> > > > /usr/lib/portage/bin/ebuild.sh fails the following test # elif emake
> > > > -j1 test -n &> /dev/null; then
> > > > # so copy straight from default src_test() all the stuff which
> > > > depends on that test passing src_test() {
> > > > vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
> > > > if ! emake -j1 test; then
> > > > hasq test $FEATURES && die "Make test failed. See above for
> > > > details." hasq test $FEATURES || eerror "Make test failed. See above
> > > > for details." fi
> > > > }
> > >
> > > I'm a bit confused about what's going on here. Isn't src_test() only
> > > supposed to run when 'test' is in FEATURES?
> >
> > I'm not sure, but as the comment says, I copied this straight from
> > /usr/lib/portage/bin/ebuild.sh and it goes:
>
> [SNIP]
>
> Some of that code is unreachable since src_test is never called when test
> is not in FEATURES. Also there is some dispute as to whether testing the
> FEATURES variable at all is permitted in ebuilds (bug #174335). In either
> case it's not needed here. if `emake -j1 test -n` really fails for some
> reason even though `emake -j1 test` generally works your src_test should
> just be:
>
> src_test() {
> emake -j1 test || die "Make test failed"
> }
why is src_test() defined at all ... the default src_test will execute `emake
check` if possible and then try `emake test`
-mike
signature.asc
Description: This is a digitally signed message part.
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/linuxtv-dvb-apps: ChangeLog linuxtv-dvb-apps-1.1.1.20070924.ebuild
On Tuesday 25 September 2007, Robert Buchholz wrote: > On Tuesday, 25. September 2007, Donnie Berkholz wrote: > > On 20:04 Mon 24 Sep , Doug Goldstein (cardoe) wrote: > > > if ! use usb; then > > > sed -i util/Makefile \ > > > -e '/ttusb_dec_reset/d' \ > > > -e '/dib3000-watch/d' > > > fi > > > > > > # do not compile test-progs > > > sed -i Makefile -e '/-C test/d' > > > > You might want to die if these seds fail. > > I already wondered a while back: > sed only fails if the file does not exist, but not if there was no > replacement. Is there any way to force it to? i'm fairly certain the answer is no -mike signature.asc Description: This is a digitally signed message part.
[gentoo-dev] FOSS.IN/2007
Hey everyone, This year's edition of India's largest Open Source event, FOSS.IN/2007 is taking place in Bangalore, India between the 4th to 8th of December 2007. As always, it's one of the most awesomest (if there is such a word) and fun events in the region and it would be nice to meet up with some Gentoo Devs/Users. I'll be around myself, so drop me a note if any of you will be coming :) The Call for Participation is out at http://foss.in/2007/info/Call_for_Participation so go ahead, submit your talks and hope to see some of you in B'lore :) Regards, -- Shyam Mani | <[EMAIL PROTECTED]> docs-team | http://gdp.gentoo.org devrel | http://devrel.gentoo.org infra | http://infrastructure.gentoo.org GPG Key| 0xFDD0E345 signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/linuxtv-dvb-apps: ChangeLog linuxtv-dvb-apps-1.1.1.20070924.ebuild
On Tue, 25 Sep 2007 11:10:34 +0200
Robert Buchholz <[EMAIL PROTECTED]> wrote:
> I already wondered a while back:
> sed only fails if the file does not exist, but not if there was no
> replacement. Is there any way to force it to?
Off the top of my head...
sed -e '1{x;s/^/0/;x;ta;:a}'
-e 's/$STRING/$REPLACEMENT/'
-e 'Tb;x;s/^/1/;x;:b;${p;x;/^0/Q1;Q0};'
--
[EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/linuxtv-dvb-apps: ChangeLog linuxtv-dvb-apps-1.1.1.20070924.ebuild
On 10:16 Tue 25 Sep , Doug Goldstein wrote: > Donnie Berkholz wrote: > > On 20:04 Mon 24 Sep , Doug Goldstein (cardoe) wrote: > > > >> cardoe 07/09/24 20:04:55 > >> > >> Modified: ChangeLog > >> Added:linuxtv-dvb-apps-1.1.1.20070924.ebuild > >> Log: > >> latest upstream snapshot. Includes many scan file updates. Drops > >> duplicate installs of scan files in /usr/share/dvb. > >> (Portage version: 2.1.3.9) > I simply cp'd the previous revision to the new revision so it would pull > now a newer upstream tarball then one from middle January. File a bug > with the maintainers. I feel a responsibility to commit the best, most bug-free code I can, regardless of whether I created the bug. Don't you? Thanks, Donnie -- [EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/bigloo: ChangeLog bigloo-3.0b_p2.ebuild
On 9/24/07, Donnie Berkholz <[EMAIL PROTECTED]> wrote:
> On 12:35 Mon 24 Sep , Marijn Schouten (hkbst) wrote:
> > hkbst 07/09/24 12:35:11
> >
> > Modified: ChangeLog
> > Added:bigloo-3.0b_p2.ebuild
> > Log:
> > bump 3.0b-2, minor bugfix version
> > (Portage version: 2.1.3.9)
>
> > # "make test" does something weird so default src_test() in
> > /usr/lib/portage/bin/ebuild.sh fails the following test
> > # elif emake -j1 test -n &> /dev/null; then
> > # so copy straight from default src_test() all the stuff which depends on
> > that test passing
> > src_test() {
> > vecho ">>> Test phase [test]: ${CATEGORY}/${PF}"
> > if ! emake -j1 test; then
> > hasq test $FEATURES && die "Make test failed. See above for
> > details."
> > hasq test $FEATURES || eerror "Make test failed. See above
> > for details."
> > fi
> > }
>
> I'm a bit confused about what's going on here. Isn't src_test() only
> supposed to run when 'test' is in FEATURES?
Yes, but this is done python side (not bash side).
You should not use $FEATURES in an ebuild as they are not meant to be
part of the API.
>
> Thanks,
> Donnie
> --
> [EMAIL PROTECTED] mailing list
>
>
--
[EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/linuxtv-dvb-apps: ChangeLog linuxtv-dvb-apps-1.1.1.20070924.ebuild
On 00:02 Wed 26 Sep , Stephen Bennett wrote:
> On Tue, 25 Sep 2007 11:10:34 +0200
> Robert Buchholz <[EMAIL PROTECTED]> wrote:
>
> > I already wondered a while back:
> > sed only fails if the file does not exist, but not if there was no
> > replacement. Is there any way to force it to?
>
> Off the top of my head...
>
> sed -e '1{x;s/^/0/;x;ta;:a}'
> -e 's/$STRING/$REPLACEMENT/'
> -e 'Tb;x;s/^/1/;x;:b;${p;x;/^0/Q1;Q0};'
I spent a few minutes trying to decipher that without luck. Could you
walk me through it?
Thanks,
Donnie
--
[EMAIL PROTECTED] mailing list
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-scheme/hop: metadata.xml ChangeLog hop-1.7.0.ebuild Manifest
"Marijn Schouten (hkbst)" <[EMAIL PROTECTED]>: > Added:metadata.xml ChangeLog hop-1.7.0.ebuild > Manifest Log: > Initial commit >./configure --prefix=/usr --libdir=/usr/$(get_libdir) || die > "configure failed" econf not possible here? V-Li -- Christian Faulhammer, Gentoo Lisp project http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode http://www.faulhammer.org/> signature.asc Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in gnome-base/gconf: ChangeLog gconf-2.20.0.ebuild
"Daniel Gryniewicz (dang)" <[EMAIL PROTECTED]>: > Modified: ChangeLog > Added:gconf-2.20.0.ebuild > Log: > New series for Gnome 2.20 > doenvd 50gconf || die A message is missing here. V-Li -- Christian Faulhammer, Gentoo Lisp project http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode http://www.faulhammer.org/> signature.asc Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/qbittorrent: ChangeLog qbittorrent-1.0.0_rc1.ebuild qbittorrent-1.0.0_beta7.ebuild
"Raul Porcel (armin76)" <[EMAIL PROTECTED]>: > Added:qbittorrent-1.0.0_rc1.ebuild > Removed: qbittorrent-1.0.0_beta7.ebuild > Version bump > # econf fails, since this uses qconf > ./configure --prefix=/usr --qtdir=/usr \ > --with-libtorrent-inc=/usr/include \ > --with-libtorrent-lib=/usr/lib \ > || die "configure failed" > emake || die "emake failed" Is this multilib safe? Shouldn't it use get_libdir()? V-Li -- Christian Faulhammer, Gentoo Lisp project http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode http://www.faulhammer.org/> signature.asc Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-news/liferea: ChangeLog liferea-1.4.3b.ebuild liferea-1.4.2b.ebuild
"Daniel Gryniewicz (dang)" <[EMAIL PROTECTED]>:
> Modified: ChangeLog
> Added:liferea-1.4.3b.ebuild
> Removed: liferea-1.4.2b.ebuild
> src_install() {
> gnome2_src_install
> rm -f ${D}/usr/bin/${PN}
> mv ${D}/usr/bin/${PN}-bin ${D}/usr/bin/${PN}
Could use some quotes.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-libs/gtk+: ChangeLog gtk+-2.12.0-r2.ebuild
"Mart Raudsepp (leio)" <[EMAIL PROTECTED]>:
> Modified: ChangeLog
> Added:gtk+-2.12.0-r2.ebuild
> Log:
> Fix a crash in file chooser search functionality and freezes in
> OpenOffice when ran outside Gnome; upstream bug #480123 and our bug
> #193513 respectively (Portage version: 2.1.3.9)
[...]
> src_test() {
> Xmake check || die
> }
Could use a die message.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-portage/genlop: ChangeLog genlop-0.30.8.ebuild
"Joe Peterson (lavajoe)" <[EMAIL PROTECTED]>: > Modified: ChangeLog > Added:genlop-0.30.8.ebuild > Version bump for portability of -c option to non-GNU/Linux > platforms (bug #172839) and better -r option performance/fixes > dobin genlop || die Could use a die message. V-Li -- Christian Faulhammer, Gentoo Lisp project http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode http://www.faulhammer.org/> signature.asc Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/baselayout: ChangeLog baselayout-1.12.10-r5.ebuild
"Mike Frysinger (vapier)" <[EMAIL PROTECTED]>:
> Modified: ChangeLog
> Added:baselayout-1.12.10-r5.ebuild
> Log:
> Add workaround for net.eth0 going AFK during upgrade to
> baselayout-2. (Portage version: 2.1.3.9)
> # Use correct path to filefuncs.so on multilib systems
> sed -i -e "s:/lib/rcscripts:/$(get_libdir)/rcscripts:" \
> ${S}/src/awk/{cachedepends,genenviron}.awk || die
> }
>
> src_compile() {
[...]
> make -C "${S}"/src \
> CC="$(tc-getCC)" \
> LD="$(tc-getCC) ${LDFLAGS}" \
> CFLAGS="${CFLAGS}" \
> LIBDIR="${libdir}" || die
> }
Could use a die message...no emake here?
[...]
> kdir ${PORTDIR}
Could use quotes.
> remap_dns_vars() {
[...]
> sed -e 's/\ -e 's/\ -e 's/\ -e 's/\ -e 's/\ \ -e 's/\ ${ROOT}/etc/conf.d/${f} > ${D}/etc/conf.d/${f}
Could use quotes.
> pkg_preinst() {
[...]
> rm -f ${ROOT}/etc/modules.conf
[...]
> rm -f ${ROOT}/etc/._cfg_gentoo-release
> echo "Gentoo Base System release ${PV}" >
> ${ROOT}/etc/gentoo-release
[...]
> for f in ${ROOT}etc/init.d/net.* ; do
[...]
> if sed -e 's/#.*//' ${ROOT}/etc/conf.d/{net,wireless}
> 2>/dev/null \ | egrep -q '\<(domain|nameservers|searchdomains)_' ;
> 2>then
[...]
> if sed -e 's/#.*//' ${ROOT}/etc/conf.d/net 2>/dev/null \
Could use quotes.
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-doc/gimp-help: ChangeLog gimp-help-0.13.ebuild
"Hanno Boeck (hanno)" <[EMAIL PROTECTED]>:
> Modified: ChangeLog
> Added:gimp-help-0.13.ebuild
> Log:
> gimp-help version bump
> src_install() {
> make DESTDIR="${D}" install || die "make install failed"
No emake here?
V-Li
--
Christian Faulhammer, Gentoo Lisp project
http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
http://www.faulhammer.org/>
signature.asc
Description: PGP signature
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/linuxtv-dvb-apps: ChangeLog linuxtv-dvb-apps-1.1.1.20070924.ebuild
On Wednesday 26 September 2007, Donnie Berkholz wrote:
> On 00:02 Wed 26 Sep , Stephen Bennett wrote:
> > On Tue, 25 Sep 2007 11:10:34 +0200
> >
> > Robert Buchholz <[EMAIL PROTECTED]> wrote:
> > > I already wondered a while back:
> > > sed only fails if the file does not exist, but not if there was no
> > > replacement. Is there any way to force it to?
> >
> > Off the top of my head...
> >
> > sed -e '1{x;s/^/0/;x;ta;:a}'
> > -e 's/$STRING/$REPLACEMENT/'
> > -e 'Tb;x;s/^/1/;x;:b;${p;x;/^0/Q1;Q0};'
>
> I spent a few minutes trying to decipher that without luck. Could you
> walk me through it?
sed maintains two buffers - pattern and hold (which start out empty) and
that's the trick here
{ } - used to group commands together
1 - only match first line (it's an address match)
x - swap pattern space and hold space
s/^/0/ - turn the (now) empty pattern space into "0"
x - swap pattern space and hold space
ta - branch to label a if previous expression matched something
a: - the actual label "a" ... needed to reset branching conditions
Tb - branch to label b if previous expression matched something
x - swap pattern space and hold space
s/^/1/ - insert "1" into the pattern space
x - swap pattern space and hold space
:b - the actual label "b'
$ - only match the last line (it's an address match)
p - print current pattern space
x - swap pattern space and hold space
/^0/Q1;Q0 - if the pattern space starts with a 0, exit with 1 ... otherwise
continue on to the exit with 0 ... either way, quit without printing
the optional argument to Q is a GNU extension which isnt documented in the
manpage :( ... guess i'll send them a patch
pretty sure the first expression can be dropped:
sed -e 's/$STRING/$REPLACEMENT/' \
-e 'tb;x;s/^/1/;x;:b;${p;x;/^$/Q1;Q0};'
and the printing makes it a little reliant on how sed is used ... i think
something like this should work with -n:
-e 'Tb;x;s/^/1/;x;:b;${x;/^$/{x;q1};x;q0}'
-mike
signature.asc
Description: This is a digitally signed message part.
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/baselayout: baselayout-2.0.0_rc4-r1.ebuild
On Wed, Sep 26, 2007 at 06:41:50AM +, Mike Frysinger (vapier) wrote:
> - if [[ -f "${ROOT}/etc/conf.d/$1" ]]; then
> + if [[ -f ${ROOT}/etc/conf.d/$1 ]]; then
You removed the quotes here - $ROOT with spaces?
> - [[ -e "${ROOT}etc/${x}" ]] && continue
> - [[ -e "${ROOT}usr/share/baselayout/${x}" ]] || continue
> - cp -p "${ROOT}usr/share/baselayout/${x}" ${ROOT}etc
> + [[ -e ${ROOT}etc/${x} ]] && continue
> + [[ -e ${ROOT}usr/share/baselayout/${x} ]] || continue
> + cp -p "${ROOT}usr/share/baselayout/${x}" "${ROOT}"etc
2 removes, one add. Make up your mind.
> - for f in ${ROOT}etc/init.d/net.*; do
> - [[ -L ${f} || ${f} == "${ROOT}etc/init.d/${lo}" ]] && continue
> + for f in "${ROOT}"etc/init.d/net.*; do
> + [[ -L ${f} || ${f} == */${lo} ]] && continue
Again the quotes, and that conditional looks iffy, it was checking
against ${ROOT}/etc/init.d/net.lo before, and now it's checking against
${PWD}/*/net.lo?
> - if [[ -e "${ROOT}"/etc/env.d/01hostname ]] ; then
> + if [[ -e ${ROOT}/etc/env.d/01hostname ]] ; then
...
> - if [[ -e "${ROOT}"/etc/init.d/domainname ]] ; then
> + if [[ -e ${ROOT}/etc/init.d/domainname ]] ; then
Again with the quotes.
--
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail : [EMAIL PROTECTED]
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
pgpGCkFYzfpgQ.pgp
Description: PGP signature
