Re: [PATCH] Containerfile-fedora-latest: add cargo

[Sam James]

Mark Wielaard  writes:

> Hi Sam,
>
> On Mon, Oct 07, 2024 at 07:39:09AM +0100, Sam James wrote:
>> Needed by the gccrs builders.
>> 
>> See e.g. https://builder.sourceware.org/buildbot/#/builders/37/builds/2060.
>
> Pushed, but note that this only works for gccrust-fedora-x86_64 (which
> is the only container builder), it doesn't work for the s390x builder
> you referenced (I'll ask Dan to install it there).
>
> Do note that for e.g. gccrust-bootstrap-debian-amd64 we had to add a
> very specific rust version.

Yeah, this shouldn't matter for Fedora as Debian's Rust is "old"
(although not really ;)) comparatively.

>
> And that there is still the issue of "unexpected successes" that
> hasn't been resolved:
>
> https://inbox.sourceware.org/gcc-rust/e4fa6922ce9fad8a338eecb8b3eb58f457f153ba.ca...@klomp.org/
> https://inbox.sourceware.org/gcc-rust/camyjc4_hwtzd1xdttnc9vp7skksjs9ecrbkhzihiyzfubev...@mail.gmail.com/
>

I'll take a look now.

> Cheers,
>
> Mark

thanks,
sam

[COMMITTED] Add virtual destructor to AbstractExpr

[Sam James]

From: Owen Avery 

gcc/rust/ChangeLog:

* checks/errors/borrowck/rust-bir.h
(class AbstractExpr): Add virtual destructor.

Signed-off-by: Owen Avery 
---
 gcc/rust/checks/errors/borrowck/rust-bir.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gcc/rust/checks/errors/borrowck/rust-bir.h 
b/gcc/rust/checks/errors/borrowck/rust-bir.h
index 4c298f147736..ed1f44686bc3 100644
--- a/gcc/rust/checks/errors/borrowck/rust-bir.h
+++ b/gcc/rust/checks/errors/borrowck/rust-bir.h
@@ -139,6 +139,8 @@ class AbstractExpr : public Visitable
 public:
   explicit AbstractExpr (ExprKind kind) : kind (kind) {}
   WARN_UNUSED_RESULT ExprKind get_kind () const { return kind; }
+
+  virtual ~AbstractExpr () {}
 };
 
 class InitializerExpr : public VisitableImpl
-- 
2.46.2