Re: Rust frontend patches v2
On 8/25/22 11:46, Philip Herron wrote: > The missing patches on > https://gcc.gnu.org/pipermail/gcc-patches/2022-August/thread.html#600200 > are 8, 10, 13, 29, and 22. Hmm, I think our limit is pretty low, sorry for that. Can you please paste output of du -hs 00*? What about limit increase, how much space do we have on sourceware infrastructure? Thanks, Martin -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: [PATCH Rust front-end v4 46/46] gccrs: Add README, CONTRIBUTING and compiler logo
On 12/6/22 11:14, arthur.co...@embecosm.com wrote: > |We still need to write out a documentation section, but these READMEs will > help in the meantime.| Hello. Just a quick comment: The Sphinx conversion didn't make it for all GCC manuals. However, you can still use Sphinx for a newly created manual, similarly to what libgccjit or Ada manuals do. Cheers, Martin -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: Rust front-end patches v4
On 12/6/22 11:13, arthur.co...@embecosm.com wrote: > Similarly to the previous round of patches, this patchset does not contain any > new features - only fixes for the reviews of the v3. New features will follow > shortly once that first patchset is merged. > > Once again, thank you to all the contributors who made this possible and > especially to Philip Herron for his dedication to the project. Hello. Congratulations for the patch set approval! I noticed a minor git issues when I tried approving the patches: warning: quoted CRLF detected .git/rebase-apply/patch:3850: trailing whitespace. /* TODO: spec syntax rules state that "MacroInvocationSemi" can be used as .git/rebase-apply/patch:3851: trailing whitespace. * ExternalItem, but text body isn't so clear. Adding MacroInvocationSemi warning: 2 lines add whitespace errors. .git/rebase-apply/patch:3374: indent with spaces. \ .git/rebase-apply/patch:3427: indent with spaces. \ warning: 2 lines add whitespace errors. .git/rebase-apply/patch:315: indent with spaces. // rust precedences .git/rebase-apply/patch:316: indent with spaces. PREC_CLOSURE = -40, // used for closures .git/rebase-apply/patch:317: indent with spaces. PREC_JUMP = -30,// used for break, continue, return, and yield .git/rebase-apply/patch:318: indent with spaces. PREC_RANGE = -10, // used for range (although weird comment in rustc about this) .git/rebase-apply/patch:319: indent with spaces. PREC_BINOP = FROM_ASSOC_OP, warning: squelched 6 whitespace errors warning: 11 lines add whitespace errors. .git/rebase-apply/patch:21: trailing whitespace. ; .git/rebase-apply/patch:26: trailing whitespace. ; warning: 2 lines add whitespace errors. .git/rebase-apply/patch:22: trailing whitespace. * If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/Rust-GCC/gccrs/issues/new). .git/rebase-apply/patch:23: trailing whitespace. Be sure to include a **title and clear description**, as much relevant information as possible, and a **code sample** .git/rebase-apply/patch:36: trailing whitespace. These will be imported into a GitHub PR to follow the normal review process, .git/rebase-apply/patch:43: trailing whitespace. * Do not open an issue on GitHub until you have collected positive feedback about the change. .git/rebase-apply/patch:61: trailing whitespace. * Where possible please add test cases to `gcc/testsuite/rust/` for all PRs. warning: squelched 15 whitespace errors warning: 20 lines add whitespace errors. Can you please take a look at that? Cheers, Martin -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: [PATCH Rust front-end v4 46/46] gccrs: Add README, CONTRIBUTING and compiler logo
On 12/13/22 02:43, Joseph Myers wrote: > On Fri, 9 Dec 2022, Martin Liška wrote: > >> On 12/6/22 11:14, arthur.co...@embecosm.com wrote: >>> |We still need to write out a documentation section, but these READMEs will >>> help in the meantime.| >> >> Hello. >> >> Just a quick comment: The Sphinx conversion didn't make it for all GCC >> manuals. However, you can still use Sphinx for a newly created manual, >> similarly to what libgccjit or Ada manuals do. > > I would also encourage people using Sphinx for a newly created manual to > consider setting up common build infrastructure for such manuals, possibly > based on that used in the attempted Sphinx conversion. It may be easier > to get common infrastructure for such manuals into shape if it's initially > only being used for one or two manuals - that is, if the addition of such > infrastructure isn't done at the same time as converting any existing > manuals to use Sphinx, or even converting any existing manuals using > Sphinx to use such infrastructure. > Hi. If the Rust folks are willing to use Sphinx, then yes, I'm going to prepare a common infrastructure (baseconf.py, common license files and a common Makefile). So something similar to what I prepared for the Sphinx conversion that didn't make it. Cheers, Martin -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: Rust front-end patches v4
On 12/13/22 14:26, Arthur Cohen wrote: > Thank you, and congratulations, to all the contributors. We thank you!! Congratulations. I have one question: do you have a list of supported architectures Rust FE can support right now? What are you plans for GCC 13.1 release? Cheers, Martin > > All the best, > > Arthur -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
