Re: [PATCH][15.2] nr2.0: late: Correctly initialize funny_error member
April 29, 2025 at 10:39 AM, "Andrew Pinski" mailto:pins...@gmail.com?to=%22Andrew%20Pinski%22%20%3Cpinskia%40gmail.com%3E > wrote: > > On Tue, Apr 29, 2025 at 1:26 AM wrote: > > > > > From: Arthur Cohen > > > > Hi everyone, > > > > We noticed inconsistent errors when running name-resolution 2.0 on > > certain files, where an invalid error was triggered and the message was > > from the `funny_ice` error finalizer function we had added as an easter > > egg. We realized yesterday that the undefined value was actually our > > `funny_error` boolean, which is supposed to be set only when resolving > > specific easter eggs `AST::IdentifierExpr`s. > > > > Since `funny_error` is a boolean, it does not get default-initialized in > > the constructor of `Late` - which this patch corrects. > > > > I will be pushing it to trunk directly, but this email specifically > > concerns its port into 15.2. > > > I am not sure if using NSDMI might be a better style here than doing > it in the constructor. > We discussed this before sending the patch but we didn't have any strong arguments for/against any solution. Do you have any? Thanks, Marc
Re: bootstrapping on a new platform - chicken and egg problem
> cargo should be a rust program but without the gccrs > how I am supposed to bootstrap ? Hello! Currently, the Rust frontend can't be bootstraped. You need an existing rustc toolchain (including cargo). Marc
Re: [PATCH] Remove lambda iterators in various HIR classes
David Faust via Gcc-rust writes: > On 10/8/21 10:45, David Faust via Gcc-rust wrote: >> This patch removes the lambda iterators used in various HIR objects. >> These iterators make interacting with the IR for static analysis more >> difficult. Instead, get_X () helpers are added for accessing elements, >> and uses of the iterators replaced with for loops. >> The following objects are adjusted in this patch: >> - HIR::TupleExpr >> - HIR::StructExprField >> - HIR::StructStruct >> - HIR::TupleStruct >> Fixes: #704, #705, #706, #707 > > This also adjusts HIR::ArrayElemsValues, fixing #703. > Must have lost those lines in the patch prep, sorry. Hi David, Thank you for this patch ! As gccrs is relying on github, feel free to open a pull request directly (if you can/want). I took care of it (and added the #703 while I was at it), and you can see that there are some small issues with the indentation: https://github.com/Rust-GCC/gccrs/pull/726/checks?check_run_id=3841896345 You need to be logged-in to see the results. If you don't have an account, you can still apply clang-format by hand :) Marc -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: [PATCH Rust front-end v3 01/46] Use DW_ATE_UTF for the Rust 'char' type
Mark Wielaard writes: > https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=no-Rust-old > if someone wants to push that, to merge for a v4. Sorry, missed that part, taking care of merging it right now :) https://github.com/Rust-GCC/gccrs/pull/1649 Thanks, Marc -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
