Re: [PATCH Rust front-end v4 46/46] gccrs: Add README, CONTRIBUTING and compiler logo
On Fri, 9 Dec 2022, Martin Liška wrote: > On 12/6/22 11:14, arthur.co...@embecosm.com wrote: > > |We still need to write out a documentation section, but these READMEs will > > help in the meantime.| > > Hello. > > Just a quick comment: The Sphinx conversion didn't make it for all GCC > manuals. However, you can still use Sphinx for a newly created manual, > similarly to what libgccjit or Ada manuals do. I would also encourage people using Sphinx for a newly created manual to consider setting up common build infrastructure for such manuals, possibly based on that used in the attempted Sphinx conversion. It may be easier to get common infrastructure for such manuals into shape if it's initially only being used for one or two manuals - that is, if the addition of such infrastructure isn't done at the same time as converting any existing manuals to use Sphinx, or even converting any existing manuals using Sphinx to use such infrastructure. -- Joseph S. Myers jos...@codesourcery.com-- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: [PATCH Rust front-end v4 46/46] gccrs: Add README, CONTRIBUTING and compiler logo
On Tue, 13 Dec 2022, Martin Liška wrote: > If the Rust folks are willing to use Sphinx, then yes, I'm going to > prepare a common infrastructure (baseconf.py, common license files and a > common Makefile). So something similar to what I prepared for the Sphinx > conversion that didn't make it. I suggest putting this in a directory such as gcc/doc/sphinx/ (rather than the top-level doc/ that was used in the Sphinx conversion). -- Joseph S. Myers jos...@codesourcery.com-- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: [PING, v2] Add '-Wno-complain-wrong-lang', and use it in 'gcc/testsuite/lib/target-supports.exp:check_compile' and elsewhere
On Tue, 21 Feb 2023, Thomas Schwinge wrote: > Is the attached v2 > "Add '-Wno-complain-wrong-lang', and use it in > 'gcc/testsuite/lib/target-supports.exp:check_compile' and elsewhere" > OK? OK. -- Joseph S. Myers jos...@codesourcery.com -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: [PATCH v3] libcpp: add function to check XID properties
On Fri, 8 Sep 2023, Arthur Cohen wrote:
> + if (c < 0x80)
> + {
> +if (('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z'))
> + return CPP_XID_START | CPP_XID_CONTINUE;
> +if (('0' <= c && c <= '9') || c == '_')
> + return CPP_XID_CONTINUE;
This may be an artifact of how the patch was mailed, but indentation seems
off here (should be six spaces for both return statements).
> + md = (mn + mx) / 2;
> + if (c <= ucnranges[md].end)
> + mx = md;
> + else
> + mn = md + 1;
And likewise here (should be a tab for both assignments).
OK with those indentation fixes.
--
Joseph S. Myers
jos...@codesourcery.com
