[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 Sam James changed: What|Removed |Added Component|spam|rust CC||dkm at gcc dot gnu.org, ||gcc-rust at gcc dot gnu.org -- You are receiving this mail because: You are on the CC list for the bug.
[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 Andrew Pinski changed: What|Removed |Added Keywords||build -- You are receiving this mail because: You are on the CC list for the bug.
[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 Andrew Pinski changed: What|Removed |Added Target Milestone|--- |14.0 -- You are receiving this mail because: You are on the CC list for the bug.
[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 Marek Polacek changed: What|Removed |Added Ever confirmed|0 |1 Last reconfirmed||2023-10-20 CC||mpolacek at gcc dot gnu.org Status|UNCONFIRMED |NEW --- Comment #1 from Marek Polacek --- Confirmed, Andrew noticed it too: https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633773.html -- You are receiving this mail because: You are on the CC list for the bug.
[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 --- Comment #2 from Andrew Pinski --- I noticed it via the build bot: https://gcc.gnu.org/pipermail/gcc-testresults/2023-October/798851.html -- You are receiving this mail because: You are on the CC list for the bug.
[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 Patrick Palka changed: What|Removed |Added Assignee|unassigned at gcc dot gnu.org |ppalka at gcc dot gnu.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug.
[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 --- Comment #3 from Patrick Palka --- I'm testing simply removing all occurrences of NON_DEPENDENT_EXPR in the parts of rust FE that were reused from the C++ FE -- You are receiving this mail because: You are on the CC list for the bug.
[PATCH] rust: build failure after NON_DEPENDENT_EXPR removal [PR111899]
Built on x86_64-pc-linux-gnu, pushed to trunk as obvious (hopefully).
-- >8 --
This patch removes stray NON_DEPENDENT_EXPR checks following the removal
of this tree code from the C++ FE. (Since this restores the build I
supppose it means the Rust FE never creates NON_DEPENDENT_EXPR trees in
the first place, so no further analysis is needed.)
PR rust/111899
gcc/rust/ChangeLog:
* backend/rust-constexpr.cc (potential_constant_expression_1):
Remove NON_DEPENDENT_EXPR handling.
* backend/rust-tree.cc (mark_exp_read): Likewise.
(mark_use): Likewise.
(lvalue_kind): Likewise.
---
gcc/rust/backend/rust-constexpr.cc | 1 -
gcc/rust/backend/rust-tree.cc | 3 ---
2 files changed, 4 deletions(-)
diff --git a/gcc/rust/backend/rust-constexpr.cc
b/gcc/rust/backend/rust-constexpr.cc
index b28fa27b2d0..a7ae4166ea0 100644
--- a/gcc/rust/backend/rust-constexpr.cc
+++ b/gcc/rust/backend/rust-constexpr.cc
@@ -6151,7 +6151,6 @@ potential_constant_expression_1 (tree t, bool want_rval,
bool strict, bool now,
case CLEANUP_POINT_EXPR:
case EXPR_STMT:
case PAREN_EXPR:
-case NON_DEPENDENT_EXPR:
/* For convenience. */
case LOOP_EXPR:
case EXIT_EXPR:
diff --git a/gcc/rust/backend/rust-tree.cc b/gcc/rust/backend/rust-tree.cc
index 66e859cd70c..7040c75f825 100644
--- a/gcc/rust/backend/rust-tree.cc
+++ b/gcc/rust/backend/rust-tree.cc
@@ -72,7 +72,6 @@ mark_exp_read (tree exp)
case ADDR_EXPR:
case INDIRECT_REF:
case FLOAT_EXPR:
-case NON_DEPENDENT_EXPR:
case VIEW_CONVERT_EXPR:
mark_exp_read (TREE_OPERAND (exp, 0));
break;
@@ -128,7 +127,6 @@ mark_use (tree expr, bool rvalue_p, bool read_p,
switch (TREE_CODE (expr))
{
case COMPONENT_REF:
-case NON_DEPENDENT_EXPR:
recurse_op[0] = true;
break;
case COMPOUND_EXPR:
@@ -4520,7 +4518,6 @@ lvalue_kind (const_tree ref)
lvalues. */
return (DECL_NONSTATIC_MEMBER_FUNCTION_P (ref) ? clk_none :
clk_ordinary);
-case NON_DEPENDENT_EXPR:
case PAREN_EXPR:
return lvalue_kind (TREE_OPERAND (ref, 0));
--
2.42.0.411.g813d9a9188
[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 --- Comment #4 from CVS Commits --- The master branch has been updated by Patrick Palka : https://gcc.gnu.org/g:5ac53c025e08b4c464b02cfc595e422813023c81 commit r14-4800-g5ac53c025e08b4c464b02cfc595e422813023c81 Author: Patrick Palka Date: Fri Oct 20 13:36:11 2023 -0400 rust: build failure after NON_DEPENDENT_EXPR removal [PR111899] This patch removes stray NON_DEPENDENT_EXPR checks following the removal of this tree code from the C++ FE. (Since this restores the build I supppose it means the Rust FE never creates NON_DEPENDENT_EXPR trees in the first place, so no further analysis is needed.) PR rust/111899 gcc/rust/ChangeLog: * backend/rust-constexpr.cc (potential_constant_expression_1): Remove NON_DEPENDENT_EXPR handling. * backend/rust-tree.cc (mark_exp_read): Likewise. (mark_use): Likewise. (lvalue_kind): Likewise. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug rust/111899] [14 regression] GCC fails to bootstrap with 'rust-tree.cc:131:10: error: ‘NON_DEPENDENT_EXPR’ was not declared in this scope'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111899 Patrick Palka changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #5 from Patrick Palka --- Fixed -- You are receiving this mail because: You are on the CC list for the bug.
