Re: [PATCH Rust front-end v4 46/46] gccrs: Add README, CONTRIBUTING and compiler logo
On 12/6/22 11:14, arthur.co...@embecosm.com wrote: > |We still need to write out a documentation section, but these READMEs will > help in the meantime.| Hello. Just a quick comment: The Sphinx conversion didn't make it for all GCC manuals. However, you can still use Sphinx for a newly created manual, similarly to what libgccjit or Ada manuals do. Cheers, Martin -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
☺ Buildbot (GNU Toolchain): gccrust - build successful (master)
A restored build has been detected on builder gccrust-fedora-ppc64le while building gccrust. Full details are available at: https://builder.sourceware.org/buildbot/#builders/19/builds/528 Build state: build successful Revision: ca0a935cdc375f4747ac67b7dc978be06041dab2 Worker: fedora-ppc64le Build Reason: (unknown) Blamelist: Aldy Hernandez , Alexander Monakov , Alexandre Oliva , Andre Vieira , Andrea Corallo , Andrew MacLeod , Andrew Pinski , Andrew Stubbs , Arsen Arsenovic , Arsen Arsenović , Artem Klimov , Arthur Cohen , Bob Duff , Boris Yakobowski , Christophe Lyon , Claudiu Zissulescu , Cui,Lili , Dave , David Faust , David Malcolm , Dimitar Dimitrov , Eric Botcazou , Eugene Rozenfeld , Faisal Abbas , Florian Weimer , Francois-Xavier Coudert , François Dumont , GCC Administrator , Gary Dismukes , Ghjuvan Lacambre , Guillermo E. Martinez , H.J. Lu , Haochen Jiang , Harald Anlauf , Hongyu Wang , Hu, Lin1 , Iain Buclaw , Ian Lance Taylor , Jakub Dupak , Jakub Jelinek , Jason Merrill , Jeff Law , Jeff Law , Jiawei , Jiufu Guo , Jonathan Wakely , Jose E. Marchesi , Joseph Myers , José Rui Faustino de Sousa , Ju-Zhe Zhong , Julian Brown , Justin Squirek , Jørgen Kvalsvik , Kewen Lin , Kim Kuparinen , Kito Cheng , Kong Lingling , Kyrylo Tkachov , Kévin Le Gouguec , LIU Hao , Lewis Hyatt , Liwei Xu , Lulu Cheng , Marc Poulhiès , Marc Poulhiès , Marek Polacek , Mark Wielaard , Martin Jambor , Martin Liska , Meghan Denny , Michael Eager , Mikael Morin , Monk Chiang , Nathan Sidwell , Olivier Hainque , Palmer Dabbelt , Patrick Palka , Philip Herron , Philip Herron , Philipp Tomsich , Piotr Trojanek , Qing Zhao , Raiki Tamura , Rainer Orth , Ramana Radhakrishnan , Richard Biener , Richard Sandiford , Robin Dapp , Ronan Desplanques , Segher Boessenkool , Sergei Trofimovich , Stafford Horne , Stefan Schulze Frielinghaus , Steve Baird , Steve Kargl , Takayuki 'January June' Suwa , Tejas Joshi , Than McIntosh , Thomas Neumann , Thomas Schwinge , Tobias Burnus , Torbjörn SVENSSON , Tucker Taft , Ulrich Drepper , Vineet Gupta , Wilco Dijkstra , Xi Ruoyao , Xiongchuan Tan , Yannick Moy , YunQiang Su , bors[bot] <26634292+bors[bot]@users.noreply.github.com>, konglin1 , liuhongt , melonedo , Дилян Палаузов Steps: - 0: worker_preparation ( success ) - 1: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/1/logs/stdio - 2: rm -rf gccrs-build ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/2/logs/stdio - 3: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/3/logs/stdio - 4: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/4/logs/stdio - warnings (29): https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/4/logs/warnings__29_ - 5: make check ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/5/logs/stdio - rust.sum: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/5/logs/rust_sum - rust.log: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/5/logs/rust_log - warnings (4): https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/5/logs/warnings__4_ - 6: grep unexpected rust.sum ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/6/logs/stdio - 7: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/7/logs/stdio - 8: build bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/8/logs/stdio - 9: fetch bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/9/logs/stdio - 10: unpack bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/10/logs/stdio - 11: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/11/logs/stdio - 12: pass .bunsen.source.gitdescribe ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/12/logs/stdio - 13: pass .bunsen.source.gitbranch ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/13/logs/stdio - 14: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/528/steps/14/logs/stdio - 15: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/buil
☠ Buildbot (GNU Toolchain): gccrust - failed 'grep unexpected ...' (failure) (master)
A new failure has been detected on builder gccrust-fedora-ppc64le while building gccrust. Full details are available at: https://builder.sourceware.org/buildbot/#builders/19/builds/529 Build state: failed 'grep unexpected ...' (failure) Revision: 88e509b1b1423867b138617c87a3e709c1db95eb Worker: fedora-ppc64le Build Reason: (unknown) Blamelist: Arthur Cohen Steps: - 0: worker_preparation ( success ) - 1: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/1/logs/stdio - 2: rm -rf gccrs-build ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/2/logs/stdio - 3: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/3/logs/stdio - 4: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/4/logs/stdio - warnings (988): https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/4/logs/warnings__988_ - 5: make check ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/5/logs/stdio - rust.sum: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/5/logs/rust_sum - rust.log: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/5/logs/rust_log - warnings (4): https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/5/logs/warnings__4_ - 6: grep unexpected rust.sum ( failure ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/6/logs/stdio - 7: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/7/logs/stdio - 8: build bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/8/logs/stdio - 9: fetch bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/9/logs/stdio - 10: unpack bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/10/logs/stdio - 11: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/11/logs/stdio - 12: pass .bunsen.source.gitdescribe ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/12/logs/stdio - 13: pass .bunsen.source.gitbranch ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/13/logs/stdio - 14: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/14/logs/stdio - 15: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/15/logs/stdio - 16: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/16/logs/stdio - 17: rm -rf gccrs-build_1 ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/19/builds/529/steps/17/logs/stdio -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: Rust front-end patches v4
On 12/6/22 11:13, arthur.co...@embecosm.com wrote: > Similarly to the previous round of patches, this patchset does not contain any > new features - only fixes for the reviews of the v3. New features will follow > shortly once that first patchset is merged. > > Once again, thank you to all the contributors who made this possible and > especially to Philip Herron for his dedication to the project. Hello. Congratulations for the patch set approval! I noticed a minor git issues when I tried approving the patches: warning: quoted CRLF detected .git/rebase-apply/patch:3850: trailing whitespace. /* TODO: spec syntax rules state that "MacroInvocationSemi" can be used as .git/rebase-apply/patch:3851: trailing whitespace. * ExternalItem, but text body isn't so clear. Adding MacroInvocationSemi warning: 2 lines add whitespace errors. .git/rebase-apply/patch:3374: indent with spaces. \ .git/rebase-apply/patch:3427: indent with spaces. \ warning: 2 lines add whitespace errors. .git/rebase-apply/patch:315: indent with spaces. // rust precedences .git/rebase-apply/patch:316: indent with spaces. PREC_CLOSURE = -40, // used for closures .git/rebase-apply/patch:317: indent with spaces. PREC_JUMP = -30,// used for break, continue, return, and yield .git/rebase-apply/patch:318: indent with spaces. PREC_RANGE = -10, // used for range (although weird comment in rustc about this) .git/rebase-apply/patch:319: indent with spaces. PREC_BINOP = FROM_ASSOC_OP, warning: squelched 6 whitespace errors warning: 11 lines add whitespace errors. .git/rebase-apply/patch:21: trailing whitespace. ; .git/rebase-apply/patch:26: trailing whitespace. ; warning: 2 lines add whitespace errors. .git/rebase-apply/patch:22: trailing whitespace. * If you're unable to find an open issue addressing the problem, [open a new one](https://github.com/Rust-GCC/gccrs/issues/new). .git/rebase-apply/patch:23: trailing whitespace. Be sure to include a **title and clear description**, as much relevant information as possible, and a **code sample** .git/rebase-apply/patch:36: trailing whitespace. These will be imported into a GitHub PR to follow the normal review process, .git/rebase-apply/patch:43: trailing whitespace. * Do not open an issue on GitHub until you have collected positive feedback about the change. .git/rebase-apply/patch:61: trailing whitespace. * Where possible please add test cases to `gcc/testsuite/rust/` for all PRs. warning: squelched 15 whitespace errors warning: 20 lines add whitespace errors. Can you please take a look at that? Cheers, Martin -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Prepare 'contrib/gcc-changelog/git_commit.py' for GCC/Rust (was: Rust front-end patches v4)
Hi!
On 2022-12-06T12:03:56+0100, Richard Biener via Gcc-patches
wrote:
> On Tue, Dec 6, 2022 at 11:11 AM wrote:
>> This patchset contains the fixed version of our most recent patchset. [...]
>
> Thanks a lot - this is OK to merge now
Hey, hey! :-)
Still working on some final edits to make the Git commits comply with GCC
policies, but hopefully ready to push soon.
I've pushed "Prepare 'contrib/gcc-changelog/git_commit.py' for GCC/Rust"
to master branch in commit 325529e21e81fbc3561d2568cb7e8a26296e5b2f, see
attached.
Please let me know if there is anything that I need to do to actually
generate the empty 'gcc/rust/ChangeLog' file.
(For avoidance of doubt: yes, only 'gcc/rust/' at this time.)
Grüße
Thomas
-
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
München, HRB 106955
>From 325529e21e81fbc3561d2568cb7e8a26296e5b2f Mon Sep 17 00:00:00 2001
From: Thomas Schwinge
Date: Sat, 10 Dec 2022 07:27:55 +0100
Subject: [PATCH] Prepare 'contrib/gcc-changelog/git_commit.py' for GCC/Rust
contrib/
* gcc-changelog/git_commit.py (default_changelog_locations): Add
'gcc/rust'.
(bug_components): Add 'rust'.
---
contrib/gcc-changelog/git_commit.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index fb1d15fd86df..aae3416e082f 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -45,6 +45,7 @@ default_changelog_locations = {
'gcc/objc',
'gcc/objcp',
'gcc/po',
+'gcc/rust',
'gcc/testsuite',
'gnattools',
'gotools',
@@ -122,6 +123,7 @@ bug_components = {
'preprocessor',
'regression',
'rtl-optimization',
+'rust',
'sanitizer',
'spam',
'target',
--
2.35.1
--
Gcc-rust mailing list
Gcc-rust@gcc.gnu.org
https://gcc.gnu.org/mailman/listinfo/gcc-rust
Add stub 'gcc/rust/ChangeLog' (was: Prepare 'contrib/gcc-changelog/git_commit.py' for GCC/Rust)
Hi! On 2022-12-10T07:39:24+0100, I wrote: > I've pushed "Prepare 'contrib/gcc-changelog/git_commit.py' for GCC/Rust" > to master branch in commit 325529e21e81fbc3561d2568cb7e8a26296e5b2f, see > attached. > > Please let me know if there is anything that I need to do to actually > generate the empty 'gcc/rust/ChangeLog' file. I've now been informed of a non-public email, that indeed there is a manual step involved; pushed "Add stub 'gcc/rust/ChangeLog'" to master branch in commit 24ff0b3e0c41e3997fb4c11736b8a412afbaadf3, see attached. > (For avoidance of doubt: yes, only 'gcc/rust/' at this time.) Grüße Thomas - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 >From 24ff0b3e0c41e3997fb4c11736b8a412afbaadf3 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Sat, 10 Dec 2022 08:33:22 +0100 Subject: [PATCH] Add stub 'gcc/rust/ChangeLog' --- gcc/rust/ChangeLog | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 gcc/rust/ChangeLog diff --git a/gcc/rust/ChangeLog b/gcc/rust/ChangeLog new file mode 100644 index ..3a4f03c28af8 --- /dev/null +++ b/gcc/rust/ChangeLog @@ -0,0 +1,6 @@ + +Copyright (C) 2022 Free Software Foundation, Inc. + +Copying and distribution of this file, with or without modification, +are permitted in any medium without royalty provided the copyright +notice and this notice are preserved. -- 2.35.1 -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
