Re: [PATCH Rust front-end v3 35/46] gccrs: Add metadata ouptput pass
On 10/26/22 23:04, David Malcolm wrote:
%{On Wed, 2022-10-26 at 10:18 +0200, arthur.co...@embecosm.com wrote:
From: Philip Herron
Extern crates statements to tell the front-end to look for another
library.
The mechanism here is heavily inspired from gccgo, so when we compile
a
library for example we invoke:
[...snip...]
+ rust_error_at (Location (),
+ "expected metadata-output path to have base file
name of: "
+ "%<%s%> got %<%s%>",
+ expected_file_name.c_str (), path_base_name);
I can't comment on the patch in depth, but does rust_error_at call into
GCC's regular diagnostics?
If so, "%qs" is a more idiomatic way to express printing a string
argument in quotes (and bold), rather than "%<%s%>", though IIRC they
do the same thing (unless I'm missing something?).
I also believe that they do the same thing. We have some %<%s%>
left-over from previous, more complex format strings, so good catch and
thank you for noticing. I'll fix them up.
This shows up in a few places in this patch, and might affect other
patches in the kit - though it's a minor nitpick, of course.
Dave
OpenPGP_0x1B3465B044AD9C65.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
--
Gcc-rust mailing list
Gcc-rust@gcc.gnu.org
https://gcc.gnu.org/mailman/listinfo/gcc-rust
Re: [PATCH Rust front-end v3 40/46] gccrs: Add GCC Rust front-end Make-lang.in
(...snip...) +RUST_SELFTEST_FLAGS = -xrs $(SELFTEST_FLAGS) I've noticed that this patch contains a typo which prevents self-tests from running properly. This should be `-xrust`, not `-xrs`. I assume there will be some other review comments, so that will be fixed in a v4 of the patches. Sorry about the annoyance. (...snip...) Kindly, -- Arthur Cohen Toolchain Engineer Embecosm GmbH Geschäftsführer: Jeremy Bennett Niederlassung: Nürnberg Handelsregister: HR-B 36368 www.embecosm.de Fürther Str. 27 90429 Nürnberg Tel.: 091 - 128 707 040 Fax: 091 - 128 707 077 OpenPGP_0x1B3465B044AD9C65.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
☺ Buildbot (GNU Toolchain): gccrust - build successful (master)
A restored build has been detected on builder gccrust-fedora-arm64 while building gccrust. Full details are available at: https://builder.sourceware.org/buildbot/#builders/179/builds/230 Build state: build successful Revision: 2357b5d5138a926d7b3f054aa66549482bec9be6 Worker: fedora-arm64 Build Reason: (unknown) Blamelist: Arthur Cohen , bors[bot] <26634292+bors[bot]@users.noreply.github.com> Steps: - 0: worker_preparation ( success ) - 1: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/1/logs/stdio - 2: rm -rf gccrs-build ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/2/logs/stdio - 3: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/3/logs/stdio - 4: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/4/logs/stdio - warnings (1069): https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/4/logs/warnings__1069_ - 5: make check ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/5/logs/stdio - rust.sum: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/5/logs/rust_sum - rust.log: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/5/logs/rust_log - warnings (6): https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/5/logs/warnings__6_ - 6: grep unexpected rust.sum ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/6/logs/stdio - 7: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/7/logs/stdio - 8: build bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/8/logs/stdio - 9: fetch bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/9/logs/stdio - 10: unpack bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/10/logs/stdio - 11: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/11/logs/stdio - 12: pass .bunsen.source.gitdescribe ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/12/logs/stdio - 13: pass .bunsen.source.gitbranch ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/13/logs/stdio - 14: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/14/logs/stdio - 15: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/15/logs/stdio - 16: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/16/logs/stdio - 17: rm -rf gccrs-build_1 ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/230/steps/17/logs/stdio -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
☠ Buildbot (GNU Toolchain): gccrust - failed 'grep unexpected ...' (failure) (master)
A new failure has been detected on builder gccrust-fedora-arm64 while building gccrust. Full details are available at: https://builder.sourceware.org/buildbot/#builders/179/builds/240 Build state: failed 'grep unexpected ...' (failure) Revision: fc2aa3cd381613a69129cd183a352f3e3c23643b Worker: fedora-arm64 Build Reason: (unknown) Blamelist: Arthur Cohen , bors[bot] <26634292+bors[bot]@users.noreply.github.com> Steps: - 0: worker_preparation ( success ) - 1: git checkout ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/1/logs/stdio - 2: rm -rf gccrs-build ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/2/logs/stdio - 3: configure ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/3/logs/stdio - 4: make ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/4/logs/stdio - warnings (1074): https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/4/logs/warnings__1074_ - 5: make check ( warnings ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/5/logs/stdio - rust.sum: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/5/logs/rust_sum - rust.log: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/5/logs/rust_log - warnings (6): https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/5/logs/warnings__6_ - 6: grep unexpected rust.sum ( failure ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/6/logs/stdio - 7: prep ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/7/logs/stdio - 8: build bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/8/logs/stdio - 9: fetch bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/9/logs/stdio - 10: unpack bunsen.cpio.gz ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/10/logs/stdio - 11: pass .bunsen.source.gitname ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/11/logs/stdio - 12: pass .bunsen.source.gitdescribe ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/12/logs/stdio - 13: pass .bunsen.source.gitbranch ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/13/logs/stdio - 14: pass .bunsen.source.gitrepo ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/14/logs/stdio - 15: upload to bunsen ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/15/logs/stdio - 16: clean up ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/16/logs/stdio - 17: rm -rf gccrs-build_1 ( success ) Logs: - stdio: https://builder.sourceware.org/buildbot/#builders/179/builds/240/steps/17/logs/stdio -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
