Regressions on master at commit r16-69 vs commit r16-63 on Linux/x86_64
Regressions on master at commit r16-69 vs commit r16-63 on Linux/x86_64 New failures: New passes: FAIL: 30_threads/async/async.cc -std=gnu++17 execution test
Adjust 'libgomp.c++/target-exceptions-pr118794-1.C' for 'targetm.arm_eabi_unwinder' [PR118794] (was: [Linaro-TCWG-CI] gcc-15-9463-gaa3e72f9430: 2 regressions on arm)
Hi! On 2025-04-17T18:15:50+, ci_notify--- via Gcc-regression wrote: > Our automatic CI has detected problems related to your patch(es). Please find > some details below. > > In bootstrap_check master-arm-check_bootstrap, after: > | commit gcc-15-9463-gaa3e72f9430 > | Author: Thomas Schwinge > | Date: Thu Mar 27 23:06:37 2025 +0100 > | > | Add test cases for exception handling constructs in dead code for > GCN, nvptx target and OpenMP 'target' offloading [PR118794] > | > | PR target/118794 > | gcc/testsuite/ > | * g++.target/gcn/exceptions-pr118794-1.C: New. > | ... 7 lines of the commit log omitted. > > Produces 2 regressions: > | > | regressions.sum: > | Running libgomp:libgomp.c++/c++.exp ... > | FAIL: libgomp.c++/target-exceptions-pr118794-1.C scan-tree-dump-times > optimized "gimple_call <__builtin_eh_pointer, " 1 > | FAIL: libgomp.c++/target-exceptions-pr118794-1.C scan-tree-dump-times > optimized "gimple_call <__builtin_unwind_resume, " 1 Ah, sorry for that. This is due to 'targetm.arm_eabi_unwinder', as per: gcc/config/arm/arm.cc:#define TARGET_ARM_EABI_UNWINDER true gcc/config/c6x/c6x.cc:#define TARGET_ARM_EABI_UNWINDER true ..., which for ARM is conditional to '#if ARM_UNWIND_INFO' (defined in 'gcc/config/arm/bpabi.h', used for various GCC configurations), and for C6x unconditional. This gets us: --- target-exceptions-pr118794-1.C.269t.optimized +++ target-exceptions-pr118794-1.C.270t.optimized [...] __attribute__((omp declare target)) void f () [...] gimple_call <__dt_comp , NULL, &c> - gimple_call <__builtin_eh_pointer, _7, 2> - gimple_call <__builtin_unwind_resume, NULL, _7> + gimple_call <__builtin_cxa_end_cleanup, NULL> } [...] There doesn't appear to be an effective-target keyword for 'targetm.arm_eabi_unwinder' specifically, do we need to add one? Or, other test cases appear to use effective-target 'arm_eabi' to disambiguate the two variants; is that the right thing to use here, too? (..., plus 'tic6x-*-*' in this case?) OK to push the attached "Adjust 'libgomp.c++/target-exceptions-pr118794-1.C' for 'targetm.arm_eabi_unwinder' [PR118794]"? (Could Arm/C6x maintainers please test this for me?) Grüße Thomas > Used configuration : > *CI config* tcwg_bootstrap_check master-arm-check_bootstrap > *configure and test flags:* none, autodetected on > armv8l-unknown-linux-gnueabihf > > We track this bug report under https://linaro.atlassian.net/browse/GNU-1562. > Please let us know if you have a fix. > > If you have any questions regarding this report, please ask on > linaro-toolch...@lists.linaro.org mailing list. > > -8<--8<--8<-- > > The information below contains the details of the failures, and the ways to > reproduce a debug environment: > > You can find the failure logs in *.log.1.xz files in > * > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1236/artifact/artifacts/00-sumfiles/ > The full lists of regressions and improvements as well as configure and make > commands are in > * > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1236/artifact/artifacts/notify/ > The list of [ignored] baseline and flaky failures are in > * > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1236/artifact/artifacts/sumfiles/xfails.xfail > > Current build : > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1236/artifact/artifacts > Reference build : > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1235/artifact/artifacts > > Instruction to reproduce the build : > https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha1/aa3e72f943032e5f074b2bd2fd06d130dda8760b/tcwg_bootstrap_check/master-arm-check_bootstrap/reproduction_instructions.txt > > Full commit : > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aa3e72f943032e5f074b2bd2fd06d130dda8760b >From 423af3203bd9ebcf1f472f244c8e0d698163967f Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 22 Apr 2025 13:41:22 +0200 Subject: [PATCH] Adjust 'libgomp.c++/target-exceptions-pr118794-1.C' for 'targetm.arm_eabi_unwinder' [PR118794] Fix-up for commit aa3e72f943032e5f074b2bd2fd06d130dda8760b "Add test cases for exception handling constructs in dead code for GCN, nvptx target and OpenMP 'target' offloading [PR118794]": we need to adjust for configurations with 'targetm.arm_eabi_unwinder', as per: gcc/config/arm/arm.cc:#define TARGET_ARM_EABI_UNWINDER true gcc/config/c6x/c6x.cc:#define TARGET_ARM_EABI_UNWINDER true ..., which for ARM is conditional to '#if ARM_UNWIND_INFO' (defined in 'gcc/config/arm/bpabi.h', used for various GCC configurations), and for C6x unconditional. This gets us:
Regressions on master at commit r16-63 vs commit r16-57 on Linux/x86_64
Regressions on master at commit r16-63 vs commit r16-57 on Linux/x86_64 New failures: FAIL: 30_threads/async/async.cc -std=gnu++17 execution test New passes:
Regressions on native/releases/gcc-14 at commit r14-11675 vs commit r14-11664 on Linux/x86_64
Regressions on releases/gcc-14 at commit r14-11675 vs commit r14-11664 on Linux/x86_64 New failures: FAIL: c-c++-common/tsan/atomic_stack.c -O2 output pattern test FAIL: c-c++-common/tsan/pr65400-1.c -O0 output pattern test FAIL: c-c++-common/tsan/pr68260.c -O2 execution test FAIL: c-c++-common/tsan/race_on_barrier.c -O2 output pattern test FAIL: c-c++-common/tsan/thread_leak1.c -O0 output pattern test FAIL: c-c++-common/tsan/thread_leak2.c -O2 output pattern test FAIL: c-c++-common/tsan/tiny_race.c -O0 output pattern test FAIL: c-c++-common/tsan/tiny_race.c -O2 output pattern test FAIL: c-c++-common/tsan/tls_race.c -O0 output pattern test FAIL: c-c++-common/tsan/volatile.c -O2 execution test FAIL: c-c++-common/tsan/write_in_reader_lock.c -O2 output pattern test FAIL: g++.dg/tsan/pthread_cond_clockwait.C -O2 execution test FAIL: g++.dg/tsan/vptr_benign_race.C -O2 execution test FAIL: g++.dg/tsan/vptr_harmful_race.C -O0 output pattern test FAIL: g++.dg/tsan/vptr_harmful_race.C -O2 output pattern test New passes: FAIL: c-c++-common/tsan/bitfield_race.c -O2 output pattern test FAIL: c-c++-common/tsan/fd_pipe_race.c -O0 output pattern test FAIL: c-c++-common/tsan/fd_pipe_race.c -O2 output pattern test FAIL: c-c++-common/tsan/free_race2.c -O2 output pattern test FAIL: c-c++-common/tsan/free_race.c -O0 output pattern test FAIL: c-c++-common/tsan/mutexset1.c -O2 output pattern test FAIL: c-c++-common/tsan/pr65400-1.c -O2 output pattern test FAIL: c-c++-common/tsan/pr65400-3.c -O0 output pattern test FAIL: c-c++-common/tsan/race_on_barrier2.c -O0 output pattern test FAIL: c-c++-common/tsan/race_on_mutex2.c -O0 output pattern test FAIL: c-c++-common/tsan/race_on_mutex.c -O0 output pattern test FAIL: c-c++-common/tsan/race_on_mutex.c -O0 output pattern test FAIL: c-c++-common/tsan/simple_race.c -O0 output pattern test FAIL: c-c++-common/tsan/simple_race.c -O2 output pattern test FAIL: c-c++-common/tsan/simple_race.c -O2 output pattern test FAIL: c-c++-common/tsan/simple_stack.c -O0 output pattern test FAIL: c-c++-common/tsan/simple_stack.c -O0 output pattern test FAIL: c-c++-common/tsan/simple_stack.c -O2 output pattern test FAIL: c-c++-common/tsan/thread_leak.c -O0 execution test
Re: Adjust 'libgomp.c++/target-exceptions-pr118794-1.C' for 'targetm.arm_eabi_unwinder' [PR118794] (was: [Linaro-TCWG-CI] gcc-15-9463-gaa3e72f9430: 2 regressions on arm)
Hi! On Tue, 22 Apr 2025 at 13:55, Thomas Schwinge wrote: > > Hi! > > On 2025-04-17T18:15:50+, ci_notify--- via Gcc-regression > wrote: > > Our automatic CI has detected problems related to your patch(es). Please > > find some details below. > > > > In bootstrap_check master-arm-check_bootstrap, after: > > | commit gcc-15-9463-gaa3e72f9430 > > | Author: Thomas Schwinge > > | Date: Thu Mar 27 23:06:37 2025 +0100 > > | > > | Add test cases for exception handling constructs in dead code for > > GCN, nvptx target and OpenMP 'target' offloading [PR118794] > > | > > | PR target/118794 > > | gcc/testsuite/ > > | * g++.target/gcn/exceptions-pr118794-1.C: New. > > | ... 7 lines of the commit log omitted. > > > > Produces 2 regressions: > > | > > | regressions.sum: > > | Running libgomp:libgomp.c++/c++.exp ... > > | FAIL: libgomp.c++/target-exceptions-pr118794-1.C scan-tree-dump-times > > optimized "gimple_call <__builtin_eh_pointer, " 1 > > | FAIL: libgomp.c++/target-exceptions-pr118794-1.C scan-tree-dump-times > > optimized "gimple_call <__builtin_unwind_resume, " 1 > > Ah, sorry for that. This is due to 'targetm.arm_eabi_unwinder', as per: > > gcc/config/arm/arm.cc:#define TARGET_ARM_EABI_UNWINDER true > gcc/config/c6x/c6x.cc:#define TARGET_ARM_EABI_UNWINDER true > > ..., which for ARM is conditional to '#if ARM_UNWIND_INFO' (defined in > 'gcc/config/arm/bpabi.h', used for various GCC configurations), and for > C6x unconditional. > > This gets us: > > --- target-exceptions-pr118794-1.C.269t.optimized > +++ target-exceptions-pr118794-1.C.270t.optimized > [...] > __attribute__((omp declare target)) > void f () > [...] >gimple_call <__dt_comp , NULL, &c> > - gimple_call <__builtin_eh_pointer, _7, 2> > - gimple_call <__builtin_unwind_resume, NULL, _7> > + gimple_call <__builtin_cxa_end_cleanup, NULL> > > } > [...] > > There doesn't appear to be an effective-target keyword for > 'targetm.arm_eabi_unwinder' specifically, do we need to add one? > Or, other test cases appear to use effective-target 'arm_eabi' to > disambiguate the two variants; is that the right thing to use here, too? > (..., plus 'tic6x-*-*' in this case?) OK to push the attached > "Adjust 'libgomp.c++/target-exceptions-pr118794-1.C' for > 'targetm.arm_eabi_unwinder' [PR118794]"? > (Could Arm/C6x maintainers please test this for me?) > I confirm that on arm-linux-gnueabihf, with your patch: PASS: libgomp.c++/target-exceptions-pr118794-1.C (test for excess errors) PASS: libgomp.c++/target-exceptions-pr118794-1.C execution test PASS: libgomp.c++/target-exceptions-pr118794-1.C scan-tree-dump-times optimized "gimple_call <__builtin_cxa_end_cleanup, " 1 and the two FAILs have disappeared. Thanks, Christophe > > Grüße > Thomas > > > > Used configuration : > > *CI config* tcwg_bootstrap_check master-arm-check_bootstrap > > *configure and test flags:* none, autodetected on > > armv8l-unknown-linux-gnueabihf > > > > We track this bug report under > > https://linaro.atlassian.net/browse/GNU-1562. Please let us know if you > > have a fix. > > > > If you have any questions regarding this report, please ask on > > linaro-toolch...@lists.linaro.org mailing list. > > > > -8<--8<--8<-- > > > > The information below contains the details of the failures, and the ways to > > reproduce a debug environment: > > > > You can find the failure logs in *.log.1.xz files in > > * > > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1236/artifact/artifacts/00-sumfiles/ > > The full lists of regressions and improvements as well as configure and > > make commands are in > > * > > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1236/artifact/artifacts/notify/ > > The list of [ignored] baseline and flaky failures are in > > * > > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1236/artifact/artifacts/sumfiles/xfails.xfail > > > > Current build : > > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1236/artifact/artifacts > > Reference build : > > https://ci.linaro.org/job/tcwg_bootstrap_check--master-arm-check_bootstrap-build/1235/artifact/artifacts > > > > Instruction to reproduce the build : > > https://git-us.linaro.org/toolchain/ci/interesting-commits.git/plain/gcc/sha1/aa3e72f943032e5f074b2bd2fd06d130dda8760b/tcwg_bootstrap_check/master-arm-check_bootstrap/reproduction_instructions.txt > > > > Full commit : > > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aa3e72f943032e5f074b2bd2fd06d130dda8760b > >
Regressions on master at commit r16-89 vs commit r16-87 on Linux/x86_64
Regressions on master at commit r16-89 vs commit r16-87 on Linux/x86_64 New failures: FAIL: gcc.dg/tree-ssa/pr92834.c scan-tree-dump-times optimized "MAX_EXPR <" 8 FAIL: gcc.dg/tree-ssa/pr92834.c scan-tree-dump-times optimized "MAX_EXPR <" 8 FAIL: gcc.dg/tree-ssa/pr94786.c scan-tree-dump-times optimized "MAX_EXPR <" 4 FAIL: gcc.dg/tree-ssa/pr94786.c scan-tree-dump-times optimized "MAX_EXPR <" 4 New passes: FAIL: gcc.target/i386/pr89618-2.c scan-tree-dump vect "loop vectorized using 16 byte vectors"
