Re: [PATCH] AIX Build failure with default -std=gnu23.
Dear Community,
Please let me know your comment.
Or is it more appropriate to have changes with header guard like this ?
--- a/libiberty/getopt.c
+++ b/libiberty/getopt.c
@@ -25,9 +25,11 @@
^L
/* This tells Alpha OSF/1 not to define a getopt prototype in .
Ditto for AIX 3.2 and . */
+#ifndef _AIX
#ifndef _NO_PROTO
# define _NO_PROTO
#endif
+#endif
#ifdef HAVE_CONFIG_H
# include
Thanks,
Sangamesh
On Thu, Nov 28, 2024 at 11:09 AM Sangamesh Mallayya <
swamy.sangam...@gmail.com> wrote:
> libiberty/getopt.c file is defining _NO_PROTO which causes conflicting
> declarations for the functions in AIX header files like stdio.h &
> stdlib.h.
> These declarations are being considered as errors in C23 which wasn't
> the case with C17.
>
> Here is the error we get.
>
> /gcc_build/./prev-gcc/xgcc -B/gcc_build/./prev-gcc/
> -B/home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/bin/ -B/home/sangam
> /install/GCC/powerpc-ibm-aix7.3.3.0/bin/
> -B/home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/lib/ -isystem
> /home/sangam/ins
> tall/GCC/powerpc-ibm-aix7.3.3.0/include -isystem
> /home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/sys-include -fno-check
> ing -c -DHAVE_CONFIG_H -g -O2 -fno-checking -I.
> -I/opt/freeware/src/packages/BUILD/gcc/libiberty/../include -W -Wall -W
> write-strings -Wc++-compat -Wstrict-prototypes -Wshadow=local -pedantic
> -D_GNU_SOURCE /opt/freeware/src/packages/BUILD/
> gcc/libiberty/getopt.c -o getopt.o
>
>
> In file included from
> /opt/freeware/src/packages/BUILD/gcc/libiberty/getopt.c:45:
> /gcc_build/prev-gcc/include-fixed/stdio.h:593:12: error: conflicting types
> for 'fgetpos64'; have 'int(FILE *, fpos64_t *)
> ' {aka 'int(FILE *, long long int *)'}
> 593 | extern int fgetpos64(FILE *, fpos64_t *);
> |^
> /gcc_build/prev-gcc/include-fixed/stdio.h:298:17: note: previous
> declaration of 'fgetpos64' with type 'int(void)'
> 298 | extern int fgetpos();
> | ^~~
> /gcc_build/prev-gcc/include-fixed/stdio.h:594:14: error: conflicting types
> for 'fopen64'; have 'FILE *(const char *, cons
> t char *)'
> 594 | extern FILE *fopen64(const char *, const char *);
> | ^~~
>
> /gcc_build/prev-gcc/include-fixed/stdio.h:259:17: note: previous
> declaration of 'fopen64' with type 'FILE *(void)'
> 259 | extern FILE * fopen();
> | ^
> /gcc_build/prev-gcc/include-fixed/stdio.h:595:14: error: conflicting types
> for 'freopen64'; have 'FILE *(const char *, co
> nst char *, FILE *)'
> 595 | extern FILE *freopen64(const char *, const char *, FILE *);
> | ^
> /gcc_build/prev-gcc/include-fixed/stdio.h:260:17: note: previous
> declaration of 'freopen64' with type 'FILE *(void)'
> 260 | extern FILE * freopen();
> | ^~~
> /gcc_build/prev-gcc/include-fixed/stdio.h:597:12: error: conflicting types
> for 'fsetpos64'; have 'int(FILE *, const fpos6
> 4_t *)' {aka 'int(FILE *, const long long int *)'}
> 597 | extern int fsetpos64(FILE *, const fpos64_t *);
> |^
> /gcc_build/prev-gcc/include-fixed/stdio.h:300:17: note: previous
> declaration of 'fsetpos64' with type 'int(void)'
> 300 | extern int fsetpos();
> | ^~~
> In file included from
> /opt/freeware/src/packages/BUILD/gcc/libiberty/getopt.c:216:
> /gcc_build/prev-gcc/include-fixed/stdlib.h: In function 'strtold':
> /gcc_build/prev-gcc/include-fixed/stdlib.h:233:30: error: too many
> arguments to function 'strtod'
>
>
> Compiled with this patch on RHEL8.10 ppc64le as well.
>
> ---
> libiberty/getopt.c | 6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/libiberty/getopt.c b/libiberty/getopt.c
> index 2f7086cc0c8..48736d4db41 100644
> --- a/libiberty/getopt.c
> +++ b/libiberty/getopt.c
> @@ -23,12 +23,6 @@
> Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA
> 02110-1301,
> USA. */
>
> -/* This tells Alpha OSF/1 not to define a getopt prototype in .
> - Ditto for AIX 3.2 and . */
> -#ifndef _NO_PROTO
> -# define _NO_PROTO
> -#endif
> -
> #ifdef HAVE_CONFIG_H
> # include
> #endif
> --
> 2.41.0
>
>
--
Thanks & Regards,
Sangamesh
Re: [PATCH] AIX Build failure with default -std=gnu23.
Dear Community,
Please let me know if the attached patch is fine.
Thanks,
Sangamesh
On Tue, Dec 3, 2024 at 11:19 PM swamy sangamesh
wrote:
> Hi Eric,
>
> Thanks for the review.
>
> I too think removing the define is a better approach and seems these won't
> be needed.
> From the comment it looks like that these were added long back and
> conflicting declarations were their until C23 standard uncovered it.
>
> If removing define is fine then i can send a final patch.
>
> Thanks,
> Sangamesh
>
>
>
>
>
> On Tue, Dec 3, 2024 at 9:11 AM Eric Gallager wrote:
>
>> On Mon, Dec 2, 2024 at 1:01 PM swamy sangamesh
>> wrote:
>> >
>> > Dear Community,
>> >
>> > Please let me know your comment.
>> > Or is it more appropriate to have changes with header guard like this ?
>> >
>>
>> I personally think it's better to just remove the define, but if
>> you're going to leave it in and guard it with a macro instead, I'd use
>> something a bit more specific than just "_AIX".
>>
>> > --- a/libiberty/getopt.c
>> > +++ b/libiberty/getopt.c
>> > @@ -25,9 +25,11 @@
>> > ^L
>> > /* This tells Alpha OSF/1 not to define a getopt prototype in
>> .
>> > Ditto for AIX 3.2 and . */
>> > +#ifndef _AIX
>> > #ifndef _NO_PROTO
>> > # define _NO_PROTO
>> > #endif
>> > +#endif
>> >
>> > #ifdef HAVE_CONFIG_H
>> > # include
>> >
>> >
>> > Thanks,
>> > Sangamesh
>> >
>> >
>> > On Thu, Nov 28, 2024 at 11:09 AM Sangamesh Mallayya <
>> swamy.sangam...@gmail.com> wrote:
>> >>
>> >> libiberty/getopt.c file is defining _NO_PROTO which causes conflicting
>> >> declarations for the functions in AIX header files like stdio.h &
>> stdlib.h.
>> >> These declarations are being considered as errors in C23 which wasn't
>> >> the case with C17.
>> >>
>> >> Here is the error we get.
>> >>
>> >> /gcc_build/./prev-gcc/xgcc -B/gcc_build/./prev-gcc/
>> -B/home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/bin/ -B/home/sangam
>> >> /install/GCC/powerpc-ibm-aix7.3.3.0/bin/
>> -B/home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/lib/ -isystem
>> /home/sangam/ins
>> >> tall/GCC/powerpc-ibm-aix7.3.3.0/include -isystem
>> /home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/sys-include -fno-check
>> >> ing -c -DHAVE_CONFIG_H -g -O2 -fno-checking -I.
>> -I/opt/freeware/src/packages/BUILD/gcc/libiberty/../include -W -Wall -W
>> >> write-strings -Wc++-compat -Wstrict-prototypes -Wshadow=local
>> -pedantic -D_GNU_SOURCE /opt/freeware/src/packages/BUILD/
>> >> gcc/libiberty/getopt.c -o getopt.o
>> >>
>> >>
>> >> In file included from
>> /opt/freeware/src/packages/BUILD/gcc/libiberty/getopt.c:45:
>> >> /gcc_build/prev-gcc/include-fixed/stdio.h:593:12: error: conflicting
>> types for 'fgetpos64'; have 'int(FILE *, fpos64_t *)
>> >> ' {aka 'int(FILE *, long long int *)'}
>> >> 593 | extern int fgetpos64(FILE *, fpos64_t *);
>> >> |^
>> >> /gcc_build/prev-gcc/include-fixed/stdio.h:298:17: note: previous
>> declaration of 'fgetpos64' with type 'int(void)'
>> >> 298 | extern int fgetpos();
>> >> | ^~~
>> >> /gcc_build/prev-gcc/include-fixed/stdio.h:594:14: error: conflicting
>> types for 'fopen64'; have 'FILE *(const char *, cons
>> >> t char *)'
>> >> 594 | extern FILE *fopen64(const char *, const char *);
>> >> | ^~~
>> >>
>> >> /gcc_build/prev-gcc/include-fixed/stdio.h:259:17: note: previous
>> declaration of 'fopen64' with type 'FILE *(void)'
>> >> 259 | extern FILE * fopen();
>> >> | ^
>> >> /gcc_build/prev-gcc/include-fixed/stdio.h:595:14: error: conflicting
>> types for 'freopen64'; have 'FILE *(const char *, co
>> >> nst char *, FILE *)'
>> >> 595 | extern FILE *freopen64(const char *, const char *, FILE *);
>> >> | ^
>> >> /gcc_build/prev-gcc/include-fixed/stdio.h:260:17: note: previous
>> declaration of 'freopen64' with type 'FILE *(void)'
>> >> 260 | ext
Re: [PATCH] AIX Build failure with default -std=gnu23.
Hi David, I don't have write privileges for GCC repo. I have raised a request for write access and provided your email address as approver. Please approve the request. Thanks, Sangamesh On Mon, Dec 9, 2024 at 3:17 AM David Edelsohn wrote: > This revised patch is okay. > > You are listed in the FSF copyrights file for GCC GDB GLIBC BINUTILS, but > do you have write privileges for the GCC repo? You are not listed in > gcc/MAINTAINERS for write-after-approval. > > Thanks, David > > On Sun, Dec 8, 2024 at 10:49 AM swamy sangamesh > wrote: > >> Thank you all for the review and comments. >> >> David, I have tested the changes against the latest master and ran >> default test cases. >> I have also built and ran the default test cases on RHEL9.0 ppc64le. >> Please let me know if any other testing needs to be covered. >> >> Please find the latest patch attached. >> >> >> >> On Sat, Dec 7, 2024 at 2:31 AM David Edelsohn wrote: >> >>> On Fri, Dec 6, 2024 at 2:17 PM Ian Lance Taylor wrote: >>> >>>> David Edelsohn writes: >>>> >>>> > On Fri, Dec 6, 2024 at 12:25 PM Rainer Orth < >>>> r...@cebitec.uni-bielefeld.de> >>>> > wrote: >>>> > >>>> >> Hi David, >>>> >> >>>> >> > No objection from me, but Ian is the maintainer of libiberty, so >>>> I'll >>>> >> defer >>>> >> > to him, especially about style and overall software engineering. >>>> >> > >>>> >> > The C23 change presumably will break on Alpha OSF/1 as well. Does >>>> GCC >>>> >> > still support OSF/1? It might be preferred to delete the block >>>> entirely >>>> >> > instead of #ifndef _AIX. >>>> >> >>>> >> GCC 4.7 was the last release to support Tru64 UNIX (ex-OSF/1). >>>> However, >>>> >> libiberty is also used outside of the toolchain, so that may affect >>>> the >>>> >> decision. >>>> >> >>>> >> However, IMO the Tru64 UNIX support can go for good now. >>>> >> >>>> > >>>> > Hi, Rainer >>>> > >>>> > Thanks for taking a look and commenting. >>>> > >>>> > It seems we both agree that it would be better to remove the entire >>>> block >>>> > defining _NO_PROTO because both of the systems are no longer >>>> supported. >>>> > >>>> > I'll give Ian the opportunity to comment. >>>> >>>> Looks good to me. Thanks. >>>> >>>> Ian >>>> >>> >>> Sangamesh, >>> >>> Can you respin and test a revised patch that removes the conditional >>> _NO_PROTO definition instead of adding #ifndef _AIX? I think that is what >>> Rainer and I would prefer because neither of the OSes is supported and we >>> don't need a fragile work-around. >>> >>> Thanks, David >>> >>> >> >> -- >> Thanks & Regards, >> Sangamesh >> > -- Thanks & Regards, Sangamesh
Re: [PATCH] AIX Build failure with default -std=gnu23.
Thank you all for the review and comments. David, I have tested the changes against the latest master and ran default test cases. I have also built and ran the default test cases on RHEL9.0 ppc64le. Please let me know if any other testing needs to be covered. Please find the latest patch attached. On Sat, Dec 7, 2024 at 2:31 AM David Edelsohn wrote: > On Fri, Dec 6, 2024 at 2:17 PM Ian Lance Taylor wrote: > >> David Edelsohn writes: >> >> > On Fri, Dec 6, 2024 at 12:25 PM Rainer Orth < >> r...@cebitec.uni-bielefeld.de> >> > wrote: >> > >> >> Hi David, >> >> >> >> > No objection from me, but Ian is the maintainer of libiberty, so I'll >> >> defer >> >> > to him, especially about style and overall software engineering. >> >> > >> >> > The C23 change presumably will break on Alpha OSF/1 as well. Does >> GCC >> >> > still support OSF/1? It might be preferred to delete the block >> entirely >> >> > instead of #ifndef _AIX. >> >> >> >> GCC 4.7 was the last release to support Tru64 UNIX (ex-OSF/1). >> However, >> >> libiberty is also used outside of the toolchain, so that may affect the >> >> decision. >> >> >> >> However, IMO the Tru64 UNIX support can go for good now. >> >> >> > >> > Hi, Rainer >> > >> > Thanks for taking a look and commenting. >> > >> > It seems we both agree that it would be better to remove the entire >> block >> > defining _NO_PROTO because both of the systems are no longer supported. >> > >> > I'll give Ian the opportunity to comment. >> >> Looks good to me. Thanks. >> >> Ian >> > > Sangamesh, > > Can you respin and test a revised patch that removes the conditional > _NO_PROTO definition instead of adding #ifndef _AIX? I think that is what > Rainer and I would prefer because neither of the OSes is supported and we > don't need a fragile work-around. > > Thanks, David > > -- Thanks & Regards, Sangamesh 0001-aix-Resolve-build-failure-with-default-C23.patch Description: Binary data
Re: [PATCH] AIX Build failure with default -std=gnu23.
Thank you everyone. I have pushed the changes. Thanks, Sangamesh On Mon, Dec 9, 2024 at 12:48 PM swamy sangamesh wrote: > Hi David, > > I don't have write privileges for GCC repo. > I have raised a request for write access and provided your email address > as approver. > Please approve the request. > > Thanks, > Sangamesh > > > On Mon, Dec 9, 2024 at 3:17 AM David Edelsohn wrote: > >> This revised patch is okay. >> >> You are listed in the FSF copyrights file for GCC GDB GLIBC BINUTILS, but >> do you have write privileges for the GCC repo? You are not listed in >> gcc/MAINTAINERS for write-after-approval. >> >> Thanks, David >> >> On Sun, Dec 8, 2024 at 10:49 AM swamy sangamesh < >> swamy.sangam...@gmail.com> wrote: >> >>> Thank you all for the review and comments. >>> >>> David, I have tested the changes against the latest master and ran >>> default test cases. >>> I have also built and ran the default test cases on RHEL9.0 ppc64le. >>> Please let me know if any other testing needs to be covered. >>> >>> Please find the latest patch attached. >>> >>> >>> >>> On Sat, Dec 7, 2024 at 2:31 AM David Edelsohn wrote: >>> >>>> On Fri, Dec 6, 2024 at 2:17 PM Ian Lance Taylor wrote: >>>> >>>>> David Edelsohn writes: >>>>> >>>>> > On Fri, Dec 6, 2024 at 12:25 PM Rainer Orth < >>>>> r...@cebitec.uni-bielefeld.de> >>>>> > wrote: >>>>> > >>>>> >> Hi David, >>>>> >> >>>>> >> > No objection from me, but Ian is the maintainer of libiberty, so >>>>> I'll >>>>> >> defer >>>>> >> > to him, especially about style and overall software engineering. >>>>> >> > >>>>> >> > The C23 change presumably will break on Alpha OSF/1 as well. >>>>> Does GCC >>>>> >> > still support OSF/1? It might be preferred to delete the block >>>>> entirely >>>>> >> > instead of #ifndef _AIX. >>>>> >> >>>>> >> GCC 4.7 was the last release to support Tru64 UNIX (ex-OSF/1). >>>>> However, >>>>> >> libiberty is also used outside of the toolchain, so that may affect >>>>> the >>>>> >> decision. >>>>> >> >>>>> >> However, IMO the Tru64 UNIX support can go for good now. >>>>> >> >>>>> > >>>>> > Hi, Rainer >>>>> > >>>>> > Thanks for taking a look and commenting. >>>>> > >>>>> > It seems we both agree that it would be better to remove the entire >>>>> block >>>>> > defining _NO_PROTO because both of the systems are no longer >>>>> supported. >>>>> > >>>>> > I'll give Ian the opportunity to comment. >>>>> >>>>> Looks good to me. Thanks. >>>>> >>>>> Ian >>>>> >>>> >>>> Sangamesh, >>>> >>>> Can you respin and test a revised patch that removes the conditional >>>> _NO_PROTO definition instead of adding #ifndef _AIX? I think that is what >>>> Rainer and I would prefer because neither of the OSes is supported and we >>>> don't need a fragile work-around. >>>> >>>> Thanks, David >>>> >>>> >>> >>> -- >>> Thanks & Regards, >>> Sangamesh >>> >> > > -- > Thanks & Regards, > Sangamesh > -- Thanks & Regards, Sangamesh
Re: [PATCH] AIX Build failure with default -std=gnu23.
Hi Eric,
Thanks for the review.
I too think removing the define is a better approach and seems these won't
be needed.
>From the comment it looks like that these were added long back and
conflicting declarations were their until C23 standard uncovered it.
If removing define is fine then i can send a final patch.
Thanks,
Sangamesh
On Tue, Dec 3, 2024 at 9:11 AM Eric Gallager wrote:
> On Mon, Dec 2, 2024 at 1:01 PM swamy sangamesh
> wrote:
> >
> > Dear Community,
> >
> > Please let me know your comment.
> > Or is it more appropriate to have changes with header guard like this ?
> >
>
> I personally think it's better to just remove the define, but if
> you're going to leave it in and guard it with a macro instead, I'd use
> something a bit more specific than just "_AIX".
>
> > --- a/libiberty/getopt.c
> > +++ b/libiberty/getopt.c
> > @@ -25,9 +25,11 @@
> > ^L
> > /* This tells Alpha OSF/1 not to define a getopt prototype in .
> > Ditto for AIX 3.2 and . */
> > +#ifndef _AIX
> > #ifndef _NO_PROTO
> > # define _NO_PROTO
> > #endif
> > +#endif
> >
> > #ifdef HAVE_CONFIG_H
> > # include
> >
> >
> > Thanks,
> > Sangamesh
> >
> >
> > On Thu, Nov 28, 2024 at 11:09 AM Sangamesh Mallayya <
> swamy.sangam...@gmail.com> wrote:
> >>
> >> libiberty/getopt.c file is defining _NO_PROTO which causes conflicting
> >> declarations for the functions in AIX header files like stdio.h &
> stdlib.h.
> >> These declarations are being considered as errors in C23 which wasn't
> >> the case with C17.
> >>
> >> Here is the error we get.
> >>
> >> /gcc_build/./prev-gcc/xgcc -B/gcc_build/./prev-gcc/
> -B/home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/bin/ -B/home/sangam
> >> /install/GCC/powerpc-ibm-aix7.3.3.0/bin/
> -B/home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/lib/ -isystem
> /home/sangam/ins
> >> tall/GCC/powerpc-ibm-aix7.3.3.0/include -isystem
> /home/sangam/install/GCC/powerpc-ibm-aix7.3.3.0/sys-include -fno-check
> >> ing -c -DHAVE_CONFIG_H -g -O2 -fno-checking -I.
> -I/opt/freeware/src/packages/BUILD/gcc/libiberty/../include -W -Wall -W
> >> write-strings -Wc++-compat -Wstrict-prototypes -Wshadow=local
> -pedantic -D_GNU_SOURCE /opt/freeware/src/packages/BUILD/
> >> gcc/libiberty/getopt.c -o getopt.o
> >>
> >>
> >> In file included from
> /opt/freeware/src/packages/BUILD/gcc/libiberty/getopt.c:45:
> >> /gcc_build/prev-gcc/include-fixed/stdio.h:593:12: error: conflicting
> types for 'fgetpos64'; have 'int(FILE *, fpos64_t *)
> >> ' {aka 'int(FILE *, long long int *)'}
> >> 593 | extern int fgetpos64(FILE *, fpos64_t *);
> >> |^
> >> /gcc_build/prev-gcc/include-fixed/stdio.h:298:17: note: previous
> declaration of 'fgetpos64' with type 'int(void)'
> >> 298 | extern int fgetpos();
> >> | ^~~
> >> /gcc_build/prev-gcc/include-fixed/stdio.h:594:14: error: conflicting
> types for 'fopen64'; have 'FILE *(const char *, cons
> >> t char *)'
> >> 594 | extern FILE *fopen64(const char *, const char *);
> >> | ^~~
> >>
> >> /gcc_build/prev-gcc/include-fixed/stdio.h:259:17: note: previous
> declaration of 'fopen64' with type 'FILE *(void)'
> >> 259 | extern FILE * fopen();
> >> | ^
> >> /gcc_build/prev-gcc/include-fixed/stdio.h:595:14: error: conflicting
> types for 'freopen64'; have 'FILE *(const char *, co
> >> nst char *, FILE *)'
> >> 595 | extern FILE *freopen64(const char *, const char *, FILE *);
> >> | ^
> >> /gcc_build/prev-gcc/include-fixed/stdio.h:260:17: note: previous
> declaration of 'freopen64' with type 'FILE *(void)'
> >> 260 | extern FILE * freopen();
> >> | ^~~
> >> /gcc_build/prev-gcc/include-fixed/stdio.h:597:12: error: conflicting
> types for 'fsetpos64'; have 'int(FILE *, const fpos6
> >> 4_t *)' {aka 'int(FILE *, const long long int *)'}
> >> 597 | extern int fsetpos64(FILE *, const fpos64_t *);
> >> |^
> >> /gcc_build/prev-gcc/include-fixed/stdio.h:300:17: note: previous
> declaration of 'fsetpos64' with type 'int(void)'
> >
