Re: [PATCH 07/15] xtensa: Fix non-robust split condition in define_insn_and_split

2021-11-19 Thread augustine.sterling--- via Gcc-patches 
On Thu, Nov 11, 2021 at 3:25 AM Kewen Lin  wrote:
> gcc/ChangeLog:
>
> * config/xtensa/xtensa.md (movdi_internal, movdf_internal): Fix split
> condition.

I had been hoping Max would reply (as I'm just doing legacy work
around this these days), but seeing that he hasn't. This is approved.

Re: [PATCH] xtensa: fix PR target/94584

2020-04-14 Thread augustine.sterling--- via Gcc-patches 
On Mon, Apr 13, 2020 at 4:39 PM Max Filippov  wrote:
> 2020-04-13  Max Filippov  
> gcc/
> * config/xtensa/xtensa.md (zero_extendhisi2, zero_extendqisi2)
> (extendhisi2_internal): Add %v1 before the load instructions.
>
> gcc/testsuite/
> * gcc.target/xtensa/pr94584.c: New test.

Approved. Surprised this hasn't been caught before.

Re: [PATCH] gcc: xtensa: delegitimize UNSPEC_PLT

2020-05-27 Thread augustine.sterling--- via Gcc-patches 
On Tue, May 26, 2020 at 11:43 AM Max Filippov  wrote:
>
> This fixes 'non-delegitimized UNSPEC 3 found in variable location' notes
> issued when building libraries which interferes with running tests.
>
> 2020-05-24  Max Filippov  
> gcc/
> * config/xtensa/xtensa.c (xtensa_delegitimize_address): New
> function.
> (TARGET_DELEGITIMIZE_ADDRESS): New macro.

This is OK.