PING: [PATCH, ARM] New CPU support for Marvell PJ4 cores
This patch is pending for a long time. Any progress? Cheers, Yi-Hsiu, Hsu -Original Message- From: Yi-Hsiu Hsu Sent: Tuesday, June 26, 2012 1:51 PM To: 'Chung-Lin Tang' Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org Subject: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores Hi Chung-Lin, I think tune_marvell attribute better be kept for future Marvell cores extension. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Chung-Lin Tang [mailto:clt...@codesourcery.com] Sent: Tuesday, June 26, 2012 12:12 PM To: Yi-Hsiu Hsu Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 2012/6/26 09:37 AM, Yi-Hsiu Hsu wrote: > Updated changelog. > > * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. > * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. > * config/arm/arm.md (tune_marvell): Add marvell_pj4. > * config/arm/arm-cores.def: Add core marvell-pj4. > * config/arm/arm-tune.md: Regenerated. > * config/arm/arm-tables.opt: Regenerated. > * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. > * doc/invoke.texi: Added entry for marvell-pj4. Another nit, I think the tune_marvell attribute now looks a bit unneeded. You can just fold it into the "tune" clause of "generic_sched". Thanks, Chung-Lin
RE: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Hi Ramana, Attached is the patch for marvell-pj4.md to fix the simple_alu_shift category. Thanks for your kindly help. Cheers, Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramra...@arm.com] Sent: Friday, January 18, 2013 10:28 PM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org ; Subject: Re: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 06/20/12 03:53, Yi-Hsiu Hsu wrote: > marvell-pj4 is added to BE8_LINK_SPEC. Sorry about the time it's taken to finish this patch up. I seem to have missed this one in the review process. I've now applied the attached patch after taking into account the recent attribute changes and treated alu_reg and simple_alu_imm as you have treated alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. Additionally I've removed tune_marvell as that seems redundant at this point of time - an additional attribute and testing that appears to be unnecessary instead of just one more inequality test. The only part I'm not sure about is how to treat the simple_alu_shift category here , so a patch to handle them in the pj4 pipeline description would be welcome. Thanks Ramana 2013-01-18 Yi-Hsiu Hsu Ramana Radhakrishnan * config/arm/marvell-pj4.md: New file. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (generic_sched): Add marvell_pj4. (generic_vfp): Likewise. * config/arm/arm-cores.def: Add marvell-pj4. * config/arm/arm-tune.md: Regenerate. * config/arm/arm-tables.opt: Regenerate. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Document marvell-pj4. > > Modified patch is attached. > > Thanks! > > B.R. > Yi-Hsiu, Hsu > > -Original Message- > From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] > Sent: Thursday, June 14, 2012 2:19 AM > To: Yi-Hsiu Hsu > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores > > On 29 May 2012 10:07, Yi-Hsiu Hsu wrote: >> Hi, >> >> This patch maintains Marvell PJ4 cores pipeline description. >> Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. >> >> * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. >> * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. >> * config/arm/arm-cores.def: Add core marvell-pj4. >> * config/arm/arm-tune.md: Regenerated. >> * config/arm/arm-tables.opt: Regenerated. >> * doc/invoke.texi: Added entry for marvell-pj4. > > This command line option should also be added to BE8_LINK_SPEC similar > to what's done for the other v7-a cores. > > Ok with that change. > > regards, > Ramana > > > >> >> >> Thanks! >> >> P.S. I create the patch from revision 187308, but this revision is unable to >> build successfully, then I apply this patch to revision 187623 and >> successfully build and pass the testsuite. >> pj4.patch Description: pj4.patch
RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Hi Ramana, Sorry for missing the Changelog, I will add it for future patches. Thanks for your kindly help. Cheers, Compiler Team @ MTL Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramra...@arm.com] Sent: Monday, January 21, 2013 6:56 PM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores Hi Yi-Hsiu Hsu, On 01/21/13 08:51, Yi-Hsiu Hsu wrote: > Hi Ramana, > > Attached is the patch for marvell-pj4.md to fix the simple_alu_shift category. > Thanks for your kindly help. In the future please submit patches with a Changelog entry. I've created one for this patch as it needed a bit of splitting up given the mis-commit earlier by doko. So in this case I've now committed the following with the following Changelog entry. Regards, Ramana 2013-01-21 Yi-Hsiu Hsu * config/arm/marvell-pj4.md (pj4_shift_conds, pj4_alu_shift, pj4_alu_shift_conds, pj4_shift): Handle simple_alu_shift. > > Cheers, > Yi-Hsiu, Hsu > > -Original Message- > From: Ramana Radhakrishnan [mailto:ramra...@arm.com] > Sent: Friday, January 18, 2013 10:28 PM > To: Yi-Hsiu Hsu > Cc: gcc-patches@gcc.gnu.org ; > Subject: Re: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores > > On 06/20/12 03:53, Yi-Hsiu Hsu wrote: >> marvell-pj4 is added to BE8_LINK_SPEC. > > Sorry about the time it's taken to finish this patch up. I seem to have > missed this one in the review process. > > I've now applied the attached patch after taking into account the recent > attribute changes and treated alu_reg and simple_alu_imm as you have treated > alu, rebased to trunk to fix up some small issues with BE8_LINK_SPECS. > > Additionally I've removed tune_marvell as that seems redundant at this point > of time - an additional attribute and testing that appears to be unnecessary > instead of just one more inequality test. > > The only part I'm not sure about is how to treat the simple_alu_shift > category here , so a patch to handle them in the pj4 pipeline description > would be welcome. > > > Thanks > Ramana > > 2013-01-18 Yi-Hsiu Hsu > Ramana Radhakrishnan > > * config/arm/marvell-pj4.md: New file. > * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. > * config/arm/arm.md (generic_sched): Add marvell_pj4. > (generic_vfp): Likewise. > * config/arm/arm-cores.def: Add marvell-pj4. > * config/arm/arm-tune.md: Regenerate. > * config/arm/arm-tables.opt: Regenerate. > * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. > * doc/invoke.texi: Document marvell-pj4. > >> >> Modified patch is attached. >> >> Thanks! >> >> B.R. >> Yi-Hsiu, Hsu >> >> -Original Message- >> From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] >> Sent: Thursday, June 14, 2012 2:19 AM >> To: Yi-Hsiu Hsu >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores >> >> On 29 May 2012 10:07, Yi-Hsiu Hsu wrote: >>> Hi, >>> >>> This patch maintains Marvell PJ4 cores pipeline description. >>> Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. >>> >>> * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. >>> * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. >>> * config/arm/arm-cores.def: Add core marvell-pj4. >>> * config/arm/arm-tune.md: Regenerated. >>> * config/arm/arm-tables.opt: Regenerated. >>> * doc/invoke.texi: Added entry for marvell-pj4. >> >> This command line option should also be added to BE8_LINK_SPEC >> similar to what's done for the other v7-a cores. >> >> Ok with that change. >> >> regards, >> Ramana >> >> >> >>> >>> >>> Thanks! >>> >>> P.S. I create the patch from revision 187308, but this revision is unable >>> to build successfully, then I apply this patch to revision 187623 and >>> successfully build and pass the testsuite. >>> =
PING: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Ping!! Cheers, Yi-Hsiu, Hsu -Original Message- From: Yi-Hsiu Hsu Sent: Tuesday, June 26, 2012 1:51 PM To: 'Chung-Lin Tang' Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org Subject: RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores Hi Chung-Lin, I think tune_marvell attribute better be kept for future Marvell cores extension. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Chung-Lin Tang [mailto:clt...@codesourcery.com] Sent: Tuesday, June 26, 2012 12:12 PM To: Yi-Hsiu Hsu Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 2012/6/26 09:37 AM, Yi-Hsiu Hsu wrote: > Updated changelog. > > * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. > * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. > * config/arm/arm.md (tune_marvell): Add marvell_pj4. > * config/arm/arm-cores.def: Add core marvell-pj4. > * config/arm/arm-tune.md: Regenerated. > * config/arm/arm-tables.opt: Regenerated. > * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. > * doc/invoke.texi: Added entry for marvell-pj4. Another nit, I think the tune_marvell attribute now looks a bit unneeded. You can just fold it into the "tune" clause of "generic_sched". Thanks, Chung-Lin
RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
marvell-pj4 is added to BE8_LINK_SPEC. Modified patch is attached. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Thursday, June 14, 2012 2:19 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 29 May 2012 10:07, Yi-Hsiu Hsu wrote: > Hi, > > This patch maintains Marvell PJ4 cores pipeline description. > Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. > > * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. > * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. > * config/arm/arm-cores.def: Add core marvell-pj4. > * config/arm/arm-tune.md: Regenerated. > * config/arm/arm-tables.opt: Regenerated. > * doc/invoke.texi: Added entry for marvell-pj4. This command line option should also be added to BE8_LINK_SPEC similar to what's done for the other v7-a cores. Ok with that change. regards, Ramana > > > Thanks! > > P.S. I create the patch from revision 187308, but this revision is unable to > build successfully, then I apply this patch to revision 187623 and > successfully build and pass the testsuite. > marvell-pj4-core.patch Description: marvell-pj4-core.patch
RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Updated changelog. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm.md (tune_marvell): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. * doc/invoke.texi: Added entry for marvell-pj4. B.R. Yi-Hsiu, Hsu -Original Message- From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] Sent: Tuesday, June 26, 2012 3:36 AM To: Yi-Hsiu Hsu Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 20 June 2012 03:53, Yi-Hsiu Hsu wrote: > marvell-pj4 is added to BE8_LINK_SPEC. > > Modified patch is attached. Missing a modified changelog entry. Ramana > > Thanks! > > B.R. > Yi-Hsiu, Hsu > > -Original Message- > From: Ramana Radhakrishnan [mailto:ramana.radhakrish...@linaro.org] > Sent: Thursday, June 14, 2012 2:19 AM > To: Yi-Hsiu Hsu > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores > > On 29 May 2012 10:07, Yi-Hsiu Hsu wrote: >> Hi, >> >> This patch maintains Marvell PJ4 cores pipeline description. >> Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. >> >> * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. >> * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. >> * config/arm/arm-cores.def: Add core marvell-pj4. >> * config/arm/arm-tune.md: Regenerated. >> * config/arm/arm-tables.opt: Regenerated. >> * doc/invoke.texi: Added entry for marvell-pj4. > > This command line option should also be added to BE8_LINK_SPEC similar > to what's done for the other v7-a cores. > > Ok with that change. > > regards, > Ramana > > > >> >> >> Thanks! >> >> P.S. I create the patch from revision 187308, but this revision is unable to >> build successfully, then I apply this patch to revision 187623 and >> successfully build and pass the testsuite. >>
RE: [PATCH, ARM] New CPU support for Marvell PJ4 cores
Hi Chung-Lin, I think tune_marvell attribute better be kept for future Marvell cores extension. Thanks! B.R. Yi-Hsiu, Hsu -Original Message- From: Chung-Lin Tang [mailto:clt...@codesourcery.com] Sent: Tuesday, June 26, 2012 12:12 PM To: Yi-Hsiu Hsu Cc: Ramana Radhakrishnan; gcc-patches@gcc.gnu.org Subject: Re: [PATCH, ARM] New CPU support for Marvell PJ4 cores On 2012/6/26 09:37 AM, Yi-Hsiu Hsu wrote: > Updated changelog. > > * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. > * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. > * config/arm/arm.md (tune_marvell): Add marvell_pj4. > * config/arm/arm-cores.def: Add core marvell-pj4. > * config/arm/arm-tune.md: Regenerated. > * config/arm/arm-tables.opt: Regenerated. > * config/arm/bpabi.h (BE8_LINK_SPEC): Add marvell_pj4. > * doc/invoke.texi: Added entry for marvell-pj4. Another nit, I think the tune_marvell attribute now looks a bit unneeded. You can just fold it into the "tune" clause of "generic_sched". Thanks, Chung-Lin
[PATCH, ARM] New CPU support for Marvell PJ4 cores
Hi, This patch maintains Marvell PJ4 cores pipeline description. Run arm testsuite on arm-linux-gnueabi and no extra regressions are found. * config/arm/marvell-pj4.md: New marvell-pj4 pipeline description. * config/arm/arm.c (arm_issue_rate): Add marvell_pj4. * config/arm/arm-cores.def: Add core marvell-pj4. * config/arm/arm-tune.md: Regenerated. * config/arm/arm-tables.opt: Regenerated. * doc/invoke.texi: Added entry for marvell-pj4. Thanks! P.S. I create the patch from revision 187308, but this revision is unable to build successfully, then I apply this patch to revision 187623 and successfully build and pass the testsuite. marvell-pj4_cores.tgz Description: marvell-pj4_cores.tgz
