[doc] Fix typo in gty.texi
Hi Richard, Could you review this patch, too? http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01003.html Thanks! Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj
Re: [doc] Fix typo in gty.texi
Hi Richard, > +representation. So the CFG simultaneously consist of basic blocks > +containing RTL and GIMPLE trees. > > That last sentence is not correct, please remove it. Ok with that change. May I ask why the last sentence is not correct? (just want to know why) The comment of gimple_expand_cfg (gcc/cfgexpand.c) says, ... snip ... We do conversion per basic block and preserve/update the tree CFG. This implies we have to do some magic as the CFG can simultaneously consist of basic blocks containing RTL and GIMPLE trees. This can ... snip ... I guess I misunderstand what the comment says, but what "This implies we have to do some magic as the CFG can simultaneously consist of basic blocks containing RTL and GIMPLE trees." actually means? Would you like explain more? Thanks! Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj
Re: [doc] Fix typo in gty.texi
> During the expansion itself we have a mix of basic-blocks that are in RTL
> and GIMPLE form. After expansion the CFG only contains RTL. The
> sentence as-is is at least misleading, suggesting that after expansion
> we have both RTL and GIMPLE in the CFG.
>
> So, on a second thought a more appropriate patch would be to just
> remove the whole note:
>
> Note that at present, the representation of control flow in the
> -@code{tree} representation is discarded before expanding to RTL@.
> -Long term the CFG should be maintained and ``expanded'' to the
> -RTL representation along with the function @code{tree} itself.
>
> that's an implementation detail that is no longer true but saying it is
> no longer true doesn't contain any useful information.
Thanks for the explaination. :)
I note that current svn head already removed the whole paragraph
above (so please ignore my patch), and add a new paragraph at the
beginning.
---
In GCC, the representation of control flow is maintained throughout
the compilation process, from constructing the CFG early in
@code{pass_build_cfg} to @code{pass_free_cfg} (see @file{passes.c}).
The CFG takes various different modes and may undergo extensive
manipulations, but the graph is always valid between its construction
and its release. This way, transfer of information such as data flow,
a measured profile, or the loop tree, can be propagated through the
passes pipeline, and even from @code{GIMPLE} to @code{RTL}.
---
I think this is much clear than before. The word "modes" in "CFG takes
various different modes" means different forms, GIMPLE or RTL, right?
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj
Re: [doc] Fix typo in gty.texi
On Fri, Aug 24, 2012 at 10:05:06AM -0400, Diego Novillo wrote: > On 2012-08-23 06:55 , 陳韋任 (Wei-Ren Chen) wrote: > > >I think this is much clear than before. The word "modes" in "CFG takes > > various different modes" means different forms, GIMPLE or RTL, right? > > Right. Thanks. :) Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj
[PATCH] Docs: lto.texi: Fix typo
Fix typo. The first "are" in the statement should be "and".
Signed-off-by: Chen Wei-Ren
---
gcc/doc/lto.texi |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gcc/doc/lto.texi b/gcc/doc/lto.texi
index 73fd831..68f8759 100644
--- a/gcc/doc/lto.texi
+++ b/gcc/doc/lto.texi
@@ -455,7 +455,7 @@ alone. The problem is that propagation of inter-procedural
information does not work well across functions and variables
that are called or referenced by other compilation units (such as
from a dynamically linked library). We say that such functions
-are variables are @emph{externally visible}.
+and variables are @emph{externally visible}.
To make the situation even more difficult, many applications
organize themselves as a set of shared libraries, and the default
--
1.7.3.4
Re: [PATCH] Docs: lto.texi: Fix typo
On Thu, Sep 20, 2012 at 09:49:27AM +0100, rearn...@arm.com wrote: > On 20 Sep 2012, at 09:27, "陳韋任 (Wei-Ren Chen)" > wrote: > > > Fix typo. The first "are" in the statement should be "and". > > > > Ok. > > R. Thanks. Would you like to commit this for me? :) Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj
