Re: PING^2: [PATCH] Add --enable-first-stage-cross configure option
Jeff Law via Gcc-patches writes: > I'm not really sure we need a patch for this. Isn't it sufficient to > "make all-gcc && make all-target-libgcc"? Folks have been doing that > for decades. > > Jeff Oh, I did not know that "make install-gcc install-target-libgcc" works in this case. So in the end, patch simplifies quirky first stage cross tool build procedure from configure --target=$target --enable-languages=c --disable-threads --disable-shared # plus --with-newlib when --with-sysroot= make all-gcc all-target-libgcc make install-gcc install-target-libgcc to configure --target=$target --enable-first-stage-cross make make install Either way is more or less okay for me, it just needs to be documented.
Re: [PATCH 0/4] drop version checks for in-tree gas [PR91602]
Jeff Law writes:
> On 7/20/2021 9:44 AM, Serge Belyshev wrote:
>> Special-casing checks for in-tree gas features is unnecessary since
>> r17 which made configure-gcc depend on all-gas, and thus making
>> alternate code path in gcc_GAS_CHECK_FEATURE for in-tree gas
>> redundant.
>>
>> Along the way this fixes PR 91602, which is caused by incorrect guess
>> of leb128 support presense in RISC-V.
>>
>> First patch removes alternate code path in gcc_GAS_CHECK_FEATURE and
>> related code, the rest are further cleanups. Patches 2 and 3 in
>> series make no functional changes, thus configure is unchanged.
>>
>> Bootstrapped/regtested on x86_64-pc-linux-gnu, riscv64-unknown-linux-gnu,
>> sparc-sun-solaris2.11 and powerpc-ibm-aix7.{1.5.0,2.4.0}, with and without
>> in-tree binutils (except on aix where combined tree does not appear to work
>> due to dynamic linker peculiarity).
>>
>> OK for mainline ?
>>
>> Serge Belyshev (4):
>>configure: drop version checks for in-tree gas [PR91602]
>>configure: remove version argument from gcc_GAS_CHECK_FEATURE
>>configure: fixup formatting from previous change
>>configure: remove gas versions from tls check
> So just be clear, the point here is to stop checking the version # and
> instead always do a real feature check by testing the behavior of the
> assembler, even an in-tree assembler, right?
That is correct, yes.
Re: [PATCH 0/4] drop version checks for in-tree gas [PR91602]
Jeff Law writes: > This set is approved. Push them to the trunk when it's convenient > for you. > > Thanks for your patience, Thanks! Committed as r12-3047 .. r12-3050.
Re: [PATCH v3] gcc_update: use human readable name for revision string in gcc/REVISION
Ping?
[PATCH v3] gcc_update: use human readable name for revision string in
gcc/REVISION
https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575556.html
>
> OK for mainline?
>
> ---
> contrib/Changelog:
>
> * gcc_update: derive human readable name for HEAD using git describe
> like "git gcc-descr" with short commit hash. Drop "revision" from
> gcc/REVISION.
> ---
> contrib/gcc_update | 19 +--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/gcc_update b/contrib/gcc_update
> index 80fac9fc995..ce472545e25 100755
> --- a/contrib/gcc_update
> +++ b/contrib/gcc_update
> @@ -332,7 +332,22 @@ case $vcs_type in
> exit 1
> fi
>
> - revision=`$GCC_GIT log -n1 --pretty=tformat:%p:%t:%H`
> + # Open-coded version of "git gcc-descr" from
> contrib/gcc-git-customization.sh
> + revision=`$GCC_GIT log -n1 --pretty=tformat:%h`
> + r=`$GCC_GIT describe --all --match 'basepoints/gcc-[0-9]*' HEAD \
> +| sed -n
> 's,^\(tags/\)\?basepoints/gcc-\([0-9]\+\)-\([0-9]\+\)-g[0-9a-f]*$,r\2-\3,p;s,^\(tags/\)\?basepoints/gcc-\([0-9]\+\)$,r\2-0,p'`;
> + if test -n $r; then
> + o=`$GCC_GIT config --get gcc-config.upstream`;
> + rr=`echo $r | sed -n
> 's,^r\([0-9]\+\)-[0-9]\+\(-g[0-9a-f]\+\)\?$,\1,p'`;
> + if $GCC_GIT rev-parse --verify --quiet
> ${o:-origin}/releases/gcc-$rr >/dev/null; then
> + m=releases/gcc-$rr;
> + else
> + m=master;
> + fi;
> + if $GCC_GIT merge-base --is-ancestor HEAD ${o:-origin}/$m; then
> + revision=${r}-g${revision};
> + fi
> + fi
> branch=`$GCC_GIT name-rev --name-only HEAD || :`
> ;;
>
> @@ -414,6 +429,6 @@ rm -f LAST_UPDATED gcc/REVISION
> date
> echo "`TZ=UTC date` (revision $revision)"
> } > LAST_UPDATED
> -echo "[$branch revision $revision]" > gcc/REVISION
> +echo "[$branch $revision]" > gcc/REVISION
>
> touch_files_reexec
[COMMITTED] MAINTAINERS: Add myself for write after approval
2021-05-17 Serge Belyshev * MAINTAINERS (Write After Approval): Add myself. --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b10f212ce8..fbaa183cea4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -317,6 +317,7 @@ Gergö Barany Charles Baylis Tejas Belagod Matthew Beliveau +Serge Belyshev Jon Beniston Andrew Bennett Andrew Benson
PING^3: [PATCH] Add --enable-first-stage-cross configure option
Final ping before stage3 ends: [PATCH] Add --enable-first-stage-cross configure option https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575318.html
