Re: [PATCH, ADA] Fix current build problems under cygwin
Eric, > OK if Pascal has no objections to the patch: > https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00671.html Looks fine to me and should have no effect for our non Cygwin builds. -- Pascal Obry gpg --keyserver keys.gnupg.net --recv-key F949BD3B
Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]
Le 06/04/2012 17:27, Pascal Obry a écrit : > > Back on this! It turn out that this breaks the shared Ada runtime. > Indeed, exported variables on Ada packages in a DLLs are only accessible > when linking against DLL (thanks to runtime pseudo reloc). > > With the patch applied it is not possible to build any Ada application > using the shared runtime. This is a very serious problem, the patch > should be reverted. > > Sorry for not having remembered before about this and why linking > against DLL was so important! > PING? -- Pascal Obry -- gpg --keyserver keys.gnupg.net --recv-key F949BD3B
Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]
Arno, > Pascal, I'd suggest you go ahead and revert this patch. This patch has already been reverted by Eric on Apr 10 on gcc-4.7 branch. -- Pascal Obry -- gpg --keyserver keys.gnupg.net --recv-key F949BD3B
Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]
Arno, >> This patch has already been reverted by Eric on Apr 10 on gcc-4.7 branch. > > I'm talking about the FSF trunk repository. Ah ok, but I do not have commit access to this repository. Eric maybe? -- Pascal Obry -- gpg --keyserver keys.gnupg.net --recv-key F949BD3B
Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]
Arno, The ChangeLog: Revert commit r184558 as breaking Ada runtime. The pseudo reloc feature works only when linking against DLL. Remove this pacth as it install the import libraries for the shared Ada runtime. This breaks any Ada program using the Ada shared runtime. With this ChangeLog just revert commit r184558 from FSF tree. For the record, this is the culprit: << commit 7ef88902afa64e783e9b612bf423fd9d12c668ff Author: davek Date: Fri Feb 24 16:17:01 2012 + libada/ChangeLog: * Makefile.in (bindir): Import from autoconf and pass down to submake. gcc/ada/ChangeLog: * gcc-interface/Makefile.in (WIN_SO_PREFIX [windows targets]): New Windows-specific make variable. (WIN_SO_INSTALL_DIR [windows targets]): Likewise. (install-gnatlib): Respect the above during installation when set, and also install any windows import library that has been built. (gnatlib-shared-win32): Use WIN_SO_PREFIX to name output DLL and also build a corresponding import library. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@184558 138bc75d-0d04-0410-96 >> Thanks. -- Pascal Obry -- gpg --keyserver keys.gnupg.net --recv-key F949BD3B
Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]
Back on this! It turn out that this breaks the shared Ada runtime. Indeed, exported variables on Ada packages in a DLLs are only accessible when linking against DLL (thanks to runtime pseudo reloc). With the patch applied it is not possible to build any Ada application using the shared runtime. This is a very serious problem, the patch should be reverted. Sorry for not having remembered before about this and why linking against DLL was so important! -- Pascal Obry -- gpg --keyserver keys.gnupg.net --recv-key F949BD3B
Re: [patch] Fix cygwin ada install [was Re: Yet another issue with gcc current trunk with ada on cygwin]
Dave, > Pascal, ping? Sorry for the delay, these message has fallen into the crack! Anyway, with these explanations I'm ok with the patch. -- Pascal Obry -- gpg --keyserver keys.gnupg.net --recv-key F949BD3B
