Re: [PATCH v2 0/8] Add Loongson SX/ASX instruction support to LoongArch target.

2023-07-18 Thread PanChenghui
Got it, I will fix the commit info in next version.

I haven't test GCC with these flags before, so I will try to build and
run regression test with BOOT_CFLAGS later. 

On Tue, 2023-07-18 at 20:26 +0800, Xi Ruoyao wrote:
> On Tue, 2023-07-18 at 19:06 +0800, Chenghui Pan wrote:
> > Lulu Cheng (8):
> >   LoongArch: Added Loongson SX vector directive compilation
> > framework.
> >   LoongArch: Added Loongson SX base instruction support.
> >   LoongArch: Added Loongson SX directive builtin function support.
> >   LoongArch: Added Loongson ASX vector directive compilation
> > framework.
> >   LoongArch: Added Loongson ASX base instruction support.
> >   LoongArch: Added Loongson ASX directive builtin function support.
> 
> Let's always use "Add".
> 
> >   LoongArch: Add Loongson SX directive test cases.
> >   LoongArch: Add Loongson ASX directive test cases.
> 
> Have you tested this series by bootstrapping and regtesting GCC with
> BOOT_CFLAGS="-O2 -ftree-vectorize -fno-vect-cost-model -mlasx" and
> BOOT_CFLAGS="-O3 -mlasx"?  This may catch some mistakes early.
> 
> And I'll rebuild the entire system with these GCC patches and -mlasx
> in
> Aug (after Glibc-2.38 release) as a field test too.
> 



Re: [PATCH v4 1/6] LoongArch: Add Loongson SX vector directive compilation framework.

2023-08-14 Thread PanChenghui
Yes, there's some confliction inside -mlsx/-mlasx option impl because
this patch set is based on the older option framework, we will try to
resolve this problem later.

On Tue, 2023-08-15 at 09:18 +0800, Xi Ruoyao wrote:
> I guess there is a merge conflict with Yujie's "-msimd=" patch and
> you
> may need to collaborate to resolve it.  Maybe just add -msimd in this
> series.
> 
> On Tue, 2023-08-15 at 09:05 +0800, Chenghui Pan wrote:
> > From: Lulu Cheng 
> > 
> > gcc/ChangeLog:
> > 
> > * config/loongarch/genopts/loongarch-strings: Add
> > compilation framework.
> > * config/loongarch/genopts/loongarch.opt.in: Ditto.
> > * config/loongarch/loongarch-c.cc
> > (loongarch_cpu_cpp_builtins): Ditto.
> > * config/loongarch/loongarch-def.c: Ditto.
> > * config/loongarch/loongarch-def.h (N_ISA_EXT_TYPES):
> > Ditto.
> > (ISA_EXT_SIMD_LSX): Ditto.
> > (N_SWITCH_TYPES): Ditto.
> > (SW_LSX): Ditto.
> > (struct loongarch_isa): Ditto.
> > * config/loongarch/loongarch-driver.cc (APPEND_SWITCH):
> > Ditto.
> > (driver_get_normalized_m_opts): Ditto.
> > * config/loongarch/loongarch-driver.h
> > (driver_get_normalized_m_opts): Ditto.
> > * config/loongarch/loongarch-opts.cc
> > (loongarch_config_target): Ditto.
> > (isa_str): Ditto.
> > * config/loongarch/loongarch-opts.h (ISA_HAS_LSX): Ditto.
> > * config/loongarch/loongarch-str.h (OPTSTR_LSX): Ditto.
> > * config/loongarch/loongarch.opt: Ditto.
> 
> /* snip */
>