[PATCH] mklog: automatically fill in generated entries

2021-02-07 Thread Mike Frysinger via Gcc-patches
contrib/ChangeLog:

* mklog.py (generated_files): New set.
(generate_changelog): Add entries based on generated_files.
---
 contrib/mklog.py | 5 +
 1 file changed, 5 insertions(+)

diff --git a/contrib/mklog.py b/contrib/mklog.py
index a70536a6849a..6509886741d7 100755
--- a/contrib/mklog.py
+++ b/contrib/mklog.py
@@ -55,6 +55,9 @@ bugzilla_url = 
'https://gcc.gnu.org/bugzilla/rest.cgi/bug?id=%s&;' \
 
 function_extensions = {'.c', '.cpp', '.C', '.cc', '.h', '.inc', '.def', '.md'}
 
+# NB: Makefile.in isn't listed as it's not always generated.
+generated_files = {'aclocal.m4', 'config.h.in', 'configure'}
+
 help_message = """\
 Generate ChangeLog template for PATCH.
 PATCH must be generated using diff(1)'s -up or -cp options
@@ -192,6 +195,8 @@ def generate_changelog(data, no_functions=False, 
fill_pr_titles=False):
 if new_path.startswith(changelog):
 new_path = new_path[len(changelog):].lstrip('/')
 out += '\t* %s: ...here.\n' % (new_path)
+elif os.path.basename(file.path) in generated_files:
+out += '\t* %s: Regenerate.\n' % (relative_path)
 else:
 if not no_functions:
 for hunk in file:
-- 
2.30.0



Re: [PATCH] mklog: automatically fill in generated entries

2021-02-08 Thread Mike Frysinger via Gcc-patches
On 08 Feb 2021 22:44, Joseph Myers wrote:
> On Sun, 7 Feb 2021, Mike Frysinger via Gcc-patches wrote:
> > +# NB: Makefile.in isn't listed as it's not always generated.
> > +generated_files = {'aclocal.m4', 'config.h.in', 'configure'}
> 
> libiberty/aclocal.m4 isn't a generated file either.

that is ... weird.  maybe it's a vintage thing.  any reason it needs
to stay this way ?  looks like it'd be trivial to switch it over to
acinclude.m4.
-mike


[PATCH] libiberty: autogenerate aclocal.m4

2021-02-13 Thread Mike Frysinger via Gcc-patches
Move custom macros to acinclude.m4 so we can autogenerate aclocal.m4
with aclocal.  This matches every other project in the tree.

libiberty/ChangeLog:

* Makefile.in (ACLOCAL, ACLOCAL_AMFLAGS, $(srcdir)/aclocal.m4): Define.
(configure_deps): Rename to ...
(aclocal_deps): ... this.  Replace aclocal.m4 with acinclude.m4.
($(srcdir)/configure): Replace $(configure_deps) with
$(srcdir)/aclocal.m4.
* aclocal.m4: Move libiberty macros to acinclude.m4, then regenerate.
* acinclude.m4: New file.
* configure: Regenerate.
---
 libiberty/Makefile.in  |  12 ++-
 libiberty/acinclude.m4 | 185 ++
 libiberty/aclocal.m4   | 198 +
 libiberty/configure|   3 -
 4 files changed, 215 insertions(+), 183 deletions(-)
 create mode 100644 libiberty/acinclude.m4

diff --git a/libiberty/Makefile.in b/libiberty/Makefile.in
index 788590957e17..4f1213b983b6 100644
--- a/libiberty/Makefile.in
+++ b/libiberty/Makefile.in
@@ -481,18 +481,24 @@ config.status: $(srcdir)/configure
$(SHELL) ./config.status --recheck
 
 AUTOCONF = autoconf
-configure_deps = $(srcdir)/aclocal.m4 \
+ACLOCAL = aclocal
+ACLOCAL_AMFLAGS = -I ../config -I ..
+aclocal_deps = \
$(srcdir)/../config/acx.m4 \
$(srcdir)/../config/cet.m4 \
$(srcdir)/../config/enable.m4 \
$(srcdir)/../config/no-executables.m4 \
$(srcdir)/../config/override.m4 \
$(srcdir)/../config/picflag.m4 \
-   $(srcdir)/../config/warnings.m4
+   $(srcdir)/../config/warnings.m4 \
+   $(srcdir)/acinclude.m4
 
-$(srcdir)/configure: @MAINT@ $(srcdir)/configure.ac $(configure_deps)
+$(srcdir)/configure: @MAINT@ $(srcdir)/configure.ac $(srcdir)/aclocal.m4
cd $(srcdir) && $(AUTOCONF)
 
+$(srcdir)/aclocal.m4: @MAINT@ $(aclocal_deps)
+   cd $(srcdir) && $(ACLOCAL) $(ACLOCAL_AMFLAGS)
+
 # Depending on config.h makes sure that config.status has been re-run
 # if needed.  This prevents problems with parallel builds, in case
 # subdirectories need to run config.status also.
diff --git a/libiberty/acinclude.m4 b/libiberty/acinclude.m4
new file mode 100644
index ..6db0e5085171
--- /dev/null
+++ b/libiberty/acinclude.m4
@@ -0,0 +1,185 @@
+dnl Copyright (C) 2000-2021 Free Software Foundation, Inc.
+dnl
+dnl GCC is free software; you can redistribute it and/or modify
+dnl it under the terms of the GNU General Public License as published by
+dnl the Free Software Foundation; either version 3, or (at your option)
+dnl any later version.
+dnl
+dnl GCC is distributed in the hope that it will be useful,
+dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
+dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+dnl GNU General Public License for more details.
+dnl
+dnl You should have received a copy of the GNU General Public License
+dnl along with GCC; see the file COPYING3.  If not see
+dnl .
+
+dnl See whether strncmp reads past the end of its string parameters.
+dnl On some versions of SunOS4 at least, strncmp reads a word at a time
+dnl but erroneously reads past the end of strings.  This can cause
+dnl a SEGV in some cases.
+AC_DEFUN([libiberty_AC_FUNC_STRNCMP],
+[AC_REQUIRE([AC_FUNC_MMAP])
+AC_CACHE_CHECK([for working strncmp], ac_cv_func_strncmp_works,
+[AC_TRY_RUN([
+/* Test by Jim Wilson and Kaveh Ghazi.
+   Check whether strncmp reads past the end of its string parameters. */
+#include 
+
+#ifdef HAVE_FCNTL_H
+#include 
+#endif
+
+#ifdef HAVE_SYS_MMAN_H
+#include 
+#endif
+
+#ifndef MAP_ANON
+#ifdef MAP_ANONYMOUS
+#define MAP_ANON MAP_ANONYMOUS
+#else
+#define MAP_ANON MAP_FILE
+#endif
+#endif
+
+#ifndef MAP_FILE
+#define MAP_FILE 0
+#endif
+#ifndef O_RDONLY
+#define O_RDONLY 0
+#endif
+
+#define MAP_LEN 0x1
+
+main ()
+{
+#if defined(HAVE_MMAP) || defined(HAVE_MMAP_ANYWHERE)
+  char *p;
+  int dev_zero;
+
+  dev_zero = open ("/dev/zero", O_RDONLY);
+  if (dev_zero < 0)
+exit (1);
+
+  p = (char *) mmap (0, MAP_LEN, PROT_READ|PROT_WRITE,
+MAP_ANON|MAP_PRIVATE, dev_zero, 0);
+  if (p == (char *)-1)
+p = (char *) mmap (0, MAP_LEN, PROT_READ|PROT_WRITE,
+  MAP_ANON|MAP_PRIVATE, -1, 0);
+  if (p == (char *)-1)
+exit (2);
+  else
+{
+  char *string = "__si_type_info";
+  char *q = (char *) p + MAP_LEN - strlen (string) - 2;
+  char *r = (char *) p + 0xe;
+
+  strcpy (q, string);
+  strcpy (r, string);
+  strncmp (r, q, 14);
+}
+#endif /* HAVE_MMAP || HAVE_MMAP_ANYWHERE */
+  exit (0);
+}
+], ac_cv_func_strncmp_works=yes, ac_cv_func_strncmp_works=no,
+  ac_cv_func_strncmp_works=yes)
+rm -f core core.* *.core])
+if test $ac_cv_func_strncmp_works = no ; then
+  AC_LIBOBJ([strncmp])
+fi
+])
+
+dnl See if errno must be declared even when  is included.
+AC_DEFUN([libiberty_AC_DECLARE_ERRNO],
+[AC_CACHE_CHECK(whether errno must be declared, libiberty_cv

[PATCH] gitignore: ignore generated dejagnu test files treewide

2021-02-14 Thread Mike Frysinger via Gcc-patches
These files are never commited, and are generated by most testsuites,
so ignore them.

ChangeLog:

* .gitignore: Ignore generated dejagnu test files.
---
 .gitignore | 5 +
 1 file changed, 5 insertions(+)

diff --git a/.gitignore b/.gitignore
index 382e2def731e..2d316e0bf881 100644
--- a/.gitignore
+++ b/.gitignore
@@ -66,3 +66,8 @@ stamp-*
 /mpc*
 /gmp*
 /isl*
+
+site.bak
+site.exp
+*.log
+*.sum
-- 
2.30.0



Re: [PATCH] libiberty: autogenerate aclocal.m4

2021-02-20 Thread Mike Frysinger via Gcc-patches
On 16 Feb 2021 11:54, Jeff Law wrote:
> On 2/13/21 7:32 PM, Mike Frysinger via Gcc-patches wrote:
> > Move custom macros to acinclude.m4 so we can autogenerate aclocal.m4
> > with aclocal.  This matches every other project in the tree.
> >
> > libiberty/ChangeLog:
> >
> > * Makefile.in (ACLOCAL, ACLOCAL_AMFLAGS, $(srcdir)/aclocal.m4): Define.
> > (configure_deps): Rename to ...
> > (aclocal_deps): ... this.  Replace aclocal.m4 with acinclude.m4.
> > ($(srcdir)/configure): Replace $(configure_deps) with
> > $(srcdir)/aclocal.m4.
> > * aclocal.m4: Move libiberty macros to acinclude.m4, then regenerate.
> > * acinclude.m4: New file.
> > * configure: Regenerate.
> OK for the trunk.
> 
> Do you have commit privs or do you need someone to commit for you?

thanks, i've pushed it now
-mike


Re: V3 [PATCH 3/5] Support the PGO build for binutils+gdb

2021-02-27 Thread Mike Frysinger via Gcc-patches
On 19 Dec 2020 10:10, H.J. Lu via Gdb-patches wrote:
> --- a/Makefile.in
> +++ b/Makefile.in
>
> +PGO_BUILD_TRAINING_FLAGS_TO_PASS = \
> + PGO_BUILD_TRAINING=yes \
> + CFLAGS_FOR_TARGET="$(PGO_BUILD_TRAINING_CFLAGS)" \
> + CXXFLAGS_FOR_TARGET="$(PGO_BUILD_TRAINING_CXXFLAGS)"
> +
> +# Ignore "make check" errors in PGO training runs.
> +PGO_BUILD_TRAINING_MFLAGS = -i

these lines are in Makefile.in but not Makefile.tpl.  so regenerating
the file causes them to be removed.  can you take a look please ?

$ autogen --version
autogen (GNU AutoGen) 5.18.16
$ autogen Makefile.def
$ git diff
diff --git a/Makefile.in b/Makefile.in
index 0a64fc10e5b0..63565ad525b9 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -437,13 +437,9 @@ PGO_BUILD_TRAINING_CFLAGS:= \
 PGO_BUILD_TRAINING_CXXFLAGS:= \
$(filter-out -specs=%,$(PGO_BUILD_TRAINING_CXXFLAGS))
 PGO_BUILD_TRAINING_FLAGS_TO_PASS = \
-   PGO_BUILD_TRAINING=yes \
CFLAGS_FOR_TARGET="$(PGO_BUILD_TRAINING_CFLAGS)" \
CXXFLAGS_FOR_TARGET="$(PGO_BUILD_TRAINING_CXXFLAGS)"
 
-# Ignore "make check" errors in PGO training runs.
-PGO_BUILD_TRAINING_MFLAGS = -i
-
 # Additional PGO and LTO compiler options to use profiling data for the
 # PGO build.
 PGO_BUILD_USE_FLAGS_TO_PASS = \
@@ -1054,7 +1050,6 @@ all:
$(PGO_BUILD_GEN_FLAGS_TO_PASS) all-host all-target \
 @if pgo-build
&& $(MAKE) $(RECURSE_FLAGS_TO_PASS) \
-   $(PGO_BUILD_TRAINING_MFLAGS) \
$(PGO_BUILD_TRAINING_FLAGS_TO_PASS) \
$(PGO_BUILD_TRAINING) \
&& $(MAKE) $(RECURSE_FLAGS_TO_PASS) clean \
-mike


[PATCH] sim: drop dep on configure-gdb

2021-03-04 Thread Mike Frysinger via Gcc-patches
I'm not entirely sure why this is here since the sim doesn't use
anything from the gdb/ dir directly, and the commit that added it
included a bunch more changes and doesn't seem to call out this
dep specifically.

ChangeLog:

* Makefile.def: Remove all-sim dependency on configure-gdb.
* Makefile.in: Regenerated.
---
 Makefile.def | 1 -
 Makefile.in  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Makefile.def b/Makefile.def
index 3e38f61193ff..df8ccfb24c3d 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -547,7 +547,6 @@ dependencies = { module=all-sim; on=all-libiberty; };
 dependencies = { module=all-sim; on=all-bfd; };
 dependencies = { module=all-sim; on=all-opcodes; };
 dependencies = { module=all-sim; on=all-readline; };
-dependencies = { module=all-sim; on=configure-gdb; };
 
 // Other host modules.
 dependencies = { module=all-fastjar; on=all-zlib; };
diff --git a/Makefile.in b/Makefile.in
index 03785200dc71..047be0255e26 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -61522,7 +61522,6 @@ install-strip-sid: maybe-install-strip-tcl
 install-sid: maybe-install-tk
 install-strip-sid: maybe-install-strip-tk
 all-sim: maybe-all-readline
-all-sim: maybe-configure-gdb
 all-fastjar: maybe-all-build-texinfo
 all-libctf: all-libiberty
 all-stage1-libctf: all-stage1-libiberty
-- 
2.30.0



[PATCH] sim: leverage gnulib

2021-05-28 Thread Mike Frysinger via Gcc-patches
We use getline, so leverage gnulib to provide fallback implementation.

ChangeLog:

* configure.ac: Add gnulib to configdirs for sim.
* configure: Regenerate.
---
 configure| 3 +++
 configure.ac | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/configure b/configure
index 3715d169dbfe..1224fc4039ec 100755
--- a/configure
+++ b/configure
@@ -9520,6 +9520,9 @@ case " ${configdirs} " in
   *\ gdbserver\ *)
 configdirs="${configdirs} gnulib gdbsupport"
 ;;
+  *\ sim\ *)
+configdirs="${configdirs} gnulib"
+;;
 esac
 
 # Strip out unwanted targets.
diff --git a/configure.ac b/configure.ac
index 626e2106cba7..66d637d70dc5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2849,6 +2849,9 @@ case " ${configdirs} " in
   *\ gdbserver\ *)
 configdirs="${configdirs} gnulib gdbsupport"
 ;;
+  *\ sim\ *)
+configdirs="${configdirs} gnulib"
+;;
 esac
 
 # Strip out unwanted targets.
-- 
2.31.1



Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure

2021-04-26 Thread Mike Frysinger via Gcc-patches
On 26 Apr 2021 19:32, Joseph Myers wrote:
> On Mon, 26 Apr 2021, Nick Clifton via Gcc-patches wrote:
> >   Given that gcc, gdb and now binutils are all now requiring C99 as a
> >   minimum version of C, are there any objections to updating
> >   configure.ac to reflect this ?
> 
> This isn't an objection, since upgrading auto* for the toolchain can be 
> complicated, but note that AC_PROG_CC_C99 is obsolete in Autoconf 2.70 and 
> instead AC_PROG_CC enables C11 mode if supported.  (So moving to the 
> latest Autoconf and Automake releases would supersede this change.)

considering how long it took before we adopted 2.69, seems unlikely we can
upgrade to 2.70.  plus, i think there was a flurry of regression fixes for
2.70, and ideally we'd get a 2.71 ?

as long as we have 2.69, we should move to AC_PROG_CC_C99 in all projects.
-mike


[PATCH] sim: depend on gnulib

2021-05-07 Thread Mike Frysinger via Gcc-patches
We're going to start using gnulib in the sim, so make sure it exists.

ChangeLog:

* Makefile.def: Add configure-sim dependency on all-gnulib.
* Makefile.in: Regenerated.
---
 Makefile.def | 1 +
 Makefile.in  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Makefile.def b/Makefile.def
index df8ccfb24c3d..2029ff3a72af 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -541,6 +541,7 @@ dependencies = { module=install-strip-sid; 
on=install-strip-tcl; };
 dependencies = { module=install-sid; on=install-tk; };
 dependencies = { module=install-strip-sid; on=install-strip-tk; };
 
+dependencies = { module=configure-sim; on=all-gnulib; };
 dependencies = { module=configure-sim; on=configure-intl; };
 dependencies = { module=all-sim; on=all-intl; };
 dependencies = { module=all-sim; on=all-libiberty; };
diff --git a/Makefile.in b/Makefile.in
index 047be0255e26..1a08f3bd376a 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -61521,6 +61521,7 @@ install-sid: maybe-install-tcl
 install-strip-sid: maybe-install-strip-tcl
 install-sid: maybe-install-tk
 install-strip-sid: maybe-install-strip-tk
+configure-sim: maybe-all-gnulib
 all-sim: maybe-all-readline
 all-fastjar: maybe-all-build-texinfo
 all-libctf: all-libiberty
-- 
2.31.1



[PATCH] config: delete unused sim macros

2021-05-11 Thread Mike Frysinger via Gcc-patches
Nothing in gcc or binutils or gdb or anything anywhere uses these.

config/

* acinclude.m4 (CYG_AC_PATH_SIM, CYG_AC_PATH_DEVO): Delete.
---
 config/acinclude.m4 | 102 
 1 file changed, 102 deletions(-)

diff --git a/config/acinclude.m4 b/config/acinclude.m4
index 8242b2c7a8ac..0abccafa0353 100644
--- a/config/acinclude.m4
+++ b/config/acinclude.m4
@@ -373,88 +373,6 @@ fi
 AC_SUBST(INTLLIB)
 ])
 
-dnl 
-dnl Find the simulator library.
-AC_DEFUN([CYG_AC_PATH_SIM], [
-dirlist=".. ../../ ../../../ ../../../../ ../../../../../ ../../../../../../ 
../../../../../../.. ../../../../../../../.. ../../../../../../../../.. 
../../../../../../../../../.. ../../../../../../../../../.."
-case "$target_cpu" in
-powerpc)   target_dir=ppc ;;
-sparc*)target_dir=erc32 ;;
-mips*) target_dir=mips ;;
-*) target_dir=$target_cpu ;;
-esac
-dnl First look for the header file
-AC_MSG_CHECKING(for the simulator header file)
-AC_CACHE_VAL(ac_cv_c_simh,[
-for i in $dirlist; do
-if test -f "${srcdir}/$i/include/remote-sim.h" ; then
-   ac_cv_c_simh=`(cd ${srcdir}/$i/include; ${PWDCMD-pwd})`
-   break
-fi
-done
-])
-if test x"${ac_cv_c_simh}" != x; then
-SIMHDIR="-I${ac_cv_c_simh}"
-AC_MSG_RESULT(${ac_cv_c_simh})
-else
-AC_MSG_RESULT(none)
-fi
-AC_SUBST(SIMHDIR)
-
-dnl See whether it's a devo or Foundry branch simulator
-AC_MSG_CHECKING(Whether this is a devo simulator )
-AC_CACHE_VAL(ac_cv_c_simdevo,[
-CPPFLAGS="$CPPFLAGS $SIMHDIR"
-AC_EGREP_HEADER([SIM_DESC sim_open.*struct _bfd], remote-sim.h,
-ac_cv_c_simdevo=yes,
-ac_cv_c_simdevo=no)
-])
-if test x"$ac_cv_c_simdevo" = x"yes" ; then
-AC_DEFINE(HAVE_DEVO_SIM)
-fi
-AC_MSG_RESULT(${ac_cv_c_simdevo})
-AC_SUBST(HAVE_DEVO_SIM)
-
-dnl Next look for the library
-AC_MSG_CHECKING(for the simulator library)
-AC_CACHE_VAL(ac_cv_c_simlib,[
-for i in $dirlist; do
-if test -f "$i/sim/$target_dir/Makefile" ; then
-   ac_cv_c_simlib=`(cd $i/sim/$target_dir; ${PWDCMD-pwd})`
-fi
-done
-])
-if test x"${ac_cv_c_simlib}" != x; then
-SIMLIB="-L${ac_cv_c_simlib}"
-else
-AC_MSG_RESULT(none)
-dnl FIXME: this is kinda bogus, cause umtimately the TM will build
-dnl all the libraries for several architectures. But for now, this
-dnl will work till then.
-dnl AC_MSG_CHECKING(for the simulator installed with the compiler 
libraries)
-dnl Transform the name of the compiler to it's cross variant, unless
-dnl CXX is set. This is also what CXX gets set to in the generated
-dnl Makefile.
-CROSS_GCC=`echo gcc | sed -e "s/^/$target/"`
-
-dnl Get G++'s full path to libgcc.a
-changequote(,)
-gccpath=`${CROSS_GCC} --print-libgcc | sed -e 
's:[a-z0-9A-Z\.\-]*/libgcc.a::' -e 's:lib/gcc-lib/::'`lib
-changequote([,])
-if test -f $gccpath/libsim.a -o -f $gccpath/libsim.so ; then
-ac_cv_c_simlib="$gccpath/"
-SIMLIB="-L${ac_cv_c_simlib}"
-   AC_MSG_RESULT(${ac_cv_c_simlib})
-else
-AM_CONDITIONAL(PSIM, test x$psim = xno)
-   SIMLIB=""
-   AC_MSG_RESULT(none)
-dnl ac_cv_c_simlib=none
-fi
-fi
-AC_SUBST(SIMLIB)
-])
-
 dnl 
 dnl Find the libiberty library.
 AC_DEFUN([CYG_AC_PATH_LIBIBERTY], [
@@ -476,26 +394,6 @@ fi
 AC_SUBST(LIBIBERTY)
 ])
 
-dnl 
-AC_DEFUN([CYG_AC_PATH_DEVO], [
-AC_MSG_CHECKING(for devo headers in the source tree)
-dirlist=".. ../../ ../../../ ../../../../ ../../../../../ ../../../../../../ 
../../../../../../.. ../../../../../../../.. ../../../../../../../../.. 
../../../../../../../../../.."
-AC_CACHE_VAL(ac_cv_c_devoh,[
-for i in $dirlist; do
-if test -f "${srcdir}/$i/include/remote-sim.h" ; then
-   ac_cv_c_devoh=`(cd ${srcdir}/$i/include; ${PWDCMD-pwd})`
-fi
-done
-])
-if test x"${ac_cv_c_devoh}" != x; then
-DEVOHDIR="-I${ac_cv_c_devoh}"
-AC_MSG_RESULT(${ac_cv_c_devoh})
-else
-AC_MSG_RESULT(none)
-fi
-AC_SUBST(DEVOHDIR)
-])
-
 dnl 
 dnl Find all the ILU headers and libraries
 AC_DEFUN([CYG_AC_PATH_ILU], [
-- 
2.31.1



Re: [PATCH] config: delete unused sim macros

2021-05-18 Thread Mike Frysinger via Gcc-patches
On 13 May 2021 09:24, Jeff Law wrote:
> On 5/11/2021 10:28 PM, Mike Frysinger via Gcc-patches wrote:
> > Nothing in gcc or binutils or gdb or anything anywhere uses these.
> >
> > config/
> >
> > * acinclude.m4 (CYG_AC_PATH_SIM, CYG_AC_PATH_DEVO): Delete.
> 
> "DEVO", yea, that's old.  I had a slight concern CYG might refer to 
> Cygwin rather than Cygnus, but the comments reference old Cygnus 
> projects (Foundry).  However, just to be sure, I checked the 
> newlib-cygwin repo which has no references other than a clone of the 
> code you're removing.
> 
> OK for the trunk.

thanks.  did you happen to see this one too ?
https://gcc.gnu.org/pipermail/gcc-patches/2021-May/569894.html
-mike