Re: [PATCH v2 0/2] OpenRISC support for cmodel=large
Hi All, On 5/1/21 11:11 PM, Stafford Horne wrote: Changes from v1: - Added patch to enabled cmodle=large on crtstuff This series fixes some bugs found when linking large binaries, both in buildroot and glibc testing. Stafford Horne (2): or1k: Add mcmodel option to handle large GOTs or1k: Use cmodel=large when building crtstuff gcc/config/or1k/or1k-opts.h | 30 ++ gcc/config/or1k/or1k.c| 11 +-- gcc/config/or1k/or1k.h| 7 +++ gcc/config/or1k/or1k.opt | 19 +++ gcc/doc/invoke.texi | 12 +++- libgcc/config.host| 4 ++-- libgcc/config/or1k/t-crtstuff | 2 ++ 7 files changed, 80 insertions(+), 5 deletions(-) create mode 100644 gcc/config/or1k/or1k-opts.h create mode 100644 libgcc/config/or1k/t-crtstuff I've tested this patchset and works as expected. It fixed libgeos build failure in conjunction with: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3c3de29b048bca6b4aa4235c647b9328e71801b6 Hope this helps to commit it upstream since I still don't see it, or am I wrong? Best regards -- Giulio Benetti Benetti Engineering sas
Re: [PATCH v2 0/2] OpenRISC support for cmodel=large
On 8/15/21 12:03 AM, Stafford Horne wrote: On Sat, Aug 14, 2021 at 11:01:16PM +0200, Giulio Benetti wrote: Hi All, On 5/1/21 11:11 PM, Stafford Horne wrote: Changes from v1: - Added patch to enabled cmodle=large on crtstuff This series fixes some bugs found when linking large binaries, both in buildroot and glibc testing. Stafford Horne (2): or1k: Add mcmodel option to handle large GOTs or1k: Use cmodel=large when building crtstuff gcc/config/or1k/or1k-opts.h | 30 ++ gcc/config/or1k/or1k.c| 11 +-- gcc/config/or1k/or1k.h| 7 +++ gcc/config/or1k/or1k.opt | 19 +++ gcc/doc/invoke.texi | 12 +++- libgcc/config.host| 4 ++-- libgcc/config/or1k/t-crtstuff | 2 ++ 7 files changed, 80 insertions(+), 5 deletions(-) create mode 100644 gcc/config/or1k/or1k-opts.h create mode 100644 libgcc/config/or1k/t-crtstuff I've tested this patchset and works as expected. It fixed libgeos build failure in conjunction with: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3c3de29b048bca6b4aa4235c647b9328e71801b6 Hope this helps to commit it upstream since I still don't see it, or am I wrong? You are not wrong, I did not push the changed to GCC yet. I will do soon. Ah ok, you're the maintainer :-) I thought there was someone else who needed to push it :-) Best regards -- Giulio Benetti Benetti Engineering sas
Re: [PATCH v2 0/2] OpenRISC support for cmodel=large
On 8/15/21 12:25 AM, Stafford Horne wrote: On Sun, Aug 15, 2021 at 12:05:37AM +0200, Giulio Benetti wrote: On 8/15/21 12:03 AM, Stafford Horne wrote: On Sat, Aug 14, 2021 at 11:01:16PM +0200, Giulio Benetti wrote: Hi All, On 5/1/21 11:11 PM, Stafford Horne wrote: Changes from v1: - Added patch to enabled cmodle=large on crtstuff This series fixes some bugs found when linking large binaries, both in buildroot and glibc testing. Stafford Horne (2): or1k: Add mcmodel option to handle large GOTs or1k: Use cmodel=large when building crtstuff gcc/config/or1k/or1k-opts.h | 30 ++ gcc/config/or1k/or1k.c| 11 +-- gcc/config/or1k/or1k.h| 7 +++ gcc/config/or1k/or1k.opt | 19 +++ gcc/doc/invoke.texi | 12 +++- libgcc/config.host| 4 ++-- libgcc/config/or1k/t-crtstuff | 2 ++ 7 files changed, 80 insertions(+), 5 deletions(-) create mode 100644 gcc/config/or1k/or1k-opts.h create mode 100644 libgcc/config/or1k/t-crtstuff I've tested this patchset and works as expected. It fixed libgeos build failure in conjunction with: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3c3de29b048bca6b4aa4235c647b9328e71801b6 Hope this helps to commit it upstream since I still don't see it, or am I wrong? You are not wrong, I did not push the changed to GCC yet. I will do soon. Ah ok, you're the maintainer :-) I thought there was someone else who needed to push it :-) Yeah, I pushed it now. Awesome, just seen now. Buildroot is already Openrisc toolchain bug free, only we have to wait for external toolchain to be rebuilt with suck patches. So we've got OpenRisc back to life :-). Thank you! -- Giulio Benetti Benetti Engineering sas
Re: [PATCH v2 0/2] OpenRISC support for cmodel=large
Hi Stafford, All, I've backported this patchset for Buildroot to versions: - 9.3.0 - 10.3.0 Does it make sense to send them? I don't know if those version will have minor versions where these backported patches can be applied. Best regards -- Giulio Benetti Benetti Engineering sas On 5/1/21 11:11 PM, Stafford Horne wrote: Changes from v1: - Added patch to enabled cmodle=large on crtstuff This series fixes some bugs found when linking large binaries, both in buildroot and glibc testing. Stafford Horne (2): or1k: Add mcmodel option to handle large GOTs or1k: Use cmodel=large when building crtstuff gcc/config/or1k/or1k-opts.h | 30 ++ gcc/config/or1k/or1k.c| 11 +-- gcc/config/or1k/or1k.h| 7 +++ gcc/config/or1k/or1k.opt | 19 +++ gcc/doc/invoke.texi | 12 +++- libgcc/config.host| 4 ++-- libgcc/config/or1k/t-crtstuff | 2 ++ 7 files changed, 80 insertions(+), 5 deletions(-) create mode 100644 gcc/config/or1k/or1k-opts.h create mode 100644 libgcc/config/or1k/t-crtstuff
Re: [PATCH v2 0/2] OpenRISC support for cmodel=large
Hi Stafford, All, > Il giorno 5 mag 2021, alle ore 08:30, Stafford Horne ha > scritto: > > On Mon, May 03, 2021 at 12:34:22PM +0200, Giulio Benetti wrote: >> Hi Stafford, All, >> >> I've backported this patchset for Buildroot to versions: >> - 9.3.0 >> - 10.3.0 >> >> Does it make sense to send them? I don't know if those version will have >> minor versions where these backported patches can be applied. > > Do you mean for me/you to send the backported GCC patches for GCC or > buildroot? I mean for GCC, I’ve already sent them for buildroot: https://patchwork.ozlabs.org/project/buildroot/list/?series=241844 > > I don't need backported versions of the toolchains and usually work off the > latest release/master. If someone wants them let me know. I was asking to know if newer minor versions of binutils and gcc will be released. If yes I could send your back ported patches here in the 2 mailing lists(binutils and gcc ones). Giulio Benetti > > -Stafford > >> Best regards >> -- >> Giulio Benetti >> Benetti Engineering sas >> >>> On 5/1/21 11:11 PM, Stafford Horne wrote: >>> Changes from v1: >>> - Added patch to enabled cmodle=large on crtstuff >>> >>> This series fixes some bugs found when linking large binaries, both in >>> buildroot >>> and glibc testing. >>> >>> Stafford Horne (2): >>> or1k: Add mcmodel option to handle large GOTs >>> or1k: Use cmodel=large when building crtstuff >>> >>> gcc/config/or1k/or1k-opts.h | 30 ++ >>> gcc/config/or1k/or1k.c| 11 +-- >>> gcc/config/or1k/or1k.h| 7 +++ >>> gcc/config/or1k/or1k.opt | 19 +++ >>> gcc/doc/invoke.texi | 12 +++- >>> libgcc/config.host| 4 ++-- >>> libgcc/config/or1k/t-crtstuff | 2 ++ >>> 7 files changed, 80 insertions(+), 5 deletions(-) >>> create mode 100644 gcc/config/or1k/or1k-opts.h >>> create mode 100644 libgcc/config/or1k/t-crtstuff >>>
