Mention of gcc 4.5 as first version with plugin support

2013-01-10 Thread Dave Johansen
Currently, the plugin documentation doesn't mention that it requires
gcc 4.5 or later. The patch to add this statement is attached and
here's the ChangeLog:

2013-01-10  Dave Johansen  

* gcc/doc/plugins.texi: Added gcc.4.5.0 or later note to
Plugins documentation.


plugins_doc.patch
Description: Binary data


Re: Mention of gcc 4.5 as first version with plugin support

2013-01-14 Thread Dave Johansen
On Mon, Jan 14, 2013 at 12:21 AM, Richard Biener
 wrote:
> On Fri, Jan 11, 2013 at 9:46 PM, Basile Starynkevitch
>  wrote:
>> On Fri, 11 Jan 2013 09:58:49 +0100
>> Dodji Seketeli  wrote:
>>
>>> Thank you Dave for this documentation patch that looks OK to my casual
>>> eyes.  Let's CC the documentation maintainers.
>>>
>>> Dave Johansen  a écrit:
>>>
>>> >
>>> > +GCC plugin support is available in GCC version 4.5.0 and
>>> > +later.
>>
>> Maybe we should say that a later version is preferable.
>> IIRC 4.5 plugin support was not very good -it was more an experimental stage 
>> than
>> anything else. I believe that we should not encourage people to write 
>> plugins against
>> 4.5.
>
> What's the value of documenting the availability of an unstable API in
> older versions
> of GCC?  Mind this documentation is version specific.
>
> Richard.
>
>> Cheers.
>>
>> --
>> Basile STARYNKEVITCH http://starynkevitch.net/Basile/
>> email: basilestarynkevitchnet mobile: +33 6 8501 2359
>> 8, rue de la Faiencerie, 92340 Bourg La Reine, France
>> *** opinions {are only mine, sont seulement les miennes} ***

My point wasn't to encourage people to use 4.5 for plugins, but just
to state when it became available. I was looking into
enabling/installing plugin support on RHEL 5/6 and spent several hours
trying to figure out why it wasn't available only to later find out
that it wasn't available in gcc 4.4. If the documentation had at least
mentioned the version when this feature was introduced, then it would
have saved me a lot of headache and is why I submitted this patch.