[Test] contrib/test_installed modified to set specific gcov
Hi, while running check for Android NDK compiler (I've used contrib/test_installed for it) I've noticed that gcov name is hardcoded in g++.dg/gcov/gcov.exp. All NDK x86 tools have prefix like i686-linux-android-, so testing will fail to spawn gcov. The patch attached introduces --with-gcov flag of contrib/test_installed so one could set specific gcov for testing. As workaround we could create a wrapper script named 'gcov' pointing to specific gcov in directory where GCC_UNDER_TEST resides. What do you think of this patch? Do you find it usefull? Thanks in advance. Anna gcov.p Description: Binary data
Re: [Test] contrib/test_installed modified to set specific gcov
Ping. 2012/8/8 Anna Tikhonova : > Hi, > > while running check for Android NDK compiler (I've used > contrib/test_installed for it) I've noticed that gcov name is > hardcoded in g++.dg/gcov/gcov.exp. > All NDK x86 tools have prefix like i686-linux-android-, so testing > will fail to spawn gcov. > > The patch attached introduces --with-gcov flag of > contrib/test_installed so one could set specific gcov for testing. > As workaround we could create a wrapper script named 'gcov' pointing > to specific gcov in directory where GCC_UNDER_TEST resides. > > What do you think of this patch? Do you find it usefull? Thanks in advance. > > Anna
Re: [Test] contrib/test_installed modified to set specific gcov
Ping one more time. 2012/8/10 Anna Tikhonova : > Ping. > > 2012/8/8 Anna Tikhonova : >> Hi, >> >> while running check for Android NDK compiler (I've used >> contrib/test_installed for it) I've noticed that gcov name is >> hardcoded in g++.dg/gcov/gcov.exp. >> All NDK x86 tools have prefix like i686-linux-android-, so testing >> will fail to spawn gcov. >> >> The patch attached introduces --with-gcov flag of >> contrib/test_installed so one could set specific gcov for testing. >> As workaround we could create a wrapper script named 'gcov' pointing >> to specific gcov in directory where GCC_UNDER_TEST resides. >> >> What do you think of this patch? Do you find it usefull? Thanks in advance. >> >> Anna
Re: [Test] contrib/test_installed modified to set specific gcov
Ok for trunk, 4.7, 4.6? 2012/8/17 Anna Tikhonova : > Ping one more time. > > 2012/8/10 Anna Tikhonova : >> Ping. >> >> 2012/8/8 Anna Tikhonova : >>> Hi, >>> >>> while running check for Android NDK compiler (I've used >>> contrib/test_installed for it) I've noticed that gcov name is >>> hardcoded in g++.dg/gcov/gcov.exp. >>> All NDK x86 tools have prefix like i686-linux-android-, so testing >>> will fail to spawn gcov. >>> >>> The patch attached introduces --with-gcov flag of >>> contrib/test_installed so one could set specific gcov for testing. >>> As workaround we could create a wrapper script named 'gcov' pointing >>> to specific gcov in directory where GCC_UNDER_TEST resides. >>> >>> What do you think of this patch? Do you find it usefull? Thanks in advance. >>> >>> Anna
[Test] Fix for PRPR53981
Hi all, I've fixed test which was failing on Android NDK testsuite/ChangeLog: 2012-07-20 Anna Tikhonova * gcc.dg/20020201-1.c: Include . Patch attached. Ok for trunk & 4.7? 20020201-1.p Description: Binary data
Re: [Test] Fix for PRPR53981
Anyone? Ping. 2012/7/20 Anna Tikhonova > > Hi all, > > I've fixed test which was failing on Android NDK > > testsuite/ChangeLog: > 2012-07-20 Anna Tikhonova > > * gcc.dg/20020201-1.c: Include . > > Patch attached. > > Ok for trunk & 4.7? >
Re: [Test] Fix for PRPR53981
Thanks! I've removed declarations. New patch attached. testsuite/ChangeLog: 2012-07-20 Anna Tikhonova * gcc.dg/20020201-1.c: Remove declarations for exit, abort, rand, srand. Include . 2012/7/24 Janis Johnson : > On 07/20/2012 05:23 AM, Anna Tikhonova wrote: >> Hi all, >> >> I've fixed test which was failing on Android NDK >> >> testsuite/ChangeLog: >> 2012-07-20 Anna Tikhonova >> >> * gcc.dg/20020201-1.c: Include . >> >> >> Patch attached. >> >> Ok for trunk & 4.7? > > OK if you remove the declarations for abort, exit, rand, and srand; > they're no longer needed. Presumably an alternate fix would be to > add "extern" before the declarations of rand and srand. > > Janis 20020201-1.p Description: Binary data
Re: [Test] Fix for PRPR53981
Kirill has already checked it in for me, thanks! Btw, I have FSF copyright assignment. Is it possible to commit this patch to 4.6 branch? Since current ndk is based on 4.6 2012/7/25 Janis Johnson : > On 07/25/2012 03:58 AM, Anna Tikhonova wrote: >> Thanks! >> >> I've removed declarations. New patch attached. > > You're not listed as "write after approval" in the MAINTAINERS > file; would you like me to check this in for you? > > I didn't check to see if you have an FSF copyright assignment > because this is a very small patch. > > Janis
Re: [Test] Fix for PRPR53981
Ping 2012/7/27 Anna Tikhonova : > Kirill has already checked it in for me, thanks! > Btw, I have FSF copyright assignment. > > Is it possible to commit this patch to 4.6 branch? Since current ndk > is based on 4.6 > > 2012/7/25 Janis Johnson : >> On 07/25/2012 03:58 AM, Anna Tikhonova wrote: >>> Thanks! >>> >>> I've removed declarations. New patch attached. >> >> You're not listed as "write after approval" in the MAINTAINERS >> file; would you like me to check this in for you? >> >> I didn't check to see if you have an FSF copyright assignment >> because this is a very small patch. >> >> Janis
