Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES
Hi Tom, Sorry for the delay, I've modified the patch to include config/pkg.m4. Aaron Use PKG_CHECK_MODULES to set debuginfod autoconf vars. Also add pkg.m4 to config/. ChangeLog: * config/debuginfod.m4: use PKG_CHECK_MODULES. * config/pkg.m4: New file. * configure: Rebuild. * configure.ac: Remove AC_DEBUGINFOD. ChangeLog/binutils: * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. * Makefile.in: Rebuild. * configure: Rebuild. * configure.ac: Include pkg.m4. * doc/Makefile.in: Rebuild. ChangeLog/gdb: * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. * configure: Rebuild. * configure.ac: Include pkg.m4. --- ChangeLog| 7 + binutils/ChangeLog | 8 + binutils/Makefile.am | 6 +- binutils/Makefile.in | 12 +- binutils/configure | 369 --- binutils/configure.ac| 1 + binutils/doc/Makefile.in | 8 +- config/debuginfod.m4 | 36 ++-- config/pkg.m4| 275 + configure| 139 +-- configure.ac | 4 - gdb/ChangeLog| 6 + gdb/Makefile.in | 2 +- gdb/configure| 365 +++--- gdb/configure.ac | 3 +- 15 files changed, 858 insertions(+), 383 deletions(-) create mode 100644 config/pkg.m4 diff --git a/ChangeLog b/ChangeLog index 49e9cf6148..e3a248c5fa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2020-07-16 Aaron Merey + + * config/debuginfod.m4: use PKG_CHECK_MODULES. + * config/pkg.m4: New file. + * configure: Rebuild. + * configure.ac: Remove AC_DEBUGINFOD. + 2020-07-04 Nick Clifton Binutils 2.35 branch created. diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 708be22cfd..679b22f1f9 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,11 @@ +2020-07-16 Aaron Merey + + * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. + * Makefile.in: Rebuild. + * configure: Rebuild. + * configure.ac: Include pkg.m4. + * doc/Makefile.in: Rebuild. + 2020-07-14 Claudiu Zissulescu * testsuite/binutils-all/arc/double_regs.s: New test. diff --git a/binutils/Makefile.am b/binutils/Makefile.am index 2ee1196790..fb54653fd3 100644 --- a/binutils/Makefile.am +++ b/binutils/Makefile.am @@ -53,7 +53,7 @@ AM_CFLAGS = $(WARN_CFLAGS) $(ZLIBINC) AM_CFLAGS_FOR_BUILD = $(WARN_CFLAGS_FOR_BUILD) $(ZLIBINC) LIBICONV = @LIBICONV@ -LIBDEBUGINFOD = @LIBDEBUGINFOD@ +DEBUGINFOD_LIBS = @DEBUGINFOD_LIBS@ # these two are almost the same program AR_PROG=ar @@ -252,7 +252,7 @@ objcopy_SOURCES = objcopy.c not-strip.c rename.c $(WRITE_DEBUG_SRCS) $(BULIBS) strings_SOURCES = strings.c $(BULIBS) readelf_SOURCES = readelf.c version.c unwind-ia64.c dwarf.c $(ELFLIBS) -readelf_LDADD = $(LIBINTL) $(LIBCTF_NOBFD) $(LIBIBERTY) $(ZLIB) $(LIBDEBUGINFOD) +readelf_LDADD = $(LIBINTL) $(LIBCTF_NOBFD) $(LIBIBERTY) $(ZLIB) $(DEBUGINFOD_LIBS) elfedit_SOURCES = elfedit.c version.c $(ELFLIBS) elfedit_LDADD = $(LIBINTL) $(LIBIBERTY) @@ -263,7 +263,7 @@ nm_new_SOURCES = nm.c $(BULIBS) objdump_SOURCES = objdump.c dwarf.c prdbg.c $(DEBUG_SRCS) $(BULIBS) $(ELFLIBS) EXTRA_objdump_SOURCES = od-xcoff.c -objdump_LDADD = $(OBJDUMP_PRIVATE_OFILES) $(OPCODES) $(LIBCTF) $(BFDLIB) $(LIBIBERTY) $(LIBINTL) $(LIBDEBUGINFOD) +objdump_LDADD = $(OBJDUMP_PRIVATE_OFILES) $(OPCODES) $(LIBCTF) $(BFDLIB) $(LIBIBERTY) $(LIBINTL) $(DEBUGINFOD_LIBS) objdump.@OBJEXT@:objdump.c if am__fastdepCC diff --git a/binutils/Makefile.in b/binutils/Makefile.in index 7ef2af4aff..951dd2c6d0 100644 --- a/binutils/Makefile.in +++ b/binutils/Makefile.in @@ -139,7 +139,7 @@ am__aclocal_m4_deps = $(top_srcdir)/../bfd/acinclude.m4 \ $(top_srcdir)/../config/zlib.m4 $(top_srcdir)/../libtool.m4 \ $(top_srcdir)/../ltoptions.m4 $(top_srcdir)/../ltsugar.m4 \ $(top_srcdir)/../ltversion.m4 $(top_srcdir)/../lt~obsolete.m4 \ - $(top_srcdir)/../bfd/version.m4 \ + $(top_srcdir)/../bfd/version.m4 $(top_srcdir)/../config/pkg.m4 \ $(top_srcdir)/../config/debuginfod.m4 \ $(top_srcdir)/configure.ac am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \ @@ -423,6 +423,8 @@ CPP = @CPP@ CPPFLAGS = @CPPFLAGS@ CYGPATH_W = @CYGPATH_W@ DATADIRNAME = @DATADIRNAME@ +DEBUGINFOD_CFLAGS = @DEBUGINFOD_CFLAGS@ +DEBUGINFOD_LIBS = @DEBUGINFOD_LIBS@ DEFS = @DEFS@ DEMANGLER_NAME = @DEMANGLER_NAME@ DEPDIR = @DEPDIR@ @@ -454,7 +456,6 @@ LDFLAGS = @LDFLAGS@ LEX = `if [ -f ../flex/flex ]; then echo ../flex/flex; else echo @LEX@; fi` LEXLIB = @LEXLIB@ LEX_OUTPUT_ROOT = @LEX_OUTPUT_ROOT@ -LIBDEBUGINFOD = @LIBDEBUGINFOD@ LIBICONV = @LIBICONV@ LIBINTL = @LIBINTL@ LIBINTL_DEP = @LIBINTL_DEP@ @@ -490,6 +491,9 @@ PACKAGE_TARNAME = @PACKAGE_TARNAME@ PACKAGE_URL = @PACKAGE_
Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES
On Fri, May 8, 2020 at 4:56 PM Tom Tromey wrote: > > > "Aaron" == Aaron Merey via Binutils writes: > > Aaron> * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. > Aaron> * aclocal.m4: Rebuild. > > Instead of inlining pkg.m4 into aclocal.m4, how about making > config/pkg.m4 and then using m4_include from gdb/acinclude.m4? > That's what gdb does for other shared m4 code. Resending the patch for this since my last attempt didn't seem to properly reply to Tom's email. From 7a7ea339a9f1ba879eb0f29ab68cbcb715d11391 Mon Sep 17 00:00:00 2001 From: Aaron Merey Date: Thu, 16 Jul 2020 16:02:43 -0400 Subject: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES Use PKG_CHECK_MODULES to set debuginfod autoconf vars. Also add pkg.m4 to config/. ChangeLog: * config/debuginfod.m4: use PKG_CHECK_MODULES. * config/pkg.m4: New file. * configure: Rebuild. * configure.ac: Remove AC_DEBUGINFOD. ChangeLog/binutils: * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. * Makefile.in: Rebuild. * configure: Rebuild. * configure.ac: Include pkg.m4. * doc/Makefile.in: Rebuild. ChangeLog/gdb: * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. * configure: Rebuild. * configure.ac: Include pkg.m4. --- ChangeLog| 7 + binutils/ChangeLog | 8 + binutils/Makefile.am | 6 +- binutils/Makefile.in | 12 +- binutils/configure | 369 --- binutils/configure.ac| 1 + binutils/doc/Makefile.in | 8 +- config/debuginfod.m4 | 36 ++-- config/pkg.m4| 275 + configure| 139 +-- configure.ac | 4 - gdb/ChangeLog| 6 + gdb/Makefile.in | 2 +- gdb/configure| 365 +++--- gdb/configure.ac | 3 +- 15 files changed, 858 insertions(+), 383 deletions(-) create mode 100644 config/pkg.m4 diff --git a/ChangeLog b/ChangeLog index 49e9cf6148..e3a248c5fa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2020-07-16 Aaron Merey + + * config/debuginfod.m4: use PKG_CHECK_MODULES. + * config/pkg.m4: New file. + * configure: Rebuild. + * configure.ac: Remove AC_DEBUGINFOD. + 2020-07-04 Nick Clifton Binutils 2.35 branch created. diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 708be22cfd..679b22f1f9 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,11 @@ +2020-07-16 Aaron Merey + + * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. + * Makefile.in: Rebuild. + * configure: Rebuild. + * configure.ac: Include pkg.m4. + * doc/Makefile.in: Rebuild. + 2020-07-14 Claudiu Zissulescu * testsuite/binutils-all/arc/double_regs.s: New test. diff --git a/binutils/Makefile.am b/binutils/Makefile.am index 2ee1196790..fb54653fd3 100644 --- a/binutils/Makefile.am +++ b/binutils/Makefile.am @@ -53,7 +53,7 @@ AM_CFLAGS = $(WARN_CFLAGS) $(ZLIBINC) AM_CFLAGS_FOR_BUILD = $(WARN_CFLAGS_FOR_BUILD) $(ZLIBINC) LIBICONV = @LIBICONV@ -LIBDEBUGINFOD = @LIBDEBUGINFOD@ +DEBUGINFOD_LIBS = @DEBUGINFOD_LIBS@ # these two are almost the same program AR_PROG=ar @@ -252,7 +252,7 @@ objcopy_SOURCES = objcopy.c not-strip.c rename.c $(WRITE_DEBUG_SRCS) $(BULIBS) strings_SOURCES = strings.c $(BULIBS) readelf_SOURCES = readelf.c version.c unwind-ia64.c dwarf.c $(ELFLIBS) -readelf_LDADD = $(LIBINTL) $(LIBCTF_NOBFD) $(LIBIBERTY) $(ZLIB) $(LIBDEBUGINFOD) +readelf_LDADD = $(LIBINTL) $(LIBCTF_NOBFD) $(LIBIBERTY) $(ZLIB) $(DEBUGINFOD_LIBS) elfedit_SOURCES = elfedit.c version.c $(ELFLIBS) elfedit_LDADD = $(LIBINTL) $(LIBIBERTY) @@ -263,7 +263,7 @@ nm_new_SOURCES = nm.c $(BULIBS) objdump_SOURCES = objdump.c dwarf.c prdbg.c $(DEBUG_SRCS) $(BULIBS) $(ELFLIBS) EXTRA_objdump_SOURCES = od-xcoff.c -objdump_LDADD = $(OBJDUMP_PRIVATE_OFILES) $(OPCODES) $(LIBCTF) $(BFDLIB) $(LIBIBERTY) $(LIBINTL) $(LIBDEBUGINFOD) +objdump_LDADD = $(OBJDUMP_PRIVATE_OFILES) $(OPCODES) $(LIBCTF) $(BFDLIB) $(LIBIBERTY) $(LIBINTL) $(DEBUGINFOD_LIBS) objdump.@OBJEXT@:objdump.c if am__fastdepCC diff --git a/binutils/Makefile.in b/binutils/Makefile.in index 7ef2af4aff..951dd2c6d0 100644 --- a/binutils/Makefile.in +++ b/binutils/Makefile.in @@ -139,7 +139,7 @@ am__aclocal_m4_deps = $(top_srcdir)/../bfd/acinclude.m4 \ $(top_srcdir)/../config/zlib.m4 $(top_srcdir)/../libtool.m4 \ $(top_srcdir)/../ltoptions.m4 $(top_srcdir)/../ltsugar.m4 \ $(top_srcdir)/../ltversion.m4 $(top_srcdir)/../lt~obsolete.m4 \ - $(top_srcdir)/../bfd/version.m4 \ + $(top_srcdir)/../bfd/version.m4 $(top_srcdir)/../config/pkg.m4 \ $(top_srcdir)/../config/debuginfod.m4 \ $(top_srcdir)/configure.ac am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \ @@ -423,6 +423,8 @@ CPP = @CPP@ CPPFLAGS = @CPPFLAGS@ CYGPATH_W = @CYGPATH_W@ DATADIRNAME = @DATADIRNAME@ +DEBUGINFOD_CFLAGS = @DEBUGINFOD_CFLAGS@ +DEBUGINFOD_LIBS = @DEBUGINFOD_LIBS@ DEFS = @DEFS@ DEMANGLE
Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES
On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey wrote:
>
> Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put
> the include
> Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac?
>
> Simon> Otherwise, from GDB's point of view I think it looks good, unless
> Simon> Tom has some things to add.
>
> I'm happy with it. Thanks for persevering.
Great. I can push to binutils-gdb but not gcc. Should I just push to
binutils-gdb for now or wait until the patch can be applied to both
repos at once?
Aaron
Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES
On Tue, Jul 21, 2020 at 2:11 PM Aaron Merey wrote:
>
> On Tue, Jul 21, 2020 at 11:20 AM Tom Tromey wrote:
> >
> > Simon> Since it's debuginfo.m4 that is using PKG_CHECK_MODULES, can you put
> > the include
> > Simon> of pkg.m4 in debuginfo.m4, instead of in {binutils,gdb}/configure.ac?
> >
> > Simon> Otherwise, from GDB's point of view I think it looks good, unless
> > Simon> Tom has some things to add.
> >
> > I'm happy with it. Thanks for persevering.
>
> Great. I can push to binutils-gdb but not gcc. Should I just push to
> binutils-gdb for now or wait until the patch can be applied to both
> repos at once?
I'm going to go ahead and push to binutils-gdb. Since these changes
should not affect gcc there shouldn't be any conflicts.
Aaron
Re: [PATCH] config/debuginfod.m4: Restore AC_CHECK_LIB check
On Mon, Jul 27, 2020 at 11:32 AM H.J. Lu wrote: > > On Sat, Jul 25, 2020 at 9:01 AM H.J. Lu wrote: > > This caused: > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=26301 > > > > It is quite normal to have debuginfod headers without libdebuginfod on > multilib OSes. Restore AC_CHECK_LIB to check if libdebuginfod exists. > And always define HAVE_LIBDEBUGINFOD to 0 or 1 for > > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > binutils/dwarf.h:#if HAVE_LIBDEBUGINFOD > binutils/objdump.c:#if HAVE_LIBDEBUGINFOD > binutils/objdump.c:#endif /* HAVE_LIBDEBUGINFOD */ > binutils/readelf.c:#if HAVE_LIBDEBUGINFOD > binutils/readelf.c:#endif /* HAVE_LIBDEBUGINFOD */ > gdb/top.c:#if HAVE_LIBDEBUGINFOD > > OK for master? Thanks for spotting this. Normally PKG_CHECH_MODULES would correctly detect whether the .so and header are installed and build accordingly, but when cross compiling the AC_CHECK_LIB may be needed. Aaron
[PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES
Hello, I'm not sure if this is the right mailing list for this patch but it modifies the top level directory of binutils-gdb for which I understand GCC to be the upstream. The purpose of this patch is to use PKG_CHECK_MODULES in config/debuginfod.m4 since debuginfod supports pkg-config. Otherwise the functionality of debuginfod.m4 is not changed by this patch. The rest of the changes involve renaming a debuginfod autoconf variable, removing an unnecessary call to AC_DEBUGINFOD in the top level configure.ac and the regeneration of files in gdb/, binutils/ and the top-level directory. Aaron Merey >From 31c1e42fb7185080a21673b8818dca01fc7d4d6f Mon Sep 17 00:00:00 2001 From: Aaron Merey Date: Fri, 1 May 2020 21:51:43 -0400 Subject: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES Use PKG_CHECK_MODULES to set the debuginfod autoconf vars. ChangeLog: * config/debuginfod.m4: use PKG_CHECK_MODULES. * configure: Rebuild. * configure.ac: Remove AC_DEBUGINFOD. ChangeLog/binutils: * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. * Makefile.in: Rebuild. * aclocal.m4: Rebuild. * configure: Rebuild. * doc/Makefile.in: Rebuild. ChangeLog/gdb: * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. * aclocal.m4: Rebuild. * configure: Rebuild. --- ChangeLog| 6 + binutils/ChangeLog | 9 + binutils/Makefile.am | 6 +- binutils/Makefile.in | 7 +- binutils/aclocal.m4 | 344 binutils/configure | 369 --- binutils/doc/Makefile.in | 6 +- config/debuginfod.m4 | 36 ++-- configure| 139 +-- configure.ac | 3 - gdb/ChangeLog| 7 + gdb/Makefile.in | 2 +- gdb/aclocal.m4 | 344 gdb/configure| 365 +++--- 14 files changed, 1266 insertions(+), 377 deletions(-) diff --git a/ChangeLog b/ChangeLog index f79c3e8fb5..49dca08bbc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2020-05-01 Aaron Merey + + * config/debuginfod.m4: use PKG_CHECK_MODULES. + * configure: Rebuild. + * configure.ac: Remove AC_DEBUGINFOD. + 2020-04-21 Stephen Casner PR 25830 diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 52082fcae1..da6ef9c8c3 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,12 @@ +ChangeLog/binutils: +2020-05-01 Aaron Merey + + * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. + * Makefile.in: Rebuild. + * aclocal.m4: Rebuild. + * configure: Rebuild. + * doc/Makefile.in: Rebuild. + 2020-05-01 Alan Modra Haim Shimonovich diff --git a/binutils/Makefile.am b/binutils/Makefile.am index e5cf5634a7..ecc5283b1b 100644 --- a/binutils/Makefile.am +++ b/binutils/Makefile.am @@ -53,7 +53,7 @@ AM_CFLAGS = $(WARN_CFLAGS) $(ZLIBINC) AM_CFLAGS_FOR_BUILD = $(WARN_CFLAGS_FOR_BUILD) $(ZLIBINC) LIBICONV = @LIBICONV@ -LIBDEBUGINFOD = @LIBDEBUGINFOD@ +DEBUGINFOD_LIBS = @DEBUGINFOD_LIBS@ # these two are almost the same program AR_PROG=ar @@ -247,7 +247,7 @@ objcopy_SOURCES = objcopy.c not-strip.c rename.c $(WRITE_DEBUG_SRCS) $(BULIBS) strings_SOURCES = strings.c $(BULIBS) readelf_SOURCES = readelf.c version.c unwind-ia64.c dwarf.c $(ELFLIBS) -readelf_LDADD = $(LIBINTL) $(LIBCTF_NOBFD) $(LIBIBERTY) $(ZLIB) $(LIBDEBUGINFOD) +readelf_LDADD = $(LIBINTL) $(LIBCTF_NOBFD) $(LIBIBERTY) $(ZLIB) $(DEBUGINFOD_LIBS) elfedit_SOURCES = elfedit.c version.c $(ELFLIBS) elfedit_LDADD = $(LIBINTL) $(LIBIBERTY) @@ -258,7 +258,7 @@ nm_new_SOURCES = nm.c $(BULIBS) objdump_SOURCES = objdump.c dwarf.c prdbg.c $(DEBUG_SRCS) $(BULIBS) $(ELFLIBS) EXTRA_objdump_SOURCES = od-xcoff.c -objdump_LDADD = $(OBJDUMP_PRIVATE_OFILES) $(OPCODES) $(LIBCTF) $(BFDLIB) $(LIBIBERTY) $(LIBINTL) $(LIBDEBUGINFOD) +objdump_LDADD = $(OBJDUMP_PRIVATE_OFILES) $(OPCODES) $(LIBCTF) $(BFDLIB) $(LIBIBERTY) $(LIBINTL) $(DEBUGINFOD_LIBS) objdump.@OBJEXT@:objdump.c if am__fastdepCC diff --git a/binutils/Makefile.in b/binutils/Makefile.in index ee6f267df9..7780729d69 100644 --- a/binutils/Makefile.in +++ b/binutils/Makefile.in @@ -420,6 +420,8 @@ CPP = @CPP@ CPPFLAGS = @CPPFLAGS@ CYGPATH_W = @CYGPATH_W@ DATADIRNAME = @DATADIRNAME@ +DEBUGINFOD_CFLAGS = @DEBUGINFOD_CFLAGS@ +DEBUGINFOD_LIBS = @DEBUGINFOD_LIBS@ DEFS = @DEFS@ DEMANGLER_NAME = @DEMANGLER_NAME@ DEPDIR = @DEPDIR@ @@ -451,7 +453,6 @@ LDFLAGS = @LDFLAGS@ LEX = `if [ -f ../flex/flex ]; then echo ../flex/flex; else echo @LEX@; fi` LEXLIB = @LEXLIB@ LEX_OUTPUT_ROOT = @LEX_OUTPUT_ROOT@ -LIBDEBUGINFOD = @LIBDEBUGINFOD@ LIBICONV = @LIBICONV@ LIBINTL = @LIBINTL@ LIBINTL_DEP = @LIBINTL_DEP@ @@ -487,6 +488,9 @@ PACKAGE_TARNAME = @PACKAGE_TARNAME@ PACKAGE_URL = @PACKAGE_URL@ PACKAGE_VERSION = @PACKA
Re: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES
On Tue, May 5, 2020 at 12:41 PM Jeff Law wrote: > > On Fri, 2020-05-01 at 22:29 -0400, Aaron Merey via Gcc-patches wrote: > > Hello, > > > > I'm not sure if this is the right mailing list for this patch but it > > modifies > > the top level directory of binutils-gdb for which I understand GCC to be the > > upstream. The purpose of this patch is to use PKG_CHECK_MODULES in > > config/debuginfod.m4 since debuginfod supports pkg-config. Otherwise the > > functionality of debuginfod.m4 is not changed by this patch. The rest of the > > changes involve renaming a debuginfod autoconf variable, removing an > > unnecessary call to AC_DEBUGINFOD in the top level configure.ac and the > > regeneration of files in gdb/, binutils/ and the top-level directory. > > > > Aaron Merey > > > > > > From 31c1e42fb7185080a21673b8818dca01fc7d4d6f Mon Sep 17 00:00:00 2001 > > From: Aaron Merey > > Date: Fri, 1 May 2020 21:51:43 -0400 > > Subject: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES > > > > Use PKG_CHECK_MODULES to set the debuginfod autoconf vars. > > > > ChangeLog: > > > > * config/debuginfod.m4: use PKG_CHECK_MODULES. > > * configure: Rebuild. > > * configure.ac: Remove AC_DEBUGINFOD. > > > > ChangeLog/binutils: > > > > * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. > > * Makefile.in: Rebuild. > > * aclocal.m4: Rebuild. > > * configure: Rebuild. > > * doc/Makefile.in: Rebuild. > > > > ChangeLog/gdb: > > > > * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. > > * aclocal.m4: Rebuild. > > * configure: Rebuild. > I can't ack the binutils or gdb directories. But the toplevel and config/ > bits > are fine. Do you have commit privs to the GCC repo? Do all these have to go > in > together? If so, that means we should coordinate commits and resyncing gcc, > gdb > and binutils I do not have commit privs to the GCC repo. It's better if all parts are committed at once to keep the files consistent. I've reattached the patch and cc'd gdb-patches. Binutils and GDB folks, do you have any concerns with this patch? Thanks, Aaron [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES Hello, I'm not sure if this is the right mailing list for this patch but it modifies the top level directory of binutils-gdb for which I understand GCC to be the upstream. The purpose of this patch is to use PKG_CHECK_MODULES in config/debuginfod.m4 since debuginfod supports pkg-config. Otherwise the functionality of debuginfod.m4 is not changed by this patch. The rest of the changes involve renaming a debuginfod autoconf variable, removing an unnecessary call to AC_DEBUGINFOD in the top level configure.ac and the regeneration of files in gdb/, binutils/ and the top-level directory. Aaron Merey From 31c1e42fb7185080a21673b8818dca01fc7d4d6f Mon Sep 17 00:00:00 2001 From: Aaron Merey Date: Fri, 1 May 2020 21:51:43 -0400 Subject: [PATCH] config/debuginfod.m4: Use PKG_CHECK_MODULES Use PKG_CHECK_MODULES to set the debuginfod autoconf vars. ChangeLog: * config/debuginfod.m4: use PKG_CHECK_MODULES. * configure: Rebuild. * configure.ac: Remove AC_DEBUGINFOD. ChangeLog/binutils: * Makefile.am: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. * Makefile.in: Rebuild. * aclocal.m4: Rebuild. * configure: Rebuild. * doc/Makefile.in: Rebuild. ChangeLog/gdb: * Makefile.in: Replace LIBDEBUGINFOD with DEBUGINFOD_LIBS. * aclocal.m4: Rebuild. * configure: Rebuild. --- ChangeLog| 6 + binutils/ChangeLog | 9 + binutils/Makefile.am | 6 +- binutils/Makefile.in | 7 +- binutils/aclocal.m4 | 344 binutils/configure | 369 --- binutils/doc/Makefile.in | 6 +- config/debuginfod.m4 | 36 ++-- configure| 139 +-- configure.ac | 3 - gdb/ChangeLog| 7 + gdb/Makefile.in | 2 +- gdb/aclocal.m4 | 344 gdb/configure| 365 +++--- 14 files changed, 1266 insertions(+), 377 deletions(-) diff --git a/ChangeLog b/ChangeLog index f79c3e8fb5..49dca08bbc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2020-05-01 Aaron Merey + + * config/debuginfod.m4: use PKG_CHECK_MODULES. + * configure: Rebuild. + * configure.ac: Remove AC_DEBUGINFOD. + 2020-04-21 Stephen Casner PR 25830 diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 52082fcae1..da6ef9c8c3 100644 --- a
