Re: [libquadmath, patch] Add logbq() to libquadmath
Dear FX, I looks OK to me - as you say, it's rather simple. Good for trunk. Thanks for the patch Paul On 9 August 2015 at 08:27, FX wrote: > ping > > In the apparent absence of the libquadmath maintainers, could a global > reviewer approve this rather simple patch, please? > > > >> The attached patch adds logbq() to libquadmath, with code lifted from glibc. >> It is made necessary by an upcoming patch for gfortran, adding full support >> for the IEEE modules on __float128, and requires logbq(). >> >> Bootstrapped and regtested on x86_64-apple-darwin14. >> OK to commit to trunk? >> >> FX > -- Outside of a dog, a book is a man's best friend. Inside of a dog it's too dark to read. Groucho Marx
Re: [libquadmath, patch] Add logbq() to libquadmath
On August 9, 2015 8:27:09 AM GMT+02:00, FX wrote: >ping > >In the apparent absence of the libquadmath maintainers, could a global >reviewer approve this rather simple patch, please? OK Richard > > >> The attached patch adds logbq() to libquadmath, with code lifted from >glibc. >> It is made necessary by an upcoming patch for gfortran, adding full >support for the IEEE modules on __float128, and requires logbq(). >> >> Bootstrapped and regtested on x86_64-apple-darwin14. >> OK to commit to trunk? >> >> FX
Re: [libquadmath, patch] Add logbq() to libquadmath
Sorry - I missed the "global" Paul On 9 August 2015 at 09:08, Paul Richard Thomas wrote: > Dear FX, > > I looks OK to me - as you say, it's rather simple. Good for trunk. > > Thanks for the patch > > Paul > > On 9 August 2015 at 08:27, FX wrote: >> ping >> >> In the apparent absence of the libquadmath maintainers, could a global >> reviewer approve this rather simple patch, please? >> >> >> >>> The attached patch adds logbq() to libquadmath, with code lifted from glibc. >>> It is made necessary by an upcoming patch for gfortran, adding full support >>> for the IEEE modules on __float128, and requires logbq(). >>> >>> Bootstrapped and regtested on x86_64-apple-darwin14. >>> OK to commit to trunk? >>> >>> FX >> > > > > -- > Outside of a dog, a book is a man's best friend. Inside of a dog it's > too dark to read. > > Groucho Marx -- Outside of a dog, a book is a man's best friend. Inside of a dog it's too dark to read. Groucho Marx
Re: [libquadmath, patch] Add logbq() to libquadmath
>> In the apparent absence of the libquadmath maintainers, could a global >> reviewer approve this rather simple patch, please? > > OK Committed as rev. 226748. Thanks. FX
Re: [Patch, Fortran, 66927, v1] [6 Regression] ICE in gfc_conf_procedure_call
Le 06/08/2015 14:00, Mikael Morin a écrit : Let me have a look at it. So, I've had a look at it. This is a pandora box that I don't want to open. So your change is OK. However, could you clarify the comment? Function calls returning a class object are either pointer or allocatable, so they don't call gfc_conv_expr_descriptor already, they aren't an exception... Mikael
Re: [PATCH opt*.awk/middle-end] Detect wrong arguments to EnabledBy
On Sat, 8 Aug 2015, Manuel López-Ibáñez wrote: > The argument to EnabledBy() must be one or more options with the > Common flag, otherwise the setting is silently ignored. This patch > detects this case when generating the options.c file and gives an > appropriate error. There were two options suffering from this: -Wchkp > is fixed by using LangEnabledBy instead, but -Wnull-dereference cannot > be enabled by -Wall or -Wextra because it triggers false positives > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16351#c35) > > Bootstrapped and regression tested on x86_64-linux-gnu. > > OK? OK with the requirement that the options have the Common flag being added to the documentation of EnabledBy in options.texi. -- Joseph S. Myers jos...@codesourcery.com
[fortran,committed] Restore libgfortran build on mingw32
Attached patch committed as rev. 226750, to restore build on mingw32. We don’t use umask() around mkstemp() on mingw32 because it doesn’t support the interesting permissions (“group” and “others”). FX mingw_umask.diff Description: Binary data mingw_umask.ChangeLog Description: Binary data
Re: [PATCH opt*.awk/middle-end] Detect wrong arguments to EnabledBy
On 9 August 2015 at 16:29, Joseph Myers wrote: > On Sat, 8 Aug 2015, Manuel López-Ibáñez wrote: > >> The argument to EnabledBy() must be one or more options with the >> Common flag, otherwise the setting is silently ignored. This patch >> detects this case when generating the options.c file and gives an >> appropriate error. There were two options suffering from this: -Wchkp >> is fixed by using LangEnabledBy instead, but -Wnull-dereference cannot >> be enabled by -Wall or -Wextra because it triggers false positives >> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=16351#c35) >> >> Bootstrapped and regression tested on x86_64-linux-gnu. >> >> OK? > > OK with the requirement that the options have the Common flag being added > to the documentation of EnabledBy in options.texi. Done. Committed as https://gcc.gnu.org/r226751 Cheers, Manuel.
Re: [PATCH][RTL-ifcvt] Make non-conditional execution if-conversion more aggressive
On Fri, Jul 31, 2015 at 7:26 PM, Jeff Law wrote: > > So there's a tight relationship between the implementation of > bbs_ok_for_cmove_arith and insn_valid_noce_process_p. If there wasn't, then > we'd probably be looking to use note_stores and note_uses. Perhaps I'm missing something, but what is wrong with using DF here instead of note_stores/note_uses? All the info on refs/mods of registers is available in the DF caches. Ciao! Steven
Re: [PATCH/libiberty] Remove use of strtod in libiberty/d-demangle.c
On 4 August 2015 at 16:23, Iain Buclaw wrote: > > Fixes PR 18669 raised against gdb/binutils. > > https://sourceware.org/bugzilla/show_bug.cgi?id=18669 > > While it is possible to roll our own strtod that handles hexadecimal > to float conversion, I'm no longer interested taking time out to > implement or maintain such a thing. So the next obvious thing to do > is nothing, which is what I've settled for. > > Regards > Iain. I'd like to ping this, as I am looking to get this downstreamed to GDB before the 7.10 release closes. Regards Iain.
