[Bug fortran/105371] New: The result of the merge function is different when it's type of parameters is the extensions type of derived type
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105371 Bug ID: 105371 Summary: The result of the merge function is different when it's type of parameters is the extensions type of derived type Product: gcc Version: 11.3.1 Status: UNCONFIRMED Severity: normal Priority: P3 Component: fortran Assignee: unassigned at gcc dot gnu.org Reporter: xudong@compiler-dev.com Target Milestone: --- Created attachment 52862 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52862&action=edit output Whether the mask is a constant or a variable causes inconsistent results of the merge function when it's type of parameters is the extensions type of derived type. 1.The mask is constant Program test00 Type t Integer :: c End Type Type,Extends(t) :: t2 Integer :: c2 End Type Class(t),Allocatable :: x,y,r logical :: ok = .true. x = t2(1,-1) y = t2(2,-2) r = merge (x,y,.true.) Select Type (z=>r) Type Is (t) print *,z%c Type Is (t2) print *,z%c,z%c2 End Select End Program 2. The mask is variable Program test01 Type t Integer :: c End Type Type,Extends(t) :: t2 Integer :: c2 End Type Class(t),Allocatable :: x,y,r logical :: ok = .true. integer :: i = 1 x = t2(1,-1) y = t2(2,-2) r = merge (x,y,i == 1) Select Type (z=>r) Type Is (t) print *,z%c Type Is (t2) print *,z%c,z%c2 End Select End Program
[Bug fortran/105372] New: The result of the merge function is different when it's type of parameters is the extensions type of derived type
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105372 Bug ID: 105372 Summary: The result of the merge function is different when it's type of parameters is the extensions type of derived type Product: gcc Version: 11.3.1 Status: UNCONFIRMED Severity: normal Priority: P3 Component: fortran Assignee: unassigned at gcc dot gnu.org Reporter: xudong@compiler-dev.com Target Milestone: --- Whether the mask is a constant or a variable causes inconsistent results of the merge function when it's type of parameters is the extensions type of derived type. 1.The mask is constant Program test00 Type t Integer :: c End Type Type,Extends(t) :: t2 Integer :: c2 End Type Class(t),Allocatable :: x,y,r logical :: ok = .true. x = t2(1,-1) y = t2(2,-2) r = merge (x,y,.true.) Select Type (z=>r) Type Is (t) print *,z%c Type Is (t2) print *,z%c,z%c2 End Select End Program 2. The mask is variable Program test01 Type t Integer :: c End Type Type,Extends(t) :: t2 Integer :: c2 End Type Class(t),Allocatable :: x,y,r logical :: ok = .true. integer :: i = 1 x = t2(1,-1) y = t2(2,-2) r = merge (x,y,i == 1) Select Type (z=>r) Type Is (t) print *,z%c Type Is (t2) print *,z%c,z%c2 End Select End Program
[Bug fortran/105371] The result of the merge function is different when it's type of parameters is the extensions type of derived type
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105371 --- Comment #3 from luoxudong --- (In reply to kargl from comment #2) > So, what do you believe the correct output should be? I think the output when the mask is constant should be consistent with the result when the mask is variable. 1.The output when the mask is constant : 1 2.The output when the mask is constant : 1 -1 the correct output should be : 1 -1
[Bug fortran/105371] The result of the merge function is different when it's type of parameters is the extensions type of derived type
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105371
--- Comment #6 from luoxudong ---
(In reply to Steve Kargl from comment #5)
> On Wed, Apr 27, 2022 at 07:51:10PM +, anlauf at gcc dot gnu.org wrote:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105371
> >
> > --- Comment #4 from anlauf at gcc dot gnu.org ---
> > The following untested hackish patch leads to the same answer for both
> > cases:
> >
> > diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
> > index 233cc42137f..abd93956217 100644
> > --- a/gcc/fortran/simplify.cc
> > +++ b/gcc/fortran/simplify.cc
> > @@ -4946,7 +4946,8 @@ gfc_simplify_merge (gfc_expr *tsource, gfc_expr
> > *fsource,
> > gfc_expr *mask)
> > {
> >result = gfc_copy_expr (mask->value.logical ? tsource : fsource);
> >/* Parenthesis is needed to get lower bounds of 1. */
> > - result = gfc_get_parentheses (result);
> > + if (result->rank)
> > + result = gfc_get_parentheses (result);
> >gfc_simplify_expr (result, 1);
> >return result;
> > }
> >
> > Thing is, I have to find a compiler that gives the result the reporter
> > expects.
> > E.g. Intel 2021.5 prints
> >
> >1
> >
> > for both cases.
> >
>
> Harald, thanks for looking at this!
>
> I don't use polymorphism in my codes.
>
> The "class(t) :: x, y, r" declaration clearly gives x, y, r the
> type type(t). I assume that the assignments "x = t2(1,-1)" and
> "y = t2(2,-2)" now change the dynamic type of x and y to type(t2).
> When "r = merge(x,y,...)" is evaluated and assigned the dynamic
> type of r becomes type(t2). So, the output should be
>
> 1 -1
>
> But, again, I'm not polymorphic.
(In reply to Steve Kargl from comment #5)
> On Wed, Apr 27, 2022 at 07:51:10PM +, anlauf at gcc dot gnu.org wrote:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105371
> >
> > --- Comment #4 from anlauf at gcc dot gnu.org ---
> > The following untested hackish patch leads to the same answer for both
> > cases:
> >
> > diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
> > index 233cc42137f..abd93956217 100644
> > --- a/gcc/fortran/simplify.cc
> > +++ b/gcc/fortran/simplify.cc
> > @@ -4946,7 +4946,8 @@ gfc_simplify_merge (gfc_expr *tsource, gfc_expr
> > *fsource,
> > gfc_expr *mask)
> > {
> >result = gfc_copy_expr (mask->value.logical ? tsource : fsource);
> >/* Parenthesis is needed to get lower bounds of 1. */
> > - result = gfc_get_parentheses (result);
> > + if (result->rank)
> > + result = gfc_get_parentheses (result);
> >gfc_simplify_expr (result, 1);
> >return result;
> > }
> >
> > Thing is, I have to find a compiler that gives the result the reporter
> > expects.
> > E.g. Intel 2021.5 prints
> >
> >1
> >
> > for both cases.
> >
>
> Harald, thanks for looking at this!
>
> I don't use polymorphism in my codes.
>
> The "class(t) :: x, y, r" declaration clearly gives x, y, r the
> type type(t). I assume that the assignments "x = t2(1,-1)" and
> "y = t2(2,-2)" now change the dynamic type of x and y to type(t2).
> When "r = merge(x,y,...)" is evaluated and assigned the dynamic
> type of r becomes type(t2). So, the output should be
>
> 1 -1
>
> But, again, I'm not polymorphic.
I think so,thanks a lot.
[Bug fortran/105371] The result of the merge function is different when it's type of parameters is the extensions type of derived type
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105371
--- Comment #7 from luoxudong ---
(In reply to Steve Kargl from comment #5)
> On Wed, Apr 27, 2022 at 07:51:10PM +, anlauf at gcc dot gnu.org wrote:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105371
> >
> > --- Comment #4 from anlauf at gcc dot gnu.org ---
> > The following untested hackish patch leads to the same answer for both
> > cases:
> >
> > diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
> > index 233cc42137f..abd93956217 100644
> > --- a/gcc/fortran/simplify.cc
> > +++ b/gcc/fortran/simplify.cc
> > @@ -4946,7 +4946,8 @@ gfc_simplify_merge (gfc_expr *tsource, gfc_expr
> > *fsource,
> > gfc_expr *mask)
> > {
> >result = gfc_copy_expr (mask->value.logical ? tsource : fsource);
> >/* Parenthesis is needed to get lower bounds of 1. */
> > - result = gfc_get_parentheses (result);
> > + if (result->rank)
> > + result = gfc_get_parentheses (result);
> >gfc_simplify_expr (result, 1);
> >return result;
> > }
> >
> > Thing is, I have to find a compiler that gives the result the reporter
> > expects.
> > E.g. Intel 2021.5 prints
> >
> >1
> >
> > for both cases.
> >
>
> Harald, thanks for looking at this!
>
> I don't use polymorphism in my codes.
>
> The "class(t) :: x, y, r" declaration clearly gives x, y, r the
> type type(t). I assume that the assignments "x = t2(1,-1)" and
> "y = t2(2,-2)" now change the dynamic type of x and y to type(t2).
> When "r = merge(x,y,...)" is evaluated and assigned the dynamic
> type of r becomes type(t2). So, the output should be
>
> 1 -1
>
> But, again, I'm not polymorphic.
But I still have a question, why does gfortran's code support polymorphic merge
when the mask is a logical variable? What is this code? I hope you can answer
it. Thank you very much
