[Bug target/63810] gcc sets incorrect macro for OS X deployment targets

2015-05-14 Thread vq at larryv dot me
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63810

--- Comment #20 from Lawrence Velázquez  ---
(In reply to Francois-Xavier Coudert from comment #18)
> (In reply to Lawrence Velázquez from comment #17)
> 
> Hey Lawrence, do you have a copyright assignment in place with the FSF? If
> so, please submit your trunk patch to gcc-patc...@gcc.gnu.org for review. If
> not, ask on the g...@gcc.gnu.org list for the paperwork to be sent to you.

Sorry, it took me a while to obtain the paperwork, and even longer to get
around to submitting it.

https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01377.html

[Bug target/63810] gcc sets incorrect macro for OS X deployment targets

2015-05-15 Thread vq at larryv dot me
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63810

--- Comment #23 from Lawrence Velázquez  ---
(In reply to Francois-Xavier Coudert from comment #21)
>  - version_as_legacy_macro(): same issue. Why do we need to handle major <=
> 9? You have rejected this possibility in macosx_version_as_macro() anyway.
> Simplify here also.

I don't see anything in version_as_legacy_macro() that specifically deals with
major <= 9. Could you point me to the offending code?

[Bug target/63810] gcc sets incorrect macro for OS X deployment targets

2015-05-20 Thread vq at larryv dot me
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63810

--- Comment #25 from Lawrence Velázquez  ---
(In reply to m...@gcc.gnu.org from comment #22)
> Though I approved it on list, you should feel free to update with the review
> points others have and post that version if you wish.

Re-roll posted:
https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01888.html

[Bug target/63810] gcc sets incorrect macro for OS X deployment targets

2015-05-28 Thread vq at larryv dot me
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63810

Lawrence Velázquez  changed:

   What|Removed |Added

  Attachment #34010|0   |1
is obsolete||

--- Comment #28 from Lawrence Velázquez  ---
Created attachment 35645
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35645&action=edit
backport to gcc-5-branch

[Bug target/63810] gcc sets incorrect macro for OS X deployment targets

2015-05-28 Thread vq at larryv dot me
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63810

Lawrence Velázquez  changed:

   What|Removed |Added

  Attachment #34011|0   |1
is obsolete||

--- Comment #29 from Lawrence Velázquez  ---
Created attachment 35646
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35646&action=edit
backport to gcc-4_9-branch

[Bug target/63810] gcc sets incorrect macro for OS X deployment targets

2015-05-28 Thread vq at larryv dot me
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63810

Lawrence Velázquez  changed:

   What|Removed |Added

  Attachment #34012|0   |1
is obsolete||

--- Comment #30 from Lawrence Velázquez  ---
Created attachment 35647
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35647&action=edit
backport to gcc-4_8-branch

[Bug target/63810] gcc sets incorrect macro for OS X deployment targets

2015-05-28 Thread vq at larryv dot me
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63810

--- Comment #31 from Lawrence Velázquez  ---
(In reply to m...@gcc.gnu.org from comment #27)
> Fixed in 6.0. Backports pre approved after bake time and testing that
> includes older darwins and ppc.

Thanks! I've attached updated patches against 4.8, 4.9, and 5.1, if you need
them.